Vm-dev December 2021

vm-dev@lists.squeakfoundation.org

15 participants
63 discussions

[OpenSmalltalk/opensmalltalk-vm] squeak.cog.spur_linux32ARMv6_202003021730 ---- seg fault on Cuis image (#597)
by Dr. Nicola Mingotti 20 Feb '22

20 Feb '22

Hi guys, i report you that according to my latest tests with Cuis on a BeagleBone Black the VM in the title is not running. But the latest-build does run ! bye ================= output ================================== root@beaglebone:~/cuis-project# ./sqcogspurlinuxhtRPi/squeak Cuis-Smalltalk-Dev/Cuis5.0-4834-32.image Segmentation fault Wed Sep 15 15:55:11 2021 /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730 [default: /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x00000000 r1 0x03004c70 r2 0x03004d30 r3 0x03004c70 r4 0x00000000 r5 0xbe952e90 r6 0x03012d40 r7 0x00224250 r8 0x00000000 r9 0x00000001 r10 0x00216288 fp 0x0021a278 ip 0x000005ec sp 0xbe950ea8 lr 0x00069290 pc 0x0004fe44 *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x4e)[0xb6d2a293] Smalltalk stack dump: 0xbe952e64 M SystemDictionary(Set)>findElementOrNil: 0x30cc098: a(n) SystemDictionary 0xbe952e90 I SystemDictionary(Dictionary)>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952ebc I SystemDictionary>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952f08 I [] in SystemDictionary>snapshot:andQuit:embedded:clearAllClassState: 0x30cc098: a(n) SystemDictionary 0x3a79bf0 s [] in BlockClosure>newProcess Most recent primitives maxIdentityHash identityHash at: at: stack page bytes 4096 available headroom 2788 minimum unused headroom 3776 (Segmentation fault) Aborted root@beaglebone:~/cuis-project# ========================================== -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/597

2 2

Re: [Vm-dev] ExtendedClipboardInterface and ClipboardExtendedPlugin state?
by Bernhard Pieber 04 Jan '22

04 Jan '22

Hi, Maybe this question is better asked on the vm-dev list. Does anyone know the status of the ClipboardExtendedPlugin? Happy New Year! Bernhard > Am 20.12.2021 um 09:38 schrieb Bernhard Pieber <bernhard(a)pieber.com>: > > Hi everyone, > > I tried to copy a form as PNG to the clipboard like this: > ExtendedClipboardInterface current addClipboardDataConvertFormToPNG: self imageForm > > This seems not to work correctly. If I paste it to TextEdit I get the binary data starting with PNG instead of the image itself. It looks as if the ClipboardExtendedPlugin is not loaded. The plugin seems to be in the current VM source (src/pugins/ClipboardExtendedPlugin), though. I am on macOS Big Sur 11.6.1. > > Should this work? I tried on Squeak 3.4, 4.6 and 5.3 but the ExtendedClipboardInterface is not loaded in these images. > > Cheers, > Bernhard

4 6

VM Maker: VMMakerUI-eem.55.mcz
by commits＠source.squeak.org 31 Dec '21

31 Dec '21

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.55.mcz ==================== Summary ==================== Name: VMMakerUI-eem.55 Author: eem Time: 31 December 2021, 12:29:30.198697 pm UUID: 5157ccdf-47ae-4d1b-80c9-f6087ba3f947 Ancestors: VMMakerUI-eem.54 StackInterpreterSimulator needs symbolic method... too =============== Diff against VMMakerUI-eem.54 =============== Item was changed: ----- Method: StackInterpreterSimulator>>utilitiesMenu: (in category '*VMMakerUI-user interface') ----- utilitiesMenu: aMenuMorph aMenuMorph add: 'toggle transcript' action: #toggleTranscript; add: 'clone VM' action: #cloneSimulationWindow; addLine; add: 'print ext head frame' action: #printExternalHeadFrame; add: 'print int head frame' action: #printHeadFrame; add: 'short print ext frame & callers' action: [self shortPrintFrameAndCallers: framePointer]; add: 'short print int frame & callers' action: [self shortPrintFrameAndCallers: localFP]; add: 'long print ext frame & callers' action: [self printFrameAndCallers: framePointer SP: stackPointer]; add: 'long print int frame & callers' action: [self printFrameAndCallers: localFP SP: localSP]; add: 'print frame...' action: [(self promptHex: 'print frame') ifNotNil: [:fp| self printFrame: fp]]; add: 'inspect frame...' action: [(self promptHex: 'inspect frame') ifNotNil: [:fp| (CogFrameInspector on: self) framePointer: fp; open]]; add: 'inspect head frame' action: [CogHeadFrameInspector openFor: self]; add: 'print call stack' action: #printCallStack; add: 'print stack call stack' action: #printStackCallStack; add: 'print stack call stack of...' action: [(self promptHex: 'frame') ifNotNil: [:fp| self printStackCallStackOf: fp]]; add: 'print call stack of...' action: [(self promptHex: 'context or process oop') ifNotNil: [:obj| self printCallStackOf: obj]]; add: 'print call stack of frame...' action: [(self promptHex: 'frame') ifNotNil: [:fp| self printCallStackFP: fp]]; add: 'print all stacks' action: #printAllStacks; add: 'write back local ptrs' action: [stackPointer := localSP. framePointer := localFP. instructionPointer := localIP. self writeBackHeadFramePointers]; add: 'print prim trace log' action: #dumpPrimTraceLog; addLine; add: 'print oop...' action: [(self promptHex: 'print oop') ifNotNil: [:oop| self printOop: oop]]; add: 'long print oop...' action: [(self promptHex: 'print oop') ifNotNil: [:oop| self longPrintOop: oop]]; add: 'print context...' action: [(self promptHex: 'print context') ifNotNil: [:oop| self printContext: oop]]; + add: 'symbolic method...' action: [(self promptHex: 'method bytecodes') ifNotNil: [:oop| self symbolicMethod: oop]]; addLine; add: 'inspect object memory' target: objectMemory action: #inspect; add: 'run leak checker' action: [Cursor execute showWhile: [self runLeakChecker]]; add: 'inspect interpreter' action: #inspect; addLine; add: 'set break count...' action: [|s| s := UIManager default request: 'break count (dec)'. s notEmpty ifTrue: [breakCount := Integer readFrom: s readStream]]; add: 'set break selector...' action: [|s| s := UIManager default request: 'break selector (MNU:foo for MNU)'. s notEmpty ifTrue: [(s size > 4 and: [s beginsWith: 'MNU:']) ifTrue: [self setBreakMNUSelector: (s allButFirst: 4)] ifFalse: [self setBreakSelector: s]]]; add: 'set break block...' action: [| s | s := UIManager default request: 'break block' initialAnswer: (breakBlock ifNotNil: [:bb| bb sourceString] ifNil: '[false]'). s notEmpty ifTrue: [self setBreakBlockFromString: s]]; add: 'turn valid exec ptrs assert o', (assertVEPAES ifTrue: ['ff'] ifFalse: ['n']) action: [assertVEPAES := assertVEPAES not]; add: 'click step' action: [self setClickStepBreakBlock]; add: (printSends ifTrue: ['no print sends'] ifFalse: ['print sends']) action: [self ensureDebugAtEachStepBlock. printSends := printSends not]; "currently printReturns does nothing" "add: (printReturns ifTrue: ['no print returns'] ifFalse: ['print returns']) action: [self ensureDebugAtEachStepBlock. printReturns := printReturns not];" add: (printBytecodeAtEachStep ifTrue: ['no print bytecode each bytecode'] ifFalse: ['print bytecode each bytecode']) action: [self ensureDebugAtEachStepBlock. printBytecodeAtEachStep := printBytecodeAtEachStep not]; add: (printFrameAtEachStep ifTrue: ['no print frame each bytecode'] ifFalse: ['print frame each bytecode']) action: [self ensureDebugAtEachStepBlock. printFrameAtEachStep := printFrameAtEachStep not]. ^aMenuMorph!

1 0

VM Maker: VMMaker.oscog-eem.3123.mcz
by commits＠source.squeak.org 30 Dec '21

30 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3123.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3123 Author: eem Time: 30 December 2021, 12:32:45.542223 pm UUID: 526712ee-56ba-4e11-bd69-6efed7cbb0d9 Ancestors: VMMaker.oscog-eem.3122 Cog: several places can use startPCOfMethodHeader: minstead of startPCOfMethod: convertToInterpreterFrame: needs to assert validInstructionPointer:..., not just evaluate it. Interpreter: better to test for a process having a context first in printAllStacks. =============== Diff against VMMaker.oscog-eem.3122 =============== Item was changed: ----- Method: CoInterpreter>>convertToInterpreterFrame: (in category 'frame access') ----- convertToInterpreterFrame: pcDelta "Convert the top machine code frame to an interpreter frame. Support for mustBeBoolean in the RegisterAllocatingCogit and for cloneContext: in shallowCopy when a code compaction is caused by machine code to bytecode pc mapping." | cogMethod methodHeader methodObj startBcpc | <var: 'cogMethod' type: #'CogBlockMethod *'> <var: 'p' type: #'char *'> self assert: (self isMachineCodeFrame: framePointer). cogMethod := self mframeCogMethod: framePointer. ((self mframeIsBlockActivation: framePointer) and: [cogMethod cmIsFullBlock not]) ifTrue: [methodHeader := (self cCoerceSimple: cogMethod cmHomeMethod to: #'CogMethod *') methodHeader. methodObj := (self cCoerceSimple: cogMethod cmHomeMethod to: #'CogMethod *') methodObject. startBcpc := cogMethod startpc] ifFalse: [methodHeader := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodHeader. methodObj := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodObject. + startBcpc := self startPCOfMethodHeader: methodHeader]. - startBcpc := self startPCOfMethod: methodObj]. "Map the machine code instructionPointer to the interpreter instructionPointer of the branch." instructionPointer := cogit bytecodePCFor: instructionPointer startBcpc: startBcpc in: cogMethod. instructionPointer := methodObj + objectMemory baseHeaderSize + instructionPointer - pcDelta - 1. "pre-decrement" + self assert: (self validInstructionPointer: instructionPointer inMethod: methodObj framePointer: framePointer). - self validInstructionPointer: instructionPointer inMethod: methodObj framePointer: framePointer. "Make space for the two extra fields in an interpreter frame" stackPointer to: framePointer + FoxMFReceiver by: objectMemory wordSize do: [:p| | oop | oop := objectMemory longAt: p. objectMemory longAt: p - objectMemory wordSize - objectMemory wordSize put: (objectMemory longAt: p)]. stackPointer := stackPointer - objectMemory wordSize - objectMemory wordSize. "Fill in the fields" objectMemory longAt: framePointer + FoxIFrameFlags put: (self encodeFrameFieldHasContext: (self mframeHasContext: framePointer) isBlock: (self mframeIsBlockActivation: framePointer) numArgs: cogMethod cmNumArgs); longAt: framePointer + FoxIFSavedIP put: instructionPointer; longAt: framePointer + FoxMethod put: methodObj. self setMethod: methodObj methodHeader: methodHeader! Item was changed: ----- Method: CoInterpreterPrimitives>>pcDataFor: (in category 'method introspection support') ----- pcDataFor: cogMethod <var: #cogMethod type: #'CogMethod *'> | cm nSlots nEntries data | cm := cogMethod methodObject. + nSlots := (objectMemory byteSizeOf: cm) - (self startPCOfMethodHeader: cogMethod methodHeader) * 2 + objectMemory minSlotsForShortening. - nSlots := (objectMemory byteSizeOf: cm) - (self startPCOfMethod: cm) * 2 + objectMemory minSlotsForShortening. data := objectMemory instantiateClass: (objectMemory splObj: ClassArray) indexableSize: nSlots. data ifNil: [^-1]. nEntries := cogit mapPCDataFor: cogMethod into: data. nEntries = 0 ifTrue: [^0]. nEntries < nSlots ifTrue: [objectMemory shorten: data toIndexableSize: nEntries]. ^data! Item was changed: ----- Method: CoInterpreterPrimitives>>picDataFor: (in category 'method introspection support') ----- picDataFor: cogMethod <var: #cogMethod type: #'CogMethod *'> | cm nSlots nEntries data | cm := cogMethod methodObject. + nSlots := (objectMemory byteSizeOf: cm) - (self startPCOfMethodHeader: cogMethod methodHeader) + objectMemory minSlotsForShortening. - nSlots := (objectMemory byteSizeOf: cm) - (self startPCOfMethod: cm) + objectMemory minSlotsForShortening. data := objectMemory instantiateClass: (objectMemory splObj: ClassArray) indexableSize: nSlots. data ifNil: [^-1]. nEntries := cogit picDataFor: cogMethod into: data. nEntries = 0 ifTrue: [^0]. nEntries < nSlots ifTrue: [objectMemory shorten: data toIndexableSize: nEntries]. ^data! Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveMinimumUnusedHeadroom (in category 'other primitives') ----- primitiveMinimumUnusedHeadroom <export: true> + self methodReturnInteger: self minimumUnusedHeadroom! - self methodReturnValue: (self integerObjectOf: self minimumUnusedHeadroom)! Item was changed: ----- Method: CogVMSimulator>>maybeCheckStackDepth:sp:pc: (in category 'debug support') ----- maybeCheckStackDepth: delta sp: sp pc: mcpc | asp bcpc startbcpc cogHomeMethod cogBlockMethod csp debugStackPointers | debugStackDepthDictionary ifNil: [^self]. (self isMachineCodeFrame: framePointer) ifFalse: [^self]. cogBlockMethod := self mframeCogMethod: framePointer. cogHomeMethod := self asCogHomeMethod: cogBlockMethod. debugStackPointers := debugStackDepthDictionary at: cogHomeMethod methodObject ifAbsentPut: [self debugStackPointersFor: cogHomeMethod methodObject]. startbcpc := cogHomeMethod = cogBlockMethod + ifTrue: [self startPCOfMethodHeader: cogHomeMethod methodHeader] - ifTrue: [self startPCOfMethod: cogHomeMethod methodObject] ifFalse: [self startPCOfClosure: (self pushedReceiverOrClosureOfFrame: framePointer)]. bcpc := cogit bytecodePCFor: mcpc startBcpc: startbcpc in: cogBlockMethod. self assert: bcpc ~= 0. ((cogBlockMethod ~= cogHomeMethod or: [cogBlockMethod cmIsFullBlock]) and: [cogit isNonLocalReturnPC: mcpc]) ifTrue: [| lastbcpc | "Method returns within a block (within an unwind-protect) must check the stack depth at the return, not the bytecode following, but the pc mapping maps to the bytecode following the return. lastBytecodePCForBlockAt:in: catches method returns at the end of a block, modifying the bcpc to that of the return. isNonLocalReturnPC: catches method returns not at the end. Assumes method return bytecodes are 1 bytecode long;a dodgy assumption, but good enough." lastbcpc := cogBlockMethod cmIsFullBlock ifTrue: [cogit endPCOf: cogHomeMethod methodObject] ifFalse: [cogit lastBytecodePCForBlockAt: startbcpc in: cogHomeMethod methodObject]. bcpc > lastbcpc ifTrue: [bcpc := lastbcpc]]. asp := self stackPointerIndexForFrame: framePointer WithSP: sp + objectMemory wordSize. csp := debugStackPointers at: bcpc ifAbsent: [-1]. "Compensate for some edge cases" asp - delta = csp ifTrue: ["Compensate for the implicit context receiver push in a trap bytecode with the absence of a continuation. Assumes trap bytecodes are 1 byte bytecodes." (SistaVM and: [cogit isTrapAt: mcpc]) ifTrue: [csp := csp + 1]. "Compensate lazily for absent receiver sends (cuz mapping is slow, even though incrememting csp is a dodgy idea)." (NewspeakVM and: [cogit isAbsentReceiverSendAt: mcpc in: cogHomeMethod]) ifTrue: [csp := debugStackPointers at: bcpc put: csp + 1]]. self assert: asp - delta + 1 = csp! Item was changed: ----- Method: Cogit>>collectCogMethodConstituent: (in category 'profiling primitives') ----- collectCogMethodConstituent: cogMethod "Answer a description of the mapping between machine code pointers and bytecode pointers for the Cog Method. First value is the address of the cog method. Following values are pairs of machine code pc and bytecode pc" <var: #cogMethod type: #'CogMethod *'> <var: #cogBlockMethod type: #'CogBlockMethod *'> | cm nSlots errCode cogBlockMethod address data | (cogMethod cmType = CMMethod) ifFalse: [^self positiveMachineIntegerFor: cogMethod asUnsignedInteger ]. cogBlockMethod := self cCoerceSimple: cogMethod to: #'CogBlockMethod *'. cogBlockMethod stackCheckOffset = 0 "isFrameless ?" ifTrue: [^self positiveMachineIntegerFor: cogMethod asUnsignedInteger]. cm := cogMethod methodObject. + nSlots := ((objectMemory byteSizeOf: cm) - (coInterpreter startPCOfMethodHeader: cm methodHeader)) * 2 + objectMemory minSlotsForShortening + 1."+1 for first address" - nSlots := ((objectMemory byteSizeOf: cm) - (coInterpreter startPCOfMethod: cm)) * 2 + objectMemory minSlotsForShortening + 1."+1 for first address" data := objectMemory instantiateClass: (objectMemory splObj: ClassArray) indexableSize: nSlots. data ifNil: [^nil]. coInterpreter pushRemappableOop: data. "The iteration assumes the object is the top remappable oop" address := (self positiveMachineIntegerFor: cogMethod asUnsignedInteger). address ifNil: [coInterpreter popRemappableOop. ^nil]. coInterpreter storePointerUnchecked: 0 ofObject: coInterpreter topRemappableOop withValue: address. cogConstituentIndex := 1. errCode := self mapFor: cogBlockMethod bcpc: (coInterpreter startPCOfMethod: cogMethod methodObject) performUntil: #collectCogConstituentFor:Annotation:Mcpc:Bcpc:Method: arg: cogMethod asVoidPointer. errCode ~= 0 ifTrue: [coInterpreter popRemappableOop. ^nil]. cogConstituentIndex < nSlots ifTrue: [objectMemory shorten: coInterpreter topRemappableOop toIndexableSize: cogConstituentIndex]. ^coInterpreter popRemappableOop.! Item was removed: - ----- Method: Cogit>>method:hasSameCodeAs: (in category 'garbage collection') ----- - method: methodA hasSameCodeAs: methodB - "For the purposes of become: see if the two methods are similar, i.e. can be safely becommed. - This is pretty strict. All literals and bytecodes must be identical. Only trailer bytes and header - flags can differ." - <inline: false> - | headerA headerB numLitsA endPCA | - headerA := objectMemory methodHeaderOf: methodA. - headerB := objectMemory methodHeaderOf: methodB. - numLitsA := objectMemory literalCountOfMethodHeader: headerA. - endPCA := self endPCOf: methodA. - ((coInterpreter argumentCountOfMethodHeader: headerA) ~= (coInterpreter argumentCountOfMethodHeader: headerB) - or: [(coInterpreter temporaryCountOfMethodHeader: headerA) ~= (coInterpreter temporaryCountOfMethodHeader: headerB) - or: [(coInterpreter primitiveIndexOfMethod: methodA header: headerA) ~= (coInterpreter primitiveIndexOfMethod: methodB header: headerB) - or: [numLitsA ~= (objectMemory literalCountOfMethodHeader: headerB) - or: [endPCA > (objectMemory numBytesOf: methodB)]]]]) ifTrue: - [^false]. - 1 to: numLitsA - 1 do: - [:li| - (objectMemory fetchPointer: li ofObject: methodA) ~= (objectMemory fetchPointer: li ofObject: methodB) ifTrue: - [^false]]. - (coInterpreter startPCOfMethod: methodA) to: endPCA do: - [:bi| - (objectMemory fetchByte: bi ofObject: methodA) ~= (objectMemory fetchByte: bi ofObject: methodB) ifTrue: - [^false]]. - ^true! Item was changed: ----- Method: Cogit>>method:hasSameCodeAs:checkPenultimate: (in category 'garbage collection') ----- method: methodA hasSameCodeAs: methodB checkPenultimate: comparePenultimateLiteral "For the purposes of become: see if the two methods are similar, i.e. can be safely becommed. This is pretty strict. All literals and bytecodes must be identical. Only trailer bytes and header flags can differ." <inline: false> | headerA headerB numLitsA endPCA | headerA := objectMemory methodHeaderOf: methodA. headerB := objectMemory methodHeaderOf: methodB. numLitsA := objectMemory literalCountOfMethodHeader: headerA. endPCA := self endPCOf: methodA. ((coInterpreter argumentCountOfMethodHeader: headerA) ~= (coInterpreter argumentCountOfMethodHeader: headerB) or: [(coInterpreter temporaryCountOfMethodHeader: headerA) ~= (coInterpreter temporaryCountOfMethodHeader: headerB) or: [(coInterpreter primitiveIndexOfMethod: methodA header: headerA) ~= (coInterpreter primitiveIndexOfMethod: methodB header: headerB) or: [numLitsA ~= (objectMemory literalCountOfMethodHeader: headerB) or: [endPCA > (objectMemory numBytesOf: methodB)]]]]) ifTrue: [^false]. 1 to: numLitsA - 1 do: [:li| (objectMemory fetchPointer: li ofObject: methodA) ~= (objectMemory fetchPointer: li ofObject: methodB) ifTrue: [(li < (numLitsA - 1) "If the method doesn't use the penultimate literal then don't fail the comparison." or: [comparePenultimateLiteral]) ifTrue: [^false]]]. + (coInterpreter startPCOfMethodHeader: headerA) to: endPCA do: - (coInterpreter startPCOfMethod: methodA) to: endPCA do: [:bi| (objectMemory fetchByte: bi ofObject: methodA) ~= (objectMemory fetchByte: bi ofObject: methodB) ifTrue: [^false]]. ^true! Item was changed: ----- Method: SimpleStackBasedCogit>>methodUsesPrimitiveErrorCode:header: (in category 'compile abstract instructions') ----- methodUsesPrimitiveErrorCode: aMethodObj header: aMethodHeader "Answer if aMethodObj contains a primitive and uses the primitive error code." <inline: true> ^(coInterpreter primitiveIndexOfMethod: aMethodObj header: aMethodHeader) > 0 and: [(coInterpreter longStoreBytecodeForHeader: aMethodHeader) = (objectMemory + fetchByte: (coInterpreter startPCOfMethodHeader: aMethodHeader) + (coInterpreter sizeOfCallPrimitiveBytecode: aMethodHeader) - fetchByte: (coInterpreter startPCOfMethod: aMethodObj) + (coInterpreter sizeOfCallPrimitiveBytecode: aMethodHeader) ofObject: aMethodObj)]! Item was changed: ----- Method: SistaCogit>>picDataFor:into: (in category 'method introspection') ----- picDataFor: cogMethod into: arrayObj "Collect the branch and send data for cogMethod, storing it into arrayObj." <api> <var: #cogMethod type: #'CogMethod *'> | errCode | cogMethod stackCheckOffset = 0 ifTrue: [^0]. introspectionDataIndex := counterIndex := 0. introspectionData := arrayObj. errCode := self mapFor: (self cCoerceSimple: cogMethod to: #'CogBlockMethod *') + bcpc: (coInterpreter startPCOfMethodHeader: cogMethod methodHeader) - bcpc: (coInterpreter startPCOfMethod: cogMethod methodObject) performUntil: #picDataFor:Annotation:Mcpc:Bcpc:Method: arg: cogMethod asVoidPointer. errCode ~= 0 ifTrue: [self assert: errCode = PrimErrNoMemory. ^-1]. cogMethod blockEntryOffset ~= 0 ifTrue: [errCode := self blockDispatchTargetsFor: cogMethod perform: #picDataForBlockEntry:Method: arg: cogMethod asInteger. errCode ~= 0 ifTrue: [self assert: errCode = PrimErrNoMemory. ^-1]]. ^introspectionDataIndex! Item was changed: ----- Method: SistaCogitClone>>picDataFor:into: (in category 'method introspection') ----- picDataFor: cogMethod into: arrayObj "Collect the branch and send data for cogMethod, storing it into arrayObj." <api> <var: #cogMethod type: #'CogMethod *'> | errCode | cogMethod stackCheckOffset = 0 ifTrue: [^0]. introspectionDataIndex := counterIndex := 0. introspectionData := arrayObj. errCode := self mapFor: (self cCoerceSimple: cogMethod to: #'CogBlockMethod *') + bcpc: (coInterpreter startPCOfMethodHeader: cogMethod methodHeader) - bcpc: (coInterpreter startPCOfMethod: cogMethod methodObject) performUntil: #picDataFor:Annotation:Mcpc:Bcpc:Method: arg: cogMethod asVoidPointer. errCode ~= 0 ifTrue: [self assert: errCode = PrimErrNoMemory. ^-1]. cogMethod blockEntryOffset ~= 0 ifTrue: [errCode := self blockDispatchTargetsFor: cogMethod perform: #picDataForBlockEntry:Method: arg: cogMethod asInteger. errCode ~= 0 ifTrue: [self assert: errCode = PrimErrNoMemory. ^-1]]. ^introspectionDataIndex! Item was changed: ----- Method: StackInterpreter>>methodUsesPrimitiveErrorCode: (in category 'primitive support') ----- methodUsesPrimitiveErrorCode: aMethodObj "Answer if aMethodObj contains a primitive and uses the primitive error code." <inline: true> | methodHeader | methodHeader := objectMemory methodHeaderOf: aMethodObj. ^(self primitiveIndexOfMethod: aMethodObj header: methodHeader) > 0 and: [(self longStoreBytecodeForHeader: methodHeader) = (objectMemory + fetchByte: (self startPCOfMethodHeader: methodHeader) + (self sizeOfCallPrimitiveBytecode: methodHeader) - fetchByte: (self startPCOfMethod: aMethodObj) + (self sizeOfCallPrimitiveBytecode: methodHeader) ofObject: aMethodObj)]! Item was changed: ----- Method: StackInterpreter>>printAllStacks (in category 'debug printing') ----- printAllStacks "Print all the stacks of all running processes, including those that are currently suspended." <export: true> "useful for VM debugging; use export: not api, so it will be accessible on win32 and won't be written to cointerp.h" | proc schedLists p processList linkedListClass minProcessInstSize processClass | <inline: false> proc := self activeProcess. "may not be an instance of process. may in exceptional circumstances be nilObject" self printNameOfClass: (objectMemory fetchClassOf: proc) count: 5; space; printHex: proc. self print: ' priority '; printNum: (self quickFetchInteger: PriorityIndex ofObject: proc); cr. framePointer ifNil: [self printProcessStack: proc] "at startup..." ifNotNil: [self printCallStack]. "first the current activation" schedLists := objectMemory fetchPointer: ProcessListsIndex ofObject: self schedulerPointer. linkedListClass := nil. "then the runnable processes" p := highestRunnableProcessPriority = 0 ifTrue: [objectMemory numSlotsOf: schedLists] ifFalse: [highestRunnableProcessPriority]. p - 1 to: 0 by: -1 do: [:pri| processList := objectMemory fetchPointer: pri ofObject: schedLists. (self isEmptyList: processList) ifFalse: [proc = objectMemory nilObject ifTrue: [proc := objectMemory fetchPointer: FirstLinkIndex ofObject: processList]. self cr; print: 'processes at priority '; printNum: pri + 1. self printProcsOnList: processList]. linkedListClass ifNil: [linkedListClass := objectMemory fetchClassOfNonImm: processList]]. linkedListClass ifNil: [linkedListClass := objectMemory superclassOf: objectMemory classSemaphore]. proc = objectMemory nilObject ifTrue: [self cr; print: 'Cannot find a runnable process. Cannot therefore determine class Process. Cannot therefore print suspended processes'. ^self]. self cr; print: 'suspended processes'. "Find the root of the Process hierarchy. It is the class, or superclass, of a process, that has inst size at least large enough to include myList" processClass := proc = objectMemory nilObject ifFalse: [objectMemory fetchClassOf: proc]. minProcessInstSize := MyListIndex + 1. [(objectMemory instanceSizeOf: (objectMemory superclassOf: processClass)) >= minProcessInstSize] whileTrue: [processClass := objectMemory superclassOf: processClass]. minProcessInstSize := objectMemory instanceSizeOf: processClass. "look for all subInstances of process that have a context as a suspendedContext and are on a list other than a LinkedList" objectMemory allObjectsDoSafely: [:obj| ((objectMemory isPointersNonImm: obj) and: [(objectMemory numSlotsOf: obj) >= minProcessInstSize + and: [(objectMemory isContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: obj)) + and: [self is: obj KindOfClass: processClass]]]) ifTrue: - and: [(self is: obj KindOfClass: processClass) - and: [objectMemory isContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: obj)]]]) ifTrue: [| myList myListClass | "Is the process waiting on some delaying list? This will be a subclass of LinkedList. If so, assume it is blocked on the list." myList := objectMemory fetchPointer: MyListIndex ofObject: obj. (myList ~= objectMemory nilObject and: [(myListClass := objectMemory fetchClassOfNonImm: myList) ~= linkedListClass and: [self is: myList KindOfClass: linkedListClass]]) ifTrue: [self printProcessStack: obj]]]! Item was changed: ----- Method: StackInterpreter>>startPCOfMethodHeader: (in category 'compiled methods') ----- startPCOfMethodHeader: methodHeader + <api> "Answer the zero-relative index to the initial byte for a method. Zero-relative version of CompiledMethod>>startpc." ^(objectMemory literalCountOfMethodHeader: methodHeader) + LiteralStart * objectMemory bytesPerOop!

1 0

VM Maker Inbox: VMMaker.oscog-dtl.3124.mcz
by commits＠source.squeak.org 27 Dec '21

27 Dec '21

David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3124.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3124 Author: dtl Time: 27 December 2021, 1:13:16.655501 pm UUID: c2f75042-e365-4331-893f-7c32080423ad Ancestors: VMMaker.oscog-dtl.3123 Support image formats 68533 and 7033. Add improvements suggested by Eliot. Add FormatNumberTests to verify format number reading and writing. Fix a bug exposed by the tests. =============== Diff against VMMaker.oscog-dtl.3123 =============== Item was added: + TestCase subclass: #FormatNumberTests + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Tests'! + + !FormatNumberTests commentStamp: 'dtl 12/27/2021 13:02' prior: 0! + FomatNumberTests verifies image format numbers as saved to or loaded from an image snapshot file. Requires package ImageFormat.! Item was added: + ----- Method: FormatNumberTests>>testImageFormatCog (in category 'tests') ----- + testImageFormatCog + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory). + self assert: 6505 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 6505 equals: (interp imageFormatVersionFromSnapshot: 6505) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6505 equals: interp imageFormatVersionForSnapshot. + self assert: 6505 equals: interp imageFormatVersion. + self assert: 6504 equals: (interp imageFormatVersionFromSnapshot: 6504) description: 'image format compatability version'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6505 equals: interp imageFormatVersionForSnapshot. + self assert: 6505 equals: interp imageFormatVersion. + + "multiple bytecode support is not provided for non-Spur images, but confirm that the support code has no ill effects" + self assert: 6505 equals: (interp imageFormatVersionFromSnapshot: 7017) description: 'hypothetical format 7017 does not exist in the wild'. + self assert: interp multipleBytecodeSetsActive. + self assert: 7017 equals: interp imageFormatVersionForSnapshot. "7017 does not exist in practice but is thoretically possible" + self assert: 6505 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver |interp readableFormat: ver ]. + self assert: #(6504 6505) equals: readableNumbers. + ! Item was added: + ----- Method: FormatNumberTests>>testImageFormatSpur32 (in category 'tests') ----- + testImageFormatSpur32 + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager MULTIPLEBYTECODESETS true). + self assert: 6521 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 6521 equals: (interp imageFormatVersionFromSnapshot: 6521) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6521 equals: interp imageFormatVersionForSnapshot. + self assert: 6521 equals: interp imageFormatVersion. + self assert: 6521 equals: (interp imageFormatVersionFromSnapshot: 7033) description: 'sets multipleBytecodSetsActive as side effect'. + self assert: interp multipleBytecodeSetsActive. + self assert: 7033 equals: interp imageFormatVersionForSnapshot. + self assert: 6521 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver | interp readableFormat: ver ]. + self assert: #(6521 7033) equals: readableNumbers. + ! Item was added: + ----- Method: FormatNumberTests>>testImageFormatSpur64 (in category 'tests') ----- + testImageFormatSpur64 + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur64BitMemoryManager MULTIPLEBYTECODESETS true). + self assert: 68021 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 68021 equals: (interp imageFormatVersionFromSnapshot: 68021) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 68021 equals: interp imageFormatVersionForSnapshot. + self assert: 68021 equals: interp imageFormatVersion. + self assert: 68021 equals: (interp imageFormatVersionFromSnapshot: 68533) description: 'sets multipleBytecodSetsActive as side effect'. + self assert: interp multipleBytecodeSetsActive. + self assert: 68533 equals: interp imageFormatVersionForSnapshot. + self assert: 68021 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver | interp readableFormat: ver ]. + self assert: #(68021 68533) equals: readableNumbers. + ! Item was changed: ----- Method: InterpreterPrimitives>>primitiveBytecodeSetsAvailable (in category 'other primitives') ----- primitiveBytecodeSetsAvailable "Answer the encoder names for the supported bytecode sets." <export: true> | encoderNames | argumentCount >0 ifTrue: [^self primitiveFailFor: PrimErrBadNumArgs]. encoderNames := self instantiateClass: self classArray indexableSize: 3. self storePointer: 0 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3'). self storePointer: 1 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3PlusClosures'). self storePointer: 2 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForSistaV1'). + self methodReturnValue: encoderNames. - self pop: 1 thenPush: encoderNames. ! Item was changed: ----- Method: InterpreterPrimitives>>primitiveMultipleBytecodeSetsActive (in category 'other primitives') ----- primitiveMultipleBytecodeSetsActive "Given one boolean parameter, set multipleBytecodeSetsActive to inform the VM that alternate bytecode sets such as SistaV1 are now in use and that the image format number should be updated accordingly. With zero parameters, answer the current value of multipleBytecodeSetsActive." <export: true> argumentCount >1 ifTrue: [^self primitiveFailFor: PrimErrBadNumArgs]. argumentCount = 1 ifTrue: [self stackTop = objectMemory trueObject ifTrue: [self cppIf: MULTIPLEBYTECODESETS ifTrue: [multipleBytecodeSetsActive := true] ifFalse: [^self primitiveFailFor: PrimErrUnsupported]] ifFalse: [self stackTop = objectMemory falseObject ifTrue: [multipleBytecodeSetsActive := false] ifFalse:[^self primitiveFailFor: PrimErrBadArgument]]]. + self methodReturnBool: multipleBytecodeSetsActive. - multipleBytecodeSetsActive - ifTrue: [self pop: argumentCount + 1 thenPush: objectMemory trueObject] - ifFalse: [self pop: argumentCount + 1 thenPush: objectMemory falseObject]. ! Item was added: + ----- Method: StackInterpreter>>imageFormatVersionForSnapshot (in category 'image save/restore') ----- + imageFormatVersionForSnapshot + "Snapshot image format includes the state of multipleBytecodeSetsActive, + set the bit when writing a snapshot" + multipleBytecodeSetsActive + ifTrue: [^self imageFormatVersion bitOr: MultipleBytecodeSetsBitmask] + ifFalse: [^self imageFormatVersion]. + ! Item was added: + ----- Method: StackInterpreter>>imageFormatVersionFromSnapshot: (in category 'image save/restore') ----- + imageFormatVersionFromSnapshot: imageVersion + "Snapshot image format includes the state of multipleBytecodeSetsActive, + mask it out when checking compatibility with this interpreter" + + multipleBytecodeSetsActive := (imageVersion bitAnd: MultipleBytecodeSetsBitmask) ~= 0. + ^imageVersion bitAnd: ( -1 - MultipleBytecodeSetsBitmask) + ! Item was changed: ----- Method: StackInterpreter>>readableFormat: (in category 'image save/restore') ----- readableFormat: imageVersion "Anwer true if images of the given format are readable by this interpreter. Allows a virtual machine to accept selected older image formats." <api> + ^objectMemory hasSpurMemoryManagerAPI + ifTrue: [(self imageFormatVersionFromSnapshot: imageVersion) = self imageFormatVersion] + ifFalse: [imageVersion = self imageFormatVersion + or: [imageVersion = self imageFormatCompatibilityVersion "Float words in BigEndian order"]]. + ! - ^ (self imageFormatVersion = (imageVersion bitAnd: ( -1 - MultipleBytecodeSetsBitmask))) "Ignore multiple bytecode support identifier" - or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" - and: [imageVersion = self imageFormatCompatibilityVersion]] "Float words in BigEndian order"! Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | <var: 'f' type: #sqImageFile> <var: 'headerStart' type: #squeakFileOffsetType> <var: 'sCWIfn' type: #'void *'> <var: 'imageName' declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. "local constants" headerStart := 0. headerSize := objectMemory wordSize * 16. "64 or 128; header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. (self invalidSqImageFile: f) ifTrue: "could not open the image file for writing" [^self primitiveFailFor: PrimErrOperationFailed]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. + self putWord32: self imageFormatVersionForSnapshot toFile: f. - multipleBytecodeSetsActive - ifTrue: [self putWord32: (self imageFormatVersion bitOr: MultipleBytecodeSetsBitmask) toFile: f] - ifFalse: [self putWord32: self imageFormatVersion toFile: f]. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. self putLong: self getSnapshotScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f! Item was added: + ----- Method: StackInterpreterSimulator>>multipleBytecodeSetsActive (in category 'accessing') ----- + multipleBytecodeSetsActive + ^multipleBytecodeSetsActive!

1 0

VM Maker Inbox: VMMaker.oscog-dtl.3123.mcz
by commits＠source.squeak.org 26 Dec '21

26 Dec '21

David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-dtl.3123.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3123 Author: dtl Time: 26 December 2021, 12:55:15.357105 pm UUID: a0d4db62-a6ac-4d9c-ba51-5eec2ce0c415 Ancestors: VMMaker.oscog-eem.3122 Support image formats 68533 and 7033. Let the image inform the VM that alternate bytecodes either are or are not in use, and remember the setting when writing or reading the image format number in a shapshot file header. Also support testing the current value of multipleBytecodeSetsActive, and listing the encoder names of supported bytecode sets. Adds two primitives: primitiveMultipleBytecodeSetsActive "Given one boolean parameter, set multipleBytecodeSetsActive to inform the VM that alternate bytecode sets such as SistaV1 are now in use and that the image format number should be updated accordingly. With zero parameters, answer the current value of multipleBytecodeSetsActive." primitiveBytecodeSetsAvailable "Answer the encoder names for the supported bytecode sets." =============== Diff against VMMaker.oscog-eem.3122 =============== Item was changed: VMClass subclass: #InterpreterPrimitives + instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask multipleBytecodeSetsActive' - instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! !InterpreterPrimitives commentStamp: 'eem 9/23/2021 13:20' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables argumentCount <Integer> eventTraceMask <Integer> exceptionPC <Integer> ffiExceptionResponse <Integer> inFFIFlags <Integer> messageSelector <Integer> newMethod <Integer> nextProfileTick <Integer> objectMemory <ObjectMemory> (simulation only) preemptionYields <Boolean> primFailCode <Integer> secondaryErrorCode <Integer> profileMethod <Integer> profileProcess <Integer> profileSemaphore <Integer> sHEAFn <Integer> argumentCount - the number of arguments of the current message eventTraceMask - a bit mask corresponding to the Event type codes in sq.h that decides what events are printed in primitiveGetNextEvent exceptionPC - the pc of an exception for an exception reporting primitive failure such as PrimErrFFIException ffiExceptionResponse - controls system response to exceptions during FFI calls. See primitiveFailForFFIException:at: inFFIFlags - flags recording currently only whether the system is in an FFI call messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode - primitive success/failure flag, 0 for success, otherwise the reason code for failure profileMethod - the primitive method active when the last profile sample was taken (if any) profileProcess - the process active when the last profile sample was taken profileSemaphore - the semaphore to be signalled when a profile sample is taken; if nil disables profiling secondaryErrorCode - a 64-bit value settable for clonable primitive failures (PrimErrOSError, PrimErrFFIException et al) profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached secondaryErrorCode - an additional value associated with various primitive failures sHEAFn - the function to call to check if access to the envronment should be granted to primitiveGetenv! Item was added: + ----- Method: InterpreterPrimitives>>primitiveBytecodeSetsAvailable (in category 'other primitives') ----- + primitiveBytecodeSetsAvailable + "Answer the encoder names for the supported bytecode sets." + <export: true> + | encoderNames | + argumentCount >0 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + encoderNames := self instantiateClass: self classArray indexableSize: 3. + self storePointer: 0 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3'). + self storePointer: 1 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3PlusClosures'). + self storePointer: 2 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForSistaV1'). + self pop: 1 thenPush: encoderNames. + ! Item was added: + ----- Method: InterpreterPrimitives>>primitiveMultipleBytecodeSetsActive (in category 'other primitives') ----- + primitiveMultipleBytecodeSetsActive + "Given one boolean parameter, set multipleBytecodeSetsActive to inform + the VM that alternate bytecode sets such as SistaV1 are now in use and + that the image format number should be updated accordingly. With zero + parameters, answer the current value of multipleBytecodeSetsActive." + + <export: true> + argumentCount >1 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + argumentCount = 1 + ifTrue: [self stackTop = objectMemory trueObject + ifTrue: [self cppIf: MULTIPLEBYTECODESETS + ifTrue: [multipleBytecodeSetsActive := true] + ifFalse: [^self primitiveFailFor: PrimErrUnsupported]] + ifFalse: [self stackTop = objectMemory falseObject + ifTrue: [multipleBytecodeSetsActive := false] + ifFalse:[^self primitiveFailFor: PrimErrBadArgument]]]. + multipleBytecodeSetsActive + ifTrue: [self pop: argumentCount + 1 thenPush: objectMemory trueObject] + ifFalse: [self pop: argumentCount + 1 thenPush: objectMemory falseObject]. + ! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. STACKVM := true. "These flags identify a GC operation (& hence a reason to leak check), or just operations the leak checker can be run for." GCModeFull := 1. "stop-the-world global GC" GCModeNewSpace := 2. "Spur's scavenge, or V3's incremental" GCModeIncremental := 4. "incremental global gc (Dijkstra tri-colour marking); as yet unimplemented" GCModeBecome := 8. "v3 post-become sweeping/Spur forwarding" GCCheckImageSegment := 16. "just a flag for leak checking image segments" GCCheckFreeSpace := 32. "just a flag for leak checking free space; Spur only" GCCheckShorten := 64. "just a flag for leak checking object shortening operations; Spur only" GCCheckPrimCall := 128. "just a flag for leak checking external primitive calls" StackPageTraceInvalid := -1. StackPageUnreached := 0. StackPageReachedButUntraced := 1. StackPageTraced := 2. DumpStackOnLowSpace := 0. MillisecondClockMask := 16r1FFFFFFF. "Note: The external primitive table should actually be dynamically sized but for the sake of inferior platforms (e.g., Mac :-) who cannot allocate memory in any reasonable way, we keep it static (and cross our fingers...)" MaxExternalPrimitiveTableSize := 4096. "entries" MaxJumpBuf := 32. "max. callback depth" FailImbalancedPrimitives := InitializationOptions at: #FailImbalancedPrimitives ifAbsentPut: [true]. EnforceAccessControl := InitializationOptions at: #EnforceAccessControl ifAbsent: [true]. ReturnToInterpreter := 1. "setjmp/longjmp code." "Because of a hack with callbacks in the non-threaded VM they must not conflct with the VM's tag bits." DisownVMForFFICall := 16. + DisownVMForThreading := 32. + + "The multiple bytecodes active bit in the image format number" + MultipleBytecodeSetsBitmask := 512. - DisownVMForThreading := 32 ! Item was changed: ----- Method: StackInterpreter>>readableFormat: (in category 'image save/restore') ----- readableFormat: imageVersion "Anwer true if images of the given format are readable by this interpreter. Allows a virtual machine to accept selected older image formats." <api> + ^ (self imageFormatVersion = (imageVersion bitAnd: ( -1 - MultipleBytecodeSetsBitmask))) "Ignore multiple bytecode support identifier" + or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" - ^imageVersion = self imageFormatVersion "Float words in platform-order" - or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" and: [imageVersion = self imageFormatCompatibilityVersion]] "Float words in BigEndian order"! Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | <var: 'f' type: #sqImageFile> <var: 'headerStart' type: #squeakFileOffsetType> <var: 'sCWIfn' type: #'void *'> <var: 'imageName' declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. "local constants" headerStart := 0. headerSize := objectMemory wordSize * 16. "64 or 128; header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. (self invalidSqImageFile: f) ifTrue: "could not open the image file for writing" [^self primitiveFailFor: PrimErrOperationFailed]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. + multipleBytecodeSetsActive + ifTrue: [self putWord32: (self imageFormatVersion bitOr: MultipleBytecodeSetsBitmask) toFile: f] + ifFalse: [self putWord32: self imageFormatVersion toFile: f]. - self putWord32: self imageFormatVersion toFile: f. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. self putLong: self getSnapshotScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f!

1 0

VM Maker: ImageFormat-dtl.53.mcz
by commits＠source.squeak.org 26 Dec '21

26 Dec '21

David T. Lewis uploaded a new version of ImageFormat to project VM Maker: http://source.squeak.org/VMMaker/ImageFormat-dtl.53.mcz ==================== Summary ==================== Name: ImageFormat-dtl.53 Author: dtl Time: 26 December 2021, 3:08:52.811788 pm UUID: e08b1774-e9c5-4923-88fe-a0255af83508 Ancestors: ImageFormat-dtl.52 Rescue utility method to handle the hypothetical case of an image file written as format 68533 or 7033 by a newer VM, but no local VM is available to open this file format. ImageFormat class>>clearSistaBit: rewrites the format number in the image file, setting it back to a number usable by an older VM that nevertheless has the necessary Sista bytecode support. =============== Diff against ImageFormat-dtl.52 =============== Item was added: + ----- Method: ImageFormat class>>clearSistaBit: (in category 'utility') ----- + clearSistaBit: imageFileName + "Rescue utility. If an image file was written by a VM that understands the new + image format numbers for multiple bytecode support, but no local VM is available + to run that image, this method can be used to rewrite the image format number + to an older format number that is likely to readable." + + "ImageFormat clearSistaBit: 'imageFileToFix.image' " + + | fmt int newInt fs | + fmt := self fromFile: imageFileName. + int := fmt asInteger. + fmt requiresMultipleBytecodeSupport + ifFalse: [ ^self inform: fmt asString, ' conversion not required']. + fmt setRequiresMultipleBytecodeSupport: false. + newInt := fmt asInteger. + (self confirm: 'convert image format number ', int asString , ' to ', newInt asString) + ifFalse: [^self inform: 'image format number ', int asString, ' not changed']. + fs := FileStream fileNamed: imageFileName. + [ fs binary; + nextPut: (newInt bitAnd: 16rFF); "assume little endian" + nextPut: ((newInt >> 8) bitAnd: 16rFF); + nextPut: ((newInt >> 16) bitAnd: 16rFF); + nextPut: ((newInt >> 24) bitAnd: 16rFF) ] ensure: [ fs close ]. + self inform: 'converted ', imageFileName,' image format number ', int asString , ' to ', newInt asString. + ^self fromFile: imageFileName. "verify result" + + + !

1 0

VM Maker: CogTools-eem.92.mcz
by commits＠source.squeak.org 24 Dec '21

24 Dec '21

Eliot Miranda uploaded a new version of CogTools to project VM Maker: http://source.squeak.org/VMMaker/CogTools-eem.92.mcz ==================== Summary ==================== Name: CogTools-eem.92 Author: eem Time: 24 December 2021, 1:00:46.796409 pm UUID: 34c4fb6f-7b3a-42fe-bfb8-7a0a1cb8f77e Ancestors: CogTools-eem.91 Make VMProfiler cope with full blocks. =============== Diff against CogTools-eem.91 =============== Item was changed: ----- Method: VMProfilerSymbolsManager>>computeCogCodeModule: (in category 'Cog compiled code') ----- computeCogCodeModule: cogCodeConstituents | symbols | (cogModule := VMPExecutableModuleSymbol new) name: vmModule shortName, '.', cogCodeConstituents first; shortName: cogCodeConstituents first; vmshift: 0; address: cogCodeConstituents second; size: cogCodeConstituents last - cogCodeConstituents second. symbols := (3 to: cogCodeConstituents size - 2 by: 2) collect: + [:i| "Declare methods as public; full blocks, PICs and entries as private" - [:i| "Declare methods as public; PICs and entries as private" | thing | ((thing := cogCodeConstituents at: i) isCompiledMethod ifTrue: [VMPPublicFunctionSymbol] ifFalse: [VMPPrivateFunctionSymbol]) new name: (self nameOf: thing cogCodeModule: cogCodeConstituents); address: (self extractAddress: (cogCodeConstituents at: i + 1)); cm: thing ; mcpcbcpcmap: (cogCodeConstituents at: i + 1); limit: (self extractAddress: (cogCodeConstituents at: i + 3 ifAbsent: [cogCodeConstituents last]))]. self addCogModuleSymbols: symbols! Item was changed: ----- Method: VMProfilerSymbolsManager>>nameOf:cogCodeModule: (in category 'Constituents naming') ----- nameOf: thing cogCodeModule: cogCodeConstituents + thing isCompiledCode ifTrue: + [thing isCompiledMethod ifTrue: [ ^ thing methodClass name , '>>' , thing selector ]. + thing isCompiledBlock ifTrue: [ ^ '[] in ', (self nameOf: thing outerCode cogCodeModule: cogCodeConstituents) ]]. + thing class == cogCodeConstituents first class ifTrue: [ ^thing ]. "i.e. a string" + ^thing isArray - thing isCompiledMethod ifTrue: [ ^ thing methodClass name , '>>' , thing selector ]. - thing class == cogCodeConstituents first class ifTrue: [ ^thing ]. - ^ thing isArray ifTrue: [self getClosedPICLabel: (self analyzeClosedPIC: thing)] + ifFalse: ['OpenPIC ', (thing isString - ifFalse: ['OpenPIC ',(thing isString ifTrue: [ thing ] + ifFalse: [ thing printString ])]! - ifFalse: [ thing printString ])] !

1 0

[OpenSmalltalk/opensmalltalk-vm] Illegal instruction `mrs x0, id_aa64isar0_el1` on aarch64 on older Linux kernels (Issue #608)
by Tony Garnock-Jones 22 Dec '21

22 Dec '21

I'm running Cog on aarch64, and because I have an old linux kernel (v3.18.140) which I cannot upgrade (it's a repurposed PostmarketOS Android device), Cog yields illegal instruction trying to execute `mrs x0, id_aa64isar0_el1`. This instruction is privileged, but later linux kernels trap and emulate it for userspace. Given that it's currently only being used to detect presence of atomic instructions (`self setHasAtomicInstructions: (idISAR0 >> 20 bitAnd: 2r1111) = 2r10`), and there's a kernel API for retrieving that specific bit of information (<https://www.kernel.org/doc/html/latest/arm64/elf_hwcaps.html> suggests HWCAP_ATOMICS), perhaps instead of using the instruction directly Cog could call the relevant `getauxval` variant? For now, I have the Stack VM running well on aarch64, so I can make progress, even if it is a little slower than it could be :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/608

2 5

VM Maker: VMMaker.oscog-eem.3122.mcz
by commits＠source.squeak.org 22 Dec '21

22 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3122.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3122 Author: eem Time: 21 December 2021, 4:22:53.449826 pm UUID: 0b780ccb-785e-4780-b94f-9f0b2d685031 Ancestors: VMMaker.oscog-eem.3121 Add the full block entry label to full block disassembly. =============== Diff against VMMaker.oscog-eem.3121 =============== Item was changed: ----- Method: Cogit>>disassembleMethod:on: (in category 'disassembly') ----- disassembleMethod: surrogateOrAddress on: aStream <doNotGenerate> | cogMethod mapEntries codeRanges | cogMethod := surrogateOrAddress isInteger ifTrue: [self cogMethodSurrogateAt: surrogateOrAddress] ifFalse: [surrogateOrAddress]. cogMethod cmType = CMBlock ifTrue: [^self disassembleMethod: cogMethod cmHomeMethod on: aStream]. disassemblingMethod ifNil: [^[disassemblingMethod := cogMethod. self disassembleMethod: surrogateOrAddress on: aStream] ensure: [disassemblingMethod := nil]]. self printMethodHeader: cogMethod on: aStream. mapEntries := Dictionary new. - (cogMethod cmType = CMMethod and: [cogMethod cmIsFullBlock]) ifFalse: - [mapEntries at: cogMethod asInteger + cmEntryOffset put: 'entry']. cogMethod cmType = CMMethod ifTrue: [cogMethod cmIsFullBlock + ifTrue: + [mapEntries + at: cogMethod asInteger + cbNoSwitchEntryOffset put: 'noSwitchEntry'; + at: cogMethod asInteger + cbEntryOffset put: 'entry'] + ifFalse: + [mapEntries + at: cogMethod asInteger + cmNoCheckEntryOffset put: 'noCheckEntry'; + at: cogMethod asInteger + cmEntryOffset put: 'entry']]. - ifTrue: [mapEntries at: cogMethod asInteger + cbNoSwitchEntryOffset put: 'noSwitchEntry'] - ifFalse: [mapEntries at: cogMethod asInteger + cmNoCheckEntryOffset put: 'noCheckEntry']]. cogMethod cmType = CMClosedPIC ifTrue: "Since Tim R's lovely work on Closed PICs, PIC cases go backwards..." [mapEntries at: cogMethod asInteger + firstCPICCaseOffset put: 'ClosedPICCase', MaxCPICCases printString. 1 to: MaxCPICCases - 1 do: [:i| mapEntries at: cogMethod asInteger + firstCPICCaseOffset + (i * cPICCaseSize) put: 'ClosedPICCase', (MaxCPICCases - i) printString]] ifFalse: [self mapFor: cogMethod performUntil: #collectMapEntry:address:into: arg: mapEntries]. NewspeakVM ifTrue: [objectRepresentation canPinObjects ifFalse: [mapEntries keys do: [:a| (mapEntries at: a) = #IsNSSendCall ifTrue: [mapEntries at: a + backEnd jumpShortByteSize put: {'Class'. #disassembleCachedOop:. (objectMemory wordSize)}; at: a + backEnd jumpShortByteSize + objectMemory bytesPerOop put: {'ImplicitReceiver'. #disassembleCachedOop:. (objectMemory wordSize)}]]]]. "This would all be far more elegant and simple if we used blocks. But there are no blocks in C and the basic enumerators here need to be used in the real VM. Apologies." (codeRanges := self codeRangesFor: cogMethod) do: [:range| (cogMethod cmType = CMMethod) ifTrue: [mapEntries keysAndValuesDo: [:mcpc :label| | bcpc selectorOrNone | (((range includes: mcpc) or: [range last + 1 = mcpc]) and: [(AnnotationsWithBytecodePCs includes: label) and: [range cogMethod stackCheckOffset > 0]]) ifTrue: [bcpc := self bytecodePCFor: mcpc startBcpc: range startpc in: range cogMethod. bcpc ~= 0 ifTrue: [label = #IsSendCall ifTrue: [selectorOrNone := (self selectorForSendAt: mcpc annotation: IsSendCall in: cogMethod methodObject). (selectorOrNone isInteger and: [objectMemory addressCouldBeOop: selectorOrNone]) ifTrue: [selectorOrNone := objectMemory stringOf: selectorOrNone]. selectorOrNone := ' ', selectorOrNone] ifFalse: [selectorOrNone := '']. mapEntries at: mcpc put: label, selectorOrNone, ' bc ', bcpc printString, '/', (bcpc + 1) printString]]]]. (cogMethod blockEntryOffset ~= 0 and: [range first = (cogMethod blockEntryOffset + cogMethod asInteger)]) ifTrue: [aStream nextPutAll: 'blockEntry:'; cr. self blockDispatchFor: cogMethod perform: #disassemble:from:to:arg: arg: aStream] ifFalse: [range first > (cogMethod address + cmNoCheckEntryOffset) ifTrue: [self printMethodHeader: range cogMethod on: aStream]. self maybeNoteStartpcFor: range. self disassembleFrom: range first to: range last labels: mapEntries on: aStream]]. aStream nextPutAll: 'startpc: '; print: codeRanges first startpc; cr. (cogMethod cmType = CMMethod or: [cogMethod cmType = CMOpenPIC]) ifTrue: [[self mapFor: cogMethod performUntil: #printMapEntry:mcpc:args: arg: { aStream. codeRanges. cogMethod }] on: AssertionFailure do: [:ex| ex primitiveChangeClassTo: ResumableVMError basicNew. ":) :) :)" ex resume: nil]]. ^cogMethod!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2021