Vm-dev August 2017

vm-dev@lists.squeakfoundation.org

31 participants
61 discussions

StackInterp/Cog>>transferTo: - assertValidExecutionPointe:r:s differences
by Ben Coman 06 May '18

06 May '18

Just curious about the difference in instructionPointer between these two... StackInterpreter>>transferTo: self assertValidExecutionPointe: instructionPointer + 1 r: framePointer s: stackPointer. CoIntepreter>>transferTo:from: self assertValidExecutionPointe: instructionPointer r: framePointer s: stackPointer. cheers -ben

3 8

Reproducible crashing the VM with a zipped fuel serialization
by stephan 13 Jan '18

13 Jan '18

I revisited my MonticelloProjects experiment yesterday, and am still crashing the vm when serializing to a compressed fuel file. I wrote about it at the time, and then gave up as the vm was less stable during that period. http://forum.world.st/Working-with-a-compressed-Fuel-file-td4869105.html and it looks like the issue referenced: http://forum.world.st/Re-Pharo-project-GZipWriteStream-crashing-my-VM-when-… To reproduce in a pharo6 image: |project| Gofer it smalltalkhubUser: 'StephanEggermont' project: 'MonticelloProjects'; package: 'MonticelloProjects'; load. project := (Smalltalk at: #MCProject) new location: 'http://smalltalkhub.com/mc/StephanEggermont/Documentation/main'. project read. project saveToFile. That reliably crashes in saveToFile. It seems to be independent of 32/64 bit and mac/linux, as I tried some variations. Stephan

3 5

[ANN] Lowtalk, a new Smalltalk dialect that could eventually replace Slang
by Ronie Salgado 19 Sep '17

19 Sep '17

Hi All, I am finally glad to announce an initial version of my secret experiment, Lowtalk: https://github.com/ronsaldo/lowtalk Lowtalk is a new Smalltalk dialect that generates relocatable binary object code, that can be linked with any C program or used to generate a standalone executable with the C linker. I am designing Lowtalk as a language for video game developing, where performance and multi-threading support is important. The Lowtalk compiler is completely written in Pharo. The main features of Lowtalk are the following: - The compiler is actually a meta circular evaluator, whose features are used for bootstraping the Lowtalk kernel. - The Lowtalk object model, including the layout of the objects is defined in the language itself. - Direct interface with C. There is an almost 1:1 mapping between the Lowtalk native types and the C types. There is a syntax extension for calling C functions. -Support for real multi-threading. - The current object model uses automatic reference counting, which is slow, but makes supporting real multi-threading easier. - Immediates are based on the Spur object model. - Partial support for generating debugging information in the DWARF standard. It is possible to place breakpoints and get correct stack traces with gdb. Lowtalk is on the line of my work with Lowcode, and I am planning on making a Lowtalk backend that uses Lowcode. The Lowtalk type system is almost the same as the one that I described at the paper: Lowcode: Extending Pharo with C Types to Improve Performance I will make a video later, and a proper demonstration at ESUG. Best regards, Ronie

9 11

VM Maker: VMMaker.oscog-eem.2266.mcz
by commits＠source.squeak.org 16 Sep '17

16 Sep '17

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2266.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2266 Author: eem Time: 31 August 2017, 12:20:30.681037 pm UUID: 0501d71a-3185-4bdb-a99c-76a5fbbeee22 Ancestors: VMMaker.oscog-eem.2265 Spur: Simplify cleverSwapHeaders:and:copyHashFlag: via xor. Fix the type of currentAllocatedBytes given the Slang changes below. Slang: Fix a regression caused by the Slang fixes in VMMaker.oscog-eem.2243. Since inferTypesForImplicitlyTypedVariablesIn: no longer sets the types of locals as it goes along (which was incorrect) we can no longer default the types of untyped variables to sqInt for the purposes of returnTypeForSend:in:ifNil:. To allow returnTypeForSend:in:ifNil: to answer nil for arithmetic on untyped expressions typeForArithmetic:in: uses TParseNode>>typeOrNilFrom:in: instead of CCodeGenerator>>typeFor:in: to avoid the defaulting. returnTypeForSend:in:ifNil: has been refactored to use the more direct TParseNode>>typeFrom:in: instead of CCodeGenerator>>typeFor:in: for clarity. Teh regression caused Slang to fail to infer the types of remembered1/2 & hash1/2 in cleverSwapHeaders:and:copyHashFlag:. The new code correctly infers the types of remembered & hashBits as sqLong. SoundPlugin: Eliminate a couple of warnings by using 0 instead of NULL. =============== Diff against VMMaker.oscog-eem.2265 =============== Item was changed: ----- Method: CCodeGenerator>>returnTypeForSend:in:ifNil: (in category 'type inference') ----- returnTypeForSend: sendNode in: aTMethod ifNil: typeIfNil "Answer the return type for a send. Unbound sends default to typeIfNil. Methods with types as yet unknown have a type determined either by the kernelReturnTypes or the table below, or, if they are in neither set, then nil. The inferred type should match as closely as possible the C type of generated expessions so that inlining would not change the expression. If there is a method for sel but its return type is as yet unknown it mustn't be defaulted, since on a subsequent pass its type may be computable." | sel methodOrNil | methodOrNil := self anyMethodNamed: (sel := sendNode selector). (methodOrNil notNil and: [methodOrNil returnType notNil]) ifTrue: [^self baseTypeForType: methodOrNil returnType]. ^kernelReturnTypes at: sel ifAbsent: [sel caseOf: { [#integerValueOf:] -> [#sqInt]. [#isIntegerObject:] -> [#int]. + [#negated] -> [self promoteArithmeticTypes: (sendNode receiver typeFrom: self in: aTMethod) and: #int]. - [#negated] -> [self promoteArithmeticTypes: (self typeFor: sendNode receiver in: aTMethod) and: #int]. [#+] -> [self typeForArithmetic: sendNode in: aTMethod]. [#-] -> [self typeForArithmetic: sendNode in: aTMethod]. [#*] -> [self typeForArithmetic: sendNode in: aTMethod]. [#/] -> [self typeForArithmetic: sendNode in: aTMethod]. [#//] -> [self typeForArithmetic: sendNode in: aTMethod]. [#\\] -> [self typeForArithmetic: sendNode in: aTMethod]. [#rem:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#quo:] -> [self typeForArithmetic: sendNode in: aTMethod]. "C99 Sec Bitwise shift operators ... 3 Sematics ... The integer promotions are performed on each of the operands. The type of the result is that of the promoted left operand..." + [#>>] -> [sendNode receiver typeFrom: self in: aTMethod]. + [#<<] -> [sendNode receiver typeFrom: self in: aTMethod]. + [#addressOf:] -> [(sendNode receiver typeFrom: self in: aTMethod) - [#>>] -> [self typeFor: sendNode receiver in: aTMethod]. - [#<<] -> [self typeFor: sendNode receiver in: aTMethod]. - [#addressOf:] -> [(self typeFor: sendNode receiver in: aTMethod) ifNil: [#sqInt] ifNotNil: [:type| type, (type last isLetter ifTrue: [' *'] ifFalse: ['*'])]]. [#at:] -> [self typeForDereference: sendNode in: aTMethod]. [#bitAnd:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitOr:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitXor:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitClear:] -> [self typeForArithmetic: sendNode in: aTMethod]. [#bitInvert32] -> [#'unsigned int']. + [#bitInvert64] -> [self promoteArithmeticTypes: (sendNode receiver typeFrom: self in: aTMethod) and: #int]. - [#bitInvert64] -> [self promoteArithmeticTypes: (self typeFor: sendNode receiver in: aTMethod) and: #int]. [#byteSwap32] -> [#'unsigned int']. [#byteSwap64] -> [#'unsigned long long']. [#byteSwapped32IfBigEndian:] -> [#'unsigned int']. [#byteSwapped64IfBigEndian:] -> [#'unsigned long long']. [#=] -> [#int]. [#~=] -> [#int]. [#==] -> [#int]. [#~~] -> [#int]. [#<] -> [#int]. [#<=] -> [#int]. [#>] -> [#int]. [#>=] -> [#int]. [#between:and:] -> [#int]. [#anyMask:] -> [#int]. [#allMask:] -> [#int]. [#noMask:] -> [#int]. [#isNil] -> [#int]. [#notNil] -> [#int]. [#&] -> [#int]. [#|] -> [#int]. [#not] -> [#int]. [#asFloat] -> [#double]. [#atan] -> [#double]. [#exp] -> [#double]. [#log] -> [#double]. [#sin] -> [#double]. [#sqrt] -> [#double]. [#asLong] -> [#long]. [#asInteger] -> [#sqInt]. [#asIntegerPtr] -> [#'sqIntptr_t']. [#asUnsignedInteger] -> [#usqInt]. [#asUnsignedIntegerPtr]-> [#'usqIntptr_t']. [#asUnsignedLong] -> [#'unsigned long']. [#asUnsignedLongLong] -> [#'unsigned long long']. [#asVoidPointer] -> [#'void *']. [#signedIntToLong] -> [#usqInt]. "c.f. generateSignedIntToLong:on:indent:" [#signedIntToShort] -> [#usqInt]. "c.f. generateSignedIntToShort:on:indent:" [#cCoerce:to:] -> [sendNode args last value]. [#cCoerceSimple:to:] -> [sendNode args last value]. [#sizeof:] -> [#'usqIntptr_t']. "Technically it's a size_t but it matches on target architectures so far..." [#ifTrue:ifFalse:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifFalse:ifTrue:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifTrue:] -> [self typeForConditional: sendNode in: aTMethod]. [#ifFalse:] -> [self typeForConditional: sendNode in: aTMethod]. [#and:] -> [#sqInt]. [#or:] -> [#sqInt]. [#caseOf:] -> [self typeFor: sendNode args first in: aTMethod] } otherwise: "If there /is/ a method for sel but its return type is as yet unknown it /mustn't/ be defaulted, since on a subsequent pass its type may be computable. Only default unbound selectors." [methodOrNil ifNotNil: [nil] ifNil: [typeIfNil]]]! Item was changed: ----- Method: CCodeGenerator>>typeForArithmetic:in: (in category 'type inference') ----- typeForArithmetic: sendNode in: aTMethod "Answer the return type for an arithmetic sendThis is so that the inliner can still inline simple expressions. Deal with pointer arithmetic, floating point arithmetic and promotion." + | rcvrType argType arg | + rcvrType := sendNode receiver typeOrNilFrom: self in: aTMethod. + argType := (arg := sendNode args first) typeOrNilFrom: self in: aTMethod. - | rcvrType argType arg promotedType | - rcvrType := self typeFor: sendNode receiver in: aTMethod. - argType := self typeFor: (arg := sendNode args first) in: aTMethod. "deal with pointer arithmetic" ((rcvrType notNil and: [rcvrType last == $*]) or: [argType notNil and: [argType last == $*]]) ifTrue: [(rcvrType isNil or: [argType isNil]) ifTrue: [^nil]. (rcvrType last == $* and: [argType last == $*]) ifTrue: [sendNode selector == #- ifTrue: [^#int]. self error: 'invalid pointer arithmetic']. ^rcvrType last == $* ifTrue: [rcvrType] ifFalse: [argType]]. + ^(self promoteArithmeticTypes: rcvrType and: argType) ifNotNil: + [:promotedType| + "We have to be very careful with subtraction. The difference between two unsigned types is signed. + But we don't want unsigned - constant to be signed. We almost always want this to stay unsigned." + (sendNode selector == #- and: [promotedType first == $u and: [(arg isConstant and: [arg value isInteger]) not]]) + ifTrue: [promotedType allButFirst: ((promotedType beginsWith: 'unsigned') ifTrue: [9] ifFalse: [1])] + ifFalse: [promotedType]]! - promotedType := self promoteArithmeticTypes: rcvrType and: argType. - "We have to be very careful with subtraction. The difference between two unsigned types is signed. - But we don't want unsigned - constant to be signed. We almost always want this to stay unsigned." - ^(sendNode selector == #- and: [promotedType first == $u and: [(arg isConstant and: [arg value isInteger]) not]]) - ifTrue: [promotedType allButFirst: ((promotedType beginsWith: 'unsigned') ifTrue: [9] ifFalse: [1])] - ifFalse: [promotedType]! Item was changed: ----- Method: SoundPlugin>>primitiveSetDefaultSoundPlayer (in category 'primitives') ----- primitiveSetDefaultSoundPlayer "Tell the operating system to use the specified device name as the output device for sound." "arg at top of stack is the String" | deviceName obj srcPtr sz | <export: true> <var: 'deviceName' declareC: 'char deviceName[257]'> <var: 'srcPtr' type: #'char *'> "Parse arguments" interpreterProxy methodArgumentCount = 1 ifFalse: [^interpreterProxy primitiveFail]. obj := interpreterProxy stackValue: 0. (interpreterProxy isBytes: obj) ifFalse: [^interpreterProxy primitiveFail]. (sz := interpreterProxy byteSizeOf: obj) <= 256 ifFalse: [^interpreterProxy primitiveFail]. srcPtr := interpreterProxy firstIndexableField: obj. self touch: srcPtr. self touch: deviceName. self touch: sz. self cCode: 'strncpy(deviceName, srcPtr, sz)'. + self cCode: 'deviceName[sz] = 0'. - self cCode: 'deviceName[sz] = NULL'. "do the work" self cCode: 'setDefaultSoundPlayer(deviceName)'. interpreterProxy failed ifFalse: "pop arg, leave receiver" [interpreterProxy pop: 1]! Item was changed: ----- Method: SoundPlugin>>primitiveSetDefaultSoundRecorder (in category 'primitives') ----- primitiveSetDefaultSoundRecorder "Tell the operating system to use the specified device name as the input device for sound." "arg at top of stack is the String" | deviceName obj srcPtr sz | <export: true> <var: 'deviceName' declareC: 'char deviceName[257]'> <var: 'srcPtr' type: #'char *'> "Parse arguments" interpreterProxy methodArgumentCount = 1 ifFalse: [^interpreterProxy primitiveFail]. obj := interpreterProxy stackValue: 0. (interpreterProxy isBytes: obj) ifFalse: [^interpreterProxy primitiveFail]. (sz := interpreterProxy byteSizeOf: obj) <= 256 ifFalse: [^interpreterProxy primitiveFail]. srcPtr := interpreterProxy firstIndexableField: obj. self touch: srcPtr. self touch: deviceName. self touch: sz. self cCode: 'strncpy(deviceName, srcPtr, sz)'. + self cCode: 'deviceName[sz] = 0'. - self cCode: 'deviceName[sz] = NULL'. "do the work" self cCode: 'setDefaultSoundRecorder(deviceName)'. interpreterProxy failed ifFalse: "pop arg, leave receiver" [interpreterProxy pop: 1]! Item was changed: ----- Method: SpurMemoryManager>>cleverSwapHeaders:and:copyHashFlag: (in category 'become implementation') ----- cleverSwapHeaders: obj1 and: obj2 copyHashFlag: copyHashFlag "swap headers, but swapping headers swaps remembered bits and hashes; remembered bits must be unswapped and hashes may be unswapped if copyHash is false." "This variant doesn't tickle a compiler bug in gcc and clang. See naiveSwapHeaders:and:copyHashFlag:" <inline: true> + | header1 header2 remembered | - | header1 header2 remembered1 remembered2 | header1 := self long64At: obj1. header2 := self long64At: obj2. + remembered := (header1 bitXor: header2) bitAnd: 1 << self rememberedBitShift. + remembered ~= 0 ifTrue: + [header1 := header1 bitXor: remembered. + header2 := header2 bitXor: remembered]. - remembered1 := header1 bitAnd: 1 << self rememberedBitShift. - remembered2 := header2 bitAnd: 1 << self rememberedBitShift. - remembered1 ~= remembered2 ifTrue: - [header1 := header1 - remembered1 + remembered2. - header2 := header2 - remembered2 + remembered1]. "swapping headers swaps hash; if not copyHashFlag then unswap hash" copyHashFlag ifFalse: + [| hashBits | + hashBits := (header1 bitXor: header2) bitAnd: self identityHashFullWordMask. + hashBits ~= 0 ifTrue: + [header1 := header1 bitXor: hashBits. + header2 := header2 bitXor: hashBits]]. - [| hash1 hash2 | - hash1 := header1 bitAnd: self identityHashFullWordMask. - hash2 := header2 bitAnd: self identityHashFullWordMask. - hash1 ~= hash2 ifTrue: - [header1 := header1 - hash1 + hash2. - header2 := header2 - hash2 + hash1]]. self long64At: obj1 put: header2. self long64At: obj2 put: header1! Item was changed: ----- Method: SpurMemoryManager>>currentAllocatedBytes (in category 'allocation accounting') ----- currentAllocatedBytes "Compute the current allocated bytes since last set. This is the cumulative total in statAllocatedBytes plus the allocation since the last scavenge." | use | + "Slang infers the type of the difference between two unsigned variables as signed. + In this case we want it to be unsigned." + <var: 'use' type: #usqInt> use := segmentManager totalOldSpaceCapacity - totalFreeOldSpace. ^statAllocatedBytes + (freeStart - scavenger eden start) + (use - oldSpaceUsePriorToScavenge)!

3 2

win32 SetEvent, ResetEvent and MsgWaitForMultipleObjects
by Holger Freyther 15 Sep '17

15 Sep '17

Hi Eliot, Bert, as part of reading the "goToSleep" primitive I had a look at Windows and the last time I dealt with win32 API was quite some time ago so maybe I am wrong but doesn't the time slice below look like a race condition? If not what am I missing? VM Thread Socket Read Thread ioRelinquishProcess.. SIGNAL(pss->readSema) -> SetEvent(vmWakeUpEvent) ResetEvent(vmWakeUpEvent) MsgWaitForMultipleObjects... Couldn't we have lost the vmWakeUpEvent for the socket and then wait the full timeout? The history in Opensmalltalk-vm doesn't go far but couldn't we create the vmWakeUpEvent with the autoreset flag? thank you holger Code snippets: sqInt ioRelinquishProcessorForMicroseconds(sqInt microSeconds) { /* wake us up if something happens */ ResetEvent(vmWakeUpEvent); if (WAIT_TIMEOUT == MsgWaitForMultipleObjects(1, &vmWakeUpEvent, FALSE, microSeconds / 1000, QS_ALLINPUT)) int synchronizedSignalSemaphoreWithIndex(int semaIndex) { int result; /* Do our job - this is now synchronized in signalSemaphoreWithIndex */ result = signalSemaphoreWithIndex(semaIndex); /* wake up interpret() if sleeping */ SetEvent(vmWakeUpEvent); static DWORD WINAPI readWatcherThread(privateSocketStruct *pss) { struct timeval tv= { 1000, 0 }; /* Timeout value == 1000 sec */ fd_set fds; int n, doWait; while(1) { ... switch(pss->readWatcherOp) { case WatchData: /* Data may be available */ pss->sockState |= SOCK_DATA_READABLE; SIGNAL(pss->readSema);

1 1

Use less CPU (improve battery life or reduce cost in the cloud)
by Holger Freyther 08 Sep '17

08 Sep '17

Hi, I have done some early prototype for the Unix VM end of 2015(?) and I have improved and repeated these for MacOS now and the thread based heartbeat (now that it is the universal default). I won't make it to ESUG this year but this might be something to play with? The motivations is simple: Polling increases the CPU usage which will reduce your battery life, takes away resources from other processes (e.g. more Pharo images) or these days increases your cloud computing bill. On top of that it might increase network latency (time from socket becoming readable to the time the semaphore is signaled). To complete the work we have work inside the Image and the VM and some of it is on the way and others might need more discussion. The idle process: ProcessorScheduler>># idleProcess "A default background process which is invisible." [true] whileTrue: [self relinquishProcessorForMicroseconds: 1000] Let's please yield the CPU for more than a 1ms. Unless I am missing something an expired Delay or network IO would make us wake up earlier anyway? The delay scheduler: The VM supports that when the next wake-up time is set to 0, the VM can sleep indefinitely. There is a pending patch to sleep "0" in our Delay scheduler. Currently we force a wake-up earlier than that. I think we should trust the VM to do wake us up even if it is a second away. Morphic UI: I don't understand the WorldState>>#interCyclePause but then I never looked at Morphic. Do we really need to poll like that? Under which circumstances does the world update? We get an event (where we have the event semaphore), we get some I/O (where we have a semaphore) or we have a timeout (where we sleep on a semaphore). Did anyone ever look at removing the tick? VM I/O: Currently we receive a SIGIO but from what I can see (and I still need to write a benchmark) the processing might be delayed 20ms? My hack removes the usage of nextPollUsecs and instead checks a variable that is set by the SIGIO handler. Besides missing memory barriers this should work(tm). The biggest issue seems that for macos/ios the input is driven by polling. E.g. some wheel events seem to require to pump the event queue. Is this something we could trigger from the image in the future? I had hoped to get a fd to a machport we could get SIGIO for.. but that doesn't seem to exist. I have hacked out the honoring of the relinquish delay, added the polling into a iOS specific routine and thanks to the Morphic Delay we bump the event loop frequently enough. VM heartbeat thread: The process keeps ticking even if the VM doesn't run. E.g. sleeps and waits for an event. There is a cost in deciding when to halt the thread so there must be a cut-off for which delays we bother to disable the heartbeat thread. I think the current code would allow the hearbeat to drift so the new code might just make it a bit worse. Where are we now? I have pushed my changes to https://github.com/zecke/opensmalltalk-vm/tree/mac-use-less-cpu and would be happy to have people look at it, look at the memory synchronization, maybe run to see if they notice extra delays or such? I started the same image with the plain-vm and my hacked one and let it run for about 20min. The output is coming from top. COMMAND %CPU TIME Pharo 4.3 00:48.49 Pharo 0.8 00:10.20 Looking for comments and feedback. regards holger

8 8

Re: [Vm-dev] [squeak-dev] Inbox/Files-monty.172
by Eliot Miranda 06 Sep '17

06 Sep '17

Hi Nicolas, I'm happy to integrate the VMMaker and open Smalltalk-vm changes if you have them. _,,,^..^,,,_ (phone) > On Aug 30, 2017, at 1:13 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > > > > 2017-08-29 8:25 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >> Not only my eyes are old, my brain too: here is the original intention of Monty: >> >> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/140/commits/c1db1eb4… >> >> So it avoids file existence test in pre-condition, not in post-condition... >> I swear I had seen other changes about passing failure status back to image for avoiding post-condition tests, but maybe it was not in this batch of changes. > > Ah, it seems I'm senile since I can't remember it's me who integrated those changes, > but not completely senile since at least I remember that I saw such changes ;) > > ------------------------------- > > Name: VMMaker.oscog-nice.2233 > Author: nice > Time: 5 June 2017, 6:13:56.418116 pm > UUID: ff8286e4-b96f-4ce6-9cb5-e7b286679e03 > Ancestors: VMMaker.oscog-eem.2232 > > Integrate changes from monty to sqFileOpenNew. > > There must be a way to check if failure is due to existence of file (implemented via PrimErrInappropriate). > If we would test existence afterward, the file could have been deleted in interim leading to another race condition. > > This VMMaker change requires a coordinated platform source change (adding a 4th parameter to sqFileOpenNew). > > >> >> Forget about all I wrote before, the changes definitely deserve a proper review. >> Maybe check what happens in case someone did not update the VM properly before applying the image changes... >> >> 2017-08-29 1:36 GMT+02:00 tim Rowledge <tim(a)rowledge.org>: >>> >>> > On 28-08-2017, at 11:47 AM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: >>> > Main request was to avoid case of race condition that can happen when separating the action (like opening a file) from the query in case of failure (like was file unwritable?), because another concurrent program might have changed the file system status in between (think of concurrent squeak images creating concurrent /tmp/foobar.baz for example). >>> >>> Oh, *that* problem. I hate that. It’s such a stupid bit of (mis)design. I think I’ve been complaining about that for around 30 years… >>> >>> > >>> > I have already integrated the necessary VM changes, but it remains to integrate image side changes. >>> > Last time I checked there were unecessary changes mixed that I'd preferred to see discussed here, and the fallback code might not work in older VM, then I came short of spare time... >>> > But in any cases, there are too many .mcz roting in inbox, so I'm glad another pair of eyes analyze the changes. >>> >>> It’s all very well Torvalds declaring that all bugs are shallow with enough pairs of eyes, *if* you have enough pairs of eyes. We need more. >>> >>> >>> tim >>> -- >>> tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim >>> Strange OpCodes: RSC: Rewind System Clock >>> >>> >>> >> > >

2 1

Current VM build problems. (was: Fwd: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211))
by Tobias Pape 05 Sep '17

05 Sep '17

Hi all, currently the vm fails to build properly due to two main problems: a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505448#L3172 linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208 linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842 macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455 macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517 macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383 (Or said differently: on 32x86 for squeak.*.spur) I recall we had problems there but I thought those were fixed 2..3 years ago? Someone can comment? b) the pharo deployment seems to not work correctly: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900 for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the deploy script to not try to. IF incorrect, pleas fix on your side/site. Best regards -Tobias > Begin forwarded message: > > From: Travis CI <builds(a)travis-ci.org> > Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) > Date: 29. August 2017 um 13:02:09 MESZ > > OpenSmalltalk / opensmalltalk-vm (Cog) > > Build #835 has errored. 48 minutes and 25 seconds > Tobias Pape 7dff211 Changeset → > [squeakssl] follow suit with the unix hostname validation things > Want to know about upcoming build environment updates? > Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here. > Documentation about Travis CI > Need help? Mail support! > Choose who receives these build notification emails in your configuration file. > > Would you like to test your private code? > Travis CI for Private Projects could be your new best friend!

3 10

[OpenSmalltalk/opensmalltalk-vm] caa824: Fix SqueakSLL prototype for 64 its again
by GitHub 31 Aug '17

31 Aug '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: caa8241de11b99ecaea5236b3d3e3c0d303c6eb4 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/caa8241de11b99ecae… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-09-01 (Fri, 01 Sep 2017) Changed paths: M platforms/Cross/plugins/SqueakSSL/SqueakSSL.h M platforms/win32/plugins/SqueakSSL/sqWin32SSL.c Log Message: ----------- Fix SqueakSLL prototype for 64 its again previous fix baa70862014d3bb510f2edf7465e857c645be0e4 worked for Win64 but broke linux64 and macosx64 If a single .h is shared, then the nearly-equal-duplicated.c shall agree on function prototypes! I’ve seen too many random int/sqInt mismatch

1 0

[OpenSmalltalk/opensmalltalk-vm] c0304d: FilePlugin: Remove misleading check for end of lin...
by GitHub 31 Aug '17

31 Aug '17

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: c0304df1d8be536c0dd6f4306e56c375e6533e3c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c0304df1d8be536c0d… Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: 2016-09-24 (Sat, 24 Sep 2016) Changed paths: M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c Log Message: ----------- FilePlugin: Remove misleading check for end of line When operating on stdin sqFileReadIntoAt will read one zero or one byte from the FILE*. The loop will exit when bytesRead is not zero and this will happen when a character was read. There is no reason to exit the loop differently for \r or \n. Commit: 3f49cd2f9a4833ea8e7d43e958bd216784204183 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3f49cd2f9a4833ea8e… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c Log Message: ----------- Merge pull request #64 from zecke/Cog-remove-eol-check FilePlugin: Remove misleading check for end of line Integrator note: this is a minor cleanup and absolutely won't change any behaviour. See https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/150 for an explanation of the origin of those checks, and for things remaining to change. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1102de6e73c3...3f…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2017