Vm-dev March 2010

vm-dev@lists.squeakfoundation.org

33 participants
62 discussions

ffi-test-main.c fails on FreeBSD
by Gary Dunn 12 Aug '16

12 Aug '16

In conjunction with getting Open Cobalt running on FreeBSD I have been looking into the problems with SqueakFFIPrims on FreeBSD and have reached a point that is beyond my understanding. I am not sure if the fix should come from the VM side or the FreeBSD port maintainer. I needed to get source code back into the ports tree so I did a make in /usr/ports/lang/squeak. I already had the 3.9 tarball, so that just repopulated the source and did the initial build. In the "files" folder I found patch files typical for a FreeBSD port. These patch source files from a generic tarball to work with FreeBSD. The one of interest was patch-platforms__unix__plugins__SqueakFFIPrims__ffi-config which contains ----x-----x----- --- platforms/unix/plugins/SqueakFFIPrims/ffi-config.org Wed Apr 26 20:27:53 2006 +++ platforms/unix/plugins/SqueakFFIPrims/ffi-config Wed Apr 26 20:29:00 2006 @@ -39,6 +39,7 @@ case ${abi} in linux) abi=sysv;; + freebsd*) abi=sysv;; darwin*) abi=darwin;; *) abi=libffi; lib="-lffi";; esac -----x-----x----- I then had the folder work/Squeak-3.9-7/platforms/unix/plugins/SqueakFFIPrims In it is a file 00README which explains how to test FFI. It says to run ffi-test-config but I have no such file. It says to type "make" to build a test suite but the build failed. It says to try with make CPU=any ABI=libffi LIB=-lffi which also failed. I traced the problem to the gcc search paths for includes and libraries -- turns out FreeBSD only searches /usr/include and /usr/lib when the required files are in /usr/local/include and /usr/local/lib. After some fiddling I finally had a "main" to test. It failed: ffi-test-main.c failed at line 361. Here is a bit from that file, ending with line 361: ffiInitialize(); for (ul= 0; ul < 15; ++ul) ffiPushSingleFloat(fa[ul]); GO(FFITypeSingleFloat, many); f= ffiReturnFloatValue(); ffiCleanup(); CHECK(f - ff < FLT_EPSILON); I worked out the CHECK macro but could not find what FLT_EPSILON is. At that point I decided to stop and come to you for help. Where do I go from here? -- Gary Dunn, Honolulu osp(a)aloha.com http://openslate.net/ http://e9erust.blogspot.com/ Sent from Slate001

5 8

Profiling and delay accuracy
by Andreas Raab 06 Aug '11

06 Aug '11

Hi Folks - For a long time now I had this feeling that MessageTally reports pretty bogus results in many situations without being able to precisely track down why this would be the case. Today I was looking at primitiveResponse() and, much to my surprise, noticed that the checkForInterrupts() that used to be there for years is gone (see Squeak3.6 for example which still has it). The sole reason for this check was to get both high delay accuracy and good profiling behavior. Consider this example: fc := FormCanvas on: Display. MessageTally spyOn:[ 1 to: 100 do:[:i| fc fillColor: Color white. fc printString. ]. ]. Using 3.6 this will be measured correctly as: **Tree** 87.5% {243ms} FormCanvas>>fillColor: |87.5% {243ms} GrafPort>>fillRect:offset: | 87.5% {243ms} GrafPort>>copyBits 12.5% {35ms} FormCanvas(Object)>>printString 12.5% {35ms} FormCanvas(Object)>>printStringLimitedTo: whereas the 3.10 reports it as **Tree** 99.6% {670ms} FormCanvas(Object)>>printString 94.9% {639ms} primitives 4.6% {31ms} FormCanvas(Object)>>printStringLimitedTo: I think you can see the problem and just imagine what this does to any cumulative results. I also wonder what that change does to platforms that don't have high-resolution asynchronous timers. This used to be the one place where we would catch timer changes at high resolution and unless the platform forces high resolution timer interrupts asynchronously (by resetting the interrupt counter) we must be loosing a lot in terms of delay accuracy. (it just so happens that the Windows VM *does* do asynchronous timer interrupts so I never noticed this but I'm very curious about the difference on Linux which typically still has pretty bad timer granularity). Any opinions? My feeling is that the timer check should go back in for all of the above reasons. At the very least a quickCheckForInterrupt() is required but I actually think putting the full check back in is worth it. Cheers, - Andreas

3 3

Joys of Squeak-dev image, VM Compiling on MacIntel and Spoon remote OtherBrowsing
by Ken G. Brown 16 Nov '10

16 Nov '10

MacPro OS X 10.4.9 Xcode 2.4.1 Squeak-dev-114-2, VMMaker 2.8b6.1, Squeak 3.8.15beta6U.app, and version 1657 of svn MacOS VM sources, and Spoon v2a12. Downloaded http://www.squeakvm.org/cgi-bin/viewcvs.cgi/ trunk version 1657 for MacOS Ran squeak-dev-beta-114-2.image on Squeak 3.8.15beta6U.app Loaded VMMaker 3.8b6.1 from dev image Universes. Generated vm sources by following instructions in <http://www.squeakvm.org/cgi-bin/viewcvs.cgi/trunk/platforms/Mac%20OS/vm/Doc…> Fought with Xcode wanting to use MacOSX10.3.9.sdk for ppc which was giving an error which was known and documented in the Readme. Finally figured out what Xcode wanted so built universal app just using 10.4.9 sdk. Couple issues: Exupery references remain in sqnamedPrims.h and sqPlatformSpecific.h from svn version 1657, I just commented them out. Notes said: Info-NPSqueak__Upgraded_.plist was to be found in the Developer directory. I could not find it so scammed a info.plist out of John's Squeak 3.8.15beta6U.app vm. Not sure what impact this has. And much, much diddling about figuring out various things... Finally got a build. It's a lot smaller (3.9MB) than John McIntosh's Squeak 3.8.15beta6U.app (8.1MB), and it looks like it is a PowerPC one but at least it runs. I'll look into the Xcode build process some more. Then: Replaced interp.c with Craig's interp.c for Spoon, rebuilt and got a VM with Spoon client stuff. Downloaded Spoon release 2a12. Moved a copy of Flow plugin from within Craig's naiad.app package into a plugins subdirectory where the new spoon client compatible MacIntel universal VM was run from. Followed Craig's Spoon instructions for loading niaid.st and niaid.pr into the 3.10 image (Squeak-dev-114-2) running on the new VM. Did the run spoon.app thing from Spoon.dmg (version 2a12), needs to be done twice if Safari is not running. Got Spoon processor running. Followed instructions again in the Spoon client and lo! Got OtherBrowser browsing the Spoon memory running on processor. Yay Craig! Who do i get to sign my certificate? :) Ken

4 7

Simulate "3+4" with InterpreterSimulator
by Ang BeePeng 08 Sep '10

08 Sep '10

Hi, I have a InterpreterSimulator start up, in a workspace I type "3+4". From here, I want to step through bytecode per bytecode, when I hit "print". What should I do to achieve this? Can I debug on the interpreter in the middle of the simulation? Or perhaps I need to put a "self halt" somewhere in the VM source? Thanks. Ang Beepeng -- View this message in context: http://n4.nabble.com/Simulate-3-4-with-InterpreterSimulator-tp1678060p16780… Sent from the Squeak - VM mailing list archive at Nabble.com.

5 20

New Windows VM: 4.0.1
by Andreas Raab 06 Apr '10

06 Apr '10

Folks - I've built a new Windows VM for the upcoming release (mostly to fix the SqueakMap problem). Good thing I tried it first - it turns out that my earlier fix for SqueakMap had fixed one particular version of the problem, but there was another variant that it hadn't addressed (now it does). With this VM I can use SqueakMap successfully. However, since this was a major version switch I've also changed two more issues that came up in the past: 1) The VM will now default to pass the window close event to the image instead of handling it directly. You can see that in a current trunk image by clicking on the close button (you'll now get a Squeak notifier instead of the previous VM notifier). The old behavior is still available if you SHIFT-Click on the close button. This is very useful if your image hangs. 2) The VM name now reflects the version. In other words, this VM is called Squeak4.0.1.exe to make it easier to distinguish between versions. Unfortunately this also means you'll heave to create a new association if you want to use this VM (hopefully, the installer will take care of that later). As always the VM is available here: http://squeakvm.org/win32/release/SqueakVM-Win32-4.0.1-bin.zip http://squeakvm.org/win32/release/SqueakVM-Win32-4.0.1-src.zip Cheers, - Andreas

5 8

VMMaker commit messages?
by Andreas Raab 01 Apr '10

01 Apr '10

Hi - Does anyone know how to turn on commit messages for VMMaker on Squeaksource? I feel like really missing out without them :-) Since the traffic should be fairly low volume I also don't see an issue with overload of the mailing list but it would make for a real good companion to the SVN commit logs. Thanks! - Andreas

4 5

Re: Mac Carbon VM 4.2.3b1 sound recording busted
by Andreas Raab 31 Mar '10

31 Mar '10

On 3/30/2010 8:19 PM, John M McIntosh wrote: >> Mac Carbon VM 4.2.3b1 sound recording busted > > Must always remember to test (lot more) things after applying VMMaker changes. > I'll have a 4.2.4b1 VM in a few days after some dust settles. > > But for now if you hit the SoundRecorder record button in your squeak.image it will crash. Oh dear. Same for Windows 4.0.1. Any ideas what's causing this? Cheers, - Andreas

3 3

[commit] r2159 - Latest updates for soundplugin.h and macintosh carbon VM sound recording fixes
by commits＠squeakvm.org 30 Mar '10

30 Mar '10

Author: johnmci Date: 2010-03-30 14:54:16 -0700 (Tue, 30 Mar 2010) New Revision: 2159 Modified: trunk/platforms/Cross/plugins/SoundPlugin/SoundPlugin.h trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.c trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.h trunk/platforms/Mac OS/plugins/SoundPlugin/sqUnixSoundMacOSXJMM.c trunk/platforms/Mac OS/vm/Documentation/4.x.x Release Notes.rtf Log: Latest updates for soundplugin.h and macintosh carbon VM sound recording fixes Modified: trunk/platforms/Cross/plugins/SoundPlugin/SoundPlugin.h =================================================================== --- trunk/platforms/Cross/plugins/SoundPlugin/SoundPlugin.h 2010-03-29 01:16:36 UTC (rev 2158) +++ trunk/platforms/Cross/plugins/SoundPlugin/SoundPlugin.h 2010-03-30 21:54:16 UTC (rev 2159) @@ -6,8 +6,8 @@ /* sound output */ sqInt snd_AvailableSpace(void); -sqInt snd_InsertSamplesFromLeadTime(sqInt frameCount, usqInt * srcBufPtr, sqInt samplesOfLeadTime); -sqInt snd_PlaySamplesFromAtLength(sqInt frameCount, usqInt* arrayIndex, sqInt startIndex); +sqInt snd_InsertSamplesFromLeadTime(sqInt frameCount, void *srcBufPtr, sqInt samplesOfLeadTime); +sqInt snd_PlaySamplesFromAtLength(sqInt frameCount, void *srcBufPtr, sqInt startIndex); sqInt snd_PlaySilence(void); sqInt snd_Start(sqInt frameCount, sqInt samplesPerSec, sqInt stereo, sqInt semaIndex); sqInt snd_Stop(void); @@ -17,11 +17,12 @@ sqInt snd_StartRecording(sqInt desiredSamplesPerSec, sqInt stereo, sqInt semaIndex); sqInt snd_StopRecording(void); double snd_GetRecordingSampleRate(void); -sqInt snd_RecordSamplesIntoAtLength(usqInt * buf, sqInt startSliceIndex, sqInt bufferSizeInBytes); -void snd_Volume(double *left, double *right); //johnmci(a)smalltalkconsulting.com Nov 6th 2000 -void snd_SetVolume(double left, double right);//johnmci(a)smalltalkconsulting.com Nov 6th 2000 +sqInt snd_RecordSamplesIntoAtLength(void *buf, sqInt startSliceIndex, sqInt bufferSizeInBytes); +void snd_Volume(double *left, double *right); /* johnmci(a)smalltalkconsulting.com Nov 6th 2000 */ +void snd_SetVolume(double left, double right); /* johnmci(a)smalltalkconsulting.com Nov 6th 2000 */ /* mixer interface */ sqInt snd_GetSwitch(sqInt identifier, sqInt captureFlag, sqInt channel); sqInt snd_SetSwitch(sqInt identifier, sqInt captureFlag, sqInt parameter); sqInt snd_SetDevice(sqInt identifier, char *name); + Modified: trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.c =================================================================== --- trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.c 2010-03-29 01:16:36 UTC (rev 2158) +++ trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.c 2010-03-30 21:54:16 UTC (rev 2159) @@ -7,9 +7,9 @@ * */ -#include "sqMacUnixInterfaceSound.h" #include "sq.h" +#include "sqMacUnixInterfaceSound.h" #include "SoundPlugin.h" #include "SqModule.h" #include "SqSound.h" @@ -36,14 +36,14 @@ return sound_AvailableSpace(); } -sqInt snd_InsertSamplesFromLeadTime(sqInt frameCount, usqInt* srcBufPtr, sqInt samplesOfLeadTime) +sqInt snd_InsertSamplesFromLeadTime(sqInt frameCount, void* srcBufPtr, sqInt samplesOfLeadTime) { return sound_InsertSamplesFromLeadTime(frameCount, srcBufPtr, samplesOfLeadTime); } -sqInt snd_PlaySamplesFromAtLength(sqInt frameCount, usqInt* arrayIndex, sqInt startIndex) +sqInt snd_PlaySamplesFromAtLength(sqInt frameCount, void *srcBufPtr, sqInt startIndex) { - return sound_PlaySamplesFromAtLength(frameCount, arrayIndex, startIndex); + return sound_PlaySamplesFromAtLength(frameCount, srcBufPtr, startIndex); } sqInt snd_PlaySilence(void) @@ -78,7 +78,7 @@ return sound_GetRecordingSampleRate(); } -sqInt snd_RecordSamplesIntoAtLength(usqInt *buf, sqInt startSliceIndex, sqInt bufferSizeInBytes) +sqInt snd_RecordSamplesIntoAtLength(void *buf, sqInt startSliceIndex, sqInt bufferSizeInBytes) { return sound_RecordSamplesIntoAtLength(buf, startSliceIndex, bufferSizeInBytes); } Modified: trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.h =================================================================== --- trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.h 2010-03-29 01:16:36 UTC (rev 2158) +++ trunk/platforms/Mac OS/plugins/SoundPlugin/sqMacUnixInterfaceSound.h 2010-03-30 21:54:16 UTC (rev 2159) @@ -6,21 +6,18 @@ * */ - char *dpyPixels = 0; - int dpyPitch = 0; - int noSoundMixer = 0; - int sound_AvailableSpace(void); - int sound_InsertSamplesFromLeadTime(int frameCount, int srcBufPtr, int samplesOfLeadTime); - int sound_PlaySamplesFromAtLength(int frameCount, int arrayIndex, int startIndex); - int sound_PlaySilence(void); - int sound_Start(int frameCount, int samplesPerSec, int stereo, int semaIndex); - int sound_Stop(void); + sqInt sound_AvailableSpace(void); + sqInt sound_InsertSamplesFromLeadTime(sqInt frameCount, void* srcBufPtr, sqInt samplesOfLeadTime); + sqInt sound_PlaySamplesFromAtLength(sqInt frameCount, void* srcBufPtr, sqInt startIndex); + sqInt sound_PlaySilence(void); + sqInt sound_Start(sqInt frameCount, sqInt samplesPerSec, sqInt stereo, sqInt semaIndex); + sqInt sound_Stop(void); /* input */ - int sound_StartRecording(int desiredSamplesPerSec, int stereo, int semaIndex); - int sound_StopRecording(void); + sqInt sound_StartRecording(sqInt desiredSamplesPerSec, sqInt stereo, sqInt semaIndex); + sqInt sound_StopRecording(void); double sound_GetRecordingSampleRate(void); - int sound_RecordSamplesIntoAtLength(int buf, int startSliceIndex, int bufferSizeInBytes); + sqInt sound_RecordSamplesIntoAtLength(void * buf, sqInt startSliceIndex, sqInt bufferSizeInBytes); /* mixer */ void sound_Volume(double *left, double *right); void sound_SetVolume(double left, double right); - int sound_SetRecordLevel(int level); + sqInt sound_SetRecordLevel(sqInt level); Modified: trunk/platforms/Mac OS/plugins/SoundPlugin/sqUnixSoundMacOSXJMM.c =================================================================== --- trunk/platforms/Mac OS/plugins/SoundPlugin/sqUnixSoundMacOSXJMM.c 2010-03-29 01:16:36 UTC (rev 2158) +++ trunk/platforms/Mac OS/plugins/SoundPlugin/sqUnixSoundMacOSXJMM.c 2010-03-30 21:54:16 UTC (rev 2159) @@ -66,6 +66,7 @@ #include <string.h> #include <assert.h> + #define SqueakFrameSize 4 // guaranteed (see class SoundPlayer) #define DeviceFrameSize 8 // ditto (<CoreAudio/AudioHardware.h>, para 9) @@ -77,12 +78,17 @@ #if (!TESTING) # include "sq.h" #else - sqInt noSoundMixer= 0; inline sqInt signalSemaphoreWithIndex(sqInt sema) { return 0; } inline sqInt success(sqInt flag) { return 0; } inline sqInt primitiveFail(void) { return -1; } #endif +#include "sqMacUnixInterfaceSound.h" + +char *dpyPixels = 0; +sqInt dpyPitch = 0; +sqInt noSoundMixer = 0; + #if (DEBUG) void dumpFormat(AudioStreamBasicDescription *fmt); // atend @@ -737,9 +743,7 @@ // Note: this is only used when the "sound quick start" preference is // enabled in the image. // - sqInt sound_InsertSamplesFromLeadTime(sqInt frameCount, usqInt* srcBufPtr, - sqInt framesOfLeadTime); - sqInt sound_InsertSamplesFromLeadTime(sqInt frameCount, usqInt* srcBufPtr, + sqInt sound_InsertSamplesFromLeadTime(sqInt frameCount, void* srcBufPtr, sqInt framesOfLeadTime) { #pragma unused(framesOfLeadTime) @@ -828,8 +832,8 @@ // play (exactly) frameCount of samples (and no less, since the result is // ignored). // - sqInt sound_PlaySamplesFromAtLength(sqInt frameCount, usqInt* arrayIndex, sqInt startIndex); - sqInt sound_PlaySamplesFromAtLength(sqInt frameCount, usqInt* arrayIndex, sqInt startIndex) + + sqInt sound_PlaySamplesFromAtLength(sqInt frameCount, void* arrayIndex, sqInt startIndex) { if (output) { @@ -965,15 +969,18 @@ } - sqInt sound_RecordSamplesIntoAtLength(sqInt buf, sqInt startSliceIndex, sqInt bufferSizeInBytes); - sqInt sound_RecordSamplesIntoAtLength(sqInt buf, sqInt startSliceIndex, sqInt bufferSizeInBytes) + sqInt sound_RecordSamplesIntoAtLength(void * buf, sqInt startSliceIndex, sqInt bufferSizeInBytes) { if (input) { if (Buffer_avail(input->buffer) >= (512 * DeviceFrameSize)) { sqInt start= startSliceIndex * SqueakFrameSize / 2; - UInt32 count= min(input->cvtBufSize, bufferSizeInBytes - start); + sqInt count= min(input->cvtBufSize, bufferSizeInBytes); + if (count <= 0) { + success(false); + return 0; + } if (kAudioHardwareNoError == AudioConverterFillBuffer(input->converter, bufferDataProc, input, &count, (char *)buf + start)) return count / (SqueakFrameSize / 2) / input->channels; Modified: trunk/platforms/Mac OS/vm/Documentation/4.x.x Release Notes.rtf =================================================================== --- trunk/platforms/Mac OS/vm/Documentation/4.x.x Release Notes.rtf 2010-03-29 01:16:36 UTC (rev 2158) +++ trunk/platforms/Mac OS/vm/Documentation/4.x.x Release Notes.rtf 2010-03-30 21:54:16 UTC (rev 2159) @@ -1,4 +1,4 @@ -{\rtf1\ansi\ansicpg1252\cocoartf1038\cocoasubrtf250 +{\rtf1\ansi\ansicpg1252\cocoartf1038\cocoasubrtf290 {\fonttbl\f0\fnil\fcharset0 Geneva;\f1\fswiss\fcharset0 Helvetica;} {\colortbl;\red255\green255\blue255;\red0\green116\blue0;} \margl1440\margr1440\vieww13080\viewh12220\viewkind0 @@ -15,11 +15,16 @@ Aug 20th, 2009 (4.2.1b1)\ Sept 17th, 2009 (4.2.2b1)\ Mar 13th, 2010 (4.2.3b1)\ +Mar 29th 2010 (4.2.4b1)\ \ \ -\ Still yet to do, in future versions -> Verify that file delete rename etc works on aliases, not the targets. (Yawn, someday)\ \ +4.2.4b1 We update to VMMaker 166 \ + imageFormatBackwardCompatibilityVersion\ + uti clock \ + We fix sound record buffer crash after vmmaker 163\ + \ 4.2.3b1 We update to VMMaker 160\ \ Reference Mantis 7405: Array new: SmallInteger maxVal broken.\

1 0

VMMaker-eem.163 fixes old SoundPlugin bug
by Eliot Miranda 30 Mar '10

30 Mar '10

Use of primitiveSoundRecordSamples with a start index other than 1 could corrupt the heap if enough samples were recorded. Name: VMMaker-eem.163 Author: eem Time: 22 March 2010, 5:15:57 pm UUID: 2fa86dda-e18c-48cd-bcac-856504aba8dc Ancestors: VMMaker-ar.162 SoundPlugin: fix bounds bug in primitiveSoundRecordSamples. The call to snd_RecordSamplesIntoAtLength neglected to subtract the start index from the size of the buffer to be written into. best Eliot

6 8

VMMaker[Tool] considered harmful
by Andreas Raab 29 Mar '10

29 Mar '10

Folks - This is probably not the best time to raise this issue but I've been increasingly unhappy about VMMaker over time (ask Eliot :-) From my perspective VMMaker is now a tool that gets more in your way than it helps. I'd like to make to make it *much* simpler. Here's what I think VMMaker ought to do: * Translate a set of classes into C code in a specific directory. Period. No fuzzing with second-guessing of absence or presence of platform or support directories, no upfront-decisions about what plugins to build internally vs. externally, no guessing about the layout of the files in a particular port, no copying files between unrelated directories. In our internal Teleplace images (where we already do this) the usage of VMMaker has been reduced to the following expression: VMMaker generate: CoInterpreter to: (FileDirectory default pathFromURI: '../src') excluding:#( BrokenPlugin DShowVideoDecoderPlugin IA32ABIPluginSimulator NewsqueakIABIPlugin NewsqueakIABIPluginAttic QuicktimePlugin QVideoCodecPlugin QwaqMediaPlugin SlangTestPlugin TestOSAPlugin ThreadedFFIPlugin Win32OSProcessPlugin ). All plugins and the main VM are generated into ../src (or whatever directory you give it) and we provide a list of plugins not to translate (although strictly speaking that's not necessary). The result is a structure that looks like here: <build root>/ platforms/ <the vmmaker platform tree> src/ <shared generated vm sources> mingwbuild/ <windows mingw build specific> cygwinbuild/ <cygwin build on windows> mscbuild/ <MSVC build on windows> macbuild/ <mac build specific> unixbuild/ <unix specific build> "... and more builds ..." Each of the *builds* then defines which plugins to use internal and which ones external (for example by modifying plugins.int and plugins.ext or by changing the appropriate build files) and takes responsibility for the location of the required support files. To me, it makes really no sense to have half of the actions being done by VMMaker and the other half by the native build environment. Since a native build environment will continue to exist for the foreseeable time I'm advocating to abandon the use of the VMMaker in the way we're doing today and reduce it to simply a generator of C code. Cheers, - Andreas

4 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2010