Vm-dev February 2022

vm-dev@lists.squeakfoundation.org

11 participants
83 discussions

[OpenSmalltalk/opensmalltalk-vm] Allow choosing an image via zenity when no arguments are provided (#408)
by Leon Matthes 05 Jun '23

05 Jun '23

You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408 -- Commit Summary -- * Add file chooser dialog to squeak.sh.in * Add file chooser dialog to bin.squeak.sh.in -- File Changes -- M platforms/unix/config/bin.squeak.sh.in (13) M platforms/unix/config/squeak.sh.in (13) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/408

4 8

[OpenSmalltalk/opensmalltalk-vm] VM crash (probably wrong forward pointer calculation) (Issue #614)
by unique75m 07 Sep '22

07 Sep '22

This I what I get in the VS2022 debugger. Of course, at the moment I do not understand the code there, but maybe hopefully Eliot can see something interesting in it. I leave VS open and look tomorrow at the code, maybe I understand a bit of it :-) Seems there is something wrong with the forward pointers. I assume the longAt(referent) fails? I guess it is a macro, but VS could not find the definition. ########## Code area - the --> line is failing with access violation ########### /* begin literalCountOfMethodHeader: */ assert((((header) & 7) == 1)); numLiterals = ((header >> 3)) & AlternateHeaderNumLiteralsMask; numSlots = numLiterals + LiteralStart; l9: /* end numStrongSlotsOf:format:ephemeronInactiveIf: */; for (i = 0; i < numSlots; i += 1) { referent = longAt((referrer + BaseHeaderSize) + (((sqInt)((usqInt)(i) << (shiftForWord()))))); if ((!(referent & (tagMask())))) { /* a forwarding pointer could be because of become: or scavenging. */ --> if ((!((longAt(referent)) & ((classIndexMask()) - (isForwardedObjectClassIndexPun()))))) { /* begin followForwarded: */ assert(isUnambiguouslyForwarder(referent)); /* begin fetchPointer:ofMaybeForwardedObject: */ referent1 = longAt((referent + BaseHeaderSize) + (0U << (shiftForWord()))); while (((!(referent1 & (tagMask())))) && ((!((longAt(referent1)) & ((classIndexMask()) - (isForwardedObjectClassIndexPun())))))) { /* begin fetchPointer:ofMaybeForwardedObject: */ referent1 = longAt((referent1 + BaseHeaderSize) + (0U << (shiftForWord()))); } referent = referent1; ########## Call stack ############ Squeak.exe!scavengeReferentsOf(__int64 referrer) Zeile 42680 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (42680) Squeak.exe!scavengeRememberedSetStartingAt(__int64 n) Zeile 42760 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (42760) Squeak.exe!scavengeLoop() Zeile 42542 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (42542) Squeak.exe!doScavenge(__int64 tenuringCriterion) Zeile 47599 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (47599) Squeak.exe!scavengingGCTenuringIf(__int64 tenuringCriterion) Zeile 57959 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (57959) Squeak.exe!sufficientSpaceAfterGC(__int64 numBytes) Zeile 58691 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (58691) Squeak.exe!checkForEventsMayContextSwitch(__int64 mayContextSwitch) Zeile 62762 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (62762) Squeak.exe!handleStackOverflowOrEventAllowContextSwitch(__int64 mayContextSwitch) Zeile 66037 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (66037) Squeak.exe!ceStackOverflow(__int64 contextSwitchIfNotNil) Zeile 15593 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (15593) [Externer Code] Squeak.exe!ioInitHeartbeat() Zeile 420 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\platforms\win32\vm\sqWin32Heartbeat.c (420) Squeak.exe!interpret() Zeile 2875 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\src\spur64.cog\cointerp.c (2875) Squeak.exe!sqMain(int argc, char * * argv) Zeile 1761 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\platforms\win32\vm\sqWin32Main.c (1761) Squeak.exe!WinMain(HINSTANCE__ * hInst, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Zeile 1851 unter C:\Users\joerg\Persoenlich\Entwicklung\Squeak\vmssource\trunk\platforms\win32\vm\sqWin32Main.c (1851) [Externer Code] ########## Locals ############ classFormat 662660168776 __int64 contextSize 72198296718755736 __int64 fmt 2 __int64 foundNewReferentOrIsWeakling 0 __int64 header 140698790658008 __int64 header1 140698758633160 __int64 i 37029628 __int64 newLocation 811789632 __int64 numLiterals 64 __int64 numSlots 167772160 __int64 numSlots1 255 unsigned __int64 numSlots2 167772160 unsigned __int64 objOop1 72057594139401638 __int64 referent 139599658561184 __int64 referent1 0 __int64 referrer 140700938141704 __int64 sp 72058702004626295 __int64 ############## Second try ################## I needed to restart it again, here are my new local values in debugger classFormat 973468582328 __int64 contextSize 72198310804720808 __int64 fmt 2 __int64 foundNewReferentOrIsWeakling 0 __int64 header 140699864399832 __int64 header1 140698758633160 __int64 i 81749860 __int64 newLocation 2070121416 __int64 numLiterals 64 __int64 numSlots 335544320 __int64 numSlots1 255 unsigned __int64 numSlots2 335544320 unsigned __int64 objOop1 72057594296693111 __int64 referent 139620721982368 __int64 referent1 0 __int64 referrer 140711869546504 __int64 sp 72058702004626295 __int64 numSlots seems to me very wrong. If I do some calculations I get also not the same value that the debugger says me. Here is the code numLiterals = ((header >> 3)) & AlternateHeaderNumLiteralsMask; numSlots = numLiterals + LiteralStart; AlternateHeaderNumLiteralsMask seems to be 0x7fff LiteralStart seems to be 1 For me is: numLiterals = ((140699864399832 >> 3)) & 0x7fff = 32763 —> does not match the debugger local, where is the 64 coming from Seems to me somebody has overridden already the „header“ variable, which seems to be wrong. Could it be that some other thread is writing in the wrong memory area and override my values? Jörg ########## System Information ############## Gerätename timemachine Prozessor AMD Ryzen 9 3900X 12-Core Processor 3.80 GHz Installierter RAM 32,0 GB Geräte-ID F6FA897B-DDB1-44D6-9BF3-8BD1110AA754 Produkt-ID 00326-10048-08575-AA867 Systemtyp 64-Bit-Betriebssystem, x64-basierter Prozessor Stift- und Toucheingabe Für diese Anzeige ist keine Stift- oder Toucheingabe verfügbar. Edition Windows 10 Home Version 20H2 Installiert am ‎23.‎03.‎2021 Betriebssystembuild 19042.1526 Leistung Windows Feature Experience Pack 120.2212.4170.0 Visual Studio 2022 win64x64\squeak.cog.spur VM version ??? I ask Eliot how i can see that on my current local github clone and post it later ############# Code for reproducation ############## Simply execute the following Smalltalk code. Maybe you need to run it multiple times, for me the crash happens sometimes at the 3rd or 4th try. | oc | oc := OrderedCollection new. 400000000 timesRepeat: [oc add: Object new] -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/614 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/614(a)github.com>

1 4

[OpenSmalltalk/opensmalltalk-vm] Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) (#575)
by Ken Dickey 10 Jul '22

10 Jul '22

With libevdev, mouse and keyboard are bound to devices in /dev/input with names like "event0" and "event1". Different keyboard/mouse hw binds to different numbers, so it is important to allow overrides via shell variables. E.g. SQUEAK_MSDEV=/dev/input/event1 SQUEAK_KBDEV=/dev/input/event0 vs SQUEAK_MSDEV=/dev/input/event0 SQUEAK_KBDEV=/dev/input/event1 Mouse rebinding works, but not keyboard rebinding. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/575

1 2

[OpenSmalltalk/opensmalltalk-vm] Feature Request: Add buildstamp to release assets (Issue #610)
by Christoph Thiede 07 Jul '22

07 Jul '22

My download folder looks pretty cluttered with names such as `squeak.cog.spur_win64x64 (3).zip`. I think it is a best practice to include the version/timestamp name of a build into the asset names. Could we maybe change the asset names to something like `osvm_202112201228_squeak.cog.spur_win64x64.zip`? -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/610 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/610(a)github.com>

3 4

[OpenSmalltalk/opensmalltalk-vm] please update branch oldTrunk (Issue #604)
by Jonas Smedegaard 04 May '22

04 May '22

The oldTrunk branch was last updated in 2016 and misses some 100 commits. Please update to be in sync with http://squeakvm.org/svn/squeak/trunk/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/604

6 15

Next Release Candidate?
by Marcel Taeumel 19 Apr '22

19 Apr '22

Hi all -- What's you overall feeling of having a new release candidate of the OSVM? Overall pace has been decreasing during the last weeks. Maybe this is a good time then? Latest commit was about 10 hours ago. So, wait for 2-3 days and then tag that version, produce binaries and test those? Best, Marcel

7 32

[OpenSmalltalk/opensmalltalk-vm] Patch callback thunkEntry to not optimize (#353)
by Guille Polito 13 Apr '22

13 Apr '22

O2 and O1 compilation produce a segmentation fault due to stack corruption (when debugging we saw some extra pushes from the stack) on callbacks return. This happens on windows 32, when compiling with mingw gcc 7.4.0. The issue can be reproduced easily by running the Alien qsort example in latest vms in both Pharo and Squeak. This PR proposes to patch just the thunkEntry function. Not optimizing just that function solves the issue in our environment, though maybe there is a more fine-grained solution. We should still investigate what is the particular optimization that causes the problem. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353 -- Commit Summary -- * Patch callback thunkEntry to not optimize, failing in win32 using gcc 7.4.0 -- File Changes -- M platforms/Cross/plugins/IA32ABI/ia32abicc.c (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353

4 4

VM Maker: VMMaker.oscog-dtl.3123.mcz
by commits＠source.squeak.org 09 Apr '22

09 Apr '22

David T. Lewis uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-dtl.3123.mcz ==================== Summary ==================== Name: VMMaker.oscog-dtl.3123 Author: dtl Time: 26 December 2021, 12:55:15.357105 pm UUID: a0d4db62-a6ac-4d9c-ba51-5eec2ce0c415 Ancestors: VMMaker.oscog-eem.3122 Support image formats 68533 and 7033. Let the image inform the VM that alternate bytecodes either are or are not in use, and remember the setting when writing or reading the image format number in a shapshot file header. Also support testing the current value of multipleBytecodeSetsActive, and listing the encoder names of supported bytecode sets. Adds two primitives: primitiveMultipleBytecodeSetsActive "Given one boolean parameter, set multipleBytecodeSetsActive to inform the VM that alternate bytecode sets such as SistaV1 are now in use and that the image format number should be updated accordingly. With zero parameters, answer the current value of multipleBytecodeSetsActive." primitiveBytecodeSetsAvailable "Answer the encoder names for the supported bytecode sets." =============== Diff against VMMaker.oscog-eem.3122 =============== Item was changed: VMClass subclass: #InterpreterPrimitives + instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask multipleBytecodeSetsActive' - instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! !InterpreterPrimitives commentStamp: 'eem 9/23/2021 13:20' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables argumentCount <Integer> eventTraceMask <Integer> exceptionPC <Integer> ffiExceptionResponse <Integer> inFFIFlags <Integer> messageSelector <Integer> newMethod <Integer> nextProfileTick <Integer> objectMemory <ObjectMemory> (simulation only) preemptionYields <Boolean> primFailCode <Integer> secondaryErrorCode <Integer> profileMethod <Integer> profileProcess <Integer> profileSemaphore <Integer> sHEAFn <Integer> argumentCount - the number of arguments of the current message eventTraceMask - a bit mask corresponding to the Event type codes in sq.h that decides what events are printed in primitiveGetNextEvent exceptionPC - the pc of an exception for an exception reporting primitive failure such as PrimErrFFIException ffiExceptionResponse - controls system response to exceptions during FFI calls. See primitiveFailForFFIException:at: inFFIFlags - flags recording currently only whether the system is in an FFI call messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode - primitive success/failure flag, 0 for success, otherwise the reason code for failure profileMethod - the primitive method active when the last profile sample was taken (if any) profileProcess - the process active when the last profile sample was taken profileSemaphore - the semaphore to be signalled when a profile sample is taken; if nil disables profiling secondaryErrorCode - a 64-bit value settable for clonable primitive failures (PrimErrOSError, PrimErrFFIException et al) profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached secondaryErrorCode - an additional value associated with various primitive failures sHEAFn - the function to call to check if access to the envronment should be granted to primitiveGetenv! Item was added: + ----- Method: InterpreterPrimitives>>primitiveBytecodeSetsAvailable (in category 'other primitives') ----- + primitiveBytecodeSetsAvailable + "Answer the encoder names for the supported bytecode sets." + <export: true> + | encoderNames | + argumentCount >0 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + encoderNames := self instantiateClass: self classArray indexableSize: 3. + self storePointer: 0 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3'). + self storePointer: 1 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3PlusClosures'). + self storePointer: 2 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForSistaV1'). + self pop: 1 thenPush: encoderNames. + ! Item was added: + ----- Method: InterpreterPrimitives>>primitiveMultipleBytecodeSetsActive (in category 'other primitives') ----- + primitiveMultipleBytecodeSetsActive + "Given one boolean parameter, set multipleBytecodeSetsActive to inform + the VM that alternate bytecode sets such as SistaV1 are now in use and + that the image format number should be updated accordingly. With zero + parameters, answer the current value of multipleBytecodeSetsActive." + + <export: true> + argumentCount >1 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + argumentCount = 1 + ifTrue: [self stackTop = objectMemory trueObject + ifTrue: [self cppIf: MULTIPLEBYTECODESETS + ifTrue: [multipleBytecodeSetsActive := true] + ifFalse: [^self primitiveFailFor: PrimErrUnsupported]] + ifFalse: [self stackTop = objectMemory falseObject + ifTrue: [multipleBytecodeSetsActive := false] + ifFalse:[^self primitiveFailFor: PrimErrBadArgument]]]. + multipleBytecodeSetsActive + ifTrue: [self pop: argumentCount + 1 thenPush: objectMemory trueObject] + ifFalse: [self pop: argumentCount + 1 thenPush: objectMemory falseObject]. + ! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. STACKVM := true. "These flags identify a GC operation (& hence a reason to leak check), or just operations the leak checker can be run for." GCModeFull := 1. "stop-the-world global GC" GCModeNewSpace := 2. "Spur's scavenge, or V3's incremental" GCModeIncremental := 4. "incremental global gc (Dijkstra tri-colour marking); as yet unimplemented" GCModeBecome := 8. "v3 post-become sweeping/Spur forwarding" GCCheckImageSegment := 16. "just a flag for leak checking image segments" GCCheckFreeSpace := 32. "just a flag for leak checking free space; Spur only" GCCheckShorten := 64. "just a flag for leak checking object shortening operations; Spur only" GCCheckPrimCall := 128. "just a flag for leak checking external primitive calls" StackPageTraceInvalid := -1. StackPageUnreached := 0. StackPageReachedButUntraced := 1. StackPageTraced := 2. DumpStackOnLowSpace := 0. MillisecondClockMask := 16r1FFFFFFF. "Note: The external primitive table should actually be dynamically sized but for the sake of inferior platforms (e.g., Mac :-) who cannot allocate memory in any reasonable way, we keep it static (and cross our fingers...)" MaxExternalPrimitiveTableSize := 4096. "entries" MaxJumpBuf := 32. "max. callback depth" FailImbalancedPrimitives := InitializationOptions at: #FailImbalancedPrimitives ifAbsentPut: [true]. EnforceAccessControl := InitializationOptions at: #EnforceAccessControl ifAbsent: [true]. ReturnToInterpreter := 1. "setjmp/longjmp code." "Because of a hack with callbacks in the non-threaded VM they must not conflct with the VM's tag bits." DisownVMForFFICall := 16. + DisownVMForThreading := 32. + + "The multiple bytecodes active bit in the image format number" + MultipleBytecodeSetsBitmask := 512. - DisownVMForThreading := 32 ! Item was changed: ----- Method: StackInterpreter>>readableFormat: (in category 'image save/restore') ----- readableFormat: imageVersion "Anwer true if images of the given format are readable by this interpreter. Allows a virtual machine to accept selected older image formats." <api> + ^ (self imageFormatVersion = (imageVersion bitAnd: ( -1 - MultipleBytecodeSetsBitmask))) "Ignore multiple bytecode support identifier" + or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" - ^imageVersion = self imageFormatVersion "Float words in platform-order" - or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" and: [imageVersion = self imageFormatCompatibilityVersion]] "Float words in BigEndian order"! Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | <var: 'f' type: #sqImageFile> <var: 'headerStart' type: #squeakFileOffsetType> <var: 'sCWIfn' type: #'void *'> <var: 'imageName' declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. "local constants" headerStart := 0. headerSize := objectMemory wordSize * 16. "64 or 128; header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. (self invalidSqImageFile: f) ifTrue: "could not open the image file for writing" [^self primitiveFailFor: PrimErrOperationFailed]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. + multipleBytecodeSetsActive + ifTrue: [self putWord32: (self imageFormatVersion bitOr: MultipleBytecodeSetsBitmask) toFile: f] + ifFalse: [self putWord32: self imageFormatVersion toFile: f]. - self putWord32: self imageFormatVersion toFile: f. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. self putLong: self getSnapshotScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f!

5 16

VM Maker Inbox: BytecodeSets.spur-eem.81.mcz
by commits＠source.squeak.org 08 Apr '22

08 Apr '22

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/BytecodeSets.spur-eem.81.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.81 Author: eem Time: 12 September 2021, 10:20:31.001161 pm UUID: d4391f21-0790-4132-9ae4-97941c8e3809 Ancestors: BytecodeSets.spur-eem.80 Proposed fix for CompiledCode>>#allLiteralsDo: by adding pushSpecialConstant:/sendSpecial:numArgs:. =============== Diff against BytecodeSets.spur-eem.80 =============== Item was changed: ----- Method: InstructionStream>>interpretNSV4ExtendedPush:for: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNSV4ExtendedPush: extB for: client "Implement the extended push for non-zero extensions." "77 01001101 Push false [* 1:true, 2:nil, 3:thisContext, ..., -N: pushExplicitOuter: N, N = Extend B]" extB < 0 ifTrue: [^client pushExplicitOuter: extB negated]. extB < 2 ifTrue: + [^client pushSpecialConstant: extB = 1]. - [^client pushConstant: extB = 1]. extB = 2 ifTrue: + [^client pushSpecialConstant: nil]. - [^client pushConstant: nil]. extB = 3 ifTrue: [^client pushActiveContext]. self error: 'undefined extended push'! Item was changed: ----- Method: InstructionStream>>interpretNext2ByteNSV4Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNext2ByteNSV4Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the two-byte codes. For a table of the bytecode set, see EncoderForNewsqueakV4's class comment." | byte method | method := self method. byte := self method at: pc. pc := pc + 1. "We do an inline quasi-binary search on bytecode" bytecode < 235 ifTrue: [bytecode < 231 ifTrue: [bytecode < 229 ifTrue: [| literal | bytecode = 226 ifTrue: [^client pushReceiverVariable: (extA bitShift: 8) + byte]. literal := method literalAt: (extA bitShift: 8) + byte + 1. bytecode = 227 ifTrue: [^client pushLiteralVariable: literal]. ^client pushConstant: literal]. bytecode = 229 ifTrue: + [^client pushSpecialConstant: (extB bitShift: 8) + byte]. - [^client pushConstant: (extB bitShift: 8) + byte]. ^client pushTemporaryVariable: byte]. bytecode = 231 ifTrue: [^byte < 128 ifTrue: [client pushNewArrayOfSize: byte] ifFalse: [client pushConsArrayWithElements: byte - 128]]. bytecode = 232 ifTrue: [^client storeIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 233 ifTrue: [^client storeIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. ^client storeIntoTemporaryVariable: byte]. bytecode < 238 ifTrue: [bytecode = 235 ifTrue: [^client popIntoReceiverVariable: (extA bitShift: 8) + byte]. bytecode = 236 ifTrue: [^client popIntoLiteralVariable: (method literalAt: (extA bitShift: 8) + byte + 1)]. ^client popIntoTemporaryVariable: byte]. bytecode < 242 ifTrue: [| selector numArgs | selector := method literalAt: (extA bitShift: 5) + (byte // 8) + 1. numArgs := (extB bitShift: 3) + (byte \\ 8). bytecode = 238 ifTrue: [^client send: selector super: false numArgs: numArgs]. bytecode = 239 ifTrue: [^client send: selector super: true numArgs: numArgs]. bytecode = 240 ifTrue: [^client sendToAbsentImplicitReceiver: selector numArgs: numArgs]. ^client sendToAbsentDynamicSuperclass: selector numArgs: numArgs]. bytecode < 245 ifTrue: [bytecode = 242 ifTrue: [^client jump: (extB bitShift: 8) + byte]. ^client jump: (extB bitShift: 8) + byte if: bytecode = 243]. bytecode = 245 ifTrue: [| selector numArgs | selector := method literalAt: (extA bitShift: 5) + (byte // 8) + 1. numArgs := (extB bitShift: 3) + (byte \\ 8). ^client sendToAbsentSelf: selector numArgs: numArgs]. "246-247 1111011 i xxxxxxxx UNASSIGNED 248-249 1111100 i xxxxxxxx UNASSIGNED" ^self unusedBytecode: client at: startPC! Item was changed: ----- Method: InstructionStream>>interpretNextNSV3InstructionFor: (in category '*BytecodeSets-NewsqueakV3-decoding') ----- interpretNextNSV3InstructionFor: client "Send to the argument, client, a message that specifies the type of the next instruction." | byte type offset method | method := self method. byte := method at: pc. type := byte // 16. offset := byte \\ 16. pc := pc+1. "We do an inline binary search on each of the possible 16 values of type." type < 8 ifTrue: [type < 4 ifTrue: [type < 2 ifTrue: [type = 0 ifTrue: [^ client pushReceiverVariable: offset]. ^ client pushTemporaryVariable: offset]. "type = 1" type = 2 ifTrue: [^ client pushConstant: (method literalAt: offset + 1)]. ^ client pushConstant: (method literalAt: offset + 17)]. "type = 3" type < 6 ifTrue: [type = 4 ifTrue: [^ client pushLiteralVariable: (method literalAt: offset + 1)]. ^ client pushLiteralVariable: (method literalAt: offset + 17)]."type = 5" type = 6 ifTrue: [offset < 8 ifTrue: [^ client popIntoReceiverVariable: offset]. ^ client popIntoTemporaryVariable: offset - 8]. "type = 7" offset = 0 ifTrue: [^ client pushReceiver]. + offset < 8 ifTrue: [^ client pushSpecialConstant: (SpecialConstants at: offset)]. - offset < 8 ifTrue: [^ client pushConstant: (SpecialConstants at: offset)]. offset = 8 ifTrue: [^ client methodReturnReceiver]. offset < 12 ifTrue: [^ client methodReturnConstant: (SpecialConstants at: offset - 8)]. offset = 12 ifTrue: [^ client methodReturnTop]. offset = 13 ifTrue: [^ client blockReturnTop]. offset = 14 ifTrue: [| byte2 | byte := method at: pc. pc := pc+1. byte2 := method at: pc. pc := pc+1. ^ client sendToDynamicSuperclass: (method literalAt: byte2 + 1) numArgs: byte]. "offset = 15" byte := method at: pc. pc := pc+1. ^ client pushImplicitReceiverForMessage: (method literalAt: byte + 1)]. type < 12 ifTrue: [type < 10 ifTrue: [type = 8 ifTrue: [^ self interpretNSV3Extension: offset in: method for: client]. "type = 9 (short jumps)" offset < 8 ifTrue: [^ client jump: offset + 1]. ^ client jump: offset - 8 + 1 if: false]. type = 10 ifTrue: "(long jumps)" [byte := method at: pc. pc := pc + 1. offset < 8 ifTrue: [^ client jump: offset - 4 * 256 + byte]. ^ client jump: (offset bitAnd: 3) * 256 + byte if: offset < 12]. "type = 11; arithmetic special selector sends" ^ client + sendSpecial: (Smalltalk specialSelectorAt: offset + 1) - send: (Smalltalk specialSelectorAt: offset + 1) - super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. type = 12 ifTrue: "non-arithmetic special selector sends" [^ client + sendSpecial: (Smalltalk specialSelectorAt: offset + 17) - send: (Smalltalk specialSelectorAt: offset + 17) - super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. "type = 13, 14 or 15" ^ client send: (method literalAt: offset + 1) super: false numArgs: type - 13 "0, 1 & 2"! Item was changed: ----- Method: InstructionStream>>interpretNextNSV4InstructionFor: (in category '*BytecodeSets-NewsqueakV4-decoding') ----- interpretNextNSV4InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForNewsqueakV4's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 224 and: [byte <= 225]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 224 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 12 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset < 14 ifTrue: [offset = 12 ifTrue: [^client pushReceiver]. extB = 0 ifTrue: + [^client pushSpecialConstant: false]. - [^client pushConstant: false]. ^self interpretNSV4ExtendedPush: extB for: client]. + ^client pushSpecialConstant: offset - 14]. "0 & 1" - ^client pushConstant: offset - 14]. "0 & 1" "short sends" div16 < 7 ifTrue: "special selector sends" [div16 = 5 ifTrue: [^client + sendSpecial: (Smalltalk specialSelectorAt: offset + 1) - send: (Smalltalk specialSelectorAt: offset + 1) - super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. ^client + sendSpecial: (Smalltalk specialSelectorAt: offset + 17) - send: (Smalltalk specialSelectorAt: offset + 17) - super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. div16 < 10 ifTrue: "vanilla sends, div16 = 7, 8 & 9" [^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 7]. "implicit receiver send, div16 = 10" div16 = 10 ifTrue: [^client sendToAbsentImplicitReceiver: (method literalAt: offset + 1) numArgs: 0]. "short store pops" offset < 8 ifTrue: [^client popIntoReceiverVariable: offset]. ^client popIntoTemporaryVariable: offset - 8]. "div16 >= 12" div16 < 14 ifTrue: [div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. offset < 8 ifTrue: [^client jump: offset + 1 if: false]. offset < 11 ifTrue: [offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: [^client methodReturnTop]. extA > 0 ifTrue: [^client blockReturnTopFromLevel: extA]. ^client blockReturnTop]. offset = 11 ifTrue: [^client doDup]. offset = 12 ifTrue: [^client doPop]. offset = 13 ifTrue: [^client doNop]. "222 11011110 break ? could have blockCopy: send break, but need a receiver and a pop result" "223 11011111 UNASSIGNED" ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 249 ifTrue: [^self interpretNext2ByteNSV4Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteNSV4Instruction: byte for: client extA: extA extB: extB startPC: savedPC!

2 1

[OpenSmalltalk/opensmalltalk-vm] DnD/Unix: Fix `dropRequestFileName` which removed the trailing slash from the path (PR #616)
by Christoph Thiede 26 Feb '22

26 Feb '22

For more than one year, drag'n'drop from the host system into the VM was broken on Linux/X11 due to a regression introduced via facfd9012e9f95679dc054fde69c13d5d4b514ca. `primitiveDropRequestFileName` would always answer `home/Christoph/myfile.txt` rather than `/home/Christoph/myfile.txt`, causing the file to be ignored on the image-side in Squeak. Now I finally found the cause of the bug, it was a simple off-by-one error. Tested on Linux/Ubuntu with XDG/Nautilus under WSL/VcXsrv. The bug was also reported to occur on native Linux distributions, though. Notes: - [ ] I don't know any system or application that would pass paths in one of the other formats (`file:/path` or `/path`). If anyone knows such applications, this would make a nice reprocase. Could you please test this out in your environment? - Related issue: There was also a bug report for DnD on macOS always being one file behind, i.e., nothing appearing in the image on the first drop, the first file appearing on the drop, etc. However, I think this is unrelated to this bug (different platform) and I have also no option to reproduce this unless Apple provides usable visualization support. If anyone is addressing the issue, skimming the history around facfd9012e9f95679dc054fde69c13d5d4b514ca might be a good starting point, anyway. Mentioning @eliotmiranda as the author of facfd9012e9f95679dc054fde69c13d5d4b514ca and @marceltaeumel FYIO. :-) You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616 -- Commit Summary -- * DnD/Unix: Fix dropRequestFileName which removed the trailing slash from the path -- File Changes -- M platforms/unix/plugins/DropPlugin/sqUnixDragDrop.c (20) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616.diff -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/616(a)github.com>

2 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2022