Vm-dev November 2008

vm-dev@lists.squeakfoundation.org

11 participants
21 discussions

Profiling and delay accuracy
by Andreas Raab 06 Aug '11

06 Aug '11

Hi Folks - For a long time now I had this feeling that MessageTally reports pretty bogus results in many situations without being able to precisely track down why this would be the case. Today I was looking at primitiveResponse() and, much to my surprise, noticed that the checkForInterrupts() that used to be there for years is gone (see Squeak3.6 for example which still has it). The sole reason for this check was to get both high delay accuracy and good profiling behavior. Consider this example: fc := FormCanvas on: Display. MessageTally spyOn:[ 1 to: 100 do:[:i| fc fillColor: Color white. fc printString. ]. ]. Using 3.6 this will be measured correctly as: **Tree** 87.5% {243ms} FormCanvas>>fillColor: |87.5% {243ms} GrafPort>>fillRect:offset: | 87.5% {243ms} GrafPort>>copyBits 12.5% {35ms} FormCanvas(Object)>>printString 12.5% {35ms} FormCanvas(Object)>>printStringLimitedTo: whereas the 3.10 reports it as **Tree** 99.6% {670ms} FormCanvas(Object)>>printString 94.9% {639ms} primitives 4.6% {31ms} FormCanvas(Object)>>printStringLimitedTo: I think you can see the problem and just imagine what this does to any cumulative results. I also wonder what that change does to platforms that don't have high-resolution asynchronous timers. This used to be the one place where we would catch timer changes at high resolution and unless the platform forces high resolution timer interrupts asynchronously (by resetting the interrupt counter) we must be loosing a lot in terms of delay accuracy. (it just so happens that the Windows VM *does* do asynchronous timer interrupts so I never noticed this but I'm very curious about the difference on Linux which typically still has pretty bad timer granularity). Any opinions? My feeling is that the timer check should go back in for all of the above reasons. At the very least a quickCheckForInterrupt() is required but I actually think putting the full check back in is worth it. Cheers, - Andreas

3 3

Joys of Squeak-dev image, VM Compiling on MacIntel and Spoon remote OtherBrowsing
by Ken G. Brown 16 Nov '10

16 Nov '10

MacPro OS X 10.4.9 Xcode 2.4.1 Squeak-dev-114-2, VMMaker 2.8b6.1, Squeak 3.8.15beta6U.app, and version 1657 of svn MacOS VM sources, and Spoon v2a12. Downloaded http://www.squeakvm.org/cgi-bin/viewcvs.cgi/ trunk version 1657 for MacOS Ran squeak-dev-beta-114-2.image on Squeak 3.8.15beta6U.app Loaded VMMaker 3.8b6.1 from dev image Universes. Generated vm sources by following instructions in <http://www.squeakvm.org/cgi-bin/viewcvs.cgi/trunk/platforms/Mac%20OS/vm/Doc…> Fought with Xcode wanting to use MacOSX10.3.9.sdk for ppc which was giving an error which was known and documented in the Readme. Finally figured out what Xcode wanted so built universal app just using 10.4.9 sdk. Couple issues: Exupery references remain in sqnamedPrims.h and sqPlatformSpecific.h from svn version 1657, I just commented them out. Notes said: Info-NPSqueak__Upgraded_.plist was to be found in the Developer directory. I could not find it so scammed a info.plist out of John's Squeak 3.8.15beta6U.app vm. Not sure what impact this has. And much, much diddling about figuring out various things... Finally got a build. It's a lot smaller (3.9MB) than John McIntosh's Squeak 3.8.15beta6U.app (8.1MB), and it looks like it is a PowerPC one but at least it runs. I'll look into the Xcode build process some more. Then: Replaced interp.c with Craig's interp.c for Spoon, rebuilt and got a VM with Spoon client stuff. Downloaded Spoon release 2a12. Moved a copy of Flow plugin from within Craig's naiad.app package into a plugins subdirectory where the new spoon client compatible MacIntel universal VM was run from. Followed Craig's Spoon instructions for loading niaid.st and niaid.pr into the 3.10 image (Squeak-dev-114-2) running on the new VM. Did the run spoon.app thing from Spoon.dmg (version 2a12), needs to be done twice if Safari is not running. Got Spoon processor running. Followed instructions again in the Spoon client and lo! Got OtherBrowser browsing the Spoon memory running on processor. Yay Craig! Who do i get to sign my certificate? :) Ken

4 7

How to use Croquet VMMaker
by Matthew Fulmer 29 Apr '09

29 Apr '09

Hi. In anticipation of working on HydraVM, I am trying to test as close a configuration as possible to HydraVM without being hydra. That is, load the nearest ancestor VMMaker and C sources to hydra, and try to make a working VM. This should help ensure that there are no "normal" bugs once I switch to Hydra, only hydra bugs. So, I did that: Here is my setup: - Fedora core 7 on x86 processor - Release 3.9 image/VM from squeak.org - Load FFI from SqueakMap - Load VMMaker-ar.70 from http://jabberwocky.croquetproject.org:8889/Homebase/ - Checkout http://squeakvm.org/svn/squeak/trunk revision 1796 (The nearest ancestor of HydraVM) I pointed VMMaker at the platforms directory in the checkout, and told it to build source in platforms/unix/src. I selected all plugins to be external, but moved FilePlugin and SocketPlugin to be internal. Then I did mkdir unixbuild cd unixbuild ../platforms/unix/config/configure make make fails linking gnu-interp.o: /bin/sh /home/matthewf/squeak/vm/hydravm-trunk-base/unixbuild/libtool --mode=link gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -export-dynamic -R/usr/local/lib -o squeak vm/vm.a FilePlugin/FilePlugin.a SocketPlugin/SocketPlugin.a disabledPlugins.o version.o -lutil -ldl -lm -lnsl vm/vm.a gcc -g -O2 -fomit-frame-pointer -DLSB_FIRST=1 -o squeak disabledPlugins.o version.o -Wl,--export-dynamic vm/vm.a FilePlugin/FilePlugin.a SocketPlugin/SocketPlugin.a -lutil -ldl -lm -lnsl vm/vm.a -Wl,--rpath -Wl,/usr/local/lib vm/vm.a(gnu-interp.o): In function `primitiveGetWindowLabel': /home/matthewf/squeak/vm/hydravm-trunk-base/unixbuild/vm/gnu-interp.c:15141: undefined reference to `ioGetWindowLabel' vm/vm.a(gnu-interp.o): In function `primitiveSetWindowLabel': /home/matthewf/squeak/vm/hydravm-trunk-base/unixbuild/vm/gnu-interp.c:18770: undefined reference to `ioSetWindowLabelOfSize' collect2: ld returned 1 exit status Building this VM worked when using the latest VMMaker from SqueakMap (VMMaker-tpr.58), everything else the same. Is there something else I need to do in order to build using the Croquet VMMaker? I want to use it specifically, since the Hydra VMMaker is derived from it. The dev notes on Hydra are at http://squeakvm.org/~sig/hydravm/devnotes.html -- Matthew Fulmer -- http://mtfulmer.wordpress.com/ Help improve Squeak Documentation: http://wiki.squeak.org/squeak/808

5 9

UUID new crashes 64bit vm
by Philippe Marschall 29 Jan '09

29 Jan '09

Hi I built a 64bit VM (for 32bit images) from SVN trunk and VMMaker-dtl.102. UUID new causes the VM to segmentation fault. The reason I did this is because I need to have a Unix VM with the cUrl plugin and my system is 64 bit. I need to have the cUrl plugin because I need an https client. If I'm doing it wrong what would be the right way of doing it? Or is there even a recent 64bit Unix VM available that was a cUrl plugin? Cheers Philippe

5 8

SmartSyntaxPluginTMethod>>nullReturnExpr, possible bug?
by Esteban Lorenzano 01 Dec '08

01 Dec '08

Hi, I had to change null output for squeak generated plugins (it was colliding with other libraries needed) and I found this: SmartSyntaxPluginTMethod>>nullReturnExpr ^ TReturnNode new setExpression: (TVariableNode new setName: 'null') this generates correct return lines, but just because "null" is defined previously. If I change null to, e.g. sqNil, the previous method still generates "return null" lines. So I changed the method as follows: SmartSyntaxPluginTMethod>>nullReturnExpr ^ TReturnNode new setExpression: (TVariableNode new setName: 'nil') just replaced "null" for "nil", and everything seems to be working fine. Is this hack correct? Cheers, Esteban

2 1

mmap, changes to co-ordinate mapping to particular address to avoid oops address remapping at startup time.
by John M McIntosh 26 Nov '08

26 Nov '08

In the past year or so there has been discussion of using mmap to set a start address for the offset of object memory so that memory address swizzling does not occur. Also various operating systems vendors say using mmap to page in large files is faster than using fread, this in fact is true and noticeable on the iPhone. This requires a change to VMMaker so that sqAllocateMemory can pass the file pointer and the header size, since in the sqAllocateMemory we need to figure out the file (image size) and also understand the headersize of the image file to return a proper address to work with. #define sqAllocateMemory(x,y,f,headersize) (a) map in the image file as MAP_PRIVATE (copy on write) at a set location, noting that on os-x mmap (file offset) does not allow for non- multiples of page size, so we return the offset into the file as the address. (b) map in the free space at the page boundary rounded up based on the file size, plus the set location. This should give two mmap memory regions side by side. Obvious issues, if any mmap fails we exit. We cannot be sure what will happen for memory mapping in the future, should we attempt recover at some other start location? Source code below for comment. ?bug memory refers to (startOfAnonymousMemory+headersize) yet calculation in sqGrowMemoryBy uses memory and gMaxHeapSize. lazy adding of extra page size to freeSpaceRoundedUpToPageSize is preventing disaster, proper fix is exercise for the reader... extern usqInt gMaxHeapSize; static usqInt gHeapSize; static void *startOfmmapForANONMemory,*startOfmmapForImageFile; static size_t fileRoundedUpToPageSize,freeSpaceRoundedUpToPageSize; /* compute the desired memory allocation */ extern unsigned char *memory; usqInt sqGetAvailableMemory() { return gMaxHeapSize; } usqInt sqAllocateMemoryMac(sqInt minHeapSize, sqInt *desiredHeapSize, FILE * f,usqInt headersize) { void *possibleLocation,*startOfAnonymousMemory; off_t fileSize; struct stat sb; size_t pageSize= getpagesize(); size_t pageMask= ~(pageSize - 1); #define valign(x) ((x) & pageMask) #pragma unused(minHeapSize,desiredHeapSize) possibleLocation = 500*1024*1024; gHeapSize = gMaxHeapSize; /* Lets see about mmap the image file into a chunk of memory at the 500MB boundary rounding up to the page size Then we on the next page anonymously allocate the required free space for young space*/ /* Thanks to David Pennell for suggesting this */ fstat(fileno((FILE *)f), &sb); fileSize = sb.st_size; fileRoundedUpToPageSize = valign(fileSize+pageSize-1); startOfAnonymousMemory = (void *) ((size_t) fileRoundedUpToPageSize + (size_t) possibleLocation); startOfmmapForImageFile = mmap(possibleLocation, fileRoundedUpToPageSize, PROT_READ|PROT_WRITE, MAP_FILE| MAP_PRIVATE,fileno((FILE *)f), 0); if (startOfmmapForImageFile != possibleLocation) { fprintf(stderr, "errno %d\n", errno); perror("startOfmmapForImageFile failed"); exit(42); } freeSpaceRoundedUpToPageSize = valign(gMaxHeapSize)- fileRoundedUpToPageSize+pageSize; startOfmmapForANONMemory = mmap(startOfAnonymousMemory, freeSpaceRoundedUpToPageSize, PROT_READ|PROT_WRITE, MAP_ANON| MAP_SHARED,0,0); if (startOfmmapForANONMemory != startOfAnonymousMemory) { fprintf(stderr, "errno %d\n", errno); perror("startOfmmapForANONMemory failed"); exit(42); } return (usqInt) startOfmmapForImageFile+headersize; } sqInt sqGrowMemoryBy(sqInt memoryLimit, sqInt delta) { if ((usqInt) memoryLimit + (usqInt) delta - (usqInt) memory > gMaxHeapSize) return memoryLimit; gHeapSize += delta; return memoryLimit + delta; } sqInt sqShrinkMemoryBy(sqInt memoryLimit, sqInt delta) { returnsqGrowMemoryBy(memoryLimit,0-delta); } sqInt sqMemoryExtraBytesLeft(sqInt flag) { return gMaxHeapSize - gHeapSize; } void sqMacMemoryFree() { if (memory == NULL) return; munmap(startOfmmapForImageFile,fileRoundedUpToPageSize); munmap(startOfmmapForANONMemory,freeSpaceRoundedUpToPageSize); memory = NULL; }

2 5

[BUG] signedLongAt: 1 put:−2,147,483,648
by John M McIntosh 26 Nov '08

26 Nov '08

I noted the the current VMs don't handle the case of storing −2,147,483,648 (primitive failure) via signed32BitValueOf: usually called via FFI signedLongAt:put: For plugin writers who used signed64BitValueOf: (primitive failure) and signed64BitIntegerFor: returned zero if passed −9,223,372,036,854,775,808. signed64BitIntegerFor: is the one that is nasty since your value of 0x8000000000000000 silently turns in 0. I reopened problem http://bugs.squeak.org/view.php?id=6987 and wrote some SUnits. I also provided a suggested fix, which allows me to run the SUnits. Lastly for Alien I added long long (signed/unsigned) support which is still missing in the FFI plugin so I could do some testing. -- = = = ======================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================

1 0

Interpreter>>signed32BitValueOf: and signed64BitValueOf: broken
by Andreas Raab 26 Nov '08

26 Nov '08

Hi - I just noticed hat Interpreter>>signed32BitValueOf: and signed64BitValueOf: are broken for edge cases. The following example will illustrate the problem: array := IntegerArray new: 1. array at: 1 put: 16rFFFFFFFF. "should fail but doesn't" array at: 1. "answers -1 incorrectly" array := IntegerArray new: 1. array at: 1 put: -16rFFFFFFFF. "should fail but doesn't" array at: 1. "answers 1 incorrectly" The problem is that both signed32BitValueOf: as well as signed64BitValueOf: do not test whether the high bit of the magnitude is set (which it mustn't to fit into a signed integer). The fix is trivial in both cases - basically all that's needed at the end of both functions is this: "Filter out values out of range for the signed interpretation such as 16rFFFFFFFF (positive w/ bit 32 set) and -16rFFFFFFFF (negative w/ bit 32 set). Since the sign is implicit in the class we require that the high bit of the magnitude is not set which is a simple test here" value < 0 ifTrue:[^self primitiveFail]. negative ifTrue:[^0 - value] ifFalse:[^value] Cheers, - Andreas

4 12

can't make latest unix vm - v1954
by Brad Fuller 25 Nov '08

25 Nov '08

Latest trunk (1954) and a clean svn checkout. I tried to make the latest vm under unix and received the following errors. Assuming that this is from latest Pharo changes on OSX which resulted in unix not building. Yes? /bin/sh /home/bfuller/dev/squeak/platforms/unix/libtool --mode=link gcc -O0 -g -DLSB_FIRST=1 -Wl,--hash-style=sysv -export-dynamic -R/usr/local/lib -o squeak vm/vm.a ADPCMCodecPlugin/ADPCMCodecPlugin.a AsynchFilePlugin/AsynchFilePlugin.a BMPReadWriterPlugin/BMPReadWriterPlugin.a B2DPlugin/B2DPlugin.a BitBltPlugin/BitBltPlugin.a CroquetPlugin/CroquetPlugin.a DSAPrims/DSAPrims.a ZipPlugin/ZipPlugin.a DropPlugin/DropPlugin.a FFTPlugin/FFTPlugin.a FilePlugin/FilePlugin.a FloatArrayPlugin/FloatArrayPlugin.a FloatMathPlugin/FloatMathPlugin.a GeniePlugin/GeniePlugin.a JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.a JPEGReaderPlugin/JPEGReaderPlugin.a JoystickTabletPlugin/JoystickTabletPlugin.a Klatt/Klatt.a LargeIntegers/LargeIntegers.a LocalePlugin/LocalePlugin.a Matrix2x3Plugin/Matrix2x3Plugin.a MiscPrimitivePlugin/MiscPrimitivePlugin.a RePlugin/RePlugin.a SecurityPlugin/SecurityPlugin.a SerialPlugin/SerialPlugin.a SocketPlugin/SocketPlugin.a SoundCodecPrims/SoundCodecPrims.a SoundGenerationPlugin/SoundGenerationPlugin.a SoundPlugin/SoundPlugin.a StarSqueakPlugin/StarSqueakPlugin.a SurfacePlugin/SurfacePlugin.a disabledPlugins.o version.o -lutil -ldl -lm -lnsl vm/vm.a mkdir .libs gcc -O0 -g -DLSB_FIRST=1 -Wl,--hash-style=sysv -o squeak disabledPlugins.o version.o -Wl,--export-dynamic vm/vm.a ADPCMCodecPlugin/ADPCMCodecPlugin.a AsynchFilePlugin/AsynchFilePlugin.a BMPReadWriterPlugin/BMPReadWriterPlugin.a B2DPlugin/B2DPlugin.a BitBltPlugin/BitBltPlugin.a CroquetPlugin/CroquetPlugin.a DSAPrims/DSAPrims.a ZipPlugin/ZipPlugin.a DropPlugin/DropPlugin.a FFTPlugin/FFTPlugin.a FilePlugin/FilePlugin.a FloatArrayPlugin/FloatArrayPlugin.a FloatMathPlugin/FloatMathPlugin.a GeniePlugin/GeniePlugin.a JPEGReadWriter2Plugin/JPEGReadWriter2Plugin.a JPEGReaderPlugin/JPEGReaderPlugin.a JoystickTabletPlugin/JoystickTabletPlugin.a Klatt/Klatt.a LargeIntegers/LargeIntegers.a LocalePlugin/LocalePlugin.a Matrix2x3Plugin/Matrix2x3Plugin.a MiscPrimitivePlugin/MiscPrimitivePlugin.a RePlugin/RePlugin.a SecurityPlugin/SecurityPlugin.a SerialPlugin/SerialPlugin.a SocketPlugin/SocketPlugin.a SoundCodecPrims/SoundCodecPrims.a SoundGenerationPlugin/SoundGenerationPlugin.a SoundPlugin/SoundPlugin.a StarSqueakPlugin/StarSqueakPlugin.a SurfacePlugin/SurfacePlugin.a -lutil -ldl -lm -lnsl vm/vm.a -Wl,--rpath -Wl,/usr/local/lib vm/vm.a(sqVirtualMachine.o): In function `sqGetInterpreterProxy': /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:351: undefined reference to `internalIsImmutable' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:352: undefined reference to `internalIsMutable' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:353: undefined reference to `primitiveFailFor' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:354: undefined reference to `classAlien' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:355: undefined reference to `getStackPointer' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:356: undefined reference to `sendInvokeCallbackStackRegistersJmpbuf' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:357: undefined reference to `reestablishContextPriorToCallback' /home/bfuller/dev/squeak/platforms/Cross/vm/sqVirtualMachine.c:358: undefined reference to `classUnsafeAlien' collect2: ld returned 1 exit status make: *** [squeak] Error 1 -- Brad Fuller

4 8

Re: [squeak-dev] Re: [Pharo-project] Alien FFI
by John M McIntosh 24 Nov '08

24 Nov '08

Ok, well asAlien seems to be used as conversion methods to ensure a passed object is an alien. What would you like to do instead? I'll integrate the primitive Error code changes this week and do any clean up. If you would like to suggest which variable bindings can be deleted I'll correct that. On 24-Nov-08, at 9:49 AM, Vassili Bykov wrote: > On Mon, Nov 24, 2008 at 12:13 AM, John M McIntosh > <johnmci(a)smalltalkconsulting.com> wrote: >> I would suggest someone with an eye towards "Compiler, CompileMethod, >> ParseNode" carefully look at the changes in "Alien-Core" to ensure >> I've not >> trashed some important part of the Pharo Compiler or Traits. I >> can't say if >> the changes are destructive or passive? > > Many of those have to do with primitive errorCode support, and it > would be nice to categorize them separately. I didn't look closely, > but those that have to do with variable bindings are likely to be > irrelevant. > > And sorry, but adding #asAlien to True, False and UndefinedObject is > just wrong. Nor should have it been in String from the start. > > Cheers, > > --Vassili > -- = = = ======================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2008