Vm-dev June 2012

vm-dev@lists.squeakfoundation.org

35 participants
74 discussions

ffi-test-main.c fails on FreeBSD
by Gary Dunn 12 Aug '16

12 Aug '16

In conjunction with getting Open Cobalt running on FreeBSD I have been looking into the problems with SqueakFFIPrims on FreeBSD and have reached a point that is beyond my understanding. I am not sure if the fix should come from the VM side or the FreeBSD port maintainer. I needed to get source code back into the ports tree so I did a make in /usr/ports/lang/squeak. I already had the 3.9 tarball, so that just repopulated the source and did the initial build. In the "files" folder I found patch files typical for a FreeBSD port. These patch source files from a generic tarball to work with FreeBSD. The one of interest was patch-platforms__unix__plugins__SqueakFFIPrims__ffi-config which contains ----x-----x----- --- platforms/unix/plugins/SqueakFFIPrims/ffi-config.org Wed Apr 26 20:27:53 2006 +++ platforms/unix/plugins/SqueakFFIPrims/ffi-config Wed Apr 26 20:29:00 2006 @@ -39,6 +39,7 @@ case ${abi} in linux) abi=sysv;; + freebsd*) abi=sysv;; darwin*) abi=darwin;; *) abi=libffi; lib="-lffi";; esac -----x-----x----- I then had the folder work/Squeak-3.9-7/platforms/unix/plugins/SqueakFFIPrims In it is a file 00README which explains how to test FFI. It says to run ffi-test-config but I have no such file. It says to type "make" to build a test suite but the build failed. It says to try with make CPU=any ABI=libffi LIB=-lffi which also failed. I traced the problem to the gcc search paths for includes and libraries -- turns out FreeBSD only searches /usr/include and /usr/lib when the required files are in /usr/local/include and /usr/local/lib. After some fiddling I finally had a "main" to test. It failed: ffi-test-main.c failed at line 361. Here is a bit from that file, ending with line 361: ffiInitialize(); for (ul= 0; ul < 15; ++ul) ffiPushSingleFloat(fa[ul]); GO(FFITypeSingleFloat, many); f= ffiReturnFloatValue(); ffiCleanup(); CHECK(f - ff < FLT_EPSILON); I worked out the CHECK macro but could not find what FLT_EPSILON is. At that point I decided to stop and come to you for help. Where do I go from here? -- Gary Dunn, Honolulu osp(a)aloha.com http://openslate.net/ http://e9erust.blogspot.com/ Sent from Slate001

5 8

Do we have the new primitive?? [WAS] Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?
by Mariano Martinez Peck 16 Dec '15

16 Dec '15

> All I can say is that I am impressed by the numbers it is really much >> faster. >> I still don't understand why I send this email with a subject say >> IdentitySet because what I really need is a fast/large IdentityDictionary >> :( Anyway, there's a place where we can use this LargeIdentitySet in Fuel >> I think). >> >> So Levente, you say this is not possible to adapt this for dictionary? >> can >> we contact Eliot to provide such a primitive? >> > > As promised, I uploaded my LargeIdentityDictionary implementation to > http://leves.web.elte.hu/**squeak/**LargeIdentityDictionary.st<http://leves.web.elte.hu/squeak/LargeIdentityDictionary.st>. > The numbers will be a bit worse compared to LargeIdentitySet, because of > the lack of the primitive, but it's still 2-3x faster than other solutions > (IdentityDictionary, PluggableIdentityDictionary, subclassing, etc). I'm > about to propose this primitive with other improvements on the vm-dev list. > > Hi Eliot/Levente. What is the status of this? Do we have already the new primitive? If true, how can we adapt LargeIdentitySet to use such new primitive? Thanks! > > Levente > > >> thanks >> >> On Fri, Dec 16, 2011 at 3:28 PM, Levente Uzonyi <leves(a)elte.hu> wrote: >> >> On Fri, 16 Dec 2011, Henrik Sperre Johansen wrote: >>> >>> On 16.12.2011 03:26, Levente Uzonyi wrote: >>> >>>> >>>> >>>>> How about my numbers? :) >>>>> >>>>> "Preallocate objects, so we won't count gc time." >>>>> n := 1000000. >>>>> objects := Array new: n streamContents: [ :stream | >>>>> n timesRepeat: [ stream nextPut: Object new ] ]. >>>>> >>>>> set := IdentitySet new: n. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >>>>> >>>>> set := LargeIdentitySet new. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >>>>> >>>>> set := (PluggableSet new: n) >>>>> hashBlock: [ :object | object identityHash * 4096 + object class >>>>> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >>>>> equalBlock: [ :a :b | a == b ]; >>>>> yourself. >>>>> Smalltalk garbageCollect. >>>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >>>>> >>>>> >>>>> I also have a LargeIdentityDictionary, which is relatively fast, but >>>>> not >>>>> as fast as LargeIdentitySet, because (for some unknown reason) we don't >>>>> have a primitive that could support it. If we had a primitive like >>>>> primitive 132 which would return the index of the element if found or >>>>> 0 if >>>>> not, then we could have a really fast LargeIdentityDictionary. >>>>> >>>>> >>>>> Levente >>>>> >>>>> Hehe yes, if writing a version fully exploiting the limited range, >>>> that's >>>> probably the approach I would go for as well. >>>> (IAssuming it's the version at http://leves.web.elte.hu/** >>>> squeak/LargeIdentitySet.st<htt**p://leves.web.elte.hu/squeak/** >>>> LargeIdentitySet.st<http://leves.web.elte.hu/squeak/LargeIdentitySet.st> >>>> > >>>> ) >>>> >>>> Mariano commented in the version at http://www.squeaksource.com/** >>>> FuelExperiments <http://www.squeaksource.com/**FuelExperiments<http://www.squeaksource.com/FuelExperiments>> >>>> that it's >>>> >>>> slow for them, which I guess is due to not adopting #identityHash calls >>>> to >>>> #basicIdentityHash calls for Pharo: >>>> ((0 to: 4095) collect: [:each | each << 22 \\ 4096 ]) asSet size -> 1 >>>> So it basically uses 1 bucket instead of 4096... Whoops. :) >>>> >>>> Uploaded a new version to the MC repository which is adapted for Pharo, >>>> on the same machine my numbers were taken from, it does the same test >>>> as I >>>> used above in 871 ms. (181 with preallocation). >>>> >>>> >>> Cool. One more thing: in Squeak the method using primitive 132 directly >>> was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If >>> this was also added to Pharo, then the #pointsTo: sends should be changed >>> to #instVarsInclude:, otherwise Array can be reported as included even if >>> it wasn't added. >>> I'll upload my LargeIdentityDictionary implementation to the same place >>> this evening, since it's still 2-3 factor faster than other solutionts >>> and >>> there seem to be demand for it. >>> >>> >>> Levente >>> >>> >>> Cheers, >>>> Henry >>>> >>>> >>>> >>>> >>> >> >> -- >> Mariano >> http://marianopeck.wordpress.**com <http://marianopeck.wordpress.com> >> >> > -- Mariano http://marianopeck.wordpress.com

4 12

Shrinking windows when Scratch is run on 4.4.7-2357 VM, Ubuntu 12.04 64bit
by Amos Blanton 30 Jul '12

30 Jul '12

On ubuntu 12.04 64 bit, any change in size of Scratch's window causes it to turn black and slowly shrink down to a thin strip. Quite an interesting bug! Here's a video: http://youtu.be/bpTX7O3NDy4 Fullscreen (via the window button - not Scratch's presentation mode) makes the window fullscreen, but there is no repaint - the window remains black until it is changed back into window mode (by clicking the rectangle). This issue also happens on my 32 bit test OS. Here's the command I used to launch, in case it's helpful: /usr/lib/squeak/4.4.7-2357/squeakvm -encoding UTF-8 -vm-display-x11 -xshm -plugins /usr/lib/scratch/plugins/:/usr/lib/squeak/4.4.7-2357/ -vm-sound-pulse /usr/share/scratch/Scratch.image Any idea what might have changed in the VM that could cause these issues? Could this be related to changes made for compiz compatibility? -Amos

3 8

New VMs at http://www.mirandabanda.org/files/Cog/VM/VM.r2559/
by Eliot Miranda 18 Jul '12

18 Jul '12

http://www.mirandabanda.org/files/Cog/VM/VM.r2559/ CogVM binaries as per VMMaker.oscog-eem.163/r2559. Make wakeHighestPriority filter-out zombie processes; fixes Newspeak/Glue crash. Add -blockonerror flag to Unix & Mac VMs to allow attaching gdb on error/segv. Make the sigsegv handler catch SIGILL and SIGBUS on Unix and Mac. Add 64-bit file support to linux builds. Fix sqUnixX11.c ClipChildren to ClipByChildren. -- best, Eliot

1 1

VM Maker: VMMaker.oscog-eem.182.mcz
by commits＠source.squeak.org 30 Jun '12

30 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.182.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.182 Author: eem Time: 29 June 2012, 6:09:22.966 pm UUID: 57f7399d-992c-49ef-8f0d-258d1b70027c Ancestors: VMMaker.oscog-eem.181 Make arrayInitializerCalled:for:type: create literal string initializers, not arrays of characters. Convert embedded carriage returns in string literals into \n's. =============== Diff against VMMaker.oscog-eem.181 =============== Item was changed: ----- Method: CCodeGenerator>>arrayInitializerCalled:for:type: (in category 'utilities') ----- arrayInitializerCalled: varName for: array type: cType "array is a literal array or a CArray on some array." | sequence lastLine | sequence := array isCollection ifTrue: [array] ifFalse: [array object]. lastLine := 0. ^String streamContents: [:s| s nextPutAll: cType; space; nextPutAll: varName; + nextPutAll: '[] = '. + sequence isString + ifTrue: [s nextPutAll: (self cLiteralFor: sequence)] + ifFalse: + [s nextPut: ${; crtab: 2. + sequence + do: [:element| s nextPutAll: (self cLiteralFor: element)] + separatedBy: + [s nextPut: $,. + (s position - lastLine) > 76 + ifTrue: [s crtab: 2. lastLine := s position] + ifFalse: [s space]]. + s crtab; nextPut: $}]. + s cr]! - nextPutAll: '[] = {'; crtab: 2. - sequence - do: [:element| s nextPutAll: (self cLiteralFor: element)] - separatedBy: - [s nextPut: $,. - (s position - lastLine) > 76 - ifTrue: [s crtab: 2. lastLine := s position] - ifFalse: [s space]]. - s crtab; nextPut: $}; cr]! Item was changed: ----- Method: CCodeGenerator>>cLiteralFor: (in category 'C code generator') ----- cLiteralFor: anObject "Return a string representing the C literal value for the given object." anObject isNumber ifTrue: [anObject isInteger ifTrue: [^(anObject < 16r7FFFFFFF) ifTrue: [anObject printString] ifFalse: [anObject printString , ObjectMemory unsignedIntegerSuffix]]. anObject isFloat ifTrue: [^anObject printString]] ifFalse: [anObject isString ifTrue: + [^'"', (anObject copyReplaceAll: (String with: Character cr) with: '\n') , '"']. - [^'"', anObject, '"']. anObject == nil ifTrue: [^ 'null' ]. anObject == true ifTrue: [^ '1' ]. anObject == false ifTrue: [^ '0' ]. anObject isCharacter ifTrue: [^anObject == $' ifTrue: ['''\'''''] "i.e. '\''" ifFalse: [anObject asString printString]]]. self error: 'Warning: A Smalltalk literal could not be translated into a C constant: ', anObject printString. ^'"XXX UNTRANSLATABLE CONSTANT XXX"'! Item was changed: ----- Method: CCodeGenerator>>cLiteralFor:name: (in category 'C code generator') ----- cLiteralFor: anObject name: smalltalkName "Return a string representing the C literal value for the given object." anObject isInteger ifTrue: [| hex dec rep | hex := anObject printStringBase: 16. dec := anObject printStringBase: 10. rep := ((smalltalkName endsWith: 'Mask') or: [anObject digitLength > 1 and: [(hex asSet size * 3) <= (dec asSet size * 2) and: [(smalltalkName endsWith: 'Size') not]]]) ifTrue: [hex first = $- ifTrue: ['-0x', hex allButFirst] ifFalse: ['0x', hex]] ifFalse: [dec]. ^(anObject < 16r7FFFFFFF) ifTrue: [rep] ifFalse: [rep, ObjectMemory unsignedIntegerSuffix "ikp"]]. anObject isFloat ifTrue: [^anObject printString]. anObject isString ifTrue: + [^'"', (anObject copyReplaceAll: (String with: Character cr) with: '\n') , '"']. - [^'"', anObject, '"']. anObject == nil ifTrue: [^ 'null' ]. anObject == true ifTrue: [^ '1' ]. "ikp" anObject == false ifTrue: [^ '0' ]. "ikp" anObject isCharacter ifTrue:[^anObject asString printString]. "ar" self error: 'Warning: A Smalltalk literal could not be translated into a C constant: ', anObject printString. ^'"XXX UNTRANSLATABLE CONSTANT XXX"'! Item was changed: ----- Method: TAssignmentNode>>emitLiteralArrayDeclarationOn:level:generator: (in category 'C code generation') ----- emitLiteralArrayDeclarationOn: aStream level: level generator: aCCodeGen | type | type := expression args last value. self assert: type last = $*. aStream crtab: level; nextPutAll: '{ static '; + nextPutAll: (aCCodeGen arrayInitializerCalled: 'aLiteralArray' for: expression args first value type: type allButLast) withBlanksTrimmed; - nextPutAll: (aCCodeGen arrayInitializerCalled: 'aLiteralArray' for: expression args first value type: type allButLast); nextPut: $;; crtab: level + 1; nextPutAll: variable name; nextPutAll: ' = aLiteralArray;'; crtab: level; nextPut: $}; cr!

1 0

VM Maker: VMMaker.oscog-eem.181.mcz
by commits＠source.squeak.org 29 Jun '12

29 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.181.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.181 Author: eem Time: 29 June 2012, 1:05:25.822 pm UUID: 37760187-3a5c-4411-9352-754a4782fa29 Ancestors: VMMaker.oscog-eem.180 Check for variable name clashes with C reserved words. Comment touch: =============== Diff against VMMaker.oscog-eem.180 =============== Item was changed: ----- Method: CCodeGenerator>>checkForGlobalUsage:in: (in category 'utilities') ----- checkForGlobalUsage: vars in: aTMethod vars do: [:var | (variables includes: var) ifTrue: "find the set of method names using this global var" [(globalVariableUsage at: var ifAbsentPut: [Set new]) add: aTMethod selector]]. + aTMethod referencesGlobalStructMakeZero. + (aTMethod locals select: [:l| self reservedWords includes: l]) do: + [:l| | em | + em := aTMethod definingClass name, '>>', aTMethod selector, ' has variable that is a C reserved word: ', l. + self error: em. + self logger cr; nextPutAll: em; cr; flush]! - aTMethod referencesGlobalStructMakeZero! Item was added: + ----- Method: CCodeGenerator>>reservedWords (in category 'C translation') ----- + reservedWords + ^#( 'auto' + 'break' + 'case' 'char' 'const' 'continue' + 'default' 'do' 'double' + 'else' 'entry' 'enum' 'extern' + 'float' 'for' + 'goto' + 'if' 'int' + 'long' + 'register' 'return' + 'short' 'signed' 'sizeof' 'static' 'struct' 'switch' + 'typedef' + 'union' 'unsigned' + 'void' 'volatile' + 'while')! Item was changed: ----- Method: Object>>touch: (in category '*VMMaker-translation support') ----- touch: something + "For translation only; eliminated by CCodeGenerator. Used to squash unused varable warnings."! - "For translation only; eliminated by CCodeGenerator"!

1 0

VM Maker: VMMaker.oscog-eem.180.mcz
by commits＠source.squeak.org 28 Jun '12

28 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.180.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.180 Author: eem Time: 28 June 2012, 9:04:19.784 am UUID: d742fc84-467e-47f9-be9e-4ba2dfa74d88 Ancestors: VMMaker.oscog-eem.179 Use workaround for broken Squeak4.3 progress exception when generating VM source. =============== Diff against VMMaker.oscog-eem.179 =============== Item was changed: ----- Method: VMMaker>>generateCogitFile (in category 'generate sources') ----- generateCogitFile "Translate the Smalltalk description of the virtual machine into C. If 'self doInlining' is true, small method bodies are inlined to reduce procedure call overhead. On the PPC, this results in a factor of three speedup with only 30% increase in code size. Subclasses can use specialised versions of CCodeGenerator and interpreterClass." | cg cogitClass | self interpreterClass needsCogit ifFalse: [^nil]. cg := [self buildCodeGeneratorForCogit] on: Notification do: [:ex| ex tag == #getVMMaker ifTrue: [ex resume: self] + ifFalse: [(ex respondsTo: #rearmHandlerDuring:) + ifTrue: [ex rearmHandlerDuring: [ex pass]] + ifFalse: [ex pass]]]. - ifFalse: [ex pass]]. self needsToRegenerateCogitFile ifFalse: [^nil]. cogitClass := self cogitClass. cg removeUnneededBuiltins. cg vmClass preGenerationHook: cg. cg storeCodeOnFile: (self sourceFilePathFor: cogitClass sourceFileName) doInlining: cogitClass doInlining. cg vmClass additionalHeadersDo: [:headerName :headerContents| | filePath | filePath := self coreVMDirectory fullNameFor: headerName. (cg needToGenerateHeader: headerName file: filePath contents: headerContents) ifTrue: [cg storeHeaderOnFile: filePath contents: headerContents]]. cogitClass apiExportHeaderName ifNotNil: [cg storeAPIExportHeader: cogitClass apiExportHeaderName OnFile: (self sourceFilePathFor: cogitClass apiExportHeaderName)]! Item was changed: ----- Method: VMMaker>>generateInterpreterFile (in category 'generate sources') ----- generateInterpreterFile "Translate the Smalltalk description of the virtual machine into C. If 'self doInlining' is true, small method bodies are inlined to reduce procedure call overhead. On the PPC, this results in a factor of three speedup with only 30% increase in code size. Subclasses can use specialised versions of CCodeGenerator and interpreterClass." | cg vmHeaderContents | cg := [self buildCodeGeneratorForInterpreter] on: Notification do: [:ex| ex tag == #getVMMaker ifTrue: [ex resume: self] + ifFalse: [(ex respondsTo: #rearmHandlerDuring:) + ifTrue: [ex rearmHandlerDuring: [ex pass]] + ifFalse: [ex pass]]]. - ifFalse: [ex pass]]. self needsToRegenerateInterpreterFile ifFalse: [^nil]. cg removeUnneededBuiltins. self interpreterClass preGenerationHook: cg. vmHeaderContents := cg vmHeaderContentsWithBytesPerWord: self bytesPerWord. (cg needToGenerateHeader: self interpreterHeaderName file: self interpreterHeaderPath contents: vmHeaderContents) ifTrue: [cg storeHeaderOnFile: self interpreterHeaderPath contents: vmHeaderContents]. cg storeCodeOnFile: (self sourceFilePathFor: self interpreterClass sourceFileName) doInlining: self doInlining. self interpreterClass additionalHeadersDo: [:headerName :headerContents| | filePath | filePath := self coreVMDirectory fullNameFor: headerName. (cg needToGenerateHeader: headerName file: filePath contents: headerContents) ifTrue: [cg storeHeaderOnFile: filePath contents: headerContents]]. self interpreterClass apiExportHeaderName ifNotNil: [cg storeAPIExportHeader: self interpreterClass apiExportHeaderName OnFile: (self sourceFilePathFor: self interpreterClass apiExportHeaderName)]. (Gnuifier on: self coreVMDirectory) interpreterFilename: self interpreterFilename; gnuify.!

1 0

VM Maker: VMMaker.oscog-eem.179.mcz
by commits＠source.squeak.org 28 Jun '12

28 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.179.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.179 Author: eem Time: 27 June 2012, 8:23:19.924 pm UUID: 1d88b152-8a22-4ca4-a96d-06022751a128 Ancestors: VMMaker.oscog-eem.178 Fix str:n:cmp: implementation for short strings =============== Diff against VMMaker.oscog-eem.178 =============== Item was removed: - ----- Method: CogVMSimulator>>str:n:cmp: (in category 'debug printing') ----- - str: aString n: bString cmp: n - "implementation of strncmp(3)" - bString isInteger ifFalse: - [^(aString first: n) ~= (bString first: n)]. - 1 to: n do: - [:i| | v | - v := (aString at: i) asInteger - (self byteAt: bString + i - 1). - v ~= 0 ifTrue: [^v]]. - ^0! Item was changed: ----- Method: VMClass>>str:n:cmp: (in category 'C library simulation') ----- str: aString n: bString cmp: n <doNotGenerate> "implementation of strncmp(3)" bString isString ifTrue: + [^(aString first: (n min: aString size)) ~= (bString first: (n min: bString size))]. - [^(aString first: n) ~= (bString first: n)]. 1 to: n do: [:i| | v | v := (aString at: i) asInteger - (self byteAt: bString + i - 1). v ~= 0 ifTrue: [^v]]. ^0!

1 0

VM Maker: VMMaker.oscog-eem.178.mcz
by commits＠source.squeak.org 28 Jun '12

28 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.178.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.178 Author: eem Time: 27 June 2012, 8:14:54.544 pm UUID: 8a31722d-f528-4495-bcf0-33544f9c93af Ancestors: VMMaker.oscog-eem.177 Fix receiver if isBytes: in printOopShortInner:. Include inst var offset in longPrintOop:. Make doesNotUnderstand: redirection warnings more informative. =============== Diff against VMMaker.oscog-eem.177 =============== Item was changed: ----- Method: CogVMSimulator>>doesNotUnderstand: (in category 'error handling') ----- doesNotUnderstand: aMessage "If this is a doit and the objectMemory understands, pass it on." (thisContext findContextSuchThat: [:ctxt| ctxt selector == #evaluate:in:to:notifying:ifFail:logged:]) ifNotNil: [(objectMemory class whichClassIncludesSelector: aMessage selector) ifNotNil: [:implementingClass| (implementingClass inheritsFrom: Object) ifTrue: "i.e. VMClass and below" + [Transcript nextPutAll: 'warning: redirecting ', aMessage selector, ' in ', thisContext sender printString, ' to objectMemory'; cr; flush. - [Transcript nextPutAll: 'warning: redirecting to objectMemory'; cr; flush. aMessage lookupClass: nil. ^aMessage sentTo: objectMemory]]. (cogit class whichClassIncludesSelector: aMessage selector) ifNotNil: [:implementingClass| (implementingClass inheritsFrom: Object) ifTrue: "i.e. VMClass and below" + [Transcript nextPutAll: 'warning: redirecting ', aMessage selector, ' in ', thisContext sender printString, ' to cogit'; cr; flush. - [Transcript nextPutAll: 'warning: redirecting to cogit'; cr; flush. aMessage lookupClass: nil. ^aMessage sentTo: cogit]]]. ^super doesNotUnderstand: aMessage! Item was changed: ----- Method: StackInterpreter>>longPrintOop: (in category 'debug printing') ----- longPrintOop: oop <api> | fmt lastIndex startIP bytecodesPerLine | ((objectMemory isIntegerObject: oop) or: [(oop between: objectMemory startOfMemory and: objectMemory freeStart) not or: [(oop bitAnd: (BytesPerWord - 1)) ~= 0 or: [(objectMemory isFreeObject: oop) or: [(fmt := objectMemory formatOf: oop) between: 5 and: 11]]]]) ifTrue: [^self printOop: oop]. self printHex: oop; print: ': a(n) '; printNameOfClass: (objectMemory fetchClassOfNonInt: oop) count: 5. fmt > 4 ifTrue: [self print: ' nbytes '; printNum: (objectMemory byteSizeOf: oop)]. self cr. + lastIndex := 256 min: (startIP := (objectMemory lastPointerOf: oop) / BytesPerWord). - lastIndex := 64 min: (startIP := (objectMemory lastPointerOf: oop) / BytesPerWord). lastIndex > 0 ifTrue: [1 to: lastIndex do: + [:i| | fieldOop | + fieldOop := objectMemory fetchPointer: i - 1 ofObject: oop. + self space; printNum: i - 1; space; printHex: fieldOop; space; printOopShort: fieldOop; cr]]. - [:index| | fieldOop | - fieldOop := objectMemory fetchPointer: index - 1 ofObject: oop. - self space; printHex: fieldOop; space; printOopShort: fieldOop; cr]]. (objectMemory isCompiledMethod: oop) ifFalse: [startIP > 64 ifTrue: [self print: '...'; cr]] ifTrue: [startIP := startIP * BytesPerWord + 1. lastIndex := objectMemory lengthOf: oop. lastIndex - startIP > 104 ifTrue: [lastIndex := startIP + 103]. bytecodesPerLine := 8. startIP to: lastIndex do: [:index| | byte | byte := objectMemory fetchByte: index - 1 ofObject: oop. self cCode: 'printf(" %02x/%-3d", byte,byte)' inSmalltalk: [self space; print: (byte radix: 16); printChar: $/; printNum: byte]. (index = lastIndex and: [(objectMemory lengthOf: oop) > index]) ifTrue: [self print: '...']. ((index - startIP + 1) \\ bytecodesPerLine) = 0 ifTrue: [self cr]]. ((lastIndex - startIP + 1) \\ bytecodesPerLine) = 0 ifFalse: [self cr]]! Item was changed: ----- Method: StackInterpreter>>printOopShortInner: (in category 'debug printing') ----- printOopShortInner: oop | classOop name nameLen | <var: #name type: #'char *'> <inline: true> (objectMemory isIntegerObject: oop) ifTrue: [self printNum: (objectMemory integerValueOf: oop); printChar: $(; printHex: (objectMemory integerValueOf: oop); printChar: $). ^nil]. (oop between: objectMemory startOfMemory and: objectMemory freeStart) ifFalse: [self printHex: oop; print: ' is not on the heap'. ^nil]. (oop bitAnd: (BytesPerWord - 1)) ~= 0 ifTrue: [self printHex: oop; print: ' is misaligned'. ^nil]. (self isFloatObject: oop) ifTrue: [self printFloat: (self dbgFloatValueOf: oop). ^nil]. classOop := objectMemory fetchClassOfNonInt: oop. (objectMemory addressCouldBeObj: classOop) ifFalse: [self print: 'a ??'. ^nil]. (objectMemory sizeBitsOf: classOop) = metaclassSizeBits ifTrue: [self printNameOfClass: oop count: 5. ^nil]. oop = objectMemory nilObject ifTrue: [self print: 'nil'. ^nil]. oop = objectMemory trueObject ifTrue: [self print: 'true'. ^nil]. oop = objectMemory falseObject ifTrue: [self print: 'false'. ^nil]. nameLen := self lengthOfNameOfClass: classOop. nameLen = 0 ifTrue: [self print: 'a ??'. ^nil]. name := self nameOfClass: classOop. nameLen = 10 ifTrue: [(self str: name n: 'ByteString' cmp: 10) not "strncmp is weird" ifTrue: [self printChar: $'; printStringOf: oop; printChar: $'. ^nil]. (self str: name n: 'ByteSymbol' cmp: 10) not "strncmp is weird" ifTrue: [self printChar: $#; printStringOf: oop. ^nil]]. (nameLen = 9 and: [(self str: name n: 'Character' cmp: 9) not]) ifTrue: [self printChar: $$; printChar: (objectMemory integerValueOf: (objectMemory fetchPointer: 0 ofObject: oop)). ^nil]. self cCode: [self prin: 'a(n) %.*s' t: nameLen f: name] inSmalltalk: [self print: 'a(n) '; print: name]. "Try to spot association-like things; they're all subclasses of LookupKey" ((objectMemory instanceSizeOf: classOop) = (ValueIndex + 1) and: [(self superclassOf: classOop) = (self superclassOf: (objectMemory fetchClassOfNonInt: (objectMemory splObj: SchedulerAssociation))) + and: [objectMemory isBytes: (objectMemory fetchPointer: KeyIndex ofObject: oop)]]) ifTrue: - and: [self isBytes: (objectMemory fetchPointer: KeyIndex ofObject: oop)]]) ifTrue: [self space; printOopShort: (objectMemory fetchPointer: KeyIndex ofObject: oop); print: ' -> '; printHex: (objectMemory fetchPointer: ValueIndex ofObject: oop)]! Item was changed: ----- Method: StackInterpreterSimulator>>doesNotUnderstand: (in category 'error handling') ----- doesNotUnderstand: aMessage "If this is a doit and the objectMemory understands, pass it on." (thisContext findContextSuchThat: [:ctxt| ctxt selector == #evaluate:in:to:notifying:ifFail:logged:]) ifNotNil: [(objectMemory class whichClassIncludesSelector: aMessage selector) ifNotNil: [:implementingClass| (implementingClass inheritsFrom: Object) ifTrue: "i.e. VMClass and below" + [Transcript nextPutAll: 'warning: redirecting ', aMessage selector, ' in ', thisContext sender printString, ' to objectMemory'; cr; flush. - [Transcript nextPutAll: 'warning: redirecting to objectMemory'; cr; flush. aMessage lookupClass: nil. ^aMessage sentTo: objectMemory]]]. ^super doesNotUnderstand: aMessage!

1 0

VM Maker: VMMaker.oscog-eem.177.mcz
by commits＠source.squeak.org 27 Jun '12

27 Jun '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.177.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.177 Author: eem Time: 27 June 2012, 12:25:12.409 pm UUID: 4d05e29b-763c-451f-9354-f5f0cef201a1 Ancestors: VMMaker.oscog-eem.176 Add internalStackValue:put:. Comment the purpose of the prim response routines. =============== Diff against VMMaker.oscog-eem.176 =============== Item was changed: ----- Method: CoInterpreter>>slowPrimitiveResponse (in category 'primitive support') ----- slowPrimitiveResponse + "Invoke a normal (non-quick) primitive. + Called under the assumption that primFunctionPtr has been preloaded" - "Called under the assumption that primFunctionPtr has been preloaded" | nArgs savedFramePointer savedStackPointer | <inline: true> <asmLabel: false> <var: #savedFramePointer type: #'char *'> <var: #savedStackPointer type: #'char *'> cogit recordPrimTrace ifTrue: [self fastLogPrim: messageSelector]. FailImbalancedPrimitives ifTrue: [nArgs := argumentCount. savedStackPointer := stackPointer. savedFramePointer := framePointer]. self initPrimCall. self dispatchFunctionPointer: primitiveFunctionPointer. (FailImbalancedPrimitives and: [self successful and: [framePointer = savedFramePointer and: [(self isMachineCodeFrame: framePointer) not]]]) ifTrue:"Don't fail if primitive has done something radical, e.g. perform:" [stackPointer ~= (savedStackPointer + (nArgs * BytesPerWord)) ifTrue: [self flag: 'Would be nice to make this a message send of e.g. unbalancedPrimitive to the current process or context'. "This is necessary but insufficient; the result may still have been written to the stack. At least we'll know something is wrong." stackPointer := savedStackPointer. self failUnbalancedPrimitive]]. "If we are profiling, take accurate primitive measures" nextProfileTick > 0 ifTrue: [self checkProfileTick: newMethod]. ^self successful! Item was changed: ----- Method: StackInterpreter>>externalQuickPrimitiveResponse (in category 'primitive support') ----- externalQuickPrimitiveResponse + "Invoke a quick primitive. + Called under the assumption that primFunctionPtr has been preloaded" - "Called under the assumption that primFunctionPtr has been preloaded" | localPrimIndex | self assert: self isPrimitiveFunctionPointerAnIndex. localPrimIndex := self cCoerceSimple: primitiveFunctionPointer to: #sqInt. self assert: (localPrimIndex > 255 and: [localPrimIndex < 520]). "Quick return inst vars" localPrimIndex >= 264 ifTrue: [self pop: 1 thenPush: (objectMemory fetchPointer: localPrimIndex - 264 ofObject: self stackTop). ^true]. "Quick return constants" localPrimIndex = 256 ifTrue: [^true "return self"]. localPrimIndex = 257 ifTrue: [self pop: 1 thenPush: objectMemory trueObject. ^true]. localPrimIndex = 258 ifTrue: [self pop: 1 thenPush: objectMemory falseObject. ^true]. localPrimIndex = 259 ifTrue: [self pop: 1 thenPush: objectMemory nilObject. ^true]. self pop: 1 thenPush: (objectMemory integerObjectOf: localPrimIndex - 261). ^true! Item was changed: ----- Method: StackInterpreter>>internalQuickPrimitiveResponse (in category 'primitive support') ----- internalQuickPrimitiveResponse + "Invoke a quick primitive. + Called under the assumption that primFunctionPtr has been preloaded" - "Called under the assumption that primFunctionPtr has been preloaded" | localPrimIndex | self assert: self isPrimitiveFunctionPointerAnIndex. localPrimIndex := self cCoerceSimple: primitiveFunctionPointer to: #sqInt. self assert: (localPrimIndex > 255 and: [localPrimIndex < 520]). "Quick return inst vars" localPrimIndex >= 264 ifTrue: [self internalStackTopPut: (objectMemory fetchPointer: localPrimIndex - 264 ofObject: self internalStackTop). ^true]. "Quick return constants" localPrimIndex = 256 ifTrue: [^true "return self"]. localPrimIndex = 257 ifTrue: [self internalStackTopPut: objectMemory trueObject. ^true]. localPrimIndex = 258 ifTrue: [self internalStackTopPut: objectMemory falseObject. ^true]. localPrimIndex = 259 ifTrue: [self internalStackTopPut: objectMemory nilObject. ^true]. self internalStackTopPut: (objectMemory integerObjectOf: localPrimIndex - 261). ^true! Item was added: + ----- Method: StackInterpreter>>internalStackValue:put: (in category 'internal interpreter access') ----- + internalStackValue: offset put: aValue + "In the StackInterpreter stacks grow down." + ^stackPages longAtPointer: localSP + (offset * BytesPerWord) put: aValue! Item was changed: ----- Method: StackInterpreter>>slowPrimitiveResponse (in category 'primitive support') ----- slowPrimitiveResponse + "Invoke a normal (non-quick) primitive. + Called under the assumption that primFunctionPtr has been preloaded" - "Called under the assumption that primFunctionPtr has been preloaded" | nArgs savedFramePointer savedStackPointer | <inline: true> <asmLabel: false> <var: #savedFramePointer type: #'char *'> <var: #savedStackPointer type: #'char *'> FailImbalancedPrimitives ifTrue: [nArgs := argumentCount. savedStackPointer := stackPointer. savedFramePointer := framePointer]. self initPrimCall. self dispatchFunctionPointer: primitiveFunctionPointer. (FailImbalancedPrimitives and: [self successful and: [framePointer = savedFramePointer]]) ifTrue:"Don't fail if primitive has done something radical, e.g. perform:" [stackPointer ~= (savedStackPointer + (nArgs * BytesPerWord)) ifTrue: [self flag: 'Would be nice to make this a message send of e.g. unbalancedPrimitive to the current process or context'. "This is necessary but insufficient; the result may still have been written to the stack. At least we'll know something is wrong." stackPointer := savedStackPointer. self failUnbalancedPrimitive]]. "If we are profiling, take accurate primitive measures" nextProfileTick > 0 ifTrue: [self checkProfileTick: newMethod]. ^self successful!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2012