Vm-dev December 2021

vm-dev@lists.squeakfoundation.org

15 participants
63 discussions

VM Maker: VMMaker.oscog-eem.3119.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3119.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3119 Author: eem Time: 6 December 2021, 1:25:40.62613 pm UUID: c0b40a55-50ca-4dd9-8b6f-d355a6dd5e1f Ancestors: VMMaker.oscog-eem.3118 CoInterpreterMT simulation: Fix the rump C stack segmentation so that each thread does indeed get its own 4k page of teh rump C stack. Document what is likely a cul de sac in multi-processor simulation. This version attempts to follow this view of the world: On switching osProcess we have to both - SAVE old process's register state - RESTORE new process's register state So what are the transitions? The transitions out (where processor state must be saved) are the opposites of tryLockVMOwnerTo:. Hence - ioWaitOnOSSemaphore: - disownVM: - ioTransferTimeslice A better approach is likely this view: An alternative is to observe that we only enter processor code through a leaf call or an enilopmart. cogit could have a processor owner tag, the index of the thread that currently owns the processor, and whenever we enter machine code we save the processor state if the tag doesn't match. =============== Diff against VMMaker.oscog-eem.3118 =============== Item was changed: CoInterpreterPrimitives subclass: #CoInterpreterMT instanceVariableNames: 'cogThreadManager checkThreadActivation maxWaitingPriority foreignCallbackPriority deferThreadSwitch disowningVMThread disownCount foreignCallbackProcessSlot activeProcessAffined relinquishing processHasThreadId reenterThreadSchedulingLoop willNotThreadWarnCount' + classVariableNames: 'DisownFlagsShift DisownVMForProcessorRelinquish OwnVMForeignThreadFlag PerThreadRumpCStackSize PrimNumberRelinquishProcessor ProcessUnaffinedOnDisown ReturnToThreadSchedulingLoop VMAlreadyOwnedHenceDoNotDisown' - classVariableNames: 'DisownFlagsShift DisownVMForProcessorRelinquish OwnVMForeignThreadFlag PrimNumberRelinquishProcessor ProcessUnaffinedOnDisown ReturnToThreadSchedulingLoop VMAlreadyOwnedHenceDoNotDisown' poolDictionaries: 'VMThreadingConstants' category: 'VMMaker-Multithreading'! Item was changed: ----- Method: CoInterpreterMT class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. (InitializationOptions at: #COGMTVM ifAbsent: [false]) == false ifTrue: [^self]. COGMTVM := true. + ReturnToThreadSchedulingLoop := 2. "setjmp/longjmp code." + + PerThreadRumpCStackSize := RumpCStackSize. + RumpCStackSize := CogThreadManager basicNew maxNumThreads * PerThreadRumpCStackSize! - ReturnToThreadSchedulingLoop := 2 "setjmp/longjmp code."! Item was changed: ----- Method: CoInterpreterMT>>assertSaneThreadAndProcess (in category 'debug support') ----- assertSaneThreadAndProcess <inline: true> self assert: cogThreadManager vmIsOwned. self assert: cogThreadManager currentVMThread state = CTMAssignableOrInVM. + self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject. + cogThreadManager assertValidProcessorStackPointersForIndex: cogThreadManager getVMOwner! - self assert: (objectMemory fetchPointer: MyListIndex ofObject: self activeProcess) = objectMemory nilObject! Item was changed: ----- Method: CoInterpreterMT>>cStackRangeForThreadIndex: (in category 'simulation') ----- cStackRangeForThreadIndex: threadIndex + "Each simulated processor thread gets 4k of the rump C stack." - "Each simulated processor thread gets 4k of the rump C stack. - The top-most section is reserved for in-memory variables such as vmOwnerLock." <doNotGenerate> | top | ^(threadIndex between: 1 and: cogThreadManager maxNumThreads) ifTrue: + [top := self rumpCStackAddress - (threadIndex - 1 * PerThreadRumpCStackSize). + top - PerThreadRumpCStackSize + 1 to: top]! - [top := self rumpCStackAddress - (threadIndex - 1 * RumpCStackSize). - top - RumpCStackSize + 1 to: top]! Item was changed: ----- Method: CoInterpreterMT>>disownVM: (in category 'vm scheduling') ----- disownVM: flags "Release the VM to other threads and answer the current thread's index. Currently valid flags: DisownVMForFFICall - informs the VM that it is entering an FFI call DisownVMForThreading - informs the VM that it is entering code during which threading should be permitted OwnVMForeignThreadFlag - indicates lowest-level entry from a foreign thread - not to be used explicitly by clients - only set by ownVMFromUnidentifiedThread VMAlreadyOwnedHenceDoNotDisown - indicates an ownVM from a callback was made when the vm was still owned. - not to be used explicitly by clients - only set by ownVMFromUnidentifiedThread This is the entry-point for plugins and primitives that wish to release the VM while performing some operation that may potentially block, and for callbacks returning back to some blocking operation. If this thread does not reclaim the VM before- hand then when the next heartbeat occurs the thread manager will schedule a thread to acquire the VM which may start running the VM in place of this thread. N.B. Most of the state needed to resume after preemption is set in preemptDisowningThread." <api> <inline: false> | vmThread result | self assert: (flags >= 0 and: [flags < (1 bitShift: DisownFlagsShift)]). self assert: self successful. cogit recordEventTrace ifTrue: [self recordTrace: TraceDisownVM thing: (objectMemory integerObjectOf: flags) source: 0]. processHasThreadId ifFalse: [willNotThreadWarnCount < 10 ifTrue: [self print: 'warning: VM parameter 48 indicates Process doesn''t have threadId; VM will not thread'; cr. willNotThreadWarnCount := willNotThreadWarnCount + 1]]. vmThread := cogThreadManager currentVMThread. (flags anyMask: VMAlreadyOwnedHenceDoNotDisown) ifTrue: [disowningVMThread := vmThread. vmThread state: CTMUnavailable. ^0]. self assertCStackPointersBelongToCurrentThread. self assertValidNewMethodPropertyFlags. + self cCode: '' inSmalltalk: + [cogThreadManager saveRegisterStateForCurrentProcess]. (flags anyMask: DisownVMForProcessorRelinquish) ifTrue: [| proc | (proc := objectMemory splObj: foreignCallbackProcessSlot) ~= objectMemory nilObject ifTrue: [foreignCallbackPriority := self quickFetchInteger: PriorityIndex ofObject: proc]. relinquishing := true. self sqLowLevelMFence]. disownCount := disownCount + 1. disowningVMThread := vmThread. "self cr; cr; print: 'disownVM Csp: '; printHex: vmThread cStackPointer; cr. (0 to: 16 by: 4) do: [:offset| self print: ' *(esp+'; printNum: offset; print: ': '; printHex: (stackPages longAt: cogit processor sp + offset); cr]. cogit processor printIntegerRegistersOn: Transcript." "OwnVMForeignThreadFlag indicates lowest-level of entry by a foreign thread. If that's where we are then release the vmThread. Otherwise indicate the vmThread is off doing something outside of the VM." (flags anyMask: OwnVMForeignThreadFlag) ifTrue: ["I don't think this is quite right. Josh's use case is creating some foreign thread and then registering it with the VM. That's not the same as binding a process to a foreign thread given that the foreign callback process is about to terminate anyway (it is returning from a callback here). So do we need an additional concept, that of a vmThread being either of the set known to the VM or floating?" self flag: 'issue with registering foreign threads with the VM'. (self isBoundProcess: self activeProcess) ifFalse: [cogThreadManager unregisterVMThread: vmThread]] ifFalse: [vmThread state: CTMUnavailable]. result := ((vmThread index bitShift: DisownFlagsShift) bitOr: (activeProcessAffined ifTrue: [0] ifFalse: [ProcessUnaffinedOnDisown])) bitOr: flags. cogThreadManager releaseVM. ^result! Item was changed: ----- Method: CoInterpreterMT>>primitiveProcessBindToThreadId (in category 'process primitives') ----- primitiveProcessBindToThreadId "Attempt to bind the receiver to the thread with the id of the argument or nil, where the receiver is a Process. If successful the VM will ensure that there are at least id many threads active." | aProcess id | <export: true> self cCode: [] inSmalltalk: [cogThreadManager isNil ifTrue: [^self primitiveFail]]. processHasThreadId ifFalse: [^self primitiveFailFor: PrimErrUnsupported]. id := self stackTop. aProcess := self stackValue: 1. ((id = objectMemory nilObject or: [(objectMemory isIntegerObject: id) and: [id ~= (objectMemory integerObjectOf: 0)]]) and: [(objectMemory isPointers: aProcess) and: [(objectMemory slotSizeOf: aProcess) >= (ThreadIdIndex + 1)]]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. id := id = objectMemory nilObject ifTrue: [0] ifFalse: [objectMemory integerValueOf: id]. id abs >= cogThreadManager maxNumThreads ifTrue: [^self primitiveFailFor: PrimErrLimitExceeded]. (self bindProcess: aProcess toId: id) ifNotNil: [:ec| ^self primitiveFailFor: ec]. + self methodReturnReceiver. + + self halt. id := self ownerIndexOfProcess: aProcess. (aProcess = self activeProcess and: [(activeProcessAffined := id ~= 0) and: [(cogThreadManager vmOwnerIsCompatibleWith: id) not]]) ifTrue: [(self quickFetchInteger: PriorityIndex ofObject: aProcess) < maxWaitingPriority ifTrue: [maxWaitingPriority = self quickFetchInteger: PriorityIndex ofObject: aProcess]. + self threadSwitchIfNecessary: aProcess from: CSThreadBind]! - checkThreadActivation := true. - self forceInterruptCheck]. - self methodReturnReceiver! Item was changed: ----- Method: CoInterpreterMT>>setCFramePointer: (in category 'simulation') ----- setCFramePointer: cfp "Set the CFramePointer, either on initialization (see initializeProcessorStack:) or from machine code in ceCaptureCStackPointers. Unlike the superclass, CFramePointer + will be different for each thread using the VM." - will be different for each thread using teh VM." <doNotGenerate> + | index range | + index := cogThreadManager currentVMThread + ifNil: [1] "initialization..." + ifNotNil: "subsequently..." + [:currentVMThread| + self assert: cogThreadManager getVMOwner = currentVMThread index. + cogThreadManager getVMOwner]. + range := self cStackRangeForThreadIndex: index. + self assert: (range includes: cfp). ^CFramePointer := cfp! Item was added: + ----- Method: CoInterpreterMT>>setCFramePointer:setCStackPointer: (in category 'callback support') ----- + setCFramePointer: cFramePointer setCStackPointer: cStackPointer + self cCode: '' inSmalltalk: + [| index range | + index := CStackPointer + ifNil: [1] "first time..." + ifNotNil: "subsequently..." + [self assert: cogThreadManager getVMOwner = cogThreadManager currentVMThread index. + cogThreadManager getVMOwner]. + range := self cStackRangeForThreadIndex: index. + self assert: ((range includes: cFramePointer) + and: [range includes: cStackPointer])]. + super setCFramePointer: cFramePointer setCStackPointer: cStackPointer! Item was changed: ----- Method: CoInterpreterMT>>setCStackPointer: (in category 'simulation') ----- setCStackPointer: csp "Set the CStackPointer, either on initialization (see initializeProcessorStack:) or from machine code in ceCaptureCStackPointers. Unlike the superclass, CStackPointer will be different for each thread using the VM." <doNotGenerate> + | index range | + index := cogThreadManager currentVMThread + ifNil: [1] "initialization..." + ifNotNil: "subsequently..." + [:currentVMThread| + self assert: cogThreadManager getVMOwner = currentVMThread index. + cogThreadManager getVMOwner]. + range := self cStackRangeForThreadIndex: index. ^CStackPointer := csp! Item was changed: ----- Method: CoInterpreterMT>>threadSchedulingLoop: (in category 'vm scheduling') ----- threadSchedulingLoop: vmThread "Enter a loop attempting to run the VM with the highest priority process and blocking on the thread's OS semaphore when unable to run that process. This version is for simulation only, simulating the longjmp back to the real threadSchedulingLoopImplementation: through exception handling." <cmacro: '(vmThread) threadSchedulingLoopImplementation(vmThread)'> - cogit initializeProcessorStack: (self cStackRangeForThreadIndex: vmThread index) last. [[self threadSchedulingLoopImplementation: vmThread] on: ReenterThreadSchedulingLoop do: [:ex| self assert: ex returnValue = 1. reenterThreadSchedulingLoop reset. ex return: true]] whileTrue! Item was changed: ----- Method: CoInterpreterMT>>threadSwitchIfNecessary:from: (in category 'process primitive support') ----- threadSwitchIfNecessary: newProc from: sourceCode + "Invoked from transferTo:from: or primitiveProcessBindToThreadId to + switch threads if the new process is bound or affined to some other thread." - "Invoked from transferTo:from: to switch threads if the new process is bound or affined to some other thread." | newProcOwnerIndex vmThread activeContext | self assert: (cogThreadManager vmOwnerIs: cogThreadManager ioGetThreadLocalThreadIndex). deferThreadSwitch ifTrue: [^self]. + cogThreadManager assertValidProcessorStackPointersForIndex: cogThreadManager getVMOwner. + "If the current process is unaffined or it is affined to the current thread we're + ok to run, but we should yield asap if a higher-priority thread wants the VM." - ok to run, but we should yield asap if a higher-priority t6hread wants the VM." newProcOwnerIndex := self ownerIndexOfProcess: newProc. ((activeProcessAffined := newProcOwnerIndex ~= 0) and: [(cogThreadManager vmOwnerIsCompatibleWith: newProcOwnerIndex) not]) ifFalse: [(self quickFetchInteger: PriorityIndex ofObject: newProc) < maxWaitingPriority ifTrue: [checkThreadActivation := true. self forceInterruptCheck]. ^self]. "The current process is affined to a thread, but not to the current owner. So switch to that owner." self cCode: '' inSmalltalk: [transcript ensureCr; + f: 'threadSwitchIfNecessary: %08x from: %s(%d) owner %d -> %d\n' + printf: { newProc. TraceSources at: sourceCode. sourceCode. cogThreadManager getVMOwner. newProcOwnerIndex }]. - f: 'threadSwitchIfNecessary: %08x from: %d owner %d -> %d\n' - printf: { newProc. sourceCode. cogThreadManager getVMOwner. newProcOwnerIndex }]. + "We at least need to externalize the stack pointers to enable a thread switch..." + (objectMemory fetchPointer: SuspendedContextIndex ofObject: newProc) = objectMemory nilObject ifTrue: - "If the activeProcess doesn't have a context yet, it needs one from which the new thread can resume execution." - (objectMemory fetchPointer: SuspendedContextIndex ofObject: newProc) = objectMemory nilObject ifTrue: [self assert: newProc = self activeProcess. self push: instructionPointer. self externalWriteBackHeadFramePointers. + false ifTrue: + "If the activeProcess doesn't have a context yet, it needs one from which the new thread can resume execution." + [activeContext := self ensureFrameIsMarried: framePointer SP: stackPointer. + objectMemory storePointer: SuspendedContextIndex ofObject: newProc withValue: activeContext]]. - activeContext := self ensureFrameIsMarried: framePointer SP: stackPointer. - objectMemory storePointer: SuspendedContextIndex ofObject: newProc withValue: activeContext]. newProcOwnerIndex < 0 ifTrue: [self assert: newProcOwnerIndex negated = cogThreadManager getVMOwner. vmThread := cogThreadManager ensureWillingThread. self deny: vmThread index = cogThreadManager getVMOwner. self assert: (cogThreadManager threadIndex: vmThread index isCompatibleWith: newProcOwnerIndex)] ifFalse: [vmThread := cogThreadManager vmThreadAt: newProcOwnerIndex. vmThread priority: (self quickFetchInteger: PriorityIndex ofObject: newProc). vmThread state = CTMUnavailable ifTrue: [vmThread state: CTMWantingOwnership]]. self returnToSchedulingLoopAndReleaseVMOrWakeThread: vmThread source: CSSwitchIfNeccessary! Item was changed: ----- Method: CogThreadManager>>assertValidStackPointersInState:forIndex: (in category 'simulation') ----- assertValidStackPointersInState: registerState forIndex: threadIndex | time range | time := Time utcMicrosecondClock. range := coInterpreter cStackRangeForThreadIndex: threadIndex. self assert: ((range includes: (registerState at: cogit processor registerStateFPIndex)) and: [range includes: (registerState at: cogit processor registerStateSPIndex)]) + "(1 to: self maxNumThreads) collect: + [:i| | range | + range := coInterpreter cStackRangeForThreadIndex: i. + range storeStringBase: 16]" + + "(1 to: self maxNumThreads) - "(0 to: numThreads + numThreadsIncrement) detect: [:i| | range | + range := coInterpreter cStackRangeForThreadIndex: i. - range := coInterpreter cStackRangeForThreadIndex: threadIndex. ((range includes: (registerState at: cogit processor registerStateFPIndex)) and: [range includes: (registerState at: cogit processor registerStateSPIndex)])] ifNone: []" + "{ (registerState at: cogit processor registerStateFPIndex) hex. + coInterpreter whereIs: (registerState at: cogit processor registerStateFPIndex). + (registerState at: cogit processor registerStateSPIndex) hex. + coInterpreter whereIs: (registerState at: cogit processor registerStateSPIndex) }" + + "(1 to: self maxNumThreads) + detect: + [:i| | range | + range := coInterpreter cStackRangeForThreadIndex: i. + ((range includes: cogit processor fp) + and: [range includes: cogit processor sp])] + ifNone: []" + + "{ cogit processor fp hex. + coInterpreter whereIs: cogit processor fp. + cogit processor sp hex. + coInterpreter whereIs: cogit processor sp }"! - "{ coInterpreter whereIs: (registerState at: cogit processor registerStateFPIndex). - coInterpreter whereIs: (registerState at: cogit processor registerStateSPIndex) }"! Item was added: + ----- Method: CogThreadManager>>initializeProcessor:forThreadIndex: (in category 'simulation') ----- + initializeProcessor: aProcessor forThreadIndex: threadIndex + "Initialize aProcessor with stack pointers within its defined range." + <doNotGenerate> + | range | + range := coInterpreter cStackRangeForThreadIndex: threadIndex. + aProcessor smashCallerSavedRegistersWithValuesFrom: 16r90000000 by: coInterpreter objectMemory wordSize / 2. + cogit initializeProcessorStack: range last. + self assertValidProcessorStackPointersForIndex: threadIndex! Item was changed: ----- Method: CogThreadManager>>ioTransferTimeslice (in category 'simulation') ----- ioTransferTimeslice <doNotGenerate> "See platforms/Cross/vm/sq.h for the real definition." + self saveRegisterStateForCurrentProcess. Processor yield! Item was changed: ----- Method: CogThreadManager>>ioWaitOnOSSemaphore: (in category 'simulation') ----- ioWaitOnOSSemaphore: aSemaphorePtr <var: #anOSSemaphore type: #'sqOSSemaphore *'> <returnTypeC: #void> <doNotGenerate> "See platforms/Cross/vm/sq.h for the real definition." "Simulate the VM's heartbeat by calling checkVMOwnershipFromHeartbeat if the wait times-out." + self saveRegisterStateForCurrentProcess. + - | thisThread | [aSemaphorePtr value waitTimeoutMSecs: 1000] whileTrue: + [coInterpreter checkVMOwnershipFromHeartbeat]! - [coInterpreter checkVMOwnershipFromHeartbeat]. - self deny: vmOwner = 0. - thisThread := self vmThreadForCurrentProcess. - cogit withProcessorHaltedDo: - [| processor | - processor := cogit processor. - registerStates - at: thisThread index - ifPresent: - [:registerState| - self assertValidStackPointersInState: registerState forIndex: thisThread index]. - processor setRegisterState: (registerStates - at: thisThread index - ifAbsentPut: - [self ensureInitializedProcessor: processor forThreadIndex: thisThread index. - processor registerState])]! Item was added: + ----- Method: CogThreadManager>>saveRegisterStateForCurrentProcess (in category 'simulation') ----- + saveRegisterStateForCurrentProcess + "On switching osProcess we have to both + - SAVE old process's register state + - RESTORE new process's register state + So what are the transitions? The transitions out (where processor state must be saved) are the opposites of tryLockVMOwnerTo:. + Hence + - waitOnOSSemaphore: + - disownVM: + - ioTransferTimeslice + i.e. the continuations from here, disownVM:, and ioTransferTimeslice, will use tryLockVMOwnerTo: + to regain control of the VM. So the register state to be restored at that point (if tryLockVMOwnerTo: + succeeds) is the register state saved in one of the three places. + But the processor is initialized in tryLockVMOwnerTo:, so only save the state if state is already present." + <doNotGenerate> + cogit withProcessorHaltedDo: + [| currentVMThread state | + currentVMThread := self vmThreadForCurrentProcess. + (registerStates includesKey: currentVMThread index) ifTrue: + [state := cogit processor registerState. + self assertValidStackPointersInState: state forIndex: currentVMThread index. + registerStates at: currentVMThread index put: state]]! Item was changed: ----- Method: CogThreadManager>>setVMOwner: (in category 'public api') ----- setVMOwner: indexOrZero "An ugly accessor used in only three cases: 1. by ownVMFromUnidentifiedThread when the VM is first locked to the thread id of the unidentified thread, and then, once identified, to the thread's index. 2. by wakeVMThreadFor: used by the two-level scheduler to switch threads when a Smalltalk process switch occurs to a process affined to another thread. 3. to release the VM (set the owner to zero)" <inline: #always> self cCode: '' inSmalltalk: [coInterpreter transcript ensureCr; f: 'setVMOwner: %d -> %d (%s)\n' + printf: { vmOwner. indexOrZero. thisContext home sender selector }]. - printf: { vmOwner. indexOrZero. thisContext home sender selector }. - "In the simulation this is where register state is saved; it is switched here and in tryLockVMOwnerTo:." - (vmOwner ~= 0 and: [vmOwner ~= indexOrZero]) ifTrue: - [self assertValidProcessorStackPointersForIndex: vmOwner. - registerStates at: vmOwner put: cogit processor registerState]. - (registerStates at: indexOrZero ifPresent: [:registerState| cogit processor setRegisterState: registerState])]. vmOwner := indexOrZero. self sqLowLevelMFence! Item was changed: ----- Method: CogThreadManager>>tryLockVMOwnerTo: (in category 'simulation') ----- tryLockVMOwnerTo: threadIndex "In the real VM this is a direct call of Cogit>>#tryLockVMOwnerTo:/ceTryLockVMOwner. + In the simulation this is where register state is restored, simulating a thread switch. + State is stored in saveRegisterStateForCurrentProcess (sent by disownVM:, ioWaitOnOSSemaphore: + and ioTransferTimeslice). The code here and in saveRegisterStateForCurrentProcess allow us to + avoid the expensive and complex MultiProcessor hack. + + The idea here is to save the register state around the invocation of tryLockVMOwnerTo:, and set + the register state to that for the owner, changing the state if ownership has changed, restoring + it if ownership has not changed." - In the simulation this is where register state is saved and switched, simulating a thread - switch. setVMOwner: also saves register state. The code here and in setVMOwner: allow - us to avoid the expensive and complex MultiProcessor hack." <doNotGenerate> - | result | self deny: threadIndex = 0. + ^cogit withProcessorHaltedDo: + [| currentOwner prior processor result | - cogit withProcessorHaltedDo: - [| currentOwner prior processor | processor := cogit processor. + currentOwner := vmOwner. + vmOwner ~= 0 ifTrue: + [prior := processor registerState. + self assertValidStackPointersInState: prior forIndex: vmOwner]. + processor setRegisterState: (registerStates + at: threadIndex + ifAbsentPut: + [self initializeProcessor: processor forThreadIndex: threadIndex. + processor registerState]). - prior := processor registerState. - "A thread switch would (have) occur(ed) if it were that the VM were owned other than by threadIndex" - (currentOwner := vmOwner) ~= threadIndex ifTrue: - [currentOwner ~= 0 ifTrue: - [self assertValidStackPointersInState: prior forIndex: currentOwner. - registerStates at: currentOwner put: prior]. - processor setRegisterState: (registerStates - at: threadIndex - ifAbsentPut: - [self ensureInitializedProcessor: processor forThreadIndex: threadIndex. - processor registerState])]. result := cogit tryLockVMOwnerTo: threadIndex. self assert: result = (threadIndex = vmOwner). result ifTrue: [registerStates at: threadIndex put: processor registerState] + ifFalse: [prior ifNotNil: [processor setRegisterState: prior]]. - ifFalse: [processor setRegisterState: prior]. coInterpreter transcript ensureCr; f: (result ifTrue: ['tryLockVMOwner %d -> %d (%s) ok\n'] ifFalse: ['tryLockVMOwner %d -> %d (%s) FAILED\n']) + printf: { vmOwner. threadIndex. thisContext home sender selector }. + self assertValidProcessorStackPointersForIndex: vmOwner. + result]! - printf: { currentOwner. threadIndex. thisContext home sender selector }. - self assertValidProcessorStackPointersForIndex: vmOwner]. - ^result! Item was changed: ----- Method: CogVMSimulator>>isOnRumpCStack: (in category 'rump c stack') ----- isOnRumpCStack: address + ^address between: heapBase - RumpCStackSize and: heapBase - objectMemory wordSize! - ^address between: heapBase - self rumpCStackSize and: heapBase - objectMemory wordSize! Item was changed: ----- Method: CogVMSimulator>>rumpCStackSize (in category 'rump c stack') ----- rumpCStackSize + "Answer the size of the rump C stack used for simulation. This stack is used for C calls, + i.e. calls made into the simulated C run-time, typically of routines in CoInterpreter." + ^RumpCStackSize! - "Allocate a rump C stack for simulation. This stack is used for C calls, i.e. calls - made into the simulated C run-time, typically of routines in CoInterpreter. - We also use it to hold in-memory copies of the cStackPointer and cFramePointer - variables for simulation speed. Alas we don't use an in-memory copy of stackLimit, - because we need some activity to count in order to implement the ioMSecs - routine and the stackLimit check is the ideal one." - ^self threadManager - ifNil: [RumpCStackSize] - ifNotNil: [:threadManager| RumpCStackSize * (threadManager maxNumThreads + 1)]! Item was added: + ----- Method: CogVMSimulator>>setCFramePointer:setCStackPointer: (in category 'multi-threading simulation switch') ----- + setCFramePointer: cFramePointer setCStackPointer: cStackPointer + "This method includes or excludes CoInterpreterMT methods as required. + Auto-generated by CogVMSimulator>>ensureMultiThreadingOverridesAreUpToDate" + + ^self perform: #setCFramePointer:setCStackPointer: + withArguments: {cFramePointer. cStackPointer} + inSuperclass: (cogThreadManager ifNil: [CoInterpreterPrimitives] ifNotNil: [CoInterpreterMT])!

1 0

VM Maker: VMMakerUI-eem.54.mcz
by commits＠source.squeak.org 05 Dec '21

05 Dec '21

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.54.mcz ==================== Summary ==================== Name: VMMakerUI-eem.54 Author: eem Time: 5 December 2021, 10:30:03.68328 am UUID: 5866a524-5b91-410f-b108-da80dd7c11fb Ancestors: VMMakerUI-eem.53 Simulator: also close vanilla inspectors when shutting down a simulation =============== Diff against VMMakerUI-eem.53 =============== Item was added: + ----- Method: CoInterpreter>>isDependentInspector: (in category '*VMMakerUI-user interface') ----- + isDependentInspector: aModel + <doNotGenerate> + ^aModel isInspector + and: [(super isDependentInspector: aModel) + or: [aModel object == cogit + or: [aModel object == cogit methodZone]]]! Item was added: + ----- Method: Inspector>>isInspector (in category '*VMMakerUI-testing') ----- + isInspector + ^true! Item was added: + ----- Method: Object>>isInspector (in category '*VMMakerUI-testing') ----- + isInspector + ^false! Item was changed: ----- Method: StackInterpreter>>closeDependentWindows (in category '*VMMakerUI-user interface') ----- closeDependentWindows <doNotGenerate> World submorphs do: [:submorph| + (self isDependentInspector: submorph model) ifTrue: - (submorph model isVMObjectInspector - and: [submorph model coInterpreter == self]) ifTrue: [submorph delete]. (self isDependentDebugger: submorph model) ifTrue: [submorph model windowIsClosing. submorph delete]]! Item was added: + ----- Method: StackInterpreter>>isDependentInspector: (in category '*VMMakerUI-user interface') ----- + isDependentInspector: aModel + <doNotGenerate> + ^aModel isInspector + and: [aModel object == self + or: [aModel object == objectMemory]]!

1 0

VM Maker: VMMaker.oscog-eem.3118.mcz
by commits＠source.squeak.org 05 Dec '21

05 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3118.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3118 Author: eem Time: 5 December 2021, 9:44:14.421853 am UUID: 2b620c6a-372b-49a2-b4d2-5404fbf4afb1 Ancestors: VMMaker.oscog-eem.3117 Dual of VMMakerUI-eem.53 Simulator: move and refactor the window closing machinery. Fix closing the multi-threaded simulator and ensure debuggers in threads are also closed. =============== Diff against VMMaker.oscog-eem.3117 =============== Item was removed: - ----- Method: CogVMSimulator>>close (in category 'initialize-release') ----- - close "close any files that ST may have opened, etc" - pluginList do: [:assoc| | plugin | plugin := assoc value. plugin ~~ self ifTrue: [plugin close]]. - "Ugh; at least some of this code belongs in the UI..." - displayView ifNotNil: - [displayView activeHand removeEventListener: self]. - ActiveHand removeEventListener: self. - World submorphs do: - [:submorph| - (submorph model isVMObjectInspector - and: [submorph model coInterpreter == self]) ifTrue: - [submorph delete]. - (submorph model isDebugger - and: [(submorph model interruptedProcess suspendedContext ifNotNil: - [:sctxt| - sctxt findContextSuchThat: - [:ctxt| - (ctxt receiver == cogit - and: [ctxt selector == #simulateCogCodeAt:]) - or: [ctxt receiver == self - and: [ctxt selector == #interpret]]]]) notNil]) ifTrue: - [submorph model windowIsClosing. - submorph delete]]! Item was removed: - ----- Method: CogVMSimulator>>windowIsClosing (in category 'primitive support') ----- - windowIsClosing - self threadManager ifNotNil: - [:threadManager| threadManager shutdownModule]. - quitBlock ifNotNil: - [:effectiveQuitBlock| - quitBlock := nil. "stop recursion on explicit window close." - [effectiveQuitBlock value] - on: BlockCannotReturn - do: [:ex|]] "Cause return from #test, et al"! Item was removed: - ----- Method: InterpreterSimulator>>openAsMorph (in category 'UI') ----- - openAsMorph - "Open a morphic view on this simulation." - | window localImageName | - localImageName := imageName - ifNotNil: [self localNameFor: imageName] - ifNil: [' synthetic image']. - window := (SystemWindow labelled: 'Simulation of ' , localImageName) model: self. - - window addMorph: (displayView := ImageMorph new image: displayForm) - frame: (0@0 corner: 1(a)0.8). - - transcript := TranscriptStream on: (String new: 10000). - window addMorph: (PluggableTextMorph on: transcript text: nil accept: nil - readSelection: nil menu: #codePaneMenu:shifted:) - frame: (0(a)0.8 corner: 0.7@1). - - window addMorph: (PluggableTextMorph on: self - text: #byteCountText accept: nil) hideScrollBarsIndefinitely - frame: (0.7(a)0.8 corner: 1@1). - - window openInWorld. - ^window! Item was removed: - ----- Method: StackInterpreterSimulator>>close (in category 'initialize-release') ----- - close "close any files that ST may have opened, etc" - pluginList do: [:assoc| | plugin | plugin := assoc value. plugin ~~ self ifTrue: [plugin close]]. - "Ugh; at least some of this code belongs in the UI..." - displayView ifNotNil: - [displayView activeHand removeEventListener: self]. - ActiveHand removeEventListener: self. - World submorphs do: - [:submorph| - (submorph model isVMObjectInspector - and: [submorph model coInterpreter == self]) ifTrue: - [submorph delete]. - (submorph model isDebugger - and: [(submorph model interruptedProcess suspendedContext ifNotNil: - [:sctxt| - sctxt findContextSuchThat: - [:ctxt| - ctxt receiver == self - and: [ctxt selector == #run]]]) notNil]) ifTrue: - [submorph model windowIsClosing. - submorph delete]]! Item was removed: - ----- Method: StackInterpreterSimulator>>windowIsClosing (in category 'primitive support') ----- - windowIsClosing - quitBlock ifNotNil: - [:effectiveQuitBlock| - quitBlock := nil. "stop recursion on explicit window close." - [effectiveQuitBlock value] - on: BlockCannotReturn - do: [:ex|]] "Cause return from #test, et al"!

1 0

VM Maker: VMMakerUI-eem.53.mcz
by commits＠source.squeak.org 05 Dec '21

05 Dec '21

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.53.mcz ==================== Summary ==================== Name: VMMakerUI-eem.53 Author: eem Time: 5 December 2021, 9:43:17.24613 am UUID: 7b14f884-f965-45ae-a901-1a3e595682ea Ancestors: VMMakerUI-eem.52 Simulator: move and refactor the window closing machinery. Fix closing the multi-threaded simulator and ensure debuggers in threads are also closed. =============== Diff against VMMakerUI-eem.52 =============== Item was added: + ----- Method: CogVMSimulator>>close (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + close "close any files that ST may have opened, etc" + pluginList do: [:assoc| | plugin | plugin := assoc value. plugin ~~ self ifTrue: [plugin close]]. + "Ugh; at least some of this code belongs in the UI..." + displayView ifNotNil: + [displayView activeHand removeEventListener: self]. + ActiveHand removeEventListener: self. + self closeDependentWindows! Item was added: + ----- Method: CogVMSimulator>>isDependentDebugger: (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + isDependentDebugger: aModel + ^aModel isDebugger + and: [(aModel interruptedProcess suspendedContext ifNotNil: + [:sctxt| + sctxt findContextSuchThat: + [:ctxt| + (ctxt receiver == cogit + and: [ctxt selector == #simulateCogCodeAt:]) + or: [ctxt receiver == self + and: [ctxt selector == #interpret + or: [ctxt selector == #threadSchedulingLoop:]]]]]) notNil] + + "World submorphs select: [:submorph| self isDependentDebugger: submorph model]"! Item was added: + ----- Method: CogVMSimulator>>windowIsClosing (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + windowIsClosing + self close. + [quitBlock ifNotNil: + [:effectiveQuitBlock| + quitBlock := nil. "stop recursion on explicit window close." + [effectiveQuitBlock value] + on: BlockCannotReturn + do: [:ex|]]] "Cause return from #test, et al" + ensure: + [self threadManager ifNotNil: + [:threadManager| threadManager shutdownModule]]! Item was added: + ----- Method: InterpreterSimulator>>openAsMorph (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + openAsMorph + "Open a morphic view on this simulation." + | window localImageName | + localImageName := imageName + ifNotNil: [self localNameFor: imageName] + ifNil: [' synthetic image']. + window := (SystemWindow labelled: 'Simulation of ' , localImageName) model: self. + + window addMorph: (displayView := ImageMorph new image: displayForm) + frame: (0@0 corner: 1(a)0.8). + + transcript := TranscriptStream on: (String new: 10000). + window addMorph: (PluggableTextMorph on: transcript text: nil accept: nil + readSelection: nil menu: #codePaneMenu:shifted:) + frame: (0(a)0.8 corner: 0.7@1). + + window addMorph: (PluggableTextMorph on: self + text: #byteCountText accept: nil) hideScrollBarsIndefinitely + frame: (0.7(a)0.8 corner: 1@1). + + window openInWorld. + ^window! Item was added: + ----- Method: StackInterpreter>>closeDependentWindows (in category '*VMMakerUI-user interface') ----- + closeDependentWindows + <doNotGenerate> + World submorphs do: + [:submorph| + (submorph model isVMObjectInspector + and: [submorph model coInterpreter == self]) ifTrue: + [submorph delete]. + (self isDependentDebugger: submorph model) ifTrue: + [submorph model windowIsClosing. + submorph delete]]! Item was added: + ----- Method: StackInterpreterSimulator>>close (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + close "close any files that ST may have opened, etc" + pluginList do: [:assoc| | plugin | plugin := assoc value. plugin ~~ self ifTrue: [plugin close]]. + "Ugh; at least some of this code belongs in the UI..." + displayView ifNotNil: + [displayView activeHand removeEventListener: self]. + ActiveHand removeEventListener: self. + self closeDependentWindows! Item was added: + ----- Method: StackInterpreterSimulator>>isDependentDebugger: (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + isDependentDebugger: aModel + ^aModel isDebugger + and: [(aModel interruptedProcess suspendedContext ifNotNil: + [:sctxt| + sctxt findContextSuchThat: + [:ctxt| + ctxt receiver == self + and: [ctxt selector == #run]]]) notNil]! Item was added: + ----- Method: StackInterpreterSimulator>>windowIsClosing (in category '*VMMakerUI-InterpreterSimulation-Morphic') ----- + windowIsClosing + self close. + quitBlock ifNotNil: + [:effectiveQuitBlock| + quitBlock := nil. "stop recursion on explicit window close." + [effectiveQuitBlock value] + on: BlockCannotReturn + do: [:ex|]] "Cause return from #test, et al"!

1 0

PSA | Slow .changes access | Real-time protection in Windows Defender
by Marcel Taeumel 03 Dec '21

03 Dec '21

Hi all -- Provided that you have a .changes file that is bigger than a couple of bytes (here: ~200 MiB), you might experience a serious lag (here: ~5 seconds) when: - Starting the .image - Evaluating some do-its (or print-its) - Saving a method All operations that typically read from or write to the .changes file. The Windows Defender's "real-time protection service" seems to monitor file access. Whatever triggers it, the defender might try to get exclusive read access to a file. Then it scans the last bytes and if it finds something strange, it will continue, eventually scanning THE ENTIRE FILE! So, what is "something strange"? Well, try to evaluate this: '<a href="https://www.microsoft.com"></a>' size. Now, depending on the size of your .changes file, the Windows Defender will begin to scan the entire file for more such patterns. Note that the Defender will never complain or blacklist that file. It is just curious for the moment. Why is the Defender able to get exclusive read access on a do-it? Take a look at SmalltalkImage >> #forceChangesToDisk. There, you can see that we close and re-open the .changes file. That's exactly the time when the Windows Defender kicks in. Avoid closing that file, and you will not experience any lag. Try to save a method with such contents. You will be able to observe the same amount of extra lag. Why is regular read access during code browsing not affected? Because we already have the open file handle to the .changes and .sources files. The Defender seems to need exclusive read access. In my experience, this happened, for example, during VM/image startup. (Note that this has nothing to do with the Defender sending stuff to Microsoft via Internet. I did all the tests offline. No Ethernet connection. No WiFi.) *** What can we do about it? Different approaches work: - Save a method (or do-it sth.) to add about 1000 bytes of uninteresting content to the .changes file; then everything is fast again - Shrink your .changes file via #condenseChanges (and don't forget to save your image afterwards!!) to speed up the Defender's scan - Disable the "real-time protection service" in the Windows settings (not recommended) - Avoid strange content in your source code (or do-its) - Do not close the file so often. #primFlush: is not affected. Best, Marcel

2 7

[OpenSmalltalk/opensmalltalk-vm] 6f2914: CogVm source as per VMMaker.oscog-eem.3117
by Eliot Miranda 02 Dec '21

02 Dec '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6f2914e4484fa2d6f0e0107391b674daea85b60c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6f2914e4484fa2d6f0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-12-02 (Thu, 02 Dec 2021) Changed paths: M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c Log Message: ----------- CogVm source as per VMMaker.oscog-eem.3117 Cog ARMv8: Since id_aa64isar0_el1 is a priviledged instruction use getauxval on linux to derive the value(s) derived there-from, currenty whether atomic instructions are available or not. This addresses opensmalltalk-vm Issue #608.

1 0

VM Maker: VMMaker.oscog-eem.3117.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3117.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3117 Author: eem Time: 2 December 2021, 1:52:19.724775 pm UUID: ede3f763-e691-4662-91d0-34fc19bc39a1 Ancestors: VMMaker.oscog-eem.3116 Since id_aa64isar0_el1 is a priviledged instruction use getauxval on linux to derive the value(s) derived there-from, currenty whether atomic instructions are available or not. This addresses opensmalltalk-vm Issue #608. =============== Diff against VMMaker.oscog-eem.3116 =============== Item was changed: ----- Method: CogARMv8Compiler class>>preambleCCode (in category 'translation') ----- preambleCCode + ^ '#if __APPLE__ && __MACH__ // Mac OS X\# include <libkern/OSCacheControl.h>\#endif\' withCRs, + '#if __linux__\# include <sys/auxv.h>\#endif' withCRs! - ^'#if __APPLE__ && __MACH__ /* Mac OS X */\#include <libkern/OSCacheControl.h>\#endif' withCRs! Item was changed: ----- Method: CogARMv8Compiler>>detectFeatures (in category 'feature detection') ----- detectFeatures <inline: #always> + self cppIf: #__APPLE__ ifTrue: + [self detectFeaturesOnMacOS] ifFalse: + [self cppIf: #__linux__ ifTrue: + [self detectFeaturesOnLinux] + ifFalse: + [self detectFeaturesOnRawMachine]]! - self cppIf: #__APPLE__ - ifTrue: [self detectFeaturesOnMacOS] - ifFalse: [self detectFeaturesOnLinux]! Item was changed: ----- Method: CogARMv8Compiler>>detectFeaturesOnLinux (in category 'feature detection') ----- detectFeaturesOnLinux + "Do a throw-away compilation to read CTR_EL0 and initialize ctrEl0. + Some linux kernels trap and synthesize access to ID_AA64ISAR0_EL1, + and some do not, so use getauxval(3) to access value(s) derived there-from, + i.e. whether the processor has atomic instructions." + <option: #__linux__> + | startAddress getFeatureReg ctrEL0 | - "Do throw-away compilations to read CTR_EL0 & ID_AA64ISAR0_EL1 and initialize ctrEl0 & idISAR0" - <notOption: #__APPLE__> - | startAddress getFeatureReg ctrEL0 idISAR0 | <var: 'getFeatureReg' declareC: 'usqIntptr_t (*getFeatureReg)(void)'> startAddress := cogit methodZoneBase. cogit allocateOpcodes: 4 bytecodes: 0. getFeatureReg := cogit cCoerceSimple: startAddress to: #'usqIntptr_t (*)(void)'. "Return the value of CTR_EL0; that's the control register that defines the vital statistics of the processor's caches." cogit gen: Nop; "do something anodyne so it is easy to distinguish MRS_CTR_EL0 being an illegal instruction rather than the code zone not being executable." gen: MRS_CTR_EL0 operand: ABIResultReg; RetN: 0. cogit outputInstructionsForGeneratedRuntimeAt: startAddress. cogit resetMethodZoneBase: startAddress. cogit ensureExecutableCodeZoneWithin: [ctrEL0 := (self cCode: 'getFeatureReg()' inSmalltalk: [cogit simulateLeafCallOf: startAddress]). "see e.g. CogARMv8Compiler class>>printCTR_EL0:, concretizeCacheControlOp1:CRm:Op2: & http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.100403_0200_00_… DminLine & IminLine are Log2 words; 16 words miniumum" self setDataCacheFlushRequired: (ctrEL0 noMask: 1 << 28). self setDataCacheLineLength: 4 << (ctrEL0 >> 16 bitAnd: 15). self dataCacheLineLength = 0 ifTrue: [self setDataCacheLineLength: 4 << 4]. self setInstructionCacheFlushRequired: (ctrEL0 noMask: 1 << 29). self setInstructionCacheLineLength: 4 << (ctrEL0 bitAnd: 15)]. self instructionCacheLineLength = 0 ifTrue: [self setInstructionCacheLineLength: 4 << 4]. + self setHasAtomicInstructions: ((self getauxval: #AT_HWCAP) anyMask: #HWCAP_ATOMICS)! - cogit zeroOpcodeIndexForNewOpcodes. - cogit - gen: Nop; "do something anodyne so it is easy to distinguish MRS_CTR_EL0 being an illegal instruction rather than the code zone not being executable." - gen: MRS_ID_AA64ISAR0_EL1 operand: ABIResultReg; - RetN: 0. - cogit outputInstructionsForGeneratedRuntimeAt: startAddress. - cogit resetMethodZoneBase: startAddress. - cogit ensureExecutableCodeZoneWithin: - [idISAR0 := (self cCode: 'getFeatureReg()' inSmalltalk: [cogit simulateLeafCallOf: startAddress]). - self setHasAtomicInstructions: (idISAR0 >> 20 bitAnd: 2r1111) = 2r10]! Item was added: + ----- Method: CogARMv8Compiler>>detectFeaturesOnRawMachine (in category 'feature detection') ----- + detectFeaturesOnRawMachine + "Do throw-away compilations to read CTR_EL0 & ID_AA64ISAR0_EL1 and initialize ctrEl0 & idISAR0" + <notOption: #__APPLE__> + <notOption: #__linux__> + | startAddress getFeatureReg ctrEL0 idISAR0 | + <var: 'getFeatureReg' declareC: 'usqIntptr_t (*getFeatureReg)(void)'> + startAddress := cogit methodZoneBase. + cogit allocateOpcodes: 4 bytecodes: 0. + getFeatureReg := cogit cCoerceSimple: startAddress to: #'usqIntptr_t (*)(void)'. + "Return the value of CTR_EL0; that's the control register that defines the vital statistics of the processor's caches." + cogit + gen: Nop; "do something anodyne so it is easy to distinguish MRS_CTR_EL0 being an illegal instruction rather than the code zone not being executable." + gen: MRS_CTR_EL0 operand: ABIResultReg; + RetN: 0. + cogit outputInstructionsForGeneratedRuntimeAt: startAddress. + cogit resetMethodZoneBase: startAddress. + cogit ensureExecutableCodeZoneWithin: + [ctrEL0 := (self cCode: 'getFeatureReg()' inSmalltalk: [cogit simulateLeafCallOf: startAddress]). + "see e.g. CogARMv8Compiler class>>printCTR_EL0:, concretizeCacheControlOp1:CRm:Op2: & + http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.100403_0200_00_… + DminLine & IminLine are Log2 words; 16 words miniumum" + self setDataCacheFlushRequired: (ctrEL0 noMask: 1 << 28). + self setDataCacheLineLength: 4 << (ctrEL0 >> 16 bitAnd: 15). + self dataCacheLineLength = 0 ifTrue: + [self setDataCacheLineLength: 4 << 4]. + self setInstructionCacheFlushRequired: (ctrEL0 noMask: 1 << 29). + self setInstructionCacheLineLength: 4 << (ctrEL0 bitAnd: 15)]. + self instructionCacheLineLength = 0 ifTrue: + [self setInstructionCacheLineLength: 4 << 4]. + cogit zeroOpcodeIndexForNewOpcodes. + cogit + gen: Nop; "do something anodyne so it is easy to distinguish MRS_ID_AA64ISAR0_EL1 being an illegal instruction rather than the code zone not being executable." + gen: MRS_ID_AA64ISAR0_EL1 operand: ABIResultReg; + RetN: 0. + cogit outputInstructionsForGeneratedRuntimeAt: startAddress. + cogit resetMethodZoneBase: startAddress. + cogit ensureExecutableCodeZoneWithin: + [idISAR0 := (self cCode: 'getFeatureReg()' inSmalltalk: [cogit simulateLeafCallOf: startAddress]). + self setHasAtomicInstructions: (idISAR0 >> 20 bitAnd: 2r1111) = 2r10]!

1 0

[OpenSmalltalk/opensmalltalk-vm] 8d5e09: CogVM source as per VMMaker.oscog-eem.3116
by Eliot Miranda 01 Dec '21

01 Dec '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8d5e090c3ee9d8339b28f0066b75967bc3263962 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8d5e090c3ee9d8339b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-12-01 (Wed, 01 Dec 2021) Changed paths: M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3116 StackInterpreter: fix printAllStacks for v3. Do so by changing SpurMemoryManager>>allObjectsDoSafely: to use isNormalObject: (excluding forwarding pointers) rather than allObjectsDo:, which uses isEnumerableObject: (whcih includes forwarding pointers, and all the puns). This is good for allAccessibleObjectsOkay & checkAllAccessibleObjectsOkay which should indeed ignore things like the class table etc. Spur: eliminate duplicate enableObjectEnumerationFrom:'s in both senders of allEntitiesFrom:do:. Cogit: eliminate some C compiler warnings in the 64-bit cogits. Slang: TMethod's writtenToGlobalVarsCache should be voided more agressively to ensure endOfMemory is inlined in allEntitiesFrom:do:.

1 0

VM Maker: VMMaker.oscog-eem.3116.mcz
by commits＠source.squeak.org 01 Dec '21

01 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3116.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3116 Author: eem Time: 1 December 2021, 11:07:46.469774 am UUID: d757936e-c3f3-48be-9435-9a3a60b14615 Ancestors: VMMaker.oscog-eem.3115 Spur: eliminate duplicate enableObjectEnumerationFrom:'s in both senders of allEntitiesFrom:do:. Slang: TMethod's writtenToGlobalVarsCache should be voided more agressively to ensure endOfMemory is inlined in allEntitiesFrom:do:. =============== Diff against VMMaker.oscog-eem.3115 =============== Item was changed: ----- Method: SpurMemoryManager>>allObjectsDo: (in category 'object enumeration') ----- allObjectsDo: aBlock <inline: true> | startObject | startObject := self objectStartingAt: self startAddressForBridgedHeapEnumeration. - self enableObjectEnumerationFrom: startObject. self allEntitiesFrom: startObject do: [:objOop| (self isEnumerableObject: objOop) ifTrue: [aBlock value: objOop]]! Item was changed: ----- Method: SpurMemoryManager>>allObjectsDoSafely: (in category 'object enumeration') ----- allObjectsDoSafely: aBlock "Enumerate, not being confised by forwarding pointers. This is chosen for compatiblity with [New]Objectmemory, but the semantics differ. Here we're interested in enumerating ordinary objects, ignoring forwarding pointers, and puns." <inline: true> | startObject | startObject := self objectStartingAt: self startAddressForBridgedHeapEnumeration. - self enableObjectEnumerationFrom: startObject. self allEntitiesFrom: startObject do: [:objOop| (self isNormalObject: objOop) ifTrue: [aBlock value: objOop]]! Item was changed: ----- Method: TMethod>>maySubstituteGlobal:in: (in category 'inlining support') ----- maySubstituteGlobal: globalVar in: aCodeGen "We can substitute globalVar into this method provided globalVar is only read, not written." + writtenToGlobalVarsCache ifNil: - writtenToGlobalVarsCache = nil ifTrue: [self computePossibleSideEffectsInto: (Set new: 50) visited: (Set new: 50) in: aCodeGen]. ^(writtenToGlobalVarsCache includes: globalVar) not! Item was changed: ----- Method: TMethod>>tryToInlineMethodsIn: (in category 'inlining') ----- tryToInlineMethodsIn: aCodeGen "Expand any (complete) inline methods sent by this method. Set the complete flag when all inlining has been done. Answer if something was inlined." self definedAsMacro ifTrue: [complete ifTrue: [^false]. ^complete := true]. ^aCodeGen pushScope: declarations while: [| didSomething statementLists | self ensureConditionalAssignmentsAreTransformedIn: aCodeGen. didSomething := self tryToInlineMethodStatementsIn: aCodeGen statementListsInto: [:stmtLists| statementLists := stmtLists]. didSomething := (self tryToInlineMethodExpressionsIn: aCodeGen) or: [didSomething]. - didSomething ifTrue: - [writtenToGlobalVarsCache := nil]. - complete ifFalse: [self checkForCompletenessIn: aCodeGen. complete ifTrue: [didSomething := true]]. "marking a method complete is progress" + + didSomething ifTrue: + [writtenToGlobalVarsCache := nil]. + didSomething]!

1 0

VM Maker: VMMaker.oscog-eem.3115.mcz
by commits＠source.squeak.org 01 Dec '21

01 Dec '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3115.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3115 Author: eem Time: 1 December 2021, 10:18:11.033997 am UUID: e71c2bb2-05b8-4d1e-a837-c31a9bcc2148 Ancestors: VMMaker.oscog-eem.3114 StackInterpreter: fix printAllStacks for v3. Do so by changing SpurMemoryManager>>allObjectsDoSafely: to use isNormalObject: (excluding forwarding pointers) rather than allObjectsDo:, which uses isEnumerableObject: (whcih includes forwarding pointers, and all the puns). This is good for allAccessibleObjectsOkay & checkAllAccessibleObjectsOkay which should indeed ignore things like the class table etc. =============== Diff against VMMaker.oscog-eem.3114 =============== Item was changed: ----- Method: NewObjectMemory>>allObjectsDoSafely: (in category 'object enumeration') ----- allObjectsDoSafely: aBlock + "Enumerate, not being confised by forwarding pointers. + This is chosen for compatiblity with Spur, but the semantics differ. + Here we're interested in being able to find the next object in memory + even when the compactor is running." <inline: true> | oop | oop := self firstObject. [oop asUnsignedInteger < freeStart] whileTrue: [(self isFreeObject: oop) ifFalse: [aBlock value: oop]. oop := self objectAfterWhileForwarding: oop]! Item was changed: ----- Method: ObjectMemory>>allObjectsDoSafely: (in category 'object enumeration') ----- allObjectsDoSafely: aBlock + "Enumerate, not being confised by forwarding pointers. + This is chosen for compatiblity with Spur, but the semantics differ. + Here we're interested in being able to find the next object in memory + even when the compactor is running." <inline: true> | oop | oop := self firstObject. [oop asUnsignedInteger < freeBlock] whileTrue: [(self isFreeObject: oop) ifFalse: [aBlock value: oop]. oop := self objectAfterWhileForwarding: oop]! Item was changed: ----- Method: SpurMemoryManager>>allObjectsDoSafely: (in category 'object enumeration') ----- allObjectsDoSafely: aBlock + "Enumerate, not being confised by forwarding pointers. + This is chosen for compatiblity with [New]Objectmemory, but the semantics differ. + Here we're interested in enumerating ordinary objects, ignoring forwarding pointers, + and puns." <inline: true> + | startObject | + startObject := self objectStartingAt: self startAddressForBridgedHeapEnumeration. + self enableObjectEnumerationFrom: startObject. + self allEntitiesFrom: startObject + do: [:objOop| + (self isNormalObject: objOop) ifTrue: + [aBlock value: objOop]]! - self allObjectsDo: aBlock! Item was changed: ----- Method: StackInterpreter>>printAllStacks (in category 'debug printing') ----- printAllStacks "Print all the stacks of all running processes, including those that are currently suspended." <export: true> "useful for VM debugging; use export: not api, so it will be accessible on win32 and won't be written to cointerp.h" | proc schedLists p processList linkedListClass minProcessInstSize processClass | <inline: false> proc := self activeProcess. "may not be an instance of process. may in exceptional circumstances be nilObject" self printNameOfClass: (objectMemory fetchClassOf: proc) count: 5; space; printHex: proc. self print: ' priority '; printNum: (self quickFetchInteger: PriorityIndex ofObject: proc); cr. framePointer ifNil: [self printProcessStack: proc] "at startup..." ifNotNil: [self printCallStack]. "first the current activation" schedLists := objectMemory fetchPointer: ProcessListsIndex ofObject: self schedulerPointer. linkedListClass := nil. "then the runnable processes" p := highestRunnableProcessPriority = 0 ifTrue: [objectMemory numSlotsOf: schedLists] ifFalse: [highestRunnableProcessPriority]. p - 1 to: 0 by: -1 do: [:pri| processList := objectMemory fetchPointer: pri ofObject: schedLists. (self isEmptyList: processList) ifFalse: [proc = objectMemory nilObject ifTrue: [proc := objectMemory fetchPointer: FirstLinkIndex ofObject: processList]. self cr; print: 'processes at priority '; printNum: pri + 1. self printProcsOnList: processList]. linkedListClass ifNil: [linkedListClass := objectMemory fetchClassOfNonImm: processList]]. linkedListClass ifNil: [linkedListClass := objectMemory superclassOf: objectMemory classSemaphore]. proc = objectMemory nilObject ifTrue: [self cr; print: 'Cannot find a runnable process. Cannot therefore determine class Process. Cannot therefore print suspended processes'. ^self]. self cr; print: 'suspended processes'. "Find the root of the Process hierarchy. It is the class, or superclass, of a process, that has inst size at least large enough to include myList" processClass := proc = objectMemory nilObject ifFalse: [objectMemory fetchClassOf: proc]. minProcessInstSize := MyListIndex + 1. [(objectMemory instanceSizeOf: (objectMemory superclassOf: processClass)) >= minProcessInstSize] whileTrue: [processClass := objectMemory superclassOf: processClass]. minProcessInstSize := objectMemory instanceSizeOf: processClass. "look for all subInstances of process that have a context as a suspendedContext and are on a list other than a LinkedList" + objectMemory allObjectsDoSafely: + [:obj| + ((objectMemory isPointersNonImm: obj) + and: [(objectMemory numSlotsOf: obj) >= minProcessInstSize + and: [(self is: obj KindOfClass: processClass) + and: [objectMemory isContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: obj)]]]) ifTrue: + [| myList myListClass | + "Is the process waiting on some delaying list? This will be a subclass of LinkedList. + If so, assume it is blocked on the list." + myList := objectMemory fetchPointer: MyListIndex ofObject: obj. + (myList ~= objectMemory nilObject + and: [(myListClass := objectMemory fetchClassOfNonImm: myList) ~= linkedListClass + and: [self is: myList KindOfClass: linkedListClass]]) ifTrue: + [self printProcessStack: obj]]]! - objectMemory hasSpurMemoryManagerAPI - ifTrue: - [objectMemory allHeapEntitiesDo: - [:obj| - ((objectMemory isNormalObject: obj) - and: [(objectMemory isPointersNonImm: obj) - and: [(objectMemory numSlotsOf: obj) >= minProcessInstSize - and: [(self is: obj KindOfClass: processClass) - and: [objectMemory isContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: obj)]]]]) ifTrue: - [| myList myListClass | - "Is the process waiting on some delaying list? This will be a subclass of LinkedList. - If so, assume it is blocked on the list." - myList := objectMemory fetchPointer: MyListIndex ofObject: obj. - (myList ~= objectMemory nilObject - and: [(myListClass := objectMemory fetchClassOfNonImm: myList) ~= linkedListClass - and: [self is: myList KindOfClass: linkedListClass]]) ifTrue: - [self printProcessStack: obj]]]] - ifFalse: - [objectMemory allObjectsDoSafely: - [:obj| - ((objectMemory isNormalObject: obj) - and: [(objectMemory isPointersNonImm: obj) - and: [(objectMemory numSlotsOf: obj) >= minProcessInstSize - and: [(self is: obj KindOfClass: processClass) - and: [objectMemory isContext: (objectMemory fetchPointer: SuspendedContextIndex ofObject: obj)]]]]) ifTrue: - [| myList myListClass | - "Is the process waiting on some delaying list? This will be a subclass of LinkedList. - If so, assume it is blocked on the list." - myList := objectMemory fetchPointer: MyListIndex ofObject: obj. - (myList ~= objectMemory nilObject - and: [(myListClass := objectMemory fetchClassOfNonImm: myList) ~= linkedListClass - and: [self is: myList KindOfClass: linkedListClass]]) ifTrue: - [self printProcessStack: obj]]]]!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2021