Vm-dev February 2022

vm-dev@lists.squeakfoundation.org

11 participants
83 discussions

Segmentation fault in Squeak6.0alpha-21313-64bit-202112201228-macOS-x64.dmg
by Bernhard Pieber 18 Feb '22

18 Feb '22

Hi All, I downloaded the current trunk to give it a try. I played with different Hi-DPI settings on the first page the preference wizard and maximised the Squeak window. Here is the crash.dmp: Does someone recognise this error? If it is a new error I guess I should report it in https://github.com/OpenSmalltalk/opensmalltalk-vm/issues, right? Cheers, Bernhard

1 0

[OpenSmalltalk/opensmalltalk-vm] 3b50ec: CogVM source as per VMMaker.oscog-eem.3158
by Eliot Miranda 17 Feb '22

17 Feb '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 3b50ec8b31a8a3d8ae5fb8ef1e78fa7076e7d9c9 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3b50ec8b31a8a3d8ae… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-02-17 (Thu, 17 Feb 2022) Changed paths: M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3158 Spur CoInterpreter: it's neater to define PrimCallIsExternalCall and mix this in for primitiveCalloutToFFI and primitiveExternalCall than defining PrimCallIsInternalPrim and mixing it in to all internal primitives. Hence add primCalloutIsExternal, and have primitiveUnloadModule reset primitiveCalloutPointer. CoInterpreter Slang: make sure pool defines are included in cointerp.h otherwise there is nothing to catch these variables being changed and cogitXXX.c's getting out of sync with cointerp.c.

1 0

VM Maker: VMMaker.oscog-eem.3158.mcz
by commits＠source.squeak.org 17 Feb '22

17 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3158.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3158 Author: eem Time: 17 February 2022, 10:40:34.464564 am UUID: fb484548-01a4-4d5e-a515-a0baa462be58 Ancestors: VMMaker.oscog-eem.3157 Spur CoInterpreter: minor refactoring eliminates duplication of setting of primCalloutIsExternal. =============== Diff against VMMaker.oscog-eem.3157 =============== Item was removed: - ----- Method: CoInterpreter>>augmentPrimitiveCalloutMetadataFlags (in category 'plugin primitive support') ----- - augmentPrimitiveCalloutMetadataFlags - "Find out whether SqueakFFIPrims is internal or external" - <inline: #always> - | index | - primCalloutIsExternal := true. - index := 1. - [(self ioListBuiltinModule: index) - ifNil: [^self] - ifNotNil: - [:moduleName| - (self strcmp: moduleName _: 'SqueakFFIPrims') = 0 ifTrue: - [primCalloutIsExternal := false]]. - index := index + 1. - true] whileTrue! Item was added: + ----- Method: CoInterpreter>>reloadPrimitiveCalloutPointer (in category 'plugin primitive support') ----- + reloadPrimitiveCalloutPointer + <inline: #never> + | index | + super reloadPrimitiveCalloutPointer. + "Find out whether SqueakFFIPrims is internal or external" + primCalloutIsExternal := true. + index := 1. + [(self ioListBuiltinModule: index) + ifNil: [^self] + ifNotNil: + [:moduleName| + (self strcmp: moduleName _: 'SqueakFFIPrims') = 0 ifTrue: + [primCalloutIsExternal := false]]. + index := index + 1. + true] whileTrue! Item was removed: - ----- Method: StackInterpreter>>augmentPrimitiveCalloutMetadataFlags (in category 'plugin primitive support') ----- - augmentPrimitiveCalloutMetadataFlags - "noop in the StackInterpreter" - <inline: #always>! Item was changed: ----- Method: StackInterpreter>>functionForPrimitiveCallout (in category 'plugin primitive support') ----- functionForPrimitiveCallout "Answer the function primitiveCallout from the FFI plugin or nil if it can't be found. Cache it for performance. We use this circumlocution so that Squeak can be deployed without the FFI plugin for security reasons." <returnTypeC: 'void (*functionForPrimitiveCallout())(void)'> <inline: true> primitiveCalloutPointer asInteger = -1 ifTrue: + [self reloadPrimitiveCalloutPointer]. - [primitiveCalloutPointer := self ioLoadFunction: 'primitiveCallout' From: 'SqueakFFIPrims'. - self augmentPrimitiveCalloutMetadataFlags]. ^self cCoerceSimple: primitiveCalloutPointer to: #'void (*)(void)'! Item was added: + ----- Method: StackInterpreter>>reloadPrimitiveCalloutPointer (in category 'plugin primitive support') ----- + reloadPrimitiveCalloutPointer + "noop in the StackInterpreter" + <inline: #always> + primitiveCalloutPointer := self ioLoadFunction: 'primitiveCallout' From: 'SqueakFFIPrims'!

1 0

VM Maker: VMMaker.oscog-eem.3157.mcz
by commits＠source.squeak.org 17 Feb '22

17 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3157.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3157 Author: eem Time: 17 February 2022, 10:15:27.034566 am UUID: 0a61a955-24e6-49bb-90ed-2e1021d31a5d Ancestors: VMMaker.oscog-eem.3156 Spur CoInterpreter: it's neater to define PrimCallIsExternalCall and mix this in for primitiveCalloutToFFI and primitiveExternalCall than defining PrimCallIsInternalPrim and mixing it in to all internal primitives. Hence add primCalloutIsExternal, and have primitiveUnloadModule reset primitiveCalloutPointer. CoInterpreter Slang: make sure pool defines are included in cointerp.h otherwise there is nothing to catch these variables being changed and cogitXXX.c's getting out of sync with cointerp.c. =============== Diff against VMMaker.oscog-eem.3156 =============== Item was changed: ----- Method: CCodeGenerator>>addConstantForBinding: (in category 'public') ----- addConstantForBinding: variableBinding "Add the pool variable to the code base as a constant." + constants + at: variableBinding key + put: ((useSymbolicConstants and: [self isCLiteral: variableBinding value]) - | node val | - val := variableBinding value. - node := (useSymbolicConstants and: [self isCLiteral: val]) ifTrue:[TDefineNode new setName: variableBinding key value: variableBinding value] + ifFalse:[TConstantNode new setValue: variableBinding value])! - ifFalse:[TConstantNode new setValue: variableBinding value]. - constants at: variableBinding key put: node! Item was added: + ----- Method: CCodeGenerator>>commonSharedPoolVariableNames (in category 'C code generator') ----- + commonSharedPoolVariableNames + "Answer the names of pool variables (potentially) shared between the Cogit and the CoInterpreter, but not defined in interp.h" + | commonConstants cointerpPools cogitPools | + commonConstants := Set new. + cointerpPools := vmClass withAllSuperclasses + inject: Set new + into: [:them :class| them addAll: class poolDictionaryNames. them]. + cogitPools := vmClass cogitClass withAllSuperclasses + inject: Set new + into: [:them :class| them addAll: class poolDictionaryNames. them]. + (cointerpPools intersection: cogitPools) do: + [:poolName| + (Smalltalk at: poolName) classPool associationsDo: + [:binding| + (self isCLiteral: binding value) ifTrue: + [commonConstants add: binding key]]]. + #(initializeMiscConstants initializePrimitiveErrorCodes) do: + [:selector| + (VMClass class>>selector) literalsDo: + [:lit| + (lit isVariableBinding and: [lit key isString]) ifTrue: + [commonConstants remove: lit key ifAbsent: []]]]. + VMBasicConstants mostBasicConstantNames do: + [:mbcn| commonConstants remove: mbcn ifAbsent: []]. + ^commonConstants! Item was changed: ----- Method: CCodeGenerator>>emitCAPIExportHeaderOn: (in category 'C code generator') ----- emitCAPIExportHeaderOn: aStream "Store prototype declarations for all API methods on the given stream." | exportedAPIMethods usedConstants | exportedAPIMethods := self sortMethods: (methods select: [:m| m isAPIMethod]). exportedAPIMethods do: [:m| m static ifTrue: [logger ensureCr; show: m selector, ' excluded from export API because it is static'; cr]]. exportedAPIMethods := exportedAPIMethods reject: [:m| m static]. self emitCFunctionPrototypes: exportedAPIMethods on: aStream. self emitGlobalCVariablesOn: aStream. + usedConstants := self emitCMacros: exportedAPIMethods on: aStream. + (vmClass notNil and: [vmClass hasCogit]) ifTrue: + [usedConstants addAll: self commonSharedPoolVariableNames]. - usedConstants := self emitCMacros: exportedAPIMethods on: aStream. self emitCConstants: usedConstants on: aStream! Item was changed: ----- Method: CCodeGenerator>>emitCConstantsOn: (in category 'C code generator') ----- emitCConstantsOn: aStream "Store the global variable declarations on the given stream." | unused | unused := constants keys asSet. "Don't generate any defines for the externally defined constants, + STACKVM, COGVM, COGMTVM et al, unless they're actually used. + Also don't generate the PrimErr defines; these must be taken from interp.h" + #(initializeMiscConstants initializePrimitiveErrorCodes) do: + [:selector| + (VMClass class>>selector) literalsDo: + [:lit| + (lit isVariableBinding and: [lit key isString]) ifTrue: + [unused add: lit key]]]. + "and VMBasicConstants mostBasicConstantNames must be taken from interp.h" + unused addAll: VMBasicConstants mostBasicConstantNames. - STACKVM, COGVM, COGMTVM et al, unless they're actually used." - (VMClass class>>#initializeMiscConstants) literalsDo: - [:lit| - (lit isVariableBinding and: [lit key isString]) ifTrue: - [unused add: lit key]]. methods do: [:meth| meth declarations keysDo: [:v| (meth typeFor: v in: self) ifNotNil: [:type| unused remove: type ifAbsent: []]]. unused remove: meth returnType ifAbsent: []. meth parseTree nodesDo: [:n| n isConstant ifTrue: [unused remove: n name ifAbsent: []]]]. unused copy do: [:const| (variableDeclarations anySatisfy: [:value| value includesSubstring: const]) ifTrue: [unused remove: const ifAbsent: []]]. + self emitCConstants: (constants keys reject: [:any| unused includes: any]) on: aStream! - "and VMBasicConstants mostBasicConstantNames *must* be taken from interp.h" - unused addAll: VMBasicConstants mostBasicConstantNames. - self emitCConstants: (constants keys reject: [:any| unused includes: any]) on: aStream! Item was changed: StackInterpreterPrimitives subclass: #CoInterpreter + instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase lastCoggableInterpretedBlockMethod deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile CFramePointer CStackPointer CReturnAddress primTracePluginName primCalloutIsExternal' - instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase lastCoggableInterpretedBlockMethod deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile CFramePointer CStackPointer CReturnAddress primTracePluginName' classVariableNames: 'CSCallbackEnter CSCallbackLeave CSCheckEvents CSEnterCriticalSection CSExitCriticalSection CSOwnVM CSResume CSSignal CSSuspend CSSwitchIfNeccessary CSThreadBind CSThreadSchedulingLoop CSWait CSYield HasBeenReturnedFromMCPC HasBeenReturnedFromMCPCOop MFMethodFlagFrameIsMarkedFlag MinBackwardJumpCountForCompile PrimTraceLogSize RumpCStackSize TraceBlockActivation TraceBlockCreation TraceBufferSize TraceCodeCompaction TraceContextSwitch TraceDisownVM TraceFullGC TraceIncrementalGC TraceIsFromInterpreter TraceIsFromMachineCode TraceOwnVM TracePreemptDisowningThread TracePrimitiveFailure TracePrimitiveRetry TraceSources TraceStackOverflow TraceThreadSwitch TraceVMCallback TraceVMCallbackReturn' poolDictionaries: 'CogMethodConstants VMStackFrameOffsets' category: 'VMMaker-JIT'! !CoInterpreter commentStamp: 'eem 3/31/2020 18:56' prior: 0! I am a variant of the StackInterpreter that can co-exist with the Cog JIT. I interpret unjitted methods, either because they have been found for the first time or because they are judged to be too big to JIT. See CogMethod class's comment for method interoperability. cogCodeSize - the current size of the machine code zone cogCompiledCodeCompactionCalledFor - a variable set when the machine code zone runs out of space, causing a machine code zone compaction at the next available opportunity cogMethodZone - the manager for the machine code zone (instance of CogMethodZone) cogit - the JIT (co-jit) (instance of SimpleStackBasedCogit, StackToRegisterMappoingCogit, etc) deferSmash - a flag causing deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) deferredSmash - a flag noting deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) desiredCogCodeSize - the desred size of the machine code zone, set at startup or via primitiveVMParameter to be written at snapshot time flagInterpretedMethods - true if methods that are interpreted shoudl have their flag bit set (used to identity methods that are interpreted because they're unjittable for some reason) gcMode - the variable holding the gcMode, used to inform the cogit of how to scan the machine code zone for oops on GC heapBase - the address in memory of the base of the objectMemory's heap, which is immediately above the machine code zone lastCoggableInterpretedBlockMethod - a variable used to invoke the cogit for a block mehtod being invoked repeatedly in the interpreter lastUncoggableInterpretedBlockMethod - a variable used to avoid invoking the cogit for an unjittable method encountered on block evaluation maxLiteralCountForCompile - the variable controlling which methods to jit. methods with a literal count above this value will not be jitted (on the grounds that large methods are typically used for initialization, and take up a lot of space in the code zone) minBackwardJumpCountForCompile - the variable controlling when to attempt to jit a method being interpreted. If as many backward jumps as this occur, the current method will be jitted primTraceLog - a small array implementing a crcular buffer logging the last N primitive invocations, GCs, code compactions, etc used for crash reporting primTraceLogIndex - the index into primTraceLog of the next entry reenterInterpreter - the jmpbuf used to jmp back into the interpreter when transitioning from machine code to the interpreter statCodeCompactionCount - the count of machine code zone compactions statCodeCompactionUsecs - the total microseconds spent in machine code zone compactions traceLog - a log of various events, used in debugging traceLogIndex - the index into traceLog of the next entry traceSources - the names associated with the codes of events in traceLog CFramePointer - if in use, the value of the C frame pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CStackPointer - the value of the C stack pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CReturnAddress - the return address for the function call which invoked the interpreter at start-up. Using this as teh return address when entering the interpreter via ceInvokeInterpeter maintains a valid stack. Since this is effevtively a constant it does not need to be saved and restored once set.! Item was changed: ----- Method: CoInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. COGVM := true. MinBackwardJumpCountForCompile := 40. MaxNumArgs := 15. PrimCallOnSmalltalkStack := 1. "Speed up simple external prims by avoiding stack switch" PrimCallOnSmalltalkStackAlign2x := 2. "Align stack to a 2 x word size boundary, e.g. for MMX instructions etc" + PrimCallNeedsNewMethod := 4. "e.g. primitiveExternalCall and primitiveCalloutToFFI extract info from newMethod's first literal" + PrimCallMayEndureCodeCompaction := 8. "primitiveExternalCall and primitiveCalloutToFFI may invoke callbacks, hence may experience code compaction." + PrimCallCollectsProfileSamples := 16. "tells JIT to compile support for profiling primitives" + PrimCallIsExternalPrim := 32. "Whether a primitive is not included in the VM, but loaded dynamically. + Hence it can only be called through a CallFullRT." - PrimCallNeedsNewMethod := 4. - PrimCallMayEndureCodeCompaction := 8. - PrimCallCollectsProfileSamples := 16. - PrimCallIsInternalPrim := 32. "Flags for use in primitiveMetadata: in external primitives, overlap with the PrimCallXXX flags above" FastCPrimitiveFlag := 1. "a.k.a. PrimCallOnSmalltalkStack" FastCPrimitiveAlignForFloatsFlag := 2. "a.k.a. PrimCallOnSmalltalkStackAlign2x" "And to shift away the flags, to compute the accessor depth, use... c.f. NullSpurMetadata in sq.h" SpurPrimitiveAccessorDepthShift := 8. SpurPrimitiveFlagsMask := 1 << SpurPrimitiveAccessorDepthShift - 1. "the primitive trace log; a record of the last 256 named/external primitives or significant events invoked." PrimTraceLogSize := 256. "Room for 256 selectors. Must be 256 because we use a byte to hold the index" TraceBufferSize := 256 * 3. "Room for 256 events" TraceContextSwitch := self objectMemoryClass basicNew integerObjectOf: 1. TraceBlockActivation := self objectMemoryClass basicNew integerObjectOf: 2. TraceBlockCreation := self objectMemoryClass basicNew integerObjectOf: 3. TraceIncrementalGC := self objectMemoryClass basicNew integerObjectOf: 4. TraceFullGC := self objectMemoryClass basicNew integerObjectOf: 5. TraceCodeCompaction := self objectMemoryClass basicNew integerObjectOf: 6. TraceOwnVM := self objectMemoryClass basicNew integerObjectOf: 7. TraceDisownVM := self objectMemoryClass basicNew integerObjectOf: 8. TraceThreadSwitch := self objectMemoryClass basicNew integerObjectOf: 9. TracePreemptDisowningThread := self objectMemoryClass basicNew integerObjectOf: 10. TraceVMCallback := self objectMemoryClass basicNew integerObjectOf: 11. TraceVMCallbackReturn := self objectMemoryClass basicNew integerObjectOf: 12. TraceStackOverflow := self objectMemoryClass basicNew integerObjectOf: 13. TracePrimitiveFailure := self objectMemoryClass basicNew integerObjectOf: 14. TracePrimitiveRetry := self objectMemoryClass basicNew integerObjectOf: 15. TraceIsFromMachineCode := 1. TraceIsFromInterpreter := 2. CSCallbackEnter := 3. CSCallbackLeave := 4. CSEnterCriticalSection := 5. CSExitCriticalSection := 6. CSResume := 7. CSSignal := 8. CSSuspend := 9. CSWait := 10. CSYield := 11. CSCheckEvents := 12. CSThreadSchedulingLoop := 13. CSOwnVM := 14. CSThreadBind := 15. CSSwitchIfNeccessary := 16. TraceSources := CArrayAccessor on: #('?' 'm' 'i' 'callbackEnter' 'callbackLeave' 'enterCritical' 'exitCritical' 'resume' 'signal' 'suspend' 'wait' 'yield' 'eventcheck' 'threadsched' 'ownVM' 'bindToThread' 'switchIfNecessary'). "this is simulation only" RumpCStackSize := 4096! Item was added: + ----- Method: CoInterpreter>>augmentPrimitiveCalloutMetadataFlags (in category 'plugin primitive support') ----- + augmentPrimitiveCalloutMetadataFlags + "Find out whether SqueakFFIPrims is internal or external" + <inline: #always> + | index | + primCalloutIsExternal := true. + index := 1. + [(self ioListBuiltinModule: index) + ifNil: [^self] + ifNotNil: + [:moduleName| + (self strcmp: moduleName _: 'SqueakFFIPrims') = 0 ifTrue: + [primCalloutIsExternal := false]]. + index := index + 1. + true] whileTrue! Item was changed: ----- Method: CoInterpreter>>functionPointerForCompiledMethod:primitiveIndex:primitivePropertyFlagsInto: (in category 'cog jit support') ----- functionPointerForCompiledMethod: methodObj primitiveIndex: primitiveIndex primitivePropertyFlagsInto: flagsPtr <api> <returnTypeC: 'void (*functionPointerForCompiledMethodprimitiveIndexprimitivePropertyFlagsInto(sqInt methodObj, sqInt primitiveIndex, sqInt *flagsPtr))(void)'> <inline: false> | flags | flagsPtr ifNotNil: [flagsPtr at: 0 put: (flags := self primitivePropertyFlags: primitiveIndex numArgs: (self argumentCountOf: methodObj))]. primitiveIndex == PrimNumberFFICall ifTrue: + [self functionForPrimitiveCallout. "first invocation sets primCalloutIsExternal" + flagsPtr ifNotNil: + [primCalloutIsExternal ifTrue: + [flagsPtr at: 0 put: (flags bitOr: PrimCallIsExternalPrim)]]. + ^primitiveCalloutPointer]. - [^self functionForPrimitiveCallout]. primitiveIndex == PrimNumberExternalCall ifTrue: [| lit | lit := self attemptToLinkExternalPrimitive: methodObj. flagsPtr ifNotNil: ["N.B. We only support the FastCPrimitiveFlag on Spur because Spur will not run a GC to satisfy an allocation in a primitive. The V3 ObjectMemory will and hence the depth of stack needed in a V3 primitive is probably too large to safely execute on a stack page." objectMemory hasSpurMemoryManagerAPI ifTrue: [| metadata metadataFlags | metadata := objectMemory fetchPointer: ExternalCallLiteralFlagsIndex ofObject: lit. (objectMemory isIntegerObject: metadata) ifTrue: [metadataFlags := (objectMemory integerValueOf: metadata) bitAnd: SpurPrimitiveFlagsMask. "combine the specific external primitive's flags with the base flags. Hence e.g. if profiling is in effect (as indicated by PrimCallCollectsProfileSamples in the base flags) it remains in effect after combining the specific flags." flags := flags bitOr: metadataFlags]]. + (self externalCallLiteralModuleIsVM: lit) ifFalse: + [flags := flags bitOr: PrimCallIsExternalPrim]. - (self externalCallLiteralModuleIsVM: lit) ifTrue: - [flags := flags bitOr: PrimCallIsInternalPrim]. flagsPtr at: 0 put: flags]. ^self functionForPrimitiveExternalCall: methodObj]. ^self functionPointerFor: primitiveIndex inClass: nil! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForSpur:numArgs: (in category 'cog jit support') ----- primitivePropertyFlagsForSpur: primIndex numArgs: numArgs <inline: true> "Answer any special requirements of the given primitive. Spur needs to set newMethod if and when a primitive fails so primitives can retry on failure due to forwarders, but this isn't done until failure. The primitiveMetadataTable is populated based on the primitiveMetadata: pragma in internal primitives." | baseFlags | baseFlags := profileSemaphore = objectMemory nilObject ifTrue: [0] ifFalse: [PrimCallCollectsProfileSamples]. self cppIf: #LRPCheck ifTrue: [longRunningPrimitiveCheckSemaphore ifNotNil: [baseFlags := baseFlags bitOr: PrimCallNeedsNewMethod]]. (primIndex = PrimNumberVMParameter and: [numArgs = 1]) "vmParameterAt:" ifTrue: + [^baseFlags + PrimCallOnSmalltalkStack + PrimCallOnSmalltalkStackAlign2x]. - [^baseFlags + PrimCallOnSmalltalkStack + PrimCallOnSmalltalkStackAlign2x + PrimCallIsInternalPrim]. ^baseFlags bitOr: ((primitiveMetadataTable at: primIndex) bitAnd: SpurPrimitiveFlagsMask)! Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveUnloadModule (in category 'plugin primitives') ----- primitiveUnloadModule "Primitive. Unload the module with the given name. Reloading of the module will happen *later* automatically, when a function from it is called. This is forced by invalidating all external primitive methods and activations in flushExternalPrimitives. N.B. since this is most likely a development time activity we don't care about performance." <primitiveMetadata: #PrimCallMayEndureCodeCompaction> + | moduleName moduleLength | - | moduleName | moduleName := self stackTop. (objectMemory isBytes: moduleName) ifFalse:[^self primitiveFail]. + moduleLength := objectMemory numBytesOfBytes: moduleName. (self ioUnloadModule: (self oopForPointer: (objectMemory firstIndexableField: moduleName)) + OfLength: moduleLength) ifFalse:[^self primitiveFail]. + (self object: moduleName equalsString: 'SqueakFFIPrims' ofSize: moduleLength) ifTrue: + [primitiveCalloutPointer := self cCoerceSimple: -1 to: #'void *']. - OfLength: (objectMemory numBytesOfBytes: moduleName)) ifFalse:[^self primitiveFail]. "N.B. flushExternalPrimitives continues. Do *not* do anything after flushExternalPrimitives in the CoInterpreter" self forceInterruptCheck. self flushExternalPrimitives "NOTREACHED"! Item was changed: SharedPool subclass: #CogMethodConstants instanceVariableNames: '' + classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallIsExternalPrim PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallOnSmalltalkStack PrimCallOnSmalltalkStackAlign2x ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' - classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallIsInternalPrim PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallOnSmalltalkStack PrimCallOnSmalltalkStackAlign2x ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' poolDictionaries: '' category: 'VMMaker-JIT'! Item was changed: ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive:flags: (in category 'primitive generators') ----- compileOnStackExternalPrimitive: primitiveRoutine flags: flags "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. Fall through to frame build." <option: #SpurObjectMemory> <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | calleeSavedRegisterMask linkRegSaveRegister spRegSaveRegister jmpFail retry continueAfterProfileSample jumpToTakeSample | self assert: (objectRepresentation hasSpurMemoryManagerAPI and: [flags anyMask: PrimCallOnSmalltalkStack]). self deny: (backEnd hasVarBaseRegister and: [self register: VarBaseReg isInMask: ABICallerSavedRegisterMask]). (coInterpreter recordFastCCallPrimTraceForMethod: methodObj) ifTrue: [self genFastPrimTraceUsing: ClassReg and: SendNumArgsReg]. "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self AddCq: methodOrBlockNumArgs R: TempReg]. "As small or smaller than move on most archs" self MoveR: TempReg Aw: coInterpreter argumentCountAddress. self genExternalizeStackPointerForFastPrimitiveCall. "We may need to save LinkReg and/or SPReg, and given the stack machinations it is much easier to save them in callee saved registers than on the stack itself." calleeSavedRegisterMask := ABICalleeSavedRegisterMask bitClear: (self registerMaskFor: ClassReg). backEnd hasLinkRegister ifTrue: [linkRegSaveRegister := self availableRegisterOrNoneIn: calleeSavedRegisterMask. self deny: linkRegSaveRegister = NoReg. self MoveR: LinkReg R: linkRegSaveRegister. calleeSavedRegisterMask := calleeSavedRegisterMask bitClear: (self registerMaskFor: linkRegSaveRegister)]. spRegSaveRegister := NoReg. (SPReg ~= NativeSPReg and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: [spRegSaveRegister := self availableRegisterOrNoneIn: calleeSavedRegisterMask. self deny: spRegSaveRegister = NoReg. self MoveR: SPReg R: spRegSaveRegister]. retry := self Label. (flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: [self AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg] ifFalse: [SPReg ~= NativeSPReg ifTrue: [backEnd genLoadNativeSPRegWithAlignedSPReg]]. backEnd genMarshallNArgs: 0 arg: nil arg: nil arg: nil arg: nil. "If the primitive is in the interpreter then its address won't change relative to the code zone over time, whereas if it is in a plugin its address could change if the module is un/re/over/loaded. So if in the interpreter and in range use a normal call instruction." + ((flags noMask: PrimCallIsExternalPrim) - ((flags anyMask: PrimCallIsInternalPrim) and: [backEnd isWithinCallRange: primitiveRoutine asInteger]) ifTrue: [self CallRT: primitiveRoutine asInteger] ifFalse: [self CallFullRT: primitiveRoutine asInteger]. backEnd genRemoveNArgsFromStack: 0. "test primFailCode and jump to failure sequence if non-zero" self MoveAw: coInterpreter primFailCodeAddress R: TempReg. spRegSaveRegister ~= NoReg ifTrue: [self MoveR: spRegSaveRegister R: SPReg]. self CmpCq: 0 R: TempReg. jmpFail := self JumpNonZero: 0. "Remember to restore the native stack pointer to point to the C stack, otherwise the Smalltalk frames will get overwritten on an interrupt." SPReg ~= NativeSPReg ifTrue: [backEnd genLoadCStackPointer]. "placing the test here attributes the tick to the primitive plus any checkForAndFollowForwardedPrimitiveState scanning, but attributes all of a failing primitive to the current method (in ceStackOverflow: on frame build)." (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample := self genCheckForProfileTimerTick: (self registerMaskFor: NoReg)]. "At this point the primitive has cut back stackPointer to point to the result." continueAfterProfileSample := self MoveAw: coInterpreter stackPointerAddress R: TempReg. "get result and restore retpc" backEnd hasLinkRegister ifTrue: [self MoveMw: 0 r: TempReg R: ReceiverResultReg; AddCq: objectMemory wordSize R: TempReg R: SPReg; MoveR: linkRegSaveRegister R: LinkReg] ifFalse: [| retpcOffset | "The original retpc is (argumentCount + 1) words below stackPointer." retpcOffset := (methodOrBlockNumArgs + 1 * objectMemory wordSize) negated. self MoveMw: retpcOffset r: TempReg R: ClassReg; "get retpc" MoveR: TempReg R: SPReg; MoveMw: 0 r: TempReg R: ReceiverResultReg; MoveR: ClassReg Mw: 0 r: TempReg "put it back on stack for the return..."]. self RetN: 0. (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample jmpTarget: self Label. self genTakeProfileSample. self Jump: continueAfterProfileSample]. "primitive failure. if there is an accessor depth, scan and retry on failure (but what if faling for out of memory?)" jmpFail jmpTarget: self Label. (coInterpreter accessorDepthForPrimitiveMethod: methodObj) >= 0 ifTrue: [| skip | "Given that following primitive state to the accessor depth is recursive, we're asking for trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. This won't be a performance issue since primitive failure should be very rare." self MoveR: FPReg Aw: coInterpreter framePointerAddress. self MoveCw: primitiveRoutine asInteger R: TempReg. self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: ClassReg)). self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress. self genLoadCStackPointersForPrimCall. backEnd genMarshallNArgs: 0 arg: 0 arg: 0 arg: 0 arg: 0. (backEnd isWithinCallRange: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState])) ifTrue: [self CallRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState])] ifFalse: [self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState])]. backEnd genLoadStackPointersForPrimCall: ClassReg. self CmpCq: 0 R: ABIResultReg. skip := self JumpZero: 0. self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. self Jump: retry. skip jmpTarget: self Label] ifFalse: "must reload SPReg to undo any alignment change," [(flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: [backEnd hasLinkRegister ifTrue: [self MoveAw: coInterpreter stackPointerAddress R: SPReg] ifFalse: "remember to include return address; use scratch to avoid an interrupt overwriting retpc" [self MoveAw: coInterpreter stackPointerAddress R: TempReg. self SubCq: objectRepresentation wordSize R: TempReg. self MoveR: TempReg R: SPReg]]]. "Remember to restore the native stack pointer to point to the C stack, otherwise the Smalltalk frames will get overwritten on an interrupt." SPReg ~= NativeSPReg ifTrue: [backEnd genLoadCStackPointer]. "The LinkRegister now contains the return address either of the primitive call or of checkForAndFollowForwardedPrimitiveState. It must be restored to the return address of the send invoking this primtiive method." backEnd hasLinkRegister ifTrue: [self MoveR: linkRegSaveRegister R: LinkReg]. "Finally remember to reload ReceiverResultReg if required. Even if arguments have been pushed, the prolog sequence assumes it is live." (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: [self MoveMw: (methodOrBlockNumArgs + (backEnd hasLinkRegister ifTrue: [0] ifFalse: [1])) * objectMemory wordSize r: SPReg R: ReceiverResultReg]. "continue to frame build..." ^0! Item was changed: ----- Method: StackInterpreter class>>primitiveMetadataTableUsing: (in category 'constants') ----- primitiveMetadataTableUsing: aCCodeGenerator + ^self primitiveTable collect: + [:thing| | implementingClass tMethod | - | slave | - slave := self basicNew. - ^self primitiveTable collectWithIndex: - [:thing :index| | primitiveIndex implementingClass tMethod | - primitiveIndex := index - 1. (thing isInteger "quick prims, 0 for fast primitve fail" or: [thing == #primitiveFail or: [(implementingClass := self primitivesClass whichClassIncludesSelector: thing) isNil]]) ifTrue: [-1 << SpurPrimitiveAccessorDepthShift] ifFalse: [tMethod := (aCCodeGenerator methodNamed: thing) ifNil: [aCCodeGenerator compileToTMethodSelector: thing in: implementingClass]. (aCCodeGenerator accessorDepthForMethod: tMethod) << SpurPrimitiveAccessorDepthShift + + (self metadataFlagsForPrimitive: tMethod)]]! - + (self metadataFlagsForPrimitive: tMethod) - + ((slave isCalloutPrimitiveIndex: primitiveIndex) ifTrue: [0] ifFalse: [PrimCallIsInternalPrim])]]! Item was added: + ----- Method: StackInterpreter>>augmentPrimitiveCalloutMetadataFlags (in category 'plugin primitive support') ----- + augmentPrimitiveCalloutMetadataFlags + "noop in the StackInterpreter" + <inline: #always>! Item was changed: ----- Method: StackInterpreter>>computeAccessorDepthsForInterpreterPrimitives (in category 'primitive support') ----- computeAccessorDepthsForInterpreterPrimitives <doNotGenerate> | cg | cg := self codeGeneratorToComputeAccessorDepth. primitiveMetadataTable ifNil: [primitiveMetadataTable := Array new: primitiveTable size withAll: (-1 bitShift: SpurPrimitiveAccessorDepthShift)]. primitiveTable withIndexDo: [:prim :index| | depthAndFlags | prim isSymbol ifTrue: [depthAndFlags := self metadataFlagsFor: prim using: cg. self assert: depthAndFlags isInteger. - (self isCalloutPrimitiveIndex: index) ifFalse: - [depthAndFlags := depthAndFlags bitOr: PrimCallIsInternalPrim]. primitiveMetadataTable at: index - 1 put: depthAndFlags]]. ^cg! Item was changed: ----- Method: StackInterpreter>>functionForPrimitiveCallout (in category 'plugin primitive support') ----- functionForPrimitiveCallout "Answer the function primitiveCallout from the FFI plugin or nil if it can't be found. Cache it for performance. We use this circumlocution so that Squeak can be deployed without the FFI plugin for security reasons." <returnTypeC: 'void (*functionForPrimitiveCallout())(void)'> <inline: true> primitiveCalloutPointer asInteger = -1 ifTrue: + [primitiveCalloutPointer := self ioLoadFunction: 'primitiveCallout' From: 'SqueakFFIPrims'. + self augmentPrimitiveCalloutMetadataFlags]. - [primitiveCalloutPointer := self ioLoadFunction: 'primitiveCallout' From: 'SqueakFFIPrims']. ^self cCoerceSimple: primitiveCalloutPointer to: #'void (*)(void)'! Item was added: + ----- Method: StackInterpreterPrimitives>>primitiveUnloadModule (in category 'plugin primitives') ----- + primitiveUnloadModule + "Primitive. Unload the module with the given name. + Reloading of the module will happen *later* automatically, when a + function from it is called. This is forced by invalidating all external + primitive methods and activations in flushExternalPrimitives. + N.B. since this is most likely a development time activity we don't care about performance." + <primitiveMetadata: #PrimCallMayEndureCodeCompaction> + | moduleName moduleLength | + moduleName := self stackTop. + (objectMemory isBytes: moduleName) ifFalse:[^self primitiveFail]. + moduleLength := objectMemory numBytesOfBytes: moduleName. + (self ioUnloadModule: (self oopForPointer: (objectMemory firstIndexableField: moduleName)) + OfLength: moduleLength) ifFalse:[^self primitiveFail]. + (self object: moduleName equalsString: 'SqueakFFIPrims' ofSize: moduleLength) ifTrue: + [primitiveCalloutPointer := self cCoerceSimple: -1 to: #'void *']. + self forceInterruptCheck. + self flushExternalPrimitives. + self pop: 1 "pop moduleName; return receiver"!

1 0

[OpenSmalltalk/opensmalltalk-vm] FileStreams are limited and too slow (Issue #613)
by unique75m 17 Feb '22

17 Feb '22

I copy the email conversation. The short form is, i am running Squeak 5.3 on my macOSX 12.0.1 (2017 macBook Pro) and there are 2 problems. The file stream primitives (open/(close) are too slow and because they are slow i need to hold 4000 file streams open, but then i get a problem with the external semaphore limit and Squeak is freezing and consumes 100% cpu time. ############################################## Is there a limit with file streams? I cannot open more than 238 on my macOSX. The 239th fails and Squeak runs with 100% cpu power. I changed then the method StandardFileStream>>open:forWrite: and removed the #retryWithGC:until:forFileNamed:, because it looked to me, that it does not much things. Now I get a <nil> back from the primitive. | directory streams | directory := FileDirectory default directoryNamed: 'Test'. directory assureExistence. streams := (1 to: 239) collect: [:index | directory fileNamed: 'test', index printString]. streams do: #close Jörg ############################################# On 2/17/22 08:20, Jörg Belger wrote: Is there a limit with file streams? I cannot open more than 238 on my macOSX. The 239th fails and Squeak runs with 100% cpu power. I changed then the method StandardFileStream>>open:forWrite: and removed the #retryWithGC:until:forFileNamed:, because it looked to me, that it does not much things. Now I get a <nil> back from the primitive. There may be a per-process limit on the number of file descriptors. When Squeak runs out, it is (I suspect) assuming that some unused file handles exist on the heap, so it tries to GC, hoping that a collection will close some unwanted file descriptors. Unfortunately if it really is running up against the limit, this strategy won't help! (We should do something better... but what?) You might be able to see what the current limit is with `ulimit -a`. If that's the cause of the problem, you could try to raise the limit at the OS level - I'm afraid I don't have a mac to hand to try it myself though. Regards, Tony ############################################## Hi Jörg, On Thu, 17 Feb 2022, Jörg Belger wrote: Is there a limit with file streams? I cannot open more than 238 on my macOSX. The 239th fails and Squeak runs with 100% cpu power. I changed then the method StandardFileStream>>open:forWrite: and removed the #retryWithGC:until:forFileNamed:, because it looked to me, that it does not much things. Now I get a <nil> back from the primitive. | directory streams | directory := FileDirectory default directoryNamed: 'Test'. directory assureExistence. streams := (1 to: 239) collect: [:index | directory fileNamed: 'test', index printString]. streams do: #close There is a limit on the maximum number of external semaphores provided by the VM. Each socket uses 3 external semaphores and each file uses one. The default limit is 256 which is very conservative and I hope the next release will ship with at least 4096 as default. Anyway, you can check the current value with Smalltalk maxExternalSemaphores and set it with Smalltalk maxExternalSemaphores: 4096 Some care must be taken not to change the limit while signals are expected to be processed (e.g. when you have activity on those sockets/files), because there's a short period during the resize while the VM may fail to signal the semaphores. Levente ############################################### My problem is simply that I need to leave the streams open coz reopening for every write is too slow. I have realtime data coming through a socket in nanosecond precision and the file handling must be very fast. Currently I have 120 nanosecond realtime streams and 2645 minute-based streams. As I use now binary format instead of the previous CSV format, I cannot read the plain data files anyway, so maybe I will give Magma a try. It does not matter if I can’t read binary files or can’t read Magma files with a text editor :-) ############################################### Seems not to work. I set the max semaphores to 8192 and opened only 4000 files. But the Squeak VM only created 242 files on hard disk and freezes with 100% cpu consumption ############################################### Hi Jörg, On Thu, 17 Feb 2022, Jörg Belger wrote: Seems not to work. I set the max semaphores to 8192 and opened only 4000 files. But the Squeak VM only created 242 files on hard disk and freezes with 100% cpu consumption As others wrote, there are also limits on the maximum number of open file descriptors. One is set by the OS per process. Typically 1024 on unix machines. E.g. on linux you can see the limit with the ulimit -n command. That can typically be changed with superuser privileges. And there's another limit if the file descriptor sets are processed with the select() function, which currently happens on Windows and Mac. Linux (and IIRC OpenIndiana too) uses epoll(), so there is no upper limit there. If select() is used, the value of FD_SETSIZE decides the maximum number of file descriptors that can be opened. Its value is typically 1024, and you'd need to compile your own VM to be able to change that if the OS permits it (Windows and Mac do). Levente ################################################ The least I expect is that I get a debugger in Smalltalk when the limit is reached and not a Squeak that is not reactive and consumes 100% cpu time. But anyway I get the hanging Squeak already with 242 file streams, independent if I set the #maxExternalSemaphores to 8192. If I do the same in VisualWorks and open 4000 write streams I have no problems with limits, so I guess it is not an operating system limit, it is a Squeak VM limit. There is no reason why everything needs to be implemented in C code, the goal should be to implement as much as we can in Smalltalk. The reason why I opened so much files is that the Squeak file API is very slow for my realtime streaming, so I simply leave the files open. Here is an example: VisualWorks needs 700ms Time millisecondsToRun: [| filename | filename := 'test.txt' asFilename. 10000 timesRepeat: [filename readWriteStream close]] Squeak needs 4000ms Time millisecondsToRun: [10000 timesRepeat: [(FileStream fileNamed: 'test,txt‘) close]] If you can tell me a faster way to open/write/close a file it would be nice. Jörg ############################################### On Thu, Feb 17, 2022 at 05:05:43PM +0100, J??rg Belger wrote: The least I expect is that I get a debugger in Smalltalk when the limit is reached and not a Squeak that is not reactive and consumes 100% cpu time. But anyway I get the hanging Squeak already with 242 file streams, independent if I set the #maxExternalSemaphores to 8192. If I do the same in VisualWorks and open 4000 write streams I have no problems with limits, so I guess it is not an operating system limit, it is a Squeak VM limit. There is no reason why everything needs to be implemented in C code, the goal should be to implement as much as we can in Smalltalk. The reason why I opened so much files is that the Squeak file API is very slow for my realtime streaming, so I simply leave the files open. Here is an example: VisualWorks needs 700ms Time millisecondsToRun: [| filename | filename := 'test.txt' asFilename. 10000 timesRepeat: [filename readWriteStream close]] Squeak needs 4000ms Time millisecondsToRun: [10000 timesRepeat: [(FileStream fileNamed: 'test,txt???) close]] On my Linux box it only takes about 100ms. If you can tell me a faster way to open/write/close a file it would be nice. J??rg You may want to try profiling it to see where the time is going: TimeProfileBrowser onBlock: [10000 timesRepeat: [(FileStream fileNamed: 'test,txt') close]]. Dave ################################################ Hi Jörg, On Thu, 17 Feb 2022, Jörg Belger wrote: The least I expect is that I get a debugger in Smalltalk when the limit is reached and not a Squeak that is not reactive and consumes 100% cpu time. But anyway I get the hanging Squeak already with 242 file streams, independent if I set the #maxExternalSemaphores to 8192. Squeak is trying to be optimistic and assumes that files can be opened but the descriptors are consumed by abandoned but unclosed files. Doing a GC will trigger the automatic closing of such files freeing up the file descriptors. If I do the same in VisualWorks and open 4000 write streams I have no problems with limits, so I guess it is not an operating system limit, it is a Squeak VM limit. There is no reason why everything needs to be implemented in C code, the goal should be to implement as much as we can in Smalltalk. The reason why I opened so much files is that the Squeak file API is very slow for my realtime streaming, so I simply leave the files open. Here is an example: VisualWorks needs 700ms Time millisecondsToRun: [| filename | filename := 'test.txt' asFilename. 10000 timesRepeat: [filename readWriteStream close]] Squeak needs 4000ms Time millisecondsToRun: [10000 timesRepeat: [(FileStream fileNamed: 'test,txt‘) close]] If you can tell me a faster way to open/write/close a file it would be nice. On my machine (linux) I get 145ms. Are you on Windows? Levente #################################################### MultiByteFileStream >> open:forWrite: needs 96.8% Can I increase the tallying depth? Because it stops at this method and I do not see the calls inside this method. #################################################### Funny, I commented out some things (red) in #open:forWrite:. Now the profiler is telling me that „String new: 1“ tools 97.4%… Really? Or is this a profiler bug? open: fileName forWrite: writeMode "Open the file with the given name. If writeMode is true, allow writing, otherwise open the file in read-only mode." "Changed to do a GC and retry before failing ar 3/21/98 17:25" | f | f := fileName asVmPathName. fileID := "StandardFileStream retryWithGC:[" self primOpen: f writable: writeMode "] until:[:id| id notNil] forFileNamed: fileName". fileID ifNil: [^ nil]. "allows sender to detect failure" name := fileName. "self register." rwmode := writeMode. buffer1 := String new: 1. self enableReadBuffering ###################################################### On Thu, 17 Feb 2022, Jörg Belger wrote: Funny, I commented out some things (red) in #open:forWrite:. Now the profiler is telling me that „String new: 1“ tools 97.4%… Really? Or is this a profiler bug? It's a limitation of the profiler. That profiler uses sampling and is implemented entirely in Smalltalk, so it can only measure message sends. What happens with your code is that after the #asVmPathName send a primitive is invoked (#primOpen:writable:), and that is not a real message send. Then inlined code comes (#ifNil:), which is also not a send. Then assignments come which are also not sends. The first actual send is String >> #new:. So, the profiler will count everything that happend before that send and after #asVmPathName towards String >> #new:, which is why you see such high number there. Since you know that String >> #new: with argument 1 is not expected to take too long, and the same applies to #ifNil: and the assignments, you can be sure that the time is spent in #primOpen:writable:, which is primitiveFileOpen in FilePlugin. And that is known to be quite slow on Windows presumably due to anti-virus measures. Levente ####################################################### I am on a Mac :-) And the 4 times faster VisualWorks code is running on same Mac :-) -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/613 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/613(a)github.com>

1 0

[OpenSmalltalk/opensmalltalk-vm] 5bb002: CogVM source as per VMMaker.oscog-eem.3156
by Eliot Miranda 16 Feb '22

16 Feb '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 5bb002e83bc166334b78e63f5f09fa19ea34f8d8 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5bb002e83bc166334b… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-02-15 (Tue, 15 Feb 2022) Changed paths: M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3156 Remember to regenerate the cogit files sicne the PrimCallXXX flags have changed. They should be in a common include. Sigh...

1 0

[OpenSmalltalk/opensmalltalk-vm] 1bb967: CogVM source as per VMMaker.oscog-eem.3156
by Eliot Miranda 16 Feb '22

16 Feb '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1bb96795fca099baedd8f45e59c847786aae91d6 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1bb96795fca099baed… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-02-15 (Tue, 15 Feb 2022) Changed paths: M platforms/Cross/plugins/IA32ABI/arm64abicc.c M platforms/unix/plugins/FileDialogPlugin/sqUnixFileDialog.c M platforms/unix/vm/aio.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c A src/plugins/SqueakFFIPrims/ARM64AppleFFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/SqueakFFIPrims.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack/validImage.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3156 CoInterpreter: Fix issues with the PrimCallXXX flags. PrimCallIsInternalPrim wasn't initialized!! PrimCallIsExternalCall isn't used. PrimCallIsInternalPrim should be set on all numbered primitives except the FFI & named prim primitives. ThreadedFFI ARM64 plugin: Apple diverges significantly from the standard. In particular, stacked arguments are packed like a struct (char takes one byte, short is aligned on a doublebyte boundary and takes two bytes, etc). Hence introduce ThreadedARM64AppleFFIPlugin as a subclass of ThreadedARM64FFIPlugin. Have ThreadedARM64FFIPlugin inherit from ThreadedFFIPlugin; it inherits nothing from ThreadedARM32FFIPlugin. Rename the ThreadedFFIX64SixteenByteReturnXX classes since they are more generally useful. In particular use ThreadedFFI64Bit16ByteReturnII to implement struct (and integer) return on ARM64. Hence get rid of getX1register (& returnX1value from arm64abicc.c). Fix two typos in primitiveSignedInt32At et al. Unix aio.c: rename epollEventsByFileDescriptorSize to epollEventsDescriptorCount and improve commenting of #if#then#else chains. unix/plugins/FileDialogPlugin/sqUnixFileDialog.c apply the fix for include files from Bruce; thanks!!

1 0

VM Maker: VMMaker.oscog-eem.3156.mcz
by commits＠source.squeak.org 16 Feb '22

16 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3156.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3156 Author: eem Time: 15 February 2022, 6:12:25.887338 pm UUID: 1000a975-b96e-40bb-8c41-47dbd0a06e3e Ancestors: VMMaker.oscog-eem.3155 ThreadedFFI ARM64 plugin: Apple diverges significantly from the standard. In particular, stacked arguments are packed like a struct (char takes one byte, short is aligned on a doublebyte boundary and takes two bytes, etc). Hence introduce ThreadedARM64AppleFFIPlugin as a subclass of ThreadedARM64FFIPlugin. Have ThreadedARM64FFIPlugin inherit from ThreadedFFIPlugin; it inherits nothing from ThreadedARM32FFIPlugin. Rename the ThreadedFFIX64SixteenByteReturnXX classes since they are more generally useful. In particular use ThreadedFFI64Bit16ByteReturnII to implement struct (and integer) return on ARM64. Hence get rid of getX1register (& returnX1value). Fix two typos in primitiveSignedInt32At et al. =============== Diff against VMMaker.oscog-eem.3155 =============== Item was added: + ThreadedARM64FFIPlugin subclass: #ThreadedARM64AppleFFIPlugin + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! + + !ThreadedARM64AppleFFIPlugin commentStamp: 'eem 2/15/2022 14:12' prior: 0! + A ThreadedARM64AppleFFIPlugin is a version of ThreadedARM64FFIPlugin that implements Apple's divergences from the ARM64 standard ABI, as described on https://developer.apple.com/documentation/xcode/writing-arm64-code-for-appl… in section "Pass Arguments to Functions Correctly". + + Instance Variables + ! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin class>>excludingPredefinedMacros (in category 'translation') ----- + excludingPredefinedMacros + ^nil! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin class>>moduleName (in category 'translation') ----- + moduleName + ^'ARM64AppleFFIPlugin'! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>alignCurrentArgOf:to: (in category 'marshalling') ----- + alignCurrentArgOf: calloutState to: boundary + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + | misAlignedBytes | + misAlignedBytes := calloutState currentArg asInteger bitAnd: boundary - 1. + misAlignedBytes ~= 0 ifTrue: + [calloutState currentArg: calloutState currentArg + (boundary - misAlignedBytes)]! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushFloat32:in: (in category 'marshalling') ----- + ffiPushFloat32: value in: calloutState + <var: #value type: #float> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState floatRegisterIndex < NumFloatRegArgs + ifTrue: "Note: this is a 'memcopy', so size is preserved. Casting to #double changes the size" + [(self cCoerceSimple: + (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) + to: 'float*') + at: 0 + put: value. + calloutState floatRegisterIndex: calloutState floatRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 4. + interpreterProxy storeSingleFloatAtPointer: calloutState currentArg from: value. + calloutState currentArg: calloutState currentArg + 4]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushFloat64:in: (in category 'marshalling') ----- + ffiPushFloat64: value in: calloutState + <var: #value type: #double> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + + calloutState floatRegisterIndex < NumFloatRegArgs + ifTrue: + [calloutState floatRegisters + at: calloutState floatRegisterIndex + put: value. + calloutState floatRegisterIndex: calloutState floatRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + calloutState floatRegisterIndex: NumFloatRegArgs. + self alignCurrentArgOf: calloutState to: 8. + interpreterProxy storeFloatAtPointer: calloutState currentArg from: value. + calloutState currentArg: calloutState currentArg + 8]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- + ffiPushPointer: pointer in: calloutState + <var: #pointer type: #'void *'> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: pointer asInteger. + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: self wordSize. + interpreterProxy longAt: calloutState currentArg put: pointer. + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushSigned16:in: (in category 'marshalling') ----- + ffiPushSigned16: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed short'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 2. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed short'). + calloutState currentArg: calloutState currentArg + 2]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushSigned32:in: (in category 'marshalling') ----- + ffiPushSigned32: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters + at: calloutState integerRegisterIndex + put: (self cCoerceSimple: value to: #sqLong). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 4. + interpreterProxy longAt: calloutState currentArg put: value. + calloutState currentArg: calloutState currentArg + 4]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushSigned64:in: (in category 'marshalling') ----- + ffiPushSigned64: value in: calloutState + <var: #value type: #sqLong> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters + at: calloutState integerRegisterIndex + put: (self cCoerceSimple: value to: #sqLong). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 8. + interpreterProxy longAt: calloutState currentArg put: value. + calloutState currentArg: calloutState currentArg + 8]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushSigned8:in: (in category 'marshalling') ----- + ffiPushSigned8: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). + calloutState currentArg: calloutState currentArg + 1]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- + ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState + <var: #pointer type: #'void *'> + <var: #argSpec type: #'unsigned int *'> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + | availableRegisterSpace stackPartSize roundedSize | + "See IHI0055B_aapcs64.pdf sections 4.3.5 & 5.4.2 Stage C; we don't yet support HVA's" + (self structIsHomogenousFloatArrayOfSize: structSize typeSpec: argSpec ofLength: argSpecSize) + ifTrue: + [availableRegisterSpace := (NumFloatRegArgs - calloutState floatRegisterIndex) * self wordSize. + structSize <= availableRegisterSpace ifTrue: "Stage C, step C.2, all in floating-point registers (!!!!)" + [self + memcpy: (self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) to: #'void *') + _: pointer + _: structSize. + "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" + calloutState floatRegisterIndex: calloutState floatRegisterIndex + (structSize + 7 bitShift: -3). + ^0]. + "Stage C, step C.3" + availableRegisterSpace := 0. + calloutState floatRegisterIndex: 8] + + ifFalse: + [availableRegisterSpace := (NumIntRegArgs - calloutState integerRegisterIndex) * self wordSize]. + stackPartSize := structSize. + availableRegisterSpace > 0 ifTrue: + [structSize <= availableRegisterSpace ifTrue:"all in integer registers" + [self + memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: #'void *') + _: pointer + _: structSize. + "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" + calloutState integerRegisterIndex: calloutState integerRegisterIndex + (structSize + 7 bitShift: -3). + ^0]. + "If no previous co-processor candidate arg has already been pushed on the stack, then split the struct between registers and stack. + Otherwise push entire struct on stack." + calloutState currentArg = calloutState argVector + ifTrue: + [stackPartSize := structSize - availableRegisterSpace. + self + memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') + _: pointer + _: availableRegisterSpace] + ifFalse: + [availableRegisterSpace := 0]. + "Stage C, step C.11" + calloutState integerRegisterIndex: NumIntRegArgs]. + + stackPartSize > 0 ifTrue: + [roundedSize := stackPartSize + 3 bitClear: 3. + calloutState currentArg + roundedSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 8. + self memcpy: calloutState currentArg _: (self addressOf: ((self cCoerceSimple: pointer to: #'char *') at: availableRegisterSpace)) _: stackPartSize. + calloutState currentArg: calloutState currentArg + roundedSize]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushUnsigned16:in: (in category 'marshalling') ----- + ffiPushUnsigned16: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned short'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 2. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned short'). + calloutState currentArg: calloutState currentArg + 2]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushUnsigned32:in: (in category 'marshalling') ----- + ffiPushUnsigned32: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: value. + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 4. + interpreterProxy longAt: calloutState currentArg put: value. + calloutState currentArg: calloutState currentArg + 4]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushUnsigned64:in: (in category 'marshalling') ----- + ffiPushUnsigned64: value in: calloutState + <var: #value type: #usqLong> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters + at: calloutState integerRegisterIndex + put:(self cCoerceSimple: value to: #usqLong). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. + self alignCurrentArgOf: calloutState to: 8. + interpreterProxy longAt: calloutState currentArg put: value. + calloutState currentArg: calloutState currentArg + 8]. + ^0! Item was added: + ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushUnsigned8:in: (in category 'marshalling') ----- + ffiPushUnsigned8: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). + calloutState currentArg: calloutState currentArg + 1]. + ^0! Item was changed: + ThreadedFFIPlugin subclass: #ThreadedARM64FFIPlugin - ThreadedARM32FFIPlugin subclass: #ThreadedARM64FFIPlugin instanceVariableNames: '' + classVariableNames: 'NumFloatRegArgs NumIntRegArgs' - classVariableNames: '' poolDictionaries: '' category: 'VMMaker-Plugins-FFI'! + !ThreadedARM64FFIPlugin commentStamp: 'KenD 12/17/2018 14:38' prior: 0! - !ThreadedARM64FFIPlugin commentStamp: '' prior: 0! A ThreadedARM64FFIPlugin is for the 64-bit ARM ABI. It typically has 8 integer registers Instance Variables ! Item was added: + ----- Method: ThreadedARM64FFIPlugin class>>ancilliaryClasses (in category 'translation') ----- + ancilliaryClasses + ^super ancilliaryClasses, + { ThreadedFFI64Bit16ByteReturnII }! Item was added: + ----- Method: ThreadedARM64FFIPlugin class>>excludingPredefinedMacros (in category 'translation') ----- + excludingPredefinedMacros + ^#('__APPLE__')! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | myThreadIndex atomicType floatRet intRet structRet specSize | - | myThreadIndex atomicType floatRet intRet x1Ret specSize | <var: #floatRet type: 'union { struct { float floats[8]; } f; struct dprr { double doubles[4]; } d; }'> + <var: #structRet type: #SixteenByteReturnII> <var: #intRet type: #usqLong> - <var: #x1Ret type: #usqLong> <inline: #always> + self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; these should be proper struct types..." - self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; this shoudl be a proper struct..." myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. ((atomicType >> 1) = (FFITypeSingleFloat >> 1) or: [(calloutState ffiRetHeader bitAnd: FFIFlagPointer+FFIFlagStructure) = FFIFlagStructure and: [self structIsHomogenousFloatArrayOfSize: (calloutState ffiRetHeader bitAnd: FFIStructSizeMask) typeSpec: (self cCoerce: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) to: #'unsigned int *') ofLength: (specSize := interpreterProxy byteSizeOf: calloutState ffiRetSpec) / (self sizeof: #'unsigned int')]]) ifTrue: [floatRet d: (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'struct dprr (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. atomicType = FFITypeDoubleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet d doubles at: 0)]. atomicType = FFITypeSingleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet f floats at: 0)]. "If the struct is a vector of floats then move float[2] to float[1], float[4] to float[2] and float[6] to float[3], to pack the float data in the double fields. We can tell if the struct is composed of floats if its size is less than the spec size, since the spec size is (1 + n fields) * 4 bytes, and the struct size is n fields * 4 bytes for floats and n fields * 8 bytes for doubles. We can't access the spec post call because it may have moved." specSize > calloutState structReturnSize ifTrue: [floatRet f floats at: 1 put: (floatRet f floats at: 2). floatRet f floats at: 2 put: (floatRet f floats at: 4). floatRet f floats at: 3 put: (floatRet f floats at: 6)]. ^self ffiReturnStruct: (self addressOf: floatRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. + "Integer and Structure returns..." + "If struct address used for return value, call is special; struct return pointer must be in x8" - "If struct address used for return value, call is special" (self mustReturnStructOnStack: calloutState structReturnSize) + ifTrue: + [intRet := 0. + self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" + andCall: (self cCoerceSimple: procAddr to: #sqLong) + withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong)] + ifFalse: + [structRet := self + dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') + with: (calloutState integerRegisters at: 0) + with: (calloutState integerRegisters at: 1) + with: (calloutState integerRegisters at: 2) + with: (calloutState integerRegisters at: 3) + with: (calloutState integerRegisters at: 4) + with: (calloutState integerRegisters at: 5) + with: (calloutState integerRegisters at: 6) + with: (calloutState integerRegisters at: 7). + intRet := structRet a]. "X1" - ifTrue: [ - intRet := 0. - self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" - andCall: (self cCoerceSimple: procAddr to: #sqLong) - withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong). - ] ifFalse: [ - intRet := self - dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') - with: (calloutState integerRegisters at: 0) - with: (calloutState integerRegisters at: 1) - with: (calloutState integerRegisters at: 2) - with: (calloutState integerRegisters at: 3) - with: (calloutState integerRegisters at: 4) - with: (calloutState integerRegisters at: 5) - with: (calloutState integerRegisters at: 6) - with: (calloutState integerRegisters at: 7). - - x1Ret := self getX1register. "Capture x1 immediately. No problem if unused" - ]. - "If struct returned in registers, - place register values into calloutState integerRegisters" - (calloutState structReturnSize > 0 - and: [self returnStructInRegisters: calloutState]) ifTrue: - ["Only 2 regs used in ARMv8/Aarch64 current" - calloutState integerRegisters at: 0 put: intRet. "X0" - calloutState integerRegisters at: 1 put: x1Ret]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: (((self returnStructInRegisters: calloutState) + ifTrue: [self cCoerceSimple: (self addressOf: structRet) to: #'char *'] - ifTrue: [self addressOf: calloutState integerRegisters] ifFalse: [calloutState limit])) ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiPushPointer:in: (in category 'marshalling') ----- + ffiPushPointer: pointer in: calloutState + <var: #pointer type: #'void *'> + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: pointer asInteger. + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: pointer. + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiPushSigned16:in: (in category 'marshalling') ----- + ffiPushSigned16: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed short'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed short'). + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiPushSigned8:in: (in category 'marshalling') ----- + ffiPushSigned8: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'signed char'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed char'). + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiPushUnsigned16:in: (in category 'marshalling') ----- + ffiPushUnsigned16: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned short'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned short'). + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiPushUnsigned8:in: (in category 'marshalling') ----- + ffiPushUnsigned8: value in: calloutState + <var: #calloutState type: #'CalloutState *'> + <inline: #always> + calloutState integerRegisterIndex < NumIntRegArgs + ifTrue: + [calloutState integerRegisters at: calloutState integerRegisterIndex put: (self cCoerceSimple: value to: #'unsigned char'). + calloutState integerRegisterIndex: calloutState integerRegisterIndex + 1] + ifFalse: + [calloutState currentArg + self wordSize > calloutState limit ifTrue: + [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned char'). + calloutState currentArg: calloutState currentArg + self wordSize]. + ^0! Item was removed: - ----- Method: ThreadedARM64FFIPlugin>>getX1register (in category 'callout support') ----- - getX1register - - <inline: true> - <var: #returnX1value declareC: 'extern sqLong returnX1value()'> - - ^self returnX1value! Item was added: + ThreadedFFIAbstractStructReturnStruct subclass: #ThreadedFFI64Bit16ByteReturnDD + instanceVariableNames: 'a b' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! + + !ThreadedFFI64Bit16ByteReturnDD commentStamp: 'nice 1/25/2020 17:43' prior: 0! + A ThreadedFFIX64SixteenByteReturnDD is a stub for returning a struct by value through 2 eight-byte float registers + That is (XMM0 XMM1) on X64. + + Instance Variables + a: <Object> + b: <Object> + + a + - stub for first eighbyte + + b + - stub for second eighbyte + ! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDD class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- + instVarNamesAndTypesForTranslationDo: aBinaryBlock + "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." + + aBinaryBlock value: 'a' value: #double. + aBinaryBlock value: 'b' value: #double.! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDD>>a (in category 'accessing') ----- + a + + ^ a! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDD>>a: (in category 'accessing') ----- + a: anObject + + ^a := anObject! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDD>>b (in category 'accessing') ----- + b + + ^ b! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDD>>b: (in category 'accessing') ----- + b: anObject + + ^b := anObject! Item was added: + ThreadedFFIAbstractStructReturnStruct subclass: #ThreadedFFI64Bit16ByteReturnDI + instanceVariableNames: 'a b' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! + + !ThreadedFFI64Bit16ByteReturnDI commentStamp: 'nice 1/25/2020 17:44' prior: 0! + A ThreadedFFIX64SixteenByteReturnDI is a stub for returning a struct by value through 1 eight-byte float register and 1 eight-byte int register + That is (XMM0 RAX) on X64. + + Instance Variables + a: <Object> + b: <Object> + + a + - stub for first eighbyte + + b + - stub for second eighbyte + ! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDI class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- + instVarNamesAndTypesForTranslationDo: aBinaryBlock + "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." + + aBinaryBlock value: 'a' value: #double. + aBinaryBlock value: 'b' value: #sqInt.! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDI>>a (in category 'accessing') ----- + a + + ^ a! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDI>>a: (in category 'accessing') ----- + a: anObject + + ^a := anObject! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDI>>b (in category 'accessing') ----- + b + + ^ b! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnDI>>b: (in category 'accessing') ----- + b: anObject + + ^b := anObject! Item was added: + ThreadedFFIAbstractStructReturnStruct subclass: #ThreadedFFI64Bit16ByteReturnID + instanceVariableNames: 'a b' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! + + !ThreadedFFI64Bit16ByteReturnID commentStamp: 'nice 1/25/2020 17:45' prior: 0! + A ThreadedFFIX64SixteenByteReturnID is a stub for returning a struct by value through 1 eight-byte int register and 1 eight-byte float register + That is (RAX XMM0) on X64. + + Instance Variables + a: <Object> + b: <Object> + + a + - stub for first eighbyte + + b + - stub for second eighbyte + ! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnID class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- + instVarNamesAndTypesForTranslationDo: aBinaryBlock + "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." + + aBinaryBlock value: 'a' value: #sqInt. + aBinaryBlock value: 'b' value: #double.! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnID>>a (in category 'accessing') ----- + a + + ^ a! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnID>>a: (in category 'accessing') ----- + a: anObject + + ^a := anObject! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnID>>b (in category 'accessing') ----- + b + + ^ b! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnID>>b: (in category 'accessing') ----- + b: anObject + + ^b := anObject! Item was added: + ThreadedFFIAbstractStructReturnStruct subclass: #ThreadedFFI64Bit16ByteReturnII + instanceVariableNames: 'a b' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! + + !ThreadedFFI64Bit16ByteReturnII commentStamp: 'nice 1/25/2020 17:44' prior: 0! + A ThreadedFFIX64SixteenByteReturnII is a stub for returning a struct by value through 2 eight-byte int registers + That is (RAX RDX) on X64. + + Instance Variables + a: <Object> + b: <Object> + + a + - stub for first eighbyte + + b + - stub for second eighbyte + ! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnII class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- + instVarNamesAndTypesForTranslationDo: aBinaryBlock + "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." + + aBinaryBlock value: 'a' value: #sqInt. + aBinaryBlock value: 'b' value: #sqInt.! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnII>>a (in category 'accessing') ----- + a + + ^ a! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnII>>a: (in category 'accessing') ----- + a: anObject + + ^a := anObject! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnII>>b (in category 'accessing') ----- + b + + ^ b! Item was added: + ----- Method: ThreadedFFI64Bit16ByteReturnII>>b: (in category 'accessing') ----- + b: anObject + + ^b := anObject! Item was added: + VMStructType subclass: #ThreadedFFIAbstractStructReturnStruct + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Plugins-FFI'! Item was added: + ----- Method: ThreadedFFIAbstractStructReturnStruct class>>structTypeName (in category 'translation') ----- + structTypeName + ^'SixteenByteReturn', (self name last: 2)! Item was changed: ----- Method: ThreadedFFIPlugin class>>generateCodeStringForPrimitives (in category 'translation') ----- generateCodeStringForPrimitives "Output a skeletal SqueakFFIPrims.c that includes the relevant FooFFIPlugin.c for each subclass based on the identifyingPredefinedMacros the subclass defines." ^String streamContents: [:s| s nextPutAll: '/* Automatically generated by\ ' withCRs. s nextPutAll: (CCodeGenerator monticelloDescriptionFor: self). s cr; nextPutAll: ' */'. s cr; cr; nextPut: $#. + (self allSubclasses sort: [:a :b| (a inheritsFrom: b) + ifTrue: [false] + ifFalse: + [(b inheritsFrom: a) + or: [a name < b name]]]) do: - (self allSubclasses sort: [:a :b| a name < b name]) do: [:class | class identifyingPredefinedMacros ifNotNil: [:predefinedMacros| s nextPutAll: 'if '. class includingPredefinedMacros ifNotNil: [:includingMacros| includingMacros do: [:predefinedMacro| s nextPutAll: 'defined('; nextPutAll: predefinedMacro; nextPutAll: ') && ']. s nextPut: $(]. class excludingPredefinedMacros ifNotNil: [:excludingMacros| excludingMacros do: [:predefinedMacro| s nextPutAll: '!!defined('; nextPutAll: predefinedMacro; nextPutAll: ') && ']. s nextPut: $(]. predefinedMacros do: [:predefinedMacro| s nextPutAll: 'defined('; nextPutAll: predefinedMacro; nextPut: $)] separatedBy: [s nextPutAll: ' || ']. class excludingPredefinedMacros ifNotNil: [s nextPut: $)]. class includingPredefinedMacros ifNotNil: [s nextPut: $)]. s cr; cr; nextPutAll: '# define '; nextPutAll: class moduleName; nextPutAll: '_exports '; nextPutAll: self moduleName; nextPutAll: '_exports'. s cr; nextPutAll: '# include "'; nextPutAll: class moduleName; nextPutAll: '.c"'. s cr; cr; nextPutAll: '#el']]. s nextPutAll: 'se'. #( 'As yet no FFI implementation appears to exist for your platform.' 'Consider implementing it, starting by adding a subclass of ThreadedFFIPlugin.') do: [:msg| s cr; nextPutAll: '# error '; nextPutAll: msg]. s cr; nextPutAll: '#endif'; cr]! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveSignedInt32At (in category 'primitives') ----- primitiveSignedInt32At + "Answer the signed 32-bit integer starting at the given byte offset (native endian)." - "Answer the signed 16-bit integer starting at the given byte offset (native endian)." <export: true> <primitiveMetadata: #FastCPrimitiveFlag> | byteOffset rcvr | byteOffset := interpreterProxy stackValue: 0. rcvr := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: byteOffset) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #int)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| ^interpreterProxy methodReturnValue: (interpreterProxy signed32BitIntegerFor: (self cCoerce: (interpreterProxy unalignedLong32At: addr) to: #'signed int'))]! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveUnsignedInt16AtPut (in category 'primitives') ----- primitiveUnsignedInt16AtPut + "Store the unsigned 16-bit integer starting at the given byte offset (native endian)." - "Store the signed 16-bit integer starting at the given byte offset (native endian)." <export: true> <primitiveMetadata: #FastCPrimitiveFlag> | valueArg value byteOffset rcvr | valueArg := interpreterProxy stackValue: 0. byteOffset := interpreterProxy stackValue: 1. rcvr := interpreterProxy stackValue: 2. ((interpreterProxy isIntegerObject: valueArg) and: [((value := interpreterProxy integerValueOf: valueArg) between: 0 and: 65535) and: [interpreterProxy isIntegerObject: byteOffset]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (self ffiAddressOf: rcvr startingAt: (interpreterProxy integerValueOf: byteOffset) size: (self sizeof: #short)) ifNil: [^interpreterProxy primitiveFailFor: PrimErrBadIndex] ifNotNil: [:addr| interpreterProxy unalignedShortAt: addr put: value. ^interpreterProxy methodReturnValue: valueArg]! Item was removed: - VMStructType subclass: #ThreadedFFIX64SixteenByteReturnDD - instanceVariableNames: 'a b' - classVariableNames: '' - poolDictionaries: '' - category: 'VMMaker-Plugins-FFI'! - - !ThreadedFFIX64SixteenByteReturnDD commentStamp: 'nice 1/25/2020 17:43' prior: 0! - A ThreadedFFIX64SixteenByteReturnDD is a stub for returning a struct by value through 2 eight-byte float registers - That is (XMM0 XMM1) on X64. - - Instance Variables - a: <Object> - b: <Object> - - a - - stub for first eighbyte - - b - - stub for second eighbyte - ! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- - instVarNamesAndTypesForTranslationDo: aBinaryBlock - "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." - - aBinaryBlock value: 'a' value: #double. - aBinaryBlock value: 'b' value: #double.! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD class>>structTypeName (in category 'translation') ----- - structTypeName - ^'SixteenByteReturnDD'! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD>>a (in category 'accessing') ----- - a - - ^ a! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD>>a: (in category 'accessing') ----- - a: anObject - - ^a := anObject! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD>>b (in category 'accessing') ----- - b - - ^ b! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDD>>b: (in category 'accessing') ----- - b: anObject - - ^b := anObject! Item was removed: - VMStructType subclass: #ThreadedFFIX64SixteenByteReturnDI - instanceVariableNames: 'a b' - classVariableNames: '' - poolDictionaries: '' - category: 'VMMaker-Plugins-FFI'! - - !ThreadedFFIX64SixteenByteReturnDI commentStamp: 'nice 1/25/2020 17:44' prior: 0! - A ThreadedFFIX64SixteenByteReturnDI is a stub for returning a struct by value through 1 eight-byte float register and 1 eight-byte int register - That is (XMM0 RAX) on X64. - - Instance Variables - a: <Object> - b: <Object> - - a - - stub for first eighbyte - - b - - stub for second eighbyte - ! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- - instVarNamesAndTypesForTranslationDo: aBinaryBlock - "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." - - aBinaryBlock value: 'a' value: #double. - aBinaryBlock value: 'b' value: #sqInt.! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI class>>structTypeName (in category 'translation') ----- - structTypeName - ^'SixteenByteReturnDI'! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI>>a (in category 'accessing') ----- - a - - ^ a! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI>>a: (in category 'accessing') ----- - a: anObject - - ^a := anObject! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI>>b (in category 'accessing') ----- - b - - ^ b! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnDI>>b: (in category 'accessing') ----- - b: anObject - - ^b := anObject! Item was removed: - VMStructType subclass: #ThreadedFFIX64SixteenByteReturnID - instanceVariableNames: 'a b' - classVariableNames: '' - poolDictionaries: '' - category: 'VMMaker-Plugins-FFI'! - - !ThreadedFFIX64SixteenByteReturnID commentStamp: 'nice 1/25/2020 17:45' prior: 0! - A ThreadedFFIX64SixteenByteReturnID is a stub for returning a struct by value through 1 eight-byte int register and 1 eight-byte float register - That is (RAX XMM0) on X64. - - Instance Variables - a: <Object> - b: <Object> - - a - - stub for first eighbyte - - b - - stub for second eighbyte - ! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- - instVarNamesAndTypesForTranslationDo: aBinaryBlock - "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." - - aBinaryBlock value: 'a' value: #sqInt. - aBinaryBlock value: 'b' value: #double.! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID class>>structTypeName (in category 'translation') ----- - structTypeName - ^'SixteenByteReturnID'! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID>>a (in category 'accessing') ----- - a - - ^ a! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID>>a: (in category 'accessing') ----- - a: anObject - - ^a := anObject! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID>>b (in category 'accessing') ----- - b - - ^ b! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnID>>b: (in category 'accessing') ----- - b: anObject - - ^b := anObject! Item was removed: - VMStructType subclass: #ThreadedFFIX64SixteenByteReturnII - instanceVariableNames: 'a b' - classVariableNames: '' - poolDictionaries: '' - category: 'VMMaker-Plugins-FFI'! - - !ThreadedFFIX64SixteenByteReturnII commentStamp: 'nice 1/25/2020 17:44' prior: 0! - A ThreadedFFIX64SixteenByteReturnII is a stub for returning a struct by value through 2 eight-byte int registers - That is (RAX RDX) on X64. - - Instance Variables - a: <Object> - b: <Object> - - a - - stub for first eighbyte - - b - - stub for second eighbyte - ! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII class>>instVarNamesAndTypesForTranslationDo: (in category 'translation') ----- - instVarNamesAndTypesForTranslationDo: aBinaryBlock - "enumerate aBinaryBlock with the names and C type strings for the inst vars to include in a BlockStart struct." - - aBinaryBlock value: 'a' value: #sqInt. - aBinaryBlock value: 'b' value: #sqInt.! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII class>>structTypeName (in category 'translation') ----- - structTypeName - ^'SixteenByteReturnII'! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII>>a (in category 'accessing') ----- - a - - ^ a! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII>>a: (in category 'accessing') ----- - a: anObject - - ^a := anObject! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII>>b (in category 'accessing') ----- - b - - ^ b! Item was removed: - ----- Method: ThreadedFFIX64SixteenByteReturnII>>b: (in category 'accessing') ----- - b: anObject - - ^b := anObject! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin class>>ancilliaryClasses (in category 'translation') ----- ancilliaryClasses ^super ancilliaryClasses, + { ThreadedFFI64Bit16ByteReturnDD. + ThreadedFFI64Bit16ByteReturnDI. + ThreadedFFI64Bit16ByteReturnID. + ThreadedFFI64Bit16ByteReturnII }! - { ThreadedFFIX64SixteenByteReturnDD. - ThreadedFFIX64SixteenByteReturnDI. - ThreadedFFIX64SixteenByteReturnID. - ThreadedFFIX64SixteenByteReturnII }!

1 0

VM Maker: VMMaker.oscog-eem.3155.mcz
by commits＠source.squeak.org 16 Feb '22

16 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3155.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3155 Author: eem Time: 15 February 2022, 6:05:12.864638 pm UUID: fd91ad7e-0787-428f-80f8-2a85e5a25026 Ancestors: VMMaker.oscog-eem.3154 CoInterpreter: Fix issues with the PrimCallXXX flags. PrimCallIsInternalPrim wasn't initialized!! PrimCallIsExternalCall isn't used. PrimCallIsInternalPrim should be set on all numbered primitives except FFI & named primitive primitives. =============== Diff against VMMaker.oscog-eem.3154 =============== Item was changed: ----- Method: CoInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. COGVM := true. MinBackwardJumpCountForCompile := 40. MaxNumArgs := 15. PrimCallOnSmalltalkStack := 1. "Speed up simple external prims by avoiding stack switch" PrimCallOnSmalltalkStackAlign2x := 2. "Align stack to a 2 x word size boundary, e.g. for MMX instructions etc" + PrimCallNeedsNewMethod := 4. + PrimCallMayEndureCodeCompaction := 8. + PrimCallCollectsProfileSamples := 16. + PrimCallIsInternalPrim := 32. - PrimCallIsExternalCall := 4. - PrimCallNeedsNewMethod := 8. - PrimCallMayEndureCodeCompaction := 16. - PrimCallCollectsProfileSamples := 32. "Flags for use in primitiveMetadata: in external primitives, overlap with the PrimCallXXX flags above" FastCPrimitiveFlag := 1. "a.k.a. PrimCallOnSmalltalkStack" FastCPrimitiveAlignForFloatsFlag := 2. "a.k.a. PrimCallOnSmalltalkStackAlign2x" "And to shift away the flags, to compute the accessor depth, use... c.f. NullSpurMetadata in sq.h" SpurPrimitiveAccessorDepthShift := 8. SpurPrimitiveFlagsMask := 1 << SpurPrimitiveAccessorDepthShift - 1. "the primitive trace log; a record of the last 256 named/external primitives or significant events invoked." PrimTraceLogSize := 256. "Room for 256 selectors. Must be 256 because we use a byte to hold the index" TraceBufferSize := 256 * 3. "Room for 256 events" TraceContextSwitch := self objectMemoryClass basicNew integerObjectOf: 1. TraceBlockActivation := self objectMemoryClass basicNew integerObjectOf: 2. TraceBlockCreation := self objectMemoryClass basicNew integerObjectOf: 3. TraceIncrementalGC := self objectMemoryClass basicNew integerObjectOf: 4. TraceFullGC := self objectMemoryClass basicNew integerObjectOf: 5. TraceCodeCompaction := self objectMemoryClass basicNew integerObjectOf: 6. TraceOwnVM := self objectMemoryClass basicNew integerObjectOf: 7. TraceDisownVM := self objectMemoryClass basicNew integerObjectOf: 8. TraceThreadSwitch := self objectMemoryClass basicNew integerObjectOf: 9. TracePreemptDisowningThread := self objectMemoryClass basicNew integerObjectOf: 10. TraceVMCallback := self objectMemoryClass basicNew integerObjectOf: 11. TraceVMCallbackReturn := self objectMemoryClass basicNew integerObjectOf: 12. TraceStackOverflow := self objectMemoryClass basicNew integerObjectOf: 13. TracePrimitiveFailure := self objectMemoryClass basicNew integerObjectOf: 14. TracePrimitiveRetry := self objectMemoryClass basicNew integerObjectOf: 15. TraceIsFromMachineCode := 1. TraceIsFromInterpreter := 2. CSCallbackEnter := 3. CSCallbackLeave := 4. CSEnterCriticalSection := 5. CSExitCriticalSection := 6. CSResume := 7. CSSignal := 8. CSSuspend := 9. CSWait := 10. CSYield := 11. CSCheckEvents := 12. CSThreadSchedulingLoop := 13. CSOwnVM := 14. CSThreadBind := 15. CSSwitchIfNeccessary := 16. TraceSources := CArrayAccessor on: #('?' 'm' 'i' 'callbackEnter' 'callbackLeave' 'enterCritical' 'exitCritical' 'resume' 'signal' 'suspend' 'wait' 'yield' 'eventcheck' 'threadsched' 'ownVM' 'bindToThread' 'switchIfNecessary'). "this is simulation only" RumpCStackSize := 4096! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForV3:numArgs: (in category 'cog jit support') ----- primitivePropertyFlagsForV3: primIndex numArgs: numArgs <inline: true> "Answer any special requirements of the given primitive" | baseFlags | baseFlags := profileSemaphore ~= objectMemory nilObject ifTrue: [PrimCallNeedsNewMethod + PrimCallCollectsProfileSamples] ifFalse: [0]. self cppIf: #LRPCheck ifTrue: [longRunningPrimitiveCheckSemaphore ifNotNil: [baseFlags := baseFlags bitOr: PrimCallNeedsNewMethod]]. + ((self isCalloutPrimitiveIndex: primIndex) + or: [self isCodeCompactingPrimitiveIndex: primIndex]) ifTrue: - (self isCalloutPrimitiveIndex: primIndex) ifTrue: "For callbacks & module unloading" - [^baseFlags bitOr: PrimCallNeedsNewMethod + PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall]. - (self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: [^baseFlags bitOr: PrimCallNeedsNewMethod + PrimCallMayEndureCodeCompaction]. ((self isPerformPrimitive: primIndex) or: [self isMetaPrimitiveIndex: primIndex]) ifTrue: [^baseFlags bitOr: PrimCallNeedsNewMethod]. ^baseFlags! Item was changed: SharedPool subclass: #CogMethodConstants instanceVariableNames: '' + classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallIsInternalPrim PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallOnSmalltalkStack PrimCallOnSmalltalkStackAlign2x ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' - classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallIsExternalCall PrimCallIsInternalPrim PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod PrimCallOnSmalltalkStack PrimCallOnSmalltalkStackAlign2x ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' poolDictionaries: '' category: 'VMMaker-JIT'! Item was changed: ----- Method: StackInterpreter class>>primitiveMetadataTableUsing: (in category 'constants') ----- primitiveMetadataTableUsing: aCCodeGenerator + | slave | + slave := self basicNew. + ^self primitiveTable collectWithIndex: + [:thing :index| | primitiveIndex implementingClass tMethod | + primitiveIndex := index - 1. - ^self primitiveTable collect: - [:thing| | implementingClass tMethod | (thing isInteger "quick prims, 0 for fast primitve fail" or: [thing == #primitiveFail or: [(implementingClass := self primitivesClass whichClassIncludesSelector: thing) isNil]]) ifTrue: [-1 << SpurPrimitiveAccessorDepthShift] ifFalse: [tMethod := (aCCodeGenerator methodNamed: thing) ifNil: [aCCodeGenerator compileToTMethodSelector: thing in: implementingClass]. (aCCodeGenerator accessorDepthForMethod: tMethod) << SpurPrimitiveAccessorDepthShift + + (self metadataFlagsForPrimitive: tMethod) + + ((slave isCalloutPrimitiveIndex: primitiveIndex) ifTrue: [0] ifFalse: [PrimCallIsInternalPrim])]]! - + (self metadataFlagsForPrimitive: tMethod)]]!

1 0

sqUnixFileDialog.c has an include problem.
by Bruce O'Neel 13 Feb '22

13 Feb '22

Hi, sqUnixFileDialog.c is now added as an internal plugin, and, that triggers an include file problem. I *think* that it is only on unix because of the file name. This patch works, but, alas, I can only test on linuxes of various sorts so think of it as a proposed patch. Clearly remove the BEO mouse droppings before you apply it. I just wanted to keep things clear in my head what I was doing. Thanks. bruce diff --git a/platforms/unix/plugins/FileDialogPlugin/sqUnixFileDialog.c b/platforms/unix/plugins/FileDialogPlugin/sqUnixFileDialog.c index 16fae9b37..d973b0b52 100644 --- a/platforms/unix/plugins/FileDialogPlugin/sqUnixFileDialog.c +++ b/platforms/unix/plugins/FileDialogPlugin/sqUnixFileDialog.c @@ -20,6 +20,9 @@ * * This is a shell that only implements fileDialogGetLocation */ + +/* BEO Old + #include <stdlib.h> #include <stdio.h> #include <sys/stat.h> @@ -28,6 +31,21 @@ #include "sqConfig.h" #include "sqPlatformSpecific.h" #include "FileDialogPlugin.h" + */ + +/* BEO New */ + +#include "sq.h" +#include "sqVirtualMachine.h" +#include "FileDialogPlugin.h" +#include "sqUnixCharConv.h" + + +#include <stdlib.h> +#include <stdio.h> +#include <sys/stat.h> + +/* BEO done */ extern struct VirtualMachine *interpreterProxy; /* signalSemaphoreWithIndex */

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2022