Vm-dev February 2022

vm-dev@lists.squeakfoundation.org

11 participants
83 discussions

buildspurtrunkvmmaker64image.sh usage
by Bernhard Pieber 21 Feb '22

21 Feb '22

Hi All, I wanted to build myself a VM Maker image. IIUC, image/buildspurtrunkvmmaker64image.sh is the way to go. Here is what I get: bernhard@MacBookPro16 image % ./buildspurtrunkvmmaker64image.sh checking for latest 64-bit VM on bintray... cannot find latest release on https://bintray.com/opensmalltalk/notifications If you've built your own VM you can substitute that using the -vm myvm argument to this script. I guess the getGoodSpurVM.sh and getGoodSpur64VM.sh need to be updated to fetch the VMs from https://github.com/OpenSmalltalk/opensmalltalk-vm/releases. Cheers, Bernhard

2 3

[OpenSmalltalk/opensmalltalk-vm] squeak.cog.spur_linux32ARMv6_202003021730 ---- seg fault on Cuis image (#597)
by Dr. Nicola Mingotti 20 Feb '22

20 Feb '22

Hi guys, i report you that according to my latest tests with Cuis on a BeagleBone Black the VM in the title is not running. But the latest-build does run ! bye ================= output ================================== root@beaglebone:~/cuis-project# ./sqcogspurlinuxhtRPi/squeak Cuis-Smalltalk-Dev/Cuis5.0-4834-32.image Segmentation fault Wed Sep 15 15:55:11 2021 /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 09:42:45 UTC 2020 gcc 4.9.2 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-97835d24-79f4-41d1-b7e9-c81bd8bf7149 4.4.0-104-generic #127~14.04.1-Ubuntu SMP Mon Dec 11 12:44:15 UTC 2017 armv7l GNU/Linux plugin path: ./sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730 [default: /root/cuis-project/sqcogspurlinuxhtRPi/lib/squeak/5.0-202003021730/] C stack backtrace & registers: r0 0x00000000 r1 0x03004c70 r2 0x03004d30 r3 0x03004c70 r4 0x00000000 r5 0xbe952e90 r6 0x03012d40 r7 0x00224250 r8 0x00000000 r9 0x00000001 r10 0x00216288 fp 0x0021a278 ip 0x000005ec sp 0xbe950ea8 lr 0x00069290 pc 0x0004fe44 *[0x0] /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x4e)[0xb6d2a293] Smalltalk stack dump: 0xbe952e64 M SystemDictionary(Set)>findElementOrNil: 0x30cc098: a(n) SystemDictionary 0xbe952e90 I SystemDictionary(Dictionary)>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952ebc I SystemDictionary>at:put: 0x30cc098: a(n) SystemDictionary 0xbe952f08 I [] in SystemDictionary>snapshot:andQuit:embedded:clearAllClassState: 0x30cc098: a(n) SystemDictionary 0x3a79bf0 s [] in BlockClosure>newProcess Most recent primitives maxIdentityHash identityHash at: at: stack page bytes 4096 available headroom 2788 minimum unused headroom 3776 (Segmentation fault) Aborted root@beaglebone:~/cuis-project# ========================================== -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/597

2 2

[OpenSmalltalk/opensmalltalk-vm] 136c2f: CogVM source as per VMMaker.oscog-eem.3163
by Eliot Miranda 20 Feb '22

20 Feb '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 136c2f9b2f333b4adfaab8923177a4689f8d5519 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/136c2f9b2f333b4adf… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-02-19 (Sat, 19 Feb 2022) Changed paths: M building/macos64ARMv8/bochsx64/conf.COG M building/macos64ARMv8/bochsx64/conf.COG.dbg M building/macos64ARMv8/bochsx86/conf.COG M building/macos64ARMv8/bochsx86/conf.COG.dbg M building/macos64ARMv8/gdbarm32/conf.COG M building/macos64ARMv8/gdbarm64/conf.COG M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3163 Spur CoInterpreter: use primitiveMetadataTable in CoInterpreter and primitiveAccessorDepthTable in StackInterpreter. There's no need to waste the space in the StackInterpreter and its easier to read the depths from the depth table in interp.c than decode the depth+metadata table in cointerp.c. Slang: ...and fix the regression in cogit.h's contents. MacOS ARMv8 builds, get the Bochs simulator support libs to build. The ARM gdb ones nearly do, but something (a subconfigure?) still fails.

1 0

VM Maker: VMMaker.oscog-eem.3163.mcz
by commits＠source.squeak.org 20 Feb '22

20 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3163.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3163 Author: eem Time: 19 February 2022, 6:31:23.548992 pm UUID: 6e25cea8-6b04-488b-9c4a-4132b2f31bd9 Ancestors: VMMaker.oscog-eem.3162 ...and fix regression in type of StackInterpreter's primitiveAccessorDepthTable; it must be signed char. =============== Diff against VMMaker.oscog-eem.3162 =============== Item was changed: ----- Method: StackInterpreter class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator | vmClass | self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" vmClass := aCCodeGenerator vmClass. "Generate primitiveTable etc based on vmClass, not just StackInterpreter" aCCodeGenerator addHeaderFile: '<stdio.h> /* for printf */'; addHeaderFile: '<stdlib.h> /* for e.g. alloca */'; addHeaderFile: '<setjmp.h>'; addHeaderFile: '<wchar.h> /* for wint_t */'; addHeaderFile: '"vmCallback.h"'; addHeaderFile: '"sqMemoryFence.h"'; addHeaderFile: '"sqImageFileAccess.h"'; addHeaderFile: '"sqSetjmpShim.h"'; addHeaderFile: '"dispdbg.h"'. LowcodeVM ifTrue: [aCCodeGenerator addHeaderFile: '"sqLowcodeFFI.h"']. vmClass declareInterpreterVersionIn: aCCodeGenerator defaultName: 'Stack'. aCCodeGenerator var: #interpreterProxy type: #'struct VirtualMachine*'. aCCodeGenerator declareVar: #sendTrace type: 'volatile int'; declareVar: #byteCount type: #usqLong. "see dispdbg.h" "These need to be pointers or unsigned." self declareC: #(instructionPointer method newMethod) as: #usqInt in: aCCodeGenerator. "These are all pointers; char * because Slang has no support for C pointer arithmetic." self declareC: #(localIP localSP localFP stackPointer framePointer stackLimit breakSelector) as: #'char *' in: aCCodeGenerator. aCCodeGenerator var: #breakSelectorLength declareC: 'sqInt breakSelectorLength = MinSmallInteger'. self declareC: #(stackPage overflowedPage) as: #'StackPage *' in: aCCodeGenerator. aCCodeGenerator var: #transcript type: #'FILE *'. aCCodeGenerator removeVariable: 'stackPages'. "this is an implicit receiver in the translated code." "This defines bytecodeSetSelector as 0 if MULTIPLEBYTECODESETS is not defined, for the benefit of the interpreter on slow machines." aCCodeGenerator addConstantForBinding: (self bindingOf: #MULTIPLEBYTECODESETS). MULTIPLEBYTECODESETS == false ifTrue: [aCCodeGenerator removeVariable: 'bytecodeSetSelector']. BytecodeSetHasExtensions == false ifTrue: [aCCodeGenerator removeVariable: 'extA'; removeVariable: 'extB']. aCCodeGenerator var: #methodCache declareC: 'sqIntptr_t methodCache[MethodCacheSize + 1 /* ', (MethodCacheSize + 1) printString, ' */]'. NewspeakVM ifTrue: [aCCodeGenerator var: #nsMethodCache declareC: 'sqIntptr_t nsMethodCache[NSMethodCacheSize + 1 /* ', (NSMethodCacheSize + 1) printString, ' */]'] ifFalse: [aCCodeGenerator removeVariable: #nsMethodCache; removeVariable: 'localAbsentReceiver'; removeVariable: 'localAbsentReceiverOrZero']. AtCacheTotalSize isInteger ifTrue: [aCCodeGenerator var: #atCache declareC: 'sqInt atCache[AtCacheTotalSize + 1 /* ', (AtCacheTotalSize + 1) printString, ' */]']. aCCodeGenerator var: #primitiveTable declareC: 'void (*primitiveTable[MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */])(void) = ', vmClass primitiveTableString. vmClass primitiveTable do: [:symbolOrNot| (symbolOrNot isSymbol and: [symbolOrNot ~~ #primitiveFail]) ifTrue: [(aCCodeGenerator methodNamed: symbolOrNot) ifNotNil: [:tMethod| tMethod returnType: #void]]]. vmClass objectMemoryClass hasSpurMemoryManagerAPI ifTrue: [aCCodeGenerator var: #primitiveAccessorDepthTable + type: 'signed char' - type: #char sizeString: 'MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */' array: (vmClass primitiveAccessorDepthTableUsing: aCCodeGenerator). aCCodeGenerator removeConstant: #PrimNumberInstVarAt; removeConstant: #PrimNumberPerform; removeConstant: # PrimNumberPerformWithArgs; removeConstant: #PrimNumberShallowCopy; removeConstant: #PrimNumberSlotAt; removeConstant: #PrimNumberFlushExternalPrimitives; removeConstant: #PrimNumberUnloadModule] ifFalse: [aCCodeGenerator removeVariable: #primitiveAccessorDepthTable; removeConstant: #PrimNumberVMParameter]. aCCodeGenerator var: #displayBits type: #'void *'; var: #primitiveCalloutPointer declareC: 'void *primitiveCalloutPointer = (void *)-1'. self declareC: #(displayWidth displayHeight displayDepth) as: #int in: aCCodeGenerator. aCCodeGenerator var: #primitiveFunctionPointer declareC: 'void (*primitiveFunctionPointer)()'; var: 'pcPreviousToFunction' declareC: 'sqInt (* const pcPreviousToFunction)(sqInt,sqInt) = ', (aCCodeGenerator cFunctionNameFor: PCPreviousToFunction); var: #externalPrimitiveTable declareC: 'void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* ', (MaxExternalPrimitiveTableSize + 1) printString, ' */])(void)'; var: #interruptCheckChain declareC: 'void (*interruptCheckChain)(void) = 0'; var: #showSurfaceFn declareC: 'int (*showSurfaceFn)(sqIntptr_t, int, int, int, int)'. self declareCAsUSqLong: #(nextPollUsecs nextWakeupUsecs "these are high-frequency enough that they're overflowing quite quickly on modern hardware" statProcessSwitch statIOProcessEvents statForceInterruptCheck statCheckForEvents statStackOverflow statStackPageDivorce statIdleUsecs) in: aCCodeGenerator. aCCodeGenerator var: #nextProfileTick type: #sqLong. aCCodeGenerator var: #reenterInterpreter type: 'jmp_buf'. LowcodeVM ifTrue: [aCCodeGenerator var: #lowcodeCalloutState type: #'sqLowcodeCalloutState*'. self declareC: #(nativeSP nativeStackPointer shadowCallStackPointer) as: #'char *' in: aCCodeGenerator] ifFalse: [#(lowcodeCalloutState nativeSP nativeStackPointer shadowCallStackPointer) do: [:var| aCCodeGenerator removeVariable: var]]. (self instVarNames select: [:ivn| ivn beginsWith: 'longRunningPrimitive']) do: [:lrpmVar| aCCodeGenerator var: lrpmVar declareC: '#if LRPCheck\', ((lrpmVar endsWith: 'Usecs') ifTrue: [#usqLong] ifFalse: [#sqInt]), ' ', lrpmVar, '\#endif']!

1 0

VM Maker: VMMaker.oscog-eem.3162.mcz
by commits＠source.squeak.org 20 Feb '22

20 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3162.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3162 Author: eem Time: 19 February 2022, 6:00:50.097188 pm UUID: 1c2eddce-e2ba-44a3-852a-8dc1efc56310 Ancestors: VMMaker.oscog-eem.3161 Slang: ...and fix the regression in cogit.h's contents using a hammer. =============== Diff against VMMaker.oscog-eem.3161 =============== Item was removed: - ----- Method: CCodeGenerator>>emitCAPIExportHeaderOn: (in category 'C code generator') ----- - emitCAPIExportHeaderOn: aStream - "Store prototype declarations for all API methods on the given stream." - | exportedAPIMethods usedConstants | - exportedAPIMethods := self sortMethods: (methods select: [:m| m isAPIMethod]). - exportedAPIMethods do: - [:m| - m static ifTrue: - [logger ensureCr; show: m selector, ' excluded from export API because it is static'; cr]]. - exportedAPIMethods := exportedAPIMethods reject: [:m| m static]. - self emitCFunctionPrototypes: exportedAPIMethods on: aStream. - self emitGlobalCVariablesOn: aStream. - usedConstants := self emitCMacros: exportedAPIMethods on: aStream. - (vmClass notNil and: [vmClass hasCogit]) ifTrue: - [usedConstants addAll: self commonSharedPoolVariableNames]. - self emitCConstants: usedConstants on: aStream! Item was added: + ----- Method: CCodeGenerator>>emitCAPIExportHeaderOn:includePoolDefines: (in category 'C code generator') ----- + emitCAPIExportHeaderOn: aStream includePoolDefines: includePoolDefines + "Store prototype declarations for all API methods on the given stream." + | exportedAPIMethods usedConstants | + exportedAPIMethods := self sortMethods: (methods select: [:m| m isAPIMethod]). + exportedAPIMethods do: + [:m| + m static ifTrue: + [logger ensureCr; show: m selector, ' excluded from export API because it is static'; cr]]. + exportedAPIMethods := exportedAPIMethods reject: [:m| m static]. + self emitCFunctionPrototypes: exportedAPIMethods on: aStream. + self emitGlobalCVariablesOn: aStream. + usedConstants := self emitCMacros: exportedAPIMethods on: aStream. + (vmClass notNil and: [vmClass hasCogit and: [includePoolDefines]]) ifTrue: + [usedConstants addAll: self commonSharedPoolVariableNames]. + self emitCConstants: usedConstants on: aStream! Item was removed: - ----- Method: CCodeGenerator>>storeAPIExportHeader:OnFile: (in category 'public') ----- - storeAPIExportHeader: headerName OnFile: fullHeaderPath - "Store C header code on the given file. Evaluate - aBlock with the stream to generate its contents." - - | header | - header := String streamContents: - [:s| - s nextPutAll: (self fileHeaderVersionStampForSourceClass: nil); cr. - self emitCAPIExportHeaderOn: s]. - (self needToGenerateHeader: headerName file: fullHeaderPath contents: header) ifTrue: - [self storeHeaderOnFile: fullHeaderPath contents: header]! Item was added: + ----- Method: CCodeGenerator>>storeAPIExportHeader:OnFile:includePoolDefines: (in category 'public') ----- + storeAPIExportHeader: headerName OnFile: fullHeaderPath includePoolDefines: includePoolDefines + "Store C header code on the given file. Evaluate + aBlock with the stream to generate its contents." + + | header | + header := String streamContents: + [:s| + s nextPutAll: (self fileHeaderVersionStampForSourceClass: nil); cr. + self emitCAPIExportHeaderOn: s includePoolDefines: includePoolDefines]. + (self needToGenerateHeader: headerName file: fullHeaderPath contents: header) ifTrue: + [self storeHeaderOnFile: fullHeaderPath contents: header]! Item was changed: ----- Method: VMMaker>>generateCogitFiles (in category 'generate sources') ----- generateCogitFiles "Translate the Smalltalk description of the virtual machine's JITs into C." | cogitClass cg | (cogitClass := self interpreterClass cogitClass) ifNil: [^nil]. self generateCogitIncludeFileFor: cogitClass. cogitClass translateableInstructionSubclassesAndInstalledOptionsDo: [:compilerClass| cg := self generateCogitFileFor: cogitClass]. cg vmClass additionalHeadersDo: [:headerName :headerContents| | filePath | filePath := self coreVMDirectory fullNameFor: headerName. (cg needToGenerateHeader: headerName file: filePath contents: headerContents) ifTrue: [cg storeHeaderOnFile: filePath contents: headerContents]]. cogitClass apiExportHeaderName ifNotNil: [cg storeAPIExportHeader: cogitClass apiExportHeaderName + OnFile: (self sourceFilePathFor: cogitClass apiExportHeaderName) + includePoolDefines: false]! - OnFile: (self sourceFilePathFor: cogitClass apiExportHeaderName)]! Item was changed: ----- Method: VMMaker>>generateInterpreterFile (in category 'generate sources') ----- generateInterpreterFile "Translate the Smalltalk description of the virtual machine into C. If 'self doInlining' is true, small method bodies are inlined to reduce procedure call overhead. On the PPC, this results in a factor of three speedup with only 30% increase in code size. Subclasses can use specialised versions of CCodeGenerator and interpreterClass." | cg vmHeaderContents | cg := [self buildCodeGeneratorForInterpreter] on: Notification do: [:ex| ex tag == #getVMMaker ifTrue: [ex resume: self] ifFalse: [(ex respondsTo: #rearmHandlerDuring:) ifTrue: [ex rearmHandlerDuring: [ex pass]] ifFalse: [ex pass]]]. self reinitializeWordSizeFrom: cg. self interpreterClass additionalHeadersDo: [:headerName :headerContents| | filePath | filePath := self coreVMDirectory fullNameFor: headerName. (cg needToGenerateHeader: headerName file: filePath contents: headerContents) ifTrue: [cg storeHeaderOnFile: filePath contents: headerContents]]. self needsToRegenerateInterpreterFile ifFalse: [^nil]. cg inferTypesForImplicitlyTypedVariablesAndMethods. self interpreterClass preGenerationHook: cg. vmHeaderContents := cg vmHeaderContentsWithBytesPerWord: self wordSize. (cg needToGenerateHeader: self interpreterHeaderName file: self interpreterHeaderPath contents: vmHeaderContents) ifTrue: [cg storeHeaderOnFile: self interpreterHeaderPath contents: vmHeaderContents]. cg storeCodeOnFile: (self sourceFilePathFor: self interpreterClass sourceFileName) doInlining: self doInlining. self interpreterClass apiExportHeaderName ifNotNil: [cg storeAPIExportHeader: self interpreterClass apiExportHeaderName + OnFile: (self sourceFilePathFor: self interpreterClass apiExportHeaderName) + includePoolDefines: true]. - OnFile: (self sourceFilePathFor: self interpreterClass apiExportHeaderName)]. (cg methodNamed: #interpret) ifNotNil: [self gnuifyInterpreterFile]. self maybeGenerateVariableOrderFiles: cg!

1 0

VM Maker: VMMaker.oscog-eem.3161.mcz
by commits＠source.squeak.org 20 Feb '22

20 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3161.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3161 Author: eem Time: 19 February 2022, 5:19:34.554129 pm UUID: 44c0ec9b-cfdf-48f0-8671-3b901756a959 Ancestors: VMMaker.oscog-eem.3160 Spur CoInterpreter: use primitiveMetadataTable in CoInterpreter and primitiveAccessorDepthTable in StackInterpreter. There's no need to waste the space in the StackInterpreter and its easier to read the depths from the depth table in interp.c than decode the depth+metadata table in cointerp.c. =============== Diff against VMMaker.oscog-eem.3160 =============== Item was changed: StackInterpreterPrimitives subclass: #CoInterpreter + instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase primitiveMetadataTable lastCoggableInterpretedBlockMethod deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile CFramePointer CStackPointer CReturnAddress primTracePluginName primCalloutIsExternal' - instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase lastCoggableInterpretedBlockMethod deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile CFramePointer CStackPointer CReturnAddress primTracePluginName primCalloutIsExternal' classVariableNames: 'CSCallbackEnter CSCallbackLeave CSCheckEvents CSEnterCriticalSection CSExitCriticalSection CSOwnVM CSResume CSSignal CSSuspend CSSwitchIfNeccessary CSThreadBind CSThreadSchedulingLoop CSWait CSYield HasBeenReturnedFromMCPC HasBeenReturnedFromMCPCOop MFMethodFlagFrameIsMarkedFlag MinBackwardJumpCountForCompile PrimTraceLogSize RumpCStackSize TraceBlockActivation TraceBlockCreation TraceBufferSize TraceCodeCompaction TraceContextSwitch TraceDisownVM TraceFullGC TraceIncrementalGC TraceIsFromInterpreter TraceIsFromMachineCode TraceOwnVM TracePreemptDisowningThread TracePrimitiveFailure TracePrimitiveRetry TraceSources TraceStackOverflow TraceThreadSwitch TraceVMCallback TraceVMCallbackReturn' poolDictionaries: 'CogMethodConstants VMStackFrameOffsets' category: 'VMMaker-JIT'! !CoInterpreter commentStamp: 'eem 3/31/2020 18:56' prior: 0! I am a variant of the StackInterpreter that can co-exist with the Cog JIT. I interpret unjitted methods, either because they have been found for the first time or because they are judged to be too big to JIT. See CogMethod class's comment for method interoperability. cogCodeSize - the current size of the machine code zone cogCompiledCodeCompactionCalledFor - a variable set when the machine code zone runs out of space, causing a machine code zone compaction at the next available opportunity cogMethodZone - the manager for the machine code zone (instance of CogMethodZone) cogit - the JIT (co-jit) (instance of SimpleStackBasedCogit, StackToRegisterMappoingCogit, etc) deferSmash - a flag causing deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) deferredSmash - a flag noting deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) desiredCogCodeSize - the desred size of the machine code zone, set at startup or via primitiveVMParameter to be written at snapshot time flagInterpretedMethods - true if methods that are interpreted shoudl have their flag bit set (used to identity methods that are interpreted because they're unjittable for some reason) gcMode - the variable holding the gcMode, used to inform the cogit of how to scan the machine code zone for oops on GC heapBase - the address in memory of the base of the objectMemory's heap, which is immediately above the machine code zone lastCoggableInterpretedBlockMethod - a variable used to invoke the cogit for a block mehtod being invoked repeatedly in the interpreter lastUncoggableInterpretedBlockMethod - a variable used to avoid invoking the cogit for an unjittable method encountered on block evaluation maxLiteralCountForCompile - the variable controlling which methods to jit. methods with a literal count above this value will not be jitted (on the grounds that large methods are typically used for initialization, and take up a lot of space in the code zone) minBackwardJumpCountForCompile - the variable controlling when to attempt to jit a method being interpreted. If as many backward jumps as this occur, the current method will be jitted primTraceLog - a small array implementing a crcular buffer logging the last N primitive invocations, GCs, code compactions, etc used for crash reporting primTraceLogIndex - the index into primTraceLog of the next entry reenterInterpreter - the jmpbuf used to jmp back into the interpreter when transitioning from machine code to the interpreter statCodeCompactionCount - the count of machine code zone compactions statCodeCompactionUsecs - the total microseconds spent in machine code zone compactions traceLog - a log of various events, used in debugging traceLogIndex - the index into traceLog of the next entry traceSources - the names associated with the codes of events in traceLog CFramePointer - if in use, the value of the C frame pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CStackPointer - the value of the C stack pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CReturnAddress - the return address for the function call which invoked the interpreter at start-up. Using this as teh return address when entering the interpreter via ceInvokeInterpeter maintains a valid stack. Since this is effevtively a constant it does not need to be saved and restored once set.! Item was changed: ----- Method: CoInterpreter class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator "Override to avoid repeating StackInterpreter's declarations and add our own extensions" self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" aCCodeGenerator addHeaderFile:'"sqCogStackAlignment.h"'; addHeaderFile:'"cogmethod.h"'. NewspeakVM ifTrue: [aCCodeGenerator addHeaderFile:'"nssendcache.h"']. aCCodeGenerator addHeaderFile: (aCCodeGenerator vmClass isThreadedVM ifTrue: ['"cointerpmt.h"'] ifFalse: ['"cointerp.h"']); addHeaderFile:'"cogit.h"'. aCCodeGenerator vmClass declareInterpreterVersionIn: aCCodeGenerator defaultName: aCCodeGenerator interpreterVersion. aCCodeGenerator var: #cogCodeSize type: #usqInt; var: #heapBase type: #usqInt; var: #statCodeCompactionUsecs type: #usqLong; var: #maxLiteralCountForCompile declareC: 'sqInt maxLiteralCountForCompile = MaxLiteralCountForCompile /* ', MaxLiteralCountForCompile printString, ' */'; var: #minBackwardJumpCountForCompile declareC: 'sqInt minBackwardJumpCountForCompile = MinBackwardJumpCountForCompile /* ', MinBackwardJumpCountForCompile printString, ' */'. aCCodeGenerator removeVariable: 'atCache'; "Way too much trouble than it's worth in the Cog VM" removeVariable: 'reenterInterpreter'. "We can use the JIT and CFrame/StrackPointer for a lighter-weight solution." + aCCodeGenerator removeVariable: #primitiveAccessorDepthTable. + aCCodeGenerator vmClass objectMemoryClass hasSpurMemoryManagerAPI + ifTrue: + [aCCodeGenerator + var: #primitiveMetadataTable + type: 'signed short' + sizeString: 'MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */' + array: (aCCodeGenerator vmClass primitiveMetadataTableUsing: aCCodeGenerator)] + ifFalse: + [aCCodeGenerator removeVariable: #primitiveMetadataTable]. aCCodeGenerator var: #primTraceLogIndex type: #'unsigned char'; var: #primTraceLog declareC: 'sqInt primTraceLog[256]'; var: #traceLog declareC: 'sqInt traceLog[TraceBufferSize /* ', TraceBufferSize printString, ' */]'; var: 'primTracePluginName' type: #'char *'; var: #traceSources type: #'char *' array: TraceSources. aCCodeGenerator var: #CFramePointer type: #'volatile usqIntptr_t'; var: #CStackPointer type: #'volatile usqIntptr_t'; var: #CReturnAddress type: #'volatile usqIntptr_t'! Item was added: + ----- Method: CoInterpreter class>>primitiveMetadataTableUsing: (in category 'constants') ----- + primitiveMetadataTableUsing: aCCodeGenerator + ^self primitiveTable collect: + [:thing| | implementingClass tMethod | + (thing isInteger "quick prims, 0 for fast primitve fail" + or: [thing == #primitiveFail + or: [(implementingClass := self primitivesClass whichClassIncludesSelector: thing) isNil]]) + ifTrue: [-1 << SpurPrimitiveAccessorDepthShift] + ifFalse: + [tMethod := (aCCodeGenerator methodNamed: thing) ifNil: + [aCCodeGenerator compileToTMethodSelector: thing in: implementingClass]. + (aCCodeGenerator accessorDepthForMethod: tMethod) << SpurPrimitiveAccessorDepthShift + + (self metadataFlagsForPrimitive: tMethod)]]! Item was added: + ----- Method: CoInterpreter>>accessorDepthForPrimitiveIndex: (in category 'cog jit support') ----- + accessorDepthForPrimitiveIndex: primIndex + <api> + <option: #SpurObjectMemory> + ^(primitiveMetadataTable at: primIndex) >>> SpurPrimitiveAccessorDepthShift! Item was added: + ----- Method: CoInterpreter>>computeAccessorDepthsForInterpreterPrimitives (in category 'primitive support') ----- + computeAccessorDepthsForInterpreterPrimitives + <doNotGenerate> + | cg | + cg := self codeGeneratorToComputeAccessorDepth. + primitiveMetadataTable ifNil: + [primitiveMetadataTable := Array new: primitiveTable size withAll: (-1 bitShift: SpurPrimitiveAccessorDepthShift)]. + primitiveTable withIndexDo: + [:prim :index| | depthAndFlags | + prim isSymbol ifTrue: + [depthAndFlags := self metadataFlagsFor: prim using: cg. + self assert: depthAndFlags isInteger. + primitiveMetadataTable at: index - 1 put: depthAndFlags]]. + ^cg! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator | vmClass | self class == thisContext methodClass ifFalse: [^self]. "Don't duplicate decls in subclasses" vmClass := aCCodeGenerator vmClass. "Generate primitiveTable etc based on vmClass, not just StackInterpreter" aCCodeGenerator addHeaderFile: '<stdio.h> /* for printf */'; addHeaderFile: '<stdlib.h> /* for e.g. alloca */'; addHeaderFile: '<setjmp.h>'; addHeaderFile: '<wchar.h> /* for wint_t */'; addHeaderFile: '"vmCallback.h"'; addHeaderFile: '"sqMemoryFence.h"'; addHeaderFile: '"sqImageFileAccess.h"'; addHeaderFile: '"sqSetjmpShim.h"'; addHeaderFile: '"dispdbg.h"'. LowcodeVM ifTrue: [aCCodeGenerator addHeaderFile: '"sqLowcodeFFI.h"']. vmClass declareInterpreterVersionIn: aCCodeGenerator defaultName: 'Stack'. aCCodeGenerator var: #interpreterProxy type: #'struct VirtualMachine*'. aCCodeGenerator declareVar: #sendTrace type: 'volatile int'; declareVar: #byteCount type: #usqLong. "see dispdbg.h" "These need to be pointers or unsigned." self declareC: #(instructionPointer method newMethod) as: #usqInt in: aCCodeGenerator. "These are all pointers; char * because Slang has no support for C pointer arithmetic." self declareC: #(localIP localSP localFP stackPointer framePointer stackLimit breakSelector) as: #'char *' in: aCCodeGenerator. aCCodeGenerator var: #breakSelectorLength declareC: 'sqInt breakSelectorLength = MinSmallInteger'. self declareC: #(stackPage overflowedPage) as: #'StackPage *' in: aCCodeGenerator. aCCodeGenerator var: #transcript type: #'FILE *'. aCCodeGenerator removeVariable: 'stackPages'. "this is an implicit receiver in the translated code." "This defines bytecodeSetSelector as 0 if MULTIPLEBYTECODESETS is not defined, for the benefit of the interpreter on slow machines." aCCodeGenerator addConstantForBinding: (self bindingOf: #MULTIPLEBYTECODESETS). MULTIPLEBYTECODESETS == false ifTrue: [aCCodeGenerator removeVariable: 'bytecodeSetSelector']. BytecodeSetHasExtensions == false ifTrue: [aCCodeGenerator removeVariable: 'extA'; removeVariable: 'extB']. aCCodeGenerator var: #methodCache declareC: 'sqIntptr_t methodCache[MethodCacheSize + 1 /* ', (MethodCacheSize + 1) printString, ' */]'. NewspeakVM ifTrue: [aCCodeGenerator var: #nsMethodCache declareC: 'sqIntptr_t nsMethodCache[NSMethodCacheSize + 1 /* ', (NSMethodCacheSize + 1) printString, ' */]'] ifFalse: [aCCodeGenerator removeVariable: #nsMethodCache; removeVariable: 'localAbsentReceiver'; removeVariable: 'localAbsentReceiverOrZero']. AtCacheTotalSize isInteger ifTrue: [aCCodeGenerator var: #atCache declareC: 'sqInt atCache[AtCacheTotalSize + 1 /* ', (AtCacheTotalSize + 1) printString, ' */]']. aCCodeGenerator var: #primitiveTable declareC: 'void (*primitiveTable[MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */])(void) = ', vmClass primitiveTableString. vmClass primitiveTable do: [:symbolOrNot| (symbolOrNot isSymbol and: [symbolOrNot ~~ #primitiveFail]) ifTrue: [(aCCodeGenerator methodNamed: symbolOrNot) ifNotNil: [:tMethod| tMethod returnType: #void]]]. vmClass objectMemoryClass hasSpurMemoryManagerAPI ifTrue: [aCCodeGenerator + var: #primitiveAccessorDepthTable + type: #char - var: #primitiveMetadataTable - type: 'signed short' sizeString: 'MaxPrimitiveIndex + 2 /* ', (MaxPrimitiveIndex + 2) printString, ' */' + array: (vmClass primitiveAccessorDepthTableUsing: aCCodeGenerator). - array: (vmClass primitiveMetadataTableUsing: aCCodeGenerator). aCCodeGenerator removeConstant: #PrimNumberInstVarAt; removeConstant: #PrimNumberPerform; removeConstant: # PrimNumberPerformWithArgs; removeConstant: #PrimNumberShallowCopy; removeConstant: #PrimNumberSlotAt; removeConstant: #PrimNumberFlushExternalPrimitives; removeConstant: #PrimNumberUnloadModule] ifFalse: [aCCodeGenerator + removeVariable: #primitiveAccessorDepthTable; - removeVariable: #primitiveMetadataTable; removeConstant: #PrimNumberVMParameter]. aCCodeGenerator var: #displayBits type: #'void *'; var: #primitiveCalloutPointer declareC: 'void *primitiveCalloutPointer = (void *)-1'. self declareC: #(displayWidth displayHeight displayDepth) as: #int in: aCCodeGenerator. aCCodeGenerator var: #primitiveFunctionPointer declareC: 'void (*primitiveFunctionPointer)()'; var: 'pcPreviousToFunction' declareC: 'sqInt (* const pcPreviousToFunction)(sqInt,sqInt) = ', (aCCodeGenerator cFunctionNameFor: PCPreviousToFunction); var: #externalPrimitiveTable declareC: 'void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* ', (MaxExternalPrimitiveTableSize + 1) printString, ' */])(void)'; var: #interruptCheckChain declareC: 'void (*interruptCheckChain)(void) = 0'; var: #showSurfaceFn declareC: 'int (*showSurfaceFn)(sqIntptr_t, int, int, int, int)'. self declareCAsUSqLong: #(nextPollUsecs nextWakeupUsecs "these are high-frequency enough that they're overflowing quite quickly on modern hardware" statProcessSwitch statIOProcessEvents statForceInterruptCheck statCheckForEvents statStackOverflow statStackPageDivorce statIdleUsecs) in: aCCodeGenerator. aCCodeGenerator var: #nextProfileTick type: #sqLong. aCCodeGenerator var: #reenterInterpreter type: 'jmp_buf'. LowcodeVM ifTrue: [aCCodeGenerator var: #lowcodeCalloutState type: #'sqLowcodeCalloutState*'. self declareC: #(nativeSP nativeStackPointer shadowCallStackPointer) as: #'char *' in: aCCodeGenerator] ifFalse: [#(lowcodeCalloutState nativeSP nativeStackPointer shadowCallStackPointer) do: [:var| aCCodeGenerator removeVariable: var]]. (self instVarNames select: [:ivn| ivn beginsWith: 'longRunningPrimitive']) do: [:lrpmVar| aCCodeGenerator var: lrpmVar declareC: '#if LRPCheck\', ((lrpmVar endsWith: 'Usecs') ifTrue: [#usqLong] ifFalse: [#sqInt]), ' ', lrpmVar, '\#endif']! Item was added: + ----- Method: StackInterpreter class>>primitiveAccessorDepthTableUsing: (in category 'constants') ----- + primitiveAccessorDepthTableUsing: aCCodeGenerator + ^self primitiveTable collect: + [:thing| | implementingClass | + (thing isInteger "quick prims, 0 for fast primitve fail" + or: [thing == #primitiveFail + or: [(implementingClass := self primitivesClass whichClassIncludesSelector: thing) isNil]]) + ifTrue: [-1] + ifFalse: + [aCCodeGenerator accessorDepthForMethod: + ((aCCodeGenerator methodNamed: thing) ifNil: + [aCCodeGenerator compileToTMethodSelector: thing in: implementingClass])]]! Item was removed: - ----- Method: StackInterpreter class>>primitiveMetadataDepthTable (in category 'constants') ----- - primitiveMetadataDepthTable - | cg | - cg := CCodeGenerator new. - cg vmClass: StackInterpreter. - ^self primitiveMetadataTableUsing: cg! Item was removed: - ----- Method: StackInterpreter class>>primitiveMetadataTableUsing: (in category 'constants') ----- - primitiveMetadataTableUsing: aCCodeGenerator - ^self primitiveTable collect: - [:thing| | implementingClass tMethod | - (thing isInteger "quick prims, 0 for fast primitve fail" - or: [thing == #primitiveFail - or: [(implementingClass := self primitivesClass whichClassIncludesSelector: thing) isNil]]) - ifTrue: [-1 << SpurPrimitiveAccessorDepthShift] - ifFalse: - [tMethod := (aCCodeGenerator methodNamed: thing) ifNil: - [aCCodeGenerator compileToTMethodSelector: thing in: implementingClass]. - (aCCodeGenerator accessorDepthForMethod: tMethod) << SpurPrimitiveAccessorDepthShift - + (self metadataFlagsForPrimitive: tMethod)]]! Item was changed: ----- Method: StackInterpreter>>accessorDepthForPrimitiveIndex: (in category 'cog jit support') ----- accessorDepthForPrimitiveIndex: primIndex - <api> <option: #SpurObjectMemory> + <inline: #always> + ^primitiveAccessorDepthTable at: primIndex! - ^(primitiveMetadataTable at: primIndex) >>> SpurPrimitiveAccessorDepthShift! Item was changed: ----- Method: StackInterpreter>>computeAccessorDepthsForInterpreterPrimitives (in category 'primitive support') ----- computeAccessorDepthsForInterpreterPrimitives <doNotGenerate> | cg | cg := self codeGeneratorToComputeAccessorDepth. + primitiveAccessorDepthTable ifNil: + [primitiveAccessorDepthTable := Array new: primitiveTable size withAll: -1]. - primitiveMetadataTable ifNil: - [primitiveMetadataTable := Array new: primitiveTable size withAll: (-1 bitShift: SpurPrimitiveAccessorDepthShift)]. primitiveTable withIndexDo: + [:prim :index| - [:prim :index| | depthAndFlags | prim isSymbol ifTrue: + [primitiveAccessorDepthTable at: index - 1 put: ((cg accessorDepthForSelector: prim) ifNil: [0])]]. - [depthAndFlags := self metadataFlagsFor: prim using: cg. - self assert: depthAndFlags isInteger. - primitiveMetadataTable at: index - 1 put: depthAndFlags]]. ^cg! Item was changed: ----- Method: StackInterpreterSimulator>>initializePluginEntries (in category 'plugin support') ----- initializePluginEntries mappedPluginEntries := OrderedCollection new. objectMemory hasSpurMemoryManagerAPI ifTrue: + [primitiveAccessorDepthTable := Array new: primitiveTable size withAll: -1. - [primitiveMetadataTable := Array new: primitiveTable size withAll: (-1 bitShift: SpurPrimitiveAccessorDepthShift). pluginList := {}. self loadNewPlugin: ''] ifFalse: [pluginList := {'' -> self }]!

1 0

Re: [Vm-dev] MVC Scrolling crashes
by Bruce O'Neel 19 Feb '22

19 Feb '22

HI, Ok, so I have an ugly patched attached. This fixes the ArmV8 crashes in MVC when you scroll. You can trigger the crash by creating a MVC project, and then within opening a workspace. Enter one line of text and keep hitting return until the text scrolls off the screen. Grab the scroll bar and scroll back. Segfault. The function that is failing is fastPathBottomToTop in platforms/Cross/plugins/BitBltPlugin/BitBltGeneric.c The code works unoptimised, but fails with the C optimiser turned on on Gcc 10.2 and gcc 7.5.0. The code looks fine to me, so, either I don't see it or this is one of those worked in the past when the C optimisers did not take advantage of "oh look, that is undefined, so I will do what I wish." My patch just bypasses the fast path in fastPathBottomToTop and forces the slower path. The only place this seemed to be used is MVC when you do big scrolling. I don't notice any obvious slowdowns even on a slow PI 3. I think this patch should be included in the 6.0 release because I am biased by works but a touch slower vs segfaults. Thanks. bruce On 2022-02-16T20:16:03.000+01:00, Marcel Taeumel <marcel.taeumel(a)hpi.de> wrote: > Hi -- > > "Form over" blitting rule is not used much in Morphic anymore. > > Here are is something you can try to see if it crashes in Morphic: > > HandMorph showEvents: false. "Still uses Form over" > > Here are some things you can do to use another blitting rule in MVC: > > TextConstants at: #DefaultRule put: Form blend. "was: Form > over" > > Maybe this stops the crashes. :-) Please report back. > > Best, > Marcel

1 0

[OpenSmalltalk/opensmalltalk-vm] f464b4: CogVM source as per VMMaker.oscog-eem.3160
by Eliot Miranda 18 Feb '22

18 Feb '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f464b4957d7705cd5725259e39775d3f6706d77b https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f464b4957d7705cd57… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3160 CoInterpreter: fix a serious bug with post-become processing in Spur where the instruction pointer could be updated incorrectly if it was in machine code (CoInterpreter>>followForwardingPointersInStackZone:). Add shared pool variables to cointerp.h so that phase errors are caught. Rename PrimErrTableIndex to PrimitiveErrorTableIndex so it is not confused with the PrimErrXXX values. Update a few primitives that use PrimCallMayEndureCodeCompaction to also supply the required PrimCallNeedsNewMethod.

1 0

VM Maker: VMMaker.oscog-eem.3160.mcz
by commits＠source.squeak.org 18 Feb '22

18 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3160.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3160 Author: eem Time: 18 February 2022, 12:07:33.23046 pm UUID: 56010400-c0d0-407a-aed4-55432c452571 Ancestors: VMMaker.oscog-eem.3159 ...and update a few primitives that use PrimCallMayEndureCodeCompaction to also supply the required PrimCallNeedsNewMethod. =============== Diff against VMMaker.oscog-eem.3159 =============== Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveProfileSemaphore (in category 'process primitives') ----- primitiveProfileSemaphore "Primitive. Install the semaphore to be used for profiling, or nil if no semaphore should be used. See also primitiveProfileStart." <export: true> + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> | sema flushState | sema := self stackValue: 0. sema = objectMemory nilObject ifTrue: [flushState := profileSemaphore ~= objectMemory nilObject] ifFalse: [flushState := profileSemaphore = objectMemory nilObject. (objectMemory isSemaphoreOop: sema) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]]. profileSemaphore := sema. profileProcess := profileMethod := objectMemory nilObject. "If we've switched profiling on or off we must void machine code (and machine code pcs in contexts) since we will start or stop testing the profile clock in machine code primitive invocations, and so generate slightly different code from here on in." flushState ifTrue: [self flushExternalPrimitives] ifFalse: [self methodReturnReceiver]! Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveUnloadModule (in category 'plugin primitives') ----- primitiveUnloadModule "Primitive. Unload the module with the given name. Reloading of the module will happen *later* automatically, when a function from it is called. This is forced by invalidating all external primitive methods and activations in flushExternalPrimitives. N.B. since this is most likely a development time activity we don't care about performance." + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> | moduleName moduleLength | moduleName := self stackTop. (objectMemory isBytes: moduleName) ifFalse:[^self primitiveFail]. moduleLength := objectMemory numBytesOfBytes: moduleName. (self ioUnloadModule: (self oopForPointer: (objectMemory firstIndexableField: moduleName)) OfLength: moduleLength) ifFalse:[^self primitiveFail]. (self object: moduleName equalsString: 'SqueakFFIPrims' ofSize: moduleLength) ifTrue: [primitiveCalloutPointer := self cCoerceSimple: -1 to: #'void *']. "N.B. flushExternalPrimitives continues. Do *not* do anything after flushExternalPrimitives in the CoInterpreter" self forceInterruptCheck. self flushExternalPrimitives "NOTREACHED"! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver. Special-case non-single contexts (because of context-to-stack mapping). Can't fail for contexts cuz of image context instantiation code (sigh)." + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> "because of cloneContext: below" - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> "because of cloneContext: below" | rcvr newCopy | rcvr := self stackTop. (objectMemory isImmediate: rcvr) ifTrue: [newCopy := rcvr] ifFalse: [(objectMemory isContextNonImm: rcvr) ifTrue: [newCopy := self cloneContext: rcvr] ifFalse: [(argumentCount = 0 or: [(objectMemory isForwarded: rcvr) not]) ifTrue: [newCopy := objectMemory cloneObject: rcvr] ifFalse: [newCopy := 0]]. newCopy = 0 ifTrue: [^self primitiveFailFor: PrimErrNoMemory]]. self methodReturnValue: newCopy! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveInstVarAt (in category 'object access primitives') ----- primitiveInstVarAt + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> "because of externalInstVar:ofContext: below" - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> "because of externalInstVar:ofContext: below" | index rcvr hdr fmt totalLength fixedFields value | index := self stackTop. rcvr := self stackValue: 1. ((objectMemory isNonIntegerObject: index) or: [argumentCount > 1 "e.g. object:instVarAt:" and: [objectMemory isOopForwarded: rcvr]]) ifTrue: [^self primitiveFailFor: PrimErrBadArgument]. (objectMemory isImmediate: rcvr) ifTrue: [^self primitiveFailFor: PrimErrInappropriate]. index := objectMemory integerValueOf: index. hdr := objectMemory baseHeader: rcvr. fmt := objectMemory formatOfHeader: hdr. totalLength := objectMemory lengthOf: rcvr baseHeader: hdr format: fmt. fixedFields := objectMemory fixedFieldsOf: rcvr format: fmt length: totalLength. (index >= 1 and: [index <= fixedFields]) ifFalse: [^self primitiveFailFor: PrimErrBadIndex]. (fmt = objectMemory indexablePointersFormat and: [objectMemory isContextHeader: hdr]) ifTrue: [value := self externalInstVar: index - 1 ofContext: rcvr] ifFalse: [value := self subscript: rcvr with: index format: fmt]. self pop: argumentCount + 1 thenPush: value! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveSlotAt (in category 'object access primitives') ----- primitiveSlotAt "Answer a slot in an object. This numbers all slots from 1, ignoring the distinction between named and indexed inst vars. In objects with both named and indexed inst vars, the named inst vars precede the indexed ones. In non-object indexed objects (objects that contain bits, not object references) this primitive answers the raw integral value at each slot. e.g. for Strings it answers the character code, not the Character object at each slot." + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> "because of externalInstVar:ofContext: below" - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> "because of externalInstVar:ofContext: below" | index rcvr fmt numSlots | index := self stackTop. rcvr := self stackValue: 1. (objectMemory isIntegerObject: index) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. (objectMemory isImmediate: rcvr) ifTrue: [^self primitiveFailFor: PrimErrBadReceiver]. fmt := objectMemory formatOf: rcvr. index := (objectMemory integerValueOf: index) - 1. fmt <= objectMemory lastPointerFormat ifTrue: [numSlots := objectMemory numSlotsOf: rcvr. (self asUnsigned: index) < numSlots ifTrue: [| value numLiveSlots | (objectMemory isContextNonImm: rcvr) ifTrue: [self externalWriteBackHeadFramePointers. numLiveSlots := (self stackPointerForMaybeMarriedContext: rcvr) + CtxtTempFrameStart. value := (self asUnsigned: index) < numLiveSlots ifTrue: [self externalInstVar: index ofContext: rcvr] ifFalse: [objectMemory nilObject]] ifFalse: [value := objectMemory fetchPointer: index ofObject: rcvr]. self pop: argumentCount + 1 thenPush: value. ^0]. ^self primitiveFailFor: PrimErrBadIndex]. fmt >= objectMemory firstByteFormat ifTrue: [fmt >= objectMemory firstCompiledMethodFormat ifTrue: [^self primitiveFailFor: PrimErrUnsupported]. numSlots := objectMemory numBytesOfBytes: rcvr. (self asUnsigned: index) < numSlots ifTrue: [self pop: argumentCount + 1 thenPushInteger: (objectMemory fetchByte: index ofObject: rcvr). ^0]. ^self primitiveFailFor: PrimErrBadIndex]. (objectMemory hasSpurMemoryManagerAPI and: [fmt >= objectMemory firstShortFormat]) ifTrue: [numSlots := objectMemory num16BitUnitsOf: rcvr. (self asUnsigned: index) < numSlots ifTrue: [self pop: argumentCount + 1 thenPushInteger: (objectMemory fetchUnsignedShort16: index ofObject: rcvr). ^0]. ^self primitiveFailFor: PrimErrBadIndex]. fmt = objectMemory sixtyFourBitIndexableFormat ifTrue: [numSlots := objectMemory num64BitUnitsOf: rcvr. (self asUnsigned: index) < numSlots ifTrue: [self pop: argumentCount + 1 thenPush: (self positive64BitIntegerFor: (objectMemory fetchLong64: index ofObject: rcvr)). ^0]. ^self primitiveFailFor: PrimErrBadIndex]. fmt >= objectMemory firstLongFormat ifTrue: [numSlots := objectMemory num32BitUnitsOf: rcvr. (self asUnsigned: index) < numSlots ifTrue: [self pop: argumentCount + 1 thenPush: (self positive32BitIntegerFor: (objectMemory fetchLong32: index ofObject: rcvr)). ^0]. ^self primitiveFailFor: PrimErrBadIndex]. ^self primitiveFailFor: PrimErrBadReceiver! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveUnloadModule (in category 'plugin primitives') ----- primitiveUnloadModule "Primitive. Unload the module with the given name. Reloading of the module will happen *later* automatically, when a function from it is called. This is forced by invalidating all external primitive methods and activations in flushExternalPrimitives. N.B. since this is most likely a development time activity we don't care about performance." - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> | moduleName moduleLength | moduleName := self stackTop. (objectMemory isBytes: moduleName) ifFalse:[^self primitiveFail]. moduleLength := objectMemory numBytesOfBytes: moduleName. (self ioUnloadModule: (self oopForPointer: (objectMemory firstIndexableField: moduleName)) OfLength: moduleLength) ifFalse:[^self primitiveFail]. (self object: moduleName equalsString: 'SqueakFFIPrims' ofSize: moduleLength) ifTrue: [primitiveCalloutPointer := self cCoerceSimple: -1 to: #'void *']. self forceInterruptCheck. self flushExternalPrimitives. self pop: 1 "pop moduleName; return receiver"!

1 0

VM Maker: VMMaker.oscog-eem.3159.mcz
by commits＠source.squeak.org 18 Feb '22

18 Feb '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3159.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3159 Author: eem Time: 18 February 2022, 11:59:34.550592 am UUID: c1612d06-f1b4-4bb1-8528-43aac645fa70 Ancestors: VMMaker.oscog-eem.3158 CoInterpreter: fix a serious bug with post-become processing in Spur where the instruction pointer could be updated incorrectly if it was in machine code (CoInterpreter>>followForwardingPointersInStackZone:). Nuke the unused primErrTable. Slang: Add shared pool variables to cointerp.h so tat phase errors are caught. Rename PrimErrTableIndex to PrimitiveErrorTableIndex so it is not confused with the PrimErrXXX values. Fix a bug with VMMakerTool when changing the source directory; VMMaker held onto the old directory objects. =============== Diff against VMMaker.oscog-eem.3158 =============== Item was changed: ----- Method: CCodeGenerator>>commonSharedPoolVariableNames (in category 'C code generator') ----- commonSharedPoolVariableNames "Answer the names of pool variables (potentially) shared between the Cogit and the CoInterpreter, but not defined in interp.h" | commonConstants cointerpPools cogitPools | commonConstants := Set new. cointerpPools := vmClass withAllSuperclasses inject: Set new into: [:them :class| them addAll: class poolDictionaryNames. them]. cogitPools := vmClass cogitClass withAllSuperclasses inject: Set new into: [:them :class| them addAll: class poolDictionaryNames. them]. (cointerpPools intersection: cogitPools) do: [:poolName| (Smalltalk at: poolName) classPool associationsDo: [:binding| (self isCLiteral: binding value) ifTrue: [commonConstants add: binding key]]]. #(initializeMiscConstants initializePrimitiveErrorCodes) do: [:selector| (VMClass class>>selector) literalsDo: [:lit| + (lit isVariableBinding and: [lit key isString and: [lit key ~~ #PrimitiveErrorTableIndex]]) ifTrue: - (lit isVariableBinding and: [lit key isString]) ifTrue: [commonConstants remove: lit key ifAbsent: []]]]. VMBasicConstants mostBasicConstantNames do: [:mbcn| commonConstants remove: mbcn ifAbsent: []]. ^commonConstants! Item was changed: ----- Method: CCodeGenerator>>emitCConstantsOn: (in category 'C code generator') ----- emitCConstantsOn: aStream "Store the global variable declarations on the given stream." | unused | unused := constants keys asSet. + methods do: + [:meth| + meth declarations keysDo: + [:v| + (meth typeFor: v in: self) ifNotNil: + [:type| unused remove: type ifAbsent: []]]. + unused remove: meth returnType ifAbsent: []. + meth parseTree nodesDo: + [:n| n isConstant ifTrue: [unused remove: n name ifAbsent: []]]]. "Don't generate any defines for the externally defined constants, STACKVM, COGVM, COGMTVM et al, unless they're actually used. Also don't generate the PrimErr defines; these must be taken from interp.h" #(initializeMiscConstants initializePrimitiveErrorCodes) do: [:selector| (VMClass class>>selector) literalsDo: [:lit| + (lit isVariableBinding and: [lit key isString and: [lit key ~~ #PrimitiveErrorTableIndex]]) ifTrue: - (lit isVariableBinding and: [lit key isString]) ifTrue: [unused add: lit key]]]. "and VMBasicConstants mostBasicConstantNames must be taken from interp.h" unused addAll: VMBasicConstants mostBasicConstantNames. - methods do: - [:meth| - meth declarations keysDo: - [:v| - (meth typeFor: v in: self) ifNotNil: - [:type| unused remove: type ifAbsent: []]]. - unused remove: meth returnType ifAbsent: []. - meth parseTree nodesDo: - [:n| n isConstant ifTrue: [unused remove: n name ifAbsent: []]]]. unused copy do: [:const| (variableDeclarations anySatisfy: [:value| value includesSubstring: const]) ifTrue: [unused remove: const ifAbsent: []]]. + self emitCConstants: (constants keys reject: [:any| unused includes: any]) on: aStream! - self emitCConstants: (constants keys reject: [:any| unused includes: any]) on: aStream! Item was changed: ----- Method: CoInterpreter class>>metadataFlagsForPrimitive: (in category 'spur compilation support') ----- metadataFlagsForPrimitive: aPrimitiveMethodOrNil + "Primitive methods may decorate themselves with 8 flags (FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag et al) + that alter how the Cogit dispatches primitives. These flags are supplied by the primitiveMetadata: pragma. + Primitive methods that access newMethod (e.g. primitiveExternalCall), or may experience a code compaction (e.g. + they may callback), are required to decorate themselves with the PrimCallMayEndureCodeCompaction & + PrimCallNeedsNewMethod flags. This information is used by the JIT to generate correct and efficient dispatch code." - "We allow methods to decorate themselves with 8 flags (FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag et al) - that alter how the Cogit dispatches primitives. These flags are supplied by the primitiveMetadata: pragma." aPrimitiveMethodOrNil ifNil: [^0]. ^(aPrimitiveMethodOrNil pragmaAt: #primitiveMetadata:) ifNil: [0] ifNotNil: [:pragma| | flags | flags := (flags := pragma arguments first) isInteger ifTrue: [flags] ifFalse: [self valueOfMetadataFlag: flags]. "PrimCallMayEndureCodeCompaction & PrimCallOnSmalltalkStack[Align2x] are mutually exclusive..." + self assert: ((flags noMask: PrimCallMayEndureCodeCompaction) or: [flags noMask: PrimCallOnSmalltalkStack + PrimCallOnSmalltalkStackAlign2x]). + "And because ceActivateFailingPrimitiveMethod: needs newMethod to be up-to-date, + PrimCallMayEndureCodeCompaction implies PrimCallNeedsNewMethod." + self assert: ((flags noMask: PrimCallMayEndureCodeCompaction) or: [flags allMask: PrimCallNeedsNewMethod]). - self assert: ((flags anyMask: PrimCallMayEndureCodeCompaction) & (flags anyMask: PrimCallOnSmalltalkStack + PrimCallOnSmalltalkStackAlign2x)) not. flags]! Item was changed: ----- Method: CoInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- followForwardingPointersInStackZone: theBecomeEffectsFlags "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. The read-barrier is minimised by arranging that forwarding pointers will fail a method cache probe, since notionally objects' internals are accessed only via sending messages to them, the exception is primitives that access the internals of the non-receiver argument(s). To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan the receivers (including the stacked receiver for non-local return) and method references in the stack zone and follow any forwarded ones. This is of course way cheaper than scanning all of memory as in the old become. Override to handle machine code frames" | theIPPtr | <inline: false> - <var: #theSP type: #'char *'> - <var: #theFP type: #'char *'> - <var: #theIPPtr type: #usqInt> - <var: #callerFP type: #'char *'> - <var: #thePage type: #'StackPage *'> - self externalWriteBackHeadFramePointers. - (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: [(objectMemory isForwarded: method) ifTrue: + [theIPPtr := instructionPointer > method ifTrue: [instructionPointer - method]. - [theIPPtr := instructionPointer - method. method := objectMemory followForwarded: method. + theIPPtr ifNotNil: [instructionPointer := method + theIPPtr]]. - instructionPointer := method + theIPPtr]. (objectMemory isOopForwarded: newMethod) ifTrue: [newMethod := objectMemory followForwarded: newMethod]]. + stackPage = 0 ifTrue: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + - self assert: stackPage ~= 0. 0 to: numStackPages - 1 do: [:i| | thePage theSP theFP callerFP oop offset | thePage := stackPages stackPageAt: i. thePage isFree ifFalse: [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). theFP := thePage headFP. "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - theIPPtr := thePage = stackPage ifTrue: [0] ifFalse: [thePage headSP asUnsignedInteger]. [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - self assert: (theIPPtr = 0 or: [thePage addressIsInPage: theIPPtr asVoidPointer]). (self isMachineCodeFrame: theFP) ifTrue: [oop := stackPages longAt: theFP + FoxMFReceiver. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + FoxMFReceiver put: (objectMemory followForwarded: oop)]. self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not] ifFalse: [oop := stackPages longAt: theFP + FoxIFReceiver. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + FoxIFReceiver put: (objectMemory followForwarded: oop)]. oop := self iframeMethod: theFP. (objectMemory isForwarded: oop) ifTrue: [| newOop | newOop := objectMemory followForwarded: oop. offset := newOop - oop. + (theIPPtr notNil - (theIPPtr ~= 0 and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: [stackPages longAt: theIPPtr put: (stackPages longAt: theIPPtr) + offset]. stackPages longAt: theFP + FoxIFSavedIP put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. stackPages longAt: theFP + FoxMethod put: (oop := newOop)]]. ((self frameHasContext: theFP) and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: [stackPages longAt: theFP + FoxThisContext put: (objectMemory followForwarded: (self frameContext: theFP))]. offset := self frameStackedReceiverOffset: theFP. oop := stackPages longAt: theFP + offset. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + offset put: (objectMemory followForwarded: oop)]. (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. theFP := callerFP]. "And finally follow the saved context and the caller context." theSP := thePage baseAddress - objectMemory wordSize. [theSP <= thePage baseAddress] whileTrue: [oop := stackPages longAt: theSP. (objectMemory isForwarded: oop) ifTrue: [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. theSP := theSP + objectMemory wordSize]]]! Item was removed: - ----- Method: CoInterpreter>>primErrTable (in category 'cog jit support') ----- - primErrTable - <api> - ^objectMemory splObj: PrimErrTableIndex! Item was changed: ----- Method: InterpreterPrimitives>>primitiveFlushExternalPrimitives (in category 'plugin primitives') ----- primitiveFlushExternalPrimitives "Primitive. Flush all the existing external primitives in the image thus forcing a reload on next invocation." + <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> - <primitiveMetadata: #PrimCallMayEndureCodeCompaction> self flushExternalPrimitives! Item was changed: ----- Method: ObjectMemory>>primitiveErrorTable (in category 'interpreter access') ----- primitiveErrorTable <api> + ^self splObj: PrimitiveErrorTableIndex! - ^self splObj: PrimErrTableIndex! Item was changed: ----- Method: SpurMemoryManager>>primitiveErrorTable (in category 'accessing') ----- primitiveErrorTable <api> + ^self splObj: PrimitiveErrorTableIndex! - ^self splObj: PrimErrTableIndex! Item was changed: ----- Method: StackInterpreter class>>metadataFlagsForPrimitive: (in category 'spur compilation support') ----- metadataFlagsForPrimitive: aPrimitiveMethod + "Primitive methods may decorate themselves with 8 flags (FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag et al) - "We allow methods to decorate themselves with 8 flags (FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag et al) that alter how the Cogit dispatches primitives. These flags are supplied by the primitiveMetadata: pragma. + Primitive methods that access newMethod (e.g. primitiveExternalCall), or may experience a code compaction (e.g. + they may callback), are required to decorate themselves with the PrimCallMayEndureCodeCompaction & + PrimCallNeedsNewMethod flags. This information is used by the JIT to generate correct and efficient dispatch code. But this is not relevant to the StackInterpreter." ^0! Item was changed: ----- Method: StackInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- followForwardingPointersInStackZone: theBecomeEffectsFlags "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. The read-barrier is minimised by arranging that forwarding pointers will fail a method cache probe, since notionally objects' internals are accessed only via sending messages to them, the exception is primitives that access the internals of the non-receiver argument(s). To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan the receivers (including the stacked receiver for non-local return) and method references in the stack zone and follow any forwarded ones. This is of course way cheaper than scanning all of memory as in the old become." | theIPPtr | <inline: false> - <var: #theFP type: #'char *'> - <var: #theIPPtr type: #usqInt> - <var: #callerFP type: #'char *'> - <var: #thePage type: #'StackPage *'> - stackPage = 0 ifTrue: "the system must be snapshotting; nothing to do..." - [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). - self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. - ^self]. - - self externalWriteBackHeadFramePointers. - (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: [(objectMemory isForwarded: method) ifTrue: [theIPPtr := instructionPointer - method. method := objectMemory followForwarded: method. instructionPointer := method + theIPPtr]. (objectMemory isOopForwarded: newMethod) ifTrue: [newMethod := objectMemory followForwarded: newMethod]]. + stackPage = 0 ifTrue: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + - self assert: stackPage ~= 0. 0 to: numStackPages - 1 do: [:i| | thePage theFP callerFP offset oop | thePage := stackPages stackPageAt: i. thePage isFree ifFalse: [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. - theFP := thePage headFP. "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - theIPPtr := thePage = stackPage ifTrue: [0] ifFalse: [thePage headSP asUnsignedInteger]. [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - self assert: (theIPPtr = 0 or: [thePage addressIsInPage: theIPPtr asVoidPointer]). oop := stackPages longAt: theFP + FoxReceiver. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + FoxReceiver put: (objectMemory followForwarded: oop)]. ((self frameHasContext: theFP) and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: [stackPages longAt: theFP + FoxThisContext put: (objectMemory followForwarded: (self frameContext: theFP))]. oop := self frameMethod: theFP. (objectMemory isForwarded: oop) ifTrue: [| newOop delta | newOop := objectMemory followForwarded: oop. + theIPPtr ifNotNil: - theIPPtr ~= 0 ifTrue: [self assert: (stackPages longAt: theIPPtr) > (self frameMethod: theFP). delta := newOop - oop. stackPages longAt: theIPPtr put: (stackPages longAt: theIPPtr) + delta]. stackPages longAt: theFP + FoxMethod put: (oop := newOop)]. offset := self frameStackedReceiverOffset: theFP. oop := stackPages longAt: theFP + offset. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + offset put: (objectMemory followForwarded: oop)]. (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. theFP := callerFP]. "And finally follow the caller context." self assert: theFP = thePage baseFP. oop := self frameCallerContext: theFP. (objectMemory isForwarded: oop) ifTrue: [self frameCallerContext: theFP put: (objectMemory followForwarded: oop)]]]! Item was changed: ----- Method: StackInterpreter>>getErrorObjectFromPrimFailCode (in category 'message sending') ----- getErrorObjectFromPrimFailCode "Answer the errorCode object to supply to a failing primitive method that accepts one. If there is a primitive error table and the primFailCode is a valid index there-in answer the corresponding entry in the table, otherwise simply answer the code as an integer." | table errObj | primFailCode > 0 ifTrue: + [table := objectMemory splObj: PrimitiveErrorTableIndex. - [table := objectMemory splObj: PrimErrTableIndex. primFailCode <= (objectMemory numSlotsOf: table) ifTrue: [errObj := objectMemory followField: primFailCode - 1 ofObject: table. "If there's a clonable object in the table at that index, answer a clone of the error object with the second slot set to the value of secondaryErrorCode." (objectMemory formatOf: errObj) = objectMemory nonIndexablePointerFormat ifTrue: [errObj := self cloneErrorObj: errObj]. ^errObj]]. ^objectMemory integerObjectOf: primFailCode! Item was changed: ----- Method: VMClass class>>initializePrimitiveErrorCodes (in category 'initialization') ----- initializePrimitiveErrorCodes "Define the VM's primitive error codes. N.B. these are replicated in platforms/Cross/vm/sqVirtualMachine.h." "VMClass initializePrimitiveErrorCodes" | pet | + PrimitiveErrorTableIndex := 51. "Zero-relative" - PrimErrTableIndex := 51. "Zero-relative" "See SmalltalkImage>>recreateSpecialObjectsArray for the table definition. If the table exists and is large enough the corresponding entry is returned as the primitive error, otherwise the error is answered numerically." + pet := Smalltalk specialObjectsArray at: PrimitiveErrorTableIndex + 1 ifAbsent: [#()]. - pet := Smalltalk specialObjectsArray at: PrimErrTableIndex + 1 ifAbsent: [#()]. pet isArray ifFalse: [pet := #()]. PrimNoErr := 0. "for helper methods that need to answer success or an error code." PrimErrGenericFailure := pet indexOf: nil ifAbsent: 1. PrimErrBadReceiver := pet indexOf: #'bad receiver' ifAbsent: 2. PrimErrBadArgument := pet indexOf: #'bad argument' ifAbsent: 3. PrimErrBadIndex := pet indexOf: #'bad index' ifAbsent: 4. PrimErrBadNumArgs := pet indexOf: #'bad number of arguments' ifAbsent: 5. PrimErrInappropriate := pet indexOf: #'inappropriate operation' ifAbsent: 6. PrimErrUnsupported := pet indexOf: #'unsupported operation' ifAbsent: 7. PrimErrNoModification := pet indexOf: #'no modification' ifAbsent: 8. PrimErrNoMemory := pet indexOf: #'insufficient object memory' ifAbsent: 9. PrimErrNoCMemory := pet indexOf: #'insufficient C memory' ifAbsent: 10. PrimErrNotFound := pet indexOf: #'not found' ifAbsent: 11. PrimErrBadMethod := pet indexOf: #'bad method' ifAbsent: 12. PrimErrNamedInternal := pet indexOf: #'internal error in named primitive machinery' ifAbsent: 13. PrimErrObjectMayMove := pet indexOf: #'object may move' ifAbsent: 14. PrimErrLimitExceeded := pet indexOf: #'resource limit exceeded' ifAbsent: 15. PrimErrObjectIsPinned := pet indexOf: #'object is pinned' ifAbsent: 16. PrimErrWritePastObject := pet indexOf: #'primitive write beyond end of object' ifAbsent: 17. PrimErrObjectMoved := pet indexOf: #'object moved' ifAbsent: 18. PrimErrObjectNotPinned := pet indexOf: #'object not pinned' ifAbsent: 19. PrimErrCallbackError := pet indexOf: #'error in callback' ifAbsent: 20. PrimErrOSError := pet indexOf: #'operating system error' ifAbsent: 21. PrimErrFFIException := pet indexOf: #'ffi call exception' ifAbsent: 22. PrimErrNeedCompaction := pet indexOf: #'heap compaction needed' ifAbsent: 23. "N.B. This is currently an internal error in Spur image segment saving." PrimErrOperationFailed := pet indexOf: #'operation failed' ifAbsent: 24. PrimErrInternalError := pet indexOf: #'internal error' ifAbsent: 25. PrimErrUninitialized := pet indexOf: #'uninitialized' ifAbsent: 26. PrimErrFFIMarshallingError := pet indexOf: #'ffi marshalling error' ifAbsent: 27! Item was changed: ----- Method: VMMaker>>sourceDirectoryName: (in category 'target directories') ----- sourceDirectoryName: aString "Sanity check really ought to be added, This is the root directory for where the sources will be WRITTEN" sourceDirName := aString. + coreVMDirectory := sourceDirectory := nil. (aString first == $. ifTrue: [FileDirectory default directoryNamed: aString] ifFalse: [FileDirectory on: aString]) assureExistence. self changed: #sourceDirectory. ^true! Item was changed: SharedPool subclass: #VMObjectIndices instanceVariableNames: '' + classVariableNames: 'ActiveProcessIndex CharacterTable CharacterValueIndex ClassAlien ClassArray ClassBitmap ClassBlockClosure ClassBlockContext ClassByteArray ClassByteString ClassCharacter ClassDoubleByteArray ClassDoubleWordArray ClassExternalAddress ClassExternalData ClassExternalFunction ClassExternalLibrary ClassExternalStructure ClassFloat ClassFullBlockClosure ClassLargeNegativeInteger ClassLargePositiveInteger ClassMessage ClassMethodContext ClassPoint ClassSemaphore ClassSmallInteger ClassString ClassUnsafeAlien ClassWeakFinalizer ClassWordArray ClosureFirstCopiedValueIndex ClosureIndex ClosureNumArgsIndex ClosureOuterContextIndex ClosureStartPCIndex CompactClasses ConstMinusOne ConstOne ConstTwo ConstZero ExcessSignalsIndex ExternalObjectsArray FalseObject FirstLinkIndex ForeignCallbackProcess FullClosureCompiledBlockIndex FullClosureFirstCopiedValueIndex FullClosureReceiverIndex HeaderIndex InstanceSpecificationIndex InstructionPointerIndex KeyIndex LastLinkIndex Liter alStart LowcodeContextMark LowcodeNativeContextClass MessageArgumentsIndex MessageLookupClassIndex MessageSelectorIndex MethodArrayIndex MethodDictionaryIndex MethodIndex MyListIndex NextLinkIndex NilObject PrimitiveErrorTableIndex PriorityIndex ProcessInExternalCodeTag ProcessListsIndex ProcessSignalingLowSpace ReceiverIndex SchedulerAssociation SelectorAboutToReturn SelectorAttemptToAssign SelectorCannotInterpret SelectorCannotReturn SelectorCounterTripped SelectorDoesNotUnderstand SelectorInvokeCallback SelectorMustBeBoolean SelectorRunWithIn SelectorSistaTrap SelectorStart SelectorUnknownBytecode SenderIndex SpecialSelectors StackPointerIndex StreamArrayIndex StreamIndexIndex StreamReadLimitIndex StreamWriteLimitIndex SuperclassIndex SuspendedContextIndex TheDisplay TheFinalizationSemaphore TheInputSemaphore TheInterruptSemaphore TheLowSpaceSemaphore TheTimerSemaphore TrueObject ValueIndex XIndex YIndex' - classVariableNames: 'ActiveProcessIndex CharacterTable CharacterValueIndex ClassAlien ClassArray ClassBitmap ClassBlockClosure ClassBlockContext ClassByteArray ClassByteString ClassCharacter ClassDoubleByteArray ClassDoubleWordArray ClassExternalAddress ClassExternalData ClassExternalFunction ClassExternalLibrary ClassExternalStructure ClassFloat ClassFullBlockClosure ClassLargeNegativeInteger ClassLargePositiveInteger ClassMessage ClassMethodContext ClassPoint ClassSemaphore ClassSmallInteger ClassString ClassUnsafeAlien ClassWeakFinalizer ClassWordArray ClosureFirstCopiedValueIndex ClosureIndex ClosureNumArgsIndex ClosureOuterContextIndex ClosureStartPCIndex CompactClasses ConstMinusOne ConstOne ConstTwo ConstZero ExcessSignalsIndex ExternalObjectsArray FalseObject FirstLinkIndex ForeignCallbackProcess FullClosureCompiledBlockIndex FullClosureFirstCopiedValueIndex FullClosureReceiverIndex HeaderIndex InstanceSpecificationIndex InstructionPointerIndex KeyIndex LastLinkIndex Liter alStart LowcodeContextMark LowcodeNativeContextClass MessageArgumentsIndex MessageLookupClassIndex MessageSelectorIndex MethodArrayIndex MethodDictionaryIndex MethodIndex MyListIndex NextLinkIndex NilObject PrimErrTableIndex PriorityIndex ProcessInExternalCodeTag ProcessListsIndex ProcessSignalingLowSpace ReceiverIndex SchedulerAssociation SelectorAboutToReturn SelectorAttemptToAssign SelectorCannotInterpret SelectorCannotReturn SelectorCounterTripped SelectorDoesNotUnderstand SelectorInvokeCallback SelectorMustBeBoolean SelectorRunWithIn SelectorSistaTrap SelectorStart SelectorUnknownBytecode SenderIndex SpecialSelectors StackPointerIndex StreamArrayIndex StreamIndexIndex StreamReadLimitIndex StreamWriteLimitIndex SuperclassIndex SuspendedContextIndex TheDisplay TheFinalizationSemaphore TheInputSemaphore TheInterruptSemaphore TheLowSpaceSemaphore TheTimerSemaphore TrueObject ValueIndex XIndex YIndex' poolDictionaries: '' category: 'VMMaker-Interpreter'! !VMObjectIndices commentStamp: '<historical>' prior: 0! I am a shared pool for the constants that define object layout and well-known objects shared between the object memories (e.g. ObjectMemory, NewObjectMemory), the interpreters (e.g. StackInterpreter, CoInterpreter) and the object representations (e.g. ObjectRepresentationForSqueakV3). self classPool declare: #Foo from: StackInterpreter classPool (ObjectMemory classPool keys select: [:k| (k beginsWith: 'Class') and: [(k endsWith: 'Index') not]]) do: [:k| self classPool declare: k from: ObjectMemory classPool]!

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2022