Vm-dev March 2018

vm-dev@lists.squeakfoundation.org

46 participants
218 discussions

VM Maker: VMMaker.oscog-eem.2361.mcz
by commits＠source.squeak.org 17 Mar '18

17 Mar '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2361.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2361 Author: eem Time: 17 March 2018, 3:46:08.32065 pm UUID: 7ca2f89a-de70-422f-b92b-54f91ac4e47b Ancestors: VMMaker.oscog-eem.2360 Spur: Make read-only (-DIMMUTABILITY) the default wth Spur VMs. Add MT versions to the Slang generation. Slang: Refactor define generation into putConditionalDefineOf:as:comment:on: putDefineOf:as:on:. To make use of these refactor writeVMHeaderTo:bytesPerWord: to writeVMHeaderTo:bytesPerWord:generator:. =============== Diff against VMMaker.oscog-eem.2360 =============== Item was changed: ----- Method: CCodeGenerator>>emitCConstants:on: (in category 'C code generator') ----- emitCConstants: constList on: aStream "Store the global variable declarations on the given stream." constList isEmpty ifTrue: [^self]. aStream cr; nextPutAll: '/*** Constants ***/'; cr. (self sortStrings: constList) do: + [:varName| | node default value | - [:varName| | node default value conditional | node := constants at: varName. node name isEmpty ifFalse: ["If the definition includes a C comment, or looks like a conditional, take it as is, otherwise convert the value from Smalltalk to C. Allow the class to provide an alternative definition, either of just the value or the whole shebang." default := (node value isString and: [(node value includesSubstring: '/*') or: [(node value includesSubstring: ' ? ') and: [node value includesSubstring: ' : ']]]) ifTrue: [node value] ifFalse: [self cLiteralFor: node value name: varName]. default = #undefined ifTrue: [aStream nextPutAll: '#undef '; nextPutAll: node name; cr] ifFalse: + [value := vmClass - [conditional := (vmClass ifNil: VMBasicConstants) defineAtCompileTime: node name. - conditional ifTrue: - [aStream nextPutAll: '#if !!defined('; nextPutAll: node name; nextPutAll: ') /* Allow this to be overridden on the compiler command line */'; cr]. - value := vmClass ifNotNil: [(vmClass specialValueForConstant: node name default: default) ifNotNil: [:specialDef| specialDef] ifNil: [default]] ifNil: [default]. + ((vmClass ifNil: VMBasicConstants) defineAtCompileTime: node name) + ifTrue: [self putConditionalDefineOf: node name + as: value + comment: 'Allow this to be overridden on the compiler command line' + on: aStream] + ifFalse: [self putDefineOf: node name as: value on: aStream]]]]. - value first ~= $# ifTrue: - [aStream nextPutAll: (conditional ifTrue: ['# define '] ifFalse: ['#define ']); nextPutAll: node name; space]. - aStream nextPutAll: value; cr. - conditional ifTrue: - [aStream nextPutAll: '#endif'; cr]]]]. aStream cr! Item was added: + ----- Method: CCodeGenerator>>putConditionalDefineOf:as:comment:on: (in category 'C code generator') ----- + putConditionalDefineOf: aConstantNameString as: valueOrValueString comment: commentOrNil on: aStream + self withConditionalDefineOf: aConstantNameString + comment: commentOrNil + on: aStream + do: [| valueAsString | + valueAsString := valueOrValueString asString. + valueAsString first ~= $# ifTrue: + [aStream nextPutAll: '# define '; nextPutAll: aConstantNameString; space]. + aStream nextPutAll: valueAsString; cr]! Item was added: + ----- Method: CCodeGenerator>>putDefineOf:as:on: (in category 'C code generator') ----- + putDefineOf: aConstantNameString as: valueOrValueString on: aStream + aStream + nextPutAll: '#define '; + nextPutAll: aConstantNameString; + space; + nextPutAll: valueOrValueString asString; + cr! Item was changed: ----- Method: CCodeGenerator>>vmHeaderContentsWithBytesPerWord: (in category 'public') ----- vmHeaderContentsWithBytesPerWord: bytesPerWord "Store C header code on the given stream." + ^ ByteString + streamContents: [ :tempStream | vmClass writeVMHeaderTo: tempStream bytesPerWord: bytesPerWord generator: self ]! - ^ByteString streamContents: - [:tempStream| - vmClass writeVMHeaderTo: tempStream bytesPerWord: bytesPerWord]! Item was added: + ----- Method: CCodeGenerator>>withConditionalDefineOf:comment:on:do: (in category 'C code generator') ----- + withConditionalDefineOf: aConstantNameString comment: commentOrNil on: aStream do: aBlock + | start | + aStream nextPutAll: '#if !!defined('; nextPutAll: aConstantNameString; nextPut: $). + commentOrNil ifNotNil: [aStream nextPutAll: ' /* '; nextPutAll: commentOrNil; nextPutAll: ' */']. + aStream cr. + start := aStream position. + aBlock value. + aStream nextPutAll: '#endif'. + aStream position - start > 80 ifTrue: + [aStream nextPutAll: ' /* !!defined('; nextPutAll: aConstantNameString; nextPutAll: ') */']. + aStream cr! Item was removed: - ----- Method: CoInterpreter class>>writeVMHeaderTo:bytesPerWord: (in category 'translation') ----- - writeVMHeaderTo: aStream bytesPerWord: bytesPerWord - super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord. - aStream - nextPutAll: '#define COGVM 1'; cr; - nextPutAll: '#if !!defined(COGMTVM)'; cr; - nextPutAll: '# define COGMTVM 0'; cr; - nextPutAll: '#endif'; cr; cr. - "This constant is a hack for the MT VM on SqueakV3. Eventually it will disappear. - But having it here rather than in CoInterpreterMT means that the interp.h header - doesn't get regenerated every time the sources are, which means less recompilation." - ((VMBasicConstants classPool associations select: [:a| a key beginsWith: 'DisownVM']) - asSortedCollection: [:a1 :a2| a1 value <= a2 value]) - do: [:a| - aStream nextPutAll: '#define '; nextPutAll: a key; space; print: a value; cr]! Item was added: + ----- Method: CoInterpreter class>>writeVMHeaderTo:bytesPerWord:generator: (in category 'translation') ----- + writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator + super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator. + aCCodeGenerator + putDefineOf: #COGVM as: 1 on: aStream; + putConditionalDefineOf: #COGMTVM as: 0 comment: nil on: aStream. + aStream cr. + "This constant is a hack for the MT VM on SqueakV3. Eventually it will disappear. + But having it here rather than in CoInterpreterMT means that the interp.h header + doesn't get regenerated every time the sources are, which is a good thing." + aCCodeGenerator + putDefineOf: #DisownVMLockOutFullGC as: DisownVMLockOutFullGC on: aStream! Item was removed: - ----- Method: Interpreter class>>writeVMHeaderTo:bytesPerWord: (in category 'translation') ----- - writeVMHeaderTo: aStream bytesPerWord: bytesPerWord - "Currently the Interpreter adds nothing to interp.h above and beyond VMClass's default. - But the code in trunk's CCodeGenerator>>emitDefineBytesPerWordOn: is a candidate." - super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord! Item was removed: - ----- Method: StackInterpreter class>>writeVMHeaderTo:bytesPerWord: (in category 'translation') ----- - writeVMHeaderTo: aStream bytesPerWord: bytesPerWord - super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord. - SistaVM ifTrue: - [aStream nextPutAll: '#define SistaVM 1'; cr]. - NewspeakVM ifTrue: - [aStream nextPutAll: '#define NewspeakVM 1'; cr]. - MULTIPLEBYTECODESETS ifTrue: - [aStream nextPutAll: '#define MULTIPLEBYTECODESETS 1'; cr]. - IMMUTABILITY ifTrue: - [aStream nextPutAll: '#define IMMUTABILITY 1'; cr]. - NewspeakVM | MULTIPLEBYTECODESETS | IMMUTABILITY ifTrue: - [aStream cr]. - aStream nextPutAll: '#define STACKVM 1'; cr. - (initializationOptions at: #SpurObjectMemory ifAbsent: false) ifTrue: - [aStream nextPutAll: '#define SPURVM 1'; cr]! Item was added: + ----- Method: StackInterpreter class>>writeVMHeaderTo:bytesPerWord:generator: (in category 'translation') ----- + writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator + super writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator. + SistaVM ifTrue: + [aCCodeGenerator putDefineOf: #SistaVM as: 1 on: aStream]. + NewspeakVM ifTrue: + [aCCodeGenerator putDefineOf: #NewspeakVM as: 1 on: aStream]. + MULTIPLEBYTECODESETS ifTrue: + [aCCodeGenerator putDefineOf: #MULTIPLEBYTECODESETS as: 1 on: aStream]. + IMMUTABILITY ifTrue: + [aCCodeGenerator + putConditionalDefineOf: #IMMUTABILITY + as: 1 + comment: 'Allow this to be overridden on the compiler command line' + on: aStream]. + SistaVM | NewspeakVM | MULTIPLEBYTECODESETS | IMMUTABILITY ifTrue: + [aStream cr]. + aCCodeGenerator putDefineOf: #STACKVM as: 1 on: aStream. + (initializationOptions at: #SpurObjectMemory ifAbsent: false) ifTrue: + [aCCodeGenerator putDefineOf: #SPURVM as: 1 on: aStream]! Item was changed: ----- Method: VMClass class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants "Falsify the `what type of VM is this?' flags that are defined in the various interp.h files. Subclass implementations need to include a super initializeMiscConstants" | omc | VMBIGENDIAN class. "Mention this for the benefit of CCodeGenerator>>emitCConstantsOn:" SPURVM := STACKVM := COGVM := COGMTVM := false. initializationOptions ifNil: [self initializationOptions: Dictionary new]. omc := initializationOptions at: #ObjectMemory ifAbsent: nil. (omc isNil and: [self defaultObjectMemoryClass notNil]) ifTrue: [omc := initializationOptions at: #ObjectMemory put: self defaultObjectMemoryClass name]. initializationOptions at: #SqueakV3ObjectMemory "the good ole default" ifAbsentPut: (omc ifNil: [true] ifNotNil: [(Smalltalk at: omc) includesBehavior: ObjectMemory]); at: #SpurObjectMemory "the new contender" ifAbsentPut: (omc ifNil: [false] ifNotNil: [(Smalltalk at: omc) includesBehavior: SpurMemoryManager]). "Use ifAbsentPut: so that they will get copied back to the VMMaker's options and dead code will likely be eliminated." PharoVM := initializationOptions at: #PharoVM ifAbsentPut: [false]. NewspeakVM := initializationOptions at: #NewspeakVM ifAbsentPut: [false]. SistaVM := initializationOptions at: #SistaVM ifAbsentPut: [false]. LowcodeVM := initializationOptions at: #LowcodeVM ifAbsentPut: [false]. MULTIPLEBYTECODESETS := initializationOptions at: #MULTIPLEBYTECODESETS ifAbsentPut: [false]. - "But not these; they're compile-time" - IMMUTABILITY := initializationOptions at: #IMMUTABILITY ifAbsent: [false]. "These must be set only if specified, not defaulted, because they are set on the command line or in include files." initializationOptions at: #VMBIGENDIAN ifPresent: [:value| VMBIGENDIAN := value]; at: #ObjectMemory ifPresent: [:value| SPURVM := value beginsWith: 'Spur']; at: #STACKVM ifPresent: [:value| STACKVM := value]; at: #COGVM ifPresent: [:value| COGVM := initializationOptions at: #COGVM]; + at: #COGMTVM ifPresent: [:value| COGMTVM := initializationOptions at: #COGMTVM]. + + "And not these; they're compile-time" + IMMUTABILITY := initializationOptions at: #IMMUTABILITY ifAbsent: [SPURVM] "Default as enabled for Spur VMs"! - at: #COGMTVM ifPresent: [:value| COGMTVM := initializationOptions at: #COGMTVM]! Item was removed: - ----- Method: VMClass class>>writeVMHeaderTo:bytesPerWord: (in category 'translation') ----- - writeVMHeaderTo: aStream bytesPerWord: bytesPerWord - "Generate the contents of interp.h on aStream. Specific Interpreter subclasses - override to add more stuff." - aStream - nextPutAll: '#define VM_PROXY_MAJOR '; print: self vmProxyMajorVersion; cr; - nextPutAll: '#define VM_PROXY_MINOR '; print: self vmProxyMinorVersion; cr; - cr; - nextPutAll: '#define SQ_VI_BYTES_PER_WORD '; print: bytesPerWord; cr; - cr. - - "The most basic constants must be defined here, not in e.g. the plugin sources, so allow those - other sources to be shared between different builds (Spur vs SqueakV3, 32-bit vs 64-bit, etc)" - VMBasicConstants mostBasicConstantNames asSet asArray sort do: - [:constName| - (VMBasicConstants classPool at: constName ifAbsent: []) ifNotNil: - [:const| - aStream nextPutAll: '#define '; nextPutAll: constName; space; print: const; cr]]. - aStream cr. - - ((VMBasicConstants classPool associations select: [:a| a key beginsWith: 'PrimErr']) - asSortedCollection: [:a1 :a2| a1 value <= a2 value]) - do: [:a| - aStream nextPutAll: '#define '; nextPutAll: a key; space; print: a value; cr]. - aStream cr. - - aStream - nextPutAll: '#define MinSmallInteger '; print: self objectMemoryClass minSmallInteger; cr; - nextPutAll: '#define MaxSmallInteger '; print: self objectMemoryClass maxSmallInteger; cr; - nextPutAll: '#define NumSmallIntegerTagBits '; print: self objectMemoryClass numSmallIntegerTagBits; cr; - cr.! Item was added: + ----- Method: VMClass class>>writeVMHeaderTo:bytesPerWord:generator: (in category 'translation') ----- + writeVMHeaderTo: aStream bytesPerWord: bytesPerWord generator: aCCodeGenerator + "Generate the contents of interp.h on aStream. Specific Interpreter subclasses + override to add more stuff." + aCCodeGenerator + putDefineOf: 'VM_PROXY_MAJOR' as: self vmProxyMajorVersion on: aStream; + putDefineOf: 'VM_PROXY_MINOR' as: self vmProxyMinorVersion on: aStream. + aStream cr. + aCCodeGenerator + putDefineOf: 'SQ_VI_BYTES_PER_WORD' as: bytesPerWord on: aStream. + aStream cr. + + "The most basic constants must be defined here, not in e.g. the plugin sources, to allow those + other sources to be shared between different builds (Spur vs SqueakV3, 32-bit vs 64-bit, etc)" + VMBasicConstants mostBasicConstantNames asSet sorted do: + [:constName| + (VMBasicConstants classPool at: constName ifAbsent: []) ifNotNil: + [:const| aCCodeGenerator putDefineOf: constName as: const on: aStream]]. + aStream cr. + + ((VMBasicConstants classPool associations select: [:a| a key beginsWith: 'PrimErr']) + sorted: [:a1 :a2| a1 value <= a2 value]) + do: [:a| aCCodeGenerator putDefineOf: a key as: a value on: aStream]. + aStream cr. + + aCCodeGenerator + putDefineOf: 'MinSmallInteger' as: self objectMemoryClass minSmallInteger on: aStream; + putDefineOf: 'MaxSmallInteger' as: self objectMemoryClass maxSmallInteger on: aStream; + putDefineOf: 'NumSmallIntegerTagBits' as: self objectMemoryClass numSmallIntegerTagBits on: aStream. + aStream cr! Item was changed: ----- Method: VMMaker class>>generateAllSpurConfigurationsUnderVersionControl (in category 'configurations') ----- generateAllSpurConfigurationsUnderVersionControl self generateNewspeakSpurStackVM; generateNewspeakSpurCog64VM; generateSqueakSpurStackVM; generateSqueakSpurStack64VM; generateNewspeakSpurCogVM; generateSqueakSpurCogVM; generateSqueakSpurCog64VM; + generateSqueakSpurCogMTVM; + generateSqueakSpurCog64MTVM; generateSqueakSpurCogSistaVM; generateSqueakSpurCogSista64VM! Item was changed: ----- Method: VMPluginCodeGenerator>>generateInterpreterProxyFunctionDereference:on:indent: (in category 'C translation') ----- generateInterpreterProxyFunctionDereference: aNode on: aStream indent: anInteger | pluginsToClone | pluginsToClone := self pluginFunctionsToClone copyWithoutAll: self selectorsThatAreGeneratedAsMacros. pluginsToClone isEmpty ifTrue: [^self]. + aStream cr. + self withConditionalDefineOf: 'SQUEAK_BUILTIN_PLUGIN' + comment: nil + on: aStream + do: [pluginsToClone do: + [:s| | cs | + cs := self cFunctionNameFor: s. + self withOptionalVerbiageFor: s + on: aStream + do: [aStream tab: anInteger; nextPutAll: cs; nextPutAll: ' = interpreterProxy->'; nextPutAll: cs; nextPut: $;; cr] + ifOptionalDo: + [self + withConditionalDefineOf: cs + comment: nil + on: aStream + do: [aStream tab: anInteger; nextPutAll: cs; nextPutAll: ' = 0;']]]]! - aStream cr; nextPutAll: '#if !!defined(SQUEAK_BUILTIN_PLUGIN)'; cr. - pluginsToClone do: - [:s| | cs | - cs := self cFunctionNameFor: s. - self withOptionalVerbiageFor: s - on: aStream - do: [aStream tab: anInteger; nextPutAll: cs; nextPutAll: ' = interpreterProxy->'; nextPutAll: cs; nextPut: $;; cr] - ifOptionalDo: [aStream - nextPutAll: '# if !!defined('; nextPutAll: cs; nextPut: $); - crtab: anInteger; nextPutAll: cs; nextPutAll: ' = 0;'; - cr; nextPutAll: '# endif'; cr]]. - aStream nextPutAll: '#endif /* !!defined(SQUEAK_BUILTIN_PLUGIN) */'.! Item was changed: ----- Method: VMPluginCodeGenerator>>withGuardAgainstDefinitionOf:on:do: (in category 'C translation') ----- withGuardAgainstDefinitionOf: selector on: aStream do: aBlock "Evaluate aBlock, surrounded by a define if selector is defined as a macro (i.e. by preDeclareInterpreterProxyOn:" (self selectorsThatMayBeGeneratedAsMacros includes: selector) ifFalse: [^aBlock value]. + self + withConditionalDefineOf: (self cFunctionNameFor: selector) + comment: nil + on: aStream + do: aBlock value! - aStream nextPutAll: '#if !!defined('; nextPutAll: (self cFunctionNameFor: selector); nextPut: $); cr. - aBlock value. - aStream nextPutAll: '#endif'; cr!

1 0

VM Maker: VMMaker.oscog-eem.2360.mcz
by commits＠source.squeak.org 17 Mar '18

17 Mar '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2360.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2360 Author: eem Time: 16 March 2018, 4:23:22.624221 pm UUID: f605d636-c6de-4a07-967a-4d3bfa53fa3e Ancestors: VMMaker.oscog-eem.2359 Plugin: Deprecate the unused in-argument-order primitive argument accessors floatArg:, integerArg:, methodArg:, & objectArg:. These have never been used. Replace them with more convenient variants of methodReturnValue:, namely methodReturnBool:, methodReturnFloat:, methodReturnInteger:, and methodReturnString:. Use them in a few primitives. Change CameraPlugin & UnicodePlugin prims to avoid use of cCode:. =============== Diff against VMMaker.oscog-eem.2359 =============== Item was changed: ----- Method: CameraPlugin>>primFrameExtent (in category 'primitives') ----- primFrameExtent "Answer the frame extent of the given camera, or zero if the camera is not open. The extent is 16 bits of width and height packed into a single integer." + | cameraNum | - | cameraNum e | <export: true> cameraNum := interpreterProxy stackIntegerValue: 0. + interpreterProxy failed ifFalse: + [interpreterProxy methodReturnInteger: (self CameraExtent: cameraNum)]! - interpreterProxy failed ifTrue: [^ 0]. - - e := self cCode: 'CameraExtent(cameraNum)'. - - interpreterProxy pop: 2 thenPush: (interpreterProxy integerObjectOf: e). "pop rcvr & arg, push int result" - ^ 0 - ! Item was changed: ----- Method: CameraPlugin>>primGetFrame (in category 'primitives') ----- primGetFrame "Copy a camera frame into the given Bitmap. The Bitmap should be for a Form of depth 32 that is the same width and height as the current camera frame. Fail if the camera is not open or if the bitmap is not the right size. If successful, answer the number of frames received from the camera since the last call. If this is zero, then there has been no change." | cameraNum bitmapOop bitmap pixCount result | <export: true> <var: 'bitmap' type: #'unsigned char *'> cameraNum := interpreterProxy stackIntegerValue: 1. bitmapOop := interpreterProxy stackValue: 0. interpreterProxy success: (interpreterProxy isWords: bitmapOop). interpreterProxy failed ifTrue: [^ 0]. bitmap := self cCoerce: (interpreterProxy firstIndexableField: bitmapOop) to: #'unsigned char *'. pixCount := interpreterProxy stSizeOf: bitmapOop. result := self Camera: cameraNum Get: bitmap Frame: pixCount. + result < 0 ifTrue: + [^interpreterProxy primitiveFail]. - result < 0 ifTrue: [ - interpreterProxy success: false. - ^ 0]. + interpreterProxy methodReturnInteger: result! - interpreterProxy pop: 3 thenPush: (interpreterProxy integerObjectOf: result). "pop rcvr & args, push int result" - ^ 0 - - ! Item was changed: ----- Method: CameraPlugin>>primGetParam (in category 'primitives') ----- primGetParam "Answer the given integer parameter of the given camera." + | cameraNum paramNum | - | cameraNum paramNum result | <export: true> cameraNum := interpreterProxy stackIntegerValue: 1. paramNum := interpreterProxy stackIntegerValue: 0. + interpreterProxy failed ifFalse: + [interpreterProxy methodReturnInteger: (self Camera: cameraNum GetParam: paramNum)]! - interpreterProxy failed ifTrue: [^ 0]. - - result := self cCode: 'CameraGetParam(cameraNum, paramNum)'. - - interpreterProxy pop: 3 thenPush: (interpreterProxy integerObjectOf: result). "pop rcvr & args, push int result" - ^ 0 - ! Item was changed: ----- Method: FloatArrayPlugin>>primitiveLength (in category 'arithmetic primitives') ----- primitiveLength "Primitive. Compute the length of the argument (sqrt of sum of component squares)." <export: true> | rcvr rcvrPtr length len | <var: #rcvrPtr type: #'float *'> <var: #len type: #double> rcvr := interpreterProxy stackValue: 0. (interpreterProxy isWords: rcvr) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. length := interpreterProxy stSizeOf: rcvr. rcvrPtr := self cCoerce: (interpreterProxy firstIndexableField: rcvr) to: #'float *'. len := 0.0. 0 to: length-1 do: [:i| len := len + ((self cCoerce: (rcvrPtr at: i) to: #double) * (self cCoerce: (rcvrPtr at: i) to: #double)) ]. len > 0.0 ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + interpreterProxy methodReturnFloat: (self sqrt: len)! - interpreterProxy pop: 1 thenPush: (interpreterProxy floatObjectOf: (self sqrt: len))! Item was changed: ----- Method: FloatArrayPlugin>>primitiveSum (in category 'arithmetic primitives') ----- primitiveSum "Primitive. Find the sum of each float in the receiver, a FloatArray, and stash the result into the argument Float." | rcvr rcvrPtr length sum | <export: true> <var: #sum type: #double> <var: #rcvrPtr type: #'float *'> rcvr := interpreterProxy stackValue: 0. (interpreterProxy isWords: rcvr) ifFalse: [^interpreterProxy primitiveFail]. length := interpreterProxy stSizeOf: rcvr. rcvrPtr := self cCoerce: (interpreterProxy firstIndexableField: rcvr) to: #'float *'. sum := 0.0. 0 to: length-1 do:[:i| sum := sum + (self cCoerce: (rcvrPtr at: i) to: #double). ]. + interpreterProxy methodReturnFloat: sum! - interpreterProxy pop: 1 thenPush: (interpreterProxy floatObjectOf: sum)! Item was changed: ----- Method: FloatMathPlugin>>primitiveTimesTwoPower (in category 'float primitives') ----- primitiveTimesTwoPower "Multiply the receiver by the power of the argument." | rcvr arg result | <export: true> <var: #rcvr type: #double> <var: #result type: #double> arg := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackFloatValue: 1. interpreterProxy failed ifTrue: [^nil]. interpreterProxy bytesPerOop > 4 ifTrue: [| twiceMaxExponent | "clip arg to at most int range; ldexp's last arg is of type int" twiceMaxExponent := 2 * (1 << self floatExponentBits). arg < twiceMaxExponent negated ifTrue: [arg := twiceMaxExponent negated] ifFalse: [arg > twiceMaxExponent ifTrue: [arg := twiceMaxExponent]]]. result := self cCode: '__ieee754_ldexp(rcvr, (int)arg)' inSmalltalk: [rcvr timesTwoPower: arg]. (self isnan: result) ifFalse: + [interpreterProxy methodReturnFloat: result]. - [interpreterProxy methodReturnValue: (interpreterProxy floatObjectOf: result)]. ^nil! Item was changed: ----- Method: InterpreterProxy>>floatArg: (in category 'stack access') ----- floatArg: offset "Like #stackFloatValue: but access method arguments left-to-right" + "Obsolete; was never used; replaced with methodReturnString: in the VirtualMachine struct." | oop | + <returnTypeC: #double> + self deprecated. - <returnTypeC: 'double'> oop := self methodArg: offset. (self isFloatObject: oop) ifFalse: [self primitiveFail. ^0.0]. ^oop! Item was changed: ----- Method: InterpreterProxy>>floatObjectOf: (in category 'converting') ----- floatObjectOf: aFloat <returnTypeC: #sqInt> "...because answering the float argument causes the type inferencer to say this answers a float." + <var: #aFloat type: #double> + aFloat isFloat ifFalse: [self error:'Not a float object']. - <var: #aFloat type: 'double '> - aFloat isFloat ifFalse:[self error:'Not a float object']. ^aFloat! Item was changed: ----- Method: InterpreterProxy>>integerArg: (in category 'stack access') ----- integerArg: offset "Like #stackIntegerValue: but access method arguments left-to-right" + "Obsolete; was never used; replaced with methodReturnInteger: in the VirtualMachine struct." | oop | + self deprecated. oop := self methodArg: offset. (self isIntegerObject: oop) ifFalse: [self primitiveFail. ^0]. ^oop! Item was changed: ----- Method: InterpreterProxy>>methodArg: (in category 'stack access') ----- methodArg: offset "Like #stackValue: but access method arguments left-to-right" + "Obsolete; was never used; replaced with methodReturnBool: in the VirtualMachine struct." + self deprecated. offset > argumentCount + 1 ifTrue:[^self primitiveFail]. ^self stackValue: argumentCount - offset! Item was added: + ----- Method: InterpreterProxy>>methodReturnBool: (in category 'stack access') ----- + methodReturnBool: boolean + "Sets the return value for a method" + self pop: argumentCount+1 thenPushBool: boolean. + ^0! Item was added: + ----- Method: InterpreterProxy>>methodReturnFloat: (in category 'stack access') ----- + methodReturnFloat: aFloat + "Sets the return value for a method" + <var: 'aFloat' type: #double> + self pop: argumentCount+1 thenPushFloat: aFloat. + ^0! Item was added: + ----- Method: InterpreterProxy>>methodReturnInteger: (in category 'stack access') ----- + methodReturnInteger: integer + "Sets the return value for a method" + self pop: argumentCount+1 thenPushInteger: integer. + ^0! Item was added: + ----- Method: InterpreterProxy>>methodReturnString: (in category 'stack access') ----- + methodReturnString: aCString + "Sets the return value for a method" + <var: 'aCString' type: #'char *'> + self pop: argumentCount+1 thenPush: (self stringForCString: aCString). + ^0! Item was changed: ----- Method: InterpreterProxy>>objectArg: (in category 'stack access') ----- objectArg: offset "Like #stackObjectValue: but access method arguments left-to-right" + "Obsolete; was never used; replaced with methodReturnFloat: in the VirtualMachine struct." | oop | + self deprecated. oop := self methodArg: offset. + (self isImmediate: oop) ifTrue: [self primitiveFail. ^ nil]. - (self isIntegerObject: oop) ifTrue: [self primitiveFail. ^ nil]. ^oop! Item was added: + ----- Method: InterpreterProxy>>pop:thenPushBool: (in category 'private') ----- + pop: nItems thenPushBool: boolean + <returnTypeC: #sqInt> + self pop: nItems. + self push: (boolean ifTrue: [self trueObject] ifFalse: [self falseObject])! Item was added: + ----- Method: InterpreterProxy>>pop:thenPushFloat: (in category 'private') ----- + pop: nItems thenPushFloat: float + <var: #float type: #double> + <returnTypeC: #sqInt> + self pop: nItems. + self push: (self floatObjectOf: float)! Item was added: + ----- Method: InterpreterProxy>>pop:thenPushInteger: (in category 'private') ----- + pop: nItems thenPushInteger: integer + <returnTypeC: #sqInt> + self pop: nItems. + self push: (self integerObjectOf: integer)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompareString (in category 'primitives') ----- primitiveCompareString "ByteString (class) compare: string1 with: string2 collated: order" <export: true> | len1 len2 order string1 string2 | <var: 'order' type: #'unsigned char *'> <var: 'string1' type: #'unsigned char *'> <var: 'string2' type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 2)]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. string1 := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). string2 := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). order := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). len1 := interpreterProxy sizeOfSTArrayFromCPrimitive: string1. len2 := interpreterProxy sizeOfSTArrayFromCPrimitive: string2. (interpreterProxy sizeOfSTArrayFromCPrimitive: order) < 256 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. 0 to: (len1 min: len2) - 1 do: [ :i | | c1 c2 | c1 := order at: (string1 at: i). c2 := order at: (string2 at: i). c1 = c2 ifFalse: + [^interpreterProxy methodReturnInteger: (c1 < c2 ifTrue: [1] ifFalse: [3])]]. + interpreterProxy methodReturnInteger: + (len1 = len2 ifTrue: [2] ifFalse: [len1 < len2 ifTrue: [1] ifFalse: [3]])! - [^interpreterProxy methodReturnValue: - (interpreterProxy integerObjectOf: - (c1 < c2 ifTrue: [1] ifFalse: [3]))]]. - interpreterProxy methodReturnValue: - (interpreterProxy integerObjectOf: - (len1 = len2 ifTrue: [2] ifFalse: [len1 < len2 ifTrue: [1] ifFalse: [3]]))! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompressToByteArray (in category 'primitives') ----- primitiveCompressToByteArray "Bitmap compress: bm toByteArray: ba" <export: true> | bm ba eqBytes i j k lowByte size destSize word | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)) to: #'int *']. interpreterProxy failed ifTrue: [^nil]. (interpreterProxy isBytes: (interpreterProxy stackValue: 0)) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 0)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). size := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. destSize := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. destSize < ((size * 4) + 7 + (size // 1984 * 3)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrUnsupported]. "Size may be OK but we don't know, hence fail with unsupported" i := self encodeInt: size in: ba at: 0. k := 0. [k < size] whileTrue: [word := bm at: k. lowByte := word bitAnd: 255. eqBytes := (word >> 8 bitAnd: 255) = lowByte and: [(word >> 16 bitAnd: 255) = lowByte and: [(word >> 24 bitAnd: 255) = lowByte]]. j := k. [j + 1 < size and: [word = (bm at: j + 1)]] whileTrue: [j := j + 1]. j > k ifTrue: [eqBytes ifTrue: [i := self encodeInt: j - k + 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1] ifFalse: [i := self encodeInt: j - k + 1 * 4 + 2 in: ba at: i. i := self encodeBytesOf: word in: ba at: i]. k := j + 1] ifFalse: [eqBytes ifTrue: [i := self encodeInt: 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1. k := k + 1] ifFalse: [[j + 1 < size and: [(bm at: j) ~= (bm at: j + 1)]] whileTrue: [j := j + 1]. j + 1 = size ifTrue: [j := j + 1]. i := self encodeInt: j - k * 4 + 3 in: ba at: i. k to: j - 1 by: 1 do: [ :m | i := self encodeBytesOf: (bm at: m) in: ba at: i]. k := j]]]. + interpreterProxy methodReturnInteger: i! - interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: i)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindFirstInString (in category 'primitives') ----- primitiveFindFirstInString "ByteString (class) findFirstInString: aString inSet: inclusionMap startingAt: start" <export: true> | aString i inclusionMap start stringSize | <var: 'aString' type: #'unsigned char *'> <var: 'inclusionMap' type: #'char *'> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 2)]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). inclusionMap := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0). (interpreterProxy sizeOfSTArrayFromCPrimitive: inclusionMap) ~= 256 ifTrue: + [^interpreterProxy methodReturnInteger: 0]. - [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)]. i := start - 1. stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. [i < stringSize and: [(inclusionMap at: (aString at: i)) = 0]] whileTrue: [i := i + 1]. + interpreterProxy methodReturnInteger: (i >= stringSize ifTrue: [0] ifFalse: [i + 1])! - interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: (i >= stringSize ifTrue: [0] ifFalse: [i + 1]))! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindSubstring (in category 'primitives') ----- primitiveFindSubstring "ByteString findSubstring: key in: body startingAt: start matchTable: matchTable" <export: true> | body key keySize matchTable start | <var: #key type: #'unsigned char *'> <var: #body type: #'unsigned char *'> <var: #matchTable type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 1)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 2)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 3)]]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. key := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 3). body := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 1). matchTable := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). (keySize := interpreterProxy sizeOfSTArrayFromCPrimitive: key) > 0 ifTrue: [keySize := keySize - 1. "adjust for zero relative indxes" (start max: 1) to: (interpreterProxy sizeOfSTArrayFromCPrimitive: body) - keySize do: [ :startIndex | | index | index := 0. [(matchTable at: (body at: startIndex + index - 1)) = (matchTable at: (key at: index))] whileTrue: [index = keySize ifTrue: + [^interpreterProxy methodReturnInteger: startIndex]. - [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: startIndex)]. index := index + 1]]]. + ^interpreterProxy methodReturnInteger: 0! - ^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveIndexOfAsciiInString (in category 'primitives') ----- primitiveIndexOfAsciiInString "ByteString indexOfAscii: anInteger inString: aString startingAt: start" <export: true> | anInteger aString start stringSize | <var: #aString type: #'unsigned char *'> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) and: [(start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0)) >= 1 and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 2))]]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. anInteger := interpreterProxy integerValueOf: (interpreterProxy stackValue: 2). aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. start - 1 to: stringSize - 1 do: [ :pos | (aString at: pos) = anInteger ifTrue: + [^interpreterProxy methodReturnInteger: pos + 1]]. + ^interpreterProxy methodReturnInteger: 0! - [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: pos + 1)]]. - ^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveStringHash (in category 'primitives') ----- primitiveStringHash "ByteArray (class) hashBytes: aByteArray startingWith: speciesHash" <export: true> | aByteArray speciesHash byteArraySize hash | <var: 'aByteArray' type: #'unsigned char *'> <var: 'speciesHash' type: #int> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 1)]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. aByteArray := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). speciesHash := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0). byteArraySize := interpreterProxy sizeOfSTArrayFromCPrimitive: aByteArray. hash := speciesHash bitAnd: 16r0FFFFFFF. 0 to: byteArraySize - 1 do: [ :pos | hash := hash + (aByteArray at: pos). hash := hash * 16r19660D bitAnd: 16r0FFFFFFF]. + interpreterProxy methodReturnInteger: hash! - interpreterProxy methodReturnValue: - (interpreterProxy integerObjectOf: hash)! Item was added: + ----- Method: NewCoObjectMemorySimulator>>methodReturnBool: (in category 'simulation only') ----- + methodReturnBool: boolean + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnBool: boolean! Item was added: + ----- Method: NewCoObjectMemorySimulator>>methodReturnFloat: (in category 'simulation only') ----- + methodReturnFloat: aFloat + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnFloat: aFloat! Item was added: + ----- Method: NewCoObjectMemorySimulator>>methodReturnInteger: (in category 'simulation only') ----- + methodReturnInteger: integer + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnInteger: integer! Item was added: + ----- Method: NewCoObjectMemorySimulator>>methodReturnString: (in category 'simulation only') ----- + methodReturnString: aCString + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnString: aCString! Item was added: + ----- Method: NewObjectMemorySimulator>>methodReturnBool: (in category 'simulation only') ----- + methodReturnBool: boolean + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnBool: boolean! Item was added: + ----- Method: NewObjectMemorySimulator>>methodReturnFloat: (in category 'simulation only') ----- + methodReturnFloat: aFloat + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnFloat: aFloat! Item was added: + ----- Method: NewObjectMemorySimulator>>methodReturnInteger: (in category 'simulation only') ----- + methodReturnInteger: integer + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnInteger: integer! Item was added: + ----- Method: NewObjectMemorySimulator>>methodReturnString: (in category 'simulation only') ----- + methodReturnString: aCString + "hack around the CoInterpreter/ObjectMemory split refactoring" + ^coInterpreter methodReturnString: aCString! Item was changed: ----- Method: ScratchPlugin>>primOpenPortNamed (in category 'serial port') ----- primOpenPortNamed "Open the port with the given name and baud rate." | nameStr src nameOop baudRate count portNum | <export: true> <var: 'nameStr' declareC: 'char nameStr[1000]'> <var: 'src' type: #'char *'> nameOop := interpreterProxy stackValue: 1. baudRate := interpreterProxy stackIntegerValue: 0. interpreterProxy success: (interpreterProxy isBytes: nameOop). interpreterProxy failed ifTrue: [^ 0]. src := self cCoerce: (interpreterProxy firstIndexableField: nameOop) to: #'char *'. count := interpreterProxy stSizeOf: nameOop. 0 to: count - 1 do: [:i | nameStr at: i put: (src at: i)]. nameStr at: count put: 0. portNum := self SerialPortOpen: nameStr PortNamed: baudRate. portNum = -1 ifTrue: [interpreterProxy success: false. ^ 0]. + ^interpreterProxy methodReturnInteger: portNum! - interpreterProxy "pop args and rcvr, push result" - pop: 3 - thenPush: (interpreterProxy integerObjectOf: portNum). - - ^ 0 - ! Item was changed: ----- Method: ScratchPlugin>>primPortCount (in category 'serial port') ----- primPortCount "Answer the number of serial ports." | result | <export: true> + result := self SerialPortCount. - result := self cCode: 'SerialPortCount()'. result = -1 ifTrue: [interpreterProxy success: false. ^ 0]. + ^interpreterProxy methodReturnInteger: result - interpreterProxy - pop: 1 thenPush: (interpreterProxy integerObjectOf: result). "pop rcvr, push result" - ^ 0 ! Item was added: + ----- Method: SpurMemoryManager>>methodReturnBool: (in category 'simulation only') ----- + methodReturnBool: boolean + "hack around the CoInterpreter/ObjectMemory split refactoring" + <doNotGenerate> + ^coInterpreter methodReturnBool: boolean! Item was added: + ----- Method: SpurMemoryManager>>methodReturnFloat: (in category 'simulation only') ----- + methodReturnFloat: aFloat + "hack around the CoInterpreter/ObjectMemory split refactoring" + <doNotGenerate> + ^coInterpreter methodReturnFloat: aFloat! Item was added: + ----- Method: SpurMemoryManager>>methodReturnInteger: (in category 'simulation only') ----- + methodReturnInteger: integer + "hack around the CoInterpreter/ObjectMemory split refactoring" + <doNotGenerate> + ^coInterpreter methodReturnInteger: integer! Item was added: + ----- Method: SpurMemoryManager>>methodReturnString: (in category 'simulation only') ----- + methodReturnString: aCString + "hack around the CoInterpreter/ObjectMemory split refactoring" + <doNotGenerate> + ^coInterpreter methodReturnString: aCString! Item was changed: ----- Method: StackInterpreter>>floatArg: (in category 'plugin primitive support') ----- floatArg: index "Like #stackFloatValue: but access method arguments left-to-right" - | oop | <returnTypeC: #double> + <doNotGenerate> "Obsolete; was never used; replaced with methodReturnString: in the VirtualMachine struct." + | oop | + self deprecated. oop := self methodArg: index. oop = 0 ifTrue:[^0.0]. "methodArg: failed" ^objectMemory floatValueOf: oop! Item was changed: ----- Method: StackInterpreter>>integerArg: (in category 'plugin primitive support') ----- integerArg: index "Like #stackIntegerValue: but access method arguments left-to-right" + <doNotGenerate> "Obsolete; was never used; replaced with methodReturnInteger: in the VirtualMachine struct." | oop | + self deprecated. oop := self methodArg: index. oop = 0 ifTrue:[^0]. "methodArg: failed" ^self checkedIntegerValueOf: oop! Item was changed: ----- Method: StackInterpreter>>methodArg: (in category 'plugin primitive support') ----- methodArg: index "Like #stackValue: but access method arguments left-to-right" + <doNotGenerate> "Obsolete; was never used; replaced with methodReturnBool: in the VirtualMachine struct." + self deprecated. + index > argumentCount + 1 ifTrue: + [self cCode: 'fprintf(stderr,"[VM]: Attempt to access method args beyond range\n")'. - index > argumentCount + 1 ifTrue:[ - self cCode: 'fprintf(stderr,"[VM]: Attempt to access method args beyond range\n")'. self printCallStack. self primitiveFail. ^0]. ^self stackValue: argumentCount - index! Item was added: + ----- Method: StackInterpreter>>methodReturnBool: (in category 'plugin primitive support') ----- + methodReturnBool: boolean + "Sets the return value for a method. In the CoInterpreter we replace the cumbersome + primResult machinery." + self pop: argumentCount+1 thenPushBool: boolean. + ^0! Item was added: + ----- Method: StackInterpreter>>methodReturnFloat: (in category 'plugin primitive support') ----- + methodReturnFloat: aFloat + "Sets the return value for a method." + <var: 'aFloat' type: #double> + self pop: argumentCount+1 thenPushFloat: aFloat. + ^0! Item was added: + ----- Method: StackInterpreter>>methodReturnInteger: (in category 'plugin primitive support') ----- + methodReturnInteger: integer + "Sets the return value for a method. In the CoInterpreter we replace the cumbersome + primResult machinery." + self pop: argumentCount+1 thenPushInteger: integer. + ^0! Item was added: + ----- Method: StackInterpreter>>methodReturnString: (in category 'plugin primitive support') ----- + methodReturnString: aCString + "Sets the return value for a method." + <var: 'aCString' type: #'char *'> + self pop: argumentCount+1 thenPush: (objectMemory stringForCString: aCString). + ^0! Item was changed: ----- Method: StackInterpreter>>objectArg: (in category 'plugin primitive support') ----- objectArg: index "Like #stackObjectValue: but access method arguments left-to-right" + <doNotGenerate> "Obsolete; was never used; replaced with methodReturnFloat: in the VirtualMachine struct." | oop | + self deprecated. oop := self methodArg: index. oop = 0 ifTrue:[^0]. "methodArg: failed" (objectMemory isImmediate: oop) ifTrue: [self primitiveFail. ^ nil]. ^oop! Item was changed: ----- Method: UnicodePlugin>>primitiveClipboardGet (in category 'primitives') ----- primitiveClipboardGet "Read the clipboard into the given UTF16 string.." | utf16Oop utf16 utf16Length count | <export: true> <var: 'utf16' type: #'unsigned short *'> utf16Oop := interpreterProxy stackValue: 0. interpreterProxy success: (interpreterProxy isWords: utf16Oop). interpreterProxy failed ifTrue: [^ 0]. utf16 := self cCoerce: (interpreterProxy firstIndexableField: utf16Oop) to: #'unsigned short *'. utf16Length := 2 * (interpreterProxy stSizeOf: utf16Oop). count := self unicodeClipboard: utf16 Get: utf16Length. + ^interpreterProxy methodReturnInteger: count! - interpreterProxy pop: 2 - thenPush: (interpreterProxy integerObjectOf: count). - - ^ 0! Item was changed: ----- Method: UnicodePlugin>>primitiveClipboardSize (in category 'primitives') ----- primitiveClipboardSize - | count | <export: true> + ^interpreterProxy methodReturnInteger: self unicodeClipboardSize! - - count := self cCode: 'unicodeClipboardSize()'. - - interpreterProxy pop: 1 - thenPush: (interpreterProxy integerObjectOf: count). - ^ 0 - ! Item was changed: ----- Method: UnicodePlugin>>primitiveGetFontList (in category 'primitives') ----- primitiveGetFontList + | strOop str strLength | - | strOop str strLength count | <export: true> <var: 'str' declareC: 'char *str'> strOop := interpreterProxy stackValue: 0. str := self asCString: strOop. + interpreterProxy failed ifFalse: + [strLength := interpreterProxy stSizeOf: strOop. + interpreterProxy methodReturnInteger: (self unicodeGetFont: str List: strLength)]! - interpreterProxy failed ifTrue: [^ nil]. - - strLength := interpreterProxy stSizeOf: strOop. - count := self cCode: 'unicodeGetFontList(str, strLength)'. - - interpreterProxy pop: 2 - thenPush: (interpreterProxy integerObjectOf: count). - ^ 0 - ! Item was changed: ----- Method: UnicodePlugin>>primitiveGetXRanges (in category 'primitives') ----- primitiveGetXRanges | utf8Oop utf8 resultOop resultPtr utf8Length count resultLength | <export: true> <var: 'utf8' declareC: 'char *utf8'> <var: 'resultPtr' declareC: 'int *resultPtr'> utf8Oop := interpreterProxy stackValue: 1. utf8 := self asCString: utf8Oop. resultOop := interpreterProxy stackValue: 0. resultPtr := self cWordsPtr: resultOop minSize: 0. interpreterProxy failed ifTrue: [^ nil]. utf8Length := interpreterProxy stSizeOf: utf8Oop. resultLength := interpreterProxy stSizeOf: resultOop. + count := self unicode: utf8 Get: utf8Length X: resultPtr Ranges: resultLength. - count := self cCode: 'unicodeGetXRanges(utf8, utf8Length, resultPtr, resultLength)'. + ^interpreterProxy methodReturnInteger: count! - interpreterProxy pop: 3 thenPush: (interpreterProxy integerObjectOf: count). - ^ 0 - !

1 0

Reproducible VM crash from commit 4749358 onwards
by Alistair Grant 16 Mar '18

16 Mar '18

Hi Everyone, If I download a recent Pharo 64 bit image, e.g.: http://files.pharo.org/image/70/latest-64.zip And use a Pharo VM from commit: commit 4749358b5717b9a2f7e1d44f9baac48ed5d80431 Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: Wed Mar 7 15:11:21 2018 -0800 or later, the following will reliably crash the VM: ./pharo Pharo7.0-64bit-a26248b.image eval "OCBytecodeGeneratorTest run: #testExample2" Earlier VMs don't crash. Stack dump below my signature. I'm a bit out of my depth beyond that... OS: Ubuntu 16.04 64 bit Cheers, Alistair Segmentation fault Thu Mar 15 22:39:13 2018 /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo Pharo VM version: 5.0-201803072311 Thursday 15 March 22:35:05 CET 2018 c99 [Production Spur 64-bit VM] Built from: CoInterpreter VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5 Mar 15 2018 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2347 uuid: 062614a7-e3da-4b30-997a-9568911b9ff5 Mar 15 2018 Revision: VM: 201803072311 alistair@59fbe1b42048:vmmaker/opensmalltalk-vm $ Date: Wed Mar 7 15:11:21 2018 -0800 $ Plugins: 201803072311 alistair@59fbe1b42048:vmmaker/opensmalltalk-vm $ Build host: Linux 59fbe1b42048 4.13.0-36-generic #40~16.04.1-Ubuntu SMP Fri Feb 16 23:25:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux plugin path: /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311 [default: /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/] C stack backtrace & registers: rax 0x13ab4880 rbx 0x13ab4710 rcx 0x13ab4938 rdx 0x13ab47c8 rdi 0x13ab44e8 rsi 0x13ab44e8 rbp 0x13ab4658 rsp 0x13ab49f0 r8 0x13ab3f28 r9 0x13ab3fe0 r10 0x13ab4098 r11 0x13ab4150 r12 0x13ab4208 r13 0x13ab42c0 r14 0x13ab4378 r15 0x13ab4430 rip 0x13ab4aa8 *[0x7ffd13ab4aa8] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo[0x41aca2] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo[0x41c87e] /lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7f78ad605390] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(lengthOf+0x0)[0x42aca0] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(cogselector+0x27)[0x49bf77] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo[0x45b15c] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo[0x45b444] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(interpret+0xb238)[0x469208] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo[0x46a4db] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(interpret+0x246)[0x45e216] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(main+0x2f8)[0x419f98] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f78acf41830] /home/alistair/vmmaker/opensmalltalk-vm/products/cogspur64linuxht/lib/pharo/5.0-201803072311/pharo(_start+0x29)[0x41a309] [0x0] Smalltalk stack dump: 0x7ffd13ad4550 I CompiledMethod>valueWithReceiver:arguments: 0x1d7e790: a(n) CompiledMethod 0x7ffd13ad45a0 M OCBytecodeGeneratorTest>testExample2 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad1ea0 I OCBytecodeGeneratorTest(TestCase)>performTest 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad1ed0 M [] in OCBytecodeGeneratorTest(TestCase)>runCase 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad1f10 M BlockClosure>ensure: 0x1d7a450: a(n) BlockClosure 0x7ffd13ad1f58 I OCBytecodeGeneratorTest(TestCase)>runCase 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad1f90 M [] in TestExecutionEnvironment>runTestCaseSafelly: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad1fc0 M BlockClosure>on:do: 0x1d7a330: a(n) BlockClosure 0x7ffd13ad2008 M [] in TestExecutionEnvironment>runTestCaseSafelly: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad2038 M BlockClosure>on:do: 0x1d7a1a8: a(n) BlockClosure 0x7ffd13ad2088 I TestExecutionEnvironment>runTestCaseSafelly: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad20c8 M [] in TestExecutionEnvironment>runTestCase: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad2108 M BlockClosure>ensure: 0x1d7a0a8: a(n) BlockClosure 0x7ffd13ad2148 M [] in TestExecutionEnvironment>runTestCase: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad2188 M BlockClosure>ifCurtailed: 0x1d79fa8: a(n) BlockClosure 0x7ffd13ad21d0 I TestExecutionEnvironment>runTestCase: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad2218 M [] in DefaultExecutionEnvironment>runTestCase: 0x23f7c30: a(n) DefaultExecutionEnvironment 0x7ffd13ad2258 M [] in CurrentExecutionEnvironment class>activate:for: 0x2404bf8: a(n) CurrentExecutionEnvironment class 0x7ffd13ad2298 M BlockClosure>ensure: 0x1d79280: a(n) BlockClosure 0x7ffd13ad22e8 I CurrentExecutionEnvironment class>activate:for: 0x2404bf8: a(n) CurrentExecutionEnvironment class 0x7ffd13ad2338 I TestExecutionEnvironment(ExecutionEnvironment)>beActiveDuring: 0x1d78f28: a(n) TestExecutionEnvironment 0x7ffd13ad2388 I DefaultExecutionEnvironment>runTestCase: 0x23f7c30: a(n) DefaultExecutionEnvironment 0x7ffd13ad23d0 I CurrentExecutionEnvironment class>runTestCase: 0x2404bf8: a(n) CurrentExecutionEnvironment class 0x7ffd13ad2418 I OCBytecodeGeneratorTest(TestCase)>runCaseManaged 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad2450 M [] in TestResult>runCase: 0x1d78930: a(n) TestResult 0x7ffd13ad2480 M BlockClosure>on:do: 0x1d78d50: a(n) BlockClosure 0x7ffd13ad24d0 I TestResult>runCase: 0x1d78930: a(n) TestResult 0x7ffd13ad2510 M [] in OCBytecodeGeneratorTest(TestCase)>run 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad2550 M BlockClosure>ensure: 0x1d78c50: a(n) BlockClosure 0x7ffd13ad25a0 I OCBytecodeGeneratorTest(TestCase)>run 0x1d78910: a(n) OCBytecodeGeneratorTest 0x7ffd13ad0100 I OCBytecodeGeneratorTest class(TestCase class)>run: 0x36155c8: a(n) OCBytecodeGeneratorTest class 0x7ffd13ad0138 M UndefinedObject>DoIt 0x23e78e0: a(n) UndefinedObject 0x7ffd13ad0198 I OpalCompiler>evaluate 0x1c76f90: a(n) OpalCompiler 0x7ffd13ad01d8 I OpalCompiler(AbstractCompiler)>evaluate: 0x1c76f90: a(n) OpalCompiler 0x7ffd13ad0220 M [] in EvaluateCommandLineHandler>evaluate: 0x1c770e8: a(n) EvaluateCommandLineHandler 0x7ffd13ad0250 M BlockClosure>on:do: 0x1c77118: a(n) BlockClosure 0x7ffd13ad02a8 I EvaluateCommandLineHandler>evaluate: 0x1c770e8: a(n) EvaluateCommandLineHandler 0x7ffd13ad02f8 I EvaluateCommandLineHandler>evaluateArguments 0x1c770e8: a(n) EvaluateCommandLineHandler 0x7ffd13ad0338 I EvaluateCommandLineHandler>activate 0x1c770e8: a(n) EvaluateCommandLineHandler 0x7ffd13ad0378 I EvaluateCommandLineHandler class(CommandLineHandler class)>activateWith: 0x252d400: a(n) EvaluateCommandLineHandler class 0x7ffd13ad03b8 M [] in PharoCommandLineHandler(BasicCommandLineHandler)>activateSubCommand: 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad03e8 M BlockClosure>on:do: 0x1c77390: a(n) BlockClosure 0x7ffd13ad0428 M PharoCommandLineHandler(BasicCommandLineHandler)>activateSubCommand: 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad0478 I PharoCommandLineHandler(BasicCommandLineHandler)>handleSubcommand 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad04b8 I PharoCommandLineHandler(BasicCommandLineHandler)>handleArgument: 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad04f0 M [] in PharoCommandLineHandler(BasicCommandLineHandler)>activate 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad0520 M BlockClosure>on:do: 0x1c77628: a(n) BlockClosure 0x7ffd13ad0560 M [] in PharoCommandLineHandler(BasicCommandLineHandler)>activate 0x55380b8: a(n) PharoCommandLineHandler 0x7ffd13ad05a0 I [] in BlockClosure>newProcess 0x1c77720: a(n) BlockClosure Most recent primitives stringHash:initialHash: basicNew successorSequences basicNew basicNew basicNew **StackOverflow** basicNew basicNew basicIdentityHash basicNew basicNew stringHash:initialHash: stringHash:initialHash: stringHash:initialHash: literal parameterAt: stringHash:initialHash: isInteger stringHash:initialHash: stringHash:initialHash: size findSubstring:in:startingAt:matchTable: indexOfAscii:inString:startingAt: indexOfAscii:inString:startingAt: stringHash:initialHash: stringHash:initialHash: * * size size copyWith: bitShift: bitShift: numTemps numTemps numTemps numTemps numTemps numTemps basicIdentityHash basicNew: size basicNew at:put: at:put: basicNew: stringHash:initialHash: compare:with:collated: perform: encodeNoTrailer encodeNoTrailer encodeNoTrailer encodeNoTrailer encodeNoTrailer encodeNoTrailer encodeNoTrailer at:put: at:put: at:put: at:put: basicNew size at:put: at:put: at:put: at:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: collect: basicNew bitAnd: **PrimitiveFailure** bitAnd: **PrimitiveFailure** bitOr: **PrimitiveFailure** bitOr: **PrimitiveFailure** bitClear: new: objectAt: at:put: objectAt: at:put: objectAt: at:put: objectAt: at:put: objectAt: at:put: objectAt:put: stringHash:initialHash: objectAt:put: withArgs:executeMethod: basicNew class basicNew primUTCMicrosecondsClock * **PrimitiveFailure** digitMultiply:neg: basicNew primOffset digitCompare: // \\ valueNoContextSwitch class class basicNew class class value class **StackOverflow** basicIdentityHash basicNew basicNew basicNew new: valueNoContextSwitch size new: size size at:put: basicNew: stackp: basicNew size at: at: at: at: psValueAt:put: psValueAt:put: psValueAt:put: psValueAt:put: psValueAt:put: primitiveResume repeat wait class millisecondClockValue basicNew signal primUTCMicrosecondsClock millisecondDelayDuration + primSignal:atUTCMicroseconds: wait wait class signal basicNew valueNoContextSwitch signal primUTCMicrosecondsClock at:put: at: at:put: primSignal:atUTCMicroseconds: wait wait valueNoContextSwitch wait ifCurtailed: basicNew value class valueNoContextSwitch perform: **StackOverflow** basicNew basicNew basicNew basicIdentityHash **StackOverflow** **StackOverflow** size indexOfAscii:inString:startingAt: at: at: at: basicIdentityHash value class linkTo: basicNew value basicIdentityHash stringHash:initialHash: stringHash:initialHash: size stringHash:initialHash: stringHash:initialHash: basicNew - class new: at:put: perform:withArguments: from:if:goto:otherwise: size size size at: ~= size at:put: basicNew: stringHash:initialHash: compare:with:collated: newMethod:header: at:put: at:put: at:put: at:put: basicNew size size size at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: from:if:goto:otherwise: from:if:goto:otherwise: from:if:goto:otherwise: objectAt:put: new: objectAt: at:put: objectAt: at:put: objectAt: at:put: objectAt: at:put: class @ withArgs:executeMethod: stack page bytes 8192 available headroom 5576 minimum unused headroom 6032 (Segmentation fault)

2 2

[OpenSmalltalk/opensmalltalk-vm] 2a6789: added immutability flag on Pharo ARM builds
by GitHub 16 Mar '18

16 Mar '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 2a67895d1c4b51cbfba77469c0c696b8b16cf104 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a67895d1c4b51cbfb… Author: clementbera <bera.clement(a)gmail.com> Date: 2018-03-16 (Fri, 16 Mar 2018) Changed paths: M build.linux32ARMv6/pharo.cog.spur/build.assert/mvm M build.linux32ARMv6/pharo.cog.spur/build.debug/mvm M build.linux32ARMv6/pharo.cog.spur/build/mvm Log Message: ----------- added immutability flag on Pharo ARM builds

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] MiscPrimitive plugin: plan for next 6 months (#177)
by Fabio Niephaus 16 Mar '18

16 Mar '18

@clementbera thanks! Are there any additional pointers to Sophie's contribution (e.g. commits or PRs)? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/177#issuecomment-3…

1 0

[OpenSmalltalk/opensmalltalk-vm] 572d12: Include the FileAttributesPlugin when making a VMM...
by GitHub 16 Mar '18

16 Mar '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 572d121f0d234b6881c44b27a74e114b037bedba https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/572d121f0d234b6881… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-03-15 (Thu, 15 Mar 2018) Changed paths: M image/BuildSqueakSpurTrunkVMMakerImage.st Log Message: ----------- Include the FileAttributesPlugin when making a VMMaker image. Provide a Source generation workspace. Commit: 43a2f5c9fe9ea25905cfde7ca7f280ddde73babf https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/43a2f5c9fe9ea25905… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-03-15 (Thu, 15 Mar 2018) Changed paths: A image/Source Generation Workspace.text Log Message: ----------- Rememer to add the workspace. Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1f0a7da9d4e8...43…

1 0

[OpenSmalltalk/opensmalltalk-vm] 1f0a7d: CogVM source as per VMMaker.oscog-eem.2359
by GitHub 16 Mar '18

16 Mar '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1f0a7da9d4e8dcf4cdfac07014decdadac6937bb https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1f0a7da9d4e8dcf4cd… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2018-03-15 (Thu, 15 Mar 2018) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/SerialPlugin/SerialPlugin.c M src/plugins/Win32OSProcessPlugin/Win32OSProcessPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2359 Cogits: Fix regression introduced in VMMaker.oscog-eem.2333 or thereabouts when improving comoilation breakpoint. maybeSelectorOfMethod can answer nil so a guard is needed. Fix ceSend:aboveClassBinding:to:numArgs:, which forgot to indirect through the binding before sending ceSend:above:to:numArgs:. Sista Cogit: This commit: - extends the Sista instruction set (new conditional jumps on mutability, age, backjump without interrupt points, new inlined arithmetics, inlined allocation up to 65k supported, possibleRoot, etc.) both in the interpreter and the JIT - all the interpreter version are now filled with many assertions, so it is now possible to compile a StackVM with SistaVM option and debug easily the optimized code using the assertions. - refactors a bit all inline primitives (Since now there is many) - reworked a bit the bytecode set so all bytecodes except traps, mappedInlinedPrimitive and callPrimitive are normal Smalltalk bytecodes while the 3 bytecodes mentioned are different in the Sista VM. That way it is easier to know what to implement to support the full image without having to implement the whole sista extensions. Decreases by 1 the number of instructions for byte reads on constants. Plugins: Fix several (ancient) issues with the MiscPrimitivePlugin primitives, identified by Levente. Try and make all failures supply an error code. Tidy up FilePlugin error checking and use of symbols for declaring variable types in: - #fileValueOf: - #pointerFrom: - #primitiveConnectToFile - #primitiveConnectToFileDescriptor Restored SerialPlugin's *byName* primitives on non-PharoVM VMs.

1 0

VM Maker: VMMaker.oscog-eem.2359.mcz
by commits＠source.squeak.org 16 Mar '18

16 Mar '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2359.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2359 Author: eem Time: 15 March 2018, 4:58:47.365471 pm UUID: b3273e3e-dd9d-4819-a928-7034e1cf412c Ancestors: VMMaker.oscog-eem.2358 Oops! Fixed one I missed. =============== Diff against VMMaker.oscog-eem.2358 =============== Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveTranslateStringWithTable (in category 'primitives') ----- primitiveTranslateStringWithTable "ByteString (class) translate: aString from: start to: stop table: table" <export: true> | aString start stop table | <var: #table type: #'unsigned char *'> <var: #aString type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 1)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 2)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 3)]]]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 3)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 3). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 2). stop := interpreterProxy integerValueOf: (interpreterProxy stackValue: 1). table := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). (start >= 1 and: [stop <= (interpreterProxy sizeOfSTArrayFromCPrimitive: aString)]) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. + (interpreterProxy sizeOfSTArrayFromCPrimitive: table) < 256 ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. start - 1 to: stop - 1 do: [ :i | aString at: i put: (table at: (aString at: i))]. interpreterProxy pop: interpreterProxy methodArgumentCount!

1 0

VM Maker: VMMaker.oscog-eem.2358.mcz
by commits＠source.squeak.org 16 Mar '18

16 Mar '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2358.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2358 Author: eem Time: 15 March 2018, 4:52:58.814066 pm UUID: 0bbd7cdd-4737-4c94-91a2-4acb4016c2e7 Ancestors: VMMaker.oscog-eem.2357 Fix several (ancient) issues with the MiscPrimitivePlugin primitives, identified by Levente. Try and make all failures supply an error code. =============== Diff against VMMaker.oscog-eem.2357 =============== Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompareString (in category 'primitives') ----- primitiveCompareString "ByteString (class) compare: string1 with: string2 collated: order" <export: true> | len1 len2 order string1 string2 | <var: 'order' type: #'unsigned char *'> <var: 'string1' type: #'unsigned char *'> <var: 'string2' type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 2)]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. string1 := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). string2 := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). order := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). len1 := interpreterProxy sizeOfSTArrayFromCPrimitive: string1. len2 := interpreterProxy sizeOfSTArrayFromCPrimitive: string2. + (interpreterProxy sizeOfSTArrayFromCPrimitive: order) < 256 ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. 0 to: (len1 min: len2) - 1 do: [ :i | | c1 c2 | c1 := order at: (string1 at: i). c2 := order at: (string2 at: i). c1 = c2 ifFalse: [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: (c1 < c2 ifTrue: [1] ifFalse: [3]))]]. interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: (len1 = len2 ifTrue: [2] ifFalse: [len1 < len2 ifTrue: [1] ifFalse: [3]]))! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveCompressToByteArray (in category 'primitives') ----- primitiveCompressToByteArray "Bitmap compress: bm toByteArray: ba" <export: true> + | bm ba eqBytes i j k lowByte size destSize word | - | bm ba eqBytes i j k lowByte size word | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 1)) to: #'int *']. interpreterProxy failed ifTrue: [^nil]. + (interpreterProxy isBytes: (interpreterProxy stackValue: 0)) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - (interpreterProxy isBytes: (interpreterProxy stackValue: 0)) ifFalse: [^interpreterProxy primitiveFail]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 0)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). size := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. + destSize := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. + destSize < ((size * 4) + 7 + (size // 1984 * 3)) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrUnsupported]. "Size may be OK but we don't know, hence fail with unsupported" i := self encodeInt: size in: ba at: 0. k := 0. [k < size] whileTrue: [word := bm at: k. lowByte := word bitAnd: 255. eqBytes := (word >> 8 bitAnd: 255) = lowByte and: [(word >> 16 bitAnd: 255) = lowByte and: [(word >> 24 bitAnd: 255) = lowByte]]. j := k. [j + 1 < size and: [word = (bm at: j + 1)]] whileTrue: [j := j + 1]. j > k ifTrue: [eqBytes ifTrue: [i := self encodeInt: j - k + 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1] ifFalse: [i := self encodeInt: j - k + 1 * 4 + 2 in: ba at: i. i := self encodeBytesOf: word in: ba at: i]. k := j + 1] ifFalse: [eqBytes ifTrue: [i := self encodeInt: 1 * 4 + 1 in: ba at: i. ba at: i put: lowByte. i := i + 1. k := k + 1] ifFalse: [[j + 1 < size and: [(bm at: j) ~= (bm at: j + 1)]] whileTrue: [j := j + 1]. j + 1 = size ifTrue: [j := j + 1]. i := self encodeInt: j - k * 4 + 3 in: ba at: i. k to: j - 1 by: 1 do: [ :m | i := self encodeBytesOf: (bm at: m) in: ba at: i]. k := j]]]. interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: i)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveConvert8BitSigned (in category 'primitives') ----- primitiveConvert8BitSigned "SampledSound (class) convert8bitSignedFrom: aByteArray to16Bit: aSoundBuffer" <export: true> | aByteArray aSoundBuffer arraySize | <var: 'aByteArray' type: #'unsigned char *'> <var: 'aSoundBuffer' type: #'unsigned short *'> (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. aByteArray := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). aSoundBuffer := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 0)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 0)) to: #'unsigned short *']. interpreterProxy failed ifTrue: [^nil]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 0)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. arraySize := interpreterProxy sizeOfSTArrayFromCPrimitive: aByteArray. (interpreterProxy byteSizeOf: (interpreterProxy stackValue: 0)) < (2 * arraySize) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. 0 to: arraySize - 1 do: [ :i | | s | s := aByteArray at: i. aSoundBuffer at: i put: (s > 127 ifTrue: [s - 256 bitShift: 8] ifFalse: [s bitShift: 8])]. interpreterProxy pop: interpreterProxy methodArgumentCount! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveDecompressFromByteArray (in category 'primitives') ----- primitiveDecompressFromByteArray "Bitmap decompress: bm fromByteArray: ba at: index" <export: true> | bm ba index i anInt code data end k n pastEnd | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> <var: 'anInt' type: #'unsigned int'> <var: 'code' type: #'unsigned int'> <var: 'data' type: #'unsigned int'> <var: 'n' type: #'unsigned int'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)) to: #'int *']. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 2)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. + (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: [^interpreterProxy primitiveFail]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). index := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue: [^nil]. i := index - 1. k := 0. end := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. pastEnd := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. [i < end] whileTrue: [anInt := ba at: i. i := i + 1. anInt <= 223 ifFalse: [anInt <= 254 ifTrue: [anInt := anInt - 224 * 256 + (ba at: i). i := i + 1] ifFalse: [anInt := 0. 1 to: 4 by: 1 do: [ :j | anInt := (anInt bitShift: 8) + (ba at: i). i := i + 1]]]. n := anInt >> 2. + k + n > pastEnd ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. - k + n > pastEnd ifTrue: [^interpreterProxy primitiveFail]. code := anInt bitAnd: 3. "code = 0 ifTrue: [nil]." code = 1 ifTrue: [data := ba at: i. i := i + 1. data := data bitOr: (data bitShift: 8). data := data bitOr: (data bitShift: 16). 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 2 ifTrue: [data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 3 ifTrue: [1 to: n do: [ :m | data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. bm at: k put: data. k := k + 1]]]. interpreterProxy pop: interpreterProxy methodArgumentCount! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindFirstInString (in category 'primitives') ----- primitiveFindFirstInString "ByteString (class) findFirstInString: aString inSet: inclusionMap startingAt: start" <export: true> | aString i inclusionMap start stringSize | <var: 'aString' type: #'unsigned char *'> <var: 'inclusionMap' type: #'char *'> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 2)]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). inclusionMap := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0). (interpreterProxy sizeOfSTArrayFromCPrimitive: inclusionMap) ~= 256 ifTrue: [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)]. i := start - 1. stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. [i < stringSize and: [(inclusionMap at: (aString at: i)) = 0]] whileTrue: [i := i + 1]. interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: (i >= stringSize ifTrue: [0] ifFalse: [i + 1]))! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveFindSubstring (in category 'primitives') ----- primitiveFindSubstring "ByteString findSubstring: key in: body startingAt: start matchTable: matchTable" <export: true> | body key keySize matchTable start | <var: #key type: #'unsigned char *'> <var: #body type: #'unsigned char *'> <var: #matchTable type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 1)) and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 2)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 3)]]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. key := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 3). body := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 2). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 1). matchTable := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). (keySize := interpreterProxy sizeOfSTArrayFromCPrimitive: key) > 0 ifTrue: [keySize := keySize - 1. "adjust for zero relative indxes" (start max: 1) to: (interpreterProxy sizeOfSTArrayFromCPrimitive: body) - keySize do: [ :startIndex | | index | index := 0. [(matchTable at: (body at: startIndex + index - 1)) = (matchTable at: (key at: index))] whileTrue: [index = keySize ifTrue: [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: startIndex)]. index := index + 1]]]. ^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveIndexOfAsciiInString (in category 'primitives') ----- primitiveIndexOfAsciiInString "ByteString indexOfAscii: anInteger inString: aString startingAt: start" <export: true> | anInteger aString start stringSize | <var: #aString type: #'unsigned char *'> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) + and: [(start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0)) >= 1 and: [(interpreterProxy isBytes: (interpreterProxy stackValue: 1)) + and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 2))]]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 2))]]) ifFalse: - [^interpreterProxy primitiveFail]. anInteger := interpreterProxy integerValueOf: (interpreterProxy stackValue: 2). aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). - start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0). stringSize := interpreterProxy sizeOfSTArrayFromCPrimitive: aString. start - 1 to: stringSize - 1 do: [ :pos | (aString at: pos) = anInteger ifTrue: [^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: pos + 1)]]. ^interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: 0)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveStringHash (in category 'primitives') ----- primitiveStringHash "ByteArray (class) hashBytes: aByteArray startingWith: speciesHash" <export: true> | aByteArray speciesHash byteArraySize hash | <var: 'aByteArray' type: #'unsigned char *'> <var: 'speciesHash' type: #int> ((interpreterProxy isIntegerObject: (interpreterProxy stackValue: 0)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 1)]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. aByteArray := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). speciesHash := interpreterProxy integerValueOf: (interpreterProxy stackValue: 0). byteArraySize := interpreterProxy sizeOfSTArrayFromCPrimitive: aByteArray. hash := speciesHash bitAnd: 16r0FFFFFFF. 0 to: byteArraySize - 1 do: [ :pos | hash := hash + (aByteArray at: pos). hash := hash * 16r19660D bitAnd: 16r0FFFFFFF]. interpreterProxy methodReturnValue: (interpreterProxy integerObjectOf: hash)! Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveTranslateStringWithTable (in category 'primitives') ----- primitiveTranslateStringWithTable "ByteString (class) translate: aString from: start to: stop table: table" <export: true> | aString start stop table | <var: #table type: #'unsigned char *'> <var: #aString type: #'unsigned char *'> ((interpreterProxy isBytes: (interpreterProxy stackValue: 0)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 1)) and: [(interpreterProxy isIntegerObject: (interpreterProxy stackValue: 2)) and: [interpreterProxy isBytes: (interpreterProxy stackValue: 3)]]]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. - [^interpreterProxy primitiveFail]. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 3)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. aString := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 3). start := interpreterProxy integerValueOf: (interpreterProxy stackValue: 2). stop := interpreterProxy integerValueOf: (interpreterProxy stackValue: 1). table := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 0). + (start >= 1 and: [stop <= (interpreterProxy sizeOfSTArrayFromCPrimitive: aString)]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadIndex]. start - 1 to: stop - 1 do: [ :i | aString at: i put: (table at: (aString at: i))]. interpreterProxy pop: interpreterProxy methodArgumentCount!

1 0

VM Maker: VMMaker.oscog-eem.2357.mcz
by commits＠source.squeak.org 16 Mar '18

16 Mar '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2357.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2357 Author: eem Time: 15 March 2018, 4:10:33.968265 pm UUID: 884a7b42-b594-4b54-844a-58a5cec1dd36 Ancestors: VMMaker.oscog-cb.2356 Fix regression introduced in VMMaker.oscog-eem.2333 or thereabouts when improving comoilation breakpoint. maybeSelectorOfMethod can answer nil so a guard is needed. =============== Diff against VMMaker.oscog-cb.2356 =============== Item was changed: ----- Method: Cogit>>cog:selector: (in category 'jit - api') ----- cog: aMethodObj selector: aSelectorOop "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <returnTypeC: #'CogMethod *'> | selector cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj selector: aSelectorOop) ifTrue: [^nil]. "In Newspeak we support anonymous accessors and hence tolerate the same method being cogged multiple times. But only if the method class association is nil." NewspeakVM ifTrue: [(coInterpreter methodHasCogMethod: aMethodObj) ifTrue: [cogMethod := coInterpreter cogMethodOf: aMethodObj. self deny: cogMethod selector = aSelectorOop. cogMethod selector = aSelectorOop ifTrue: [^cogMethod]. (coInterpreter methodClassAssociationOf: aMethodObj) ~= objectMemory nilObject ifTrue: [self cCode: 'extern void *firstIndexableField(sqInt)'. "Slang, au natural" self warnMultiple: cogMethod selectors: aSelectorOop. ^nil]]] ifFalse: [self deny: (coInterpreter methodHasCogMethod: aMethodObj)]. self deny: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). selector := aSelectorOop = objectMemory nilObject ifTrue: [coInterpreter maybeSelectorOfMethod: aMethodObj] ifFalse: [aSelectorOop]. "coInterpreter stringOf: selector" + selector ifNotNil: + [coInterpreter + compilationBreak: selector + point: (objectMemory lengthOf: selector) + isMNUCase: false]. - coInterpreter - compilationBreak: selector - point: (objectMemory lengthOf: selector) - isMNUCase: false. aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. NewspeakVM ifTrue: [cogMethod := methodZone findPreviouslyCompiledVersionOf: aMethodObj with: aSelectorOop. cogMethod ifNotNil: [(coInterpreter methodHasCogMethod: aMethodObj) not ifTrue: [self assert: (coInterpreter rawHeaderOf: aMethodObj) = cogMethod methodHeader. cogMethod methodObject: aMethodObj. coInterpreter rawHeaderOf: aMethodObj put: cogMethod asInteger]. ^cogMethod]]. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := objectMemory receiverTagBitsForMethod: methodObj. cogMethod := self compileCogMethod: aSelectorOop. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2018