Vm-dev March 2018

vm-dev@lists.squeakfoundation.org

46 participants
218 discussions

VM Maker: VMMaker.oscog-akg.2341.mcz
by commits＠source.squeak.org 03 Mar '18

03 Mar '18

Alistair Grant uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-akg.2341.mcz ==================== Summary ==================== Name: VMMaker.oscog-akg.2341 Author: akg Time: 3 March 2018, 7:17:10.187325 pm UUID: d0fa56c5-cccb-41b4-b28d-4c54c9acdccf Ancestors: VMMaker.oscog-akg.2340 Include FilePlugin>>primitiveFileOpenUseFileDescriptor & primitiveFileOpenUseFile on all platforms (not just PharoVM). =============== Diff against VMMaker.oscog-akg.2340 =============== Item was changed: + ----- Method: FilePlugin>>cfileRecordSize (in category 'private') ----- - ----- Method: FilePlugin>>cfileRecordSize (in category 'pharo primitives') ----- cfileRecordSize "Return the size of a stdio FILE* handle" <inline: #always> ^self sizeof: #'FILE*'! Item was changed: + ----- Method: FilePlugin>>fileOpenFd:write: (in category 'private') ----- - ----- Method: FilePlugin>>fileOpenFd:write: (in category 'private - pharo') ----- fileOpenFd: fd write: writeFlag "Open the fd as file. Answer the file oop." | file fileOop | - <option: #PharoVM> <var: #file type: 'SQFile *'> <var: 'fd' type: 'int'> <export: true> fileOop := interpreterProxy instantiateClass: interpreterProxy classByteArray indexableSize: self fileRecordSize. file := self fileValueOf: fileOop. interpreterProxy failed ifFalse: [self cCode: 'sqFileFdOpen(file, fd, writeFlag)' inSmalltalk: [file]]. ^ fileOop! Item was changed: + ----- Method: FilePlugin>>fileOpenFile:write: (in category 'private') ----- - ----- Method: FilePlugin>>fileOpenFile:write: (in category 'private - pharo') ----- fileOpenFile: cfile write: writeFlag "Open the FILE* as file. Answer the file oop." | file fileOop | - <option: #PharoVM> <var: #file type: 'SQFile *'> <var: 'cfile' type: 'FILE *'> <export: true> fileOop := interpreterProxy instantiateClass: interpreterProxy classByteArray indexableSize: self fileRecordSize. file := self fileValueOf: fileOop. interpreterProxy failed ifFalse: [self cCode: 'sqFileFileOpen(file, cfile, writeFlag)' inSmalltalk: [file]]. ^ fileOop! Item was changed: + ----- Method: FilePlugin>>primitiveFileOpenUseFile (in category 'file primitives') ----- - ----- Method: FilePlugin>>primitiveFileOpenUseFile (in category 'pharo primitives') ----- primitiveFileOpenUseFile + "Open the file with the supplied FILE* and writeFlag. + FILE* must be supplied in a byte object (ByteArray) with the platform address size. + writeFlag must be a boolean." | writeFlag cfileOop cfile filePointer | - <option: #PharoVM> <var: 'cfile' type: 'FILE* '> <export: true> writeFlag := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). cfileOop := interpreterProxy stackValue: 1. (((interpreterProxy isBytes: cfileOop) and: [(interpreterProxy byteSizeOf: cfileOop) = self cfileRecordSize])) ifFalse: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. cfile := interpreterProxy firstIndexableField: cfileOop. interpreterProxy failed ifFalse: [filePointer := self fileOpenFile: cfile write: writeFlag]. interpreterProxy failed ifFalse: [^interpreterProxy pop: 3 "rcvr, name, writeFlag" thenPush: filePointer]. ^interpreterProxy primitiveFail.! Item was changed: + ----- Method: FilePlugin>>primitiveFileOpenUseFileDescriptor (in category 'file primitives') ----- - ----- Method: FilePlugin>>primitiveFileOpenUseFileDescriptor (in category 'pharo primitives') ----- primitiveFileOpenUseFileDescriptor + "Open the file with the supplied file descriptor and writeFlag. + fileDescriptor must be an integer. + writeFlag must be a boolean." | writeFlag fdPointer fd filePointer | - <option: #PharoVM> <var: 'fd' type: 'int'> <export: true> writeFlag := interpreterProxy booleanValueOf: (interpreterProxy stackValue: 0). fdPointer := interpreterProxy stackValue: 1. (interpreterProxy isIntegerObject: fdPointer) ifFalse: [^ interpreterProxy primitiveFailFor: PrimErrBadArgument]. fd := interpreterProxy integerValueOf: fdPointer. filePointer := self fileOpenFd: fd write: writeFlag. interpreterProxy failed ifFalse: [^interpreterProxy pop: 3 "rcvr, name, writeFlag" thenPush: filePointer]. ^interpreterProxy primitiveFail.!

1 0

[OpenSmalltalk/opensmalltalk-vm] 21462 open a file stream based on fd or file (#222)
by akgrant43 03 Mar '18

03 Mar '18

Extend FilePlugin to allow a file to be opened using either the file descriptor (fd) or FILE* in Pharo. Original PR: https://github.com/pharo-project/pharo-vm/pull/108 Updated PR: https://github.com/pharo-project/pharo-vm/pull/142 (both superseeded) As a (redundant) example of how this can be used, to open stderr (fd=2) for writing: | stderr | stderr := BinaryFileStream handle: (FilePluginPrims new openFileDescriptor: 2 writable: true) file: (File named: 'fd2') forWrite: true stderr nextPutAll: 'Hello World'; lf. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/222 -- Commit Summary -- * 21462-Open a FileStream based on fd or FILE* * 21462-Open-a-FileStream-based-on-fd-or-FILE -- File Changes -- M platforms/Cross/plugins/FilePlugin/FilePlugin.h (5) M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c (35) M src/plugins/FilePlugin/FilePlugin.c (153) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/222.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/222.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/222

1 2

[OpenSmalltalk/opensmalltalk-vm] 362a31: 21462-Open a FileStream based on fd or FILE*
by GitHub 03 Mar '18

03 Mar '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 362a315766492395224f5ff8b35fcefab643133e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/362a31576649239522… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-03-01 (Thu, 01 Mar 2018) Changed paths: M platforms/Cross/plugins/FilePlugin/FilePlugin.h M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c M src/plugins/FilePlugin/FilePlugin.c Log Message: ----------- 21462-Open a FileStream based on fd or FILE* Extend FilePlugin to allow a file to be opened using either the file descriptor (fd) or FILE* in Pharo. Original PR: https://github.com/pharo-project/pharo-vm/pull/108 Updated PR: https://github.com/pharo-project/pharo-vm/pull/142 (both superseeded) As a (redundant) example of how this can be used, to open stderr (fd=2) for writing: | stderr | stderr := BinaryFileStream handle: (FilePluginPrims new openFileDescriptor: 2 writable: true) file: (File named: 'fd2') forWrite: true stderr nextPutAll: 'Hello World'; lf. stderr close. Commit: c452eb3d62e52676fdc35700265efdaaf2b60dbe https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c452eb3d62e52676fd… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-03-02 (Fri, 02 Mar 2018) Changed paths: M src/plugins/FilePlugin/FilePlugin.c Log Message: ----------- 21462-Open-a-FileStream-based-on-fd-or-FILE Remove temporary version method. Commit: 12586de3c8554bc5d792afed5f295c1ae69b7989 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/12586de3c8554bc5d7… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-03-03 (Sat, 03 Mar 2018) Changed paths: M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c Log Message: ----------- 21462-Open-a-FileStream-based-on-fd-or-FILE Not supported on Windows Commit: ac4145b7b5b036e57889e3e99076926c9a82f059 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ac4145b7b5b036e578… Author: akgrant43 <akgrant(a)gmail.com> Date: 2018-03-03 (Sat, 03 Mar 2018) Changed paths: M platforms/Cross/plugins/FilePlugin/FilePlugin.h M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c M src/plugins/FilePlugin/FilePlugin.c Log Message: ----------- Merge pull request #222 from akgrant43/21462-Open-a-FileStream-based-on-fd-or-FILE 21462 open a file stream based on fd or file Extend FilePlugin to allow a file to be opened using either the file descriptor (fd) or FILE* in Pharo on Posix platforms. See also: https://pharo.fogbugz.com/f/cases/21462/Open-a-FileStream-based-on-fd-or-FI… Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/4b58edcae0b8...ac…

1 0

Fwd: [Pharo-dev] Pharo 7 Repeatable crash: XIO: fatal IO error 14 (Bad address) on X server ":0"
by Martin McClure 02 Mar '18

02 Mar '18

Anyone here interested in this crash? Is there a newer VM I should test with? Thanks, -Martin -------- Forwarded Message -------- Subject: [Pharo-dev] Pharo 7 Repeatable crash: XIO: fatal IO error 14 (Bad address) on X server ":0" Date: Wed, 21 Feb 2018 10:37:18 -0800 From: Martin McClure <martin(a)hand2mouse.com> Reply-To: Pharo Development List <pharo-dev(a)lists.pharo.org> To: Pharo Development List <pharo-dev(a)lists.pharo.org> On the current Linux32 Pharo 7.0, (https://get.pharo.org/70+vm as of 30 minutes ago) the VM crashes with the message XIO: fatal IO error 14 (Bad address) on X server ":0" whenever I try to enlarge the Pharo window by dragging the corner, and get to a size of about 2Mpixels. This is with a virgin image with no windows open inside the main window. A workaround seems to be to open a System Browser before resizing the main window. This does not reproduce on Pharo 6.1 (https://get.pharo.org/). This *does* reproduce when running the Pharo7 image on the Pharo 6.1 VM, so it may not be entirely a VM problem. Most times, no crash dump is created, and nothing is logged to PharoDebug.log. Occasionally, especially when rapidly changing the size of the window, it segfaults and logs a dump. This may or may not be the same problem. This is less annoying since I found the workaround, but still seems to be something that should be fixed. Does anyone want further information from me in order to fix it? Regards, -Martin

3 7

Re: [Vm-dev] Fwd: [Pharo-dev] Pharo 7 Repeatable crash: XIO: fatal IO error 14 (Bad address) on X server ":0"
by Martin McClure 02 Mar '18

02 Mar '18

On 03/02/2018 08:23 AM, Eliot Miranda wrote: >>> That's strange. Can you put a breakpoint in write or exit so that gdb does stop rather than exit? Martin, if I were trying t debug this I would be trying to get the error to occur within gdb said I could poke around. I don't know any better way if solving problems like this than by first because no able to examine the exception in situ. I get that it's frustrating but there's no magic bullet. One has the keep trying until one can find out what caused the crash. >>> >> By putting a breakpoint in exit I was able to get the stack below. I >> hope this gives you a clue as to where to look next. Once again, what >> I'm doing at the point of failure is dragging the corner of the X >> window to resize it larger. >> > > Great. It's a problem in the X server, not in the VM (even if it's > the VM's fault). So any X11 experts want to weigh in on how to > proceed? I hate to say it but I would at least try restarting the X > server. I'm afraid that the problem does reproduce on a different system, configured similarly but with a slightly newer X server version (xorg-server-1.19.5-r1) that has been rebooted much more recently. -Martin

1 0

[64 bits] Object pointers in jitted code
by Javier Pimás 02 Mar '18

02 Mar '18

Hi! This time I'm investigating how cog jit handles pointers to objects in native code. In x86-32 its easier because you have immediates of the size of a pointer, but in x64 the immediates are restricted to 32bits (and I think less in arm). So I wonder how people works around that, if using a movabs instruction every time you need a pointer or if doing something else. I found a mail in the list dated from 2011 (titled "questions about cog internals") where you (Eliot) said that pointers were inlined in jit code, but I don't know if that's still the case. Looking at the slang code I found CogOutOfLineLiteralsX64Compiler, but it seems it is not used (yet?). Cheers! Pocho -- Javier Pimás Ciudad de Buenos Aires

4 10

VMMaker Interpreter Class Name
by Alistair Grant 02 Mar '18

02 Mar '18

Hi Eliot, Sorry to trouble you but can you confirm what the Interpreter class name should be in the VMMakerTool? The reason I ask is because the code I'm generating for FilePlugin has: # define SPURVM 0 while the version in the repository has SPURVM 1. I'm setting the interpreter class name to StackInterpreter, but the tool is automatically changing it to StackInterpreterPrimitives. Thanks, Alistair

2 2

[OpenSmalltalk/opensmalltalk-vm] e2773b: compatibility
by GitHub 02 Mar '18

02 Mar '18

Branch: refs/heads/krono/openbsd Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: e2773b04550e5bb85b17094a4fdc14b95e5932ea https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e2773b04550e5bb85b… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-03-02 (Fri, 02 Mar 2018) Changed paths: M platforms/unix/plugins/SoundPlugin/sqUnixSound.c M scripts/updateSCCSVersions Log Message: ----------- compatibility Commit: 960a715abf39e5e088403dbab8f1b4f93b206d9e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/960a715abf39e5e088… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-03-02 (Fri, 02 Mar 2018) Changed paths: A platforms/unix/plugins/SqueakSSL/sqUnixLibreSSL.inc R platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.c A platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.inc A platforms/unix/plugins/SqueakSSL/sqUnixSSL.c Log Message: ----------- Split Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/e2773b04550e^...9…

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2018