Vm-dev April 2011

vm-dev@lists.squeakfoundation.org

36 participants
176 discussions

Re: [Pharo-project] new Cog VMs uploaded
by Eliot Miranda 27 Apr '11

27 Apr '11

can you post a stack trace from gdb? Also, what linux system and what image are you using? TIA Eliot On Wed, Apr 27, 2011 at 8:18 AM, Philippe Marschall <kustos(a)gmx.net> wrote: > On 26.04.2011 23:01, Eliot Miranda wrote: > > ...to http://www.mirandabanda.org/files/Cog/VM/VM.r2379/. These fix > > shallowCopy and copyFrom: for contexts and (I hope) fix the linux Locale > > plugin. > > The following still crashes my vm: > > (Locale localeID: (LocaleID isoLanguage: 'de' isoCountry: 'CH')) > primShortDateFormat > > Cheers > Philippe > > >

1 0

Re: [Pharo-project] new Cog VMs uploaded
by Eliot Miranda 27 Apr '11

27 Apr '11

Philippe, can you please profile before and after? This could very well be to do with the additional cost of shallowCopy for contexts, but it is inevitable that a correct implementation is going to be more expensive than the simple block-copy. The new implementation can be optimized, but we need to profile first to be sure we're tilting at the relevant windmill. AdvThanksance Eliot On Wed, Apr 27, 2011 at 9:40 AM, Philippe Marschall <kustos(a)gmx.net> wrote: > On 26.04.2011 23:01, Eliot Miranda wrote: > > ...to http://www.mirandabanda.org/files/Cog/VM/VM.r2379/. These fix > > shallowCopy and copyFrom: for contexts and (I hope) fix the linux Locale > > plugin. > > I'm seeing quite a drastic performance degradation in the last two Cog > releases for Seaside. r2361 and r2370 would yield about 4300 to 4400 > "points" for /tests/functional/WAPerformanceFunctionalTest. r2378 and > r2380 are down to about 2600 to 2700. That's almost a third slower. > > Cheers > Philippe > > >

1 0

VM Maker: VMMaker-dtl.229.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 27 Apr '11

27 Apr '11

Dave Lewis uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker-dtl.229.mcz ==================== Summary ==================== Name: VMMaker-dtl.229 Author: dtl Time: 26 April 2011, 7:02:44 am UUID: c1d30608-3088-4db7-20fa-2af7a46c1508 Ancestors: VMMaker-dtl.228 VMMaker 4.4.16 Add VMBasicConstants pool to InterpreterPlugin. Fix bug in SlangTest>>setUp, and update comments. Document the code generation optimization in CCodeGenerator>>localizeGlobalVariables with a unit test. Currently this optimization produces unexpected (but correct) results in translating Interpreter>>primitiveFailFor: Background: If a method makes reference to an instance variable, and if this is the only method containing a reference to that variable, then the C translator will produce a local variable declaration in the generated function, and no global declaration will appear in the generated source file. This optimization is applied after inlining has been performed, so there are legitimate cases where a variable must be an instance variable referenced by two methods, but can be made local if those methods are inlined into a single method and only one method reference to the variable remains. See ObjectMemory>>markAndSweep: for an example.

1 0

VM Maker: VMMaker-dtl.228.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 27 Apr '11

27 Apr '11

Dave Lewis uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker-dtl.228.mcz ==================== Summary ==================== Name: VMMaker-dtl.228 Author: dtl Time: 23 April 2011, 8:27:47 am UUID: c1d30608-3098-56b7-200a-34f7a46c1508 Ancestors: VMMaker-dtl.227 VMMaker 4.4.15 Fix a duplicate variable declaration in AsynchFilePlugin. Move class variables from ObjectMemory and Interpreter into shared pools as per oscog. Add #largeContextSize and #smallContextSize to ObjectMemory to generate code for 32 and 64 bit object memories (remove constants LargeContextSize and SmallContextSize from shared pools, as these are 32 bit object memory only). Currently unused in Interpreter but will be required for StackInterpreter. Notes: VMBasicConstants is not required for primitives but is used (unnecessarily?) in oscog. The constant InvokeObjectAsMethodPrimitiveIndex was unused, so this is removed. This leaves only two constants in VMSqueakV3BytecodeConstants, so this class probably does not carry its weight. Leave it for now though. VMSqueakV3ObjectRepresentationConstants does not contain various constants that could better be implemented as methods (see ObjectMemory category "constants"). Follow up requred - check if largeContextSize and smallContextSize are defined correctly for a 64 bit object memory.

1 0

A possible Cog bug (was: Re: [squeak-dev] Direct implementation of shift/reset in Smalltalk)
by Levente Uzonyi 27 Apr '11

27 Apr '11

On Thu, 21 Apr 2011, Frank Shearar wrote: > I finished a preliminary version of the shift/reset control operator for > creating and using partial continuations: > > http://www.squeaksource.com/Control.html > > It's pretty easy to use: > snip > Comments welcome! I thought it's a bit easier to use notifications instead of control operators. Here's an example: c := [ 3 + PartialContinuationNotification signal ] on: PartialContinuationNotification do: [ :not | not continuation ]. c value: 4. "==> 7" So I implemented it and uploaded it to http://leves.web.elte.hu/squeak/Control-ul.5.mcz . I also refactored the code a bit. Even though some Pharo folks always wanted to be able to use streams with OrderedCollection (which works in Squeak btw), it's kinda pointless thing to use #streamContents: with them, because OrderedCollections can grow by themselves, unlike Arrays or Strings. The code works, the tests are green, etc. But I wasn't happy with the results, because ContextPart already implements #copyTo: (which I think can also be simplified by removing BlockContext support), which can be used to serialize the stack. So I wrote the code, but it didn't work for some reason. The execution always ran into the error 'computation has been terminated' in MethodContext >> #cannotReturn: and the method context (which stitches the continuation onto the stack) was broken (nil in temporaries where should be non nil values). Finally I tried it in SqueakVM instead of Cog and it worked. The tests are green, the example code works, etc. The code with these changes is available at http://leves.web.elte.hu/squeak/Control-ul.6.mcz . I prepared an image to ease the debugging process, which is available at http://leves.web.elte.hu/squeak/ContextBug.zip . Levente P.S.: Feel free to add an issue to the Cog tracker. :) > > frank > > [1] > http://www.lshift.net/blog/2011/04/20/direct-implementation-of-shiftreset-i… > >

3 10

VM Maker: VMMaker-dtl.229.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 27 Apr '11

27 Apr '11

1 0

[commit] r2380 - Fix snafu in cloneContext:.
by commits＠squeakvm.org 27 Apr '11

27 Apr '11

Author: eliot Date: 2011-04-26 17:58:52 -0700 (Tue, 26 Apr 2011) New Revision: 2380 Modified: branches/Cog/image/VMMaker-Squeak4.1.changes branches/Cog/image/VMMaker-Squeak4.1.image branches/Cog/src/vm/cointerp.c branches/Cog/src/vm/cointerp.h branches/Cog/src/vm/gcc3x-cointerp.c Log: Fix snafu in cloneContext:. Modified: branches/Cog/image/VMMaker-Squeak4.1.changes =================================================================== --- branches/Cog/image/VMMaker-Squeak4.1.changes 2011-04-26 19:24:15 UTC (rev 2379) +++ branches/Cog/image/VMMaker-Squeak4.1.changes 2011-04-27 00:58:52 UTC (rev 2380) @@ -178239,4 +178239,48 @@ "VMMaker"! -----QUIT----{26 April 2011 . 12:13:26 pm} VMMaker-Squeak4.1.image priorSource: 7348282! \ No newline at end of file +----QUIT----{26 April 2011 . 12:13:26 pm} VMMaker-Squeak4.1.image priorSource: 7348282! + +----STARTUP----{26 April 2011 . 5:47:26 pm} as /Users/eliot/Cog/oscogvm/image/VMMaker-Squeak4.1.image! + +!StackInterpreterPrimitives methodsFor: 'primitive support' stamp: 'eem 4/26/2011 17:45' prior: 40904700! +cloneContext: aContext + | cloned spouseFP sp | + <var: #spouseFP type: #'char *'> + cloned := objectMemory clone: aContext. + cloned ~= 0 ifTrue: + [0 to: StackPointerIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (self externalInstVar: i ofContext: aContext)]. + MethodIndex to: ReceiverIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (self fetchPointer: i ofObject: aContext)]. + (self isStillMarriedContext: aContext) + ifTrue: + [spouseFP := self frameOfMarriedContext: aContext. + sp := (self stackPointerIndexForFrame: spouseFP) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (self temporary: i in: spouseFP)]] + ifFalse: + [sp := (self fetchStackPointerOf: aContext) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (self fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]]. + ^cloned! ! + +"VMMaker"! + +----QUIT----{26 April 2011 . 5:54:49 pm} VMMaker-Squeak4.1.image priorSource: 7357300! \ No newline at end of file Modified: branches/Cog/image/VMMaker-Squeak4.1.image =================================================================== (Binary files differ) Modified: branches/Cog/src/vm/cointerp.c =================================================================== --- branches/Cog/src/vm/cointerp.c 2011-04-26 19:24:15 UTC (rev 2379) +++ branches/Cog/src/vm/cointerp.c 2011-04-27 00:58:52 UTC (rev 2380) @@ -1,9 +1,9 @@ /* Automatically generated by - CCodeGeneratorGlobalStructure VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b + CCodeGeneratorGlobalStructure VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 from - CoInterpreter VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b + CoInterpreter VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 */ -static char __buildInfo[] = "CoInterpreter VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b " __DATE__ ; +static char __buildInfo[] = "CoInterpreter VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 " __DATE__ ; char *__interpBuildInfo = __buildInfo; @@ -1865,7 +1865,7 @@ /* 575 */ (void (*)(void))0, 0 }; static void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* 4097 */])(void); -const char *interpreterVersion = "Croquet Closure Cog VM [CoInterpreter VMMaker.oscog-eem.55]"; +const char *interpreterVersion = "Croquet Closure Cog VM [CoInterpreter VMMaker.oscog-eem.56]"; sqInt minBackwardJumpCountForCompile = MinBackwardJumpCountForCompile /* 10 */; static volatile int sendTrace; @@ -24286,12 +24286,9 @@ else { sp1 = (fetchStackPointerOf(receiver)) - 1; for (i = 0; i <= sp1; i += 1) { - longAtput((cloned + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord), longAt((receiver + BaseHeaderSize) + (i << ShiftForWord))); + longAtput((cloned + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord), longAt((receiver + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord))); } } - for (i = ((sp1 + CtxtTempFrameStart) + 1); i <= ((lengthOf(receiver)) - 1); i += 1) { - longAtput((cloned + BaseHeaderSize) + (i << ShiftForWord), GIV(nilObj)); - } } newCopy = cloned; } Modified: branches/Cog/src/vm/cointerp.h =================================================================== --- branches/Cog/src/vm/cointerp.h 2011-04-26 19:24:15 UTC (rev 2379) +++ branches/Cog/src/vm/cointerp.h 2011-04-27 00:58:52 UTC (rev 2380) @@ -1,5 +1,5 @@ /* Automatically generated by - CCodeGeneratorGlobalStructure VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b + CCodeGeneratorGlobalStructure VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 */ Modified: branches/Cog/src/vm/gcc3x-cointerp.c =================================================================== --- branches/Cog/src/vm/gcc3x-cointerp.c 2011-04-26 19:24:15 UTC (rev 2379) +++ branches/Cog/src/vm/gcc3x-cointerp.c 2011-04-27 00:58:52 UTC (rev 2380) @@ -2,11 +2,11 @@ /* Automatically generated by - CCodeGeneratorGlobalStructure VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b + CCodeGeneratorGlobalStructure VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 from - CoInterpreter VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b + CoInterpreter VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 */ -static char __buildInfo[] = "CoInterpreter VMMaker.oscog-eem.55 uuid: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b " __DATE__ ; +static char __buildInfo[] = "CoInterpreter VMMaker.oscog-eem.56 uuid: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 " __DATE__ ; char *__interpBuildInfo = __buildInfo; @@ -1868,7 +1868,7 @@ /* 575 */ (void (*)(void))0, 0 }; static void (*externalPrimitiveTable[MaxExternalPrimitiveTableSize + 1 /* 4097 */])(void); -const char *interpreterVersion = "Croquet Closure Cog VM [CoInterpreter VMMaker.oscog-eem.55]"; +const char *interpreterVersion = "Croquet Closure Cog VM [CoInterpreter VMMaker.oscog-eem.56]"; sqInt minBackwardJumpCountForCompile = MinBackwardJumpCountForCompile /* 10 */; static volatile int sendTrace; @@ -24290,12 +24290,9 @@ else { sp1 = (fetchStackPointerOf(receiver)) - 1; for (i = 0; i <= sp1; i += 1) { - longAtput((cloned + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord), longAt((receiver + BaseHeaderSize) + (i << ShiftForWord))); + longAtput((cloned + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord), longAt((receiver + BaseHeaderSize) + ((i + CtxtTempFrameStart) << ShiftForWord))); } } - for (i = ((sp1 + CtxtTempFrameStart) + 1); i <= ((lengthOf(receiver)) - 1); i += 1) { - longAtput((cloned + BaseHeaderSize) + (i << ShiftForWord), GIV(nilObj)); - } } newCopy = cloned; }

1 0

VM Maker: CMakeVMMaker-MarianoMartinezPeck.101.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 26 Apr '11

26 Apr '11

Mariano Martínez Peck uploaded a new version of CMakeVMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/CMakeVMMaker-MarianoMartinezPeck.101.mcz ==================== Summary ==================== Name: CMakeVMMaker-MarianoMartinezPeck.101 Author: MarianoMartinezPeck Time: 26 April 2011, 9:05:56 pm UUID: dbd0f91c-8ff6-450a-9b93-7af3d3aa7dcd Ancestors: CMakeVMMaker-MarianoMartinezPeck.100 Finally fix the problem with asserts: For release confs: a) turn debugging off (-DDEBUGVM=0) b) suppress assertions (-DNDEBUG) For debugging debug confs: a) turn all debugging on (-DDEBUGVM=1) b) enable assertions (omit defining -DNDEBUG)

1 0

VM Maker: VMMaker.oscog-eem.55.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 26 Apr '11

26 Apr '11

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker.oscog-eem.55.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.55 Author: eem Time: 26 April 2011, 11:47:29 am UUID: 315353fc-7f75-4b5b-8a43-3a636cb1aa0b Ancestors: VMMaker-oscog.54 Implement shallowCopy (primitiveClone) and copyFrom: (primitiveCopyObject) correctly for contexts. Change package nameto correct Monticello branch convention.

1 0

VM Maker: CMakeVMMaker-MarianoMartinezPeck.100.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 26 Apr '11

26 Apr '11

Mariano Martínez Peck uploaded a new version of CMakeVMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/CMakeVMMaker-MarianoMartinezPeck.100.mcz ==================== Summary ==================== Name: CMakeVMMaker-MarianoMartinezPeck.100 Author: MarianoMartinezPeck Time: 26 April 2011, 8:43:31 pm UUID: 394701c5-bcc1-4f28-a1ee-c7b7aa5b140b Ancestors: CMakeVMMaker-MarianoMartinezPeck.99 Removed -fomit-frame-pointer from Mac targets

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2011