Vm-dev April 2011

vm-dev@lists.squeakfoundation.org

36 participants
176 discussions

Cog and #commonSend are getting me crazy :(
by Mariano Martinez Peck 29 Apr '11

29 Apr '11

Hi Eliot. I am fighting since several hours with something in Cog and I cannot realize it. I am blind. I need to intercept all messages sent to an object. I have already done this for Interpreter VM and for StackVM. Now, I am trying latest CogMTVM, and there is something I am not sying...I have this test: testBlah ClassWith1Var new fooLong. ClassWith1Var new fooLong. ClassWith1Var new fooLong. ClassWith1Var >> fooLong | aaa | Object new. self foo. Now, I modified CoInterpreter >> commonSend "Send a message, starting lookup with the receiver's class." "Assume: messageSelector and argumentCount have been set, and that the receiver and arguments have been pushed onto the stack," "Note: This method is inlined into the interpreter dispatch loop." <sharedCodeNamed: 'commonSend' inCase: 131> self sendBreak: messageSelector + BaseHeaderSize point: (objectMemory lengthOf: messageSelector) receiver: (self internalStackValue: argumentCount). cogit recordSendTrace ifTrue: [self recordTrace: lkupClass thing: messageSelector source: TraceIsFromInterpreter]. self internalFindNewMethod. self print: 'called: '; printStringOf: messageSelector; cr. self internalExecuteNewMethod. self fetchNextBytecode And when running the VM from gdb, 'called: fooLong' doesn't appear at all!!! why ? In addition, it appears 'called: foo' which is correct because #fooLong sends #foo but it appears only ONCE. #fooLong as I can see is not a quick return method but instead it goes by #sendLiteralSelector0ArgsBytecode. But the same happens if I put the print in that method... (which makes sense). I tried with a StackVM and the same....so it seems that #fooLong is going by another place than #commonSend. As far as I understand, there is nothing related with PIC or Jitt. In any of those cases, as what I can see, the #commonSend is called anyways. So...I am completly lost. Thanks in advance for any help. -- Mariano http://marianopeck.wordpress.com

4 6

VM Maker: CMakeVMMaker-MarianoMartinezPeck.102.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 29 Apr '11

29 Apr '11

Mariano Martínez Peck uploaded a new version of CMakeVMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/CMakeVMMaker-MarianoMartinezPeck.102.mcz ==================== Summary ==================== Name: CMakeVMMaker-MarianoMartinezPeck.102 Author: MarianoMartinezPeck Time: 29 April 2011, 11:10:38 am UUID: 964da102-a4a6-464d-b242-5bcbeef00ae1 Ancestors: CMakeVMMaker-MarianoMartinezPeck.100 Recover all the lost changes of Squeaksource Little fix in debug flags (a white space was needed)

1 0

What is exactly the problem when evaluating stuff from Workspace and Cog?
by Mariano Martinez Peck 28 Apr '11

28 Apr '11

Hi. Sorry for my ignorance, but I remember hearing about that evaluating stuff from a workspace may not be the best choice when we want to test stuff on Cog. And in fact, today I suffered that. I put a breakpoint in the method lookup, where the dnu is thrown. And then from a workspace I executed: TestCase new adasdassad And didn't stop. Then I put that in a method: MyClass >> blah TestCase new asdadsadasda And did MyClass new blah and the breakpoint stop....So, can someone explain me what black magic happens with the Workspace? is something related to the Compiler evaluation ? Thanks in advance, -- Mariano http://marianopeck.wordpress.com

3 5

[commit] r2383 - do not copy trailing NUL from C to Squeak strings
by commits＠squeakvm.org 28 Apr '11

28 Apr '11

Author: piumarta Date: 2011-04-27 18:16:17 -0700 (Wed, 27 Apr 2011) New Revision: 2383 Modified: trunk/platforms/unix/ChangeLog trunk/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c Log: do not copy trailing NUL from C to Squeak strings Modified: trunk/platforms/unix/ChangeLog =================================================================== --- trunk/platforms/unix/ChangeLog 2011-04-27 18:23:43 UTC (rev 2382) +++ trunk/platforms/unix/ChangeLog 2011-04-28 01:16:17 UTC (rev 2383) @@ -1,3 +1,8 @@ +2011-04-28 Ian Piumarta <com -dot- gmail -at- piumarta (backwards)> + + * plugins/LocalePlugin/sqUnixLocale.c: Do not copy trailing NUL + from C to Squeak strings. + 2011-03-31 Ian Piumarta <piumarta(a)freebsd.piumarta.com> * vm/sqUnixExternalPrims.c: Resolve symbols eagerly on FreeBSD. Modified: trunk/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c =================================================================== --- trunk/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-27 18:23:43 UTC (rev 2382) +++ trunk/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-28 01:16:17 UTC (rev 2383) @@ -27,7 +27,7 @@ /* Author: Ian.Piumarta(a)inria.fr * - * Last edited: 2008-11-10 13:25:18 by piumarta on ubuntu.piumarta.com + * Last edited: 2011-04-28 10:11:02 by piumarta on 192.168.1.11 */ #include "sq.h" @@ -62,6 +62,12 @@ static struct lconv *localeConv= 0; +static void safestrcpy(char *dst, const char *src) +{ + memcpy(dst, src, strlen(src)); +} + + /*** SUNDRY STUPIDITY ***/ @@ -612,7 +618,7 @@ */ void sqLocGetCurrencySymbolInto(char *str) { - strcpy(str, localeConv->currency_symbol); + safestrcpy(str, localeConv->currency_symbol); } sqInt sqLocCurrencySymbolSize(void) @@ -637,7 +643,7 @@ */ void sqLocGetDigitGroupingSymbolInto(char *str) { - strcpy(str, localeConv->thousands_sep); + safestrcpy(str, localeConv->thousands_sep); } @@ -645,7 +651,7 @@ */ void sqLocGetDecimalSymbolInto(char *str) { - strcpy(str, localeConv->decimal_point); + safestrcpy(str, localeConv->decimal_point); } @@ -698,7 +704,7 @@ */ void sqLocGetLongDateFormatInto(char *str) { - strcpy(str, nl_langinfo(D_FMT)); + safestrcpy(str, nl_langinfo(D_FMT)); } /* Answer the number of characters in the short date format. @@ -712,7 +718,7 @@ */ void sqLocGetShortDateFormatInto(char *str) { - strcpy(str, nl_langinfo(D_FMT)); + safestrcpy(str, nl_langinfo(D_FMT)); } /* Answer the number of characters in the time format. @@ -726,7 +732,7 @@ */ void sqLocGetTimeFormatInto(char *str) { - strcpy(str, nl_langinfo(T_FMT)); + safestrcpy(str, nl_langinfo(T_FMT)); } @@ -741,11 +747,11 @@ void sqLocGetCountryInto(char * str) { - strcpy(str, getCountry()); + safestrcpy(str, getCountry()); } void sqLocGetLanguageInto(char * str) { - strcpy(str, getLanguage()); + safestrcpy(str, getLanguage()); }

1 0

VM Maker: VMMaker.oscog-eem.56.mcz
by squeak-dev-noreply＠lists.squeakfoundation.org 27 Apr '11

27 Apr '11

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker.oscog-eem.56.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.56 Author: eem Time: 26 April 2011, 5:49:36 am UUID: fbf17bd2-ddbc-488f-b70d-3b9ba8906430 Ancestors: VMMaker.oscog-eem.55 Fix snafu in cloneContext:.

1 0

new Cog VMs uploaded
by Eliot Miranda 27 Apr '11

27 Apr '11

...to http://www.mirandabanda.org/files/Cog/VM/VM.r2379/. These fix shallowCopy and copyFrom: for contexts and (I hope) fix the linux Locale plugin. best, Eliot

2 4

Re: [Pharo-project] new Cog VMs uploaded
by Eliot Miranda 27 Apr '11

27 Apr '11

Hi All, this is because of carelessness in the trunk platforms/unix/plugins/LocalePlugin/sqUnixLocale.c which uses strcpy to copy C strings from the locale subsystem into Smalltalk strings. strcpy copies the trailing null, which will overwrite the first byte of the following object. This just happens not to kill the standard VM because current code always uses these functions on new strings. But Cog currently checks for attempts to overwrite objects and hence it catches these attemptys and aborts, with an error message. Hilaire, Phillipe, you should have seen and reported the "last object overwritten" report form the VM and if so we would have debugged this a lot sooner. Error messages are there to be read. Ian, David, I recommend that you fold URL: http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/unix/plugins/Loca… Revision: 2382 back into trunk. I've replaced all uses of strcpy in platforms/unix/plugins/LocalePlugin/sqUnixLocale.c with the following: /* For Cog do *not* copy the trailing null since the VM checks for attempts to * overwrite the end of an object, and copying the trailing null into a string * does precisely this. */ #define safestrcpy(str,source) do { \ char *src = (source); \ int len = strlen(src); \ strncpy(str,src,len); \ } while (0) On Wed, Apr 27, 2011 at 8:18 AM, Philippe Marschall <kustos(a)gmx.net> wrote: > On 26.04.2011 23:01, Eliot Miranda wrote: > > ...to http://www.mirandabanda.org/files/Cog/VM/VM.r2379/. These fix > > shallowCopy and copyFrom: for contexts and (I hope) fix the linux Locale > > plugin. > > The following still crashes my vm: > > (Locale localeID: (LocaleID isoLanguage: 'de' isoCountry: 'CH')) > primShortDateFormat > > Cheers > Philippe > > >

1 0

[commit] r2382 - Fix comment typo.
by commits＠squeakvm.org 27 Apr '11

27 Apr '11

Author: eliot Date: 2011-04-27 11:23:43 -0700 (Wed, 27 Apr 2011) New Revision: 2382 Modified: branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c Log: Fix comment typo. Modified: branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c =================================================================== --- branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-27 18:17:24 UTC (rev 2381) +++ branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-27 18:23:43 UTC (rev 2382) @@ -608,7 +608,7 @@ return localeConv->p_cs_precedes; } -/* For Cog do *not* copy the trailing null sicne the VM checks for attempts to +/* For Cog do *not* copy the trailing null since the VM checks for attempts to * overwrite the end of an object, and copying the trailing null into a string * does precisely this. */

1 0

[commit] r2381 - Fix egregious object overwriting bug in sqUnixLocale.c.
by commits＠squeakvm.org 27 Apr '11

27 Apr '11

Author: eliot Date: 2011-04-27 11:17:24 -0700 (Wed, 27 Apr 2011) New Revision: 2381 Modified: branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c Log: Fix egregious object overwriting bug in sqUnixLocale.c. Modified: branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c =================================================================== --- branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-27 00:58:52 UTC (rev 2380) +++ branches/Cog/platforms/unix/plugins/LocalePlugin/sqUnixLocale.c 2011-04-27 18:17:24 UTC (rev 2381) @@ -608,11 +608,21 @@ return localeConv->p_cs_precedes; } +/* For Cog do *not* copy the trailing null sicne the VM checks for attempts to + * overwrite the end of an object, and copying the trailing null into a string + * does precisely this. + */ +#define safestrcpy(str,source) do { \ + char *src = (source); \ + int len = strlen(src); \ + strncpy(str,src,len); \ +} while (0) + /* Store the currency symbol into the given string. */ void sqLocGetCurrencySymbolInto(char *str) { - strcpy(str, localeConv->currency_symbol); + safestrcpy(str, localeConv->currency_symbol); } sqInt sqLocCurrencySymbolSize(void) @@ -637,7 +647,7 @@ */ void sqLocGetDigitGroupingSymbolInto(char *str) { - strcpy(str, localeConv->thousands_sep); + safestrcpy(str, localeConv->thousands_sep); } @@ -645,7 +655,7 @@ */ void sqLocGetDecimalSymbolInto(char *str) { - strcpy(str, localeConv->decimal_point); + safestrcpy(str, localeConv->decimal_point); } @@ -698,7 +708,7 @@ */ void sqLocGetLongDateFormatInto(char *str) { - strcpy(str, nl_langinfo(D_FMT)); + safestrcpy(str, nl_langinfo(D_FMT)); } /* Answer the number of characters in the short date format. @@ -712,7 +722,7 @@ */ void sqLocGetShortDateFormatInto(char *str) { - strcpy(str, nl_langinfo(D_FMT)); + safestrcpy(str, nl_langinfo(D_FMT)); } /* Answer the number of characters in the time format. @@ -726,7 +736,7 @@ */ void sqLocGetTimeFormatInto(char *str) { - strcpy(str, nl_langinfo(T_FMT)); + safestrcpy(str, nl_langinfo(T_FMT)); } @@ -741,11 +751,11 @@ void sqLocGetCountryInto(char * str) { - strcpy(str, getCountry()); + safestrcpy(str, getCountry()); } void sqLocGetLanguageInto(char * str) { - strcpy(str, getLanguage()); + safestrcpy(str, getLanguage()); }

1 0

SqueakSource failure and data loss
by David T. Lewis 27 Apr '11

27 Apr '11

SqueakSource has apparently experienced a failure with resulting data loss. If you have made any commits during the last several days, check to see if they are still present on SqueakSource. Eliot, I believe this includes your recent oscog update. The data loss appears to go back to at least April 23, and possibly further. I have recopied VMMaker-dtl.227 and VMMaker-dtl.228 to the server but I am not certain what else may have been lost. Dave

4 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2011