A side-comment from the peanut gallery...
On 16 November 2017 at 03:47, Fabio Niephaus notifications@github.com wrote:
It is indeed. I was hoping we do "you break it, you fix it", but that didn't work apparently.
Taking the path of least resistance is human nature. There are varying levels of "too busy to fix that right now." Introducing the merge-barrier shifts that balance point to encourage the idealistic behaviour of fixing errors asap.
To mitigate concerns of delayed merges.. If these barriers sometimes get in the way of something critical, it should be okay to temporarily disable them. But at least the default encourages the ideal behaviour and bypassing that require explicit action rather than happening accidentally.
We could force the Cog branch to always be green by only allowing changes that previously have been proven to pass, but then it takes longer to get things merged. Not sure if we want that...
Delayed merges are a fairly generic concern. It would be good to expose some detail from everyone concerned that enabling the following will impeded their workflow...
https://help.github.com/assets/images/help/repository/protecting-branch-loos...
That is... What period of delay are you concerned about? How often do you you think this would be a problem? Is the problem the delay in merging-code, or the delay in getting the new binary to run?
cheers -ben