Hi Eliot,
as promised I checked what I did and found something I changed:
The file platforms/unix/vm/sqUnixHeartbeat.c has the function void ioUpdateVMTimezone(). It was changed to something similar to what is in Cog's sqUnixITimerHeartbeat.c:
void ioUpdateVMTimezone() { updateMicrosecondClock(); #ifdef HAVE_TM_GMTOFF time_t utctt; utctt = (get64(utcMicrosecondClock) - MicrosecondsFrom1901To1970) / MicrosecondsPerSecond; vmGMTOffset = localtime(&utctt)->tm_gmtoff * MicrosecondsPerSecond; #else # ifdef HAVE_TIMEZONE extern time_t timezone, altzone; extern int daylight; vmGMTOffset = -1 * (daylight ? altzone : timezone) * MicrosecondsPerSecond; # else # error "cannot determine timezone correction" # endif #endif }
One thing is striking: the call to updateMicrosecondClock() is here before the #ifdef HAVE_TM_GMTOFF while in sqUnixITimerHeartbeat.c it is after the #ifdef. I don't know which one is correct (I may have copied it wrongly from sqUnixITimerHeartbeat). Albeit the one here seems to be correct in my eyes. What do you think? (Side note: As far as I remember Solaris does not have tm_gmtoff and thus the else part is being executed).
Regards Andreas
Am 14.03.15 18:33, schrieb Andreas Wacknitz:
Hi Eliot,
Am 11.03.2015 um 23:15 schrieb Eliot Miranda <eliot.miranda@gmail.com mailto:eliot.miranda@gmail.com>:
HI Andreas,
On Wed, Mar 11, 2015 at 9:55 AM, Andreas Wacknitz <a.wacknitz@gmx.de mailto:a.wacknitz@gmx.de> wrote:
Hi Clement,Am 11.03.2015 um 09:23 schrieb Clément Bera <bera.clement@gmail.com <mailto:bera.clement@gmail.com>>: Hello, About the FreeBSD VM, Holger Freyther worked on it so he's the best person to answer. I think some people used it and it was at least partially working.That’s my impression. The VMMaker contains some FreeBSD classes but I have the impression that they are not complete (and probably outdated).About your NativeBoost bug on openSolaris, need more information: - Can you confirm that you use an intel processor on your openSolaris machine ? I assume that yes but I ask because solaris were typically running on other processors. NativeBoost, as of today, works only with intel processor.Yes, my Sun Ultra 24 is an Intel based Workstation (Q9300).- Do you build the Cog VM or Stack VM ? I mean PharoVMBuild or PharoSVMBuild ? I think the PharoSVMBuild does not include NativeBoost by default, that may be your problem. There's a fix somewhere...PharoVM from "branch 'master' of https://github.com/pharo-project/pharo-vm" (thus Cog VM).I would like to fold back any changes into the svn master repository for Cog. What are the diffs? (If you have time to send me the diffs that would save me a lot of time).
I don’t know whether there is much to harvest from what I did. As far as I remember most of my work was hacking the generator image created by the pharo vm scripts (for my Mac) in order to make the resulting C code to compile under openindiana. The basis for Solaris was already there (and as far as I can see it is also in the Squeak VM sources). I only tweaked some definitions and includes. I will look at my notes tomorrow and will post if I will find something relevant.
I am curios about the future of the PharoVM. The main development of the VM seem to happen in the SqueakVM (by you). Getting the Spur changes into the PharoVM seem to be a lot of work. Wouldn’t it be better to move back the changes of the PharoVM into the SqueakVM and have a united development? And what is the status and what are the plans regarding Timothy’s (gettimothy) work?
Regards Andreas