30 Jul
2022
30 Jul
'22
9:27 p.m.
@eliotmiranda requested changes on this pull request.
Hi Ken, can you do a different version which doesn't include either of src/plugins/SqueakFFIPrims/RiscV64FFIPlugin.c src/plugins/ZipPlugin/ZipPlugin.c ? I generate these carefully. Your generations are against changed VMMaker packages (see the static const char *moduleName = "ZipPlugin * VMMaker.oscog-eem.3218 " INT_EXT; lines). So I don't want to accept these changes and have to regenerate the plugin files again. Everything else looks fine.
--
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646#pullrequestreview...
You are receiving this because you are subscribed to this thread.
Message ID: OpenSmalltalk/opensmalltalk-vm/pull/646/review/1056471550@github.com