Hi,
I started to write a rpm spec file to package the PharoVM on CentOS/RHEL/OpenSUSE and there is a list of warnings to resolve first before the packages are being published. I am pasting the list below. Most is in pure C code, some seems to be in the Smalltalk part as well.
any volunteers to fix it or handle PRs in a timely manner?
holger
[ 90s] I: Program is using implicit definitions of functions getting [ 90s] pointers or implemented by macros. These functions need to use their [ 90s] correct prototypes to allow correct argument passing on e.g. x86_64 . [ 90s] - Implicit memory/string functions need #include <string.h>. [ 90s] - Implicit *printf functions need #include <stdio.h>. [ 90s] - Implicit *printf functions need #include <stdio.h>. [ 90s] - Implicit *read* functions need #include <unistd.h>. [ 90s] - Implicit *recv* functions need #include <sys/socket.h>. [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/vm/sqVirtualMachine.c:593 [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.c:173 [ 90s] W: pharo6-ui-common implicit-pointer-decl /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm/sqUnixMain.c:1569, 1602 [ 90s] [ 90s] I: A function uses a 'return;' statement, but has actually a value [ 90s] to return, like an integer ('return 42;') or similar. [ 90s] W: pharo6-ui-common voidreturn /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-ALSA/sqUnixSoundALSA.c:673 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/plugins/SoundPlugin/sqUnixSound.c:194, 195, 196, 197 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/spursrc/vm/cogitIA32.c:8669, 18919, 21697, 28355 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/spursrc/vm/gcc3x-cointerp.c:32907 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/IA32ABI/IA32ABI.c:786, 833, 880, 927 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/SerialPlugin/SerialPlugin.c:237 [ 90s] E: pharo6-ui-common 64bit-portability-issue /home/abuild/rpmbuild/BUILD/pharo6-vm-core/src/plugins/SqueakFFIPrims/IA32FFIPlugin.c:545, 548, 554, 563, 568, 2825 [ 90s] [ 90s] I: Program returns random data in a function [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:118 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer1.c:36 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer3.c:1078 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:68, 483 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:67 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1385 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:82, 98 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:65 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/headers.c:118, 141, 185, 210, 233, 295, 314, 326, 377 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:321 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.h:152, 166, 87, 137, 114, 101 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixX11.c:6926 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixXdnd.c:803 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c:455, 519, 528, 600, 713, 821, 814 [ 90s] [ 90s] I: Program returns random data in a function [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:118 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer1.c:36 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/audio/layer3.c:1078 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/libmpeg3.c:68, 483 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3atrack.c:67 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3demux.c:1385 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3title.c:82, 98 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3vtrack.c:65 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/headers.c:118, 141, 185, 210, 233, 295, 314, 326, 377 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/mpeg3video.c:321 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/Cross/plugins/Mpeg3Plugin/libmpeg/video/slice.h:152, 166, 87, 137, 114, 101 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixX11.c:6926 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-display-X11/sqUnixXdnd.c:803 [ 90s] E: pharo6-ui-common no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/pharo6-vm-core/platforms/unix/vm-sound-pulse/sqUnixSoundPulseAudio.c:455, 519, 528, 600, 713, 821, 814