On 31 January 2012 21:19, Igor Stasenko siguctua@gmail.com wrote:
On 31 January 2012 20:50, Eliot Miranda eliot.miranda@gmail.com wrote:
On Tue, Jan 31, 2012 at 11:22 AM, Mariano Martinez Peck marianopeck@gmail.com wrote:
Hi Eliot. Me again :) I was checking the changes Igor did some time ago for the fast become where he basically swapped the bytes contents between the objects when they were the same size and same header type. He put such code in separate primtives and some changes in the image side to call them. I have just played with them and they seem to work. I have 2 questions for you:
- Do you think that this new fast become can have problems when becoming CompiledMethods? I am asking because of the JIT/Pic. Maybe I need a flushCache or something?
Yes, almost certainly. You'd want to do a flushCache on both methods.
are there other object types which we need to be careful with? because i was thinking to just put a check in fast-become prim and simply fail the prim if object type(s) to be swapped are not supported, so user will be forced to use slow good-old #become:
otherwise, if its only compiled methods, we can actually put flush cache in primitive itself, so no matter who/how calling it, there will be no chance to have inconsistent behavior.
-- Best regards, Igor Stasenko.