Vm-dev April 2022

vm-dev@lists.squeakfoundation.org

16 participants
71 discussions

[OpenSmalltalk/opensmalltalk-vm] 06dca1: In IA32ABI plugin on 32-bit (x86/IA32) platforms, ...
by Marcel Taeumel 13 Apr '22

13 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 06dca1d00d20747735655b25e0a7987cd5c48315 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/06dca1d00d20747735… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M building/win32x86/common/Makefile.tools M platforms/Cross/plugins/IA32ABI/ia32abicc.c Log Message: ----------- In IA32ABI plugin on 32-bit (x86/IA32) platforms, use -O0 in thunkEntry when compiling via gcc to not mess it up. Works fine with clang. For 32-bit Windows builds via Cygwin/MSYS/MinGW, default to clang instead of gcc for the above reasons. Also see (merged) PR #353.

1 0

[OpenSmalltalk/opensmalltalk-vm] Patch callback thunkEntry to not optimize (#353)
by Guille Polito 13 Apr '22

13 Apr '22

O2 and O1 compilation produce a segmentation fault due to stack corruption (when debugging we saw some extra pushes from the stack) on callbacks return. This happens on windows 32, when compiling with mingw gcc 7.4.0. The issue can be reproduced easily by running the Alien qsort example in latest vms in both Pharo and Squeak. This PR proposes to patch just the thunkEntry function. Not optimizing just that function solves the issue in our environment, though maybe there is a more fine-grained solution. We should still investigate what is the particular optimization that causes the problem. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353 -- Commit Summary -- * Patch callback thunkEntry to not optimize, failing in win32 using gcc 7.4.0 -- File Changes -- M platforms/Cross/plugins/IA32ABI/ia32abicc.c (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/353

4 4

SqueakFFI 32-bit (win) | int64_t not working for negative integers
by Marcel Taeumel 13 Apr '22

13 Apr '22

Hi all -- This is not working in 32-bit on Windows: FFITestLibrary ffiTest8LongLongSum: -1 with: -1 with: -1 with: -1 with: -1 with: -1 with: -1 with: -1. It answers " 34359738360 " instead of " - 8 ". It's working fine in a 64-bit build. The debugging output in this test functions says: 8 long longs came in as i1 = 4294967295 (ffffffff) i2 = 4294967295 (ffffffff) i3 = 4294967295 (ffffffff) i4 = 4294967295 (ffffffff) i5 = 4294967295 (ffffffff) i6 = 4294967295 (ffffffff) i7 = 4294967295 (ffffffff) i8 = 4294967295 (ffffffff) ... this is clearly wrong. Or is it? On 64-bit, the same function says: 8 long longs came in as i1 = -1 (ffffffffffffffff) i2 = -1 (ffffffffffffffff) i3 = -1 (ffffffffffffffff) i4 = -1 (ffffffffffffffff) i5 = -1 (ffffffffffffffff) i6 = -1 (ffffffffffffffff) i7 = -1 (ffffffffffffffff) i8 = -1 (ffffffffffffffff) Both are formatted via " %lld (%llx) " I am missing something here... did we change the representation of negative integers in Squeak and forgot to update something along ThreadedFFIPlugin >> #ffiIntegerValueOf:? :-/ Best, Marcel *** EXPORT(long long) ffiTest8LongLongSum(long long c1, long long c2, long long c3, long long c4, long long c5, long long c6, long long c7, long long c8) { printf("8 long longs came in as\ni1 = %lld (%llx)\ni2 = %lld (%llx)\ni3 = %lld (%llx)\ni4 = %lld (%llx)\ni5 = %lld (%llx)\ni6 = %lld (%llx)\ni7 = %lld (%llx)\ni8 = %lld (%llx)\n", c1, c1, c2, c2, c3, c3, c4, c4, c5, c5, c6, c6, c7, c7, c8, c8); return c1 + c2 + c3 + c4 + c5 + c6 + c7 + c8; }

2 5

[OpenSmalltalk/opensmalltalk-vm] 80bc70: SqueakFFIPrims source as per VMMaker.oscog-mt.3181
by Marcel Taeumel 13 Apr '22

13 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 80bc7019d2fd35a364edc23da5c8ea9c75b6c123 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/80bc7019d2fd35a364… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64AppleFFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c Log Message: ----------- SqueakFFIPrims source as per VMMaker.oscog-mt.3181 In the FFI plugin, fixes a regression in int64_t support on 32-bit builds, which was due to a mix-up between int64_t and intptr_t. Note that the current design only supports up to 64-bit integer types. If we want to support, for example, 128-bit integer types on a 64-bit machine, we would have to think about a replacement for 'usqLong'. Or even better, we find a way to specialize #ffiArgByValue:in: in subclasses of ThreadedFFIPlugin to use the stack more efficiently.

1 0

VM Maker: VMMaker.oscog-mt.3181.mcz
by commits＠source.squeak.org 13 Apr '22

13 Apr '22

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3181.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3181 Author: mt Time: 13 April 2022, 10:53:52.645201 am UUID: 85dd23b6-7723-a548-811e-6356bd6d5095 Ancestors: VMMaker.oscog-mt.3179 In the FFI plugin, fixes a regression in int64_t support on 32-bit builds, which was due to a mix-up between int64_t and intptr_t. Note that the current design only supports up to 64-bit integer types. If we want to support, for example, 128-bit integer types on a 64-bit machine, we would have to think about a replacement for 'usqLong'. Or even better, we find a way to specialize #ffiArgByValue:in: in subclasses of ThreadedFFIPlugin to use the stack more efficiently. =============== Diff against VMMaker.oscog-mt.3179 =============== Item was changed: ----- Method: ThreadedFFIPlugin>>ffiArgByValue:in: (in category 'callout support') ----- ffiArgByValue: oop in: calloutState "Support for generic callout. Prepare an argument by value for a callout." <var: #calloutState type: #'CalloutState *'> | atomicType intValue floatValue | <inline: true> + <var: #intValue type: #'usqLong'> "Support up to int64_t or uint64_t" atomicType := self atomicTypeOf: calloutState ffiArgHeader. (self isFloatAtomicType: atomicType) ifFalse: [intValue := self ffiIntegerValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]. "N.B. Slang inlines the functions within the dispatchOn:in:with:with: here-in" self cppIf: BytesPerWord = 8 ifTrue: [^self dispatchOn: atomicType in: #( ffiPushVoid:in: "FFITypeVoid" ffiPushUnsigned64:in: "FFITypeBool" ffiPushUnsigned8:in: "FFITypeUnsignedInt8" ffiPushSigned8:in: "FFITypeSignedInt8" ffiPushUnsigned16:in: "FFITypeUnsignedInt16" ffiPushSigned16:in: "FFITypeSignedInt16" ffiPushUnsigned32:in: "FFITypeUnsignedInt32" ffiPushSigned32:in: "FFITypeSignedInt32" ffiPushUnsigned64:in: "FFITypeUnsignedInt64" ffiPushSigned64:in: "FFITypeSignedInt64" ffiPushUnsigned8:in: "FFITypeUnsignedChar8" ffiPushSigned8:in: "FFITypeSignedChar8" ffiPushVoid:in: "ffiPushFloat32:" "FFITypeSingleFloat" ffiPushVoid:in: "ffiPushFloat64:" "FFITypeDoubleFloat" ffiPushUnsigned16:in: "FFITypeUnsignedChar16" ffiPushUnsigned32:in:) "FFITypeUnsignedChar32" with: intValue with: calloutState] ifFalse: [^self dispatchOn: atomicType in: #( ffiPushVoid:in: "FFITypeVoid" ffiPushUnsigned32:in: "FFITypeBool" ffiPushUnsigned8:in: "FFITypeUnsignedInt8" ffiPushSigned8:in: "FFITypeSignedInt8" ffiPushUnsigned16:in: "FFITypeUnsignedInt16" ffiPushSigned16:in: "FFITypeSignedInt16" ffiPushUnsigned32:in: "FFITypeUnsignedInt32" ffiPushSigned32:in: "FFITypeSignedInt32" ffiPushUnsigned64:in: "FFITypeUnsignedInt64" ffiPushSigned64:in: "FFITypeSignedInt64" ffiPushUnsigned8:in: "FFITypeUnsignedChar8" ffiPushSigned8:in: "FFITypeSignedChar8" ffiPushVoid:in: "ffiPushFloat32:" "FFITypeSingleFloat" ffiPushVoid:in: "ffiPushFloat64:" "FFITypeDoubleFloat" ffiPushUnsigned16:in: "FFITypeUnsignedChar16" ffiPushUnsigned32:in:) "FFITypeUnsignedChar32" with: intValue with: calloutState]]. floatValue := self ffiFloatValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]. atomicType = FFITypeSingleFloat ifTrue: [^self ffiPushFloat32: floatValue in: calloutState] ifFalse:[^self ffiPushFloat64: floatValue in: calloutState]! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCreateIntegralResultOop:ofAtomicType:in: (in category 'callout support') ----- ffiCreateIntegralResultOop: retVal ofAtomicType: atomicType in: calloutState <inline: #always> <var: 'calloutState' type: #'CalloutState *'> + <var: 'retVal' type: #usqLong> "Support up to int64_t or uint64_t" - <var: 'retVal' type: #usqLong> "Callout support. Return the appropriate oop for the given atomic type" | shift value mask byteSize | <var: 'value' type: #usqLong> <var: 'mask' type: #usqLong> self deny: (self isFloatAtomicType: atomicType). atomicType = FFITypeBool ifTrue: ["Make sure bool honors the byte size requested" byteSize := calloutState ffiRetHeader bitAnd: FFIStructSizeMask. value := byteSize = (self sizeof: retVal) ifTrue: [retVal] ifFalse: [retVal bitAnd: 1 asUnsignedLongLong << (byteSize * 8) - 1]. ^value = 0 ifTrue: [interpreterProxy falseObject] ifFalse: [interpreterProxy trueObject]]. atomicType <= FFITypeSignedInt32 ifTrue: ["these are all generall integer returns" atomicType <= (BytesPerWord = 8 ifTrue: [FFITypeSignedInt32] ifFalse: [FFITypeSignedInt16]) ifTrue: ["byte/short(/int). first extract partial word, then sign extend" shift := (BytesPerWord = 8 and: [atomicType >= FFITypeUnsignedInt32]) ifTrue: [32] ifFalse: [(atomicType >> 1) * 8]. "# of significant bits" value := retVal bitAnd: (1 asUnsignedLongLong << shift - 1). (atomicType anyMask: 1) ifTrue: ["make the guy signed" mask := 1 asUnsignedLongLong << (shift-1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. ^interpreterProxy integerObjectOf: value]. "Word sized integer return" ^(atomicType anyMask: 1) ifTrue: [interpreterProxy signedMachineIntegerFor: retVal] "signed return" ifFalse: [interpreterProxy positiveMachineIntegerFor: retVal]]. "unsigned return" + "int64_6, uint64_t" - "longlong, char" (atomicType >> 1) = (FFITypeSignedInt64 >> 1) ifTrue: [^(atomicType anyMask: 1) ifTrue: [interpreterProxy signed64BitIntegerFor: retVal] "signed return" ifFalse: [interpreterProxy positive64BitIntegerFor: retVal]]. "unsigned return" + "char" self assert: (self isCharacterAtomicType: atomicType). ^atomicType caseOf: { [FFITypeUnsignedChar8] -> [interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)]. [FFITypeSignedChar8] -> [interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)]. [FFITypeUnsignedChar16] -> [interpreterProxy characterObjectOf: (retVal bitAnd: 16rFFFF)]. [FFITypeUnsignedChar32] -> [interpreterProxy characterObjectOf: (self cCoerce: retVal to: #'unsigned int')] }! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiIntegerValueOf: (in category 'callout support') ----- ffiIntegerValueOf: oop "Support for generic callout. Answer an integer value that is coerced as C would do." <inline: true> + <returnTypeC: #'usqLong'> "Support up to int64_t or uint64_t, at least intptr_t" "Cheat with a tag test" (oop anyMask: BytesPerWord - 1) ifTrue: [(interpreterProxy isIntegerObject: oop) ifTrue: [^interpreterProxy integerValueOf: oop]. self cppIf: SPURVM ifTrue: [(interpreterProxy isCharacterObject: oop) ifTrue: "Immediate in Spur" [^interpreterProxy characterValueOf: oop]. (interpreterProxy isFloatObject: oop) ifTrue: "Immediate in 64-bit Spur" [^interpreterProxy floatValueOf: oop]]] ifFalse: [self cppIf: SPURVM ifTrue: "No non-immediate characters in Spur" [] ifFalse: [(interpreterProxy isCharacterObject: oop) ifTrue: [^interpreterProxy characterValueOf: oop]]. (interpreterProxy isFloatObject: oop) ifTrue: [^interpreterProxy floatValueOf: oop]. oop = interpreterProxy nilObject ifTrue: [^0]. "@@: should we really allow this????" oop = interpreterProxy falseObject ifTrue: [^0]. oop = interpreterProxy trueObject ifTrue: [^1]. (interpreterProxy isLargePositiveIntegerObject: oop) ifTrue: + [^interpreterProxy positive64BitValueOf: oop]. + (interpreterProxy isLargeNegativeIntegerObject: oop) ifTrue: + [^interpreterProxy signed64BitValueOf: oop]]. - [self cppIf: BytesPerWord = 8 "Use cppIf: to get the return type of the function right. Should be sqInt on 32-bits." - ifTrue: [^interpreterProxy positive64BitValueOf: oop] - ifFalse: [^interpreterProxy positive32BitValueOf: oop]]]. ^interpreterProxy signedMachineIntegerValueOf: oop "<- will fail if not integer"! Item was changed: ----- Method: ThreadedFFIPlugin>>isFloatAtomicType: (in category 'primitive support') ----- isFloatAtomicType: atomicTypeCode <inline: true> + "(atomicTypeCode >> 1) = (FFITypeSingleFloat >> 1)" + ^atomicTypeCode >> 1 = 6 ! - ^atomicTypeCode >> 1 = 6! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> + <var: #intRet type: #usqLong> "Support up to int64_t or uint64_t" - <var: #intRet type: #usqLong> <inline: #always> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqLong (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: (self addressOf: intRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSigned32:in: (in category 'marshalling') ----- ffiPushSigned32: value in: calloutState + <var: #value type: #sqInt> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'signed int'). - interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + 4. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSigned64:in: (in category 'marshalling') ----- ffiPushSigned64: value in: calloutState + <var: #value type: #sqLong> - <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsigned32:in: (in category 'marshalling') ----- ffiPushUnsigned32: value in: calloutState + <var: #value type: #usqInt> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState currentArg + 4 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. + interpreterProxy longAt: calloutState currentArg put: (self cCoerceSimple: value to: #'unsigned int'). - interpreterProxy longAt: calloutState currentArg put: value. calloutState currentArg: calloutState currentArg + 4. ^0!

1 0

VM Maker Inbox: VMMaker.oscog-mt.3180.mcz
by commits＠source.squeak.org 12 Apr '22

12 Apr '22

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-mt.3180.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3180 Author: mt Time: 12 April 2022, 3:24:49.887509 pm UUID: adbe155e-2f5f-e643-a586-8da8ae54915c Ancestors: VMMaker.oscog-mt.3179 Quickfix to make at least int32_t and uint32_t ranges work when pushing with Large(Positive|Negative)Integer arguments in an int64_t or uint64_t interface. Note that SmallInteger does not cover int32_t or uint32_t in 32-bit builds. The bigger issue is that #ffiArgByValue:in: is not prepared for an #ffiIntegerValueOf: that answers more than sqInt, which is the current word size. This would also effect, for example, int128_t and uint128_t types in a 64-bit build. But we do not have such types yet. Overall, there is no good support for LargeInteger at this point. :-( =============== Diff against VMMaker.oscog-mt.3179 =============== Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushSigned64:in: (in category 'marshalling') ----- ffiPushSigned64: value in: calloutState + "<var: #value type: #sqLong> -- No support for reading more than 32-bits of a LargeInteger. See #ffiIntegerValueOf:." - <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy + "longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt);" + longAt: calloutState currentArg put: value; + "longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt)." + longAt: calloutState currentArg + 4 put: (value < 0 ifTrue: [16rFFFFFFFF] ifFalse: [0]). - longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); - longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8. ^0! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiPushUnsigned64:in: (in category 'marshalling') ----- ffiPushUnsigned64: value in: calloutState + "<var: #value type: #usqLong> -- No support for reading more than 32-bits of a LargeInteger. See #ffiIntegerValueOf:." - <var: #value type: #usqLong> <var: #calloutState type: #'CalloutState *'> <inline: #always> calloutState currentArg + 8 > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. interpreterProxy + "longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt);" + longAt: calloutState currentArg put: value; + "longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt)." + longAt: calloutState currentArg + 4 put: 0. - longAt: calloutState currentArg put: (self cCoerceSimple: value to: #usqInt); - longAt: calloutState currentArg + 4 put: (self cCoerceSimple: value >> 32 to: #usqInt). calloutState currentArg: calloutState currentArg + 8. ^0!

1 0

VM Maker: VMMakerUI-mt.57.mcz
by commits＠source.squeak.org 11 Apr '22

11 Apr '22

Marcel Taeumel uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-mt.57.mcz ==================== Summary ==================== Name: VMMakerUI-mt.57 Author: mt Time: 11 April 2022, 10:25:28.069975 am UUID: f752708f-00fc-fe4e-b082-82981358e1be Ancestors: VMMakerUI-eem.56 Updates the update dialog: - More compact badges - More compact date-and-time display of last build - Add macOS ARM builds =============== Diff against VMMakerUI-eem.56 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>osvm_GitHubActions_statusBadgeUrl: (in category '*VMMakerUI-updater') ----- osvm_GitHubActions_statusBadgeUrl: workflowName | id | id := workflowName encodeForHTTP. + ^ 'https://raster.shields.io/github/workflow/status/OpenSmalltalk/opensmalltal…' - ^ 'https://raster.shields.io/github/workflow/status/OpenSmalltalk/opensmalltal…' format: {id}! Item was changed: ----- Method: TheWorldMainDockingBar>>osvm_GitHubActions_statusTimestamp: (in category '*VMMakerUI-updater') ----- osvm_GitHubActions_statusTimestamp: workflow "Slow. Fetch HTML page, extract first occurrence of ... <time-ago datetime='2021-08-04T14:24:20Z' ... " | statusPage begin end dateAndTime | statusPage := (WebClient httpGet: (self osvm_GitHubActions_statusPageUrl: workflow)) content. begin := statusPage findString: 'datetime' startingAt: 100000. "Skip the first X bytes decoration." end := statusPage findString: 'Z' startingAt: begin. dateAndTime := DateAndTime readFrom: (statusPage copyFrom: begin + 10 to: end) readStream. ^ String streamContents: [:s | dateAndTime asDate = Date today ifTrue: [s nextPutAll: 'Today' translated, ','] ifFalse: [dateAndTime asDate = Date yesterday ifTrue: [s nextPutAll: 'Yesterday' translated, ','] ifFalse: [dateAndTime printYMDOn: s]]. s space. + (dateAndTime respondsTo: #printHMOn:) + ifTrue: [dateAndTime printHMOn: s] + ifFalse: [dateAndTime printHMSOn: s] ]! - dateAndTime printHMSOn: s]! Item was changed: ----- Method: TheWorldMainDockingBar>>updateVMMaker (in category '*VMMakerUI-updater') ----- updateVMMaker <updater: 'Update VMMaker'> | updater history message | updater := MCMcmUpdater updateMapNamed: 'update.oscog' repository: 'http://source.squeak.org/VMMaker'. updater lastUpdateMap ifEmpty: [ "If this is the first time that you use the updater, start at 5.mcm to avoid loading old code." updater lastUpdateMap at: updater repository put: 5]. history := updater dependentPackages collect: [:package | package name -> (package workingCopy ancestors "N.B. the first version in a package's history will have empty ancestors." ifEmpty: [nil] ifNotEmpty: [:ancestors| ancestors first])] as: OrderedDictionary. updater doUpdate: false. "Set update history to the packages that actually changed." updater dependentPackages do: [:package | | oldVersionInfo newVersionInfo | oldVersionInfo := history at: package name ifAbsent: []. newVersionInfo := package workingCopy ancestors first. (oldVersionInfo ifNil: [0] ifNotNil: [oldVersionInfo versionNumber]) < newVersionInfo versionNumber ifTrue: [history at: package name put: {oldVersionInfo. newVersionInfo}] ifFalse: [history removeKey: package name]]. "Prepare message, including the update history and OSVM ci badges." message := String streamContents: [:s | s nextPutAll: 'VMMaker update succesful. '. history ifEmpty: [s nextPutAll: 'All packages were already up-to-date.'] ifNotEmpty: [s nextPutAll: 'Updated packages:']. history keysAndValuesDo: [:packageName :updateInfo | s nextPutAll: ' - '. s nextPutAll: packageName; space. updateInfo isArray ifFalse: [s nextPutAll: '*removed*' translated] ifTrue: [ updateInfo first ifNil: [s nextPutAll: '*added*' translated] ifNotNil: [s print: updateInfo first versionNumber]. s nextPutAll: ' -> '. s print: updateInfo second versionNumber. s nextPutAll: '']]. s nextPutAll: (' Url: <a href="{1}">{1}</a>' format: {updater repository}). s nextPutAll: ' Map: '; print: updater updateMapName. s nextPutAll: ' '. + #('macOS (x86)' macos 'Build for macOS' + 'macOS (ARM)' 'macos-arm' 'Build for macOS (ARM)' - #('macOS' macos 'Build for macOS' 'Windows' win 'Build for Windows' 'Linux (x86)' linux 'Build for Linux (x86)' 'Linux (ARM)' 'linux-arm' 'Build for Linux (ARM)') groupsDo: [:label :workflow :workflowName | + s nextPutAll: (' <a href="{2}"><img src="{3}" /> {4}</a> {1}' - s nextPutAll: (' {1} status: <a href="{2}"><img src="{3}" /> {4}</a>' format: { label. self osvm_GitHubActions_statusPageUrl: workflow. self osvm_GitHubActions_statusBadgeUrl: workflowName. self osvm_GitHubActions_statusTimestamp: workflow})]. + s nextPutAll: (' Note that updated platform sources might be available, too: <a href="{1}">{1}</a>' format: {'https://github.com/OpenSmalltalk/opensmalltalk-vm'}). - s nextPutAll: (' NOTE THAT updated platform sources might be available, too: -> <a href="{1}">{1}</a>' format: {'https://github.com/OpenSmalltalk/opensmalltalk-vm'}). ]. self inform: message asTextFromHtml.!

3 2

VM Maker: VMMaker.oscog-mt.3178.mcz
by commits＠source.squeak.org 11 Apr '22

11 Apr '22

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3178.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3178 Author: mt Time: 8 April 2022, 4:08:35.320968 pm UUID: 5a32c82a-059d-cc45-bbeb-6dfad10915b0 Ancestors: VMMaker.oscog-mt.3177, VMMaker.oscog-dtl.3124 Merges VMMaker.oscog-dtl.3124. See http://lists.squeakfoundation.org/pipermail/vm-dev/2022-April/037807.html VMMaker.oscog-dtl.3124: Support image formats 68533 and 7033. Add improvements suggested by Eliot. Add FormatNumberTests to verify format number reading and writing. Fix a bug exposed by the tests. VMMaker.oscog-dtl.3123: Support image formats 68533 and 7033. Let the image inform the VM that alternate bytecodes either are or are not in use, and remember the setting when writing or reading the image format number in a shapshot file header. Also support testing the current value of multipleBytecodeSetsActive, and listing the encoder names of supported bytecode sets. Adds two primitives: primitiveMultipleBytecodeSetsActive "Given one boolean parameter, set multipleBytecodeSetsActive to inform the VM that alternate bytecode sets such as SistaV1 are now in use and that the image format number should be updated accordingly. With zero parameters, answer the current value of multipleBytecodeSetsActive." primitiveBytecodeSetsAvailable "Answer the encoder names for the supported bytecode sets." =============== Diff against VMMaker.oscog-mt.3177 =============== Item was added: + TestCase subclass: #FormatNumberTests + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'VMMaker-Tests'! + + !FormatNumberTests commentStamp: 'dtl 12/27/2021 13:02' prior: 0! + FomatNumberTests verifies image format numbers as saved to or loaded from an image snapshot file. Requires package ImageFormat.! Item was added: + ----- Method: FormatNumberTests>>testImageFormatCog (in category 'tests') ----- + testImageFormatCog + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory). + self assert: 6505 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 6505 equals: (interp imageFormatVersionFromSnapshot: 6505) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6505 equals: interp imageFormatVersionForSnapshot. + self assert: 6505 equals: interp imageFormatVersion. + self assert: 6504 equals: (interp imageFormatVersionFromSnapshot: 6504) description: 'image format compatability version'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6505 equals: interp imageFormatVersionForSnapshot. + self assert: 6505 equals: interp imageFormatVersion. + + "multiple bytecode support is not provided for non-Spur images, but confirm that the support code has no ill effects" + self assert: 6505 equals: (interp imageFormatVersionFromSnapshot: 7017) description: 'hypothetical format 7017 does not exist in the wild'. + self assert: interp multipleBytecodeSetsActive. + self assert: 7017 equals: interp imageFormatVersionForSnapshot. "7017 does not exist in practice but is thoretically possible" + self assert: 6505 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver |interp readableFormat: ver ]. + self assert: #(6504 6505) equals: readableNumbers. + ! Item was added: + ----- Method: FormatNumberTests>>testImageFormatSpur32 (in category 'tests') ----- + testImageFormatSpur32 + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager MULTIPLEBYTECODESETS true). + self assert: 6521 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 6521 equals: (interp imageFormatVersionFromSnapshot: 6521) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 6521 equals: interp imageFormatVersionForSnapshot. + self assert: 6521 equals: interp imageFormatVersion. + self assert: 6521 equals: (interp imageFormatVersionFromSnapshot: 7033) description: 'sets multipleBytecodSetsActive as side effect'. + self assert: interp multipleBytecodeSetsActive. + self assert: 7033 equals: interp imageFormatVersionForSnapshot. + self assert: 6521 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver | interp readableFormat: ver ]. + self assert: #(6521 7033) equals: readableNumbers. + ! Item was added: + ----- Method: FormatNumberTests>>testImageFormatSpur64 (in category 'tests') ----- + testImageFormatSpur64 + + | interp readableNumbers | + interp := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur64BitMemoryManager MULTIPLEBYTECODESETS true). + self assert: 68021 equals: interp imageFormatVersion. + self assert: nil equals: interp multipleBytecodeSetsActive description: 'not yet initialized by image load'. + self assert: 68021 equals: (interp imageFormatVersionFromSnapshot: 68021) description: 'clears multipleBytecodSetsActive as side effect'. + self deny: interp multipleBytecodeSetsActive. + self assert: 68021 equals: interp imageFormatVersionForSnapshot. + self assert: 68021 equals: interp imageFormatVersion. + self assert: 68021 equals: (interp imageFormatVersionFromSnapshot: 68533) description: 'sets multipleBytecodSetsActive as side effect'. + self assert: interp multipleBytecodeSetsActive. + self assert: 68533 equals: interp imageFormatVersionForSnapshot. + self assert: 68021 equals: interp imageFormatVersion description: 'base format value not affected by state of multipleBytecodSetsActive'. + readableNumbers := (Smalltalk classNamed: #ImageFormat) knownVersionNumbers + select: [ :ver | interp readableFormat: ver ]. + self assert: #(68021 68533) equals: readableNumbers. + ! Item was changed: VMClass subclass: #InterpreterPrimitives + instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask multipleBytecodeSetsActive' - instanceVariableNames: 'objectMemory messageSelector argumentCount newMethod primFailCode secondaryErrorCode exceptionPC inFFIFlags profileMethod profileProcess profileSemaphore nextProfileTick preemptionYields sHEAFn ffiExceptionResponse eventTraceMask' classVariableNames: 'CrossedX EndOfRun MillisecondClockMask' poolDictionaries: 'VMBasicConstants VMBytecodeConstants VMMethodCacheConstants VMObjectIndices VMSqueakClassIndices VMStackFrameOffsets' category: 'VMMaker-Interpreter'! !InterpreterPrimitives commentStamp: 'eem 9/23/2021 13:20' prior: 0! InterpreterPrimitives implements most of the VM's core primitives. It is the root of the interpreter hierarchy so as to share the core primitives amongst the varioius interpreters. Instance Variables argumentCount <Integer> eventTraceMask <Integer> exceptionPC <Integer> ffiExceptionResponse <Integer> inFFIFlags <Integer> messageSelector <Integer> newMethod <Integer> nextProfileTick <Integer> objectMemory <ObjectMemory> (simulation only) preemptionYields <Boolean> primFailCode <Integer> secondaryErrorCode <Integer> profileMethod <Integer> profileProcess <Integer> profileSemaphore <Integer> sHEAFn <Integer> argumentCount - the number of arguments of the current message eventTraceMask - a bit mask corresponding to the Event type codes in sq.h that decides what events are printed in primitiveGetNextEvent exceptionPC - the pc of an exception for an exception reporting primitive failure such as PrimErrFFIException ffiExceptionResponse - controls system response to exceptions during FFI calls. See primitiveFailForFFIException:at: inFFIFlags - flags recording currently only whether the system is in an FFI call messageSelector - the oop of the selector of the current message newMethod - the oop of the result of looking up the current message nextProfileTick - the millisecond clock value of the next profile tick (if profiling is in effect) objectMemory - the memory manager and garbage collector that manages the heap preemptionYields - a boolean controlling the process primitives. If true (old, incorrect, blue-book semantics) a preempted process is sent to the back of its run-queue. If false, a process preempted by a higher-priority process is put back at the head of its run queue, hence preserving cooperative scheduling within priorities. primFailCode - primitive success/failure flag, 0 for success, otherwise the reason code for failure profileMethod - the primitive method active when the last profile sample was taken (if any) profileProcess - the process active when the last profile sample was taken profileSemaphore - the semaphore to be signalled when a profile sample is taken; if nil disables profiling secondaryErrorCode - a 64-bit value settable for clonable primitive failures (PrimErrOSError, PrimErrFFIException et al) profileMethod - the oop of the method at the time nextProfileTick was reached profileProcess - the oop of the activeProcess at the time nextProfileTick was reached profileSemaphore - the oop of the semaphore to signal when nextProfileTick is reached secondaryErrorCode - an additional value associated with various primitive failures sHEAFn - the function to call to check if access to the envronment should be granted to primitiveGetenv! Item was added: + ----- Method: InterpreterPrimitives>>primitiveBytecodeSetsAvailable (in category 'other primitives') ----- + primitiveBytecodeSetsAvailable + "Answer the encoder names for the supported bytecode sets." + <export: true> + | encoderNames | + argumentCount >0 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + encoderNames := self instantiateClass: self classArray indexableSize: 3. + self storePointer: 0 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3'). + self storePointer: 1 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForV3PlusClosures'). + self storePointer: 2 ofObject: encoderNames withValue: (objectMemory stringForCString: 'EncoderForSistaV1'). + self methodReturnValue: encoderNames. + ! Item was added: + ----- Method: InterpreterPrimitives>>primitiveMultipleBytecodeSetsActive (in category 'other primitives') ----- + primitiveMultipleBytecodeSetsActive + "Given one boolean parameter, set multipleBytecodeSetsActive to inform + the VM that alternate bytecode sets such as SistaV1 are now in use and + that the image format number should be updated accordingly. With zero + parameters, answer the current value of multipleBytecodeSetsActive." + + <export: true> + argumentCount >1 ifTrue: + [^self primitiveFailFor: PrimErrBadNumArgs]. + argumentCount = 1 + ifTrue: [self stackTop = objectMemory trueObject + ifTrue: [self cppIf: MULTIPLEBYTECODESETS + ifTrue: [multipleBytecodeSetsActive := true] + ifFalse: [^self primitiveFailFor: PrimErrUnsupported]] + ifFalse: [self stackTop = objectMemory falseObject + ifTrue: [multipleBytecodeSetsActive := false] + ifFalse:[^self primitiveFailFor: PrimErrBadArgument]]]. + self methodReturnBool: multipleBytecodeSetsActive. + ! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. STACKVM := true. RevisedSuspend := true. "primitiveSuspendBackingUpV1/2 no longer allow a process waiting on a condition variable to go past the condition variable" "These flags identify a GC operation (& hence a reason to leak check), or just operations the leak checker can be run for." GCModeFull := 1. "stop-the-world global GC" GCModeNewSpace := 2. "Spur's scavenge, or V3's incremental" GCModeIncremental := 4. "incremental global gc (Dijkstra tri-colour marking); as yet unimplemented" GCModeBecome := 8. "v3 post-become sweeping/Spur forwarding" GCCheckImageSegment := 16. "just a flag for leak checking image segments" GCCheckFreeSpace := 32. "just a flag for leak checking free space; Spur only" GCCheckShorten := 64. "just a flag for leak checking object shortening operations; Spur only" GCCheckPrimCall := 128. "just a flag for leak checking external primitive calls" StackPageTraceInvalid := -1. StackPageUnreached := 0. StackPageReachedButUntraced := 1. StackPageTraced := 2. MillisecondClockMask := 16r1FFFFFFF. "Note: The external primitive table should actually be dynamically sized but for the sake of inferior platforms (e.g., Mac :-) who cannot allocate memory in any reasonable way, we keep it static (and cross our fingers...)" MaxExternalPrimitiveTableSize := 4096. "entries" FailImbalancedPrimitives := InitializationOptions at: #FailImbalancedPrimitives ifAbsentPut: [true]. EnforceAccessControl := InitializationOptions at: #EnforceAccessControl ifAbsent: [true]. ReturnToInterpreter := 1. "setjmp/longjmp code." "Because of a hack with callbacks in the non-threaded VM they must not conflct with the VM's tag bits." DisownVMForFFICall := 16. + DisownVMForThreading := 32. + + "The multiple bytecodes active bit in the image format number" + MultipleBytecodeSetsBitmask := 512.! - DisownVMForThreading := 32 - ! Item was added: + ----- Method: StackInterpreter>>imageFormatVersionForSnapshot (in category 'image save/restore') ----- + imageFormatVersionForSnapshot + "Snapshot image format includes the state of multipleBytecodeSetsActive, + set the bit when writing a snapshot" + multipleBytecodeSetsActive + ifTrue: [^self imageFormatVersion bitOr: MultipleBytecodeSetsBitmask] + ifFalse: [^self imageFormatVersion]. + ! Item was added: + ----- Method: StackInterpreter>>imageFormatVersionFromSnapshot: (in category 'image save/restore') ----- + imageFormatVersionFromSnapshot: imageVersion + "Snapshot image format includes the state of multipleBytecodeSetsActive, + mask it out when checking compatibility with this interpreter" + + multipleBytecodeSetsActive := (imageVersion bitAnd: MultipleBytecodeSetsBitmask) ~= 0. + ^imageVersion bitAnd: ( -1 - MultipleBytecodeSetsBitmask) + ! Item was changed: ----- Method: StackInterpreter>>readableFormat: (in category 'image save/restore') ----- readableFormat: imageVersion "Anwer true if images of the given format are readable by this interpreter. Allows a virtual machine to accept selected older image formats." <api> + ^objectMemory hasSpurMemoryManagerAPI + ifTrue: [(self imageFormatVersionFromSnapshot: imageVersion) = self imageFormatVersion] + ifFalse: [imageVersion = self imageFormatVersion + or: [imageVersion = self imageFormatCompatibilityVersion "Float words in BigEndian order"]]. + ! - ^imageVersion = self imageFormatVersion "Float words in platform-order" - or: [objectMemory hasSpurMemoryManagerAPI not "No compatibility version for Spur as yet" - and: [imageVersion = self imageFormatCompatibilityVersion]] "Float words in BigEndian order"! Item was changed: ----- Method: StackInterpreter>>writeImageFileIO (in category 'image save/restore') ----- writeImageFileIO "Write the image header and heap contents to imageFile for snapshot. c.f. writeImageFileIOSimulation. The game below is to maintain 64-bit alignment for all putLong:toFile: occurrences." <inline: #never> | imageName headerStart headerSize f imageBytes bytesWritten sCWIfn okToWrite | <var: 'f' type: #sqImageFile> <var: 'headerStart' type: #squeakFileOffsetType> <var: 'sCWIfn' type: #'void *'> <var: 'imageName' declareC: 'extern char imageName[]'> self cCode: [] inSmalltalk: [imageName := 'sooth compiler'. ^self writeImageFileIOSimulation]. "If the security plugin can be loaded, use it to check for write permission. If not, assume it's ok" sCWIfn := self ioLoadFunction: 'secCanWriteImage' From: 'SecurityPlugin'. sCWIfn ~= 0 ifTrue: [okToWrite := self cCode: '((sqInt (*)(void))sCWIfn)()'. okToWrite ifFalse:[^self primitiveFail]]. "local constants" headerStart := 0. headerSize := objectMemory wordSize * 16. "64 or 128; header size in bytes; do not change!!" f := self sqImageFile: imageName Open: 'wb'. (self invalidSqImageFile: f) ifTrue: "could not open the image file for writing" [^self primitiveFailFor: PrimErrOperationFailed]. imageBytes := objectMemory imageSizeToWrite. headerStart := self sqImage: f File: imageName StartLocation: headerSize + imageBytes. self cCode: '/* Note: on Unix systems one could put an exec command here, padded to 512 bytes */'. "position file to start of header" self sqImageFile: f Seek: headerStart. + self putWord32: self imageFormatVersionForSnapshot toFile: f. - self putWord32: self imageFormatVersion toFile: f. self putWord32: headerSize toFile: f. self putLong: imageBytes toFile: f. self putLong: objectMemory baseAddressOfImage toFile: f. self putLong: objectMemory specialObjectsOop toFile: f. self putLong: objectMemory newObjectHash toFile: f. self putLong: self getSnapshotScreenSize toFile: f. self putLong: self getImageHeaderFlags toFile: f. self putWord32: extraVMMemory toFile: f. self putShort: desiredNumStackPages toFile: f. self putShort: self unknownShortOrCodeSizeInKs toFile: f. self putWord32: desiredEdenBytes toFile: f. self putShort: (maxExtSemTabSizeSet ifTrue: [self ioGetMaxExtSemTableSize] ifFalse: [0]) toFile: f. self putShort: the2ndUnknownShort toFile: f. objectMemory hasSpurMemoryManagerAPI ifTrue: [self putLong: objectMemory firstSegmentBytes toFile: f. self putLong: objectMemory bytesLeftInOldSpace toFile: f. 2 timesRepeat: [self putLong: 0 toFile: f] "Pad the rest of the header."] ifFalse: [4 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." objectMemory wordSize = 8 ifTrue: [3 timesRepeat: [self putLong: 0 toFile: f]]. "Pad the rest of the header." self assert: headerStart + headerSize = (self sqImageFilePosition: f). "position file after the header" self sqImageFile: f Seek: headerStart + headerSize. self successful ifFalse: "file write or seek failure" [self sqImageFileClose: f. ^nil]. "write the image data" objectMemory hasSpurMemoryManagerAPI ifTrue: [bytesWritten := objectMemory writeImageSegmentsToFile: f] ifFalse: [bytesWritten := self sq: (self pointerForOop: objectMemory baseAddressOfImage) Image: (self sizeof: #char) File: imageBytes Write: f]. self success: bytesWritten = imageBytes. self sqImageFileClose: f! Item was added: + ----- Method: StackInterpreterSimulator>>multipleBytecodeSetsActive (in category 'accessing') ----- + multipleBytecodeSetsActive + ^multipleBytecodeSetsActive!

2 3

[OpenSmalltalk/opensmalltalk-vm] de14af: CogVM source as per VMMaker.oscog-mt.3179
by Marcel Taeumel 11 Apr '22

11 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: de14af37efb6b0bdb0fcc5cd2795aa5626f77279 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/de14af37efb6b0bdb0… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2022-04-11 (Mon, 11 Apr 2022) Changed paths: M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerpmt.c M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerpmt.c M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-mt.3179 Commit: 580f6b90945bce0e5588a4088d4a0b2425636ba9 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/580f6b90945bce0e55… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2022-04-11 (Mon, 11 Apr 2022) Changed paths: M src/spur32.cog.newspeak/cogitARMv5.c M src/spur32.cog.newspeak/cogitIA32.c M src/spur32.cog.newspeak/cointerp.c M src/spur32.cog.newspeak/gcc3x-cointerp.c M src/spur32.stack.newspeak/gcc3x-interp.c M src/spur32.stack.newspeak/interp.c M src/spur64.cog.newspeak/cogitARMv8.c M src/spur64.cog.newspeak/cogitX64SysV.c M src/spur64.cog.newspeak/cogitX64WIN64.c M src/spur64.cog.newspeak/cointerp.c M src/spur64.cog.newspeak/gcc3x-cointerp.c M src/spur64.stack.newspeak/gcc3x-interp.c M src/spur64.stack.newspeak/interp.c Log Message: ----------- Newspeak source as per VMMaker.oscog-mt.3179 [ci skip] Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/6cd4bb2c46f8...58…

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Hmmm, somehow validImage.c was generated with CR line terminators. (6d38f13)
by Marcel Taeumel 11 Apr '22

11 Apr '22

@eliotmiranda Fixed either via `VMMaker.oscog-mt.3179` or `Multilingual-mt.277` (Trunk). This was a regression from my recent `Locale` refactorings where an instance of a text converter was shared between file streams but should not be shared. -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6d38f13347be103116… You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/commit/6d38f13347be1031168b8b02e8ca52dc1b74be1c/70987377(a)github.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2022