Vm-dev April 2022

vm-dev@lists.squeakfoundation.org

16 participants
71 discussions

[OpenSmalltalk/opensmalltalk-vm] 973240: Fix issue #623. Add -s switch to ar command on Ma...
by Eliot Miranda 21 Apr '22

21 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 97324043f5749da751ad2a060460092cac2e8190 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/97324043f5749da751… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-04-21 (Thu, 21 Apr 2022) Changed paths: M building/macos32x86/common/Makefile.plugin M building/macos64ARMv8/common/Makefile.plugin M building/macos64x64/common/Makefile.plugin Log Message: ----------- Fix issue #623. Add -s switch to ar command on Mac, which runs ranlib.

1 0

Next Release Candidate?
by Marcel Taeumel 19 Apr '22

19 Apr '22

Hi all -- What's you overall feeling of having a new release candidate of the OSVM? Overall pace has been decreasing during the last weeks. Maybe this is a good time then? Latest commit was about 10 hours ago. So, wait for 2-3 days and then tag that version, produce binaries and test those? Best, Marcel

7 32

[OpenSmalltalk/opensmalltalk-vm] Pre-release 202204190959 - 202204190959
by github-actions[bot] 19 Apr '22

19 Apr '22

-- View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/202204190959 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/releases/64727391(a)github.com>

1 0

[OpenSmalltalk/opensmalltalk-vm]
by Marcel Taeumel 19 Apr '22

19 Apr '22

Branch: refs/tags/202204190959 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

[OpenSmalltalk/opensmalltalk-vm] 2a0e78: For macOS platform, fixes regression in -headless ...
by Marcel Taeumel 19 Apr '22

19 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 2a0e7851d0e057b06e77e64a58e155d9c7935e6a https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2a0e7851d0e057b06e… Author: Marcel Taeumel <marcel.taeumel(a)hpi.de> Date: 2022-04-19 (Tue, 19 Apr 2022) Changed paths: M platforms/iOS/vm/Common/Classes/sqSqueakNullScreenAndWindow.m Log Message: ----------- For macOS platform, fixes regression in -headless mode.

1 0

[OpenSmalltalk/opensmalltalk-vm] 1283ba: CogVM source as per VMMaker.oscog-eem.3183
by Eliot Miranda 19 Apr '22

19 Apr '22

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1283ba40038b9fb5dcf56313845364efe1cd25e3 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1283ba40038b9fb5dc… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2022-04-18 (Mon, 18 Apr 2022) Changed paths: M platforms/Cross/vm/sqVirtualMachine.c M platforms/Cross/vm/sqVirtualMachine.h M platforms/iOS/vm/Common/Classes/sqSqueakAppDelegate.m M src/plugins/BitBltPlugin/BitBltPlugin.c M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3183 BitBltPlugin: implement primitivePixelValueAtX:y:put: to complement primitivePixelValueAtX:y:. Reuse the obsolete & unused sendInvokeCallback:Stack:Registers:Jmpbuf: function in the VirtualMachione struct to access storeLong32:ofObject:withValue:.

1 0

VM Maker: VMMaker.oscog-eem.3183.mcz
by commits＠source.squeak.org 19 Apr '22

19 Apr '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3183.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3183 Author: eem Time: 18 April 2022, 6:18:23.56464 pm UUID: c5c103b4-2c5c-44e7-8e32-030e79600ca6 Ancestors: VMMaker.oscog-mt.3182 BitBltPlugin: implement primitivePixelValueAtX:y:put: to complement primitivePixelValueAtX:y:. (in the platform code reuse the obsolete sendInvokeCallback:Stack:Registers:Jmpbuf: function to access storeLong32:ofObject:withValue:). =============== Diff against VMMaker.oscog-mt.3182 =============== Item was added: + ----- Method: BitBltSimulation>>primitivePixelValueAtX:y:put: (in category 'primitives') ----- + primitivePixelValueAtX: xVal y: yVal put: pixel + "Sets the single pixel at x@y. Answers the previous value of the pixel. + It does not handle LSB bitmaps right now. + If x or y are < 0, return 0 to indicate transparent (cf BitBlt>bitPeekerFromForm: usage). + Likewise if x>width or y>depth. + Fail if the rcvr doesn't seem to be a Form, or x|y seem wrong" + <primitiveMetadata: #FastCPrimitiveFlag> + | rcvr bitmap depth ppW stride bitsSize word mask shift oldPixel | + rcvr := self primitive: 'primitivePixelValueAtPut' parameters: #(SmallInteger SmallInteger SmallInteger) receiver: #Oop. + + "check that rcvr is plausibly a Form or subclass" + rcvr := interpreterProxy stackValue: interpreterProxy methodArgumentCount. + ((interpreterProxy isPointers: rcvr) + and: [(interpreterProxy slotSizeOf: rcvr) >= 4]) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + + "get the bits oop and width/height/depth" + bitmap := interpreterProxy fetchPointer: FormBitsIndex ofObject: rcvr. + (interpreterProxy isWordsOrBytes: bitmap) ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + width := interpreterProxy fetchInteger: FormWidthIndex ofObject: rcvr. + height := interpreterProxy fetchInteger: FormHeightIndex ofObject: rcvr. + depth := interpreterProxy fetchInteger: FormDepthIndex ofObject: rcvr. + "if width/height/depth are not integer, fail" + (interpreterProxy failed + or: [depth < 0 "we don't handle LSB Forms yet"]) ifTrue: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + + (xVal < 0 or: [ xVal >= width + or: [yVal < 0 or: [ yVal >= height + or: [pixel < 0]]]] ) ifTrue:[^interpreterProxy primitiveFailFor: PrimErrBadArgument]. + + "OK so now we know we have a plausible Form, the width/height/depth/x/y are all reasonable and it's time to plunder the bitmap" + ppW := 32//depth. "pixels in each word" + stride := (width + (ppW -1)) // ppW. "how many words per row of pixels" + bitsSize := interpreterProxy byteSizeOf: bitmap. + bitsSize >= (stride * height * 4 "bytes per word") ifFalse: + [^interpreterProxy primitiveFailFor: PrimErrBadReceiver]. + word := interpreterProxy fetchLong32: (yVal * stride) + (xVal//ppW) ofObject: bitmap. "load the word that contains our target" + mask := 16rFFFFFFFF >> (32 - depth). "make a mask to isolate the pixel within that word" + shift := 32 - (((xVal bitAnd: ppW-1) + 1) * depth). "this is the tricky MSB part - we mask the xVal to find how far into the word we need, then add 1 for the pixel we're looking for, then * depth to get the bit shift" + oldPixel := word >> shift bitAnd: mask. "shift, mask and dim the lights" + word := ((word bitOr: mask << shift) - (mask << shift)) + (pixel << shift). + interpreterProxy storeLong32: (yVal * stride) + (xVal//ppW) ofObject: bitmap withValue: word. + ^oldPixel asPositiveIntegerObj "pop the incoming and push our answer" + ! Item was removed: - ----- Method: CoInterpreter>>sendInvokeCallback:Stack:Registers:Jmpbuf: (in category 'callback support') ----- - sendInvokeCallback: thunkPtr Stack: stackPtr Registers: regsPtr Jmpbuf: jmpBufPtr - "Override to log and check stack alignment. Since this is an implicit send we need to - log it explicitly. The return side is done via a primitive so that gets logged normally." - cogit assertCStackWellAligned. - cogit recordPrimTrace ifTrue: - [self fastLogPrim: (objectMemory splObj: SelectorInvokeCallback)]. - ^super sendInvokeCallback: thunkPtr Stack: stackPtr Registers: regsPtr Jmpbuf: jmpBufPtr! Item was removed: - ----- Method: Interpreter>>sendInvokeCallback:Stack:Registers:Jmpbuf: (in category 'callback support') ----- - sendInvokeCallback: thunkPtr Stack: stackPtr Registers: regsPtr Jmpbuf: jmpBufPtr - "Send the 4 argument callback message invokeCallback:stack:registers:jmpbuf: - to Alien class with the supplied args. The arguments are raw C addresses - and are converted to integer objects on the way." - | where | - <export: true> - self pushRemappableOop: (self positive32BitIntegerFor: jmpBufPtr). - self pushRemappableOop: (self positive32BitIntegerFor: regsPtr). - self pushRemappableOop: (self positive32BitIntegerFor: stackPtr). - self pushRemappableOop: (self positive32BitIntegerFor: thunkPtr). - receiver := self splObj: ClassAlien. - lkupClass := self fetchClassOfNonImm: receiver. - messageSelector := self splObj: SelectorInvokeCallback. - (self lookupInMethodCacheSel: messageSelector class: lkupClass) ifFalse: - [(self lookupMethodNoMNUEtcInClass: lkupClass) ifFalse: - [^false]]. - primitiveIndex ~= 0 ifTrue: - [^false]. - self storeContextRegisters: activeContext. - self justActivateNewMethod. - where := activeContext + self baseHeaderSize + (ReceiverIndex << self shiftForWord). - self longAt: where + (1 << self shiftForWord) put: self popRemappableOop. - self longAt: where + (2 << self shiftForWord) put: self popRemappableOop. - self longAt: where + (3 << self shiftForWord) put: self popRemappableOop. - self longAt: where + (4 << self shiftForWord) put: self popRemappableOop. - self interpret. - "not reached" - ^true! Item was removed: - ----- Method: InterpreterProxy>>sendInvokeCallback:Stack:Registers:Jmpbuf: (in category 'callback support') ----- - sendInvokeCallback: thunkPtr Stack: stackPtr Registers: regsPtr Jmpbuf: jmpBufPtr - "Send the 4 argument callback message invokeCallback:stack:registers:jmpbuf: - to Alien class with the supplied args. The arguments are raw C addresses - and are converted to integer objects on the way." - <returnTypeC: #sqInt> - self notYetImplemented! Item was added: + ----- Method: InterpreterProxy>>storeLong32:ofObject:withValue: (in category 'object access') ----- + storeLong32: fieldIndex ofObject: oop withValue: anInteger + <var: #anInteger type: #usqInt> + <returnTypeC: #usqInt> + <option: #(atLeastVMProxyMajor:minor: 1 16)> + ((self isIntegerValue: anInteger) + and: [anInteger between: 0 and: 16rFFFFFFFF]) + ifTrue:[^oop instVarAt: fieldIndex+1 put: anInteger] + ifFalse:[^self primitiveFail]! Item was changed: ----- Method: ObjectMemory>>storeLong32:ofObject:withValue: (in category 'object access') ----- storeLong32: fieldIndex ofObject: oop withValue: valueWord + <export: true> - ^ self long32At: oop + self baseHeaderSize + (fieldIndex << 2) put: valueWord! Item was changed: ----- Method: SpurMemoryManager>>storeLong32:ofObject:withValue: (in category 'object access') ----- storeLong32: fieldIndex ofObject: obj withValue: valueWord + <api> ^self long32At: obj + self baseHeaderSize + (fieldIndex << 2) put: valueWord! Item was removed: - ----- Method: StackInterpreter>>sendInvokeCallback:Stack:Registers:Jmpbuf: (in category 'callback support') ----- - sendInvokeCallback: thunkPtr Stack: stackPtr Registers: regsPtr Jmpbuf: jmpBufPtr - "Send the 4 argument callback message invokeCallback:stack:registers:jmpbuf: - to Alien class with the supplied args. The arguments are raw C addresses - and are converted to integer objects on the way." - <export: true> - | classTag | - classTag := self fetchClassTagOfNonImm: (objectMemory splObj: ClassAlien). - messageSelector := self splObj: SelectorInvokeCallback. - argumentCount := 4. - (self lookupInMethodCacheSel: messageSelector classTag: classTag) ifFalse: - [(self lookupOrdinaryNoMNUEtcInClass: (objectMemory classForClassTag: classTag)) ~= 0 ifTrue: - [^false]]. - ((self argumentCountOf: newMethod) = 4 - and: [primitiveFunctionPointer = 0]) ifFalse: - [^false]. - self push: (self splObj: ClassAlien). "receiver" - self push: (self positiveMachineIntegerFor: thunkPtr). - self push: (self positiveMachineIntegerFor: stackPtr). - self push: (self positiveMachineIntegerFor: regsPtr). - self push: (self positiveMachineIntegerFor: jmpBufPtr). - self ifAppropriateCompileToNativeCode: newMethod selector: messageSelector. - self justActivateNewMethod: false. "either interpreted or machine code" - (self isMachineCodeFrame: framePointer) ifFalse: - [self maybeFlagMethodAsInterpreted: newMethod]. - self checkForStackOverflow. - self enterSmalltalkExecutiveFromCallback. - "not reached" - ^true!

1 0

[OpenSmalltalk/opensmalltalk-vm] unable to run the 202112201228 pre-release on mac os 12.3.1 (m1, monterey) (Issue #624)
by Faried Nawaz 15 Apr '22

15 Apr '22

When I launch Squeak from `squeak.cog.spur_macos64ARMv8.dmg`, it crashes immediately and I get a popup asking me to move it to trash. Right-clicking to "open" or launching it from outside the disk doesn't work either. In dmesg's output I see ``` [37037.194729]: build_userspace_exit_reason: illegal flags passed from userspace (some masked off) 0x141, ns: 9, code 0x8 [37037.194799]: Waking up reference: 795Thread waiting on reference 795 woke upASP: Sleep interrupted, signal 0x100 [37037.194972]: ASP: Security policy would not allow process: 41283, /Volumes/squeak.cog.spur_macos64ARMv8/Squeak.app/Contents/MacOS/Squeak ``` I don't want to turn SIP off just for Squeak, and I don't know how to bypass this. I've also tried the latest build from [here](https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/download/l… (dated April 13 2022), and it runs into the same issue. -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/624 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/issues/624(a)github.com>

3 6

VM Maker: VMMaker.oscog-mt.3182.mcz
by commits＠source.squeak.org 14 Apr '22

14 Apr '22

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3182.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3182 Author: mt Time: 14 April 2022, 3:13:29.844637 pm UUID: 42239309-89d2-1742-a787-54dbce98bfdd Ancestors: VMMaker.oscog-mt.3181 In FFI callouts following ARM64 abi, document an issue with pushing structs that are larger than 16 bytes as argument. That is, called functions will always read x0 register as pointer to fetch argument. This currently results in a segmentation fault. Thanks to Tobias (topa) for figuring out this issue! =============== Diff against VMMaker.oscog-mt.3181 =============== Item was changed: ----- Method: ThreadedARM64AppleFFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'unsigned int *'> <var: #calloutState type: #'CalloutState *'> <inline: #always> | availableRegisterSpace stackPartSize roundedSize | + "Stage B, step B.4 -- composite type larger than 16 bytes copied to caller-allocated memory and replaced by pointer" + self flag: #todo. + "See IHI0055B_aapcs64.pdf sections 4.3.5 & 5.4.2 Stage C; we don't yet support HVA's" (self structIsHomogenousFloatArrayOfSize: structSize typeSpec: argSpec ofLength: argSpecSize) ifTrue: [availableRegisterSpace := (NumFloatRegArgs - calloutState floatRegisterIndex) * self wordSize. structSize <= availableRegisterSpace ifTrue: "Stage C, step C.2, all in floating-point registers (!!!!)" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState floatRegisterIndex: calloutState floatRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "Stage C, step C.3" availableRegisterSpace := 0. calloutState floatRegisterIndex: 8] ifFalse: [availableRegisterSpace := (NumIntRegArgs - calloutState integerRegisterIndex) * self wordSize]. stackPartSize := structSize. availableRegisterSpace > 0 ifTrue: [structSize <= availableRegisterSpace ifTrue:"all in integer registers" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState integerRegisterIndex: calloutState integerRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "If no previous co-processor candidate arg has already been pushed on the stack, then split the struct between registers and stack. Otherwise push entire struct on stack." calloutState currentArg = calloutState argVector ifTrue: [stackPartSize := structSize - availableRegisterSpace. self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') _: pointer _: availableRegisterSpace] ifFalse: [availableRegisterSpace := 0]. "Stage C, step C.11" calloutState integerRegisterIndex: NumIntRegArgs]. stackPartSize > 0 ifTrue: [roundedSize := stackPartSize + 3 bitClear: 3. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self alignCurrentArgOf: calloutState to: 8. self memcpy: calloutState currentArg _: (self addressOf: ((self cCoerceSimple: pointer to: #'char *') at: availableRegisterSpace)) _: stackPartSize. calloutState currentArg: calloutState currentArg + roundedSize]. ^0! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiPushStructure:ofSize:typeSpec:ofLength:in: (in category 'marshalling') ----- ffiPushStructure: pointer ofSize: structSize typeSpec: argSpec ofLength: argSpecSize in: calloutState <var: #pointer type: #'void *'> <var: #argSpec type: #'unsigned int *'> <var: #calloutState type: #'CalloutState *'> <inline: #always> | availableRegisterSpace stackPartSize roundedSize | + "Stage B, step B.4 -- composite type larger than 16 bytes copied to caller-allocated memory and replaced by pointer" + self flag: #todo. + "See IHI0055B_aapcs64.pdf sections 4.3.5 & 5.4.2 Stage C; we don't yet support HVA's" (self structIsHomogenousFloatArrayOfSize: structSize typeSpec: argSpec ofLength: argSpecSize) ifTrue: [availableRegisterSpace := (NumFloatRegArgs - calloutState floatRegisterIndex) * self wordSize. structSize <= availableRegisterSpace ifTrue: "Stage C, step C.2, all in floating-point registers (!!!!)" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: calloutState floatRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState floatRegisterIndex: calloutState floatRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "Stage C, step C.3" availableRegisterSpace := 0. calloutState floatRegisterIndex: 8] ifFalse: [availableRegisterSpace := (NumIntRegArgs - calloutState integerRegisterIndex) * self wordSize]. stackPartSize := structSize. availableRegisterSpace > 0 ifTrue: [structSize <= availableRegisterSpace ifTrue:"all in integer registers" [self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: #'void *') _: pointer _: structSize. "Round structSize up and divide by 8 ( NB: _not_ 4 !!)" calloutState integerRegisterIndex: calloutState integerRegisterIndex + (structSize + 7 bitShift: -3). ^0]. "If no previous co-processor candidate arg has already been pushed on the stack, then split the struct between registers and stack. Otherwise push entire struct on stack." calloutState currentArg = calloutState argVector ifTrue: [stackPartSize := structSize - availableRegisterSpace. self memcpy: (self cCoerceSimple: (self addressOf: (calloutState integerRegisters at: calloutState integerRegisterIndex)) to: 'void *') _: pointer _: availableRegisterSpace] ifFalse: [availableRegisterSpace := 0]. "Stage C, step C.11" calloutState integerRegisterIndex: NumIntRegArgs]. stackPartSize > 0 ifTrue: [roundedSize := stackPartSize + 3 bitClear: 3. calloutState currentArg + roundedSize > calloutState limit ifTrue: [^FFIErrorCallFrameTooBig]. self memcpy: calloutState currentArg _: (self addressOf: ((self cCoerceSimple: pointer to: #'char *') at: availableRegisterSpace)) _: stackPartSize. calloutState currentArg: calloutState currentArg + roundedSize]. ^0!

1 0

SqueakFFI ARMv8 (Apple M1) | Struct Arg CRASH
by Marcel Taeumel 13 Apr '22

13 Apr '22

Hi Eliot, hi all -- There is an issue with pushing certain struct args with doubles before the callout. Works fine through Rosetta (macos64x64), crashes otherwise (macos64ARMv8). The following tests produce the crash. A breakpoint in sqFFITestFuncs.c shows that the function args are not correct: FFIPluginTests >> #testSumStructSslf FFIPluginTests >> #testSumStructSslf2 FFIPluginTests >> #testSumStructSslf4 FFIPluginTests >> #testSumStructSSdi5 FFIPluginTests >> #testSumdiStructWithStructSdi4 FFIPluginTests >> #testSumiStructWithStructSdi4 My hypothesis is that there is an issue with pushing integer-float combinations such as: int16_t int64_t float ... slf double int32_t ... di Yet, the funny thing is that the following tests do not crash even though they also use "di" structs: FFIPluginTests >> #testSumStructSdi FFIPluginTests >> #testSumStructSdi2 FFIPluginTests >> #testSumStructSdi4 Since nothing serious happens in sqFFITestFuncs.c and everything is fine on X86(_64) builds, I suspect that argument pushing has a bug. Maybe even on all ARMv8 builds. Could somebody check on Linux? Bruce? Best, Marcel

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2022