This is because of a conflicting definition of error() in sqVirtualMachine.h and in sqAssert.h
Since pharo is building FFI as internal plugin, this makes the build red on windows.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: ce7f664825a5640bdf45a94f83357827f25353e6
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce7f664825a5640bdf…
Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M platforms/Cross/vm/sqAssert.h
Log Message:
-----------
Fix issue #557 (workaround?)
If we build an internal plugin `SQUEAK_BUILTIN_PLUGIN`, then we don't need to `EXPORT` the error/warning functions.
There are still conflicting definitions in sqVirtualMachine.h which totally ignore IMPORT/EXPORT but these only generate warnings, not errors.
Commit: 331b8cdcd21e09e16fd17def87becc1a542591d8
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/331b8cdcd21e09e16f…
Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M platforms/Cross/vm/sqAssert.h
Log Message:
-----------
Merge pull request #558 from OpenSmalltalk/issue_557_export_conflict_on_windows
Fix issue #557 (workaround?) [ci skip] we know we're red
Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/4e791b82c5a2...33…
Branch: refs/heads/issue_557_export_conflict_on_windows
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: ce7f664825a5640bdf45a94f83357827f25353e6
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce7f664825a5640bdf…
Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M platforms/Cross/vm/sqAssert.h
Log Message:
-----------
Fix issue #557 (workaround?)
If we build an internal plugin `SQUEAK_BUILTIN_PLUGIN`, then we don't need to `EXPORT` the error/warning functions.
There are still conflicting definitions in sqVirtualMachine.h which totally ignore IMPORT/EXPORT but these only generate warnings, not errors.