Vm-dev April 2021

vm-dev@lists.squeakfoundation.org

15 participants
95 discussions

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Changes to sq.h and sqAssert.h to accompany commit (aafcb78)
by Tobias Pape 21 Apr '21

21 Apr '21

Problem is that stdio might include features.h -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aafcb78371c7e57607…

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Changes to sq.h and sqAssert.h to accompany commit (aafcb78)
by Nicolas Cellier 21 Apr '21

21 Apr '21

If sqConfig.h WANTS to #define fseek/ftell as fseeko and ftello, then it just has to first #include <stdio.h>. Then any other .c including first "sqConfig.h", then <stdio.h> should just work. This is because <stdio.h> will not be included twice (it is protected by some #ifndef) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aafcb78371c7e57607…

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Changes to sq.h and sqAssert.h to accompany commit (aafcb78)
by Nicolas Cellier 21 Apr '21

21 Apr '21

I'm amazed to not find the IMPORT/EXPORT directives in sqVirtualMachine.h IMO, the right solution is already sketched in minheadless: ``` $ grep -r VM_FUNCTION_EXPORT platforms/ platforms/minheadless/windows/sqPlatformSpecific-Win32.h:# undef VM_FUNCTION_EXPORT platforms/minheadless/windows/sqPlatformSpecific-Win32.h:# define VM_FUNCTION_EXPORT(returnType) __declspec( dllexport ) returnType platforms/minheadless/windows/sqPlatformSpecific-Win32.h:# undef VM_FUNCTION_EXPORT platforms/minheadless/windows/sqPlatformSpecific-Win32.h:# define VM_FUNCTION_EXPORT(returnType) __declspec( dllimport ) returnType ``` The relevant section is: ``` # if defined(BUILD_VM_CORE) && !defined(VM_CORE_STATIC) # undef VM_FUNCTION_EXPORT # define VM_FUNCTION_EXPORT(returnType) __declspec( dllexport ) returnType # else # undef VM_FUNCTION_EXPORT # define VM_FUNCTION_EXPORT(returnType) __declspec( dllimport ) returnType # endif # ``` then we would just have to declare `VM_FUNCTION_EXPORT(some_return_type) some_foo_func( some_arg_type );` in sqVirtualMachine.h. then at compile time, we just use `-DBUILD_VM_CORE` for compiling the VM, but omit it for compiling external plugins. Or maybe we can just use `#if !defined(SQUEAK_BUILTIN_PLUGIN)` in the platform specific file, instead of if defined(BUILD_VM_CORE) && !defined(VM_CORE_STATIC) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aafcb78371c7e57607…

1 0

rescuing linux builds
by Nicolas Cellier 21 Apr '21

21 Apr '21

Hi all, may I suggest that we put a #ifdef HAVE_CONFIG_H # include "config.h" #endif ahead of a few strategic platforms (and src) files so as to rescue the linux build? Currently, the builds fail because of #error directive in config.h... For some files that already include sqConfig.h, just moving sqConfig.h ahead generally also solves the problem... I've tried it with some success...

2 3

primitiveTranslateStringWithTable
by Florin Mateoc 21 Apr '21

21 Apr '21

Hi, While looking at some of the more exotic primitives, I stumbled upon this little gem. I think it's bad enough that it modifies strings in place (some of those could be method literals), but it even modifies symbols in place, without adding them to the symbol table. I would say this is a bug, I don't think symbols should be modified in place (other than by the #intern: method), but this does not look unintentional - apparently ByteSymbol class >> #translate:from:to:table: was added specifically to make the primitive work on symbols too. Does anybody have any insight into this, is this functionality (modifying symbols in place) used anywhere? Thank you, Florin

2 7

clone: -> cloneObject:
by Nicolas Cellier 21 Apr '21

21 Apr '21

Hi all, Eliot, just to inform that I have uploaded a new version Balloon3D-Plugins-nice.17 to http://www.squeaksource.com/Balloon3D The old one did still use clone: Nicolas

1 1

Build failed: opensmalltalk-vm 1.0.2437
by AppVeyor 20 Apr '21

20 Apr '21

1 0

[OpenSmalltalk/opensmalltalk-vm]
by Nicolas Cellier 20 Apr '21

20 Apr '21

Branch: refs/heads/fix_minheadless_build Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

[OpenSmalltalk/opensmalltalk-vm] Fix minheadless build (#559)
by Nicolas Cellier 20 Apr '21

20 Apr '21

At least one minheadless passes on appveyor, mission accomplished, time to merge (Who has two more hours to wait this evening?) You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/559 -- Commit Summary -- * define erro(x) macro rather than error * Finish the clean-up of the 4 unused functions getButtonState & co -- File Changes -- M platforms/minheadless/common/sqPlatformSpecificCommon.h (7) M platforms/minheadless/common/sqWindow-Null.c (4) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/559.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/559.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/559

1 1

[OpenSmalltalk/opensmalltalk-vm] 001841: define erro(x) macro rather than error
by Nicolas Cellier 20 Apr '21

20 Apr '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 00184111ea909b2a19eba6aca05cd3136e249503 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/00184111ea909b2a19… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2021-04-20 (Tue, 20 Apr 2021) Changed paths: M platforms/minheadless/common/sqPlatformSpecificCommon.h Log Message: ----------- define erro(x) macro rather than error Due to a change in the order of headers, the former definition conflicts with the field error in virtual machine structure. Commit: 31f31918c6c6bde220e6dac648644993661f236c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/31f31918c6c6bde220… Author: Nicolas Cellier <nicolas.cellier(a)sirehna.com> Date: 2021-04-20 (Tue, 20 Apr 2021) Changed paths: M platforms/minheadless/common/sqWindow-Null.c Log Message: ----------- Finish the clean-up of the 4 unused functions getButtonState & co Commit: ccf7efbcea6310b5574ba9195fb58facc310f94e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ccf7efbcea6310b557… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2021-04-20 (Tue, 20 Apr 2021) Changed paths: M platforms/minheadless/common/sqPlatformSpecificCommon.h M platforms/minheadless/common/sqWindow-Null.c Log Message: ----------- Merge pull request #559 from OpenSmalltalk/fix_minheadless_build Fix minheadless build Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/331b8cdcd21e...cc…

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev April 2021