instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason ([UI becomes unresponsive because input events are no longer received](http://forum.world.st/ANN-Squeak-5-3-RC1-tp5112435p5112454.html)).
Using `self.window toggleFullScreen:self` also does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).
Please test and review!
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478
-- Commit Summary --
* Use NSWindow API for changing fullscreen mode
-- File Changes --
M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m (24)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.patchhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: eb2ee2c9247dbc4c18249435954b4363db88627e
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/eb2ee2c9247dbc4c18…
Author: Fabio Niephaus <code(a)fniephaus.com>
Date: 2020-02-28 (Fri, 28 Feb 2020)
Changed paths:
M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m
Log Message:
-----------
Use NSWindow API for changing fullscreen mode (#478)
* Use NSWindow API for changing fullscreen mode
instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason (UI becomes unresponsive because input events are no longer received).
Using `self.window toggleFullScreen:self` also does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).
* Address reviewer feedback