instead of going through NSView's API. The latter does offer more options, but messes up the fullscreen mode for some reason ([UI becomes unresponsive because input events are no longer received](http://forum.world.st/ANN-Squeak-5-3-RC1-tp5112435p5112454.html)).
Using `self.window toggleFullScreen:self` also does not mess with additional displays (only the display showing Squeak is put into fullscreen mode).
Please test and review! You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478
-- Commit Summary --
* Use NSWindow API for changing fullscreen mode
-- File Changes --
M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m (24)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/478.diff
nicolas-cellier-aka-nice commented on this pull request.
@@ -48,6 +48,7 @@
extern SqueakOSXAppDelegate *gDelegateApp; extern struct VirtualMachine* interpreterProxy; +extern int getFullScreenFlag();
Just a detail, but should be sqInt
fniephaus commented on this pull request.
@@ -48,6 +48,7 @@
extern SqueakOSXAppDelegate *gDelegateApp; extern struct VirtualMachine* interpreterProxy; +extern int getFullScreenFlag();
Have you given the PR a try locally?
eliotmiranda commented on this pull request.
Personally I loathe and despise (fullScreen == 0) Correct C is !fullScreen. ;-)
And getFullScreenFlag() == (fullScreen == 1) is better written as getFullScreenFlag() == (fullScreen != 0) (or occasionally one will see getFullScreenFlag() == !!fullScreen).
eliotmiranda approved this pull request.
@fniephaus pushed 1 commit.
1b60d38144e319ab8c6e7f2f4b94a8a085da334a Address reviewer feedback [ci skip]
Merged #478 into Cog.
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Fabio Niephaus
-
Nicolas Cellier