> On Jun 10, 2019, at 6:40 AM, Nicolas Cellier <notifications(a)github.com> wrote:
>
> Are we really interested in printing %p , symbolic? (the address of symbolic)
> Aren't we more interested by printing the contents %x , *symbolic?
>
the contents %x , *symbolic certainly
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/32cab0301aa733d578…
Hi all,
Thanks to Ronie, OpenSmalltalkVM CI builds are passing again.
It'd be cool if we could fix some of the known bugs (e.g. keyboard shortcut
issue) and go over open pull requests, so that we can push another release
sometime soon.
Cheers,
Fabio
Hi Eliot,
I will remove the translation to mac-roman, it's just that these dirty
corners speed my progression down.
If i understand correctly, either the legacy polling API is not
internationalization friendly, or maybe the wParam does contain someting
else than utf32/ucs4 code? Do we really need to support legacy polling API?
Sharing platform code forever with old VM is not sustainable, it
complexifies everything, IMO we have a license to cut useless code.
Le mer. 12 juin 2019 à 03:39, Eliot Miranda <notifications(a)github.com> a
écrit :
> Hi Nicolas,
>
> it's put code. Why not just fix it?
>
> On Tue, Jun 11, 2019 at 2:40 PM Nicolas Cellier <notifications(a)github.com>
> wrote:
>
> > I'm somehow amazed to not see a keymap[wParam & 0xff] buffer overrun
> > protection here!
> > This code is probably never executed since the image side presumably
> > provide a non NULL inputSemaphoreIndex, but it's scary.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e47364…
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/ADY5VUCPLK4B7UBYBTM4ZWLP2…
> >
> > .
> >
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e47364…>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAFRYIW3TBYQSMUTZVDSQILP2…>
> .
>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e47364…
I'm somehow amazed to not see a `keymap[wParam & 0xff]` buffer overrun protection here!
This code is probably never executed since the image side presumably provide a non NULL `inputSemaphoreIndex`, but it's scary.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a4a7841030a5e47364…
Are we really interested in printing `%p` , `symbolic`? (the address of symbolic)
Aren't we more interested by printing the contents `%x` , `*symbolic`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/32cab0301aa733d578…
Err, isn't it a regression?
The `TEXT` macro must not be used with `TEXT(string1 string2)` but rather `TEXT(string1) TEXT(string2)`, otherwise it will mix byte and wide string.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d964e7448494bffdb0…