Hi!
does anybody know why isSelfPseudoVariable checks for name = '{{self}}'?
I wrote an script to get the method node of all the methods in the image
and no one sets {{self}} as name of a VariableNode, the key = 'self' if the
one used to identify a VariableNode as a self pseudo var.
Here is the current implementation:
isSelfPseudoVariable
"Answer if this ParseNode represents the 'self' pseudo-variable."
^ key = 'self' or: [name = '{{self}}']
And here the script I wrote:
| method methodNode |
ProtoObject withAllSubclassesDo: [ :aClass |
aClass selectors do: [ :aSelector |
method := aClass >> aSelector.
methodNode := method methodNode.
methodNode nodesDo: [ :node |
(node isSelfPseudoVariable and: [ node name = '{{self}}'])
ifTrue: [self halt].
]]]
Thanks!
Hernan.
--
*Hernán WilkinsonAgile Software Development, Teaching & Coaching*
*Phone: +54-011*-4893-2057
*Twitter: @HernanWilkinson*
*site: http://www.10Pines.com <http://www.10pines.com/>*
Address: Alem 896, Floor 6, Buenos Aires, Argentina
Branch: refs/heads/Nuke_conversion_of_keyValue_to_MacRoman_on_win32
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 557c3bbb50e89e908d845a0b3bc272a3fef2b5fb
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/557c3bbb50e89e908d…
Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>
Date: 2019-06-13 (Thu, 13 Jun 2019)
Changed paths:
M platforms/win32/vm/sqWin32.h
M platforms/win32/vm/sqWin32Main.c
Log Message:
-----------
Fixup: SetupKeymap was removed, don't forget to remove the calls to it!
Branch: refs/heads/Nuke_conversion_of_keyValue_to_MacRoman_on_win32
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 4e34e8a9298241fddc36ff7780189b94597e73ea
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4e34e8a9298241fddc…
Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>
Date: 2019-06-12 (Wed, 12 Jun 2019)
Changed paths:
M platforms/win32/vm/sqWin32Window.c
Log Message:
-----------
Do not convert keyboard event charCode to mac-roman encoding
Image do not use such mac-roman encoding for ages.
On the contrary, images have to undo this translation by sending `macToSqueak` here and there which makes no sense.
We do not need this opensmalltalk VM to be compatible with 15-years old images. Let's clean-up.