Vm-dev February 2019

vm-dev@lists.squeakfoundation.org

33 participants
94 discussions

Re: [Vm-dev] [Cuis-dev] Write Barriers
by ken.dickey＠whidbey.com 07 Feb '19

07 Feb '19

On 2019-02-04 13:26, Gerald Klix via Cuis-dev wrote: .. > I am implementing a package that supports the write barriers > implemented in the current virtual machine. > The package was meant to be an add-on to Cuis-Standard-Image. > Alas, I just discovered, that I have to modify a lot of > #at:put:-primitives to make it work with Array and similar > classes. Therefore I would like have this package integrated > in with current image, once it is finished. Gerald, As a long time advocate of "the simplest thing that will work", I am wondering at what your goal and purpose is here. What cool things are you doing/adding that require a write barrier? Perhaps you should be looking at VMMaker and doing things at the VM level? If so, you might make a case in the vm-dev mailing list for direct support. $0.02, -KenD

4 3

Squeak Oversight Board Election 2019
by Ron Teitelbaum 06 Feb '19

06 Feb '19

Hi All, It's that time again. Time to raise your voices and elect your leaders! Can you believe it's been a year already? It's a time for you to stand up, help your community and volunteer to serve! Squeak wants you! Every year we elect the SOB (Squeak Oversight Board) consisting of seven members from our community. The current board members are: 1. Bert Freudenberg 2. Eliot Miranda 3. Tim Rowledge 4. David T. Lewis 5. Marcel Taeumel 6. Craig Latta 7. Nicolas Cellier For more info on the board please see: https://squeakboard.wordpress.com/our-mission/ Everything about the election, including schedule and more, can be tracked here: http://wiki.squeak.org/squeak/6612 Now until Monday 21nd of January 3 PM (20.00 UTC): Nominations of SOB members and campaigning! Candidates should nominate themselves and start their campaign on the squeak-dev mailing list. Or if you nominate someone else, make sure that person really wants to run. :) I will not put anyone on the candidate list until that person makes it known on squeak-dev that he/she intends to run. During this period, the candidates should ideally present themselves on squeak-dev, unless they have already done so, and the community can ask questions. I encourage you to reach out to potential candidates, people that are active in the community and represent your views, and ask them to run. Some people will not run without encouragement. Also, I know that some people wait to the last minute to run for the board to see if others will run but please consider getting this year off to a faster start and just jump right in! Schedule: Now until Monday 21nd of January 3 PM (20.00 UTC): Nominations of SOB members and campaigning! Monday 21nd of January 2019 3 PM (20.00 UTC): Candidate list is finalized. Monday 21nd of January 2019 4 PM (21.00 UTC): Online election starts. Tuesday 5th of February 2019 4 PM (23.00 UTC): Online election ends. Results will be announced immediately when the election ends. The voting period is two week long and ballots are sent out via email. And how do you end up on the voter list? See below. :) IMPORTANT: New voters will NOT be added once the election is started. You MUST try to get on the voter list before the 21st of January 2019 or you will NOT be able to vote. If your Email has changed please try to make sure it is changed on the list of voters before the election starts. -------------------------- If you were invited to vote last year you are already on the voter list, no worries! If you are a new Squeaker and wish to vote you should do ONE of the following: * Get a "known" Squeaker to vouch for you. If a known Squeaker sends an email to voters (at) squeak.org giving me a name and email for you, then I will add you. * Send an email to voters at squeak.org yourself (and CC to squeak-dev if you like) with information/arguments showing me that you are indeed serious about voting and that you are indeed a Squeaker. When the voting period starts all voters will receive an email with instructions and a link to the voting website. If there are any further questions, just reply *in this thread* and I will closely track it - or send email to voters (at) squeak.org which points to me. ...so let's get on with it! All the best, Ron Teitelbaum

8 22

VM Maker Inbox: VMMaker.oscog-KenD.2518.mcz
by commits＠source.squeak.org 04 Feb '19

04 Feb '19

A new version of VMMaker was added to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-KenD.2518.mcz ==================== Summary ==================== Name: VMMaker.oscog-KenD.2518 Author: KenD Time: 4 February 2019, 12:14:27.621166 pm UUID: 0b3e3f73-87b1-4b35-b4fd-842ccdbdd971 Ancestors: VMMaker.oscog-eem.2517 Struct return in registers works. All FFI tests now pass (need to add more). =============== Diff against VMMaker.oscog-eem.2517 =============== Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- + ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs + "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack + and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil + and the spec from the receiver." + | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | + <inline: true> + <var: #theCalloutState type: #'CalloutState'> + <var: #calloutState type: #'CalloutState *'> + <var: #allocation type: #'char *'> + + primNumArgs := interpreterProxy methodArgumentCount. + (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: + [^self ffiFail: FFIErrorNotFunction]. + "Load and check the values in the externalFunction before we call out" + flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. + interpreterProxy failed ifTrue: + [^self ffiFail: FFIErrorBadArgs]. + + "This must come early for compatibility with the old FFIPlugin. Image-level code + may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." + address := self ffiLoadCalloutAddress: externalFunction. + interpreterProxy failed ifTrue: + [^0 "error code already set by ffiLoadCalloutAddress:"]. + + argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. + "must be array of arg types" + ((interpreterProxy isArray: argTypeArray) + and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: + [^self ffiFail: FFIErrorBadArgs]. + "check if the calling convention is supported" + self cppIf: COGMTVM + ifTrue: + [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: + [^self ffiFail: FFIErrorCallType]] + ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." + [(self ffiSupportsCallingConvention: flags) ifFalse: + [^self ffiFail: FFIErrorCallType]]. + + requiredStackSize := self externalFunctionHasStackSizeSlot + ifTrue: [interpreterProxy + fetchInteger: ExternalFunctionStackSizeIndex + ofObject: externalFunction] + ifFalse: [-1]. + interpreterProxy failed ifTrue: + [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil + ifTrue: [PrimErrBadMethod] + ifFalse: [PrimErrBadReceiver])]. + stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. + self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. + calloutState := self addressOf: theCalloutState. + self cCode: [self me: calloutState ms: 0 et: (self sizeof: #CalloutState)]. + calloutState callFlags: flags. + "Fetch return type and args" + argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. + argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. + argClass := interpreterProxy fetchPointer: 1 ofObject: argType. + (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: + [^self ffiFail: err]. "cannot return" + "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. + Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" + allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. + self mustAlignStack ifTrue: + [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. + calloutState + argVector: allocation; + currentArg: allocation; + limit: allocation + stackSize. + 1 to: nArgs do: + [:i| + argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. + argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. + argClass := interpreterProxy fetchPointer: 1 ofObject: argType. + oop := argArrayOrNil isNil + ifTrue: [interpreterProxy stackValue: nArgs - i] + ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. + err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. + err ~= 0 ifTrue: + [self cleanupCalloutState: calloutState. + self cppIf: COGMTVM ifTrue: + [err = PrimErrObjectMayMove negated ifTrue: + [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." + ^self ffiFail: err]]. "coercion failed or out of stack space" + "Failures must be reported back from ffiArgument:Spec:Class:in:. + Should not fail from here on in." + self assert: interpreterProxy failed not. + self ffiLogCallout: externalFunction. + (requiredStackSize < 0 + and: [self externalFunctionHasStackSizeSlot]) ifTrue: + [stackSize := calloutState currentArg - calloutState argVector. + interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. + "Go out and call this guy" + result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. + self cleanupCalloutState: calloutState. + "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." + interpreterProxy pop: primNumArgs + 1 thenPush: result. + ^result! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" + | myThreadIndex atomicType floatRet intRet x1Ret | - | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> + <var: #x1Ret type: #usqLong> <inline: true> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). + + "If struct address used, place it in x8" + (calloutState structReturnSize > 0 + and: [(self returnStructInRegisters: calloutState structReturnSize) not]) ifTrue: + [self setReturnRegister: calloutState limit]. "stack alloca'd struct" calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). + "Capture x1 immediately. No problem if unused" + x1Ret := self getX1register. + + "If struct returned in registers, + place register values into calloutState integerRegisters" + (calloutState structReturnSize > 0 + and: [self returnStructInRegisters: calloutState structReturnSize]) ifTrue: + ["Only 2 regs used in ARMv8/Aarch64 current" + calloutState integerRegisters at: 0 put: intRet. "X0" + calloutState integerRegisters at: 1 put: x1Ret]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>ffiReturnStruct:ofType:in: (in category 'callout support') ----- + ffiReturnStruct: longLongRet ofType: ffiRetType in: calloutState + <var: #longLongRet type: #usqLong> + <var: #calloutState type: #'CalloutState *'> + "Create a structure return value from an external function call. The value has been stored in + alloca'ed space pointed to by the calloutState or in the return value." + | retOop retClass oop | + <inline: true> + retClass := interpreterProxy fetchPointer: 1 ofObject: ffiRetType. + retOop := interpreterProxy instantiateClass: retClass indexableSize: 0. + self remapOop: retOop + in: [oop := interpreterProxy + instantiateClass: interpreterProxy classByteArray + indexableSize: calloutState structReturnSize]. + self memcpy: (interpreterProxy firstIndexableField: oop) + _: ((self returnStructInRegisters: calloutState structReturnSize) + ifTrue: [self addressOf: calloutState integerRegisters] + ifFalse: [calloutState limit]) + _: calloutState structReturnSize. + interpreterProxy storePointer: 0 ofObject: retOop withValue: oop. + ^retOop! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>getX1register (in category 'callout support') ----- + getX1register + + <inline: true> + <var: #returnX1value declareC: 'extern sqLong returnX1value()'> + + ^self returnX1value! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>returnStructInRegisters: (in category 'marshalling') ----- returnStructInRegisters: returnStructSize + "Answer if a struct result of a given size is able to be returned in registers." + ^returnStructSize <= (2 * self wordSize)! - "Answer if a struct result of a given size is returned in memory or not." - ^returnStructSize <= (2 * self wordSize) "??numIntRegs--> 8 * wordsize??"! Item was added: + ----- Method: ThreadedARM64FFIPlugin>>setReturnRegister: (in category 'callout support') ----- + setReturnRegister: structAddr + + <inline: true> + <var: #structAddr type: #'sqLong'> + <var: #setStructReturnAddressRegister declareC: 'extern void setStructReturnAddressRegister(sqLong structAddr)'> + + self setStructReturnAddressRegister: structAddr! Item was changed: ThreadedFFICalloutState subclass: #ThreadedFFICalloutStateForARM64 instanceVariableNames: 'integerRegisterIndex floatRegisterIndex integerRegisters floatRegisters' classVariableNames: '' poolDictionaries: '' category: 'VMMaker-Plugins-FFI'! + + !ThreadedFFICalloutStateForARM64 commentStamp: 'KenD 2/4/2019 09:57' prior: 0! + A ThreadedFFICalloutStateForARM64 is used to pass FFI parameters for foreign calls. + + Instance Variables + floatRegisterIndex: Integer + floatRegisters: Array of SqInt [64 bit] + integerRegisterIndex: Integer + integerRegisters: Array of Double + + ! Item was changed: ----- Method: ThreadedFFICalloutStateForARM64>>initialize (in category 'initialize-release') ----- initialize super initialize. integerRegisterIndex := 0. + floatRegisterIndex := 0. + resultAddress := 0. "Only used for struct returns which do not fit in registers" - floatRegisterIndex := 0. integerRegisters := CArrayAccessor on: (Array new: ThreadedARM64FFIPlugin numIntRegArgs). + floatRegisters := CArrayAccessor on: (Array new: ThreadedARM64FFIPlugin numFloatRegArgs). + ! - floatRegisters := CArrayAccessor on: (Array new: ThreadedARM64FFIPlugin numFloatRegArgs)! Item was changed: InterpreterPlugin subclass: #ThreadedFFIPlugin instanceVariableNames: 'ffiLogEnabled externalFunctionInstSize ffiLastError allocationMap' classVariableNames: 'DefaultMaxStackSize ExternalFunctionAddressIndex ExternalFunctionArgTypesIndex ExternalFunctionFlagsIndex ExternalFunctionStackSizeIndex MaxNumArgs' poolDictionaries: 'FFIConstants' category: 'VMMaker-Plugins-FFI'! + !ThreadedFFIPlugin commentStamp: 'KenD 1/31/2019 13:57' prior: 0! - !ThreadedFFIPlugin commentStamp: 'eem 1/6/2019 17:35' prior: 0! This plugin provides access to foreign function interfaces on those platforms that provide such. For example Windows DLLs and unix .so's. This version is designed to support reentrancy and threading, and so uses alloca to stack allocate all memory needed for a given callout. Specific platforms are implemented by concrete subclasses. Threaded calls can only be provided within the context of the threaded VM; othewise calls must be blocking. So code specific to threading is guarded with a self cppIf: COGMTVM ifTrue: [...] form to arrange that it is only compiled in the threaded VM context. The callout primitives consume a type spec that defines the signature of the function to be called and a vector of arguments. The type spec may be extracted from the method containing an FFI pragma or as an explicit parameter. The arguments to be passed may either be arguments to the the method containing an FFI pragma or as an explicit Array of parameters. Space is allocated to house the marshalled parameters and the type spec and arguments are then parsed to marshall the actual parameters into that space. The space is some combination of alloc'ed memory for parameters passed on the stack and a "callout state" struct (an instance of ThreadedFFICalloutState) to hold any parameters to be passed in registers. By using C's facilities appropriately we can arrange that the C compiler generates code for passing all parameters, avoiding having to descend to the assembler or machine-code level (*). The basic scheme is to use alloca to stack allocate space for passing stacked parameters, since the memory allocated by alloca s at top-of-stack and in exactly the right place for parameter passing (*), and to invoke the function to be called with as many arguments as there are integer register parameters in the calling convention. For example, on x86/IA32 there are no register parameters and all arguments are passed on the stack, while on ARMv4/5/6 there are four integer register parameters. Since float results are typically answered through a floating-point register and integer/pointer results answered through one (or, on 32-bits for 64-0bit results, two) register. So on x86 the function to be called is invoked using floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)()') or intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqLong (*)()') On ARMv4/5/6 it is invoked with floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) or floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) or intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) + Hence the C compiler generates the code to pass regster parameters appropriately. All we have to do is provide sufficient register parameters and give the function (pointer) to be called a suitable type. - Hence the C compiler generates the code to pass regoster parameters appropriately. All we have to do is provide sufficient register parameters and give the function (pointer) to be called a suitable type. + Likewise we also persuade the C compiler to generate code to load any floating-point register arguments by preceding any call of a function that takes floating-point arguments passed in registers with a call to loadFloatRegs with as many floating-point parameters as there are floating-point parameter registers. loadFloatRegs is implemented in platforms//Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c as an empty function. So floating-point registers are passed via calls such as: - Likewise we also persuade the C compiler to generate code to load any floating-point register arguments by preceding any call of a function that takes floating-point arguments passed in registers with a call to loadFloatRegs with as many floating-point parameters as trhere are floating-point parameter rtegisters. loadFloatRegs is implementyed in platforms//Cross/plugins/SqueakFFIPrims/sqFFIPlugin.c as an empty function. So floating-point registers are passed via calls such as: calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 0)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 2)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 4)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 6)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 8)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 10)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 12)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 14)) to: #'double *') at: 0) (*) some implementations of alloca do not answer the actual top-of-stack, but may answer an address a word or two away. On these implementations we merely derive the top-of-stack instead of using the result of alloca, or perhaps set the stack pointer to the result of alloca, as befits the platform. + Callbacks are not handled by this plugin. Instead they are handled by image-level code to create Alien "thunks", small sequences of machine code, that invoke a function thunkEntry, implemented as required by each platform in one of the files in platforms/Cross/plugins/IA32ABI (a regrettable name; it should be something like platforms/Cross/plugins/AlienCallbacks). Each platform's thunkEntry has a signature that takes all integer register parameters (if any), all floating-point register parameters (if any), a pointer to the thunk, and the stack pointer at the point the thunk was invoiked. To pass a callback to foreign code, the marshaller in this plugin passes the address of the thunk. When external code calls that address the think is invoked, and it invokes thunkEntry as required. thunkEntry then saves its parameters locally in an instance of VMCallbackContext, which includes a jmpbuf. thunkEntry then does a setjmp and enters the VM via sendInvokeCallbackContext[:], which cr eates an activation of invokeCallbackContext: to execute the callback. This method then extracts the address of the thunk from the VMCallbackContext and invokes machinery in Callback to match the address with a Smalltalk block. The block is then evaluated with the parameters extracted from the VMCallbackContext, marshalled by methods in Callback subclasses signatures protocol, which know whether a parameter would be passed in a register or on the stack. The result of the block is then passed back to thunkEntry by storing it in a field in the VMCallbackContext and invoking primSignal:andReturnAs:fromContext:, which uses longjmp to jump back to thunkEntry which then extracts the result from its VMCallbackContext and returns. - Callbacks are not handled by this plugin. Insteasd they are handled by image-level code to create Alien "thunks", small sequences of machine code, that invoke a function thunkEntry, implemented as required by each platform in one of the files in platforms/Cross/plugins/IA32ABI (a regrettable name; it should be something like platforms/Cross/plugins/AlienCallbacks). Each platform's thunkEntry has a signature that takes all integer register parameters (if any), all floating-point register parameters (if any), a pointer to the thunk, and the stack pointer at the point the thunk was invoiked. To pass a callback to foreign code, the marshaller in this plugin passes the address of the tunk. When external code calls that address the think is invoked, and it invokes thunkEntry as required. thunkEntry then saves its parameters locally in an instance of VMCallbackContext, which includes a jmpbuf. thunkEntry then does a setjmp and enters the VM via sendInvokeCallbackContext[:], which cr eates an activation of invokeCallbackContext: to execute the callback. This method then extracts the address of the thunk from the VMCallbackContext and invokes machinery in Callback to match the address with a Smalltalk block. The block is then evaluated with the parameters extracted from the VMCallbackContext, marshalled by methods in Callback subclasses signatures ptotocol, which know whether a parameter would be passed in a register or on the stack. The result of the block is then passed back to thunkEntry by storing it in a field in the VMCallbackContext and invoking primSignal:andReturnAs:fromContext:, which uses longjmp to jump back to thunkEntry which then extracts the result from its VMCallbackContext and returns. For example, the signature of thunkEntry on x86/IA32 (platforms/Cross/plugins/IA32ABI/ia32abicc.c) is long thunkEntry(void *thunkp, sqIntptr_t *stackp) whereas on ARMv4/5/6 (platforms/Cross/plugins/IA32ABI/arm32abicc.c) it is long long thunkEntry(long r0, long r1, long r2, long r3, double d0, double d1, double d2, double d3, double d4, double d5, double d6, double d7, void *thunkpPlus16, sqIntptr_t *stackp)!

1 0

[OpenSmalltalk/opensmalltalk-vm] Handle spaces in VM path name (#369)
by akgrant43 04 Feb '19

04 Feb '19

Modify the launch script templates to handle spaces in the VM path name. dirname takes one or more paths, so if the path has spaces and isn't quoted it is treated as two paths... not what we want. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/369 -- Commit Summary -- * Handle spaces in VM path name -- File Changes -- M platforms/unix/config/bin.squeak.sh.in (2) M platforms/unix/config/squeak.sh.in (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/369.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/369.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/369

1 1

[OpenSmalltalk/opensmalltalk-vm] e8f235: Handle spaces in VM path name
by akgrant43 04 Feb '19

04 Feb '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: e8f235ef313990acae0cda037bb0b35a9c88b7ad https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e8f235ef313990acae… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2019-02-04 (Mon, 04 Feb 2019) Changed paths: M platforms/unix/config/bin.squeak.sh.in M platforms/unix/config/squeak.sh.in Log Message: ----------- Handle spaces in VM path name Modify the launch script templates to handle spaces in the VM path name. dirname takes one or more paths, so if the path has spaces and isn't quoted it is treated as two paths... not what we want. Commit: 694dfe3ed015e16f5b8e9cf17d37e4bdd32bea16 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/694dfe3ed015e16f5b… Author: akgrant43 <akgrant(a)gmail.com> Date: 2019-02-04 (Mon, 04 Feb 2019) Changed paths: M platforms/unix/config/bin.squeak.sh.in M platforms/unix/config/squeak.sh.in Log Message: ----------- Merge pull request #369 from akgrant43/dirname Handle spaces in VM path name Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/7b625603cf6a...69…

1 0

[OpenSmalltalk/opensmalltalk-vm] Remove PharoV50.sources from pharo builds (#365)
by akgrant43 04 Feb '19

04 Feb '19

Pharo generates the sources file for each image, so there's no point shipping an out-of-date sources file with the VM. Thanks to Hilaire for the initial report, see http://forum.world.st/PharoV50-sources-in-VM-td5094603.html I'll submit a PR soon(ish). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/365

2 5

Build failed: opensmalltalk-vm 1.0.1687
by AppVeyor 04 Feb '19

04 Feb '19

1 0

[OpenSmalltalk/opensmalltalk-vm] 365: Remove PharoV50.sources from linux builds (#366)
by akgrant43 04 Feb '19

04 Feb '19

Pharo linux builds are still including PharoV50.sources, which isn't used in any currently supported versions. For Pharo7 and later sources are generated for each build, so there's no need to ever include sources. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/366 -- Commit Summary -- * 365: Remove PharoV50.sources from linux builds -- File Changes -- M build.linux32ARMv6/editpharoinstall.sh (23) M build.linux32x86/editpharoinstall.sh (23) M build.linux64x64/editpharoinstall.sh (23) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/366.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/366.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/366

2 2

[OpenSmalltalk/opensmalltalk-vm] 143bea: 365: Remove PharoV50.sources from linux builds
by akgrant43 04 Feb '19

04 Feb '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 143bea7c1c9316e61aebf35eaf800040bff2e995 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/143bea7c1c9316e61a… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2019-02-02 (Sat, 02 Feb 2019) Changed paths: M build.linux32ARMv6/editpharoinstall.sh M build.linux32x86/editpharoinstall.sh M build.linux64x64/editpharoinstall.sh Log Message: ----------- 365: Remove PharoV50.sources from linux builds Pharo linux builds are still including PharoV50.sources, which isn't used in any currently supported versions. For Pharo7 and later sources are generated for each build, so there's no need to ever include sources. Commit: 7b625603cf6aeb1b05850c5ea0373ea76469525d https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7b625603cf6aeb1b05… Author: akgrant43 <akgrant(a)gmail.com> Date: 2019-02-04 (Mon, 04 Feb 2019) Changed paths: M build.linux32ARMv6/editpharoinstall.sh M build.linux32x86/editpharoinstall.sh M build.linux64x64/editpharoinstall.sh Log Message: ----------- Merge pull request #366 from akgrant43/Issue365 365: Remove PharoV50.sources from linux builds Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b7ca5eda86c6...7b…

1 0

Canceled: OpenSmalltalk/opensmalltalk-vm#1687 (Cog - 3fd0ccd)
by Travis CI 04 Feb '19

04 Feb '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1687 Status: Canceled Duration: 8 mins and 4 secs Commit: 3fd0ccd (Cog) Author: David T. Lewis Message: Merge branch 'Cog' of https://github.com/OpenSmalltalk/opensmalltalk-vm into Cog View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b36d5fc778e1...3f… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/488309886?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2019