Vm-dev December 2019

vm-dev@lists.squeakfoundation.org

31 participants
265 discussions

[OpenSmalltalk/opensmalltalk-vm] Release 201911282316 - 201911282316
by Fabio Niephaus 05 Dec '19

05 Dec '19

-- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/201911282316

1 0

[OpenSmalltalk/opensmalltalk-vm]
by Fabio Niephaus 05 Dec '19

05 Dec '19

Branch: refs/tags/201911282316 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

Re: [Vm-dev] Porting to Alpine Linux aarch64 Raspberry Pi 3B
by ken.dickey＠whidbey.com 04 Dec '19

04 Dec '19

> I would try two things. One is to find out where FILE is defined by > searching the system's include files. There has to be some kind of > definition because e.g. open answers a FILE *. So one /has/ to be able > to > write e.g. > FILE *f = open("foo.txt",... > > and that's all the code is doing, trying to declare a small array of > FILE > *'s. Ya. Attached. The code array uses 'FILE', not 'FILE *', btw. static FILE stdoutStack[STDOUT_STACK_SZ]; Hey, I once used '***' in EPROM boot code -- because I had to! My ol' brain has now rotted and no longer does cdecl. Back to the '80's. I am just confused by this. I don't know enough memory usage context to safely convert to 'FILE *' > The second thing would be to commit a change to sqVirtualMachine.c > which > simply ifdef's out push/popOutputFile if some manifest constant, such > as > CANT_USE_FILE_STAR or DONT_USE_FILE_STAR is defined in the makefile (so > that files are compiled with -DDONT_USE_FILE_STAR=1 or some such). I will continue to play around. Thanks! Part of my confusion is lack of understanding as to why pushOutputFile() side-effects stdout rather than using a global 'output' variable universally. *stdout = *output Just initialize 'output' global on startup an side effect that. Thanks again much for all, -KenD

2 2

Porting to Alpine Linux aarch64 Raspberry Pi 3B
by ken.dickey＠whidbey.com 04 Dec '19

04 Dec '19

Greetings, I am too lazy to do bare metal, but found a very light weight Linux distro which uses Musl and Busybox. Thought was to get basic port up using XFCE desktop then switch to direct framebuffer and not use the desktop. Let someone else do usb and net drivers et al. Unfortunately, I gave away all my C references and it has been a couple of decades since I did anything serious in C. I added -D_GNU_SOURCES to the CFLAGS but am getting a wierd (to me) error. Apparently FILE is #defined as some kind of opaque type? Anyway, breakage in platforms/Cross/vm/sqVirtualMachine.c for pushOutputFile() Can some kind soul help me out with a workaround for this? Thanks a bunch! -KenD

4 4

[OpenSmalltalk/opensmalltalk-vm] libgit build fails because of libssl and libcrypto (#210)
by Javier Pimas 04 Dec '19

04 Dec '19

on /build.linux32x86/pharo.cog.spur/build I run ./mvm and get make[3]: *** No rule to make target '/usr/lib/i386-linux-gnu/libssl.so', needed by 'libgit2.so.0.25.1'. Stop. I worked around it by running sudo ln -s /lib/i386-linux-gnu/libssl.so.1.0.0 /usr/lib/i386-linux-gnu/libssl.so but shouldn't be necessary as libssl is downloaded and built by the script. The same happens with libcrypto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/210

3 4

[OpenSmalltalk/opensmalltalk-vm] BitBlt Segmentation Fault with Magic (2^31) value (#447)
by Patrick R 03 Dec '19

03 Dec '19

The following issue arose during the last few days. On current 64bit Squeak bundles, when setting a morph to an x position being (2 raisedTo: 31) in a world having an InfiniteForm, the VM crashes with a SegFault. This does not happen with (2 raisedTo: 32) or (2 raisedTo: 30). So far I was able to reproduce this on Windows and Linux (have not checked Mac yet). I tried to boil it down to the BitBlt call that causes this with the second example. At the bottom I have attached an example crash.dmp. This does not happen on 32bit bundles. It does occur on older 64bit Squeak releases (e.g. 5.2). ```Smalltalk "Execute this in a World with a texture (InfiniteForm) background" m := CircleMorph new openInWorld. m position: (2 raisedTo: 31)@100. ``` ```Smalltalk patternForm := Form extent: 3 @ 3 depth: 32. port := GrafPort new. port setDestForm: Display. port sourceForm: sourceForm. port fillColor: nil. port combinationRule: Form paint. port sourceRect: (0@0 extent: patternForm boundingBox extent). port destOrigin: (2 raisedTo: 31)@100. port copyBits. ``` ```` /mnt/c/Users/patri/Desktop/swag/teaching/SWA1920/tmp_image/SWA2020Trunk.app/Contents/Linux-x86_64/lib/squeak/5.0-201810190412/squeak Squeak VM version: 5.0-201810190412 Sat Oct 20 08:15:47 UTC 2018 gcc 4.8 [Production Spur 64-bit VM] Built from: CoInterpreter VMMaker.oscog-eem.2461 uuid: b3cd33f5-6309-43a1-b669-7a1805111f34 Oct 20 2018 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2464 uuid: 0b1fa0a3-a781-4fd5-b1cf-1809796ccbbf Oct 20 2018 Revision: VM: 201810190412 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Thu Oct 18 21:12:21 2018 CommitHash: 15341b57 Plugins: 201810190412 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-7e855ac8-57b9-4f6f-bf30-fd6e0ad67398 4.4.0-101-generic #124~14.04.1-Ubuntu SMP Fri Nov 10 19:05:36 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux plugin path: Linux-x86_64/lib/squeak/5.0-201810190412 [default: /mnt/c/Users/patri/Desktop/swag/teaching/SWA1920/tmp_image/SWA2020Trunk.app/Contents/Linux-x86_64/lib/squeak/5.0-201810190412/] C stack backtrace & registers: rax 0xef63a4c0 rbx 0xef63a350 rcx 0xef63a578 rdx 0xef63a408 rdi 0xef63a128 rsi 0xef63a128 rbp 0xef63a298 rsp 0xef63a630 r8 0xef639b68 r9 0xef639c20 r10 0xef639cd8 r11 0xef639d90 r12 0xef639e48 r13 0xef639f00 r14 0xef639fb8 r15 0xef63a070 rip 0xef63a6e8 *[0x7fffef63a6e8] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41b767] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41d1d5] /lib/x86_64-linux-gnu/libpthread.so.0(+0x12890)[0x7f82c2e42890] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4b50c4] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4ba99c] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4baf59] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x458cc7] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(interpret+0xa687)[0x468157] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x469306] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(interpret+0x246)[0x45dd16] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(main+0x2fa)[0x41ac8a] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7f82c2a51b97] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41afb4] [0x0] Smalltalk stack dump: 0x7fffef6963a8 I GrafPort>copyBits 0x26bf808: a(n) GrafPort 0x7fffef6963d8 M UndefinedObject>DoIt 0x29e78e0: a(n) UndefinedObject 0x7fffef696430 I Compiler>evaluateCue:ifFail: 0x26040b0: a(n) Compiler 0x7fffef697dc0 I Compiler>evaluateCue:ifFail:logged: 0x26040b0: a(n) Compiler 0x7fffef697e18 I Compiler>evaluate:in:to:environment:notifying:ifFail:logged: 0x26040b0: a(n) Compiler 0x7fffef697e90 M [] in SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x8864a20: a(n) SmalltalkEditor 0x7fffef697ec8 M BlockClosure>on:do: 0x2604060: a(n) BlockClosure 0x7fffef697f30 I SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x8864a20: a(n) SmalltalkEditor 0x7fffef697f78 I SmalltalkEditor(TextEditor)>evaluateSelection 0x8864a20: a(n) SmalltalkEditor 0x7fffef697fb8 I SmalltalkEditor(TextEditor)>doIt 0x8864a20: a(n) SmalltalkEditor 0x7fffef697fe8 M SmalltalkEditor(TextEditor)>doIt: 0x8864a20: a(n) SmalltalkEditor 0x7fffef698040 I SmalltalkEditor(TextEditor)>dispatchOnKeyboardEvent: 0x8864a20: a(n) SmalltalkEditor 0x7fffef698078 M SmalltalkEditor(TextEditor)>keyStroke: 0x8864a20: a(n) SmalltalkEditor 0x7fffef6980b8 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698108 M TextMorphForEditView(TextMorph)>handleInteraction:fromEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698148 M TextMorphForEditView>handleInteraction:fromEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698198 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6981e8 M ECToolSet class>codeCompletionAround:textMorph:keyStroke: 0x7249388: a(n) ECToolSet class 0x7fffef698230 M ToolSet class>codeCompletionAround:textMorph:keyStroke: 0x2db08c8: a(n) ToolSet class 0x7fffef698278 M TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6982b8 M TextMorphForEditView>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6982f8 M TextMorphForEditView(Morph)>handleKeystroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698338 M TextMorphForEditView(TextMorph)>handleKeystroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698370 M KeyboardEvent>sentTo: 0x2601398: a(n) KeyboardEvent 0x7fffef6983b0 M TextMorphForEditView(Morph)>handleEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6983e8 M TextMorphForEditView(Morph)>handleFocusEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698430 M MorphicEventDispatcher>doHandlingForFocusEvent:with: 0x2600188: a(n) MorphicEventDispatcher 0x7fffef63fe38 M MorphicEventDispatcher>dispatchFocusEvent:with: 0x2600188: a(n) MorphicEventDispatcher 0x7fffef63fe78 M TextMorphForEditView(Morph)>processFocusEvent:using: 0x867ea40: a(n) TextMorphForEditView 0x7fffef63feb8 M TextMorphForEditView(Morph)>processFocusEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef63ff08 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef63ff48 M BlockClosure>ensure: 0x2600070: a(n) BlockClosure 0x7fffef63ff88 M KeyboardEvent(MorphicEvent)>becomeActiveDuring: 0x25ff8b8: a(n) KeyboardEvent 0x7fffef63ffd8 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef640018 M BlockClosure>ensure: 0x25ffea0: a(n) BlockClosure 0x7fffef640058 M HandMorph>becomeActiveDuring: 0x747d0b0: a(n) HandMorph 0x7fffef6400a8 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef6400e8 M BlockClosure>ensure: 0x25ffcd0: a(n) BlockClosure 0x7fffef640128 M PasteUpMorph>becomeActiveDuring: 0x747d000: a(n) PasteUpMorph 0x7fffef640170 M HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef6401c8 M HandMorph>sendEvent:focus:clear: 0x747d0b0: a(n) HandMorph 0x7fffef640210 M HandMorph>sendKeyboardEvent: 0x747d0b0: a(n) HandMorph 0x7fffef640250 M HandMorph>handleEvent: 0x747d0b0: a(n) HandMorph 0x7fffef6402a8 M HandMorph>processEvents 0x747d0b0: a(n) HandMorph 0x7fffef6402e0 M [] in AnimWorldState(WorldState)>doOneCycleNowFor: 0x7488298: a(n) AnimWorldState 0x7fffef640328 M Array(SequenceableCollection)>do: 0x748cdc8: a(n) Array 0x7fffef640360 M AnimWorldState(WorldState)>handsDo: 0x7488298: a(n) AnimWorldState 0x7fffef6403a0 M AnimWorldState(WorldState)>doOneCycleNowFor: 0x7488298: a(n) AnimWorldState 0x7fffef6403d8 M AnimWorldState(WorldState)>doOneCycleFor: 0x7488298: a(n) AnimWorldState 0x7fffef640410 M PasteUpMorph>doOneCycle 0x747d000: a(n) PasteUpMorph 0x7fffef640440 M [] in AnimMorphicProject>spawnNewProcess 0x747cf20: a(n) AnimMorphicProject 0x87c5278 s [] in BlockClosure>newProcess Most recent primitives at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitLengthAt: bitLengthAt: bitLengthAt: maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: basicNew isOfSameSizeCheck: isOfSameSizeCheck: at: at: value:value: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitPosition bitPosition bitPosition << basicNew size on:from:to: on:from:to: at: nextBits:put: nextBits:put: nextBits:put: byteAt:put: byteAt:put: nextBytePut: bitXor: growTo: growTo: max: max: max: max: replaceFrom:to:with:startingAt: encodeLengthField: value value value value value originalContents originalContents originalContents originalContents originalContents nextPutAll: at: at: at: at: size size size size objectAt: basicNew size at: at: at: perform: size header createMethod:class:header: newMethod:header: newMethod:header: newMethod:header: newMethod:header: at: at: at:put: at:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: basicNew withArgs:executeMethod: @ basicNew depth combinationRule: basicNew basicNew width height at: squared squared copyBits stack page bytes 8192 available headroom 5576 minimum unused headroom 6024 (Segmentation fault) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/447

4 7

VM Maker: VMMaker.oscog-eem.2601.mcz
by commits＠source.squeak.org 03 Dec '19

03 Dec '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2601.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2601 Author: eem Time: 3 December 2019, 9:40:27.524843 am UUID: 16ee0b79-1d3a-4ee9-9de4-89d2da8176cd Ancestors: VMMaker.oscog-eem.2600 More work for CogARMv8Compiler. Add concretizeCmpCqR & concretizeMoveMwrR. Fix pc-relative louteral loading in moveCw:intoR:. Now four instructions into generating ceDereferenceSelectorIndex. =============== Diff against VMMaker.oscog-eem.2600 =============== Item was changed: CogAbstractInstruction subclass: #CogARMv8Compiler instanceVariableNames: '' classVariableNames: 'AL AddOpcode AndOpcode CC CS CmpOpcode D0 D1 D10 D11 D12 D13 D14 D15 D16 D17 D18 D19 D2 D20 D21 D22 D23 D24 D25 D26 D27 D28 D29 D3 D30 D31 D4 D5 D6 D7 D8 D9 EQ FP GE GT HI LE LR LS LT MI NE OrOpcode PL R0 R1 R10 R11 R12 R13 R14 R15 R16 R17 R18 R19 R2 R20 R21 R22 R23 R24 R25 R26 R27 R28 R29 R3 R30 R31 R4 R5 R6 R7 R8 R9 SP SXTB SXTH SXTW SXTX SubOpcode UXTB UXTH UXTW UXTX VC VS XorOpcode' poolDictionaries: 'ARMv8A64Opcodes' category: 'VMMaker-JIT'! + !CogARMv8Compiler commentStamp: 'eem 12/3/2019 08:45' prior: 0! - !CogARMv8Compiler commentStamp: 'eem 11/25/2019 16:30' prior: 0! I generate ARMv8 machine code instructions from CogAbstractInstructions with CogRTLOpcodes. Here in "Arm ARM" refers to Arm® Architecture Reference Manual Armv8, for Armv8-A architecture profile + https://developer.arm.com/docs/ddi0487/latest/arm-architecture-reference-ma… + + Some things to know about ARMv8 instructions: + Whether 31 in a register field implies the zero register or the SP register(s) depends on the specific instruction. + + C3.2.1 Load/Store register + If a Load instruction specifies writeback and the register being loaded is also the base register, + then behavior is CONSTRAINED UNPREDICTABLE and one of the following behaviors must occur: + - The instruction is treated as UNDEFINED. + - The instruction is treated as a NOP. + - The instruction performs the load using the specified addressing mode and the base register + becomes UNKNOWN. In addition, if an exception occurs during the execution of such an + instruction, the base address might be corrupted so that the instruction cannot be repeated. + If a Store instruction performs a writeback and the register that is stored is also the base register, + then behavior is CONSTRAINED UNPREDICTABLE and one of the following behaviors must occur: + - The instruction is treated as UNDEFINED. + - The instruction is treated as a NOP. + - The instruction performs the store to the designated register using the specified addressing + mode, but the value stored is UNKNOWN.! - https://developer.arm.com/docs/ddi0487/latest/arm-architecture-reference-ma…! Item was changed: ----- Method: CogARMv8Compiler>>computeMaximumSize (in category 'generate machine code') ----- computeMaximumSize "Because we don't use Thumb, each ARMv8 instruction has 4 bytes. Several abstract opcodes need more than one instruction. Instructions that refer to constants and/or literals depend on literals being stored out-of-line or encoded in immediate instruction fields (i.e. we only support OutOfLineLiteralsManager. N.B. The ^N forms are to get around the bytecode compiler's long branch limits which are exceeded when each case jumps around the otherwise." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^0]. [Literal] -> [^8]. [AlignmentNops] -> [^(operands at: 0) - 4]. [Fill32] -> [^4]. [Nop] -> [^4]. "Control" [Call] -> [^4]. [CallFull] -> [^8]. [JumpR] -> [^4]. [Jump] -> [^4]. [JumpFull] -> [^8]. [JumpLong] -> [^4]. [JumpZero] -> [^4]. [JumpNonZero] -> [^4]. [JumpNegative] -> [^4]. [JumpNonNegative] -> [^4]. [JumpOverflow] -> [^4]. [JumpNoOverflow] -> [^4]. [JumpCarry] -> [^4]. [JumpNoCarry] -> [^4]. [JumpLess] -> [^4]. [JumpGreaterOrEqual] -> [^4]. [JumpGreater] -> [^4]. [JumpLessOrEqual] -> [^4]. [JumpBelow] -> [^4]. [JumpAboveOrEqual] -> [^4]. [JumpAbove] -> [^4]. [JumpBelowOrEqual] -> [^4]. [JumpLongZero] -> [^4]. [JumpLongNonZero] -> [^4]. [JumpFPEqual] -> [^8]. [JumpFPNotEqual] -> [^8]. [JumpFPLess] -> [^8]. [JumpFPGreaterOrEqual] -> [^8]. [JumpFPGreater] -> [^8]. [JumpFPLessOrEqual] -> [^8]. [JumpFPOrdered] -> [^8]. [JumpFPUnordered] -> [^8]. [RetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. [Stop] -> [^4]. "Arithmetic" [AddCqR] -> [^8]. [AndCqR] -> [^8]. [AndCqRR] -> [^8]. [CmpCqR] -> [^8]. [OrCqR] -> [^8]. [SubCqR] -> [^8]. [TstCqR] -> [^8]. [XorCqR] -> [^8]. [AddCwR] -> [^8]. [AndCwR] -> [^8]. [CmpCwR] -> [^8]. [OrCwR] -> [^8]. [SubCwR] -> [^8]. [XorCwR] -> [^8]. [AddRR] -> [^4]. [AndRR] -> [^4]. [CmpRR] -> [^4]. [OrRR] -> [^4]. [XorRR] -> [^4]. [SubRR] -> [^4]. [NegateR] -> [^4]. [LoadEffectiveAddressMwrR]-> [^8 halt]. "I think this is likely 4" [LogicalShiftLeftCqR] -> [^4]. [LogicalShiftRightCqR] -> [^4]. [ArithmeticShiftRightCqR] -> [^4]. [LogicalShiftLeftRR] -> [^4]. [LogicalShiftRightRR] -> [^4]. [ArithmeticShiftRightRR] -> [^4]. [AddRdRd] -> [^4]. [CmpRdRd] -> [^4]. [SubRdRd] -> [^4]. [MulRdRd] -> [^4]. [DivRdRd] -> [^4]. [SqrtRd] -> [^4]. [ClzRR] -> [^4]. "Data Movement" [MoveCqR] -> [^4]. [MoveCwR] -> [^4]. [MoveRR] -> [^4]. [MoveRdRd] -> [^4]. + [MoveAwR] -> [^((operands at: 1) ~= SP + and: [(self isAddressRelativeToVarBase: (operands at: 0)) + or: [cogit addressIsInCurrentCompilation: (operands at: 0)]]) + ifTrue: [4] + ifFalse: [8]]. - [MoveAwR] -> [^((self isAddressRelativeToVarBase: (operands at: 0)) - and: [(operands at: 1) ~= SP]) - ifTrue: [4] - ifFalse: [8]]. [MoveRAw] -> [^((self isAddressRelativeToVarBase: (operands at: 1)) and: [(operands at: 0) ~= SP]) + ifTrue: [4] + ifFalse: [8]]. - ifTrue: [4] - ifFalse: [8]]. [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) + ifTrue: [4] + ifFalse: [8]]. - ifTrue: [4] - ifFalse: [8]]. [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) + ifTrue: [4] + ifFalse: [8]]. - ifTrue: [4] - ifFalse: [8]]. [MoveMwrR] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveRMwr] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveMbrR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveRMbr] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveM16rR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveRM16r] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. [MoveM64rRd] -> [^8]. [MoveRdM64r] -> [^8]. [MoveXbrRR] -> [^4]. [MoveRXbrR] -> [^4]. [MoveXwrRR] -> [^4]. [MoveRXwrR] -> [^4]. [PopR] -> [^4]. [PushR] -> [^4]. [PushCw] -> [self halt]. [PushCq] -> [self halt]. [PrefetchAw] -> [self halt]. "Conversion" [ConvertRRd] -> [^8]. }. ^0 "to keep C compiler quiet" ! Item was added: + ----- Method: CogARMv8Compiler>>concretizeCmpCqR (in category 'generate machine code - concretize') ----- + concretizeCmpCqR + "Will get inlined into concretizeAt: switch." + <inline: true> + | constant rn offset | + constant := operands at: 0. + rn := operands at: 1. + + self is6BitSignedImmediate: constant + ifTrue: + [:immediate : negate| + "C6.2.46 CCMN (immediate) C6-833 + C6.2.48 CCMP (immediate) C6-837" + machineCode + at: 0 + put: 2r11111010010000000000100000001111 + + (AL << 12) + + (negate ifTrue: [1 << 30] ifFalse: [0]) + + (immediate << 16) + + (rn << 5). + ^machineCodeSize := 4] + ifFalse: []. + offset := self moveCw: constant intoR: RISCTempReg. + "C6.2.49 CCMP (register) C6-839" + machineCode + at: offset // 4 + put: 2r11111010010000000000000000001111 + + (AL << 12) + + (RISCTempReg << 16) + + (rn << 5). + ^machineCodeSize := offset + 4! Item was added: + ----- Method: CogARMv8Compiler>>concretizeMoveMwrR (in category 'generate machine code - concretize') ----- + concretizeMoveMwrR + <inline: true> + | srcReg offset destReg | + <var: #offset type: #sqInt> + offset := operands at: 0. + srcReg := operands at: 1. + destReg := operands at: 2. + machineCode + at: 0 + put: (self ldrn: srcReg rt: destReg imm: offset shiftBy12: false). + ^machineCodeSize := 4! Item was changed: ----- Method: CogARMv8Compiler>>dispatchConcretize (in category 'generate machine code') ----- dispatchConcretize "Attempt to generate concrete machine code for the instruction at address. This is the inner dispatch of concretizeAt: actualAddress which exists only to get around the branch size limits in the SqueakV3 (blue book derived) bytecode set." <returnTypeC: #void> opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^self concretizeLabel]. [Literal] -> [^self concretizeLiteral]. [AlignmentNops] -> [^self concretizeAlignmentNops]. [Fill32] -> [^self concretizeFill32]. [Nop] -> [^self concretizeNop]. "Control" [Call] -> [^self concretizeCall]. "call code within code space" [CallFull] -> [^self concretizeCallFull]. "call code anywhere in address space" [JumpR] -> [^self concretizeJumpR]. [JumpFull] -> [^self concretizeJumpFull]."jump within address space" [JumpLong] -> [^self concretizeConditionalJump: AL]."jumps witihn code space" [JumpLongZero] -> [^self concretizeConditionalJump: EQ]. [JumpLongNonZero] -> [^self concretizeConditionalJump: NE]. [Jump] -> [^self concretizeConditionalJump: AL]. [JumpZero] -> [^self concretizeConditionalJump: EQ]. [JumpNonZero] -> [^self concretizeConditionalJump: NE]. [JumpNegative] -> [^self concretizeConditionalJump: MI]. [JumpNonNegative] -> [^self concretizeConditionalJump: PL]. [JumpOverflow] -> [^self concretizeConditionalJump: VS]. [JumpNoOverflow] -> [^self concretizeConditionalJump: VC]. [JumpCarry] -> [^self concretizeConditionalJump: CS]. [JumpNoCarry] -> [^self concretizeConditionalJump: CC]. [JumpLess] -> [^self concretizeConditionalJump: LT]. [JumpGreaterOrEqual] -> [^self concretizeConditionalJump: GE]. [JumpGreater] -> [^self concretizeConditionalJump: GT]. [JumpLessOrEqual] -> [^self concretizeConditionalJump: LE]. [JumpBelow] -> [^self concretizeConditionalJump: CC]. "unsigned lower" [JumpAboveOrEqual] -> [^self concretizeConditionalJump: CS]. "unsigned greater or equal" [JumpAbove] -> [^self concretizeConditionalJump: HI]. [JumpBelowOrEqual] -> [^self concretizeConditionalJump: LS]. [JumpFPEqual] -> [^self concretizeFPConditionalJump: EQ]. [JumpFPNotEqual] -> [^self concretizeFPConditionalJump: NE]. [JumpFPLess] -> [^self concretizeFPConditionalJump: LT]. [JumpFPGreaterOrEqual] -> [^self concretizeFPConditionalJump: GE]. [JumpFPGreater] -> [^self concretizeFPConditionalJump: GT]. [JumpFPLessOrEqual] -> [^self concretizeFPConditionalJump: LE]. [JumpFPOrdered] -> [^self concretizeFPConditionalJump: VC]. [JumpFPUnordered] -> [^self concretizeFPConditionalJump: VS]. [RetN] -> [^self concretizeRetN]. [Stop] -> [^self concretizeStop]. "Arithmetic" [AddCqR] -> [^self concretizeNegateableDataOperationCqR: AddOpcode]. [AndCqR] -> [^self concretizeInvertibleDataOperationCqR: AndOpcode]. [AndCqRR] -> [^self concretizeAndCqRR]. + [CmpCqR] -> [^self concretizeCmpCqR]. - [CmpCqR] -> [^self concretizeNegateableDataOperationCqR: CmpOpcode]. [OrCqR] -> [^self concretizeDataOperationCqR: OrOpcode]. [SubCqR] -> [^self concretizeSubCqR]. [TstCqR] -> [^self concretizeTstCqR]. [XorCqR] -> [^self concretizeInvertibleDataOperationCqR: XorOpcode]. [AddCwR] -> [^self concretizeDataOperationCwR: AddOpcode]. [AndCwR] -> [^self concretizeDataOperationCwR: AndOpcode]. [CmpCwR] -> [^self concretizeDataOperationCwR: CmpOpcode]. [OrCwR] -> [^self concretizeDataOperationCwR: OrOpcode]. [SubCwR] -> [^self concretizeDataOperationCwR: SubOpcode]. [XorCwR] -> [^self concretizeDataOperationCwR: XorOpcode]. [AddRR] -> [^self concretizeDataOperationRR: AddOpcode]. [AndRR] -> [^self concretizeDataOperationRR: AndOpcode]. [CmpRR] -> [^self concretizeDataOperationRR: CmpOpcode]. [OrRR] -> [^self concretizeDataOperationRR: OrOpcode]. [SubRR] -> [^self concretizeDataOperationRR: SubOpcode]. [XorRR] -> [^self concretizeDataOperationRR: XorOpcode]. [AddRdRd] -> [^self concretizeAddRdRd]. [CmpRdRd] -> [^self concretizeCmpRdRd]. [DivRdRd] -> [^self concretizeDivRdRd]. [MulRdRd] -> [^self concretizeMulRdRd]. [SubRdRd] -> [^self concretizeSubRdRd]. [SqrtRd] -> [^self concretizeSqrtRd]. [NegateR] -> [^self concretizeNegateR]. [LoadEffectiveAddressMwrR] -> [^self concretizeLoadEffectiveAddressMwrR]. [ArithmeticShiftRightCqR] -> [^self concretizeArithmeticShiftRightCqR]. [LogicalShiftRightCqR] -> [^self concretizeLogicalShiftRightCqR]. [LogicalShiftLeftCqR] -> [^self concretizeLogicalShiftLeftCqR]. [ArithmeticShiftRightRR] -> [^self concretizeArithmeticShiftRightRR]. [LogicalShiftLeftRR] -> [^self concretizeLogicalShiftLeftRR]. [LogicalShiftRightRR] -> [^self concretizeLogicalShiftRightRR]. [ClzRR] -> [^self concretizeClzRR]. "Data Movement" [MoveCqR] -> [^self concretizeMoveCqR]. [MoveCwR] -> [^self concretizeMoveCwR]. [MoveRR] -> [^self concretizeMoveRR]. [MoveAwR] -> [^self concretizeMoveAwR]. [MoveRAw] -> [^self concretizeMoveRAw]. [MoveAbR] -> [^self concretizeMoveAbR]. [MoveRAb] -> [^self concretizeMoveRAb]. [MoveMbrR] -> [^self concretizeMoveMbrR]. [MoveRMbr] -> [^self concretizeMoveRMbr]. [MoveRM16r] -> [^self concretizeMoveRM16r]. [MoveM16rR] -> [^self concretizeMoveM16rR]. [MoveM64rRd] -> [^self concretizeMoveM64rRd]. [MoveMwrR] -> [^self concretizeMoveMwrR]. [MoveXbrRR] -> [^self concretizeMoveXbrRR]. [MoveRXbrR] -> [^self concretizeMoveRXbrR]. [MoveXwrRR] -> [^self concretizeMoveXwrRR]. [MoveRXwrR] -> [^self concretizeMoveRXwrR]. [MoveRMwr] -> [^self concretizeMoveRMwr]. [MoveRdM64r] -> [^self concretizeMoveRdM64r]. [PopR] -> [^self concretizePopR]. [PushR] -> [^self concretizePushR]. [PushCq] -> [^self concretizePushCq]. [PushCw] -> [^self concretizePushCw]. [PrefetchAw] -> [^self concretizePrefetchAw]. "Conversion" [ConvertRRd] -> [^self concretizeConvertRRd]. [ConvertRdR] -> [^self concretizeConvertRdR]. [ConvertRRs] -> [^self concretizeConvertRRs]. [ConvertRsR] -> [^self concretizeConvertRsR]. [ConvertRsRd] -> [^self concretizeConvertRsRd]. [ConvertRdRs] -> [^self concretizeConvertRdRs]. [SignExtend8RR] -> [^self concretizeSignExtend8RR]. [SignExtend16RR] -> [^self concretizeSignExtend16RR]. [SignExtend32RR] -> [^self concretizeSignExtend32RR]. [ZeroExtend8RR] -> [^self concretizeZeroExtend8RR]. [ZeroExtend16RR] -> [^self concretizeZeroExtend16RR]. [ZeroExtend32RR] -> [^self concretizeZeroExtend32RR].}! Item was added: + ----- Method: CogARMv8Compiler>>is6BitSignedImmediate:ifTrue:ifFalse: (in category 'generate machine code - support') ----- + is6BitSignedImmediate: constant ifTrue: binaryBlock ifFalse: nullaryBlock + <inline: #always> + (constant between: -1 << 5 and: 1 << 5) + ifTrue: + [binaryBlock + value: constant abs + value: constant < 0] + ifFalse: [nullaryBlock value]! Item was added: + ----- Method: CogARMv8Compiler>>ldrn:rt:imm:shiftBy12: (in category 'generate machine code - support') ----- + ldrn: srcReg rt: targetReg imm: offset shiftBy12: shiftBy12 + "C6.2.130 LDR (immediate) C6-976 + C6.2.166 LDUR C6-1058" + + self deny: srcReg = targetReg. + "Unsigned offset, C6-1058" + (offset \\ 8 = 0 + and: [offset / 8 between: 0 and: 1 << 12 - 1]) ifTrue: + [^2r1111100101 << 22 + + (offset << 7 "10 - 3") + + (srcReg << 5) + + targetReg]. + self assert: (offset between: -256 and: 255). + "Signed 9-bit offset, C6-976" + ^2r11111000010000000000110000000000 + + ((offset bitAnd: 511) << 12) + + (srcReg << 5) + + targetReg! Item was changed: ----- Method: CogARMv8Compiler>>moveCw:intoR: (in category 'generate machine code - support') ----- moveCw: constant intoR: destReg + "Emit a load of constant into destReg. Answer the number of bytes of machine code + generated. Literals are stored out-of-line; emit a LDR (literal) with the relevant offset." - "Emit a load of aWord into destReg. Answer the number of bytes of machine code generated. - Literals are stored out-of-line; emit a LDR with the relevant offset." <var: 'constant' type: #usqInt> <inline: true> + self deny: destReg = SP. self assert: (cogit addressIsInCurrentCompilation: dependent address). + self assert: dependent address \\ 4 = 0. + self assert: (dependent address - address) abs < (1<<18). - self assert: (dependent address bitAnd: 3) = 0. - self assert: (dependent address - address) abs < (1<<19). "C6.2.131 LDR (literal) C6-979" machineCode at: 0 + put: 2r01011 << 27 + + (dependent address - address << 3 "5 - 2") + + destReg. - put: 2r01011000 << 24 - + destReg - + ((dependent address - (address + 8) bitAnd: 1 << 19 - 1) << 5). ^machineCodeSize := 4! Item was added: + ----- Method: CogARMv8Compiler>>outOfLineLiteralOpcodeLimit (in category 'generate machine code') ----- + outOfLineLiteralOpcodeLimit + "The maximum offset in a LDR (literal) is -2^18 to 2^18-1. + And this is multiplied by 4 to produce the effective address. + This is a huge range; we have no grounds for concern." + ^1 << 18 - 1! Item was changed: ----- Method: CogARMv8Compiler>>strn:rt:imm:shiftBy12: (in category 'generate machine code - support') ----- strn: srcReg rt: targetReg imm: offset shiftBy12: shiftBy12 "C6.2.273 STR (immediate) C6-1239 C6.2.297 STUR C6-1290" self deny: srcReg = SP. + self deny: srcReg = targetReg. "Unsigned offset, C6-1240" (offset \\ 8 = 0 and: [offset / 8 between: 0 and: 1 << 12 - 1]) ifTrue: [^2r1111100100 << 22 + (offset << 7 "10 - 3") + (targetReg << 5) + srcReg]. self assert: (offset between: -256 and: 255). ^2r11111000000 << 21 + ((offset bitAnd: 511) << 12) + (targetReg << 5) + srcReg! Item was changed: + ----- Method: CogOutOfLineLiteralsARMCompiler>>outOfLineLiteralOpcodeLimit (in category 'generate machine code') ----- - ----- Method: CogOutOfLineLiteralsARMCompiler>>outOfLineLiteralOpcodeLimit (in category 'compile abstract instructions') ----- outOfLineLiteralOpcodeLimit "The maximum offset in a LDR is (1<<12)-1, or (1<<10)-1 instructions. Be conservative. The issue is that one abstract instruction can emit multiple hardware instructions so we assume a 2 to 1 worst case of hardware instructions to abstract opcodes.." ^1 << (12 "12-bit offset field" - 2 "4 bytes per literal" - 1 "2 hardware instructions to 1 abstract opcode") - 1!

1 0

[OpenSmalltalk/opensmalltalk-vm] Reproduceable Segmentation fault while saving images (#444)
by Juraj Kubelka 03 Dec '19

03 Dec '19

Executing the following script produces a segmentation fault: ```Smalltalk | aJson anArray | aJson := ZnEasy get: 'https://data.nasa.gov/resource/y77d-th95.json' asZnUrl. Array streamContents: [ :aStream | 400 timesRepeat: [ aStream nextPutAll: (STON fromString: aJson contents). Smalltalk saveSession ] ]. ``` [crash.dmp.txt](https://github.com/OpenSmalltalk/opensmalltalk-vm/files/3843… Reproduced on Pharo 8 Mac OS: ``` Image ----- Pharo8.0.0 Build information: Pharo-8.0.0+build.972.sha.bbb812d1387fd27ef4096e35224cb4425a60ab6c (64 Bit) Unnamed Virtual Machine --------------- /Users/.../Pharo/vms/80-x64/Pharo.app/Contents/MacOS/Pharo CoInterpreter VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 VM: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Sat Jan 5 20:00:11 2019 CommitHash: 7a3c6b6 Plugins: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Mac OS X built on Jan 5 2019 19:11:02 UTC Compiler: 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31) VMMaker versionString VM: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Sat Jan 5 20:00:11 2019 CommitHash: 7a3c6b6 Plugins: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git CoInterpreter VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 ``` Also reproduced on Pharo 8 Mac OS: ``` Virtual Machine --------------- /Users/syrel/Documents/Pharo/images/GToolkit/../../vms/80-x64/Pharo.app/Contents/MacOS/Pharo CoInterpreter VMMaker.oscog-eem.2570 uuid: b61e294a-cb2a-4d9a-9e7e-8cc17676c920 Oct 16 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2570 uuid: b61e294a-cb2a-4d9a-9e7e-8cc17676c920 Oct 16 2019 VM: 201910161212 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Wed Oct 16 14:12:15 2019 CommitHash: da97dd5 Plugins: 201910161212 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Mac OS X built on Oct 16 2019 12:39:27 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42) ``` Also reproduced on Pharo 8 Linux Ubuntu 18.04: ``` Pharo VM version: 5.0-201902062351 Wed Feb 6 23:59:26 UTC 2019 gcc 4.8 [Production Spur 64-bit VM] Built from: CoInterpreter VMMaker.oscog-eem.2509 uuid: 91e81f64-95de-4914-a960-8f842be3a194 Feb 6 2019 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2509 uuid: 91e81f64-95de-4914-a960-8f842be3a194 Feb 6 2019 Revision: VM: 201902062351 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Wed Feb 6 15:51:18 2019 CommitHash: a838346b Plugins: 201902062351 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-f2b22483-7f84-414f-b833-69f69518c685 4.4.0-101-generic #124~14.04.1-Ubuntu SMP Fri Nov 10 19:05:36 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux plugin path: /dev/shm/p8/pharo-vm/lib/pharo/5.0-201902062351 [default: /dev/shm/p8/pharo-vm/lib/pharo/5.0-201902062351/] ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/444

16 55

VM Maker: VMMaker.oscog-eem.2600.mcz
by commits＠source.squeak.org 03 Dec '19

03 Dec '19

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2600.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2600 Author: eem Time: 2 December 2019, 7:51:20.659048 pm UUID: fb9c3e90-4faf-4812-a5a1-2d28197e4a88 Ancestors: VMMaker.oscog-eem.2599 More work for CogARMv8Compiler. Add register assignments. Add concretizeLiteral & concretizeMoveRAw. Hence ceCaptureCStackPointers is now generated. In-image compilation: Update CurrentImageCoInterpreterFacade now the C stack pointers live in the CoInterpreter. =============== Diff against VMMaker.oscog-eem.2599 =============== Item was changed: ----- Method: CogARMv8Compiler>>computeMaximumSize (in category 'generate machine code') ----- computeMaximumSize "Because we don't use Thumb, each ARMv8 instruction has 4 bytes. Several + abstract opcodes need more than one instruction. Instructions that refer to + constants and/or literals depend on literals being stored out-of-line or encoded + in immediate instruction fields (i.e. we only support OutOfLineLiteralsManager. - abstract opcodes need more than one instruction. Instructions that refer - to constants and/or literals depend on literals being stored in-line or out-of-line. N.B. The ^N forms are to get around the bytecode compiler's long branch limits which are exceeded when each case jumps around the otherwise." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^0]. + [Literal] -> [^8]. - [Literal] -> [^4]. [AlignmentNops] -> [^(operands at: 0) - 4]. [Fill32] -> [^4]. [Nop] -> [^4]. "Control" [Call] -> [^4]. [CallFull] -> [^8]. [JumpR] -> [^4]. [Jump] -> [^4]. [JumpFull] -> [^8]. [JumpLong] -> [^4]. [JumpZero] -> [^4]. [JumpNonZero] -> [^4]. [JumpNegative] -> [^4]. [JumpNonNegative] -> [^4]. [JumpOverflow] -> [^4]. [JumpNoOverflow] -> [^4]. [JumpCarry] -> [^4]. [JumpNoCarry] -> [^4]. [JumpLess] -> [^4]. [JumpGreaterOrEqual] -> [^4]. [JumpGreater] -> [^4]. [JumpLessOrEqual] -> [^4]. [JumpBelow] -> [^4]. [JumpAboveOrEqual] -> [^4]. [JumpAbove] -> [^4]. [JumpBelowOrEqual] -> [^4]. [JumpLongZero] -> [^4]. [JumpLongNonZero] -> [^4]. [JumpFPEqual] -> [^8]. [JumpFPNotEqual] -> [^8]. [JumpFPLess] -> [^8]. [JumpFPGreaterOrEqual] -> [^8]. [JumpFPGreater] -> [^8]. [JumpFPLessOrEqual] -> [^8]. [JumpFPOrdered] -> [^8]. [JumpFPUnordered] -> [^8]. [RetN] -> [^(operands at: 0) = 0 ifTrue: [4] ifFalse: [8]]. [Stop] -> [^4]. "Arithmetic" + [AddCqR] -> [^8]. + [AndCqR] -> [^8]. + [AndCqRR] -> [^8]. + [CmpCqR] -> [^8]. + [OrCqR] -> [^8]. + [SubCqR] -> [^8]. + [TstCqR] -> [^8]. + [XorCqR] -> [^8]. + [AddCwR] -> [^8]. + [AndCwR] -> [^8]. + [CmpCwR] -> [^8]. + [OrCwR] -> [^8]. + [SubCwR] -> [^8]. + [XorCwR] -> [^8]. + [AddRR] -> [^4]. + [AndRR] -> [^4]. + [CmpRR] -> [^4]. + [OrRR] -> [^4]. + [XorRR] -> [^4]. + [SubRR] -> [^4]. + [NegateR] -> [^4]. + [LoadEffectiveAddressMwrR]-> [^8 halt]. "I think this is likely 4" - [AddCqR] -> [^8]. - [AndCqR] -> [^8]. - [AndCqRR] -> [^8]. - [CmpCqR] -> [^8]. - [OrCqR] -> [^8]. - [SubCqR] -> [^8]. - [TstCqR] -> [^8]. - [XorCqR] -> [^8]. - [AddCwR] -> [^8]. - [AndCwR] -> [^8]. - [CmpCwR] -> [^8]. - [OrCwR] -> [^8]. - [SubCwR] -> [^8]. - [XorCwR] -> [^8]. - [AddRR] -> [^4]. - [AndRR] -> [^4]. - [CmpRR] -> [^4]. - [OrRR] -> [^4]. - [XorRR] -> [^4]. - [SubRR] -> [^4]. - [NegateR] -> [^4]. - [LoadEffectiveAddressMwrR] -> [8]. [LogicalShiftLeftCqR] -> [^4]. [LogicalShiftRightCqR] -> [^4]. [ArithmeticShiftRightCqR] -> [^4]. [LogicalShiftLeftRR] -> [^4]. [LogicalShiftRightRR] -> [^4]. [ArithmeticShiftRightRR] -> [^4]. [AddRdRd] -> [^4]. [CmpRdRd] -> [^4]. [SubRdRd] -> [^4]. [MulRdRd] -> [^4]. [DivRdRd] -> [^4]. [SqrtRd] -> [^4]. [ClzRR] -> [^4]. "Data Movement" [MoveCqR] -> [^4]. [MoveCwR] -> [^4]. [MoveRR] -> [^4]. [MoveRdRd] -> [^4]. + [MoveAwR] -> [^((self isAddressRelativeToVarBase: (operands at: 0)) + and: [(operands at: 1) ~= SP]) - [MoveAwR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. + [MoveRAw] -> [^((self isAddressRelativeToVarBase: (operands at: 1)) + and: [(operands at: 0) ~= SP]) - [MoveRAw] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) ifTrue: [4] ifFalse: [8]]. [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) ifTrue: [4] ifFalse: [8]]. + [MoveMwrR] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. + [MoveRMwr] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. + [MoveMbrR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|4] ifFalse:[8]]. + [MoveRMbr] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. + [MoveM16rR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|4] ifFalse:[8]]. + [MoveRM16r] -> [^self isPossiblyShiftableImm12: (operands at: 1) ifTrue: [:shift12|4] ifFalse:[8]]. - [MoveRMwr] -> [^self is12BitValue: (operands at: 1) - ifTrue: [:u :i| 4] - ifFalse: [8]]. - [MoveRdM64r] -> [^8]. - [MoveMbrR] -> [^self is12BitValue: (operands at: 0) - ifTrue: [:u :i| 4] - ifFalse: [8]]. - [MoveRMbr] -> [^self is12BitValue: (operands at: 1) - ifTrue: [:u :i| 4] - ifFalse: [8]]. - [MoveRM16r] -> [^self is12BitValue: (operands at: 1) - ifTrue: [:u :i| 4] - ifFalse: [8]]. - [MoveM16rR] -> [self halt]. [MoveM64rRd] -> [^8]. + [MoveRdM64r] -> [^8]. - [MoveMwrR] -> [^self is12BitValue: (operands at: 0) - ifTrue: [:u :i| 4] - ifFalse: [8]]. [MoveXbrRR] -> [^4]. [MoveRXbrR] -> [^4]. [MoveXwrRR] -> [^4]. [MoveRXwrR] -> [^4]. [PopR] -> [^4]. [PushR] -> [^4]. [PushCw] -> [self halt]. [PushCq] -> [self halt]. [PrefetchAw] -> [self halt]. "Conversion" [ConvertRRd] -> [^8]. }. ^0 "to keep C compiler quiet" ! Item was added: + ----- Method: CogARMv8Compiler>>concretizeLiteral (in category 'generate machine code') ----- + concretizeLiteral + "Generate an out-of-line literal. Copy the value and any annotation from the stand-in in the literals manager." + | literalAsInstruction literal | + <var: 'literal' type: #usqInt> + literalAsInstruction := cogit cCoerceSimple: (operands at: 0) to: #'AbstractInstruction *'. + literal := (self isAnInstruction: literalAsInstruction) + ifTrue: [literalAsInstruction address] + ifFalse: [self cCode: [literalAsInstruction asUnsignedInteger] + inSmalltalk: [literalAsInstruction]]. + self assert: (dependent notNil and: [dependent opcode = Literal]). + dependent annotation ifNotNil: + [self assert: annotation isNil. + annotation := dependent annotation]. + dependent address ifNotNil: [self assert: dependent address = address]. + dependent address: address. + machineCode + at: 0 put: (literal bitAnd: 16rFFFFFFFF); + at: 1 put: (literal >> 32). + machineCodeSize := 8! Item was added: + ----- Method: CogARMv8Compiler>>concretizeMoveRAw (in category 'generate machine code - concretize') ----- + concretizeMoveRAw + "Will get inlined into concretizeAt: switch." + <inline: true> + | srcReg destAddr instrOffset| + srcReg := operands at: 0. + destAddr := operands at: 1. + "str srcReg, [VarBaseReg, #offset] except that this is illegal for SP/X31" + (self isAddressRelativeToVarBase: destAddr) ifTrue: + [destAddr < cogit varBaseAddress ifTrue: + [self shouldBeImplemented. + ^machineCodeSize := 4]. + srcReg ~= SP ifTrue: + [machineCode + at: 0 + put: (self strn: srcReg rt: VarBaseReg imm: destAddr - cogit varBaseAddress shiftBy12: false). + ^machineCodeSize := 4]. + machineCode + at: 0 + put: (self movern: srcReg rd: RISCTempReg); + at: 1 + put: (self strn: RISCTempReg rt: VarBaseReg imm: destAddr - cogit varBaseAddress shiftBy12: false). + ^machineCodeSize := 8]. + "LEA ConcreteIPReg + str srcReg, [ConcreteIPReg]" + instrOffset := self moveCw: destAddr intoR: RISCTempReg. + machineCode + at: instrOffset // 4 + put: (self strn: srcReg rt: RISCTempReg imm: 0 shiftBy12: false). + ^machineCodeSize := instrOffset + 4! Item was added: + ----- Method: CogARMv8Compiler>>isAddressRelativeToVarBase: (in category 'testing') ----- + isAddressRelativeToVarBase: varAddress + <inline: true> + <var: #varAddress type: #usqInt> + "Support for addressing variables off the dedicated VarBaseReg" + ^varAddress notNil + and: [varAddress + between: cogit varBaseAddress - (1 << 8) + and: cogit varBaseAddress + (1 << 12) - 1]! Item was added: + ----- Method: CogARMv8Compiler>>isPossiblyShiftableImm12:ifTrue:ifFalse: (in category 'generate machine code - support') ----- + isPossiblyShiftableImm12: immediate ifTrue: unaryBlock ifFalse: nullaryBlock + <inline: #always> + (immediate between: 0 and: 1 << 12 - 1) ifTrue: + [^unaryBlock value: false]. + ((immediate noMask: 1 << 12 - 1) + and: [immediate >> 12 between: 0 and: 1 << 12 - 1]) ifTrue: + [^unaryBlock value: true]. + ^nullaryBlock value! Item was added: + ----- Method: CogARMv8Compiler>>isPossiblyShiftableImm12orImm9:ifTrue:ifFalse: (in category 'generate machine code - support') ----- + isPossiblyShiftableImm12orImm9: immediate ifTrue: unaryBlock ifFalse: nullaryBlock + <inline: #always> + ((immediate between: -256 and: 255) + or: [immediate between: 0 and: 1 << 12 - 1]) ifTrue: + [^unaryBlock value: false]. + ((immediate noMask: 1 << 12 - 1) + and: [immediate >> 12 between: 0 and: 1 << 12 - 1]) ifTrue: + [^unaryBlock value: true]. + ^nullaryBlock value! Item was added: + ----- Method: CogARMv8Compiler>>isSharable (in category 'generate machine code') ----- + isSharable + "Hack: To know if a literal should be unique (not shared) mark the second operand." + <inline: true> + self assert: opcode = Literal. + ^operands at: 1! Item was added: + ----- Method: CogARMv8Compiler>>literalOpcodeIndex (in category 'generate machine code') ----- + literalOpcodeIndex + "Hack: To know how far away a literal is from its referencing instruction we store + its opcodeIndex, or -1, if as yet unassigned, in the second operand of the literal." + <inline: true> + self assert: opcode = Literal. + ^(operands at: 2) asInteger! Item was added: + ----- Method: CogARMv8Compiler>>moveCw:intoR: (in category 'generate machine code - support') ----- + moveCw: constant intoR: destReg + "Emit a load of aWord into destReg. Answer the number of bytes of machine code generated. + Literals are stored out-of-line; emit a LDR with the relevant offset." + <var: 'constant' type: #usqInt> + <inline: true> + self assert: (cogit addressIsInCurrentCompilation: dependent address). + self assert: (dependent address bitAnd: 3) = 0. + self assert: (dependent address - address) abs < (1<<19). + "C6.2.131 LDR (literal) C6-979" + machineCode + at: 0 + put: 2r01011000 << 24 + + destReg + + ((dependent address - (address + 8) bitAnd: 1 << 19 - 1) << 5). + ^machineCodeSize := 4! Item was added: + ----- Method: CogARMv8Compiler>>movern:rd: (in category 'generate machine code - support') ----- + movern: srcReg rd: destReg + ^self addrn: srcReg rd: destReg imm: 0 shiftBy12: false! Item was added: + ----- Method: CogARMv8Compiler>>setLiteralOpcodeIndex: (in category 'generate machine code') ----- + setLiteralOpcodeIndex: index + "Hack: To know how far away a literal is from its referencing instruction we store + its opcodeIndex, or -1, if as yet unassigned, in the second operand of the literal." + <inline: true> + self assert: opcode = Literal. + operands at: 2 put: index! Item was added: + ----- Method: CogARMv8Compiler>>strn:rt:imm:shiftBy12: (in category 'generate machine code - support') ----- + strn: srcReg rt: targetReg imm: offset shiftBy12: shiftBy12 + "C6.2.273 STR (immediate) C6-1239 + C6.2.297 STUR C6-1290" + + self deny: srcReg = SP. + "Unsigned offset, C6-1240" + (offset \\ 8 = 0 + and: [offset / 8 between: 0 and: 1 << 12 - 1]) ifTrue: + [^2r1111100100 << 22 + + (offset << 7 "10 - 3") + + (targetReg << 5) + + srcReg]. + self assert: (offset between: -256 and: 255). + ^2r11111000000 << 21 + + ((offset bitAnd: 511) << 12) + + (targetReg << 5) + + srcReg! Item was added: + ----- Method: CogARMv8Compiler>>usesOutOfLineLiteral (in category 'testing') ----- + usesOutOfLineLiteral + "Answer if the receiver uses an out-of-line literal. Needs only + to work for the opcodes created with gen:literal:operand: et al." + + opcode + caseOf: { + [CallFull] -> [^true]. + [JumpFull] -> [^true]. + "Arithmetic" + [AddCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [AndCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [AndCqRR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [CmpCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [OrCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [SubCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [TstCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [XorCqR] -> [^self isPossiblyShiftableImm12: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [AddCwR] -> [^true]. + [AndCwR] -> [^true]. + [CmpCwR] -> [^true]. + [OrCwR] -> [^true]. + [SubCwR] -> [^true]. + [XorCwR] -> [^true]. + "[LoadEffectiveAddressMwrR] + -> [^self rotateable8bitImmediate: (operands at: 0) ifTrue: [:r :i| false] ifFalse: [true]]." + "Data Movement" + "[MoveCqR] -> [^self rotateable8bitImmediate: (operands at: 0) ifTrue: [:r :i| false] ifFalse: [true]]." + [MoveCwR] -> [^(self inCurrentCompilation: (operands at: 0)) not]. + [MoveAwR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) not]. + [MoveRAw] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) not]. + [MoveAbR] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) not]. + [MoveRAb] -> [^(self isAddressRelativeToVarBase: (operands at: 1)) not]. + [MoveMwrR] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [MoveRMwr] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 1) ifTrue: [:shift12|false] ifFalse:[true]]. + [MoveMbrR] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [MoveRMbr] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 1) ifTrue: [:shift12|false] ifFalse:[true]]. + [MoveM16rR] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 0) ifTrue: [:shift12|false] ifFalse:[true]]. + [MoveRM16r] -> [^self isPossiblyShiftableImm12orImm9: (operands at: 1) ifTrue: [:shift12|false] ifFalse:[true]]. + "[MoveRdM64r] -> [^self is12BitValue: (operands at: 1) ifTrue: [:u :i| false] ifFalse: [true]]. + [MoveM64rRd] -> [^self is12BitValue: (operands at: 0) ifTrue: [:u :i| false] ifFalse: [true]]." + [PushCw] -> [^(self inCurrentCompilation: (operands at: 0)) not]. + "[PushCq] -> [^self rotateable8bitImmediate: (operands at: 0) ifTrue: [:r :i| false] ifFalse: [true]]." + [PrefetchAw] -> [^(self isAddressRelativeToVarBase: (operands at: 0)) not]. + } + otherwise: [self assert: false]. + ^false "to keep C compiler quiet" + ! Item was changed: CogClass subclass: #CurrentImageCoInterpreterFacade + instanceVariableNames: 'memory cogit coInterpreter objectMemory objectMap headerToMethodMap cachedObject cachedOop variables cFramePointer cStackPointer' - instanceVariableNames: 'memory cogit coInterpreter objectMemory objectMap headerToMethodMap cachedObject cachedOop variables' classVariableNames: '' poolDictionaries: 'CogMethodConstants VMBasicConstants VMObjectIndices VMSqueakClassIndices' category: 'VMMaker-Support'! !CurrentImageCoInterpreterFacade commentStamp: 'eem 8/6/2014 14:59' prior: 0! A CurrentImageCoInterpreterFacade is a stand-in for an object memory (ObjectMemory, SpurMemoryManager, etc) that allows the Cogits to access image objects as if they were in the simulator VM's heap. hence it allows the Cogits to generate code for methdos in the current image, for testing, etc. Instance Variables cachedObject: <Object> cachedOop: <Integer> coInterpreter: <CoInterpreter> cogit: <Cogit> headerToMethodMap: <Dictionary> memory: <ByteArray> objectMap: <IdentityDictionary> objectMemory: <NewObjectMemory|SpurMemoryManager> variables: <Dictionary> cachedObject - the object matching cachedOop, to speed-up oop to obejct mapping cachedOop - the last used oop coInterpreter - the CoInterpreter simulator used by the cogit. cogit - the code egnerator in use headerToMethodMap - a map from header to CompiledMethod memory - a rump memory for holding various interpreter variables (e.g. stackLimit) that are accessed as memory locations by generated code objectMap - map from objects to their oops objectMemory - the object memory used to encode various values, answer queries, etc variables - a map from the names of variables to their addresses in memory ! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>checkIfCFramePointerInUse (in category 'cog jit support') ----- + checkIfCFramePointerInUse + ^true! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>setCFramePointer:setCStackPointer: (in category 'cog jit support') ----- + setCFramePointer: fp setCStackPointer: sp + cFramePointer := fp. + cStackPointer := sp!

1 0

VM Maker Inbox: VMMaker-dtl.409.mcz
by commits＠source.squeak.org 03 Dec '19

03 Dec '19

David T. Lewis uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker-dtl.409.mcz ==================== Summary ==================== Name: VMMaker-dtl.409 Author: dtl Time: 2 December 2019, 7:15:49.04 pm UUID: 2f30017c-5c17-49a2-b431-9fcdb82b7770 Ancestors: VMMaker-dtl.408 Let primitiveResumeFromSnapshot fail if the current interpreter cannot support the image format of the snapshot object. =============== Diff against VMMaker-dtl.408 =============== Item was changed: ----- Method: ContextInterpreter>>primitiveResumeFromSnapshot (in category 'snapshot utility primitives') ----- primitiveResumeFromSnapshot "Discard the current object memory and resume interpreter execution in the provided snapshot." <export: true> | expectedArraySize snapshotValues size newMemoryBytesOrBitmap bigEndian snapshotImageFormat snapshotStartOfMemory snapshotSpecialObjectsOop snapshotLastHash screenSizePoint headerSize imageBytes imageHeaderFlags snapshotExtraVMMemory swapBytes snapshotFullScreen defaultHeapSize desiredHeapSize | expectedArraySize := 11. "ImageSnapshot new asValues size => 11" argumentCount == 1 ifFalse: [ ^self primitiveFailFor: PrimErrBadNumArgs]. snapshotValues := self stackObjectValue: 0. self assertClassOf: snapshotValues is: (objectMemory splObj: ClassArray). self successful ifFalse: [ ^self primitiveFailFor: PrimErrBadArgument]. size := objectMemory numSlotsOf: snapshotValues. size < expectedArraySize ifTrue: [ ^self primitiveFailFor: PrimErrBadArgument]. newMemoryBytesOrBitmap := objectMemory fetchPointer: 0 ofObject: snapshotValues. bigEndian := (objectMemory fetchPointer: 1 ofObject: snapshotValues) = objectMemory trueObject. snapshotImageFormat := objectMemory integerValueOf: (objectMemory fetchPointer: 2 ofObject: snapshotValues).. + (self readableFormat: snapshotImageFormat) + ifFalse: [ ^self primitiveFailFor: PrimErrInappropriate ]. headerSize := objectMemory integerValueOf: (objectMemory fetchPointer: 3 ofObject: snapshotValues).. imageBytes := self positive32BitValueOf: (objectMemory fetchPointer: 4 ofObject: snapshotValues).. "good for up to 2GB image" snapshotStartOfMemory := objectMemory integerValueOf: (objectMemory fetchPointer: 5 ofObject: snapshotValues).. snapshotSpecialObjectsOop := objectMemory integerValueOf: (objectMemory fetchPointer: 6 ofObject: snapshotValues).. snapshotLastHash := objectMemory integerValueOf: (objectMemory fetchPointer: 7 ofObject: snapshotValues).. screenSizePoint := objectMemory fetchPointer: 8 ofObject: snapshotValues.. self assertClassOf: screenSizePoint is: (objectMemory splObj: ClassPoint). self successful ifFalse: [ ^self primitiveFailFor: PrimErrBadArgument]. imageHeaderFlags := objectMemory integerValueOf: (objectMemory fetchPointer: 9 ofObject: snapshotValues).. snapshotExtraVMMemory := objectMemory integerValueOf: (objectMemory fetchPointer: 10 ofObject: snapshotValues).. swapBytes := bigEndian ~= self isBigEnder. snapshotFullScreen := false. "FIXME" "From sqUnixMain.c #define DefaultHeapSize 20 megabytes BEYOND actual image size" defaultHeapSize := 20 * 1000 * 1000. desiredHeapSize := defaultHeapSize + imageBytes. self snapshotResume: newMemoryBytesOrBitmap heapSize: desiredHeapSize swapBytes: swapBytes oldBaseAddr: snapshotStartOfMemory specialObjectsOop: snapshotSpecialObjectsOop lastHash: snapshotLastHash savedWindowSize: screenSizePoint fullScreenFlag: snapshotFullScreen extraVMMemory: snapshotExtraVMMemory. self pop: 1 thenPush: newMemoryBytesOrBitmap. ! Item was changed: ----- Method: ContextInterpreter>>snapshotResume:heapSize:swapBytes:oldBaseAddr:specialObjectsOop:lastHash:savedWindowSize:fullScreenFlag:extraVMMemory: (in category 'snapshot utility primitives') ----- snapshotResume: byteArrayOrBitmap heapSize: desiredHeapSize swapBytes: swapBytes oldBaseAddr: oldBaseAddr specialObjectsOop: specialObjects lastHash: hashValue savedWindowSize: windowSize fullScreenFlag: fullScreen extraVMMemory: extraMemory "Arrange for the interpreter to resume execution from a snapshot of saved memory and interpreter state. The current object memory and interpreter state is discarded, and the interpreter resumes execution at the point of + the supplied image snapshot." - the supplied image snapshot.." | dataSize sourceBytes mem | <returnTypeC: 'usqInt'> <var: #desiredHeapSize type: 'usqInt'> <var: #dataSize type: 'size_t '> <var: #sourceBytes type: 'char *'> <var: #mem type: 'char *'> "Notes - The parameters windowSize, fullScreen and extraMemory are currently not used when resuming the VM in a new image. The display size and fullscreen mode are probably best set from the image by calling primitiveSetDisplayMode prior to primitiveResumeFromSnapshot. The extraMemory parameter is ignored here because we are simply copying the new object memory over a previously allocated heap space." dataSize := objectMemory byteSizeOf: byteArrayOrBitmap. sourceBytes := objectMemory firstIndexableField: byteArrayOrBitmap. objectMemory setSpecialObjectsOop: specialObjects. objectMemory setLastHash: hashValue. "Copy object memory into allocated space" objectMemory setMemoryLimits: dataSize heapSize: desiredHeapSize. mem := objectMemory pointerForOop: objectMemory getMemory. self mem: mem cp: sourceBytes y: dataSize. self swapBytesAndPrepareToInterpret: swapBytes oldBaseAddr: oldBaseAddr. self interpret. "Resume interpreter execution in the snapshot." ! Item was changed: ----- Method: VMMaker class>>versionString (in category 'version testing') ----- versionString "VMMaker versionString" + ^'4.17.2'! - ^'4.17.1'!

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2019