Vm-dev November 2019

vm-dev@lists.squeakfoundation.org

19 participants
178 discussions

[OpenSmalltalk/opensmalltalk-vm] Linux Squeak VM X11 keyboard changes breaks 32b VM (#396)
by kksubbu 26 Dec '19

26 Dec '19

Tim Johnson reported a problem with 32b Linux builds: http://forum.world.st/Linux-Squeak-VM-X11-keyboard-changes-td5099584.html Pressing ctrl-d now acts like debugIt instead of doIt like in the 64b. Ctrl-p also stopping working. I did a bisection of all versions in https://bintray.com/opensmalltalk/vm/cog/ and narrowed down the problem to good squeak.cog.spur_linux32x86_201811272342.tar.gz bad squeak.cog.spur_linux32x86_201812301551.tar.gz The error is consistent on both 18231 and the oldest 18221 released image for 32b VM but does not appear with 64b VMs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/396

9 27

[OpenSmalltalk/opensmalltalk-vm] fix calculation of x11 scroll distances (#446)
by Tom Beckmann 25 Dec '19

25 Dec '19

I believe these values should be like the below. Refer to for example here: http://xahlee.info/linux/linux_x11_mouse_button_number.html (the first scroll event is button 4). And the up-direction should be negative for Squeak. After these adjustments the behavior was correct on my machine. To try out, ensure that you have `Smalltalk sendMouseWheelEvents: true` You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446 -- Commit Summary -- * fix calculation of x11 scroll distances -- File Changes -- M platforms/unix/vm-display-X11/sqUnixX11.c (6) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/446

2 2

Squeak Inspectors
by Eliot Miranda 11 Dec '19

11 Dec '19

Hi All, Clément and I were talking earlier today (about issues around the solving of issue 444) and later on we talked a it about UI. It has been a goal of Tudor Girba to have a VMMaker that uses the Glamorous Toolkit for richer inspection facilities, a project than makes sense to me too. But it is one I have failed to contribute to because of issues I have with Pharo. However, richer inspection could be implemented in Squeak too, without taking on the task of porting GT to Squeak (a worth-while project I encourage anyone interested to consider). So what would be required to do something slick in Squeak? I'm hacking up a few ideas right now but there are some things I'd like, and I'm not sure of how to get them, hence my sending the message here and cc'ing Marcel. One thing is handling double click in text so that it triggers not a selection, but some semantic action. I'm imagining a three column inspector where on the left are the inst vars of a VM object, such as the interpreter. In the next column is a default display of the selected inst var, for example, the output of the print: routine, which for the specialObjectsArray looks like this: 16r2FAF998: a(n) Array 16r734500 nil 16r734510 false 16r734520 true 16rD09B20 a Global #Processor -> 16r00745CD8 16rB01D20 class Bitmap 16r124FCB8 class SmallInteger 16rB02140 class ByteString 16rB01C00 class Array 16rB4D228 a SmalltalkImage 16r106E708 class BoxedFloat64 16rB05380 class Context 16r734500 nil 16rB04BA0 class Point 16rAFF358 class LargePositiveInteger 16r780B30 a DisplayScreen 16rB00018 class Message 16rB01F00 class CompiledMethod 16r2000B8 a Semaphore 16rB02440 class Semaphore 16rAFF4D8 class Character 16r93F0A8 #doesNotUnderstand: 16r93F0C8 #cannotReturn: 16r734500 nil 16r241C998 an Array 16r734500 nil 16r93F0E0 #mustBeBoolean 16rB01FC0 class ByteArray 16r116E800 class Process 16r2FB10B8 an Array 16r1365050 a Semaphore 16r100048 a Semaphore 16r734500 nil 16r734500 nil 16r734500 nil 16r980DF8 #cannotInterpret: 16r734500 nil 16rB192C0 class BlockClosure 16r734500 nil 16r100068 an Array 16r734500 nil 16r10AB350 a LinkedList 16r759080 a Semaphore 16rAFF2F8 class LargeNegativeInteger 16r2F82230 class ExternalAddress 16r2F820E8 class ExternalStructure 16r2F82D00 class ExternalData 16r2F88508 class ExternalFunction 16r2F82950 class ExternalLibrary 16r9B2090 #aboutToReturn:through: 16r9CB820 #run:with:in: 16r10BBBD0 #attemptToAssign:withIndex: 16r2FB10C8 an Array 16r2F4DF88 class Alien 16r10BBD20 #invokeCallbackContext: 16r2F51228 class UnsafeAlien 16r734500 nil 16r734500 nil 16rCE3570 #unusedBytecode 16r10BBBA0 #conditionalBranchCounterTrippedOn: 16r10BAB98 #classTrapFor: Then in the third column would be a sub-inspector, so that if one double-clicked in an oops in the above display, that would be displayed in the third column. Ideally the inspectors would cascade like they do in GT. But for the moment I'd be happy with anything that doesn't require copy/pasting oops (the hex numbers above) into dialog boxes to print further info in the transcript window in a simulation. So Marcel (& others who are interested), at the most basic level, how would one add a double-click action to our current Inspector framework to enable that kind of interaction? How would one build a cascading Inspector as per GT? And as impetus, this UI will help us develop the VM faster, and that will get you, in time, a faster VM. _,,,^..^,,,_ best, Eliot

4 6

[OpenSmalltalk/opensmalltalk-vm] Problem linking Linux Sound Library (#360)
by Eva 09 Dec '19

09 Dec '19

On Linux Mint Sylvia, I could not play sounds (e.g. ``SampledSound beep``). This occurred in the newest SWA VM build of Squeak. Underlying problem seems to be that the Linux sound libraries for PulseAudio are not linked correctly. (Maybe this is the same as #118) With @krono I found this workaround: `` LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libpulse-simple.so.0.1.0 LD_LIBRARY_PATH=/home/user/Dokumente/SWA2018.app/Contents/Linux-i686/bin/../lib/squeak/5.0-201810071412:/lib/x86_64-linux-gnu:/lib:/usr/lib/x86_64-linux-gnu:/usr/lib: /home/user/Dokumente/SWA2018.app/Contents/Linux-i686/bin/../lib/squeak/5.0-201810071412/squeak -vm-sound-pulse /home/user/Dokumente/SWA2018.app/Contents/Resources/SWA2018.image `` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/360

9 16

[OpenSmalltalk/opensmalltalk-vm] libgit build fails because of libssl and libcrypto (#210)
by Javier Pimas 04 Dec '19

04 Dec '19

on /build.linux32x86/pharo.cog.spur/build I run ./mvm and get make[3]: *** No rule to make target '/usr/lib/i386-linux-gnu/libssl.so', needed by 'libgit2.so.0.25.1'. Stop. I worked around it by running sudo ln -s /lib/i386-linux-gnu/libssl.so.1.0.0 /usr/lib/i386-linux-gnu/libssl.so but shouldn't be necessary as libssl is downloaded and built by the script. The same happens with libcrypto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/210

3 4

[OpenSmalltalk/opensmalltalk-vm] BitBlt Segmentation Fault with Magic (2^31) value (#447)
by Patrick R 03 Dec '19

03 Dec '19

The following issue arose during the last few days. On current 64bit Squeak bundles, when setting a morph to an x position being (2 raisedTo: 31) in a world having an InfiniteForm, the VM crashes with a SegFault. This does not happen with (2 raisedTo: 32) or (2 raisedTo: 30). So far I was able to reproduce this on Windows and Linux (have not checked Mac yet). I tried to boil it down to the BitBlt call that causes this with the second example. At the bottom I have attached an example crash.dmp. This does not happen on 32bit bundles. It does occur on older 64bit Squeak releases (e.g. 5.2). ```Smalltalk "Execute this in a World with a texture (InfiniteForm) background" m := CircleMorph new openInWorld. m position: (2 raisedTo: 31)@100. ``` ```Smalltalk patternForm := Form extent: 3 @ 3 depth: 32. port := GrafPort new. port setDestForm: Display. port sourceForm: sourceForm. port fillColor: nil. port combinationRule: Form paint. port sourceRect: (0@0 extent: patternForm boundingBox extent). port destOrigin: (2 raisedTo: 31)@100. port copyBits. ``` ```` /mnt/c/Users/patri/Desktop/swag/teaching/SWA1920/tmp_image/SWA2020Trunk.app/Contents/Linux-x86_64/lib/squeak/5.0-201810190412/squeak Squeak VM version: 5.0-201810190412 Sat Oct 20 08:15:47 UTC 2018 gcc 4.8 [Production Spur 64-bit VM] Built from: CoInterpreter VMMaker.oscog-eem.2461 uuid: b3cd33f5-6309-43a1-b669-7a1805111f34 Oct 20 2018 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2464 uuid: 0b1fa0a3-a781-4fd5-b1cf-1809796ccbbf Oct 20 2018 Revision: VM: 201810190412 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Thu Oct 18 21:12:21 2018 CommitHash: 15341b57 Plugins: 201810190412 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-7e855ac8-57b9-4f6f-bf30-fd6e0ad67398 4.4.0-101-generic #124~14.04.1-Ubuntu SMP Fri Nov 10 19:05:36 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux plugin path: Linux-x86_64/lib/squeak/5.0-201810190412 [default: /mnt/c/Users/patri/Desktop/swag/teaching/SWA1920/tmp_image/SWA2020Trunk.app/Contents/Linux-x86_64/lib/squeak/5.0-201810190412/] C stack backtrace & registers: rax 0xef63a4c0 rbx 0xef63a350 rcx 0xef63a578 rdx 0xef63a408 rdi 0xef63a128 rsi 0xef63a128 rbp 0xef63a298 rsp 0xef63a630 r8 0xef639b68 r9 0xef639c20 r10 0xef639cd8 r11 0xef639d90 r12 0xef639e48 r13 0xef639f00 r14 0xef639fb8 r15 0xef63a070 rip 0xef63a6e8 *[0x7fffef63a6e8] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41b767] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41d1d5] /lib/x86_64-linux-gnu/libpthread.so.0(+0x12890)[0x7f82c2e42890] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4b50c4] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4ba99c] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x4baf59] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x458cc7] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(interpret+0xa687)[0x468157] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x469306] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(interpret+0x246)[0x45dd16] Linux-x86_64/lib/squeak/5.0-201810190412/squeak(main+0x2fa)[0x41ac8a] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7f82c2a51b97] Linux-x86_64/lib/squeak/5.0-201810190412/squeak[0x41afb4] [0x0] Smalltalk stack dump: 0x7fffef6963a8 I GrafPort>copyBits 0x26bf808: a(n) GrafPort 0x7fffef6963d8 M UndefinedObject>DoIt 0x29e78e0: a(n) UndefinedObject 0x7fffef696430 I Compiler>evaluateCue:ifFail: 0x26040b0: a(n) Compiler 0x7fffef697dc0 I Compiler>evaluateCue:ifFail:logged: 0x26040b0: a(n) Compiler 0x7fffef697e18 I Compiler>evaluate:in:to:environment:notifying:ifFail:logged: 0x26040b0: a(n) Compiler 0x7fffef697e90 M [] in SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x8864a20: a(n) SmalltalkEditor 0x7fffef697ec8 M BlockClosure>on:do: 0x2604060: a(n) BlockClosure 0x7fffef697f30 I SmalltalkEditor(TextEditor)>evaluateSelectionAndDo: 0x8864a20: a(n) SmalltalkEditor 0x7fffef697f78 I SmalltalkEditor(TextEditor)>evaluateSelection 0x8864a20: a(n) SmalltalkEditor 0x7fffef697fb8 I SmalltalkEditor(TextEditor)>doIt 0x8864a20: a(n) SmalltalkEditor 0x7fffef697fe8 M SmalltalkEditor(TextEditor)>doIt: 0x8864a20: a(n) SmalltalkEditor 0x7fffef698040 I SmalltalkEditor(TextEditor)>dispatchOnKeyboardEvent: 0x8864a20: a(n) SmalltalkEditor 0x7fffef698078 M SmalltalkEditor(TextEditor)>keyStroke: 0x8864a20: a(n) SmalltalkEditor 0x7fffef6980b8 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698108 M TextMorphForEditView(TextMorph)>handleInteraction:fromEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698148 M TextMorphForEditView>handleInteraction:fromEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698198 M [] in TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6981e8 M ECToolSet class>codeCompletionAround:textMorph:keyStroke: 0x7249388: a(n) ECToolSet class 0x7fffef698230 M ToolSet class>codeCompletionAround:textMorph:keyStroke: 0x2db08c8: a(n) ToolSet class 0x7fffef698278 M TextMorphForEditView(TextMorph)>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6982b8 M TextMorphForEditView>keyStroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6982f8 M TextMorphForEditView(Morph)>handleKeystroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698338 M TextMorphForEditView(TextMorph)>handleKeystroke: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698370 M KeyboardEvent>sentTo: 0x2601398: a(n) KeyboardEvent 0x7fffef6983b0 M TextMorphForEditView(Morph)>handleEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef6983e8 M TextMorphForEditView(Morph)>handleFocusEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef698430 M MorphicEventDispatcher>doHandlingForFocusEvent:with: 0x2600188: a(n) MorphicEventDispatcher 0x7fffef63fe38 M MorphicEventDispatcher>dispatchFocusEvent:with: 0x2600188: a(n) MorphicEventDispatcher 0x7fffef63fe78 M TextMorphForEditView(Morph)>processFocusEvent:using: 0x867ea40: a(n) TextMorphForEditView 0x7fffef63feb8 M TextMorphForEditView(Morph)>processFocusEvent: 0x867ea40: a(n) TextMorphForEditView 0x7fffef63ff08 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef63ff48 M BlockClosure>ensure: 0x2600070: a(n) BlockClosure 0x7fffef63ff88 M KeyboardEvent(MorphicEvent)>becomeActiveDuring: 0x25ff8b8: a(n) KeyboardEvent 0x7fffef63ffd8 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef640018 M BlockClosure>ensure: 0x25ffea0: a(n) BlockClosure 0x7fffef640058 M HandMorph>becomeActiveDuring: 0x747d0b0: a(n) HandMorph 0x7fffef6400a8 M [] in HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef6400e8 M BlockClosure>ensure: 0x25ffcd0: a(n) BlockClosure 0x7fffef640128 M PasteUpMorph>becomeActiveDuring: 0x747d000: a(n) PasteUpMorph 0x7fffef640170 M HandMorph>sendFocusEvent:to:clear: 0x747d0b0: a(n) HandMorph 0x7fffef6401c8 M HandMorph>sendEvent:focus:clear: 0x747d0b0: a(n) HandMorph 0x7fffef640210 M HandMorph>sendKeyboardEvent: 0x747d0b0: a(n) HandMorph 0x7fffef640250 M HandMorph>handleEvent: 0x747d0b0: a(n) HandMorph 0x7fffef6402a8 M HandMorph>processEvents 0x747d0b0: a(n) HandMorph 0x7fffef6402e0 M [] in AnimWorldState(WorldState)>doOneCycleNowFor: 0x7488298: a(n) AnimWorldState 0x7fffef640328 M Array(SequenceableCollection)>do: 0x748cdc8: a(n) Array 0x7fffef640360 M AnimWorldState(WorldState)>handsDo: 0x7488298: a(n) AnimWorldState 0x7fffef6403a0 M AnimWorldState(WorldState)>doOneCycleNowFor: 0x7488298: a(n) AnimWorldState 0x7fffef6403d8 M AnimWorldState(WorldState)>doOneCycleFor: 0x7488298: a(n) AnimWorldState 0x7fffef640410 M PasteUpMorph>doOneCycle 0x747d000: a(n) PasteUpMorph 0x7fffef640440 M [] in AnimMorphicProject>spawnNewProcess 0x747cf20: a(n) AnimMorphicProject 0x87c5278 s [] in BlockClosure>newProcess Most recent primitives at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitLengthAt: bitLengthAt: bitLengthAt: maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode maxCode at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: basicNew isOfSameSizeCheck: isOfSameSizeCheck: at: at: value:value: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: at: bitPosition bitPosition bitPosition << basicNew size on:from:to: on:from:to: at: nextBits:put: nextBits:put: nextBits:put: byteAt:put: byteAt:put: nextBytePut: bitXor: growTo: growTo: max: max: max: max: replaceFrom:to:with:startingAt: encodeLengthField: value value value value value originalContents originalContents originalContents originalContents originalContents nextPutAll: at: at: at: at: size size size size objectAt: basicNew size at: at: at: perform: size header createMethod:class:header: newMethod:header: newMethod:header: newMethod:header: newMethod:header: at: at: at:put: at:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: objectAt:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: at:put: basicNew withArgs:executeMethod: @ basicNew depth combinationRule: basicNew basicNew width height at: squared squared copyBits stack page bytes 8192 available headroom 5576 minimum unused headroom 6024 (Segmentation fault) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/447

4 7

[OpenSmalltalk/opensmalltalk-vm] Reproduceable Segmentation fault while saving images (#444)
by Juraj Kubelka 03 Dec '19

03 Dec '19

Executing the following script produces a segmentation fault: ```Smalltalk | aJson anArray | aJson := ZnEasy get: 'https://data.nasa.gov/resource/y77d-th95.json' asZnUrl. Array streamContents: [ :aStream | 400 timesRepeat: [ aStream nextPutAll: (STON fromString: aJson contents). Smalltalk saveSession ] ]. ``` [crash.dmp.txt](https://github.com/OpenSmalltalk/opensmalltalk-vm/files/3843… Reproduced on Pharo 8 Mac OS: ``` Image ----- Pharo8.0.0 Build information: Pharo-8.0.0+build.972.sha.bbb812d1387fd27ef4096e35224cb4425a60ab6c (64 Bit) Unnamed Virtual Machine --------------- /Users/.../Pharo/vms/80-x64/Pharo.app/Contents/MacOS/Pharo CoInterpreter VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 VM: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Sat Jan 5 20:00:11 2019 CommitHash: 7a3c6b6 Plugins: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Mac OS X built on Jan 5 2019 19:11:02 UTC Compiler: 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31) VMMaker versionString VM: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Sat Jan 5 20:00:11 2019 CommitHash: 7a3c6b6 Plugins: 201901051900 https://github.com/OpenSmalltalk/opensmalltalk-vm.git CoInterpreter VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2504 uuid: a00b0fad-c04c-47a6-8a11-5dbff110ac11 Jan 5 2019 ``` Also reproduced on Pharo 8 Mac OS: ``` Virtual Machine --------------- /Users/syrel/Documents/Pharo/images/GToolkit/../../vms/80-x64/Pharo.app/Contents/MacOS/Pharo CoInterpreter VMMaker.oscog-eem.2570 uuid: b61e294a-cb2a-4d9a-9e7e-8cc17676c920 Oct 16 2019 StackToRegisterMappingCogit VMMaker.oscog-eem.2570 uuid: b61e294a-cb2a-4d9a-9e7e-8cc17676c920 Oct 16 2019 VM: 201910161212 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Wed Oct 16 14:12:15 2019 CommitHash: da97dd5 Plugins: 201910161212 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Mac OS X built on Oct 16 2019 12:39:27 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42) ``` Also reproduced on Pharo 8 Linux Ubuntu 18.04: ``` Pharo VM version: 5.0-201902062351 Wed Feb 6 23:59:26 UTC 2019 gcc 4.8 [Production Spur 64-bit VM] Built from: CoInterpreter VMMaker.oscog-eem.2509 uuid: 91e81f64-95de-4914-a960-8f842be3a194 Feb 6 2019 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2509 uuid: 91e81f64-95de-4914-a960-8f842be3a194 Feb 6 2019 Revision: VM: 201902062351 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Wed Feb 6 15:51:18 2019 CommitHash: a838346b Plugins: 201902062351 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-f2b22483-7f84-414f-b833-69f69518c685 4.4.0-101-generic #124~14.04.1-Ubuntu SMP Fri Nov 10 19:05:36 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux plugin path: /dev/shm/p8/pharo-vm/lib/pharo/5.0-201902062351 [default: /dev/shm/p8/pharo-vm/lib/pharo/5.0-201902062351/] ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/444

16 55

[OpenSmalltalk/opensmalltalk-vm] bb5c54: Update the VM build scripts now that FileAttribute...
by Eliot Miranda 29 Nov '19

29 Nov '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: bb5c547ba5b04a23148f5ff356b3fb46562c1c3f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/bb5c547ba5b04a2314… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2019-11-29 (Fri, 29 Nov 2019) Changed paths: M image/BuildPharo6VMMakerImage.st M image/BuildSqueakSpurTrunkVMMakerImage.st Log Message: ----------- Update the VM build scripts now that FileAttributesPlugin has moved to the VMMaker repository. [ci skip]

1 0

VM Maker: FileAttributesPlugin.oscog-AlistairGrant.29.mcz
by commits＠source.squeak.org 29 Nov '19

29 Nov '19

Eliot Miranda uploaded a new version of FileAttributesPlugin to project VM Maker: http://source.squeak.org/VMMaker/FileAttributesPlugin.oscog-AlistairGrant.2… ==================== Summary ==================== Name: FileAttributesPlugin.oscog-AlistairGrant.29 Author: AlistairGrant Time: 16 June 2018, 2:49:28.03222 pm UUID: 9c55f745-9933-4291-abb7-f278da431090 Ancestors: FileAttributesPlugin.oscog-AlistairGrant.28 1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes. The posix routines just don't seem to handle timezones and DST correctly. =============== Diff against FileAttributesPlugin.oscog-AlistairGrant.28 =============== Item was changed: ----- Method: FileAttributesPlugin class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: cg self declareC: #('sCLPfn' 'sCOFfn') as: #'void *' in: cg. "Assume the security plugin can be loaded until proven otherwise" cg var: 'hasSecurityPlugin' declareC: 'int hasSecurityPlugin = 1'. cg addHeaderFile: '<limits.h>'. cg addHeaderFile: '<sys/types.h>'. cg addHeaderFile: '<dirent.h> #ifdef _WIN32 #include <windows.h> #include <winbase.h> #define FAIL() { return -1; } #include "sqWin32File.h" + #else + #include "sqMemoryAccess.h" + extern sqLong convertToLongSqueakTime(time_t unixTime); #endif typedef struct dirptrstruct { DIR *dp; int path_len; char *path_file; char path[PATH_MAX+4]; } osdir;'. cg addHeaderFile: '<sys/stat.h> #if !!defined(HAVE_LSTAT) && !!defined(_WIN32) #define HAVE_LSTAT 1 #endif'. cg addHeaderFile: '<unistd.h> /* AKG 2017 - ', self moduleName, '.c translated from class ', self name, ' */'! Item was added: + ----- Method: FileAttributesPlugin>>convertWinToSqueakTime: (in category 'private - windows') ----- + convertWinToSqueakTime: st + "Convert the supplied Windows SYSTEMTIME to Squeak time" + <option: #_WIN32> + + | dy secs nDaysPerMonth | + + <returnTypeC: 'sqLong'> + <var: 'st' declareC: 'SYSTEMTIME st'> + <var: 'dy' type: 'sqLong'> + <var: 'secs' type: 'sqLong'> + <var: 'nDaysPerMonth' declareC: 'static sqLong nDaysPerMonth[14] = { + 0, 0, 31, 59, 90, 120, 151, + 181, 212, 243, 273, 304, 334, 365 }'> + self touch: nDaysPerMonth. + + "Squeak epoch is Jan 1, 1901" + "compute delta year" + dy := (self cCode: 'st.wYear') - 1901. + secs := (dy * 365 * 24 * 60 * 60) "base seconds" + + ((dy bitShift: -2) * 24 * 60 * 60). "seconds of leap years" + "check if month > 2 and current year is a leap year" + [ (self cCode: 'st.wMonth') > 2 and: [ (dy bitAnd: 16r0003) = 16r0003 ]] ifTrue: [ + "add one day" + secs := secs + (24 * 60 * 60) ]. + "add the days from the beginning of the year" + secs := secs + (self cCode: '(nDaysPerMonth[st.wMonth] + st.wDay - 1) * 24 * 60 * 60'). + "add the hours, minutes, and seconds" + secs := secs + (self cCode: 'st.wSecond + 60*(st.wMinute + 60*st.wHour)'). + ^secs + ! Item was changed: ----- Method: FileAttributesPlugin>>fileCreationTimeFor:length:to: (in category 'private - windows') ----- fileCreationTimeFor: pathString length: pathLength to: creationDate + "Get the creationDate for the supplied file." + <inline: #never> - "Get the creationDate for the supplied file. - Linux kernel 4.11 should have statx(), so hopefully there will be a cross-platform - solution soon. Just dump the c-code and hope to remove it soon." <option: #_WIN32> + | winAttrs status | - | tm winAttrs win32Path sysTime | <var: 'pathString' type: 'char *'> + <var: 'creationDate' type: 'sqLong *'> - <var: 'creationDate' type: 'time_t *'> - <var: 'tm' type: 'struct tm'> <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA'> - <var: 'win32Path' type: 'WCHAR *'> - <var: 'sysTime' type: 'SYSTEMTIME'> - self touch: winAttrs. - self touch: sysTime. - self me: (self addressOf: tm) ms: 0 et: tm sizeof. - "convert the supplied path name into a wide string" - self ALLOC_: win32Path WIN32_: pathString PATH: pathLength. - (self cCode: 'GetFileAttributesExW(win32Path, 0, &winAttrs)') = 0 ifTrue: - [^self getAttributesFailed]. - (self cCode: 'FileTimeToSystemTime(&winAttrs.ftCreationTime, &sysTime)') = 0 ifTrue: - [^self timeConversionFailed]. + "Get the file attributes" + status := self winFileAttributesFor: pathString length: pathLength to: (self addressOf: winAttrs). + status = 0 ifFalse: [^status]. - self cCode: ' - tm.tm_year = sysTime.wYear - 1900; - tm.tm_mon = sysTime.wMonth - 1; - tm.tm_mday = sysTime.wDay; + "Set the creationDate" + status := self winFileCreationTimeFor: (self addressOf: winAttrs) to: creationDate. + status = 0 ifFalse: [^status]. - tm.tm_hour = sysTime.wHour; - tm.tm_min = sysTime.wMinute; - tm.tm_sec = sysTime.wSecond; - tm.tm_isdst = 0; - *creationDate = mktime(&tm)'. ^0! Item was added: + ----- Method: FileAttributesPlugin>>fileLastAccessTimeFor:length:to: (in category 'private - windows') ----- + fileLastAccessTimeFor: pathString length: pathLength to: creationDate + "Get the creationDate for the supplied file." + <inline: #never> + <option: #_WIN32> + | winAttrs status | + <var: 'pathString' type: 'char *'> + <var: 'creationDate' type: 'sqLong *'> + <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA'> + + "Get the file attributes" + status := self winFileAttributesFor: pathString length: pathLength to: (self addressOf: winAttrs). + status = 0 ifFalse: [^status]. + + "Set the creationDate" + status := self winFileLastAccessTimeFor: (self addressOf: winAttrs) to: creationDate. + status = 0 ifFalse: [^status]. + + ^0! Item was added: + ----- Method: FileAttributesPlugin>>fileLastWriteTimeFor:length:to: (in category 'private - windows') ----- + fileLastWriteTimeFor: pathString length: pathLength to: creationDate + "Get the creationDate for the supplied file." + <inline: #never> + <option: #_WIN32> + | winAttrs status | + <var: 'pathString' type: 'char *'> + <var: 'creationDate' type: 'sqLong *'> + <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA'> + + "Get the file attributes" + status := self winFileAttributesFor: pathString length: pathLength to: (self addressOf: winAttrs). + status = 0 ifFalse: [^status]. + + "Set the creationDate" + status := self winFileLastWriteTimeFor: (self addressOf: winAttrs) to: creationDate. + status = 0 ifFalse: [^status]. + + ^0! Item was removed: - ----- Method: FileAttributesPlugin>>offsetStatBufTimesForWIN32: (in category 'private - windows') ----- - offsetStatBufTimesForWIN32: statBufPointer - "Adjust the statBuffer to UTC, see https://msdn.microsoft.com/en-us/library/windows/desktop/ms725481(v=vs.85).…" - <option: #_WIN32> - <var: 'statBufPointer' type: 'struct stat *'> - | status dtzi offset | - <var: 'offset' type: 'long'> - <var: 'dtzi' type: 'TIME_ZONE_INFORMATION'> - status := self GetTimeZoneInformation: (self addressOf: dtzi). - offset := (self cCode: 'dtzi.Bias' inSmalltalk: [0]) * 60. - "Adjust for DST if required" - status = 2 ifTrue: [offset := offset - 3600]. - self cCode: 'statBufPointer->st_atime += offset'. - self cCode: 'statBufPointer->st_mtime += offset'. - self cCode: 'statBufPointer->st_ctime += offset'.! Item was removed: - ----- Method: FileAttributesPlugin>>oopFromTimeT: (in category 'private') ----- - oopFromTimeT: posixSeconds - "Answer an object representation of the provided time (time_t). - The size of time_t is platform dependent, so check the size and convert appropriately." - - <var: 'posixSeconds' type: 'time_t'> - - ^(self sizeof: #time_t) = 4 ifTrue: - [interpreterProxy signed32BitIntegerFor: posixSeconds] - ifFalse: - [interpreterProxy signed64BitIntegerFor: posixSeconds]. - ! Item was added: + ----- Method: FileAttributesPlugin>>posixFileTimesFrom:to: (in category 'private - posix') ----- + posixFileTimesFrom: statBufPointer to: attributeArray + "Populate attributeArray with the file times from statBufPointer" + + | attributeDate | + + <var: 'statBufPointer' type: 'struct stat *'> + <var: 'attributeDate' type: 'sqLong'> + + self cppIf: #_WIN32 defined ifTrue: [] ifFalse: [ + attributeDate := self convertToLongSqueakTime: statBufPointer st_atime. + interpreterProxy + storePointer: 8 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + attributeDate := self convertToLongSqueakTime: statBufPointer st_mtime. + interpreterProxy + storePointer: 9 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + attributeDate := self convertToLongSqueakTime: statBufPointer st_ctime. + interpreterProxy + storePointer: 10 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate); + storePointer: 11 + ofObject: attributeArray + withValue: interpreterProxy nilObject ]. + ^0! Item was changed: ----- Method: FileAttributesPlugin>>primitiveFileAttribute (in category 'file primitives') ----- primitiveFileAttribute "Answer a single file attribute. primFileAttributes: aString attributeNumber: attributeNumber aString is the path to the file attributeNumber identifies which attribute to return: 1 - 12: stat(): name, mode, ino, dev, nlink, uid, gid, size, accessDate, modifiedDate, changeDate, creationDate 13 - 15: access(): R_OK, W_OK, X_OK 16: isSymlink On error, answer a single element array containing the appropriate error code." + | fileName attributeNumber resultOop fileNameOop statBuf cPathName sizeIfFile mode attributeDate status | - | fileName attributeNumber resultOop fileNameOop statBuf cPathName sizeIfFile mode creationDate status | <export: true> <var: 'statBuf' type: 'struct stat'> <var: 'cPathName' declareC: 'char cPathName[PATH_MAX]'> + <var: 'attributeDate' type: 'sqLong'> - <var: 'creationDate' type: 'time_t'> fileName := interpreterProxy stackObjectValue: 1. attributeNumber := interpreterProxy stackIntegerValue: 0. (interpreterProxy failed or: [(attributeNumber between: 1 and: 16) not or: [(interpreterProxy is: fileName KindOf: 'String') not]]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. status := self pathOop: fileName toBuffer: cPathName maxLen: #PATH_MAX. status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. resultOop := 0. attributeNumber < 12 ifTrue: "Get requested stat entry" [ status := self putStatFor: cPathName intoBuffer: (self addressOf: statBuf) targetName: (self addressOf: fileNameOop). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. "In C, this would naturally be a switch statement, but I don't know to mix in the smalltalk code" attributeNumber = 1 ifTrue: [resultOop := fileNameOop]. attributeNumber = 2 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_mode]. attributeNumber = 3 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_ino]. attributeNumber = 4 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_dev]. attributeNumber = 5 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_nlink]. attributeNumber = 6 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_uid]. attributeNumber = 7 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_gid]. attributeNumber = 8 ifTrue: [ sizeIfFile := ((self S_ISDIR: statBuf st_mode) = 0) ifTrue: [statBuf st_size] ifFalse: [0]. resultOop := interpreterProxy positiveMachineIntegerFor: sizeIfFile ]. + attributeNumber = 9 ifTrue: [ "Access Time" + self cppIf: #_WIN32 defined ifTrue: [ + status := self fileLastAccessTimeFor: cPathName + length: cPathName strlen + to: (self addressOf: attributeDate put: [:val| attributeDate := val]). + status ~= 0 ifTrue: + [^interpreterProxy primitiveFailForOSError: status]. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] + ifFalse: [ + attributeDate := self convertToLongSqueakTime: statBuf st_atime. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. + attributeNumber = 10 ifTrue: [ "Modified Time" + self cppIf: #_WIN32 defined ifTrue: [ + status := self fileLastWriteTimeFor: cPathName + length: cPathName strlen + to: (self addressOf: attributeDate put: [:val| attributeDate := val]). + status ~= 0 ifTrue: + [^interpreterProxy primitiveFailForOSError: status]. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] + ifFalse: [ + attributeDate := self convertToLongSqueakTime: statBuf st_mtime. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. + attributeNumber = 11 ifTrue: [ "Change Time" + self cppIf: #_WIN32 defined ifTrue: + [resultOop := interpreterProxy nilObject] + ifFalse: [ + attributeDate := self convertToLongSqueakTime: statBuf st_ctime. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. - attributeNumber = 9 ifTrue: - [resultOop := self oopFromTimeT: statBuf st_atime]. - attributeNumber = 10 ifTrue: - [resultOop := self oopFromTimeT: statBuf st_mtime]. - attributeNumber = 11 ifTrue: - [resultOop := self oopFromTimeT: statBuf st_ctime]. ] + ifFalse: [attributeNumber = 12 ifTrue: [ "Creation Time" - ifFalse: [attributeNumber = 12 ifTrue: - [ self cppIf: #_WIN32 defined ifTrue: [ status := self fileCreationTimeFor: cPathName length: cPathName strlen + to: (self addressOf: attributeDate put: [:val| attributeDate := val]). - to: (self addressOf: creationDate put: [:val| creationDate := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. + resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] - resultOop := self oopFromTimeT: creationDate ] ifFalse: [ resultOop := interpreterProxy nilObject ] ] ifFalse: [attributeNumber < 16 ifTrue: "Get requested access entry" [ attributeNumber = 13 ifTrue: [mode := self fileReadableFlag]. attributeNumber = 14 ifTrue: [mode := self fileWriteableFlag]. attributeNumber = 15 ifTrue: [mode := self fileExecutableFlag]. resultOop := ((self acc: cPathName ess: mode) = 0) ifTrue: [interpreterProxy trueObject] ifFalse: [interpreterProxy falseObject]. ] + ifFalse: "attributeNumber = 16, #isSymlink" - ifFalse: "attributeNumber = 16" [ status := self isSymlink: cPathName boolean: (self addressOf: resultOop put: [:val| resultOop := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. ]]]. resultOop = 0 ifTrue: ["It shouldn't be possible to get here" interpreterProxy primitiveFail] ifFalse: [interpreterProxy pop: 3 thenPush: resultOop]! Item was changed: ----- Method: FileAttributesPlugin>>putStatFor:intoBuffer:targetName: (in category 'private - file') ----- putStatFor: cPathName intoBuffer: statBufPointer targetName: fileNameOop "Call stat() on cPathName, storing the results in the buffer at statBufPointer." | status | <var: 'cPathName' type: 'char *'> <var: 'statBufPointer' type: 'struct stat *'> <var: 'fileNameOop' type: 'sqInt *'> status := self st: cPathName at: statBufPointer. status ~= 0 ifTrue: [^self cantStatPath]. - self cppIf: #_WIN32 defined - ifTrue: [self offsetStatBufTimesForWIN32: statBufPointer]. fileNameOop at: 0 put: interpreterProxy nilObject. ^0! Item was changed: ----- Method: FileAttributesPlugin>>statArrayFor:toArray:from:fileName: (in category 'private - file') ----- statArrayFor: cPathName toArray: attributeArray from: statBufPointer fileName: fileNameOop "Answer a file entry array from the supplied statBufPointer" + | sizeIfFile status | - | sizeIfFile creationDate status | <var: 'cPathName' type: 'char *'> <var: 'statBufPointer' type: 'struct stat *'> - <var: 'creationDate' type: 'time_t'> sizeIfFile := (self S_ISDIR: statBufPointer st_mode) = 0 ifTrue: [statBufPointer st_size] ifFalse: [0]. interpreterProxy storePointer: 0 ofObject: attributeArray withValue: fileNameOop; storePointer: 1 ofObject: attributeArray withValue: (interpreterProxy positiveMachineIntegerFor: statBufPointer st_mode); storePointer: 2 ofObject: attributeArray withValue: (interpreterProxy positive64BitIntegerFor: statBufPointer st_ino); storePointer: 3 ofObject: attributeArray withValue: (interpreterProxy positive64BitIntegerFor: statBufPointer st_dev); storePointer: 4 ofObject: attributeArray withValue: (interpreterProxy positive64BitIntegerFor: statBufPointer st_nlink); storePointer: 5 ofObject: attributeArray withValue: (interpreterProxy positiveMachineIntegerFor: statBufPointer st_uid); storePointer: 6 ofObject: attributeArray withValue: (interpreterProxy positiveMachineIntegerFor: statBufPointer st_gid); storePointer: 7 ofObject: attributeArray + withValue: (interpreterProxy positive64BitIntegerFor: sizeIfFile). + - withValue: (interpreterProxy positive64BitIntegerFor: sizeIfFile); - storePointer: 8 - ofObject: attributeArray - withValue: (self oopFromTimeT: statBufPointer st_atime); - storePointer: 9 - ofObject: attributeArray - withValue: (self oopFromTimeT: statBufPointer st_mtime); - storePointer: 10 - ofObject: attributeArray - withValue: (self oopFromTimeT: statBufPointer st_ctime). self cppIf: #_WIN32 defined + ifTrue: [ status := self winFileTimesFor: cPathName to: attributeArray ] + ifFalse: [ status := self posixFileTimesFrom: statBufPointer to: attributeArray ]. + + ^status + ! - ifTrue: - [status := self fileCreationTimeFor: cPathName - length: cPathName strlen - to: (self addressOf: creationDate put: [:val| creationDate := val]). - interpreterProxy - storePointer: 11 - ofObject: attributeArray - withValue: (status = 0 - ifTrue: [self oopFromTimeT: creationDate] - ifFalse: [interpreterProxy nilObject])] - ifFalse: - [interpreterProxy - storePointer: 11 - ofObject: attributeArray - withValue: interpreterProxy nilObject]. - ^0! Item was changed: ----- Method: FileAttributesPlugin>>versionString (in category 'version string') ----- versionString "Answer a string containing the version string for this plugin." <inline: #always> + ^'1.3.0'! - ^'1.2.6'! Item was added: + ----- Method: FileAttributesPlugin>>winFileAttributesFor:length:to: (in category 'private - windows') ----- + winFileAttributesFor: pathString length: pathLength to: winAttrs + "Populate the supplied Win32 file attribute structure" + + <option: #_WIN32> + + | win32Path | + <var: 'pathString' type: 'char *'> + <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA *'> + <var: 'win32Path' type: 'WCHAR *'> + + self touch: winAttrs. + "convert the supplied path name into a wide string" + self ALLOC_: win32Path WIN32_: pathString PATH: pathLength. + "Populate the supplied winAttrs structure" + (self cCode: 'GetFileAttributesExW(win32Path, GetFileExInfoStandard, winAttrs)') = 0 ifTrue: + [^self getAttributesFailed]. + ^0! Item was added: + ----- Method: FileAttributesPlugin>>winFileCreationTimeFor:to: (in category 'private - windows') ----- + winFileCreationTimeFor: winAttrs to: creationDate + "Set the file creation time from the supplied attributes." + <option: #_WIN32> + + | sysTime fileTime | + + <var: 'winAttrs' declareC: 'WIN32_FILE_ATTRIBUTE_DATA *winAttrs'> + <var: 'creationDate' declareC: 'sqLong *creationDate'> + <var: 'fileTime' type: 'FILETIME'> + <var: 'sysTime' type: 'SYSTEMTIME'> + + self touch: winAttrs. + self touch: sysTime. + self touch: fileTime. + + (self cCode: 'FileTimeToLocalFileTime(&winAttrs->ftCreationTime, &fileTime)') = 0 ifTrue: + [^self timeConversionFailed]. + (self cCode: 'FileTimeToSystemTime(&fileTime, &sysTime)') = 0 ifTrue: + [^self timeConversionFailed]. + self cCode: '*creationDate = convertWinToSqueakTime(sysTime)'. + + ^0! Item was added: + ----- Method: FileAttributesPlugin>>winFileLastAccessTimeFor:to: (in category 'private - windows') ----- + winFileLastAccessTimeFor: winAttrs to: accessDate + "Set the file creation time from the supplied attributes." + <option: #_WIN32> + + | sysTime fileTime | + + <var: 'winAttrs' declareC: 'WIN32_FILE_ATTRIBUTE_DATA *winAttrs'> + <var: 'accessDate' declareC: 'sqLong *accessDate'> + <var: 'fileTime' type: 'FILETIME'> + <var: 'sysTime' type: 'SYSTEMTIME'> + + self touch: winAttrs. + self touch: sysTime. + self touch: fileTime. + + (self cCode: 'FileTimeToLocalFileTime(&winAttrs->ftLastAccessTime, &fileTime)') = 0 ifTrue: + [^self timeConversionFailed]. + (self cCode: 'FileTimeToSystemTime(&fileTime, &sysTime)') = 0 ifTrue: + [^self timeConversionFailed]. + self cCode: '*accessDate = convertWinToSqueakTime(sysTime)'. + + ^0! Item was added: + ----- Method: FileAttributesPlugin>>winFileLastWriteTimeFor:to: (in category 'private - windows') ----- + winFileLastWriteTimeFor: winAttrs to: writeDate + "Set the file write time from the supplied attributes." + <option: #_WIN32> + + | sysTime fileTime | + + <var: 'winAttrs' declareC: 'WIN32_FILE_ATTRIBUTE_DATA *winAttrs'> + <var: 'writeDate' declareC: 'sqLong *writeDate'> + <var: 'fileTime' type: 'FILETIME'> + <var: 'sysTime' type: 'SYSTEMTIME'> + + self touch: winAttrs. + self touch: sysTime. + self touch: fileTime. + + (self cCode: 'FileTimeToLocalFileTime(&winAttrs->ftLastWriteTime, &fileTime)') = 0 ifTrue: + [^self timeConversionFailed]. + (self cCode: 'FileTimeToSystemTime(&fileTime, &sysTime)') = 0 ifTrue: + [^self timeConversionFailed]. + self cCode: '*writeDate = convertWinToSqueakTime(sysTime)'. + + ^0! Item was added: + ----- Method: FileAttributesPlugin>>winFileTimesFor:to: (in category 'private - windows') ----- + winFileTimesFor: cPathName to: attributeArray + <inline: #never> + <option: #_WIN32> + + | winAttrs attributeDate status | + <var: 'cPathName' declareC: 'char *cPathName'> + <var: 'attributeDate' type: 'sqLong'> + <var: 'winAttrs' type: 'WIN32_FILE_ATTRIBUTE_DATA'> + + "Get the file attributes" + status := self winFileAttributesFor: cPathName + length: cPathName strlen + to: (self addressOf: winAttrs put: [ :val | winAttrs := val ]). + status = 0 ifFalse: [^status]. + + "Set the accessDate" + status := self winFileLastAccessTimeFor: (self addressOf: winAttrs) to: (self addressOf: attributeDate). + status = 0 ifFalse: [^status]. + interpreterProxy + storePointer: 8 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + + "Set the accessDate" + status := self winFileLastWriteTimeFor: (self addressOf: winAttrs) to: (self addressOf: attributeDate). + status = 0 ifFalse: [^status]. + interpreterProxy + storePointer: 9 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + + "Set the changeDate" + interpreterProxy + storePointer: 10 + ofObject: attributeArray + withValue: interpreterProxy nilObject. + + "Set the creationDate" + status := self winFileCreationTimeFor: (self addressOf: winAttrs) to: (self addressOf: attributeDate). + status = 0 ifFalse: [^status]. + interpreterProxy + storePointer: 11 + ofObject: attributeArray + withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + + ^0 + !

1 0

VM Maker: FileAttributesPlugin.oscog-AlistairGrant.31.mcz
by commits＠source.squeak.org 29 Nov '19

29 Nov '19

Eliot Miranda uploaded a new version of FileAttributesPlugin to project VM Maker: http://source.squeak.org/VMMaker/FileAttributesPlugin.oscog-AlistairGrant.3… ==================== Summary ==================== Name: FileAttributesPlugin.oscog-AlistairGrant.31 Author: AlistairGrant Time: 17 June 2018, 7:19:22.996287 pm UUID: aeb07abd-07f5-4277-8dd5-f176f1b9222d Ancestors: FileAttributesPlugin.oscog-AlistairGrant.30 1.3.2: Get builds working on MacOS (and subsequently Windows) =============== Diff against FileAttributesPlugin.oscog-AlistairGrant.30 =============== Item was changed: ----- Method: FileAttributesPlugin class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: cg self declareC: #('sCLPfn' 'sCOFfn') as: #'void *' in: cg. "Assume the security plugin can be loaded until proven otherwise" cg var: 'hasSecurityPlugin' declareC: 'int hasSecurityPlugin = 1'. cg addHeaderFile: '<limits.h>'. cg addHeaderFile: '<sys/types.h>'. cg addHeaderFile: '<dirent.h> #ifdef _WIN32 #include <windows.h> #include <winbase.h> #define FAIL() { return -1; } #include "sqWin32File.h" - #else - #include "sqMemoryAccess.h" - extern sqLong convertToLongSqueakTime(time_t unixTime); #endif typedef struct dirptrstruct { DIR *dp; int path_len; char *path_file; char path[PATH_MAX+4]; } osdir;'. cg addHeaderFile: '<sys/stat.h> #if !!defined(HAVE_LSTAT) && !!defined(_WIN32) #define HAVE_LSTAT 1 #endif'. cg addHeaderFile: '<unistd.h> /* AKG 2017 - ', self moduleName, '.c translated from class ', self name, ' */'! Item was added: + ----- Method: FileAttributesPlugin>>faConvertUnixToLongSqueakTime: (in category 'private - posix') ----- + faConvertUnixToLongSqueakTime: unixTime + "Convert the supplied Unix (UTC) time to Squeak time. + + Squeak time has an epoch of 1901 and uses local time + i.e. timezone + daylight savings + + Answer an sqLong which is guaranteed to be 64 bits on all platforms." + + | squeakTime | + + <returnTypeC: #'sqLong'> + <var: 'unixTime' type: #'time_t'> + <var: 'squeakTime' type: #'sqLong'> + + self cppIf: #_WIN32 defined ifTrue: + [squeakTime := 0] + ifFalse: [ + squeakTime := unixTime. + self cppIf: (self defined: #HAVE_TM_GMTOFF) ifTrue: + [ squeakTime := squeakTime + (self cCode: 'localtime(&unixTime)->tm_gmtoff')] + ifFalse: [ self cppIf: (self defined: #HAVE_TIMEZONE) ifTrue: + [ squeakTime := squeakTime + (self cCode: '(daylight*60*60) - timezone')] + ifFalse: [ self cPreprocessorDirective: '#error: cannot determine timezone correction']]. + "Squeak epoch is Jan 1, 1901. Unix epoch is Jan 1, 1970: 17 leap years + and 52 non-leap years later than Squeak." + squeakTime := squeakTime + + (self cCode: '(52*365UL + 17*366UL) * 24*60*60UL' + inSmalltalk: [((52*365) + (17*366)) * 24*60*60]) ]. + ^squeakTime + + + ! Item was changed: ----- Method: FileAttributesPlugin>>posixFileTimesFrom:to: (in category 'private - posix') ----- posixFileTimesFrom: statBufPointer to: attributeArray "Populate attributeArray with the file times from statBufPointer" | attributeDate | <var: 'statBufPointer' type: #'struct stat *'> <var: 'attributeDate' type: #'sqLong'> self cppIf: #_WIN32 defined ifTrue: [] ifFalse: [ + attributeDate := self faConvertUnixToLongSqueakTime: statBufPointer st_atime. - attributeDate := self convertToLongSqueakTime: statBufPointer st_atime. interpreterProxy storePointer: 8 ofObject: attributeArray withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + attributeDate := self faConvertUnixToLongSqueakTime: statBufPointer st_mtime. - attributeDate := self convertToLongSqueakTime: statBufPointer st_mtime. interpreterProxy storePointer: 9 ofObject: attributeArray withValue: (interpreterProxy signed64BitIntegerFor: attributeDate). + attributeDate := self faConvertUnixToLongSqueakTime: statBufPointer st_ctime. - attributeDate := self convertToLongSqueakTime: statBufPointer st_ctime. interpreterProxy storePointer: 10 ofObject: attributeArray withValue: (interpreterProxy signed64BitIntegerFor: attributeDate); storePointer: 11 ofObject: attributeArray withValue: interpreterProxy nilObject ]. ^0! Item was changed: ----- Method: FileAttributesPlugin>>primitiveFileAttribute (in category 'file primitives') ----- primitiveFileAttribute "Answer a single file attribute. primFileAttributes: aString attributeNumber: attributeNumber aString is the path to the file attributeNumber identifies which attribute to return: 1 - 12: stat(): name, mode, ino, dev, nlink, uid, gid, size, accessDate, modifiedDate, changeDate, creationDate 13 - 15: access(): R_OK, W_OK, X_OK 16: isSymlink On error, answer a single element array containing the appropriate error code." | fileName attributeNumber resultOop fileNameOop statBuf cPathName sizeIfFile mode attributeDate status | <export: true> <var: 'statBuf' type: #'struct stat'> <var: 'cPathName' declareC: 'char cPathName[PATH_MAX]'> <var: 'attributeDate' type: #'sqLong'> fileName := interpreterProxy stackObjectValue: 1. attributeNumber := interpreterProxy stackIntegerValue: 0. (interpreterProxy failed or: [(attributeNumber between: 1 and: 16) not or: [(interpreterProxy is: fileName KindOf: 'String') not]]) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrBadArgument]. status := self pathOop: fileName toBuffer: cPathName maxLen: #PATH_MAX. status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. resultOop := 0. attributeNumber < 12 ifTrue: "Get requested stat entry" [ status := self putStatFor: cPathName intoBuffer: (self addressOf: statBuf) targetName: (self addressOf: fileNameOop). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. "In C, this would naturally be a switch statement, but I don't know to mix in the smalltalk code" attributeNumber = 1 ifTrue: [resultOop := fileNameOop]. attributeNumber = 2 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_mode]. attributeNumber = 3 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_ino]. attributeNumber = 4 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_dev]. attributeNumber = 5 ifTrue: [resultOop := interpreterProxy positive64BitIntegerFor: statBuf st_nlink]. attributeNumber = 6 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_uid]. attributeNumber = 7 ifTrue: [resultOop := interpreterProxy positiveMachineIntegerFor: statBuf st_gid]. attributeNumber = 8 ifTrue: [ sizeIfFile := ((self S_ISDIR: statBuf st_mode) = 0) ifTrue: [statBuf st_size] ifFalse: [0]. resultOop := interpreterProxy positiveMachineIntegerFor: sizeIfFile ]. attributeNumber = 9 ifTrue: [ "Access Time" self cppIf: #_WIN32 defined ifTrue: [ status := self fileLastAccessTimeFor: cPathName length: cPathName strlen to: (self addressOf: attributeDate put: [:val| attributeDate := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] ifFalse: [ + attributeDate := self faConvertUnixToLongSqueakTime: statBuf st_atime. - attributeDate := self convertToLongSqueakTime: statBuf st_atime. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. attributeNumber = 10 ifTrue: [ "Modified Time" self cppIf: #_WIN32 defined ifTrue: [ status := self fileLastWriteTimeFor: cPathName length: cPathName strlen to: (self addressOf: attributeDate put: [:val| attributeDate := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] ifFalse: [ + attributeDate := self faConvertUnixToLongSqueakTime: statBuf st_mtime. - attributeDate := self convertToLongSqueakTime: statBuf st_mtime. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. attributeNumber = 11 ifTrue: [ "Change Time" self cppIf: #_WIN32 defined ifTrue: [resultOop := interpreterProxy nilObject] ifFalse: [ + attributeDate := self faConvertUnixToLongSqueakTime: statBuf st_ctime. - attributeDate := self convertToLongSqueakTime: statBuf st_ctime. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate]]. ] ifFalse: [attributeNumber = 12 ifTrue: [ "Creation Time" self cppIf: #_WIN32 defined ifTrue: [ status := self fileCreationTimeFor: cPathName length: cPathName strlen to: (self addressOf: attributeDate put: [:val| attributeDate := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. resultOop := interpreterProxy signed64BitIntegerFor: attributeDate ] ifFalse: [ resultOop := interpreterProxy nilObject ] ] ifFalse: [attributeNumber < 16 ifTrue: "Get requested access entry" [ attributeNumber = 13 ifTrue: [mode := self fileReadableFlag]. attributeNumber = 14 ifTrue: [mode := self fileWriteableFlag]. attributeNumber = 15 ifTrue: [mode := self fileExecutableFlag]. resultOop := ((self acc: cPathName ess: mode) = 0) ifTrue: [interpreterProxy trueObject] ifFalse: [interpreterProxy falseObject]. ] ifFalse: "attributeNumber = 16, #isSymlink" [ status := self isSymlink: cPathName boolean: (self addressOf: resultOop put: [:val| resultOop := val]). status ~= 0 ifTrue: [^interpreterProxy primitiveFailForOSError: status]. ]]]. resultOop = 0 ifTrue: ["It shouldn't be possible to get here" interpreterProxy primitiveFail] ifFalse: [interpreterProxy pop: 3 thenPush: resultOop]! Item was changed: ----- Method: FileAttributesPlugin>>versionString (in category 'version string') ----- versionString "Answer a string containing the version string for this plugin." <inline: #always> + ^'1.3.2'! - ^'1.3.1'!

1 0

← Newer
1
2
3
4
5
6
7
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2019