Vm-dev November 2019

vm-dev@lists.squeakfoundation.org

19 participants
178 discussions

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Remove a pointer aliasing (replace by memcpy). (0e8de85)
by Nicolas Cellier 01 Nov '19

01 Nov '19

Arghh, this is completely wrong! should be `memcpy(buf,&one,4)` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0e8de8580aedea1052…

1 0

[OpenSmalltalk/opensmalltalk-vm] suspect code in sqUnixFileCopyPlugin.c (#442)
by Nicolas Cellier 01 Nov '19

01 Nov '19

So says the compiler: > > ../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:94:61: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare] > if (( (read(in, mem, stat.st_size) != stat.st_size) >= 0) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > ../../platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c:95:56: warning: result of comparison of constant 0 with boolean expression is always true [-Wtautological-constant-compare] > && (write(out, mem, stat.st_size) != stat.st_size) >= 0) The compiler is right, this makes not much sense: if (( (read(in, mem, stat.st_size) != stat.st_size) >= 0) && (write(out, mem, stat.st_size) != stat.st_size) >= 0) Also, the `copy` function may leave open file descriptors in case of failure, so it badly need some attention. https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/unix/p… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/442

2 2

[OpenSmalltalk/opensmalltalk-vm] Yet another BitBlt source pastEnd access (#441)
by Nicolas Cellier 01 Nov '19

01 Nov '19

Observed while simulating newspeak with this stack: ``` 16r107230 M BitBlt>copy:from:in:fillColor:rule: 16r320338: a(n) BitBlt 16r10725C M Form>copy:from:in:rule: 16r31F618: a(n) Form 16r1072A0 M StrikeFont>characterFormAt:put: 16r318E60: a(n) StrikeFont 16r1072D4 I StrikeFont>ensureCleanBold 16r318E60: a(n) StrikeFont 16r1072FC M StrikeFont>emphasized: 16r8EAFE8: a(n) StrikeFont 16r10731C M BrazilStringMorph(StringMorph)>fontToUse 16r314AF8: a(n) BrazilStringMorph 16r107338 M BrazilStringMorph(StringMorph)>measureContents 16r314AF8: a(n) BrazilStringMorph 16r107358 M BrazilStringMorph(StringMorph)>fitContents 16r314AF8: a(n) BrazilStringMorph 16r107370 M BrazilStringMorph(StringMorph)>font:emphasis: 16r314AF8: a(n) BrazilStringMorph 16r107398 I BrazilStringMorph(StringMorph)>font: 16r314AF8: a(n) BrazilStringMorph 16r1073B4 M LabelMorphicAgent>setMorphFont: 16r1183A0: a(n) LabelMorphicAgent 16r1073D4 M [] in LabelMorphicAgent(Object)>~ 16r1183A0: a(n) LabelMorphicAgent 16r1073F0 M AttributeMapping>update 16r316A60: a(n) AttributeMapping ``` The BitBlt spec is: ``` interpreterProxy: a Spur32BitMMLECoSimulator moduleName: nil translatedMethodCache: nil simulator: a SmartSyntaxPluginSimulator destForm: 3274264 sourceForm: 3268464 halftoneForm: 5419272 combinationRule: 3 destX: 20 destY: 0 width: 1581 height: 15 sourceX: 19 sourceY: 0 clipX: 0 clipY: 0 clipWidth: 1601 clipHeight: 15 sourceWidth: 1600 sourceHeight: 15 sourceDepth: 1 sourcePitch: 200 sourceBits: 3268512 sourcePPW: 32 sourceMSB: true destWidth: 1601 destHeight: 15 destDepth: 1 destPitch: 204 destBits: 3274312 destPPW: 32 destMSB: true bitCount: 0 skew: -1 mask1: 4095 mask2: 2147483648 preload: false nWords: 51 destMask: 2147483648 hDir: 1 vDir: 1 sourceIndex: 3271512 sourceDelta: -4 destIndex: 3277368 destDelta: 0 sx: 19 sy: 0 dx: 20 dy: 0 bbW: 1581 bbH: 15 halftoneHeight: 0 noSource: false noHalftone: true halftoneBase: nil sourceAlpha: nil srcBitShift: 0 dstBitShift: 0 bitBltOop: 3277624 affectedL: 0 affectedR: 15 affectedT: 0 affectedB: 15 opTable: #(#clearWord:with: #bitAnd:with: #bitAndInvert:with: #sourceWord:with: #bitInvertAnd:with: #destinationWord:with: #bitXor:with: #bitOr:with: #bitInvertAndInvert:with: #bitInvertXor:with: #bitInvertDestination:with: #bitOrInvert:with: #bitInvertSource:with: #bitInvertOr:with: #bitInvertOrInvert:with: #destinationWord:with: #destinationWord:with: #destinationWord:with: #addWord:with: #subWord:with: #rgbAdd:with: #rgbSub:with: #OLDrgbDiff:with: #OLDtallyIntoMap:with: #alphaBlend:with: #pixPaint:with: #pixMask:with: #rgbMax:with: #rgbMin:with: #rgbMinInvert:with: #alphaBlendConst:with: #alphaPaintConst:with: #rgbDiff:with: #tallyIntoMap:with: #alphaBlendScaled:with: #alphaBlendScaled:with: #alphaBlendScaled:with: #rgbMul:with: #pixSwap:with: #pixClear:with: #fixAlpha:with: #rgbComponentAlpha:with:) maskTable: #(1 3 nil 15 31 nil nil 255 nil nil nil nil nil nil nil 65535 nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil 4294967295) ditherMatrix4x4: a CArrayAccessor on: #(0 8 2 10 12 4 14 6 3 11 1 9 15 7 13 5) ditherThresholds16: a CArrayAccessor on: #(0 2 4 6 8 10 12 14 16) ditherValues16: a CArrayAccessor on: #(0 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30) hasSurfaceLock: false warpSrcShift: 5 warpSrcMask: 4294967295 warpAlignShift: 0 warpAlignMask: 0 warpBitShiftTable: a CArrayAccessor on: #(0 nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil) querySurfaceFn: nil lockSurfaceFn: nil unlockSurfaceFn: nil isWarping: false cmFlags: 0 cmMask: 0 cmShiftTable: nil cmMaskTable: nil cmLookupTable: nil cmBitsPerColor: 0 dither8Lookup: a CArrayAccessor on: #( ...snip byte array of size 4096 ...) componentAlphaModeColor: nil componentAlphaModeAlpha: nil ungammaLookupTable: nil gammaLookupTable: nil numGCsOnInvocation: 14 bitBltIsReceiver: true endOfDestination: 3277372 endOfSource: 3271512 destinationHashes: nil copyBitsCount: nil copyBitsBreakCount: nil ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/441

2 4

Fixed: OpenSmalltalk/opensmalltalk-vm#1845 (Cog - b3fbde3)
by Travis CI 01 Nov '19

01 Nov '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1845 Status: Fixed Duration: 1 hr, 25 mins, and 10 secs Commit: b3fbde3 (Cog) Author: Nicolas Cellier Message: Merge pull request #440 from OpenSmalltalk/compile_linux64x64_with_clang Compile linux64x64 with clang This is a workaround for issue #433 View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/a2f6e9ebafc3...b3… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/604466043?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

4 3

[OpenSmalltalk/opensmalltalk-vm] cde6a6: Remove the -fwrapv option from all linux builds
by Nicolas Cellier 01 Nov '19

01 Nov '19

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: cde6a60d0e055e689c3dc8f7347ed775ba8eaa92 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cde6a60d0e055e689c… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2019-11-01 (Fri, 01 Nov 2019) Changed paths: M build.linux32ARMv6/newspeak.cog.spur/build.assert/mvm M build.linux32ARMv6/newspeak.cog.spur/build.debug/mvm M build.linux32ARMv6/newspeak.cog.spur/build/mvm M build.linux32ARMv6/newspeak.stack.spur/build.assert/mvm M build.linux32ARMv6/newspeak.stack.spur/build.debug/mvm M build.linux32ARMv6/newspeak.stack.spur/build/mvm M build.linux32ARMv6/pharo.cog.spur/build.assert/mvm M build.linux32ARMv6/pharo.cog.spur/build.debug/mvm M build.linux32ARMv6/pharo.cog.spur/build/mvm M build.linux32ARMv6/squeak.cog.spur/build.assert/mvm M build.linux32ARMv6/squeak.cog.spur/build.debug/mvm M build.linux32ARMv6/squeak.cog.spur/build/mvm M build.linux32ARMv6/squeak.stack.spur/build.assert/mvm M build.linux32ARMv6/squeak.stack.spur/build.debug/mvm M build.linux32ARMv6/squeak.stack.spur/build/mvm M build.linux32ARMv6/squeak.stack.v3/build.assert/mvm M build.linux32ARMv6/squeak.stack.v3/build.debug/mvm M build.linux32ARMv6/squeak.stack.v3/build/mvm M build.linux32ARMv7/newspeak.cog.spur/build.assert/mvm M build.linux32ARMv7/newspeak.cog.spur/build.debug/mvm M build.linux32ARMv7/newspeak.cog.spur/build/mvm M build.linux32ARMv7/newspeak.stack.spur/build.assert/mvm M build.linux32ARMv7/newspeak.stack.spur/build.debug/mvm M build.linux32ARMv7/newspeak.stack.spur/build/mvm M build.linux32x86/newspeak.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build.assert/mvm M build.linux32x86/newspeak.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build.debug/mvm M build.linux32x86/newspeak.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build/mvm M build.linux32x86/newspeak.stack.spur/build.assert/mvm M build.linux32x86/newspeak.stack.spur/build.debug/mvm M build.linux32x86/newspeak.stack.spur/build/mvm M build.linux32x86/nsnac.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build.assert/mvm M build.linux32x86/nsnac.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build.debug/mvm M build.linux32x86/nsnac.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build/mvm M build.linux32x86/pharo.cog.spur.lowcode/build.assert.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur.lowcode/build.assert/mvm M build.linux32x86/pharo.cog.spur.lowcode/build.debug.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur.lowcode/build.debug/mvm M build.linux32x86/pharo.cog.spur.lowcode/build.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur.lowcode/build/mvm M build.linux32x86/pharo.cog.spur.minheadless/build.assert.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur.minheadless/build.debug.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur.minheadless/build.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur/build.assert/mvm M build.linux32x86/pharo.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur/build.debug/mvm M build.linux32x86/pharo.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/pharo.cog.spur/build/mvm M build.linux32x86/pharo.sista.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/pharo.sista.spur/build.assert/mvm M build.linux32x86/pharo.sista.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/pharo.sista.spur/build.debug/mvm M build.linux32x86/pharo.sista.spur/build.itimerheartbeat/mvm M build.linux32x86/pharo.sista.spur/build/mvm M build.linux32x86/pharo.stack.spur.lowcode/build.assert.itimerheartbeat/mvm M build.linux32x86/pharo.stack.spur.lowcode/build.assert/mvm M build.linux32x86/pharo.stack.spur.lowcode/build.debug.itimerheartbeat/mvm M build.linux32x86/pharo.stack.spur.lowcode/build.debug/mvm M build.linux32x86/pharo.stack.spur.lowcode/build.itimerheartbeat/mvm M build.linux32x86/pharo.stack.spur.lowcode/build/mvm M build.linux32x86/squeak.cog.spur.immutability/build.assert/mvm M build.linux32x86/squeak.cog.spur.immutability/build.debug/mvm M build.linux32x86/squeak.cog.spur.immutability/build/mvm M build.linux32x86/squeak.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/squeak.cog.spur/build.assert/mvm M build.linux32x86/squeak.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/squeak.cog.spur/build.debug/mvm M build.linux32x86/squeak.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/squeak.cog.spur/build/mvm M build.linux32x86/squeak.cog.v3/build.assert.itimerheartbeat/mvm M build.linux32x86/squeak.cog.v3/build.assert/mvm M build.linux32x86/squeak.cog.v3/build.debug.itimerheartbeat/mvm M build.linux32x86/squeak.cog.v3/build.debug/mvm M build.linux32x86/squeak.cog.v3/build.itimerheartbeat/mvm M build.linux32x86/squeak.cog.v3/build.multithreaded.assert/mvm M build.linux32x86/squeak.cog.v3/build.multithreaded.debug/mvm M build.linux32x86/squeak.cog.v3/build.multithreaded/mvm M build.linux32x86/squeak.cog.v3/build/mvm M build.linux32x86/squeak.sista.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/squeak.sista.spur/build.assert/mvm M build.linux32x86/squeak.sista.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/squeak.sista.spur/build.debug/mvm M build.linux32x86/squeak.sista.spur/build.itimerheartbeat/mvm M build.linux32x86/squeak.sista.spur/build/mvm M build.linux32x86/squeak.stack.spur/build.assert/mvm M build.linux32x86/squeak.stack.spur/build.debug/mvm M build.linux32x86/squeak.stack.spur/build/mvm M build.linux32x86/squeak.stack.v3/build.assert/mvm M build.linux32x86/squeak.stack.v3/build.debug/mvm M build.linux32x86/squeak.stack.v3/build/mvm M build.linux64ARMv8/pharo.cog.spur/build/mvm M build.linux64ARMv8/pharo.stack.spur/build.debug/mvm M build.linux64ARMv8/pharo.stack.spur/build/mvm M build.linux64ARMv8/squeak.stack.spur/build.assert/mvm M build.linux64ARMv8/squeak.stack.spur/build.debug/mvm M build.linux64ARMv8/squeak.stack.spur/build/mvm Log Message: ----------- Remove the -fwrapv option from all linux builds Commit: f6bed1e26fb7c4f57f8682a0459d66ad443b5590 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6bed1e26fb7c4f57f… Author: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> Date: 2019-11-01 (Fri, 01 Nov 2019) Changed paths: M build.macos32x86/common/Makefile.flags M build.macos64x64/common/Makefile.flags Log Message: ----------- Remove -fwrapv option from mac builds too Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/f1903e5c871d...f6…

1 0

Passed: OpenSmalltalk/opensmalltalk-vm#1847 (201910302214 - f1903e5)
by Travis CI 01 Nov '19

01 Nov '19

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1847 Status: Passed Duration: 2 hrs, 18 mins, and 29 secs Commit: f1903e5 (201910302214) Author: Nicolas Cellier Message: Generate BitBltPlugin from VMMaker.oscog-nice.2575 This is to solve issue #441 View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/201910302214 View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/605977352?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] Release 201910302214 - 201910302214
by Fabio Niephaus 01 Nov '19

01 Nov '19

-- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/201910302214

1 0

[OpenSmalltalk/opensmalltalk-vm]
by Fabio Niephaus 01 Nov '19

01 Nov '19

Branch: refs/tags/201910302214 Home: https://github.com/OpenSmalltalk/opensmalltalk-vm

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev November 2019