Vm-dev February 2018

vm-dev@lists.squeakfoundation.org

27 participants
131 discussions

[OpenSmalltalk/opensmalltalk-vm] 21379 FileAttributesPlugin _WIN32 & nil creationTime (#220)
by akgrant43 21 Feb '18

21 Feb '18

Name: FileAttributesPlugin.oscog-AlistairGrant.28 Author: AlistairGrant Time: 21 February 2018, 9:46:27.211606 am UUID: fb804aff-1cbd-4ffa-b48a-e3d665d10673 Ancestors: FileAttributesPlugin.oscog-AlistairGrant.27 1.2.6: Clean up Windows specific code, return nil for creationTime on Unix - Use the option: pragma to make Windows specific methods only compile on Windows. - Return nil instead of -1 for file creationTime on Unix Fogbugz: https://pharo.fogbugz.com/f/cases/21379/FileAttributesPlugin-_WIN32-nil-cre… You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/220 -- Commit Summary -- * 21379 FileAttributesPlugin _WIN32 & nil creationTime -- File Changes -- M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (91) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/220.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/220.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/220

2 1

[OpenSmalltalk/opensmalltalk-vm] 74f805: 21379 FileAttributesPlugin _WIN32 & nil creationTi...
by GitHub 21 Feb '18

21 Feb '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 74f805c77347c32b466811a37750e66bfcbc9270 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/74f805c77347c32b46… Author: AlistairGrant <akgrant0710(a)gmail.com> Date: 2018-02-21 (Wed, 21 Feb 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- 21379 FileAttributesPlugin _WIN32 & nil creationTime Name: FileAttributesPlugin.oscog-AlistairGrant.28 Author: AlistairGrant Time: 21 February 2018, 9:46:27.211606 am UUID: fb804aff-1cbd-4ffa-b48a-e3d665d10673 Ancestors: FileAttributesPlugin.oscog-AlistairGrant.27 1.2.6: Clean up Windows specific code, return nil for creationTime on Unix - Use the option: pragma to make Windows specific methods only compile on Windows. - Return nil instead of -1 for file creationTime on Unix Fogbugz: https://pharo.fogbugz.com/f/cases/21379/FileAttributesPlugin-_WIN32-nil-cre… Commit: 7b880914c50cac4d9571aab57dbded4cd30ceb15 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/7b880914c50cac4d95… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2018-02-21 (Wed, 21 Feb 2018) Changed paths: M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c Log Message: ----------- Merge pull request #220 from akgrant43/21379-FileAttributesPlugin-_WIN32-nil-creationTime 21379 FileAttributesPlugin _WIN32 & nil creationTime Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b2efb7d3302c...7b…

1 0

[OpenSmalltalk/opensmalltalk-vm] b2efb7: Revert "make updateSCCSVersions work in more situa...
by GitHub 21 Feb '18

21 Feb '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b2efb7d3302c29945a8ab7092b498e3eb4c6e700 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b2efb7d3302c29945a… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2018-02-21 (Wed, 21 Feb 2018) Changed paths: M scripts/updateSCCSVersions Log Message: ----------- Revert "make updateSCCSVersions work in more situations" This reverts commit 0458c6a92651fc8d0bf86158a0407f87470ade50. See http://forum.world.st/git-bites-again-td5067505.html [ci skip]

2 1

Fwd: Misc primitives & read-only objects
by Clément Bera 21 Feb '18

21 Feb '18

Hi all, I'm trying to set literals as read-only in Pharo. I've got this problem with this Misc primitive: translate: aString from: start to: stop table: table "translate the characters in the string by the given table, in place" <primitive: 'primitiveTranslateStringWithTable' module: 'MiscPrimitivePlugin'> <var: #table declareC: 'unsigned char *table'> <var: #aString declareC: 'unsigned char *aString'> start to: stop do: [ :i | aString at: i put: (table at: (aString basicAt: i) + 1) ] The primitive mutates aString without checking if it's read-only. What is the right way in Smart syntax plugin to add the read-only check ? Best, -- Clément Béra https://clementbera.github.io/ https://clementbera.wordpress.com/ Bâtiment B 40, avenue Halley 59650 *Villeneuve d'Ascq*

2 1

String comparison primitive preliminary speed-up result: 20-600x
by Clément Bera 21 Feb '18

21 Feb '18

Hi all, *The short version:* After looking into MiscPlugin with Eliot, we decided to work on a numbered primitive to speed up String comparison especially String>>#= (which matters for parsers that are widely used by our communities) as a long-term replacement for compare:with:collated: Misc primitive. Being numbered allows the JIT to have an entry for it. We (likely Eliot) will work on other Misc primitives to compile them differently in the future (No Smalltalk level smart syntax to ease cross language management) but aside from String comparison, they will remain in a plugin, since they're not as critical. The new primitive is as follow (optional last parameter so 2 versions): ByteString >> *compareWith:* anotherString ByteString >> *compareWith:* anotherString *collated:* order "Return a negative Smi, 0 or a positive Smi if self is < = or > to anotherString, with the collating order of characters given optionally by the order array." Preliminary benchmarks show 20 to 600x speed-up in String comparison (< <= = > >= on Strings; 600x on small strings, 20x on large strings). String comparison does not use any more the optional last parameter, only other APIs do. Sophie in CC did the bulk of the work as part of a 100h student project, though various discussion in the mailing list involving many of us but especially Levente, Eliot and me helped a lot. There are still some tests to write to make sure everything is stable before integration, but my understanding is that integration should happen anytime soon. Sophie, could you please answer a time frame for integration to this mail? *The long version:* The blog version includes assembly code, Cog's RTL code & Slang code for each version as well as the exact preliminary benchmarks we ran: https://clementbera.wordpress.com/2018/02/17/massive-string-comparison-perf… Levente maybe you want to review the long version in my blog if you have comments/advises before integration. I guess you will write accurate micro-benchmarks once it's integrated anyway. This LLVM/GCC performance difference is very annoying though for correct evaluation of speed-ups, I wonder, have any one seen a difference there before for other primitives? PrimitiveStringReplace might have similar issues. I don't know if we could report those things as bugs to the LLVM people somehow. Best, -- Clément Béra Pharo consortium engineer https://clementbera.wordpress.com/ Bâtiment B 40, avenue Halley 59650 Villeneuve d'Ascq

3 4

VM Maker: VMMaker.oscog-eem.2336.mcz
by commits＠source.squeak.org 20 Feb '18

20 Feb '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2336.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2336 Author: eem Time: 20 February 2018, 1:37:39.077638 pm UUID: 9f7b71dd-9980-4005-b64e-0bbf8cda761e Ancestors: VMMaker.oscog-eem.2335 RegisterAllocatingCogit: Fix the visited register filter in the register swapper in the merge engine. Write some regression tests for the merge engine. It appears that the new release process proceeds with the RegisterAllocatingCogit. =============== Diff against VMMaker.oscog-eem.2335 =============== Item was added: + ----- Method: Cogit>>opcodePrintStringFrom:to: (in category 'debug printing') ----- + opcodePrintStringFrom: startIndex to: stopIndex + ^(String streamContents: + [:s| + startIndex to: stopIndex do: + [:i| + (abstractOpcodes at: i) printStateOn: s]]) allButFirst! Item was changed: ----- Method: RegisterAllocatingCogit>>resolveConflicts:with:to: (in category 'bytecode generator support') ----- resolveConflicts: registersInCommon with: mergeSimStack to: simStackPtr "registersInCommon is the register mask of registers in use in both the current simStack and the target mergeSimStack. Swap any and all conflicting register uses in registersInCommon, until register uses in simStack agree with mergeSimStack." + | registerExchanges registerLocations agreements visited initialIndex initialStack | - | registerExchanges registerLocations agreements visited initialIndex | "registerLocations records where a register has moved to during an exchange. This allows a single pass of the stack to rename registers, instead of 1/2 N^2; max stack ~ 56" <var: 'registerExchanges' declareC: 'int registerExchanges[NumRegisters]'> <var: 'registerLocations' declareC: 'int registerLocations[NumRegisters]'> self deny: self duplicateRegisterAssignmentsInTemporaries. registersInCommon = (self registerMaskFor: FPReg) ifTrue: [self assert: (self conflictsResolvedBetweenSimStackAnd: mergeSimStack). ^self]. self cCode: '' inSmalltalk: [registerExchanges := CArrayAccessor on: (Array new: NumRegisters). registerLocations := CArrayAccessor on: (Array new: NumRegisters)]. 0 to: NumRegisters - 1 do: [:i| registerExchanges at: i put: i]. + self cCode: '' inSmalltalk: + [initialIndex := opcodeIndex. initialStack := self simStackPrintString]. "for debugging" - initialIndex := opcodeIndex. "for debugging" agreements := visited := 0. 0 to: simStackPtr do: [:i| | currentReg targetReg | currentReg := (self simStackAt: i) registerOrNone. targetReg := (self simStack: mergeSimStack at: i) registerOrNone. (currentReg ~= NoReg and: [targetReg ~= NoReg]) ifTrue: [currentReg := registerExchanges at: currentReg. currentReg = targetReg ifTrue: [(self register: currentReg isInMask: visited) ifFalse: [visited := visited bitOr: (self registerMaskFor: currentReg). agreements := agreements bitOr: (self registerMaskFor: currentReg)]] ifFalse: [((self register: currentReg isInMask: registersInCommon) + and: [self register: currentReg isNotInMask: (visited bitOr: agreements)]) ifTrue: - and: [(self register: currentReg isNotInMask: visited) - or: [self register: targetReg isNotInMask: visited]]) ifTrue: [| this that | visited := visited bitOr: (self registerMaskFor: currentReg and: targetReg). self SwapR: targetReg R: currentReg Scratch: RISCTempReg. this := registerExchanges at: currentReg. that := registerExchanges at: targetReg. registerExchanges at: currentReg put: that; at: targetReg put: this]]]]. (visited := visited bitClear: agreements) = 0 ifTrue: [self assert: (self conflictsResolvedBetweenSimStackAnd: mergeSimStack). ^self]. 0 to: NumRegisters - 1 do: [:i| registerLocations at: (registerExchanges at: i) put: i]. 0 to: simStackPtr do: [:i| | ssEntry reg | ssEntry := self simStackAt: i. reg := ssEntry registerOrNone. (reg ~= NoReg and: [(self register: reg isInMask: registersInCommon) and: [reg ~= (self simStack: mergeSimStack at: i) registerOrNone]]) ifTrue: [ssEntry type = SSRegister ifTrue: [ssEntry register: (registerLocations at: reg)] ifFalse: [ssEntry liveRegister: (registerLocations at: reg)]]]. self deny: self duplicateRegisterAssignmentsInTemporaries. self assert: (self conflictsResolvedBetweenSimStackAnd: mergeSimStack) "(initialIndex to: opcodeIndex - 1) collect: [:x| abstractOpcodes at: x]"! Item was added: + TestCase subclass: #RegisterAllocatingCogitTests + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: 'CogAbstractRegisters' + category: 'VMMaker-Tests'! Item was added: + ----- Method: RegisterAllocatingCogitTests>>testMergeRegisterSwappingForX64InBlockNodeAnalysis (in category 'tests') ----- + testMergeRegisterSwappingForX64InBlockNodeAnalysis + "Test the first merge in BlockNode>>#analyseTempsWithin:rootNode:assignmentPools:" + "self new testMergeRegisterSwappingForX64InBlockNodeAnalysis" + | cogit fixup start | + cogit := self x64Cogit. + cogit + instVarNamed: 'methodOrBlockNumArgs' put: 3; + instVarNamed: 'methodOrBlockNumTemps' put: 5; + initSimStackForFramefulMethod: nil. + (cogit simStackAt: 0) liveRegister: ReceiverResultReg. + (cogit simStackAt: 1) liveRegister: Extra4Reg. + (cogit simStackAt: 5) liveRegister: Extra5Reg. + cogit ssPushDesc: (cogit simStackAt: 1). + (fixup := cogit bytecodeFixupClass for: cogit) + mergeSimStack: cogit copySimStack; + simStackPtr: (cogit instVarNamed: 'simStackPtr'); + becomeMergeFixup. + cogit + ssPop: 1; + ssPushDesc: (cogit simStackAt: 0). + (cogit simStackAt: 1) liveRegister: NoReg. + (cogit simStackAt: 5) liveRegister: Extra5Reg. + + self assert: ' + 0 (bo FPReg-24 (spilled) (live: ReceiverResultReg)) + 1 (bo FPReg+32 (spilled)) + 2 (bo FPReg+24 (spilled)) + 3 (bo FPReg+16 (spilled)) + 4 (bo FPReg-32 (spilled)) + 5 (bo FPReg-40 (spilled) (live: Extra5Reg)) + 6<-(sb) (bo FPReg-24 (live: ReceiverResultReg)) + ' equals: cogit simStackPrintString. + self assert:' + 0 (bo FPReg-24 (spilled) (live: ReceiverResultReg)) + 1 (bo FPReg+32 (spilled) (live: Extra4Reg)) + 2 (bo FPReg+24 (spilled)) + 3 (bo FPReg+16 (spilled)) + 4 (bo FPReg-32 (spilled)) + 5 (bo FPReg-40 (spilled) (live: Extra5Reg)) + 6<- (bo FPReg+32 (live: Extra4Reg)) + ' equals: fixup simStackPrintString. + + start := cogit getOpcodeIndex. + [cogit mergeCurrentSimStackWith: fixup] + on: AssertionFailure + do: [:ex| + self assert: false description: 'assertion failure in cogit'. + ex resume: nil]. + + self assert: ' + 0 (bo FPReg-24 (spilled) (live: ReceiverResultReg)) + 1 (bo FPReg+32 (spilled)) + 2 (bo FPReg+24 (spilled)) + 3 (bo FPReg+16 (spilled)) + 4 (bo FPReg-32 (spilled)) + 5 (bo FPReg-40 (spilled) (live: Extra5Reg)) + 6<-(sb) (spill @ FPReg-48 (live: Extra4Reg)) + ' equals: cogit simStackPrintString. + + self assert: '(MoveRR ReceiverResultReg Extra4Reg)' + equals: (cogit opcodePrintStringFrom: start to: cogit getOpcodeIndex - 1)! Item was added: + ----- Method: RegisterAllocatingCogitTests>>testMergeRegisterSwappingForX64InSmallIntegerPrinting (in category 'tests') ----- + testMergeRegisterSwappingForX64InSmallIntegerPrinting + "self new testMergeRegisterSwappingForX64InSmallIntegerPrinting" + | cogit fixup start | + cogit := self x64Cogit. + cogit + instVarNamed: 'methodOrBlockNumArgs' put: 4; + instVarNamed: 'methodOrBlockNumTemps' put: 9; + initSimStackForFramefulMethod: nil; + ssPushConstant: (cogit objectMemory integerObjectOf: 0). + (fixup := cogit bytecodeFixupClass for: cogit) + mergeSimStack: cogit copySimStack; + simStackPtr: (cogit instVarNamed: 'simStackPtr'); + becomeMergeFixup. + (cogit simStackAt: 0) liveRegister: Extra5Reg. + (cogit simStackAt: 5) liveRegister: Extra4Reg. + (cogit simStackAt: 7) liveRegister: Extra3Reg. + (cogit simStack: fixup mergeSimStack at: 10) constant: (cogit objectMemory integerObjectOf: 1). + (cogit simStack: fixup mergeSimStack at: 5) liveRegister: Extra5Reg. + (cogit simStack: fixup mergeSimStack at: 7) liveRegister: Extra4Reg. + (cogit simStack: fixup mergeSimStack at: 10) liveRegister: Extra3Reg. + + self assert: ' + 0 (bo FPReg-24 (spilled) (live: Extra5Reg)) + 1 (bo FPReg+40 (spilled)) + 2 (bo FPReg+32 (spilled)) + 3 (bo FPReg+24 (spilled)) + 4 (bo FPReg+16 (spilled)) + 5 (bo FPReg-32 (spilled) (live: Extra4Reg)) + 6 (bo FPReg-40 (spilled)) + 7 (bo FPReg-48 (spilled) (live: Extra3Reg)) + 8 (bo FPReg-56 (spilled)) + 9 (bo FPReg-64 (spilled)) + 10<-(sb) (const =0 (16r0)) + ' equals: cogit simStackPrintString. + self assert: ' + 0 (bo FPReg-24 (spilled)) + 1 (bo FPReg+40 (spilled)) + 2 (bo FPReg+32 (spilled)) + 3 (bo FPReg+24 (spilled)) + 4 (bo FPReg+16 (spilled)) + 5 (bo FPReg-32 (spilled) (live: Extra5Reg)) + 6 (bo FPReg-40 (spilled)) + 7 (bo FPReg-48 (spilled) (live: Extra4Reg)) + 8 (bo FPReg-56 (spilled)) + 9 (bo FPReg-64 (spilled)) + 10<- (const =1 (16r1) (live: Extra3Reg)) + ' equals: fixup simStackPrintString. + + start := cogit getOpcodeIndex. + [cogit mergeCurrentSimStackWith: fixup] + on: AssertionFailure + do: [:ex| + self assert: false description: 'assertion failure in cogit'. + ex resume: nil]. + + self assert: ' + 0 (bo FPReg-24 (spilled)) + 1 (bo FPReg+40 (spilled)) + 2 (bo FPReg+32 (spilled)) + 3 (bo FPReg+24 (spilled)) + 4 (bo FPReg+16 (spilled)) + 5 (bo FPReg-32 (spilled) (live: Extra5Reg)) + 6 (bo FPReg-40 (spilled)) + 7 (bo FPReg-48 (spilled) (live: Extra4Reg)) + 8 (bo FPReg-56 (spilled)) + 9 (bo FPReg-64 (spilled)) + 10<-(sb) (reg Extra3Reg) + ' equals: cogit simStackPrintString. + + self assert: '(XCHGRR 15 14) (XCHGRR 14 13) (MoveCqR 1 Extra3Reg)' + equals: (cogit opcodePrintStringFrom: start to: cogit getOpcodeIndex - 1)! Item was added: + ----- Method: RegisterAllocatingCogitTests>>x64Cogit (in category 'private') ----- + x64Cogit + ^RegisterAllocatingCogit initializedInstanceForTests: #(ObjectMemory Spur64BitCoMemoryManager + ISA X64 + MULTIPLEBYTECODESETS true)! Item was added: + ----- Method: SimpleStackBasedCogit>>register:and:isNotInMask: (in category 'testing') ----- + register: reg1 and: reg2 isNotInMask: mask + <inline: true> + ^mask noMask: (self registerMaskFor: reg1 and: reg2)! Item was changed: + ----- Method: SimpleStackBasedCogit>>register:isInMask: (in category 'testing') ----- - ----- Method: SimpleStackBasedCogit>>register:isInMask: (in category 'simulation stack') ----- register: reg isInMask: mask <inline: true> ^ mask anyMask: (self registerMaskFor: reg)! Item was changed: + ----- Method: SimpleStackBasedCogit>>register:isNotInMask: (in category 'testing') ----- - ----- Method: SimpleStackBasedCogit>>register:isNotInMask: (in category 'simulation stack') ----- register: reg isNotInMask: mask <inline: true> ^ mask noMask: (self registerMaskFor: reg)!

1 0

[VM-dev] Can we be a JavaScript engine?
by Denis Kudriashov 20 Feb '18

20 Feb '18

Hi. It is just a question from the space :) I wonder, can we be a JavaScript engine? Like replacing nodeJs with Pharo/Squeak. I imagine that JS prototypes can be easily supported by anonymous classes. What is missing? Best regards, Denis

4 6

[OpenSmalltalk/opensmalltalk-vm] dc89ed: fix define*
by GitHub 20 Feb '18

20 Feb '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: dc89eded7ef7ae324823866ebe2376d10152ab37 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/dc89eded7ef7ae3248… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-02-20 (Tue, 20 Feb 2018) Changed paths: M platforms/unix/plugins/SqueakSSL/openssl_overlay.h Log Message: ----------- fix define*

1 0

[OpenSmalltalk/opensmalltalk-vm] 24c27f: fix define
by GitHub 20 Feb '18

20 Feb '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 24c27f4a84b1dfb820801ef52021a25032a1bad4 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/24c27f4a84b1dfb820… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-02-20 (Tue, 20 Feb 2018) Changed paths: M platforms/unix/plugins/SqueakSSL/openssl_overlay.h Log Message: ----------- fix define

1 0

[OpenSmalltalk/opensmalltalk-vm] 651805: move one more
by GitHub 20 Feb '18

20 Feb '18

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6518050c16072dfbb4f45884448b96c7e6d4493c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6518050c16072dfbb4… Author: Tobias Pape <tobias(a)netshed.de> Date: 2018-02-20 (Tue, 20 Feb 2018) Changed paths: M platforms/unix/plugins/SqueakSSL/openssl_overlay.h Log Message: ----------- move one more

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev February 2018