Vm-dev August 2016

vm-dev@lists.squeakfoundation.org

33 participants
98 discussions

[OpenSmalltalk/opensmalltalk-vm] 1f82cb: Force remove config.h in mvm scripts
by GitHub 17 Aug '16

17 Aug '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1f82cbdeec1dfd6072014fccfab4c9db38e9b925 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1f82cbdeec1dfd6072… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2016-08-05 (Fri, 05 Aug 2016) Changed paths: M build.linux32ARMv6/newspeak.stack.spur/build.assert/mvm M build.linux32ARMv6/newspeak.stack.spur/build.debug/mvm M build.linux32ARMv6/newspeak.stack.spur/build/mvm M build.linux32ARMv6/squeak.stack.spur/build.assert/mvm M build.linux32ARMv6/squeak.stack.spur/build.debug/mvm M build.linux32ARMv6/squeak.stack.spur/build/mvm M build.linux32ARMv6/squeak.stack.v3/build.assert/mvm M build.linux32ARMv6/squeak.stack.v3/build.debug/mvm M build.linux32ARMv6/squeak.stack.v3/build/mvm M build.linux32ARMv7/newspeak.stack.spur/build.assert/mvm M build.linux32ARMv7/newspeak.stack.spur/build.debug/mvm M build.linux32ARMv7/newspeak.stack.spur/build/mvm M build.linux32x86/newspeak.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build.assert/mvm M build.linux32x86/newspeak.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build.debug/mvm M build.linux32x86/newspeak.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/newspeak.cog.spur/build/mvm M build.linux32x86/newspeak.stack.spur/build.assert/mvm M build.linux32x86/newspeak.stack.spur/build.debug/mvm M build.linux32x86/newspeak.stack.spur/build/mvm M build.linux32x86/nsnac.cog.spur/build.assert.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build.assert/mvm M build.linux32x86/nsnac.cog.spur/build.debug.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build.debug/mvm M build.linux32x86/nsnac.cog.spur/build.itimerheartbeat/mvm M build.linux32x86/nsnac.cog.spur/build/mvm M build.linux32x86/squeak.stack.spur/build.assert/mvm M build.linux32x86/squeak.stack.spur/build.debug/mvm M build.linux32x86/squeak.stack.spur/build/mvm M build.linux32x86/squeak.stack.v3/build.assert/mvm M build.linux32x86/squeak.stack.v3/build.debug/mvm M build.linux32x86/squeak.stack.v3/build/mvm M build.linux64x64/newspeak.cog.spur/build.assert.itimerheartbeat/mvm M build.linux64x64/newspeak.cog.spur/build.assert/mvm M build.linux64x64/newspeak.cog.spur/build.debug.itimerheartbeat/mvm M build.linux64x64/newspeak.cog.spur/build.debug/mvm M build.linux64x64/newspeak.cog.spur/build.itimerheartbeat/mvm M build.linux64x64/newspeak.cog.spur/build/mvm M build.linux64x64/newspeak.stack.spur/build.assert/mvm M build.linux64x64/newspeak.stack.spur/build.debug/mvm M build.linux64x64/newspeak.stack.spur/build/mvm Log Message: ----------- Force remove config.h in mvm scripts https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3e2b3e429307bff510… /cc @bwestergaard @krono [ci skip]

3 2

Object basicNew vs object shallowCopy
by Denis Kudriashov 17 Aug '16

17 Aug '16

Hi. I compared performance between object instantiation and object cloning. I was wondering that instantiation almost twice faster than clone (primitive 70 vs 148). Could you explain why it like that and could it be improved? I was think that new object construction is much complex because it requires to fill all object fields (header structure and etc). And I was think that copy is just simple function like memcpy which just copy bytes without any logic. Here is my code: object := Object new. 3 timesRepeat: [ Smalltalk garbageCollect ]. result1 := [ Object basicNew ] benchFor: 10 seconds. 3 timesRepeat: [ Smalltalk garbageCollect ]. result2 := [ object shallowCopy ] benchFor: 10 seconds. {result1. result2}. "an Array(a BenchmarkResult(518,021,045 iterations in 10 seconds 2 milliseconds. 51,791,746 per second) a BenchmarkResult(302,807,253 iterations in 10 seconds 4 milliseconds. 30,268,618 per second))" (I run it on latest Pharo on Mac SpurVM) Best regards, Denis

5 9

Re: [Vm-dev] VM Maker: VMMaker.oscog-cb.1919.mcz
by Clément Bera 17 Aug '16

17 Aug '16

With that commit the VM is stable again. On Wed, Aug 17, 2016 at 4:11 PM, <commits(a)source.squeak.org> wrote: > > ClementBera uploaded a new version of VMMaker to project VM Maker: > http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1919.mcz > > ==================== Summary ==================== > > Name: VMMaker.oscog-cb.1919 > Author: cb > Time: 17 August 2016, 4:10:53.445475 pm > UUID: 00a8dd2a-bc8d-4552-b400-be781c8aabec > Ancestors: VMMaker.oscog-cb.1918 > > fixed bug in scanner related to twoPath methods > > =============== Diff against VMMaker.oscog-cb.1918 =============== > > Item was changed: > ----- Method: StackToRegisterMappingCogit>>compileFrameBuild (in > category 'compile abstract instructions') ----- > compileFrameBuild > "Build a frame for a CogMethod activation. See CoInterpreter > class>>initializeFrameIndices. > Override to push the register receiver and register arguments, if > any." > self cppIf: IMMUTABILITY ifTrue: > [useTwoPaths ifTrue: > [self compileTwoPathFrameBuild. > ^self]]. > needsFrame ifFalse: > [useTwoPaths ifTrue: > [self compileTwoPathFramelessInit]. > self initSimStackForFramelessMethod: initialPC. > ^self]. > + self deny: useTwoPaths. > self genPushRegisterArgs. > super compileFrameBuild. > self initSimStackForFramefulMethod: initialPC! > > Item was changed: > ----- Method: StackToRegisterMappingCogit>>scanMethod (in category > 'compile abstract instructions') ----- > scanMethod > "Scan the method (and all embedded blocks) to determine > - what the last bytecode is; extra bytes at the end of a > method are used to encode things like source pointers or temp names > - if the method needs a frame or not > - what are the targets of any backward branches. > - how many blocks it creates > Answer the block count or on error a negative error code" > | latestContinuation nExts descriptor pc numBlocks distance > targetPC framelessStackDelta seenInstVarStore | > <var: #descriptor type: #'BytecodeDescriptor *'> > needsFrame := useTwoPaths := seenInstVarStore := false. > self maybeInitNumFixups. > self maybeInitNumCounters. > prevBCDescriptor := nil. > NewspeakVM ifTrue: > [numIRCs := 0]. > (primitiveIndex > 0 > and: [coInterpreter isQuickPrimitiveIndex: primitiveIndex]) > ifTrue: > [^0]. > pc := latestContinuation := initialPC. > numBlocks := framelessStackDelta := nExts := extA := extB := 0. > [pc <= endPC] whileTrue: > [byte0 := (objectMemory fetchByte: pc ofObject: methodObj) > + bytecodeSetOffset. > descriptor := self generatorAt: byte0. > descriptor isExtension ifTrue: > [descriptor opcode = Nop ifTrue: "unknown bytecode > tag; see Cogit class>>#generatorTableFrom:" > [^EncounteredUnknownBytecode]. > self loadSubsequentBytesForDescriptor: > descriptor at: pc. > self perform: descriptor generator]. > (descriptor isReturn > and: [pc >= latestContinuation]) ifTrue: > [endPC := pc]. > > needsFrame ifFalse: > [(descriptor needsFrameFunction isNil > or: [self perform: descriptor needsFrameFunction > with: framelessStackDelta]) > ifTrue: > ["With immutability we win > simply by avoiding a frame build if the receiver is young and not > immutable." > self cppIf: IMMUTABILITY > ifTrue: > [descriptor is1ByteInstVarStore > > ifTrue: [useTwoPaths := true] > > ifFalse: [needsFrame := true. useTwoPaths := false]] > + ifFalse: > [needsFrame := true. useTwoPaths := false]] > - ifFalse: > [needsFrame := true]] > ifFalse: > [framelessStackDelta := > framelessStackDelta + descriptor stackDelta. > "Without immutability we > win if there are two or more stores and the receiver is new." > self cppIf: IMMUTABILITY > ifTrue: [] > ifFalse: > > [descriptor is1ByteInstVarStore ifTrue: > > [seenInstVarStore > > ifTrue: [useTwoPaths := true] > > ifFalse: [seenInstVarStore := true]]]]]. > > descriptor isBranch ifTrue: > [distance := self spanFor: descriptor at: pc exts: > nExts in: methodObj. > targetPC := pc + descriptor numBytes + distance. > (self isBackwardBranch: descriptor at: pc exts: > nExts in: methodObj) > ifTrue: [self initializeFixupAt: targetPC > - initialPC] > ifFalse: > [latestContinuation := > latestContinuation max: targetPC. > self maybeCountFixup. > self maybeCountCounter]]. > descriptor isBlockCreation ifTrue: > [numBlocks := numBlocks + 1. > distance := self spanFor: descriptor at: pc exts: > nExts in: methodObj. > targetPC := pc + descriptor numBytes + distance. > latestContinuation := latestContinuation max: > targetPC. > self maybeCountFixup]. > > NewspeakVM ifTrue: > [descriptor hasIRC ifTrue: > [numIRCs := numIRCs + 1]]. > pc := pc + descriptor numBytes. > descriptor isExtension > ifTrue: [nExts := nExts + 1] > ifFalse: [nExts := extA := extB := 0]. > prevBCDescriptor := descriptor]. > ^numBlocks! > >

3 3

[OpenSmalltalk/opensmalltalk-vm] 6c6ab2: Fix the mis-prefixing of the git version info with...
by GitHub 17 Aug '16

17 Aug '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 6c6ab27df7ac11b7cd593bd707bd5a0eec6ae5d5 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6c6ab27df7ac11b7cd… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-08-17 (Wed, 17 Aug 2016) Changed paths: M platforms/Cross/vm/sqSCCSVersion.h Log Message: ----------- Fix the mis-prefixing of the git version info with 'r', which applies only to Subversion. Commit: 94d921387328d20302fffa3f7e696ac85d1e98ab https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94d921387328d20302… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-08-17 (Wed, 17 Aug 2016) Changed paths: M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh Log Message: ----------- Merge branch 'Cog' of http://github.com/OpenSmalltalk/opensmalltalk-vm into Cog Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/a9f2e94decb3...94…

1 0

[OpenSmalltalk/opensmalltalk-vm] fec529: Changed scripts so they are explicitly interpreted...
by GitHub 17 Aug '16

17 Aug '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: fec529b1f25b9083ec9345374b59e3ca41f9a06c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/fec529b1f25b9083ec… Author: Ana Laura Perez Cerrato <laura(a)A4-5000-Debian.lan> Date: 2016-08-17 (Wed, 17 Aug 2016) Changed paths: M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh Log Message: ----------- Changed scripts so they are explicitly interpreted by bash and not the default shell Commit: a9f2e94decb3bbeec5d46be959a32772f0477932 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a9f2e94decb3bbeec5… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2016-08-17 (Wed, 17 Aug 2016) Changed paths: M image/buildsistareaderimage.sh M image/buildspurtrunk64image.sh M image/buildspurtrunkreader64image.sh M image/buildspurtrunkreaderimage.sh M image/buildspurtrunkvmmakerimage.sh M image/getGoodCogVM.sh M image/getGoodSpurNsvm.sh M image/getGoodSpurVM.sh M image/resizesqueakwindow.sh M image/updatespurimage.sh M image/updatevmmakerimage.sh M image/uploadspurimage.sh Log Message: ----------- Merge pull request #38 from lauraperezcerrato/Cog Changed scripts so they are explicitly interpreted by bash and not the default shell Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/cf15ce9a3049...a9…

1 0

[OpenSmalltalk/opensmalltalk-vm] cf15ce: CogVM source as per VMMaker.oscog-cb.1919
by GitHub 17 Aug '16

17 Aug '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: cf15ce9a304905918f4e28e762e570b05f3cabf7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cf15ce9a304905918f… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-08-17 (Wed, 17 Aug 2016) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-cb.1919 Cogit: fixed bug in scanner related to twoPath setter methods fixed a store check minor detail in sista vMs fixed branches from C runtime to cppIf Spur Cogit: Implement machine-code shallowCopy for Spur, excepting 0 slot objects, contexts, methods and objects with overflow size. Spur: Make sure that markAndTrace: is never inlined.

1 0

VM Maker: VMMaker.oscog-cb.1919.mcz
by commits＠source.squeak.org 17 Aug '16

17 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1919.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1919 Author: cb Time: 17 August 2016, 4:10:53.445475 pm UUID: 00a8dd2a-bc8d-4552-b400-be781c8aabec Ancestors: VMMaker.oscog-cb.1918 fixed bug in scanner related to twoPath methods =============== Diff against VMMaker.oscog-cb.1918 =============== Item was changed: ----- Method: StackToRegisterMappingCogit>>compileFrameBuild (in category 'compile abstract instructions') ----- compileFrameBuild "Build a frame for a CogMethod activation. See CoInterpreter class>>initializeFrameIndices. Override to push the register receiver and register arguments, if any." self cppIf: IMMUTABILITY ifTrue: [useTwoPaths ifTrue: [self compileTwoPathFrameBuild. ^self]]. needsFrame ifFalse: [useTwoPaths ifTrue: [self compileTwoPathFramelessInit]. self initSimStackForFramelessMethod: initialPC. ^self]. + self deny: useTwoPaths. self genPushRegisterArgs. super compileFrameBuild. self initSimStackForFramefulMethod: initialPC! Item was changed: ----- Method: StackToRegisterMappingCogit>>scanMethod (in category 'compile abstract instructions') ----- scanMethod "Scan the method (and all embedded blocks) to determine - what the last bytecode is; extra bytes at the end of a method are used to encode things like source pointers or temp names - if the method needs a frame or not - what are the targets of any backward branches. - how many blocks it creates Answer the block count or on error a negative error code" | latestContinuation nExts descriptor pc numBlocks distance targetPC framelessStackDelta seenInstVarStore | <var: #descriptor type: #'BytecodeDescriptor *'> needsFrame := useTwoPaths := seenInstVarStore := false. self maybeInitNumFixups. self maybeInitNumCounters. prevBCDescriptor := nil. NewspeakVM ifTrue: [numIRCs := 0]. (primitiveIndex > 0 and: [coInterpreter isQuickPrimitiveIndex: primitiveIndex]) ifTrue: [^0]. pc := latestContinuation := initialPC. numBlocks := framelessStackDelta := nExts := extA := extB := 0. [pc <= endPC] whileTrue: [byte0 := (objectMemory fetchByte: pc ofObject: methodObj) + bytecodeSetOffset. descriptor := self generatorAt: byte0. descriptor isExtension ifTrue: [descriptor opcode = Nop ifTrue: "unknown bytecode tag; see Cogit class>>#generatorTableFrom:" [^EncounteredUnknownBytecode]. self loadSubsequentBytesForDescriptor: descriptor at: pc. self perform: descriptor generator]. (descriptor isReturn and: [pc >= latestContinuation]) ifTrue: [endPC := pc]. needsFrame ifFalse: [(descriptor needsFrameFunction isNil or: [self perform: descriptor needsFrameFunction with: framelessStackDelta]) ifTrue: ["With immutability we win simply by avoiding a frame build if the receiver is young and not immutable." self cppIf: IMMUTABILITY ifTrue: [descriptor is1ByteInstVarStore ifTrue: [useTwoPaths := true] ifFalse: [needsFrame := true. useTwoPaths := false]] + ifFalse: [needsFrame := true. useTwoPaths := false]] - ifFalse: [needsFrame := true]] ifFalse: [framelessStackDelta := framelessStackDelta + descriptor stackDelta. "Without immutability we win if there are two or more stores and the receiver is new." self cppIf: IMMUTABILITY ifTrue: [] ifFalse: [descriptor is1ByteInstVarStore ifTrue: [seenInstVarStore ifTrue: [useTwoPaths := true] ifFalse: [seenInstVarStore := true]]]]]. descriptor isBranch ifTrue: [distance := self spanFor: descriptor at: pc exts: nExts in: methodObj. targetPC := pc + descriptor numBytes + distance. (self isBackwardBranch: descriptor at: pc exts: nExts in: methodObj) ifTrue: [self initializeFixupAt: targetPC - initialPC] ifFalse: [latestContinuation := latestContinuation max: targetPC. self maybeCountFixup. self maybeCountCounter]]. descriptor isBlockCreation ifTrue: [numBlocks := numBlocks + 1. distance := self spanFor: descriptor at: pc exts: nExts in: methodObj. targetPC := pc + descriptor numBytes + distance. latestContinuation := latestContinuation max: targetPC. self maybeCountFixup]. NewspeakVM ifTrue: [descriptor hasIRC ifTrue: [numIRCs := numIRCs + 1]]. pc := pc + descriptor numBytes. descriptor isExtension ifTrue: [nExts := nExts + 1] ifFalse: [nExts := extA := extB := 0]. prevBCDescriptor := descriptor]. ^numBlocks!

1 0

VM Maker: VMMaker.oscog-cb.1918.mcz
by commits＠source.squeak.org 17 Aug '16

17 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1918.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1918 Author: cb Time: 17 August 2016, 3:26:11.629947 pm UUID: d3b3d964-2664-4ebb-b2e7-0a21cb23ddfe Ancestors: VMMaker.oscog-eem.1917 fixed a store check minor detail in sista vMs fixed branches from C runtime to cppIf =============== Diff against VMMaker.oscog-eem.1917 =============== Item was removed: - ----- Method: StackToRegisterMappingCogit>>extBSpecifiesNoImmCheck (in category 'testing') ----- - extBSpecifiesNoImmCheck - <inline: true> - ^ extB anyMask: 4! Item was removed: - ----- Method: StackToRegisterMappingCogit>>extBSpecifiesNoStoreCheck (in category 'testing') ----- - extBSpecifiesNoStoreCheck - <inline: true> - ^ extB anyMask: 1! Item was added: + ----- Method: StackToRegisterMappingCogit>>extBSpecifiesStoreCheck (in category 'testing') ----- + extBSpecifiesStoreCheck + "This is a negative check" + <inline: true> + ^ extB noMask: 1! Item was changed: ----- Method: StackToRegisterMappingCogit>>genGenericStorePop:MaybeContextSlotIndex:needsStoreCheck:needsRestoreRcvr:needsImmutabilityCheck: (in category 'bytecode generator stores') ----- genGenericStorePop: popBoolean MaybeContextSlotIndex: slotIndex needsStoreCheck: needsStoreCheck needsRestoreRcvr: needsRestoreReceiver needsImmutabilityCheck: needsImmCheck "Generates a store into an object that *may* be a context. Multiple settings: - needsStoreCheck (young into old object check) - needRestoreRcvr (ensures the recevier is live across the store) - needsImmCheck (do the call-back if the receiver is immutable)" <inline: true> | jmpSingle jmpDone | <var: #jmpSingle type: #'AbstractInstruction *'> <var: #jmpDone type: #'AbstractInstruction *'> "The reason we need a frame here is that assigning to an inst var of a context may involve wholesale reorganization of stack pages, and the only way to preserve the execution state of an activation in that case is if it has a frame." "Context stores do not require Imm checks as contexts can't be immutable" self assert: needsFrame. self ssPop: 1. self ssAllocateCallReg: ClassReg and: SendNumArgsReg. "for ceStoreContextInstVarTrampoline" self ssPush: 1. objectRepresentation genLoadSlot: SenderIndex sourceReg: ReceiverResultReg destReg: TempReg. self ssStoreAndReplacePop: popBoolean toReg: ClassReg. jmpSingle := objectRepresentation genJumpNotSmallIntegerInScratchReg: TempReg. self MoveCq: slotIndex R: SendNumArgsReg. self CallRT: ceStoreContextInstVarTrampoline. jmpDone := self Jump: 0. jmpSingle jmpTarget: self Label. + self + cppIf: IMMUTABILITY + ifTrue: + [needsImmCheck + ifTrue: + [objectRepresentation + genStoreWithImmutabilityCheckSourceReg: ClassReg + slotIndex: slotIndex + destReg: ReceiverResultReg + scratchReg: TempReg + needsStoreCheck: needsStoreCheck + needRestoreRcvr: needsRestoreReceiver. + jmpDone jmpTarget: self Label. + ^0]]. + objectRepresentation + genStoreSourceReg: ClassReg + slotIndex: slotIndex + destReg: ReceiverResultReg + scratchReg: TempReg + inFrame: true + needsStoreCheck: needsStoreCheck. - (IMMUTABILITY and: [needsImmCheck]) - ifTrue: - [objectRepresentation - genStoreWithImmutabilityCheckSourceReg: ClassReg - slotIndex: slotIndex - destReg: ReceiverResultReg - scratchReg: TempReg - needsStoreCheck: needsStoreCheck - needRestoreRcvr: needsRestoreReceiver] - ifFalse: - [objectRepresentation - genStoreSourceReg: ClassReg - slotIndex: slotIndex - destReg: ReceiverResultReg - scratchReg: TempReg - inFrame: true - needsStoreCheck: needsStoreCheck]. jmpDone jmpTarget: self Label. ^0! Item was changed: ----- Method: StackToRegisterMappingCogit>>genGenericStorePop:slotIndex:destReg:needsStoreCheck:needsRestoreRcvr:needsImmutabilityCheck: (in category 'bytecode generator stores') ----- genGenericStorePop: popBoolean slotIndex: slotIndex destReg: destReg needsStoreCheck: needsStoreCheck needsRestoreRcvr: needsRestoreReceiver needsImmutabilityCheck: needsImmCheck "Generates a store into an object that *cannot* be a context. This code is common between multiple stores (litVar, instVar, remoteInstVar, RemoteTemp) Multiple settings: - needsStoreCheck (young into old object check) - needRestoreRcvr (ensures the receiver is live across the store) - needsImmCheck (do the call-back if the receiver is immutable)" <inline: true> "We have two very different paths as only the immutability path requires a specific register for the value on top of stack as well as the stack flush" + | topReg | + self + cppIf: IMMUTABILITY + ifTrue: + [needsImmCheck + ifTrue: + [self ssAllocateRequiredReg: ClassReg. + "we replace the top value for the flush" + self ssStoreAndReplacePop: popBoolean toReg: ClassReg. + self ssFlushTo: simStackPtr. + ^objectRepresentation + genStoreWithImmutabilityCheckSourceReg: ClassReg + slotIndex: slotIndex + destReg: destReg + scratchReg: TempReg + needsStoreCheck: needsStoreCheck + needRestoreRcvr: needsRestoreReceiver]]. + topReg := self + allocateRegForStackEntryAt: 0 + notConflictingWith: (self registerMaskFor: destReg). + self ssStorePop: popBoolean toReg: topReg. + ^objectRepresentation + genStoreSourceReg: topReg + slotIndex: slotIndex + destReg: destReg + scratchReg: TempReg + inFrame: needsFrame + needsStoreCheck: needsStoreCheck - (IMMUTABILITY and: [needsImmCheck]) - ifTrue: - [self ssAllocateRequiredReg: ClassReg. - "we replace the top value for the flush" - self ssStoreAndReplacePop: popBoolean toReg: ClassReg. - self ssFlushTo: simStackPtr. - objectRepresentation - genStoreWithImmutabilityCheckSourceReg: ClassReg - slotIndex: slotIndex - destReg: destReg - scratchReg: TempReg - needsStoreCheck: needsStoreCheck - needRestoreRcvr: needsRestoreReceiver ] - ifFalse: - [| topReg | - topReg := self - allocateRegForStackEntryAt: 0 - notConflictingWith: (self registerMaskFor: destReg). - self ssStorePop: popBoolean toReg: topReg. - objectRepresentation - genStoreSourceReg: topReg - slotIndex: slotIndex - destReg: destReg - scratchReg: TempReg - inFrame: needsFrame - needsStoreCheck: needsStoreCheck]. - ^ 0 ! Item was changed: ----- Method: StackToRegisterMappingCogit>>sistaNeedsStoreCheck (in category 'testing') ----- sistaNeedsStoreCheck <inline: true> "The store check can be ignored if the value assigned doesn't need it (immediate, etc) In addition, the extB low bit is marked by the optimizer if the store check is not required" + ^ self ssTopNeedsStoreCheck and: [ self extBSpecifiesStoreCheck ]! - ^ self ssTopNeedsStoreCheck and: [ self extBSpecifiesNoStoreCheck ]!

1 0

Re: [squeak-dev] [ANN] Squeak 5.1 Feature Freeze -- Trunk closed for new features; only bug fixes or text updates
by Eliot Miranda 16 Aug '16

16 Aug '16

Hi Tim, > On Aug 11, 2016, at 11:14 AM, tim Rowledge <tim(a)rowledge.org> wrote: [snip] > The image is frikkin’ huge. How on earth do we have 22Mb of ByteArray/BitMap/ByteString around? And it looks like we are keeping a very large amount of MC stuff; 13018 instances of MCVersionInfo/MCVersionName/DateAndTime/Date/Time/UUID. Is that smart? Simply flushing the cached ancestry from the MC browser gets rid of 60% of them and appears to save 3Mb. Except the damn saved image afterwards is exactly the same size! Sigh. Sorry about this. This is due to the immaturity (brokenness) of the Spur compactor. There is a reasonable solution for the release process, which is to modify the 32- to 64-bit bootstrap to allow the VM simulator to clone a 32-bit image having squeezed the free space out of it. I'll try and get in this asap. By year end I hope that Clément and I will have rewritten the compactor to eliminate this embarrassingly bad behaviour. > > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Strange OpCodes: RDR: Rotate Disk Right > > >

3 3

VM Maker: Cog-eem.328.mcz
by commits＠source.squeak.org 16 Aug '16

16 Aug '16

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.328.mcz ==================== Summary ==================== Name: Cog-eem.328 Author: eem Time: 15 August 2016, 7:50:11.265382 pm UUID: 09c34c1e-71c5-4a9f-870c-e441d6d24011 Ancestors: Cog-eem.327 Provide Spur32BitPreen to opreen 32-bit images, removing the excessive free space left by Spur's current poor compaction algorithm. =============== Diff against Cog-eem.327 =============== Item was added: + SimulatorHarness subclass: #Spur32BitPreen + instanceVariableNames: 'oldHeap newHeap map reverseMap oldInterpreter newInterpreter imageHeaderFlags savedWindowSize' + classVariableNames: '' + poolDictionaries: 'VMObjectIndices' + category: 'Cog-Bootstrapping'! + + !Spur32BitPreen commentStamp: 'eem 8/15/2016 19:49' prior: 0! + A Spur32BitPreen is a simple image rewriter for 32-bit Spru images that eliminates free space and hence shrinks the preened image. Use via + Spur32BitPreen new preenImage: 'spur' + which will produce spur-preen.image and spur-preen.changes from spur.image and spur.changes. + + Instance Variables + imageHeaderFlags: <Integer> + map: <Dictionary> + newHeap: <Spur32BitMMLESimulator> + newInterpreter: <StackInterpreterSimulatorLSB> + oldHeap: <Spur32BitMMLESimulator> + oldInterpreter: <StackInterpreterSimulatorLSB> + reverseMap: <Dictionary> + savedWindowSize: <Integer> + + imageHeaderFlags + - flags word in image header + + map + - map from oops in old image to oops in new image + + newHeap + - the preened heap + + newInterpreter + - the interpreter wrapping the preened heap + + oldHeap + - the heap to be preened + + oldInterpreter + - the interpreter wrapping the heap to be preened + + reverseMap + - map from oops in new image to oops in old image + + savedWindowSize + - screen size word in mage header + ! Item was added: + ----- Method: Spur32BitPreen>>clone: (in category 'bootstrap image') ----- + clone: oldObj + | newObj hash | + newObj := newHeap + allocateSlots: (oldHeap numSlotsOf: oldObj) + format: (oldHeap formatOf: oldObj) + classIndex: (oldHeap classIndexOf: oldObj). + (hash := oldHeap rawHashBitsOf: oldObj) ~= 0 ifTrue: + [newHeap setHashBitsOf: newObj to: hash]. + (oldHeap isImmutable: oldObj) ifTrue: + [newHeap setIsImmutableOf: newObj to: true]. + (oldHeap isPinned: oldObj) ifTrue: + [newHeap setIsPinnedOf: newObj to: true]. + self deny: (oldHeap isRemembered: oldObj). + self deny: (oldHeap isMarked: oldObj). + self deny: (oldHeap isGrey: oldObj). + reverseMap at: newObj put: oldObj. + ^map at: oldObj put: newObj! Item was added: + ----- Method: Spur32BitPreen>>cloneFreeLists: (in category 'bootstrap image') ----- + cloneFreeLists: oldObj + | newObj | + newObj := newHeap + allocateSlots: newHeap numFreeLists + format: newHeap wordIndexableFormat + classIndex: newHeap wordSizeClassIndexPun. + reverseMap at: newObj put: oldObj. + ^map at: oldObj put: newObj! Item was added: + ----- Method: Spur32BitPreen>>cloneObjects (in category 'bootstrap image') ----- + cloneObjects + "Clone all normal objects. Of hidden objects only clone the freeLists object and + the classTableRoot and class table pages. In particular, dont clone objStacks. + The refs to the objStacks are nilled out in fillInHeap." + | i freeListsObject | + i := 0. + freeListsObject := oldHeap freeListsObject. + oldHeap allOldSpaceObjectsDo: + [:obj32| + (i := i + 1) >= 100000 ifTrue: + [Transcript nextPut: $:; flush. i := 0]. + obj32 = freeListsObject + ifTrue: + [self cloneFreeLists: obj32] + ifFalse: + [(self shouldClone: obj32) ifTrue: + [self clone: obj32]]]! Item was added: + ----- Method: Spur32BitPreen>>fillInBitsObject:from: (in category 'bootstrap image') ----- + fillInBitsObject: obj64 from: obj32 + 0 to: (oldHeap numBytesOf: obj32) - 1 do: + [:i| + newHeap + storeByte: i + ofObject: obj64 + withValue: (oldHeap fetchByte: i ofObject: obj32)]! Item was added: + ----- Method: Spur32BitPreen>>fillInClassTable (in category 'bootstrap image') ----- + fillInClassTable + self fillInPointerObject: (map at: oldHeap classTableRootObj) from: oldHeap classTableRootObj! Item was added: + ----- Method: Spur32BitPreen>>fillInCompiledMethod:from: (in category 'bootstrap image') ----- + fillInCompiledMethod: newObj from: oldObj + "oldInterpreter printOop: oldObj" + "newInterpreter printOop: newObj" + 0 to: (oldHeap numPointerSlotsOf: oldObj) - 1 do: + [:i| | oldOop newOop | + oldOop := oldHeap fetchPointer: i ofObject: oldObj. + newOop := self map32BitOop: oldOop. + newHeap + storePointerUnchecked: i + ofObject: newObj + withValue: newOop]. + (oldInterpreter startPCOfMethod: oldObj) + to: (oldHeap numBytesOf: oldObj) - 1 + do: [:j| + newHeap + storeByte: j + ofObject: newObj + withValue: (oldHeap fetchByte: j ofObject: oldObj)]! Item was added: + ----- Method: Spur32BitPreen>>fillInHeap (in category 'bootstrap image') ----- + fillInHeap + | heapEnd freeListsObj | + heapEnd := newHeap freeStart. + newHeap + nilObject: (map at: oldHeap nilObject); + falseObject: (map at: oldHeap falseObject); + trueObject: (map at: oldHeap trueObject); + specialObjectsOop: (map at: oldHeap specialObjectsOop); + lastHash: oldHeap lastHash; + setHiddenRootsObj: (map at: oldHeap classTableRootObj). + newHeap segmentManager + initSegmentForInImageCompilationFrom: newHeap nilObject + to: heapEnd + newHeap bridgeSize. + freeListsObj := newHeap objectAfter: newHeap trueObject. + "Nil-out the free lists." + newHeap + fillObj: freeListsObj numSlots: (newHeap numSlotsOf: freeListsObj) with: 0; + initializeFreeSpacePostLoad: freeListsObj; + initializePostBootstrap; + setEndOfMemory: (newHeap segmentManager bridgeAt: 0) + newHeap baseHeaderSize! Item was added: + ----- Method: Spur32BitPreen>>fillInObjects (in category 'bootstrap image') ----- + fillInObjects + "interpreter32 printOop: oldObj" + | i | + {oldHeap markStack. oldHeap weaklingStack. oldHeap mournQueue} do: + [:obj| + obj ~= oldHeap nilObject ifTrue: + [map at: obj put: (map at: oldHeap nilObject)]]. + i := 0. + oldHeap allObjectsDo: + [:oldObj| + (i := i + 1) >= 10000 ifTrue: + [Transcript nextPut: $.; flush. i := 0]. + (map at: oldObj ifAbsent: nil) + ifNotNil: + [:newObj| | format | + (newHeap numSlotsOf: newObj) > 0 ifTrue: "filter-out filtered objStack pages" + [format := oldHeap formatOf: oldObj. + (newHeap isPointersFormat: format) + ifTrue: + [self fillInPointerObject: newObj from: oldObj] + ifFalse: + [(newHeap isCompiledMethodFormat: format) + ifTrue: [self fillInCompiledMethod: newObj from: oldObj] + ifFalse: [self fillInBitsObject: newObj from: oldObj]]]] + ifNil: [self assert: (self isUnmappedObject: oldObj)]]! Item was added: + ----- Method: Spur32BitPreen>>fillInPointerObject:from: (in category 'bootstrap image') ----- + fillInPointerObject: newObj from: oldObj + 0 to: (oldHeap numSlotsOf: oldObj) - 1 do: + [:i| + newHeap + storePointerUnchecked: i + ofObject: newObj + withValue: (self map32BitOop: (oldHeap fetchPointer: i ofObject: oldObj))]! Item was added: + ----- Method: Spur32BitPreen>>incrementPCField:ofObject:for: (in category 'bootstrap image') ----- + incrementPCField: fieldIndex ofObject: obj64 for: method32 + | value nLits | + value := newHeap fetchPointer: fieldIndex ofObject: obj64. + (newHeap isIntegerObject: value) + ifTrue: + [nLits := oldHeap literalCountOf: method32. + newHeap + storePointerUnchecked: fieldIndex + ofObject: obj64 + withValue: (newHeap integerObjectOf: nLits + LiteralStart * 4 + (newHeap integerValueOf: value))] + ifFalse: + [self assert: (reverseMap at: value) = oldHeap nilObject]! Item was added: + ----- Method: Spur32BitPreen>>initMaps (in category 'initialize-release') ----- + initMaps + map := Dictionary new: oldHeap memory size // 32. + reverseMap := Dictionary new: oldHeap memory size // 32! Item was added: + ----- Method: Spur32BitPreen>>isUnmappedObject: (in category 'bootstrap image') ----- + isUnmappedObject: obj32 + "Answer if obj32 is an object that is not cloned by the bootstrap." + ^obj32 = oldHeap freeListsObject + or: [(oldHeap isValidObjStackPage: obj32)]! Item was added: + ----- Method: Spur32BitPreen>>map32BitOop: (in category 'bootstrap image') ----- + map32BitOop: obj32 + "oldInterpreter printOop: obj32" + ^map + at: obj32 + ifAbsent: + [(oldHeap isImmediateCharacter: obj32) + ifTrue: [newHeap characterObjectOf: (oldHeap characterValueOf: obj32)] + ifFalse: [newHeap integerObjectOf: (oldHeap integerValueOf: obj32)]]! Item was added: + ----- Method: Spur32BitPreen>>on: (in category 'public access') ----- + on: imageName + (oldInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager)) + openOn: imageName extraMemory: 0. + oldHeap := oldInterpreter objectMemory. + imageHeaderFlags := oldInterpreter getImageHeaderFlags. + savedWindowSize := oldInterpreter savedWindowSize. + newInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager). + newHeap := newInterpreter objectMemory. + newHeap + allocateMemoryOfSize: oldHeap oldSpaceSize + newSpaceSize: 8 * 1024 * 1024 + stackSize: 16 * 1024 + codeSize: 0. + newHeap bootstrapping: true. + self initMaps! Item was added: + ----- Method: Spur32BitPreen>>preenImage (in category 'public access') ----- + preenImage + self cloneObjects. + self fillInObjects. + self fillInClassTable. + self fillInHeap. + self reportSizes! Item was added: + ----- Method: Spur32BitPreen>>preenImage: (in category 'public access') ----- + preenImage: imageName + (Smalltalk classNamed: #FileReference) ifNotNil: + [^self preenImageUsingFileReference: imageName]. + (Smalltalk classNamed: #FileDirectory) ifNotNil: + [^self preenImageUsingFileDirectory: imageName]. + self error: 'at a loss as to what file system support to use'! Item was added: + ----- Method: Spur32BitPreen>>preenImageUsingFileDirectory: (in category 'public access') ----- + preenImageUsingFileDirectory: imageName + | dirName baseName dir | + dirName := FileDirectory dirPathFor: imageName. + baseName := (imageName endsWith: '.image') + ifTrue: [FileDirectory baseNameFor: imageName] + ifFalse: [FileDirectory localNameFor: imageName]. + dir := dirName isEmpty ifTrue: [FileDirectory default] ifFalse: [FileDirectory default on: dirName]. + self on: (dir fullNameFor: baseName, '.image'). + [self preenImage] + on: Halt + do: [:ex| + "suppress halts from the usual suspects (development time halts)" + (#(fullGC compactImage) includes: ex signalerContext sender selector) + ifTrue: [ex resume] + ifFalse: [ex pass]]. + self writeSnapshot: (dir fullNameFor: baseName, '-preen.image') + headerFlags: imageHeaderFlags + screenSize: savedWindowSize. + dir deleteFileNamed: baseName, '-preen.changes'; + copyFileNamed: baseName, '.changes' toFileNamed: baseName, '-preen.changes'! Item was added: + ----- Method: Spur32BitPreen>>reportSizes (in category 'bootstrap image') ----- + reportSizes + | change oldHeapSize newHeapSize | + oldHeapSize := oldHeap oldSpaceSize. + newHeapSize := newHeap oldSpaceSize. + change := newHeapSize - oldHeapSize / oldHeapSize. + Transcript + nextPutAll: 'done.'; cr; + nextPutAll: 'old heap size: '; nextPutAll: oldHeapSize asStringWithCommas; tab; + nextPutAll: 'initial new heap size: '; nextPutAll: newHeapSize asStringWithCommas; cr; + nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; + flush. + newHeapSize := newHeap endOfMemory + - newHeap scavenger eden limit + - newHeap totalFreeListBytes. + change := newHeapSize - oldHeapSize / oldHeapSize. + Transcript + nextPutAll: 'final new heap size: '; nextPutAll: newHeapSize asStringWithCommas; tab; + nextPutAll: 'change: '; print: change * 100.0 maxDecimalPlaces: 2; nextPut: $%; cr; + flush! Item was added: + ----- Method: Spur32BitPreen>>shouldClone: (in category 'bootstrap image') ----- + shouldClone: obj32 + ^(oldHeap isValidObjStackPage: obj32) not! Item was added: + ----- Method: Spur32BitPreen>>writeSnapshot:headerFlags:screenSize: (in category 'snapshot') ----- + writeSnapshot: imageFileName headerFlags: headerFlags screenSize: screenSizeInteger + newHeap + checkFreeSpace; + runLeakCheckerForFullGC. + newInterpreter + setImageHeaderFlagsFrom: headerFlags; + setDisplayForm: nil; + setSavedWindowSize: savedWindowSize; + imageName: imageFileName; + writeImageFileIO. + Transcript cr; show: 'Done!!'! Item was changed: ----- Method: Spur32to64BitBootstrap>>cloneFreeLists: (in category 'bootstrap image') ----- cloneFreeLists: obj32 | obj64 | obj64 := heap64 allocateSlots: heap64 numFreeLists + format: heap64 wordIndexableFormat + classIndex: heap64 wordSizeClassIndexPun. - format: heap64 sixtyFourBitIndexableFormat - classIndex: heap64 sixtyFourBitLongsClassIndexPun. reverseMap at: obj64 put: obj32. ^map at: obj32 put: obj64!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2016