Vm-dev August 2016

vm-dev@lists.squeakfoundation.org

33 participants
98 discussions

VM Maker: VMMaker.oscog-cb.1927.mcz
by commits＠source.squeak.org 31 Aug '16

31 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1927.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1927 Author: cb Time: 31 August 2016, 1:48:20.563669 pm UUID: d00bfc22-488e-430c-a9f6-90cbaeabdb23 Ancestors: VMMaker.oscog-eem.1926 Now that the trampoline for context inst var store can be called on single contexts, we need to update the trampoline to work with single contexts =============== Diff against VMMaker.oscog-eem.1926 =============== Item was changed: ----- Method: CoInterpreter>>ceContext:instVar:value: (in category 'trampolines') ----- ceContext: maybeMarriedContext instVar: slotIndex value: anOop <api> "genStorePop:MaybeContextReceiverVariable: filters out unmarried contexts but not arbitrary objects in subclasses. It answers maybeMarriedContext so that the StackToRegisterMappingCogit can keep ReceiverResultReg live." + ((objectMemory isContextNonImm: maybeMarriedContext) + and: [self isMarriedOrWidowedContext: maybeMarriedContext]) - (objectMemory isContextNonImm: maybeMarriedContext) ifTrue: + [instructionPointer := self popStack. - [self assert: (self isMarriedOrWidowedContext: maybeMarriedContext). - instructionPointer := self popStack. self externalInstVar: slotIndex ofContext: maybeMarriedContext put: anOop. self push: instructionPointer] ifFalse: [objectMemory storePointer: slotIndex ofObject: maybeMarriedContext withValue: anOop]. ^maybeMarriedContext!

1 0

VM Maker: VMMaker.oscog-eem.1926.mcz
by commits＠source.squeak.org 31 Aug '16

31 Aug '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1926.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.1926 Author: eem Time: 31 August 2016, 12:34:22.439536 pm UUID: e25b6c8f-9742-4011-a948-d27ae483a098 Ancestors: VMMaker.oscog-cb.1925 Comment the register saving convention for the context inst var access trampolines in the JIT. =============== Diff against VMMaker.oscog-cb.1925 =============== Item was changed: ----- Method: Cogit>>generateRunTimeTrampolines (in category 'initialization') ----- generateRunTimeTrampolines "Generate the run-time entries at the base of the native code zone and update the base." ceSendMustBeBooleanAddFalseTrampoline := self genMustBeBooleanTrampolineFor: objectMemory falseObject called: 'ceSendMustBeBooleanAddFalseTrampoline'. ceSendMustBeBooleanAddTrueTrampoline := self genMustBeBooleanTrampolineFor: objectMemory trueObject called: 'ceSendMustBeBooleanAddTrueTrampoline'. ceNonLocalReturnTrampoline := self genNonLocalReturnTrampoline. ceCheckForInterruptTrampoline := self genCheckForInterruptsTrampoline. + "Neither of the context inst var access trampolines save registers. Their operation could cause + arbitrary update of stack frames, so the assumption is that callers flush the stack before calling + the context inst var access trampolines, and that everything except the result is dead afterwards." ceFetchContextInstVarTrampoline := self genTrampolineFor: #ceContext:instVar: called: 'ceFetchContextInstVarTrampoline' arg: ReceiverResultReg arg: SendNumArgsReg result: SendNumArgsReg. ceStoreContextInstVarTrampoline := self genTrampolineFor: #ceContext:instVar:value: called: 'ceStoreContextInstVarTrampoline' arg: ReceiverResultReg arg: SendNumArgsReg arg: ClassReg result: ReceiverResultReg. "to keep ReceiverResultReg live.". ceCannotResumeTrampoline := self genTrampolineFor: #ceCannotResume called: 'ceCannotResumeTrampoline'. "These two are unusual; they are reached by return instructions." ceBaseFrameReturnTrampoline := self genReturnTrampolineFor: #ceBaseFrameReturn: called: 'ceBaseFrameReturnTrampoline' arg: ReceiverResultReg. ceReturnToInterpreterTrampoline := self genReturnTrampolineFor: #ceReturnToInterpreter: called: 'ceReturnToInterpreterTrampoline' arg: ReceiverResultReg!

1 0

VM Maker: VMMaker.oscog-cb.1925.mcz
by commits＠source.squeak.org 31 Aug '16

31 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1925.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1925 Author: cb Time: 31 August 2016, 1:27:47.355435 pm UUID: b77be8d3-8f56-4e47-a88f-960dc3050d55 Ancestors: VMMaker.oscog-cb.1924 assertion improvement to make the simulator more robust. Added immutability check in maybe context object store in jitted code. Added an annotation for inst var store in the SistaV1 bytecode set to tip the JIT if the mutated object may be a context or not. StackSpur VM are now generated with dual bytecode set support. =============== Diff against VMMaker.oscog-cb.1924 =============== Item was changed: ----- Method: StackInterpreter>>objCouldBeClassObj: (in category 'debug support') ----- objCouldBeClassObj: objOop "Answer if objOop looks like a class object. WIth Spur be lenient if the object doesn't yet have a hash (i.e. is not yet in the classTable), and accept forwarding pointers." <api> <inline: false> | fieldOop | ^(objectMemory isPointersNonImm: objOop) and: [(objectMemory numSlotsOfAny: objOop) > InstanceSpecificationIndex and: [fieldOop := objectMemory fetchPointer: SuperclassIndex ofObject: objOop. + ((objectMemory addressCouldBeObj: fieldOop) - ((objectMemory isNonImmediate: fieldOop) and:[ (objectMemory isPointersNonImm: fieldOop) or: [(objectMemory isOopForwarded: fieldOop) and: [objectMemory isPointers: (objectMemory followForwarded: fieldOop)]]]) and: [fieldOop := objectMemory fetchPointer: MethodDictionaryIndex ofObject: objOop. + ((objectMemory addressCouldBeObj: fieldOop) - ((objectMemory isNonImmediate: fieldOop) and:[ (objectMemory isPointersNonImm: fieldOop) or: [(objectMemory isOopForwarded: fieldOop) and: [objectMemory isPointers: (objectMemory followForwarded: fieldOop)]]]) and: [(objectMemory isIntegerObject: (objectMemory fetchPointer: InstanceSpecificationIndex ofObject: objOop))]]]]! Item was changed: ----- Method: StackInterpreter>>shortPrint: (in category 'simulation') ----- shortPrint: oop <doNotGenerate> | name classOop | (objectMemory isImmediate: oop) ifTrue: [(objectMemory isImmediateCharacter: oop) ifTrue: [^(objectMemory characterValueOf: oop) < 256 ifTrue: ['=$', (objectMemory characterValueOf: oop) printString, ' (', (String with: (Character value: (objectMemory characterValueOf: oop))), ')'] ifFalse: ['=$', (objectMemory characterValueOf: oop) printString, '(???)']]. (objectMemory isIntegerObject: oop) ifTrue: [^'=', (objectMemory integerValueOf: oop) printString, ' (', (objectMemory integerValueOf: oop) hex, ')']. (objectMemory isImmediateFloat: oop) ifTrue: [^ '=', (objectMemory floatValueOf: oop) printString, ' (', oop hex, ')']. ^'= UNKNOWN IMMEDIATE', ' (', (objectMemory integerValueOf: oop) hex, ')']. (objectMemory addressCouldBeObj: oop) ifFalse: [^(oop bitAnd: objectMemory allocationUnit - 1) ~= 0 ifTrue: [' is misaligned'] ifFalse: [self whereIs: oop]]. (objectMemory isFreeObject: oop) ifTrue: [^' is a free chunk of size ', (objectMemory sizeOfFree: oop) printString, (objectMemory hasSpurMemoryManagerAPI ifTrue: [' 0th: ', (objectMemory fetchPointer: 0 ofFreeChunk: oop) hex] ifFalse: [''])]. (objectMemory isForwarded: oop) ifTrue: [^' is a forwarded object to ', (objectMemory followForwarded: oop) hex, ' of slot size ', (objectMemory numSlotsOfAny: oop) printString]. (objectMemory isFloatInstance: oop) ifTrue: [^'=', (objectMemory dbgFloatValueOf: oop) printString]. oop = objectMemory nilObject ifTrue: [^'nil']. oop = objectMemory falseObject ifTrue: [^'false']. oop = objectMemory trueObject ifTrue: [^'true']. classOop := objectMemory fetchClassOfNonImm: oop. ((self objCouldBeClassObj: oop) and: [(objectMemory numSlotsOf: classOop) = metaclassNumSlots]) ifTrue: [^'class ', (self nameOfClass: oop)]. name := self nameOfClass: classOop. name size = 0 ifTrue: [name := '??']. (#('String' 'ByteString') includes: name) ifTrue: [^(self stringOf: oop) printString]. (#('Symbol' 'ByteSymbol') includes: name) ifTrue: [^'#', (self stringOf: oop)]. name = 'Character' ifTrue: "SpurMemoryManager has immediate Characters (see above); ObjectMemory does not" [^'=', (Character value: (objectMemory integerValueOf: (objectMemory fetchPointer: 0 ofObject: oop))) printString]. "Try to spot association-like things; they're all subclasses of LookupKey" ((objectMemory isPointersNonImm: oop) and: [classOop ~= objectMemory nilObject and: [((objectMemory instanceSizeOf: classOop) between: ValueIndex + 1 and: ValueIndex + 2) + and: [(objectMemory addressCouldBeObj: (objectMemory fetchPointer: KeyIndex ofObject: oop))] + and: [(objectMemory isBytesNonImm: (objectMemory fetchPointer: KeyIndex ofObject: oop))]]]) ifTrue: - and: [(objectMemory isBytes: (objectMemory fetchPointer: KeyIndex ofObject: oop))]]]) ifTrue: [| classLookupKey | classLookupKey := objectMemory fetchClassOfNonImm: (objectMemory splObj: SchedulerAssociation). [classLookupKey = objectMemory nilObject ifTrue: [^(('AEIOU' includes: name first) ifTrue: ['an '] ifFalse: ['a ']), name]. (objectMemory instanceSizeOf: classLookupKey) = (KeyIndex + 1)] whileFalse: [classLookupKey := self superclassOf: classLookupKey]. (self includesBehavior: classOop ThatOf: classLookupKey) ifTrue: [^(('AEIOU' includes: name first) ifTrue: ['an '] ifFalse: ['a ']), name, ' ', (self shortPrint: (objectMemory fetchPointer: KeyIndex ofObject: oop)), ' -> ', (objectMemory fetchPointer: ValueIndex ofObject: oop) hex8]]. ^(('AEIOU' includes: name first) ifTrue: ['an '] ifFalse: ['a ']), name! Item was changed: ----- Method: StackToRegisterMappingCogit>>genGenericStorePop:MaybeContextSlotIndex:needsStoreCheck:needsRestoreRcvr:needsImmutabilityCheck: (in category 'bytecode generator stores') ----- genGenericStorePop: popBoolean MaybeContextSlotIndex: slotIndex needsStoreCheck: needsStoreCheck needsRestoreRcvr: needsRestoreReceiver needsImmutabilityCheck: needsImmCheck "Generates a store into an object that *may* be a context. Multiple settings: - needsStoreCheck (young into old object check) - needRestoreRcvr (ensures the recevier is live across the store) - needsImmCheck (do the call-back if the receiver is immutable)" <inline: true> - | jmpSingle jmpDone | <var: #jmpSingle type: #'AbstractInstruction *'> <var: #jmpDone type: #'AbstractInstruction *'> + <var: #mutableJump type: #'AbstractInstruction *'> + <var: #immutabilityFailure type: #'AbstractInstruction *'> + | immutabilityFailure mutableJump | "The reason we need a frame here is that assigning to an inst var of a context may involve wholesale reorganization of stack pages, and the only way to preserve the execution state of an activation in that case is if it has a frame." - "Context stores do not require Imm checks as contexts can't be immutable" self assert: needsFrame. + self + cppIf: IMMUTABILITY + ifTrue: + [needsImmCheck + ifTrue: + [mutableJump := objectRepresentation genJumpMutable: ReceiverResultReg scratchReg: TempReg. + objectRepresentation genStoreTrampolineCall: slotIndex. + needsRestoreReceiver ifTrue: [ self putSelfInReceiverResultReg ]. + immutabilityFailure := self Jump: 0. + mutableJump jmpTarget: self Label.]]. self ssPop: 1. self ssAllocateCallReg: ClassReg and: SendNumArgsReg. "for ceStoreContextInstVarTrampoline" self ssPush: 1. objectRepresentation genLoadSlot: SenderIndex sourceReg: ReceiverResultReg destReg: TempReg. self ssStoreAndReplacePop: popBoolean toReg: ClassReg. + self ssFlushTo: simStackPtr. - jmpSingle := objectRepresentation genJumpNotSmallIntegerInScratchReg: TempReg. self MoveCq: slotIndex R: SendNumArgsReg. self CallRT: ceStoreContextInstVarTrampoline. - jmpDone := self Jump: 0. - jmpSingle jmpTarget: self Label. self cppIf: IMMUTABILITY ifTrue: + [needsImmCheck ifTrue:[immutabilityFailure jmpTarget: self Label]]. - [needsImmCheck - ifTrue: - [objectRepresentation - genStoreWithImmutabilityCheckSourceReg: ClassReg - slotIndex: slotIndex - destReg: ReceiverResultReg - scratchReg: TempReg - needsStoreCheck: needsStoreCheck - needRestoreRcvr: needsRestoreReceiver. - jmpDone jmpTarget: self Label. - ^0]]. - objectRepresentation - genStoreSourceReg: ClassReg - slotIndex: slotIndex - destReg: ReceiverResultReg - scratchReg: TempReg - inFrame: true - needsStoreCheck: needsStoreCheck. - jmpDone jmpTarget: self Label. ^0! Item was changed: ----- Method: StackToRegisterMappingCogit>>genSistaExtStoreAndPopReceiverVariableBytecodePopBoolean: (in category 'bytecode generators') ----- + genSistaExtStoreAndPopReceiverVariableBytecodePopBoolean: popBoolean - genSistaExtStoreAndPopReceiverVariableBytecodePopBoolean: boolean <inline: true> + | index needsStoreCheck needsImmCheck maybeContext | - | index needsStoreCheck needsImmCheck | needsStoreCheck := self sistaNeedsStoreCheck. needsImmCheck := self extBSpecifiesImmCheck. + "Long form and short form exist for popInto. Only the long form exists for store. + Store have an explicit flag to mark context accessing, while popInto context accessing are done through the long form, + hence generate the context form if the flag is set or if this is a popInto." + maybeContext := popBoolean or: [self extBSpecifiesMaybeContext]. extB := 0. index := byte1 + (extA << 8). extA := 0. + ^((coInterpreter isWriteMediatedContextInstVarIndex: index) and: [maybeContext]) - ^(coInterpreter isWriteMediatedContextInstVarIndex: index) ifTrue: [self + genStorePop: popBoolean - genStorePop: boolean MaybeContextReceiverVariable: index needsStoreCheck: needsStoreCheck needsImmutabilityCheck: needsImmCheck] ifFalse: [self + genStorePop: popBoolean - genStorePop: boolean ReceiverVariable: index needsStoreCheck: needsStoreCheck needsImmutabilityCheck: needsImmCheck]! Item was changed: ----- Method: VMMaker class>>generateSqueakSpurStackVM (in category 'configurations') ----- generateSqueakSpurStackVM "No primitives since we can use those from the Cog VM" ^VMMaker generate: StackInterpreter with: #(ObjectMemory Spur32BitMemoryManager + FailImbalancedPrimitives false + MULTIPLEBYTECODESETS true + bytecodeTableInitializer initializeBytecodeTableForSqueakV3PlusClosuresSistaV1Hybrid) - FailImbalancedPrimitives false) to: (FileDirectory default pathFromURI: self sourceTree, '/spurstacksrc') platformDir: (FileDirectory default pathFromURI: self sourceTree, '/platforms') including: #()!

1 0

VM Maker: BytecodeSets.spur-cb.57.mcz
by commits＠source.squeak.org 31 Aug '16

31 Aug '16

ClementBera uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-cb.57.mcz ==================== Summary ==================== Name: BytecodeSets.spur-cb.57 Author: cb Time: 31 August 2016, 1:24:23.877084 pm UUID: 78a8e61c-ebef-4698-9e53-8a3d40cc2ca7 Ancestors: BytecodeSets.spur-eem.56 As there is a single form for instance variable store, I added an annotation so that the JIt knows if the inst var store is with a maybe context object or not. =============== Diff against BytecodeSets.spur-eem.56 =============== Item was removed: - ----- Method: EncoderForSistaV1>>genStoreFlagExtensionIgnoreStoreCheck:maybeContext: (in category 'extended bytecode generation') ----- - genStoreFlagExtensionIgnoreStoreCheck: ignoreStoreCheck maybeContext: maybeContext - "ignoreStoreCheck: - Can be applied to the long form of store and store pop of literal variable, remote inst var, remote temp, receiver inst var. - If present, the VM does not generate the GC store check. - The main reasons the compiler can ignore the store check are one of these two: - - the mutated object is always young - - the object stored is immediate - Currently the store check is for the remembered table, but we may have it for tri color marking later. So the compiler cannot really remove the store check if the object stored is old. - - maybeContext: - Can be used only with remote instance variable stores. If marked, the object can be a context and hence needs specific VM code. Receiver inst var have a separate encoding, temp vectors and literal variable can't be contexts" - self genUnsignedSingleExtendB: ignoreStoreCheck asBit + (maybeContext asBit << 1)! Item was added: + ----- Method: EncoderForSistaV1>>genStoreFlagExtensionIgnoreStoreCheck:maybeContext:ignoreReadOnlyCheck: (in category 'extended bytecode generation') ----- + genStoreFlagExtensionIgnoreStoreCheck: ignoreStoreCheck maybeContext: maybeContext ignoreReadOnlyCheck: ignoreReadOnlyCheck + "ignoreStoreCheck: + Can be applied to the long form of store and store pop of literal variable, remote inst var, remote temp, receiver inst var. + If present, the VM does not generate the GC store check. + The main reasons the compiler can ignore the store check are one of these two: + - the mutated object is always young + - the object stored is immediate + Currently the store check is for the remembered table, but we may have it for tri color marking later. So the compiler cannot really remove the store check if the object stored is old. + + maybeContext: + Can be used only with remote instance variable stores and receiver variable stores. If marked, the object can be a context and hence needs specific VM code. Receiver inst var have a separate encoding, temp vectors and literal variable can't be contexts + + ignoreReadOnlyCheck: + no read-only check will be performed by the VM. Normally each store has a read-only check. + " + self genUnsignedSingleExtendB: ignoreStoreCheck asBit + (maybeContext asBit << 1) + (ignoreReadOnlyCheck asBit << 2)! Item was changed: ----- Method: EncoderForSistaV1>>genStoreInstVar: (in category 'bytecode generation') ----- genStoreInstVar: instVarIndex "243 11110011 iiiiiiii Store Receiver Variable #iiiiiii (+ Extend A * 256)" + self genStoreInstVarLong: instVarIndex maybeContext: false! - self genStoreInstVarLong: instVarIndex! Item was changed: ----- Method: EncoderForSistaV1>>genStoreInstVarLong: (in category 'bytecode generation') ----- genStoreInstVarLong: instVarIndex "243 11110011 iiiiiiii Store Receiver Variable #iiiiiii (+ Extend A * 256)" + ^self genStoreInstVarLong: instVarIndex maybeContext: instVarIndex < MethodContext instSize! - (instVarIndex < 0 or: [instVarIndex > 65535]) ifTrue: - [^self outOfRangeError: 'index' index: instVarIndex range: 0 to: 65535]. - instVarIndex > 255 ifTrue: - [self genUnsignedSingleExtendA: instVarIndex // 256]. - stream - nextPut: 243; - nextPut: instVarIndex \\ 256! Item was added: + ----- Method: EncoderForSistaV1>>genStoreInstVarLong:maybeContext: (in category 'bytecode generation') ----- + genStoreInstVarLong: instVarIndex maybeContext: maybeContext + "243 11110011 iiiiiiii Store Receiver Variable #iiiiiii (+ Extend A * 256)" + (instVarIndex < 0 or: [instVarIndex > 65535]) ifTrue: + [^self outOfRangeError: 'index' index: instVarIndex range: 0 to: 65535]. + maybeContext ifTrue: + [self genStoreFlagExtensionIgnoreStoreCheck: false maybeContext: maybeContext ignoreReadOnlyCheck: false]. + instVarIndex > 255 ifTrue: + [self genUnsignedSingleExtendA: instVarIndex // 256]. + stream + nextPut: 243; + nextPut: instVarIndex \\ 256!

1 0

Mac OS X full screen mode blanks primary monitor
by Eliot Miranda 31 Aug '16

31 Aug '16

Hi All, I love the new full screen button in the title bar, but when I run it on tip Mac OS X VMs on a Mac laptop with a secondary monitor attached,, when the system is expanded to full screen on one monitor the other monitor goes blank and one cannot interact with anything on that display. My arrangement is to have a 1920@1080 secondary display to the right of my 1920@1200 laptop display. _,,,^..^,,,_ best, Eliot

2 1

VM Maker: BytecodeSets.spur-eem.56.mcz
by commits＠source.squeak.org 30 Aug '16

30 Aug '16

Eliot Miranda uploaded a new version of BytecodeSets to project VM Maker: http://source.squeak.org/VMMaker/BytecodeSets.spur-eem.56.mcz ==================== Summary ==================== Name: BytecodeSets.spur-eem.56 Author: eem Time: 30 August 2016, 3:32:54.862873 pm UUID: c6cb6456-6083-4dbf-847c-f271bfa173e9 Ancestors: BytecodeSets.spur-cb.55 Bring some of the InstructionStream decoding machinery up-to-date w.r.t. the specification (EncoderForSistaV1's class comment). Implement back-end generation of some of the Sista bytecodes. Have InstructionPrinter>>callInlinePrimitive: be the keeper of the truth w.r.t. inline primitives. =============== Diff against BytecodeSets.spur-cb.55 =============== Item was added: + ----- Method: BytecodeEncoder>>sizeBranchIfNotInstanceOf:distance: (in category '*BytecodeSets-opcode sizing') ----- + sizeBranchIfNotInstanceOf: behaviorOrArrayOfBehaviorLiteralIndex distance: jumpDistance + ^self sizeOpcodeSelector: #genBranchIfNotInstanceOf:distance: + withArguments: {behaviorOrArrayOfBehaviorLiteralIndex. jumpDistance}! Item was added: + ----- Method: BytecodeEncoder>>sizeTrap (in category '*BytecodeSets-opcode sizing') ----- + sizeTrap + ^self sizeOpcodeSelector: #genTrap withArguments: #()! Item was added: + ----- Method: BytecodeEncoder>>sizeUnsignedSingleExtendB: (in category '*BytecodeSets-opcode sizing') ----- + sizeUnsignedSingleExtendB: anInteger + ^self sizeOpcodeSelector: #genUnsignedSingleExtendB: withArguments: {anInteger}! Item was added: + ----- Method: InstructionPrinter>>branchIfNotInstanceOf:distance: (in category '*BytecodeSets-SistaV1-decoding') ----- + branchIfNotInstanceOf: behaviorOrArrayOfBehavior distance: distance + "If the object on top of stack has the type -or one of the type- present in the literal + (the literal is a behavior or an array of behavior), then pop it. Else jumps by the distance." + self print: 'branchIfNotInstanceOf: ', behaviorOrArrayOfBehavior printString, ' distance: ', distance printString! Item was changed: ----- Method: InstructionPrinter>>callInlinePrimitive: (in category '*BytecodeSets-instruction decoding') ----- callInlinePrimitive: index "Print the callInlinePrimitive." + self print: 'callInlinePrimitive: ' , ((#((1000 ' class') + (1001 ' pointer numSlots') + (1002 ' pointer basicSize') + (1003 ' byte8Type format numBytes') + (1004 ' short16Type format numSho') + (1005 ' word32Type format numWord') + (1006 ' doubleWord64Type format n') + (1011 ' fixed pointer basicNew') + (2000 ' SmallInteger #+') + (2001 ' SmallInteger #-') + (2002 ' SmallInteger #*') + (2003 ' SmallInteger #/') + (2004 ' SmallInteger #//') + (2005 ' SmallInteger #\\') + (2006 ' SmallInteger #quo:') + (2016 ' SmallInteger #bitAnd:') + (2017 ' SmallInteger #bitOr:') + (2018 ' SmallInteger #bitXor:') + (2019 ' SmallInteger #bitShift:') + (2032 ' SmallInteger #>') + (2033 ' SmallInteger #<') + (2034 ' SmallInteger #>=') + (2035 ' SmallInteger #<=') + (2036 ' SmallInteger #=') + (2037 ' SmallInteger #~=') + (2064 ' Pointer Object>>at:') + (2065 ' Byte Object>>at:') + (2066 ' 16-bit Word Object>>at:') + (2067 ' Word Object>>at:') + (2068 ' DoubleWord Object>>at:') + (2069 ' QuadWord Object>>at:') + (3000 ' Pointer Object>>at:put:') + (3001 ' Byte Object>>at:put:') + (3002 ' Word Object>>at:put:') + (3003 ' DoubleWord Object>>at:put') + (3004 ' QuadWord Object>>at:put:')) + detect: [:tuple| tuple first = index] + ifNone: []) + ifNil: [index printString] + ifNotNil: [:tuple| tuple last])! - - self print: 'callInlinePrimitive: ' , index printString! Item was changed: ----- Method: InstructionStream>>interpretNext3ByteSistaV1Instruction:for:extA:extB:startPC: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNext3ByteSistaV1Instruction: bytecode for: client extA: extA extB: extB startPC: startPC "Send to the argument, client, a message that specifies the next instruction. This method handles the three-byte codes. For a table of the bytecode set, see EncoderForSistaV1's class comment." | method byte2 byte3 literal | method := self method. byte2 := method at: pc. byte3 := method at: pc + 1. pc := pc + 2. "we search the bytecodes by what we expect to be the static frequency." bytecode = 248 ifTrue: [byte3 >= 128 ifTrue: [^client callInlinePrimitive: byte2 + (byte3 - 128 bitShift: 8)]. ^client callPrimitive: byte2 + (byte3 bitShift: 8)]. + "* 249 11111001 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" + bytecode = 249 ifTrue: + [literal := method literalAt: (extA bitShift: 8) + byte2 + 1. + ^client pushFullClosure: literal numCopied: (byte3 bitAnd: 16r3F)]. - "249 11111001 xxxxxxxx syyyyyyy Reserved for Push Float" - bytecode = 249 ifTrue: [^ self unusedBytecode: client at: startPC]. bytecode = 250 ifTrue: ["** 250 11111010 eeiiikkk jjjjjjjj Push Closure Num Copied iii (+ExtA//16*8) Num Args kkk (+ ExtA\\16*8) BlockSize jjjjjjjj (+ExtB*256). ee = num extensions" ^client pushClosureCopyNumCopiedValues: ((byte2 bitShift: -3) bitAnd: 7) + (extA // 16 bitShift: 3) numArgs: (byte2 bitAnd: 7) + (extA \\ 16 bitShift: 3) blockSize: byte3 + (extB bitShift: 8)]. bytecode = 251 ifTrue: [^client pushRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 252 ifTrue: [^client storeIntoRemoteTemp: byte2 inVectorAt: byte3]. bytecode = 253 ifTrue: [^client popIntoRemoteTemp: byte2 inVectorAt: byte3]. "** 254 11111110 kkkkkkkk jjjjjjjj branch If Not Instance Of Behavior/Array Of Behavior kkkkkkkk (+ Extend A * 256, where Extend A >= 0) distance jjjjjjjj (+ Extend B * 256, where Extend B >= 0)" + bytecode = 254 ifTrue: - literal := method literalAt: (extA bitShift: 8) + byte2 + 1. - bytecode = 253 ifTrue: [^ client branchIfNotInstanceOf: literal distance: (extB bitShift: 8) + byte3 ]. + ^self unusedBytecode: client at: startPC! - "* 255 11111111 xxxxxxxx siyyyyyy push Closure Compiled block literal index xxxxxxxx (+ Extend A * 256) numCopied yyyyyy receiverOnStack: s = 1 ignoreOuterContext: i = 1" - ^client - pushFullClosure: literal - numCopied: (byte3 bitAnd: 16r3F).! Item was changed: ----- Method: InstructionStream>>interpretNextSistaV1InstructionFor: (in category '*BytecodeSets-SistaV1-decoding') ----- interpretNextSistaV1InstructionFor: client "Send to the argument, client, a message that specifies the next instruction." | byte div16 offset method extA extB savedPC | method := self method. "For a table of the bytecode set, see EncoderForSistaV1's class comment." "consume and compute any extensions first." extA := extB := 0. savedPC := pc. [byte := self method at: pc. pc := pc + 1. byte >= 16rE0 and: [byte <= 16rE1]] whileTrue: [| extByte | extByte := self method at: pc. pc := pc + 1. byte = 16rE0 ifTrue: [extA := (extA bitShift: 8) + extByte] ifFalse: [extB := (extB = 0 and: [extByte > 127]) ifTrue: [extByte - 256] ifFalse: [(extB bitShift: 8) + extByte]]]. div16 := byte // 16. offset := byte \\ 16. "We do an inline quasi-binary search on each of the possible 16 values of div16" div16 < 11 ifTrue: [div16 < 6 ifTrue: [div16 < 4 ifTrue: [div16 < 2 ifTrue: [div16 = 0 ifTrue: [^client pushReceiverVariable: offset]. ^client pushLiteralVariable: (method literalAt: offset + 1)]. "div16 = 1" ^client pushConstant: (method literalAt: byte \\ 32 + 1)]. div16 = 4 ifTrue: [offset < 12 ifTrue: [^client pushTemporaryVariable: offset]. offset = 12 ifTrue: [^client pushReceiver]. offset = 13 ifTrue: [^client pushConstant: true]. offset = 14 ifTrue: [^client pushConstant: false]. offset = 15 ifTrue: [^client pushConstant: nil]]. "div16 = 5" offset < 2 ifTrue: [^client pushConstant: offset]. offset = 2 ifTrue: [^self interpretSistaV1ExtendedPush: extB for: client]. offset = 3 ifTrue: [^client doDup]. offset = 8 ifTrue: [^client methodReturnReceiver]. offset = 9 ifTrue: [^client methodReturnConstant: true]. offset = 10 ifTrue: [^client methodReturnConstant: false]. offset = 11 ifTrue: [^client methodReturnConstant: nil]. offset = 12 ifTrue: [^client methodReturnTop]. offset = 13 ifTrue: [^client blockReturnConstant: nil]. offset = 14 ifTrue: [^client blockReturnTop]. offset = 15 ifTrue: [^client doNop]. ^self unusedBytecode: client at: savedPC]. "short sends" div16 = 6 ifTrue: [^client send: (Smalltalk specialSelectorAt: offset + 1) super: false numArgs: (Smalltalk specialNargsAt: offset + 1)]. div16 = 7 ifTrue: [^client send: (Smalltalk specialSelectorAt: offset + 17) super: false numArgs: (Smalltalk specialNargsAt: offset + 17)]. ^client send: (method literalAt: offset + 1) super: false numArgs: div16 - 8]. "div16 >= 11; bytecode >= 176" div16 < 14 ifTrue: [div16 = 11 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1]. ^client jump: offset - 7 if: true]. div16 = 12 ifTrue: [offset < 8 ifTrue: [^client jump: offset + 1 if: false]. ^client popIntoReceiverVariable: offset - 8]. "div16 = 13" offset < 8 ifTrue: [^client popIntoTemporaryVariable: offset]. offset = 8 ifTrue: [ ^ client doPop ]. + offset = 9 ifTrue: [ ^ client trap ]. - offset = 8 ifTrue: [ ^ client trap ]. ^self unusedBytecode: client at: savedPC]. "2 byte and 3 byte codes" byte < 248 ifTrue: [^self interpretNext2ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC]. ^self interpretNext3ByteSistaV1Instruction: byte for: client extA: extA extB: extB startPC: savedPC! Item was added: + ----- Method: StackDepthFinder>>branchIfNotInstanceOf:distance: (in category '*BytecodeSets-SistaV1-decoding') ----- + branchIfNotInstanceOf: behaviorOrArrayOfBehavior distance: anInteger + self drop!

1 0

VM Maker: VMMaker.oscog-cb.1924.mcz
by commits＠source.squeak.org 30 Aug '16

30 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1924.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1924 Author: cb Time: 30 August 2016, 2:08:20.49763 pm UUID: da9f563b-03b1-4925-9834-11f3d0dcb5cc Ancestors: VMMaker.oscog-eem.1923 quick fix on the push nil functions for the sista bytecode set. =============== Diff against VMMaker.oscog-eem.1923 =============== Item was changed: ----- Method: StackToRegisterMappingCogit>>sistaV1:Num:Push:Nils: (in category 'span functions') ----- sistaV1: descriptor Num: pc Push: nExts Nils: aMethodObj - "230 11100110 iiiiiiii PushNClosureTemps iiiiiiii" <var: #descriptor type: #'BytecodeDescriptor *'> <inline: true> + ^descriptor generator == #genPushConstantNilBytecode + ifTrue: [1] - ^descriptor generator == #genPushClosureTempsBytecode - ifTrue: [objectMemory fetchByte: pc + 1 ofObject: aMethodObj] ifFalse: [0]!

1 0

VM Maker: VMMaker.oscog-eem.1923.mcz
by commits＠source.squeak.org 30 Aug '16

30 Aug '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1923.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.1923 Author: eem Time: 30 August 2016, 12:55:39.968766 pm UUID: 7f3c5884-2c3f-440a-a84d-d83aaf74bf0c Ancestors: VMMaker.oscog-cb.1922 Revert accidental commit. =============== Diff against VMMaker.oscog-cb.1922 =============== Item was changed: ----- Method: VMMaker class>>generateSqueakCogVMWithInterpreterClass:options: (in category 'confs-support') ----- generateSqueakCogVMWithInterpreterClass: interpreterClass options: optionsArray ^VMMaker generate: interpreterClass + and: StackToRegisterMappingCogit - and: SimpleStackBasedCogit with: optionsArray to: (FileDirectory default pathFromURI: self sourceTree, '/src') platformDir: (FileDirectory default pathFromURI: self sourceTree, '/platforms') including:#()!

1 0

VM Maker: VMMaker.oscog-cb.1922.mcz
by commits＠source.squeak.org 30 Aug '16

30 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1922.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1922 Author: cb Time: 30 August 2016, 1:48:41.283379 pm UUID: 7c2ac8b2-b5ad-49ec-a845-9044ff84b144 Ancestors: VMMaker.oscog-cb.1921 Added support from error code while scanning block bodies. =============== Diff against VMMaker.oscog-cb.1921 =============== Item was changed: ----- Method: Cogit>>scanBlock: (in category 'compile abstract instructions') ----- scanBlock: blockStart "Scan the block to determine if the block needs a frame or not" | descriptor pc end framelessStackDelta nExts | <var: #blockStart type: #'BlockStart *'> <var: #descriptor type: #'BytecodeDescriptor *'> needsFrame := false. methodOrBlockNumArgs := blockStart numArgs. inBlock := true. pc := blockStart startpc. end := blockStart startpc + blockStart span. framelessStackDelta := nExts := extA := extB := 0. [pc < end] whileTrue: [byte0 := (objectMemory fetchByte: pc ofObject: methodObj) + bytecodeSetOffset. descriptor := self generatorAt: byte0. descriptor isExtension ifTrue: [self loadSubsequentBytesForDescriptor: descriptor at: pc. self perform: descriptor generator]. needsFrame ifFalse: [(descriptor needsFrameFunction isNil or: [self perform: descriptor needsFrameFunction with: framelessStackDelta]) ifTrue: [needsFrame := true] ifFalse: [framelessStackDelta := framelessStackDelta + descriptor stackDelta]]. objectRepresentation maybeNoteDescriptor: descriptor blockStart: blockStart. pc := self nextBytecodePCFor: descriptor at: pc exts: nExts in: methodObj. descriptor isExtension ifTrue: [nExts := nExts + 1] ifFalse: [nExts := extA := extB := 0]]. needsFrame ifFalse: [framelessStackDelta < 0 ifTrue: [self error: 'negative stack delta in block; block contains bogus code or internal error']. [framelessStackDelta > 0] whileTrue: [descriptor := self generatorAt: (objectMemory fetchByte: blockStart startpc ofObject: methodObj) + bytecodeSetOffset. descriptor generator ~~ #genPushConstantNilBytecode ifTrue: [self error: 'frameless block doesn''t start with enough pushNils']. blockStart startpc: blockStart startpc + descriptor numBytes; span: blockStart span - descriptor numBytes. + framelessStackDelta := framelessStackDelta - 1]]. + ^0! - framelessStackDelta := framelessStackDelta - 1]]! Item was changed: ----- Method: SistaCogit>>compileBlockBodies (in category 'compile abstract instructions') ----- compileBlockBodies "override to maintain counterIndex when recompiling blocks; sigh." <inline: false> | result compiledBlocksCount blockStart savedNeedsFrame savedNumArgs savedNumTemps initialStackPtr initialOpcodeIndex initialCounterIndex initialIndexOfIRC | <var: #blockStart type: #'BlockStart *'> self assert: blockCount > 0. "scanBlock: in compileBlockEntry: sets both of these appropriately for each block." savedNeedsFrame := needsFrame. savedNumArgs := methodOrBlockNumArgs. savedNumTemps := methodOrBlockNumTemps. inBlock := true. compiledBlocksCount := 0. [compiledBlocksCount < blockCount] whileTrue: [blockStart := self blockStartAt: compiledBlocksCount. + (result := self scanBlock: blockStart) < 0 ifTrue: [^result]. - self scanBlock: blockStart. initialOpcodeIndex := opcodeIndex. initialCounterIndex := counterIndex. NewspeakVM ifTrue: [initialIndexOfIRC := indexOfIRC]. [self compileBlockEntry: blockStart. initialStackPtr := simStackPtr. (result := self compileAbstractInstructionsFrom: blockStart startpc + (self pushNilSize: methodObj numInitialNils: blockStart numInitialNils) through: blockStart startpc + blockStart span - 1) < 0 ifTrue: [^result]. "If the final simStackPtr is less than the initial simStackPtr then scanBlock: over- estimated the number of initial nils (because it assumed one or more pushNils to produce an operand were pushNils to initialize temps. This is very rare, so compensate by checking, adjusting numInitialNils and recompiling the block body. N.B. No need to reinitialize the literalsManager because it answers existing literals." initialStackPtr = simStackPtr] whileFalse: [self assert: initialStackPtr > simStackPtr. blockStart numInitialNils: blockStart numInitialNils + simStackPtr - initialStackPtr. blockStart fakeHeader dependent: nil. self reinitializeFixupsFrom: blockStart startpc + blockStart numInitialNils through: blockStart startpc + blockStart span - 1. self cCode: 'bzero(abstractOpcodes + initialOpcodeIndex, (opcodeIndex - initialOpcodeIndex) * sizeof(AbstractInstruction))' inSmalltalk: [initialOpcodeIndex to: opcodeIndex - 1 do: [:i| abstractOpcodes at: i put: (CogCompilerClass for: self)]]. opcodeIndex := initialOpcodeIndex. counterIndex := initialCounterIndex. NewspeakVM ifTrue: [indexOfIRC := initialIndexOfIRC]]. compiledBlocksCount := compiledBlocksCount + 1]. needsFrame := savedNeedsFrame. methodOrBlockNumArgs := savedNumArgs. methodOrBlockNumTemps := savedNumTemps. ^0! Item was changed: ----- Method: StackToRegisterMappingCogit>>compileBlockBodies (in category 'compile abstract instructions') ----- compileBlockBodies <inline: false> | result compiledBlocksCount blockStart savedNeedsFrame savedNumArgs savedNumTemps initialStackPtr initialOpcodeIndex initialIndexOfIRC | <var: #blockStart type: #'BlockStart *'> self assert: blockCount > 0. "scanBlock: in compileBlockEntry: sets both of these appropriately for each block." savedNeedsFrame := needsFrame. savedNumArgs := methodOrBlockNumArgs. savedNumTemps := methodOrBlockNumTemps. inBlock := true. compiledBlocksCount := 0. [compiledBlocksCount < blockCount] whileTrue: [blockStart := self blockStartAt: compiledBlocksCount. + (result := self scanBlock: blockStart) < 0 ifTrue: [^result]. - self scanBlock: blockStart. initialOpcodeIndex := opcodeIndex. literalsManager saveForBlockCompile. NewspeakVM ifTrue: [initialIndexOfIRC := indexOfIRC]. [self compileBlockEntry: blockStart. initialStackPtr := simStackPtr. (result := self compileAbstractInstructionsFrom: blockStart startpc + (self pushNilSize: methodObj numInitialNils: blockStart numInitialNils) through: blockStart startpc + blockStart span - 1) < 0 ifTrue: [^result]. "If the final simStackPtr is less than the initial simStackPtr then scanBlock: over- estimated the number of initial nils (because it assumed one or more pushNils to produce an operand were pushNils to initialize temps. This is very rare, so compensate by checking, adjusting numInitialNils and recompiling the block body. N.B. No need to reinitialize the literalsManager because it answers existing literals." initialStackPtr = simStackPtr] whileFalse: [self assert: initialStackPtr > simStackPtr. blockStart numInitialNils: blockStart numInitialNils + simStackPtr - initialStackPtr. blockStart fakeHeader dependent: nil. self reinitializeFixupsFrom: blockStart startpc + blockStart numInitialNils through: blockStart startpc + blockStart span - 1. self cCode: 'bzero(abstractOpcodes + initialOpcodeIndex, (opcodeIndex - initialOpcodeIndex) * sizeof(AbstractInstruction))' inSmalltalk: [initialOpcodeIndex to: opcodeIndex - 1 do: [:i| abstractOpcodes at: i put: (CogCompilerClass for: self)]]. opcodeIndex := initialOpcodeIndex. literalsManager resetForBlockCompile. NewspeakVM ifTrue: [indexOfIRC := initialIndexOfIRC]]. compiledBlocksCount := compiledBlocksCount + 1]. needsFrame := savedNeedsFrame. methodOrBlockNumArgs := savedNumArgs. methodOrBlockNumTemps := savedNumTemps. ^0! Item was changed: ----- Method: StackToRegisterMappingCogit>>scanBlock: (in category 'compile abstract instructions') ----- scanBlock: blockStart "Scan the block to determine if the block needs a frame or not" | descriptor pc end framelessStackDelta nExts pushingNils numPushNils | <var: #blockStart type: #'BlockStart *'> <var: #descriptor type: #'BytecodeDescriptor *'> needsFrame := false. prevBCDescriptor := nil. methodOrBlockNumArgs := blockStart numArgs. inBlock := true. pc := blockStart startpc. end := blockStart startpc + blockStart span. framelessStackDelta := nExts := extA := extB := 0. pushingNils := true. [pc < end] whileTrue: [byte0 := (objectMemory fetchByte: pc ofObject: methodObj) + bytecodeSetOffset. descriptor := self generatorAt: byte0. descriptor isExtension ifTrue: [self loadSubsequentBytesForDescriptor: descriptor at: pc. self perform: descriptor generator]. needsFrame ifFalse: [(descriptor needsFrameFunction isNil or: [self perform: descriptor needsFrameFunction with: framelessStackDelta]) ifTrue: [needsFrame := true] ifFalse: [framelessStackDelta := framelessStackDelta + descriptor stackDelta]]. objectRepresentation maybeNoteDescriptor: descriptor blockStart: blockStart. (pushingNils and: [descriptor isExtension not]) ifTrue: ["Count the initial number of pushed nils acting as temp initializers. We can't tell whether an initial pushNil is an operand reference or a temp initializer, except when the pushNil is a jump target (has a fixup), which never happens: self systemNavigation browseAllSelect: [:m| | ebc | (ebc := m embeddedBlockClosures select: [:ea| ea decompile statements first isMessage] thenCollect: [:ea| ea decompile statements first selector]) notEmpty and: [(#(whileTrue whileFalse whileTrue: whileFalse:) intersection: ebc) notEmpty]] or if the bytecode set has a push multiple nils bytecode. We simply count initial nils. Rarely we may end up over-estimating. We will correct by checking the stack depth at the end of the block in compileBlockBodies." (numPushNils := self numPushNils: descriptor pc: pc nExts: nExts method: methodObj) > 0 ifTrue: [self assert: (descriptor numBytes = 1 or: [descriptor generator == #genPushClosureTempsBytecode]). blockStart numInitialNils: blockStart numInitialNils + numPushNils] ifFalse: [pushingNils := false]]. pc := self nextBytecodePCFor: descriptor at: pc exts: nExts in: methodObj. descriptor isExtension ifTrue: [nExts := nExts + 1] ifFalse: [nExts := extA := extB := 0]. prevBCDescriptor := descriptor]. "It would be nice of this wasn't necessary but alas we need to do the eager scan for frameless methods so that we don't end up popping too much off the simulated stack, e.g. for pushNil; returnTopFromBlock methods." needsFrame ifFalse: [self assert: (framelessStackDelta >= 0 and: [blockStart numInitialNils >= framelessStackDelta]). + blockStart numInitialNils: blockStart numInitialNils - framelessStackDelta]. + ^0! - blockStart numInitialNils: blockStart numInitialNils - framelessStackDelta]! Item was changed: ----- Method: StackToRegisterMappingCogit>>sistaV1PushNilSize:numInitialNils: (in category 'span functions') ----- sistaV1PushNilSize: aMethodObj numInitialNils: numInitialNils "230 11100110 iiiiiiii PushNClosureTemps iiiiiiii" <inline: true> + ^numInitialNils! - ^numInitialNils = 0 ifTrue: [0] ifFalse: [2]! Item was changed: ----- Method: StackToRegisterMappingCogitChecker>>scanBlock: (in category 'compile abstract instructions') ----- scanBlock: blockStart + | result | + (result := super scanBlock: blockStart) < 0 ifTrue: [^result]. - super scanBlock: blockStart. needsFrame ifTrue: [| tempCount | tempCount := coInterpreter tempCountForBlockStartingAt: blockStart startpc + 1 in: methodObj. blockStart numInitialNils ~= tempCount ifTrue: + [blockStart numInitialNils: tempCount]]. + ^0! - [blockStart numInitialNils: tempCount]]!

1 0

VM Maker: VMMaker.oscog-cb.1921.mcz
by commits＠source.squeak.org 30 Aug '16

30 Aug '16

ClementBera uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-cb.1921.mcz ==================== Summary ==================== Name: VMMaker.oscog-cb.1921 Author: cb Time: 30 August 2016, 11:05:36.920661 am UUID: 2ecc27e4-cf4e-455e-941a-6993d9470dfe Ancestors: VMMaker.oscog-cb.1920 Improving assert used during debugging bytecode sets. =============== Diff against VMMaker.oscog-cb.1920 =============== Item was added: + ----- Method: Cogit class>>maxNegativeErrorCode (in category 'accessing') ----- + maxNegativeErrorCode + ^MaxNegativeErrorCode! Item was changed: ----- Method: Integer>>asUnsignedInteger (in category '*VMMaker-interpreter simulator') ----- asUnsignedInteger "Since the simulator deals with positive integers most of the time we assert that the receiver is greater than zero. But one major exception is stack pointers in the StackInterpreterSimulator, which are negative. So don't fail if the sender is a StackInterpreter and the receiver could be a stack pointer." self >= 0 ifFalse: + [self assert: (((thisContext sender methodClass includesBehavior: CoInterpreter) + and: [self between: Cogit maxNegativeErrorCode and: -1]) + or: [(thisContext sender methodClass includesBehavior: StackInterpreter) + and: [thisContext sender receiver stackPages couldBeFramePointer: self]])]. - [self assert: ((thisContext sender methodClass includesBehavior: StackInterpreter) - and: [thisContext sender receiver stackPages couldBeFramePointer: self])]. ^self! Item was changed: ----- Method: SimpleStackBasedCogit>>genCallPrimitiveBytecode (in category 'bytecode generators') ----- genCallPrimitiveBytecode "V3PlusClosures: 139 10001011 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256) NewsqueakV4: 249 11111001 iiiiiiii jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256) SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + ( jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution." + (bytecodePC = initialPC and: [byte2 < 128]) ifFalse: [^EncounteredUnknownBytecode]. - bytecodePC ~= initialPC ifTrue: - [^EncounteredUnknownBytecode]. - byte2 < 128 ifFalse: [^EncounteredUnknownBytecode]. - self assert: (primitiveIndex = (byte1 + (byte2 << 8)) - or: [primitiveIndex = 0 "disabled primitives, e.g. stream prims" - and: [(coInterpreter primitiveIndexOf: methodObj) = (byte1 + (byte2 << 8))]]). ^0!

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2016