Vm-dev December 2016

vm-dev@lists.squeakfoundation.org

34 participants
102 discussions

New case to crash Spur VM
by Denis Kudriashov 09 Dec '16

09 Dec '16

Hi In debugger (Squeak or Pharo) try "step over" for expression "Object basicSize": image will crash. We have opened issue for this in Pharo tracker 17962 <https://pharo.fogbugz.com/f/cases/17962/Image-is-crashed-when-step-over-Obj…>

5 12

OpenSmalltalk VM on Gentoo Linux
by ï»¿Samuel Hodgkins 09 Dec '16

09 Dec '16

So, I've recently moved to Gentoo Linux and want to run the Squeak VM. Unfortunately, there's no ebuild or package for the OpenSmalltalk VM (There is one for 'classic' VM though). As such, does anyone have a list of the dependencies so that I can install them? (or if someone has written a ebuild/package for VM.) (maybe after I get it working I'll learn how to write an ebuild and do that.)

3 3

[OpenSmalltalk/opensmalltalk-vm] 5a9494: CogVM source as per VMMaker.oscog-eem.2033
by GitHub 09 Dec '16

09 Dec '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 5a949459043392bbc093d78574c2d7c07b10fcb2 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/5a949459043392bbc0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2033 Work around Slang snafu with last commit. Slang can't handle the complications involved with cmHomeMethod with the SistaV1 bytecode set (full blocks).

1 0

VM Maker: VMMaker.oscog-eem.2033.mcz
by commits＠source.squeak.org 09 Dec '16

09 Dec '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2033.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2033 Author: eem Time: 8 December 2016, 3:18:30.130792 pm UUID: dacd8710-6751-4d27-ba92-6653560eb15a Ancestors: VMMaker.oscog-eem.2032 Work around Slang snafu with last commit. Slang can't handle the complications involved with cmHomeMethod with the SistaV1 bytecode set (full blocks). =============== Diff against VMMaker.oscog-eem.2032 =============== Item was changed: ----- Method: CoInterpreter>>ceSendMustBeBooleanTo:interpretingAtDelta: (in category 'trampolines') ----- ceSendMustBeBooleanTo: aNonBooleanObject interpretingAtDelta: jumpSize "For RegisterAllocatingCogit we want the address following a conditional branch not to be reachable, so we don't have to generate code to reload registers. Instead simply convert to an interpreter frame, backup the pc to the branch, reenter the interpreter and hence retry the mustBeBoolean send therein." <api> | cogMethod methodObj methodHeader startBcpc | <var: 'cogMethod' type: #'CogBlockMethod *'> self assert: (objectMemory addressCouldBeOop: aNonBooleanObject). cogMethod := self mframeCogMethod: framePointer. ((self mframeIsBlockActivation: framePointer) and: [cogMethod cmIsFullBlock not]) ifTrue: + [methodHeader := (self cCoerceSimple: cogMethod cmHomeMethod to: #'CogMethod *') methodHeader. + methodObj := (self cCoerceSimple: cogMethod cmHomeMethod to: #'CogMethod *') methodObject. - [methodHeader := cogMethod cmHomeMethod methodHeader. - methodObj := cogMethod cmHomeMethod methodObject. startBcpc := cogMethod startpc] ifFalse: [methodHeader := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodHeader. methodObj := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodObject. startBcpc := self startPCOfMethod: methodObj]. "Map the machine code instructionPointer to the interpreter instructionPointer of the branch." instructionPointer := self popStack. instructionPointer := cogit bytecodePCFor: instructionPointer startBcpc: startBcpc in: cogMethod. instructionPointer := methodObj + objectMemory baseHeaderSize + instructionPointer - jumpSize - 1. "pre-decrement" "Make space for the two extra fields in an interpreter frame" stackPointer to: framePointer + FoxMFReceiver by: objectMemory wordSize do: [:p| | oop | oop := objectMemory longAt: p. objectMemory longAt: p - objectMemory wordSize - objectMemory wordSize put: (objectMemory longAt: p)]. stackPointer := stackPointer - objectMemory wordSize - objectMemory wordSize. self push: aNonBooleanObject. "Fill in the fields" objectMemory longAt: framePointer + FoxIFrameFlags put: (self encodeFrameFieldHasContext: (self mframeHasContext: framePointer) isBlock: (self mframeIsBlockActivation: framePointer) numArgs: cogMethod cmNumArgs); longAt: framePointer + FoxIFSavedIP put: 0; longAt: framePointer + FoxMethod put: methodObj. "and now reenter the interpreter..." self setMethod: methodObj methodHeader: methodHeader. self siglong: reenterInterpreter jmp: ReturnToInterpreter.!

1 0

[OpenSmalltalk/opensmalltalk-vm] a7f147: CogVm source as per VMMaker.oscog-eem.2032
by GitHub 08 Dec '16

08 Dec '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: a7f147ff4ce5f2c368919c256c10a608eff00da0 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a7f147ff4ce5f2c368… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-12-08 (Thu, 08 Dec 2016) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVm source as per VMMaker.oscog-eem.2032 Co/StackInterpreter: Fix slip in makeBaseFrame:; the code to skip the primitive when activating a method with a primitive used the wrong way to determine the initial PC of a method. Use the new startPCOfMethodHeader: (consistent with startPCOfMethod:). Rename initialPCForHeader:method: to initialIPForHeader:method: to avoid confusion; IP is used for instructionPointers, i.e. addresses of bytecodes, not indexes of bytecodes.

1 0

VM Maker: VMMaker.oscog-eem.2032.mcz
by commits＠source.squeak.org 08 Dec '16

08 Dec '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2032.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2032 Author: eem Time: 8 December 2016, 2:34:11.901673 pm UUID: 11ee2d57-bc90-4060-9d13-cba0722ad042 Ancestors: VMMaker.oscog-eem.2031 Co/StackInterpreter: Fix slip in makeBaseFrame:; the code to skip the primitive when activating a method with a primitive used the wrong way to determine the initial PC of a method. Use the new startPCOfMethodHeader: (consistent with startPCOfMethod:). Rename initialPCForHeader:method: to initialIPForHeader:method: top avoid confusion; IP is used for instructionPointers, i.e. addresses of bytecodes, not indexes of bytecodes. Simulator: Use logSend: consistently and have it also print the selector when printBytecodeAtEachStep is in effect. RegisterAllocatingCogit: Fix slips in initSimStackForFramelessMethod:. Make CogRegisterAllocatingSimStackEntry printing more robust. =============== Diff against VMMaker.oscog-eem.2031 =============== Item was changed: ----- Method: CoInterpreter>>activateCoggedNewMethod: (in category 'message sending') ----- activateCoggedNewMethod: inInterpreter "Activate newMethod when newMethod has been cogged, i.e. create a machine-code frame and (re)enter machine-code." | methodHeader cogMethod rcvr numTemps errorCode switched | <var: #cogMethod type: #'CogMethod *'> methodHeader := self rawHeaderOf: newMethod. self assert: (self isCogMethodReference: methodHeader). cogMethod := self cCoerceSimple: methodHeader to: #'CogMethod *'. methodHeader := cogMethod methodHeader. rcvr := self stackValue: cogMethod cmNumArgs. "could new rcvr be set at point of send?" self push: instructionPointer. cogMethod stackCheckOffset = 0 ifTrue: ["frameless method; nothing to activate..." cogit numRegArgs > 0 ifTrue: "dont use and: so as to get Slang to inline cogit numRegArgs > 0" [cogMethod cmNumArgs <= cogit numRegArgs ifTrue: [self callRegisterArgCogMethod: cogMethod at: cogit noCheckEntryOffset receiver: rcvr]]. self push: cogMethod asInteger + cogit noCheckEntryOffset. self push: rcvr. cogit ceCallCogCodePopReceiverReg. self error: 'should not be reached']. self push: framePointer. framePointer := stackPointer. self push: cogMethod asInteger. self push: objectMemory nilObject. "FxThisContext field" self push: rcvr. "clear remaining temps to nil" numTemps := self temporaryCountOfMethodHeader: methodHeader. cogMethod cmNumArgs + 1 to: numTemps do: [:i | self push: objectMemory nilObject]. (self methodHeaderHasPrimitive: methodHeader) ifTrue: [| initialPC | "Store the error code if the method starts with a long store temp. No instructionPointer skip because we're heading for machine code." + initialPC := (self initialIPForHeader: methodHeader method: newMethod) + (self sizeOfCallPrimitiveBytecode: methodHeader). - initialPC := (self initialPCForHeader: methodHeader method: newMethod) + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: [(objectMemory byteAt: initialPC) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." stackPointer >= stackLimit ifTrue: [self assert: cogMethod stackCheckOffset > cogit noCheckEntryOffset. self push: cogMethod asInteger + cogMethod stackCheckOffset. self push: rcvr. cogit ceEnterCogCodePopReceiverReg. self error: 'should not be reached']. instructionPointer := cogMethod asInteger + cogMethod stackCheckOffset. switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self returnToExecutive: inInterpreter postContextSwitch: switched! Item was changed: ----- Method: CoInterpreter>>activateNewFullClosureMethod:numArgs:mayContextSwitch: (in category 'control primitives') ----- activateNewFullClosureMethod: blockClosure numArgs: numArgs mayContextSwitch: mayContextSwitch "Similar to activateNewMethod but for Closure and newMethod." | numCopied theMethod methodHeader numTemps inInterpreter switched | <inline: true> numCopied := self copiedValueCountOfFullClosure: blockClosure. theMethod := objectMemory fetchPointer: FullClosureCompiledBlockIndex ofObject: blockClosure. self assert: (objectMemory isOopCompiledMethod: theMethod). methodHeader := self rawHeaderOf: theMethod. (self isCogMethodReference: methodHeader) ifTrue: [^self executeFullCogBlock: (self cogMethodOf: theMethod) closure: blockClosure mayContextSwitch: mayContextSwitch]. "How do we know when to compile a block method? One simple criterion is to check if the block is running within its inner context, i.e. if the outerContext is married. Even simpler is to remember the previous block entered via the interpreter and compile if this is the same one. But we can thrash trying to compile an uncoggable method unless we try and remember which ones can't be cogged. So also record the last block method we failed to compile and avoid recompiling it." (self methodWithHeaderShouldBeCogged: methodHeader) ifTrue: [(instructionPointer < objectMemory startOfMemory "If from machine code (via value primitive) attempt jitting" or: [theMethod = lastCoggableInterpretedBlockMethod]) "If from interpreter and repeat block, attempt jitting" ifTrue: [theMethod ~= lastUncoggableInterpretedBlockMethod ifTrue: [cogit cogFullBlockMethod: theMethod numCopied: numCopied. (self methodHasCogMethod: theMethod) ifTrue: [^self executeFullCogBlock: (self cogMethodOf: theMethod) closure: blockClosure mayContextSwitch: mayContextSwitch]. cogCompiledCodeCompactionCalledFor ifFalse: [lastUncoggableInterpretedBlockMethod := theMethod]]] ifFalse: [lastCoggableInterpretedBlockMethod := theMethod]] ifFalse: [self maybeFlagMethodAsInterpreted: theMethod]. self assert: (self methodHasCogMethod: theMethod) not. "Because this is an uncogged method we need to continue via the interpreter. We could have been reached either from the interpreter, in which case we should simply return, or from a machine code frame or from a compiled primitive. In these latter two cases we must longjmp back to the interpreter. The instructionPointer tells us which path we took. If the sender was an interpreter frame but called through a (failing) primitive then make sure we restore the saved instruction pointer and avoid pushing ceReturnToInterpreterPC which is only valid between an interpreter caller frame and a machine code callee frame." (inInterpreter := instructionPointer >= objectMemory startOfMemory) ifFalse: [instructionPointer = cogit ceReturnToInterpreterPC ifTrue: [instructionPointer := self iframeSavedIP: framePointer]]. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: theMethod. self push: objectMemory nilObject. "FxThisContext field" self push: (self encodeFrameFieldHasContext: false isBlock: true numArgs: numArgs). self push: 0. "FoxIFSavedIP" "Because inst var access is not checked, we must follow the receiver in Spur to ensure it is valid." self push: (objectMemory followField: FullClosureReceiverIndex ofObject: blockClosure). "Copy the copied values..." 0 to: numCopied - 1 do: [:i| self push: (objectMemory fetchPointer: i + FullClosureFirstCopiedValueIndex ofObject: blockClosure)]. self assert: (self frameIsBlockActivation: framePointer). self assert: (self frameHasContext: framePointer) not. methodHeader := objectMemory methodHeaderOf: theMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs + numCopied + 1 to: numTemps do: [ :i | self push: objectMemory nilObject]. + instructionPointer := (self initialIPForHeader: methodHeader method: theMethod) - 1. - instructionPointer := (self initialPCForHeader: methodHeader method: theMethod) - 1. self setMethod: theMethod. "Now check for stack overflow or an event (interrupt, must scavenge, etc)" switched := false. stackPointer < stackLimit ifTrue: [switched := self handleStackOverflowOrEventAllowContextSwitch: mayContextSwitch]. self returnToExecutive: inInterpreter postContextSwitch: switched! Item was changed: ----- Method: CoInterpreter>>activateNewMethod (in category 'message sending') ----- activateNewMethod | methodHeader numArgs numTemps rcvr errorCode inInterpreter switched | methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. "Because this is an uncogged method we need to continue via the interpreter. We could have been reached either from the interpreter, in which case we should simply return, or from a machine code frame or from a compiled primitive. In these latter two cases we must longjmp back to the interpreter. The instructionPointer tells us which path we took. If the sender was an interpreter frame but called through a (failing) primitive then make sure we restore the saved instruction pointer and avoid pushing ceReturnToInterpreterPC which is only valid between an interpreter caller frame and a machine code callee frame." (inInterpreter := instructionPointer >= objectMemory startOfMemory) ifFalse: [instructionPointer = cogit ceReturnToInterpreterPC ifTrue: [instructionPointer := self iframeSavedIP: framePointer]]. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: objectMemory nilObject. "FxThisContext field" self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: 0. "FoxIFSavedIP" self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. + instructionPointer := (self initialIPForHeader: methodHeader method: newMethod) - 1. - instructionPointer := (self initialPCForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." instructionPointer := instructionPointer + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: [(objectMemory byteAt: instructionPointer + 1) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." switched := true. stackPointer < stackLimit ifTrue: [switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader)]. self returnToExecutive: inInterpreter postContextSwitch: switched! Item was changed: ----- Method: CoInterpreter>>internalActivateNewMethod (in category 'message sending') ----- internalActivateNewMethod | methodHeader numTemps rcvr errorCode switched | <inline: true> methodHeader := self rawHeaderOf: newMethod. self assert: (self isCogMethodReference: methodHeader) not. numTemps := self temporaryCountOfMethodHeader: methodHeader. self assert: argumentCount = (self argumentCountOfMethodHeader: methodHeader). rcvr := self internalStackValue: argumentCount. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self internalPush: localIP. self internalPush: localFP. localFP := localSP. self internalPush: newMethod. self setMethod: newMethod methodHeader: methodHeader. self internalPush: objectMemory nilObject. "FxThisContext field" self internalPush: (self encodeFrameFieldHasContext: false isBlock: false numArgs: (self argumentCountOfMethodHeader: methodHeader)). self internalPush: 0. "FoxIFSavedIP" self internalPush: rcvr. "Initialize temps..." argumentCount + 1 to: numTemps do: [:i | self internalPush: objectMemory nilObject]. "-1 to account for pre-increment in fetchNextBytecode" + localIP := self pointerForOop: (self initialIPForHeader: methodHeader method: newMethod) - 1. - localIP := self pointerForOop: (self initialPCForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." localIP := localIP + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: [(objectMemory byteAt: localIP + 1) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self internalStackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. self assert: (self frameNumArgs: localFP) == argumentCount. self assert: (self frameIsBlockActivation: localFP) not. self assert: (self frameHasContext: localFP) not. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." localSP < stackLimit ifTrue: [self externalizeIPandSP. switched := self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self returnToExecutive: true postContextSwitch: switched. self internalizeIPandSP]! Item was changed: ----- Method: CoInterpreter>>justActivateNewMethod (in category 'message sending') ----- justActivateNewMethod | methodHeader activateCogMethod cogMethod numArgs numTemps rcvr errorCode initialIP | <var: #cogMethod type: #'CogMethod *'> <var: #initialIP type: #usqInt> <inline: true> methodHeader := self rawHeaderOf: newMethod. (activateCogMethod := self isCogMethodReference: methodHeader) ifTrue: [cogMethod := self cCoerceSimple: methodHeader to: #'CogMethod *'. methodHeader := cogMethod methodHeader]. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. (activateCogMethod and: [instructionPointer asUnsignedInteger >= objectMemory startOfMemory]) ifTrue: [self iframeSavedIP: framePointer put: instructionPointer. instructionPointer := cogit ceReturnToInterpreterPC]. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. + initialIP := self initialIPForHeader: methodHeader method: newMethod. - initialIP := self initialPCForHeader: methodHeader method: newMethod. activateCogMethod ifTrue: [self push: cogMethod asUnsignedInteger. self push: objectMemory nilObject. "FoxThisContext field" instructionPointer := cogMethod asUnsignedInteger + cogMethod stackCheckOffset] ifFalse: [self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: objectMemory nilObject. "FoxThisContext field" self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: 0. "FoxIFSavedIP" instructionPointer := initialIP - 1]. self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." initialIP := initialIP + (self sizeOfCallPrimitiveBytecode: methodHeader). activateCogMethod ifFalse: [instructionPointer := initialIP]. primFailCode ~= 0 ifTrue: [(objectMemory byteAt: initialIP + 1) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. ^methodHeader! Item was changed: ----- Method: CoInterpreter>>makeBaseFrameFor: (in category 'frame access') ----- makeBaseFrameFor: aContext "<Integer>" "Marry aContext with the base frame of a new stack page. Build the base frame to reflect the context's state. Answer the new page. Override to hold the caller context in a different place, In the StackInterpreter we use the caller saved ip, but in the Cog VM caller saved ip is the ceBaseReturn: trampoline. Simply hold the caller context in the first word of the stack." <returnTypeC: #'StackPage *'> | page pointer theMethod theIP numArgs stackPtrIndex maybeClosure rcvr | <inline: false> <var: #page type: #'StackPage *'> <var: #pointer type: #'char *'> <var: #cogMethod type: #'CogMethod *'> "theIP must be typed as signed because it is assigned ceCannotResumePC and so maybe implicitly typed as unsigned." <var: #theIP type: #sqInt> self assert: (objectMemory isContext: aContext). self assert: (self isSingleContext: aContext). self assert: (objectMemory goodContextSize: aContext). theIP := objectMemory fetchPointer: InstructionPointerIndex ofObject: aContext. self assert: HasBeenReturnedFromMCPC < 0. theIP := (objectMemory isIntegerObject: theIP) ifTrue: [objectMemory integerValueOf: theIP] ifFalse: [HasBeenReturnedFromMCPC]. theMethod := objectMemory followObjField: MethodIndex ofObject: aContext. page := stackPages newStackPage. "first word on stack is caller context of base frame" stackPages longAt: (pointer := page baseAddress) put: (objectMemory followObjField: SenderIndex ofObject: aContext). "second word is the context itself; needed for cannotReturn processing; see ceBaseReturn:." stackPages longAt: (pointer := pointer - objectMemory wordSize) put: aContext. rcvr := objectMemory followField: ReceiverIndex ofObject: aContext. "If the frame is a closure activation then the closure should be on the stack in the pushed receiver position (closures receive the value[:value:] messages). Otherwise it should be the receiver proper." maybeClosure := objectMemory fetchPointer: ClosureIndex ofObject: aContext. maybeClosure ~= objectMemory nilObject ifTrue: [(objectMemory isForwarded: maybeClosure) ifTrue: [maybeClosure := objectMemory fixFollowedField: ClosureIndex ofObject: aContext withInitialValue: maybeClosure]. numArgs := self argumentCountOfClosure: maybeClosure. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: maybeClosure] ifFalse: [| header | header := objectMemory methodHeaderOf: theMethod. numArgs := self argumentCountOfMethodHeader: header. "If this is a synthetic context its IP could be pointing at the CallPrimitive opcode. If so, skip it." ((self methodHeaderHasPrimitive: header) + and: [theIP = (1 + (self startPCOfMethodHeader: header))]) ifTrue: - and: [theIP = (1 + (objectMemory lastPointerOfMethodHeader: header))]) ifTrue: [theIP := theIP + (self sizeOfCallPrimitiveBytecode: header)]. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: rcvr]. "Put the arguments on the stack" 1 to: numArgs do: [:i| stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (objectMemory fetchPointer: ReceiverIndex + i ofObject: aContext)]. "saved caller ip is base return trampoline" stackPages longAt: (pointer := pointer - objectMemory wordSize) put: cogit ceBaseFrameReturnPC. "base frame's saved fp is null" stackPages longAt: (pointer := pointer - objectMemory wordSize) put: 0. "N.B. Don't set the baseFP, which marks the page as in use, until after ensureMethodIsCogged: and/or instructionPointer:forContext:frame:. These can cause a compiled code compaction which, if marked as in use, will examine this partially initialized page and crash." page headFP: pointer. "Create either a machine code frame or an interpreter frame based on the pc. If the pc is -ve it is a machine code pc and so we produce a machine code frame. If +ve an interpreter frame. N.B. Do *not* change this to try and map from a bytecode pc to a machine code frame under any circumstances. See ensureContextIsExecutionSafeAfterAssignToStackPointer:" theIP < 0 ifTrue: [| cogMethod | "Since we would have to generate a machine-code method to be able to map the native pc anyway we should create a native method and native frame." cogMethod := self ensureMethodIsCogged: theMethod. theMethod := cogMethod asInteger. maybeClosure ~= objectMemory nilObject ifTrue: [(self isVanillaBlockClosure: maybeClosure) ifTrue: ["If the pc is the special HasBeenReturnedFromMCPC pc set the pc appropriately so that the frame stays in the cannotReturn: state." theIP = HasBeenReturnedFromMCPC ifTrue: [theMethod := (cogit findMethodForStartBcpc: (self startPCOfClosure: maybeClosure) inHomeMethod: (self cCoerceSimple: theMethod to: #'CogMethod *')) asInteger. theMethod = 0 ifTrue: [self error: 'cannot find machine code block matching closure''s startpc']. theIP := cogit ceCannotResumePC] ifFalse: [self assert: (theIP signedBitShift: -16) < -1. "See contextInstructionPointer:frame:" theMethod := theMethod - ((theIP signedBitShift: -16) * cogit blockAlignment). theIP := theMethod - theIP signedIntFromShort]] ifFalse: [self assert: (theIP signedBitShift: -16) >= -1. "If the pc is the special HasBeenReturnedFromMCPC pc set the pc appropriately so that the frame stays in the cannotReturn: state." theIP := theIP = HasBeenReturnedFromMCPC ifTrue: [cogit ceCannotResumePC] ifFalse: [theMethod asInteger - theIP]]. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theMethod + MFMethodFlagHasContextFlag + MFMethodFlagIsBlockFlag] ifFalse: [self assert: (theIP signedBitShift: -16) >= -1. "If the pc is the special HasBeenReturnedFromMCPC pc set the pc appropriately so that the frame stays in the cannotReturn: state." theIP := theIP = HasBeenReturnedFromMCPC ifTrue: [cogit ceCannotResumePC] ifFalse: [theMethod asInteger - theIP]. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theMethod + MFMethodFlagHasContextFlag]. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: aContext] ifFalse: [stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theMethod. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: aContext. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (self encodeFrameFieldHasContext: true isBlock: maybeClosure ~= objectMemory nilObject numArgs: numArgs). stackPages longAt: (pointer := pointer - objectMemory wordSize) put: 0. "FoxIFSavedIP" theIP := self iframeInstructionPointerForIndex: theIP method: theMethod]. page baseFP: page headFP. self assert: (self frameHasContext: page baseFP). self assert: (self frameNumArgs: page baseFP) == numArgs. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: rcvr. stackPtrIndex := self quickFetchInteger: StackPointerIndex ofObject: aContext. self assert: ReceiverIndex + stackPtrIndex < (objectMemory lengthOf: aContext). numArgs + 1 to: stackPtrIndex do: [:i| stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (objectMemory fetchPointer: ReceiverIndex + i ofObject: aContext)]. "top of stack is the instruction pointer" stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theIP. page headSP: pointer. self assert: (self context: aContext hasValidInversePCMappingOf: theIP in: page baseFP). "Mark context as married by setting its sender to the frame pointer plus SmallInteger tags and the InstructionPointer to the saved fp (which ensures correct alignment w.r.t. the frame when we check for validity) plus SmallInteger tags." objectMemory storePointerUnchecked: SenderIndex ofObject: aContext withValue: (self withSmallIntegerTags: page baseFP). objectMemory storePointerUnchecked: InstructionPointerIndex ofObject: aContext withValue: (self withSmallIntegerTags: 0). self assert: (objectMemory isIntegerObject: (objectMemory fetchPointer: SenderIndex ofObject: aContext)). self assert: (self frameOfMarriedContext: aContext) = page baseFP. self assert: (self validStackPageBaseFrame: page). ^page! Item was changed: ----- Method: CogRegisterAllocatingSimStackEntry>>printStateOn: (in category 'printing') ----- printStateOn: aStream <doNotGenerate> "Smalltalk-side only" type isInteger ifFalse: [^self]. aStream nextPut: $(. type caseOf: { [SSBaseOffset] -> [aStream nextPutAll: 'bo '; nextPutAll: (cogit backEnd nameForRegister: register). offset negative ifFalse: [aStream nextPut: $+]. aStream print: offset]. [SSConstant] -> [aStream nextPutAll: 'const '; nextPutAll: (cogit coInterpreter shortPrint: constant)]. [SSRegister] -> [aStream nextPutAll: 'reg '; nextPutAll: (cogit backEnd nameForRegister: register)]. [SSSpill] -> [aStream nextPutAll: 'spill @ '; nextPutAll: (cogit backEnd nameForRegister: register). offset negative ifFalse: [aStream nextPut: $+]. aStream print: offset] }. (spilled and: [type ~= SSSpill]) ifTrue: [aStream nextPutAll: ' (spilled)']. liveRegister ~= NoReg ifTrue: + [aStream nextPutAll: ' (live: '; nextPutAll: (liveRegister ifNil: ['NIL!!!!'] ifNotNil: [cogit backEnd nameForRegister: liveRegister]); nextPut: $)]. - [aStream nextPutAll: ' (live: '; nextPutAll: (cogit backEnd nameForRegister: liveRegister); nextPut: $)]. bcptr ifNotNil: [aStream space; nextPut: ${; print: bcptr; nextPut: $}]. aStream nextPut: $)! Item was changed: ----- Method: CogVMSimulator>>findNewMethodInClassTag: (in category 'testing') ----- findNewMethodInClassTag: classTag " | cName | traceOn ifTrue: [cName := (self sizeBitsOf: class) = 16r20 ifTrue: ['class ' , (self nameOfClass: (self fetchPointer: 6 ofObject: class))] ifFalse: [(self nameOfClass: class)]. self cr; print: cName , '>>' , (self stringOf: messageSelector)]. " + messageSelector = (objectMemory splObj: SelectorDoesNotUnderstand) ifTrue: [self halt]. - (self stringOf: messageSelector) = 'doesNotUnderstand:' ifTrue: [self halt]. + self logSend: messageSelector. - sendCount := sendCount + 1. - - printSends ifTrue: - [self cr; print: byteCount; space; printStringOf: messageSelector; cr]. " (sendCount > 1000 and: [sendCount\\10 = 0]) ifTrue: [Transcript print: sendCount; space. self validate]. " " (sendCount > 100150) ifTrue: [self qvalidate. messageQueue == nil ifTrue: [messageQueue := OrderedCollection new]. messageQueue addLast: (self stringOf: messageSelector)]. " ^super findNewMethodInClassTag: classTag! Item was changed: ----- Method: CogVMSimulator>>logSend: (in category 'debugging traps') ----- logSend: oop sendCount := sendCount + 1. + (printSends or: [printBytecodeAtEachStep]) ifTrue: - printSends ifTrue: [transcript print: byteCount; nextPut: $/; print: sendCount; space. self printStringOf: oop. transcript cr; flush]! Item was changed: ----- Method: CogVMSimulator>>makeBaseFrameFor: (in category 'frame access') ----- makeBaseFrameFor: aContext "<Integer>" "aContext = 26431360 ifTrue: [self halt]." + "(objectMemory fetchPointer: MethodIndex ofObject: aContext) = 16rD4C178 ifTrue: + [self halt]." ^super makeBaseFrameFor: aContext! Item was changed: ----- Method: RegisterAllocatingCogit>>initSimStackForFramelessMethod: (in category 'simulation stack') ----- initSimStackForFramelessMethod: startpc super initSimStackForFramelessMethod: startpc. simSelf liveRegister: NoReg. 0 to: simStackPtr do: [:i| | desc | + desc := self simStackAt: i. + desc liveRegister: (desc type == SSRegister ifTrue: [desc register] ifFalse: [NoReg])]! - desc := self simStackAt: 1. - desc liveRegister: desc registerOrNone]! Item was changed: ----- Method: StackInterpreter>>activateNewFullClosureMethod:numArgs:mayContextSwitch: (in category 'control primitives') ----- activateNewFullClosureMethod: blockClosure numArgs: numArgs mayContextSwitch: mayContextSwitch "Similar to activateNewMethod but for Closure and newMethod." | numCopied theMethod methodHeader numTemps | <inline: true> numCopied := self copiedValueCountOfFullClosure: blockClosure. theMethod := objectMemory fetchPointer: FullClosureCompiledBlockIndex ofObject: blockClosure. self assert: (objectMemory isOopCompiledMethod: theMethod). self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: theMethod. self push: (self encodeFrameFieldHasContext: false isBlock: true numArgs: numArgs). self push: objectMemory nilObject. "FxThisContext field" "Because inst var access is not checked, we must follow the receiver in Spur to ensure it is valid." self push: (objectMemory followField: FullClosureReceiverIndex ofObject: blockClosure). "Copy the copied values..." 0 to: numCopied - 1 do: [:i| self push: (objectMemory fetchPointer: i + FullClosureFirstCopiedValueIndex ofObject: blockClosure)]. self assert: (self frameIsBlockActivation: framePointer). self assert: (self frameHasContext: framePointer) not. methodHeader := objectMemory methodHeaderOf: theMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs + numCopied + 1 to: numTemps do: [ :i | self push: objectMemory nilObject]. + instructionPointer := (self initialIPForHeader: methodHeader method: theMethod) - 1. - instructionPointer := (self initialPCForHeader: methodHeader method: theMethod) - 1. self setMethod: theMethod. "Now check for stack overflow or an event (interrupt, must scavenge, etc)" stackPointer < stackLimit ifTrue: [self handleStackOverflowOrEventAllowContextSwitch: mayContextSwitch]! Item was changed: ----- Method: StackInterpreter>>callPrimitiveBytecode (in category 'miscellaneous bytecodes') ----- callPrimitiveBytecode "V4: 249 11111001 i i i i i i i i jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256) SistaV1: 248 11111000 iiiiiiii mjjjjjjj Call Primitive #iiiiiiii + (jjjjjjj * 256) m=1 means inlined primitive, no hard return after execution. V3/Spur: 139 10001011 i i i i i i i i jjjjjjjj Call Primitive #iiiiiiii + (jjjjjjjj * 256)" "Note that we simply skip a callPrimitiveBytecode at the start of a method that contains a primitive. This because methods like Context(Part)>>reset have to be updated to skip the callPrimtiive bytecode otherwise." SistaVM ifTrue: [| byte1 byte2 prim primSet header | byte1 := self fetchByte. byte2 := self fetchByte. self fetchNextBytecode. byte2 < 128 ifTrue: [header := objectMemory methodHeaderOf: method. ((self methodHeaderHasPrimitive: header) and: [localIP asUnsignedInteger + = (self initialIPForHeader: header method: method) + (self sizeOfCallPrimitiveBytecode: header)]) ifTrue: - = (self initialPCForHeader: header method: method) + (self sizeOfCallPrimitiveBytecode: header)]) ifTrue: [^self]. localIP := localIP - 3. ^self respondToUnknownBytecode]. prim := byte2 - 128 << 8 + byte1. primSet := prim >> 13 bitAnd: 3. prim := prim bitAnd: 8191. primSet = 0 ifTrue: [ prim < 1000 ifTrue: [^self nullaryInlinePrimitive: prim]. prim < 2000 ifTrue: [^self unaryInlinePrimitive: prim - 1000]. prim < 3000 ifTrue: [^self binaryInlinePrimitive: prim - 2000]. prim < 4000 ifTrue: [^self trinaryInlinePrimitive: prim - 3000]. ]. LowcodeVM ifTrue: [ primSet = 1 ifTrue: [ prim < 1000 ifTrue: [^self lowcodeNullaryInlinePrimitive: prim]. prim < 2000 ifTrue: [^self lowcodeUnaryInlinePrimitive: prim - 1000]. prim < 3000 ifTrue: [^self lowcodeBinaryInlinePrimitive: prim - 2000]. prim < 4000 ifTrue: [^self lowcodeTrinaryInlinePrimitive: prim - 3000]. ]. ]. localIP := localIP - 3. ^self respondToUnknownBytecode] ifFalse: [| header | header := objectMemory methodHeaderOf: method. ((self methodHeaderHasPrimitive: header) + and: [localIP asInteger = (self initialIPForHeader: header method: method)]) - and: [localIP asInteger = (self initialPCForHeader: header method: method)]) ifTrue: [localIP := localIP + (self sizeOfCallPrimitiveBytecode: header) - 1. ^self fetchNextBytecode] ifFalse: [^self respondToUnknownBytecode]]! Item was added: + ----- Method: StackInterpreter>>ifSoAssertValidIPAssign:ofContext:with: (in category 'frame access') ----- + ifSoAssertValidIPAssign: index ofContext: maybeMarriedContext with: anOop + self assert: (index ~= InstructionPointerIndex + or: [(objectMemory isContextNonImm: maybeMarriedContext) not + or: [| mo | + mo := self fetchPointer: MethodIndex ofObject: maybeMarriedContext. + (anOop = objectMemory nilObject + or: [(objectMemory isIntegerObject: anOop) + and: [(objectMemory integerValueOf: anOop) + between: (LiteralStart + (objectMemory literalCountOf: mo)) * objectMemory bytesPerOop + and: (objectMemory numBytesOf: mo)]])]])! Item was added: + ----- Method: StackInterpreter>>initialIPForHeader:method: (in category 'compiled methods') ----- + initialIPForHeader: methodHeader method: theMethod + "Answer a pointer to the initial byte for a method; used only in methods that build a frame." + <inline: true> + ^theMethod + + ((LiteralStart + (objectMemory literalCountOfMethodHeader: methodHeader)) * objectMemory bytesPerOop) + + objectMemory baseHeaderSize! Item was removed: - ----- Method: StackInterpreter>>initialPCForHeader:method: (in category 'compiled methods') ----- - initialPCForHeader: methodHeader method: theMethod - "Answer a pointer to the initial byte for a method; used only in methods that build a frame." - <inline: true> - ^theMethod - + ((LiteralStart + (objectMemory literalCountOfMethodHeader: methodHeader)) * objectMemory bytesPerOop) - + objectMemory baseHeaderSize! Item was changed: ----- Method: StackInterpreter>>internalActivateNewMethod (in category 'message sending') ----- internalActivateNewMethod | methodHeader numTemps rcvr errorCode | <inline: true> methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. self assert: argumentCount = (self argumentCountOfMethodHeader: methodHeader). rcvr := self internalStackValue: argumentCount. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self internalPush: localIP. self internalPush: localFP. localFP := localSP. self internalPush: newMethod. self setMethod: newMethod methodHeader: methodHeader. self internalPush: (self encodeFrameFieldHasContext: false isBlock: false numArgs: (self argumentCountOfMethodHeader: methodHeader)). self internalPush: objectMemory nilObject. "FxThisContext field" self internalPush: rcvr. "Initialize temps..." argumentCount + 1 to: numTemps do: [:i | self internalPush: objectMemory nilObject]. "-1 to account for pre-increment in fetchNextBytecode" + localIP := self pointerForOop: (self initialIPForHeader: methodHeader method: newMethod) - 1. - localIP := self pointerForOop: (self initialPCForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." localIP := localIP + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: [(objectMemory byteAt: localIP + 1) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self internalStackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. self assert: (self frameNumArgs: localFP) == argumentCount. self assert: (self frameIsBlockActivation: localFP) not. self assert: (self frameHasContext: localFP) not. "Now check for stack overflow or an event (interrupt, must scavenge, etc)." localSP < stackLimit ifTrue: [self externalizeIPandSP. self handleStackOverflowOrEventAllowContextSwitch: (self canContextSwitchIfActivating: newMethod header: methodHeader). self internalizeIPandSP]! Item was changed: ----- Method: StackInterpreter>>justActivateNewMethod (in category 'message sending') ----- justActivateNewMethod | methodHeader numArgs numTemps rcvr errorCode | <inline: true> methodHeader := objectMemory methodHeaderOf: newMethod. numTemps := self temporaryCountOfMethodHeader: methodHeader. numArgs := self argumentCountOfMethodHeader: methodHeader. rcvr := self stackValue: numArgs. "could new rcvr be set at point of send?" self assert: (objectMemory isOopForwarded: rcvr) not. self push: instructionPointer. self push: framePointer. framePointer := stackPointer. self push: newMethod. self setMethod: newMethod methodHeader: methodHeader. self push: (self encodeFrameFieldHasContext: false isBlock: false numArgs: numArgs). self push: objectMemory nilObject. "FxThisContext field" self push: rcvr. "clear remaining temps to nil" numArgs+1 to: numTemps do: [:i | self push: objectMemory nilObject]. + instructionPointer := (self initialIPForHeader: methodHeader method: newMethod) - 1. - instructionPointer := (self initialPCForHeader: methodHeader method: newMethod) - 1. (self methodHeaderHasPrimitive: methodHeader) ifTrue: ["Skip the CallPrimitive bytecode, if it's there, and store the error code if the method starts with a long store temp. Strictly no need to skip the store because it's effectively a noop." instructionPointer := instructionPointer + (self sizeOfCallPrimitiveBytecode: methodHeader). primFailCode ~= 0 ifTrue: [(objectMemory byteAt: instructionPointer + 1) = (self longStoreBytecodeForHeader: methodHeader) ifTrue: [errorCode := self getErrorObjectFromPrimFailCode. self stackTopPut: errorCode "nil if primFailCode == 1, or primFailCode"]. primFailCode := 0]]. ^methodHeader! Item was changed: ----- Method: StackInterpreter>>makeBaseFrameFor: (in category 'frame access') ----- makeBaseFrameFor: aContext "<Integer>" "Marry aContext with the base frame of a new stack page. Build the base frame to reflect the context's state. Answer the new page." <returnTypeC: #'StackPage *'> | page pointer theMethod theIP numArgs stackPtrIndex maybeClosure rcvr | <inline: false> <var: #page type: #'StackPage *'> <var: #pointer type: #'char *'> self assert: (objectMemory isContext: aContext). self assert: (self isSingleContext: aContext). self assert: (objectMemory goodContextSize: aContext). page := stackPages newStackPage. pointer := page baseAddress. theIP := objectMemory fetchPointer: InstructionPointerIndex ofObject: aContext. theMethod := objectMemory followObjField: MethodIndex ofObject: aContext. (objectMemory isIntegerObject: theIP) ifFalse: [self error: 'context is not resumable']. theIP := objectMemory integerValueOf: theIP. rcvr := objectMemory followField: ReceiverIndex ofObject: aContext. "If the frame is a closure activation then the closure should be on the stack in the pushed receiver position (closures receive the value[:value:] messages). Otherwise it should be the receiver proper." maybeClosure := objectMemory fetchPointer: ClosureIndex ofObject: aContext. maybeClosure ~= objectMemory nilObject ifTrue: [(objectMemory isForwarded: maybeClosure) ifTrue: [maybeClosure := objectMemory fixFollowedField: ClosureIndex ofObject: aContext withInitialValue: maybeClosure]. numArgs := self argumentCountOfClosure: maybeClosure. stackPages longAt: pointer put: maybeClosure] ifFalse: [| header | header := objectMemory methodHeaderOf: theMethod. numArgs := self argumentCountOfMethodHeader: header. "If this is a synthetic context its IP could be pointing at the CallPrimitive opcode. If so, skip it." ((self methodHeaderHasPrimitive: header) + and: [theIP = (1 + (self startPCOfMethodHeader: header))]) ifTrue: - and: [theIP = (1 + (objectMemory lastPointerOfMethodHeader: header))]) ifTrue: [theIP := theIP + (self sizeOfCallPrimitiveBytecode: header)]. stackPages longAt: pointer put: rcvr]. "Put the arguments on the stack" 1 to: numArgs do: [:i| stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (objectMemory fetchPointer: ReceiverIndex + i ofObject: aContext)]. "saved caller ip is sender context in base frame" stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (objectMemory followObjField: SenderIndex ofObject: aContext). "base frame's saved fp is null" stackPages longAt: (pointer := pointer - objectMemory wordSize) put: 0. page baseFP: pointer; headFP: pointer. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theMethod. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (self encodeFrameFieldHasContext: true isBlock: maybeClosure ~= objectMemory nilObject numArgs: numArgs). self assert: (self frameHasContext: page baseFP). self assert: (self frameNumArgs: page baseFP) == numArgs. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: aContext. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: rcvr. stackPtrIndex := self quickFetchInteger: StackPointerIndex ofObject: aContext. self assert: ReceiverIndex + stackPtrIndex < (objectMemory lengthOf: aContext). numArgs + 1 to: stackPtrIndex do: [:i| stackPages longAt: (pointer := pointer - objectMemory wordSize) put: (objectMemory fetchPointer: ReceiverIndex + i ofObject: aContext)]. "top of stack is the instruction pointer" theIP := self iframeInstructionPointerForIndex: theIP method: theMethod. stackPages longAt: (pointer := pointer - objectMemory wordSize) put: theIP. page headSP: pointer. self assert: (self context: aContext hasValidInversePCMappingOf: theIP in: page baseFP). "Mark context as married by setting its sender to the frame pointer plus SmallInteger tags and the InstructionPointer to the saved fp (which ensures correct alignment w.r.t. the frame when we check for validity) plus SmallInteger tags." objectMemory storePointerUnchecked: SenderIndex ofObject: aContext withValue: (self withSmallIntegerTags: page baseFP). objectMemory storePointerUnchecked: InstructionPointerIndex ofObject: aContext withValue: (self withSmallIntegerTags: 0). self assert: (objectMemory isIntegerObject: (objectMemory fetchPointer: SenderIndex ofObject: aContext)). self assert: (self frameOfMarriedContext: aContext) = page baseFP. self assert: (self validStackPageBaseFrame: page). ^page! Item was added: + ----- Method: StackInterpreter>>startPCOfMethodHeader: (in category 'compiled methods') ----- + startPCOfMethodHeader: methodHeader + "Answer the zero-relative index to the initial byte for a method. + Zero-relative version of CompiledMethod>>startpc." + ^(objectMemory literalCountOfMethodHeader: methodHeader) + LiteralStart * objectMemory bytesPerOop! Item was changed: ----- Method: StackInterpreter>>storeMaybeContext:receiverVariable:withValue: (in category 'stack bytecodes') ----- + storeMaybeContext: obj receiverVariable: fieldIndex withValue: anOop - storeMaybeContext: obj receiverVariable: fieldIndex withValue: anObject "Must trap accesses to married and widowed contexts. But don't want to check on all inst var accesses. This method is only used by the long-form bytecodes, evading the cost." <inline: true> ((self isWriteMediatedContextInstVarIndex: fieldIndex) and: [(objectMemory isContextNonImm: obj) and: [self isMarriedOrWidowedContext: obj]]) ifTrue: + [self instVar: fieldIndex ofContext: obj put: anOop] - [self instVar: fieldIndex ofContext: obj put: anObject] ifFalse: + [objectMemory storePointerImmutabilityCheck: fieldIndex ofObject: obj withValue: anOop]! - [objectMemory storePointerImmutabilityCheck: fieldIndex ofObject: obj withValue: anObject] - ! Item was changed: ----- Method: StackInterpreterSimulator>>findNewMethodInClassTag: (in category 'testing') ----- findNewMethodInClassTag: classTag " | cName | traceOn ifTrue: [cName := (self sizeBitsOf: class) = 16r20 ifTrue: ['class ' , (self nameOfClass: (self fetchPointer: 6 ofObject: class))] ifFalse: [(self nameOfClass: class)]. self cr; print: cName , '>>' , (self stringOf: messageSelector)]. " + messageSelector = (objectMemory splObj: SelectorDoesNotUnderstand) ifTrue: [self halt]. - (self stringOf: messageSelector) = 'doesNotUnderstand:' ifTrue: [self halt]. sendCount := sendCount + 1. + (printSends or: [printBytecodeAtEachStep]) ifTrue: - printSends ifTrue: [self cr; print: byteCount; space; printStringOf: messageSelector; cr]. " (sendCount > 1000 and: [sendCount\\10 = 0]) ifTrue: [Transcript print: sendCount; space. self validate]. " " (sendCount > 100150) ifTrue: [self qvalidate. messageQueue == nil ifTrue: [messageQueue := OrderedCollection new]. messageQueue addLast: (self stringOf: messageSelector)]. " ^super findNewMethodInClassTag: classTag!

1 0

WebAssembly
by Ben Coman 08 Dec '16

08 Dec '16

I've just bumped into WebAssembly and am curious what opportunities (or not) it might offer us. * https://medium.com/javascript-scene/what-is-webassembly-the-dawn-of-a-new-e… One approach could be to just compile our currently generated C code to WevAssembly via LLVM. Ronie's recent effort to produce a non-display minimal VM should help proof of concept here. * http://webassembly.org/docs/c-and-c++/ * https://hacks.mozilla.org/2015/12/compiling-to-webassembly-its-happening/ * http://cultureofdevelopment.com/blog/build-your-first-thing-with-web-assemb… An obvious downside would be having a VM running on a VM. But WebAssembly doesn't do garbage collection so at least it wouldn't double up on that. Possibly there would be some double-up/conflict on JIT-ing, but there seems like there will be a facility for adding JIT and optimisation libraries, so possibly past investment in Cog is not lost. Also perhaps(??) while WebAssembly is in its formative stage right now some primitives can be added to facilitate how Cog operates. * http://webassembly.org/docs/future-features/#platform-independent-just-in-t… * http://webassembly.org/docs/jit-library/ Another approach may be to start with SqueakJS, and work out how the Cog JIT could be plugged into WebAssembly as a library that SqueakJS (and others?) could use. If its architecturally possible this might broaden the exposure of Cog(??). What would WebAssembly require to facilitate using Cog? Of course all plates are full, but now seems the ideal time time to get involved. WebAssembly browser preview seeking community feedback concluding Q1 2017. https://www.infoq.com/news/2016/11/webassembly-browser-preview http://webassembly.org/roadmap/ https://github.com/WebAssembly/design Chrome nightly builds available to test it http://thenextweb.com/dd/2016/03/15/webassembly-lands-chrome-canary-offerin… It would be amazing to run Cog in a web browser, and thus facilitate all our favourite Smalltalk dialects. Side thought: Craig's work to incrementally download a running image could be useful to reducing web page startup time. cheers -ben

4 4

VM Maker: VMMaker.oscog-eem.2031.mcz
by commits＠source.squeak.org 08 Dec '16

08 Dec '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2031.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2031 Author: eem Time: 7 December 2016, 6:35:42.344995 pm UUID: 8ca33ad6-6017-412f-8c48-83024848049f Ancestors: VMMaker.oscog-eem.2030 registerAllocatingCogit: Implement mustBeBoolean processing, mapping machine code frame to interpreted frame. =============== Diff against VMMaker.oscog-eem.2030 =============== Item was changed: ----- Method: CoInterpreter>>ceSendMustBeBooleanTo:interpretingAtDelta: (in category 'trampolines') ----- + ceSendMustBeBooleanTo: aNonBooleanObject interpretingAtDelta: jumpSize - ceSendMustBeBooleanTo: anObject interpretingAtDelta: jumpSize "For RegisterAllocatingCogit we want the address following a conditional branch not to be reachable, so we + don't have to generate code to reload registers. Instead simply convert to an interpreter frame, + backup the pc to the branch, reenter the interpreter and hence retry the mustBeBoolean send therein." - don't have to generate code to reload registers. Instead simply convert to an interpreter frame." <api> + | cogMethod methodObj methodHeader startBcpc | + <var: 'cogMethod' type: #'CogBlockMethod *'> + self assert: (objectMemory addressCouldBeOop: aNonBooleanObject). + cogMethod := self mframeCogMethod: framePointer. + ((self mframeIsBlockActivation: framePointer) + and: [cogMethod cmIsFullBlock not]) + ifTrue: + [methodHeader := cogMethod cmHomeMethod methodHeader. + methodObj := cogMethod cmHomeMethod methodObject. + startBcpc := cogMethod startpc] + ifFalse: + [methodHeader := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodHeader. + methodObj := (self cCoerceSimple: cogMethod to: #'CogMethod *') methodObject. + startBcpc := self startPCOfMethod: methodObj]. + + "Map the machine code instructionPointer to the interpreter instructionPointer of the branch." - self flag: 'A nice way to implement this is to - - provide an additional argument that is the size of the branch (have trampolines for 1 & 2 byte jumps). - Note that there is no need to back up before any extensions since the branch will not be taken. - ceSendMustBeBooleanTo: anObject interpretingAtDelta: jumpSize - - map the frame to an interpreter frame - - push anObject - - back up the pc to position the interpreter at the jump - - enter the interpreter, hence reexecuting the mustBeBoolean'. - self shouldBeImplemented. instructionPointer := self popStack. + instructionPointer := cogit bytecodePCFor: instructionPointer startBcpc: startBcpc in: cogMethod. + instructionPointer := methodObj + objectMemory baseHeaderSize + instructionPointer - jumpSize - 1. "pre-decrement" + + "Make space for the two extra fields in an interpreter frame" + stackPointer to: framePointer + FoxMFReceiver by: objectMemory wordSize do: + [:p| | oop | + oop := objectMemory longAt: p. + objectMemory + longAt: p - objectMemory wordSize - objectMemory wordSize + put: (objectMemory longAt: p)]. + stackPointer := stackPointer - objectMemory wordSize - objectMemory wordSize. + self push: aNonBooleanObject. + "Fill in the fields" + objectMemory + longAt: framePointer + FoxIFrameFlags + put: (self + encodeFrameFieldHasContext: (self mframeHasContext: framePointer) + isBlock: (self mframeIsBlockActivation: framePointer) + numArgs: cogMethod cmNumArgs); + longAt: framePointer + FoxIFSavedIP + put: 0; + longAt: framePointer + FoxMethod + put: methodObj. + + "and now reenter the interpreter..." + self setMethod: methodObj methodHeader: methodHeader. + self siglong: reenterInterpreter jmp: ReturnToInterpreter.! - self push: anObject. - self push: instructionPointer. - ^self - ceSendAbort: (objectMemory splObj: SelectorMustBeBoolean) - to: anObject - numArgs: 0!

1 0

[OpenSmalltalk/opensmalltalk-vm] 9d4e68: CogVM source as per VMMaker.oscog-eem.2030
by GitHub 08 Dec '16

08 Dec '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 9d4e68e555ba7b712a8c92047c95a78e840048cd https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9d4e68e555ba7b712a… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-12-07 (Wed, 07 Dec 2016) Changed paths: M .gitignore M build.macos32x86/pharo.stack.spur/plugins.ext M build.macos32x86/pharo.stack.spur/plugins.int M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/plugins/AsynchFilePlugin/AsynchFilePlugin.c M src/plugins/B2DPlugin/B2DPlugin.c M src/plugins/BitBltPlugin/BitBltPlugin.c M src/plugins/FilePlugin/FilePlugin.c M src/plugins/MiscPrimitivePlugin/MiscPrimitivePlugin.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2030 Interpreter: Improve debugging of stack imbalances on primitive invocation by restoring the stack pointer after calling failUnbalancedPrimitive. Add a variable to help debug the crashes in callbacks due to stack imbalance experienced in the Pharo VM. The variable is a set of bit flags tracing the path through returnAs:ThroughCallback:Context:. Fix a compilation warning with the definition of sigsetjump & siglongjmp in the interpreter. Do to signed32BitValueOf: what has been done to signed32BitIntegerFor:, i.e. only invoke noInlineSigned32BitValueGutsOf: for the case of LargeInteger deciphering. When the oop is a 31bits SmallInteger, don't bother entering such function - just inline. Cogit: Fix occasional start-up crashes on linux x64. The choice of 16rBADA550 for a constant in closed PIC prototype generation (used to compute offsets in PICs) occasionally coincides with the address for code chosen by address space randomization, and so confuses the Cogit into generating pc-relative addressing to create this address, hence causing mayhem later on when the wrong sizes for instructions are used to decode closed PIC contents. Hence also beef up the asserts regarding distinguishing constants planted in code on X64 for MoveCwR PushCw and ArithCwR. Fix the order of generating fixups and pushing the dummyValue when no deadCode in genSpecialSelectorEqalsEquals:. This didn't matter with the StackToRegisterMappingCogit but in the RegisterAllocatingCogit now that teh stack is not flushed on conditional branch, it is critical; the fixup must be established before the dummyValue is pushed. Fix a slip in genSubConstant:R: which always used TempReg and didn't use its argument. Abstract away voiding the optStatus into voidReceiverOptStatus so that RegisterAllocatingCogit can override to clear the liveRegister on simSelf. Add voidReceiverResultRegContainsSelf that scans the stack for occurrences of simSelf in a register on stack and to either flush (StackToRegisterMappingCogit) or void liveRegister (RegisterAllocatingCogit). Improve Spur genGetClassObjectOf:into:scratchReg:instRegIsReceiver: to avoid reg-reg copies. Make #~~ a special selector instead of #blockCopy:. If the bytecode compiler compiles #~~ using the special selector bytecode, then the pointer comparison with #~~ is inlined as it is with #==. This leads #~~ to have the same performance as #==. It also means #~~ is not a primitive call, as #==. To integrate that in the Squeak / Pharo image, one needs to add #~~ instead of if not already the case. SistaCogit: Added a setting so that subclasses of cogit can choose to refuse early openPIC promotion. This leads to much, much, *much* better type information on PICs in the Sista VM. No changes in the normal VM. Plugins/Primitives: Fix an unused value warning in Balloon/Bezier. I (NC) think that the intention was to use 2nd derivative to decide direction when 1st derivative is null. Fix primitiveBeCursor - generated code could dereference a null pointer offsetObj due to misplaced block end. Also a null pointer cursorObj could be dereferenced if 2 arguments or more were passed to the primitive. Make pharo.stack.spur's plugins agree with pharo.cog.spur's git: Ignore zip files in image directory.

1 0

VM Maker: VMMaker.oscog-eem.2030.mcz
by commits＠source.squeak.org 08 Dec '16

08 Dec '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2030.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2030 Author: eem Time: 7 December 2016, 3:22:31.533512 pm UUID: 336e0ad2-8a82-4c38-af30-a533abc15672 Ancestors: VMMaker.oscog-eem.2029 Fix a translation-time snafu with the V3 Cogit. =============== Diff against VMMaker.oscog-eem.2029 =============== Item was removed: - ----- Method: CogObjectRepresentationForSqueakV3>>genInlinedIdenticalOrNotIf: (in category 'compile abstract instructions') ----- - genInlinedIdenticalOrNotIf: orNot - <inline: true> - ^ cogit genVanillaInlinedIdenticalOrNotIf: orNot! Item was added: + ----- Method: CogObjectRepresentationForSqueakV3>>genInlinedIdenticalOrNotIfGuts: (in category 'compile abstract instructions') ----- + genInlinedIdenticalOrNotIfGuts: orNot + <inline: true> + ^ cogit genVanillaInlinedIdenticalOrNotIf: orNot!

1 0

← Newer
1
...
5
6
7
8
9
10
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev December 2016