Vm-dev October 2016

vm-dev@lists.squeakfoundation.org

30 participants
82 discussions

Quick sketch for Cogit augmentation of plugin primitives
by Eliot Miranda 14 Oct '16

14 Oct '16

Hi All, just a quick sketch of an idea (and a bucket of whitewash) in the light of finding that FloatArray>>at: index <primitive: 'primitiveAt' module: 'FloatArrayPlugin'> ^Float fromIEEE32Bit: (self basicAt: index) and at:put: are very slow. The basic idea is to annotate selected internal plugin primitive implementation methods with a corresponding Cogit or CogObjectRepresentation generator for a machine code version of the primitive. FloatArray>>at:put: is I think about 6 times slower than the native Cogit implementation of at:put:; this because invoking plugin primitives is very slow (native stack pointers must be written back to the interpreter's stack pointers, arguments must be pushed onto the stack, the primFailCode must be tested explicitly). First, Roni has added some single-precision float support to the Cogit for Lowcode. To do single-precision to double-precision we would still need something like ConvertRsRd and ConvertRdRs to do the conversion. A related task is to implement the Lowcode instruction support for the other platforms; Roni has done x86 (IA32), which leaves ARMv6 & 7, x86-64 and MIPS32. Second, one could add a translation-time scheme to associate specific plugin primitives with JIT versions. For example, let's imagine we annotate the above's corresponding primitive implementation as: FloatArrayPlugin>>primitiveAt <cogitPrimitive: #genFloatArrayPluginAt> | index rcvr floatValue floatPtr | <export: true> <var: #floatValue type: #double> <var: #floatPtr type: #'float *'> index := interpreterProxy stackIntegerValue: 0. rcvr := interpreterProxy stackValue: 1. (interpreterProxy failed not and: [(interpreterProxy isWords: rcvr) and: [index > 0 and: [index <= (interpreterProxy slotSizeOf: rcvr)]]]) ifFalse: [^interpreterProxy primitiveFail]. floatPtr := interpreterProxy firstIndexableField: rcvr. floatValue := (floatPtr at: index-1) asFloat. interpreterProxy pop: 2. interpreterProxy pushFloat: floatValue and then generate a string table that contains the tuple {"FloatArrayPlugin", "primitiveAt", genFloatArrayPluginAt } which could be consulted by the Cogit whenever a plugin primitive call in an internal plugin occurs in a jitter method. The Cogit would then generate the call via the generator, which might or might not fall back on the plugin primitive in unusual circumstances, but would handle the common case in machine code and reap much improved performance as a result. Don't have time to do this now (perhaps you do ;-) ) so documenting the idea to not forget it. Candidates: FloatArrayPlugin at: at:put:, LargeIntegerArithmeticPlugin comparisons. _,,,^..^,,,_ best, Eliot

1 0

9 Pending Pull Requests for OpenSmalltalk VM
by Fabio Niephaus 14 Oct '16

14 Oct '16

Hi all, there are currently quite a few open pull requests on GitHub. It's absolutely great that the move to GitHub has really made it easier to contribute, but of course we also need to actually review and merge them at some point. The oldest PR is older than a month and there were only few comments on all of them in general. So when you have some time, maybe have a look at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pulls Best, Fabio

3 3

[OpenSmalltalk/opensmalltalk-vm] ba962f: VMMaker.oscog-eem.1960
by GitHub 14 Oct '16

14 Oct '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: ba962f43f021a262b8c26d23e074e1b571bc68d0 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ba962f43f021a262b8… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c Log Message: ----------- VMMaker.oscog-eem.1960 Fix off-by-one error in the offset of the byte containing the "is full block method" flag in a CogBlockMethod. Commit: 3c2c39d92cb85284c24bc02edb2196600dcd162e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3c2c39d92cb85284c2… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M scripts/updateSCCSVersions Log Message: ----------- Merge branch 'Cog' of http://www.github.com/opensmalltalk/vm into Cog Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/468cbca885c0...3c…

1 0

VM Maker: VMMaker.oscog-eem.1960.mcz
by commits＠source.squeak.org 14 Oct '16

14 Oct '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1960.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.1960 Author: eem Time: 13 October 2016, 3:24:35.154823 pm UUID: fb5e58cd-1533-4f86-9184-84ef7efba782 Ancestors: VMMaker.oscog-eem.1959 Fix off-by-one error in the offset of the byte containing the "is full block method" flag in a CogBlockMethod. =============== Diff against VMMaker.oscog-eem.1959 =============== Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>bitAndByteOffsetOfIsFullBlockBitInto: (in category 'in-line cacheing') ----- bitAndByteOffsetOfIsFullBlockBitInto: aBlock <inline: true> "This supplies the bitmask for the isFullBlock bit, and the offset of the byte containing that bit in a CogMethod header to aBlock. We don't have named variables holding this + offset. The following assert tests whether the values are correct by creating a surrogate + on an empty ByteArray, setting the bit, and checking that the expected values are set - offset. Th efollowing assert tsts whether the values are correct by creating a surrogate - on an empty ByteArray, setting the bit, and checking that the exopected values are set in the ByteArray." self cCode: [] inSmalltalk: [| m | m := ByteArray new: 16. CogBlockMethodSurrogate64 new at: 0 memory: m headerSize: 8 cogit: nil; cpicHasMNUCaseOrCMIsFullBlock: true. self assert: m = #[0 0 0 0 0 0 0 0 0 16 0 0 0 0 0 0]. self assert: (m at: objectMemory baseHeaderSize + 2) = 16]. + aBlock value: 16 value: objectMemory baseHeaderSize + 1 "zero-relative"! - aBlock value: 16 value: objectMemory baseHeaderSize + 2!

1 0

[OpenSmalltalk/opensmalltalk-vm] 1aa41e: replaces bash with sh
by GitHub 13 Oct '16

13 Oct '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 1aa41edb4fdbaad7ad22c29608985e15e137f692 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1aa41edb4fdbaad7ad… Author: Gerardo Santana <geardo.santana(a)gmail.com> Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M scripts/updateSCCSVersions Log Message: ----------- replaces bash with sh Commit: 468cbca885c04aaef65135c2565933dcf63d8f7f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/468cbca885c04aaef6… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M scripts/updateSCCSVersions Log Message: ----------- Merge pull request #76 from santana/sh replaces bash with sh Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/d286d746d9c3...46…

1 0

[OpenSmalltalk/opensmalltalk-vm] d286d7: CogVM source as per VMMaker.oscog-eem.1959
by GitHub 13 Oct '16

13 Oct '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: d286d746d9c36e1bf55e0b45e66eded81db88a41 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d286d746d9c36e1bf5… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/interp.h M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/gcc3x-cointerp.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/interp.h M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.1959 Fix primitiveConstantFill for Spur 16-bit and 64-bit indexable objects. Ensure that on Spur bytes beyond the last byte are zero. Fix compilation of the Cogits by exporting full block entry offsets correctly.

1 0

VM Maker: VMMaker.oscog-eem.1959.mcz
by commits＠source.squeak.org 13 Oct '16

13 Oct '16

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1959.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.1959 Author: eem Time: 12 October 2016, 7:38:49.6578 pm UUID: 2784931a-d7ba-431a-be8c-ec79b1e55684 Ancestors: VMMaker.oscog-eem.1958 Fix primitiveConstantFill for Spur 16-bit and 64-bit indexable objects. Ensure that on Spur bytes beyond the last byte are zero. Fix compilation of the Cogits by exporting the full block entry offsets correctly. In 1959 the Cuban revolution occurs, the Confédération Mondiale des Activités Subaquatiques is founded by, amongst others, Jacques-Yves Cousteau, and I am born ;-). =============== Diff against VMMaker.oscog-eem.1958 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveConstantFill (in category 'sound primitives') ----- primitiveConstantFill + "Fill the receiver, which must be an indexable non-pointer + object, with the given integer value." + objectMemory hasSpurMemoryManagerAPI + ifTrue: [self primitiveConstantFillSpur] + ifFalse: [self primitiveConstantFillV3]! - "Fill the receiver, which must be an indexable bytes or words - objects, with the given integer value." - | fillValue rcvr rcvrIsBytes end i | - <var: #end type: #usqInt> - <var: #i type: #usqInt> - fillValue := self positive32BitValueOf: self stackTop. - rcvr := self stackValue: 1. - self success: (objectMemory isWordsOrBytes: rcvr). - rcvrIsBytes := objectMemory isBytes: rcvr. - rcvrIsBytes ifTrue: [self success: (fillValue >= 0 and: [fillValue <= 255])]. - self successful ifTrue: - [end := rcvr + (objectMemory sizeBitsOf: rcvr). - i := rcvr + objectMemory baseHeaderSize. - rcvrIsBytes ifTrue: - [fillValue := fillValue bitAnd: 255. - fillValue := fillValue + (fillValue << 8) + (fillValue << 16) + (fillValue << 24)]. - [i < end] whileTrue: - [objectMemory long32At: i put: fillValue. - i := i + 4]. - self pop: 1]! Item was added: + ----- Method: InterpreterPrimitives>>primitiveConstantFillSpur (in category 'sound primitives') ----- + primitiveConstantFillSpur + "Fill the receiver, which must be an indexable non-pointer object, with the given integer value." + <inline: true> + | fillValue rcvr format end i oddBytes | + <var: #fillValue type: #usqLong> + <var: #end type: #usqInt> + <var: #i type: #usqInt> + fillValue := self positive64BitValueOf: self stackTop. + rcvr := self stackValue: 1. + (self successful + and: [(objectMemory isNonImmediate: rcvr) + and: [(format := objectMemory formatOf: rcvr) >= objectMemory sixtyFourBitIndexableFormat]]) ifFalse: + [^self primitiveFail]. + format >= objectMemory firstShortFormat + ifTrue: + [format >= objectMemory firstByteFormat + ifTrue: + [(fillValue > 16rFF or: [format >= objectMemory firstCompiledMethodFormat]) ifTrue: + [^self primitiveFail]. + fillValue := fillValue + (fillValue << 8) + (fillValue << 16) + (fillValue << 24). + oddBytes := format bitAnd: 7] + ifFalse: + [fillValue > 16rFFFF ifTrue: + [^self primitiveFail]. + fillValue := fillValue + (fillValue << 16). + oddBytes := (format bitAnd: 3) << 1]. + fillValue := fillValue + (fillValue << 32)] + ifFalse: + [format = objectMemory sixtyFourBitIndexableFormat + ifTrue: + [oddBytes := 0] + ifFalse: + [fillValue > 16rFFFFFFFF ifTrue: + [^self primitiveFail]. + fillValue := fillValue + (fillValue << 32). + oddBytes := (format bitAnd: 1) << 2]]. + end := objectMemory addressAfter: rcvr. + i := rcvr + objectMemory baseHeaderSize. + [i < end] whileTrue: + [objectMemory long64At: i put: fillValue. + i := i + 8]. + "now ensure trailing bytes are zero" + oddBytes > 0 ifTrue: + [self flag: #endianness. + fillValue := fillValue >> (8 * oddBytes). + objectMemory long64At: i - 8 put: fillValue]. + self pop: 1! Item was added: + ----- Method: InterpreterPrimitives>>primitiveConstantFillV3 (in category 'sound primitives') ----- + primitiveConstantFillV3 + "Fill the receiver, which must be an indexable bytes or words + object, with the given integer value." + <inline: true> + | fillValue rcvr end i | + <var: #end type: #usqInt> + <var: #i type: #usqInt> + fillValue := self positive32BitValueOf: self stackTop. + rcvr := self stackValue: 1. + self success: (objectMemory isWordsOrBytes: rcvr). + (objectMemory isBytes: rcvr) ifTrue: + [self success: (fillValue >= 0 and: [fillValue <= 255]). + fillValue := fillValue + (fillValue << 8) + (fillValue << 16) + (fillValue << 24)]. + self successful ifTrue: + [end := rcvr + (objectMemory sizeBitsOf: rcvr). + i := rcvr + objectMemory baseHeaderSize. + [i < end] whileTrue: + [objectMemory long32At: i put: fillValue. + i := i + 4]. + self pop: 1]! Item was changed: ----- Method: SimpleStackBasedCogit>>fullBlockEntryOffset (in category 'accessing') ----- fullBlockEntryOffset <api> + <cmacro> ^cbEntryOffset! Item was changed: ----- Method: SimpleStackBasedCogit>>fullBlockNoContextSwitchEntryOffset (in category 'accessing') ----- fullBlockNoContextSwitchEntryOffset <api> + <cmacro> ^cbNoSwitchEntryOffset!

1 0

reattaching a detatched git head...
by Eliot Miranda 12 Oct '16

12 Oct '16

I'm stuck. Don't know how I detached from the master. I'm seeing this: You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b <new-branch-name> HEAD is now at ed4a499... CogVM source as per VMMaker.oscog-eem.1958 I want to make this the new master, and then add a commit. I'm stuck. Git mavens, help please. _,,,^..^,,,_ best, Eliot

4 4

[OpenSmalltalk/opensmalltalk-vm] f277ba: Remove MIDIPlugin from builds (but leave #80 open ...
by GitHub 12 Oct '16

12 Oct '16

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f277bae3e8f34481dc06c0af8902c446c05c5b4e https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f277bae3e8f34481dc… Author: Bert Freudenberg <bert(a)freudenbergs.de> Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M build.macos32x86/pharo.cog.spur/plugins.ext M build.macos32x86/pharo.stack.spur/plugins.ext M build.macos32x86/squeak.cog.spur+immutability/plugins.ext M build.macos32x86/squeak.cog.spur/plugins.ext M build.macos32x86/squeak.cog.v3/plugins.ext M build.macos32x86/squeak.sista.spur/plugins.ext M build.macos32x86/squeak.stack.spur/plugins.ext M build.macos32x86/squeak.stack.v3/plugins.ext M build.macos64x64/squeak.cog.spur.immutability/plugins.ext M build.macos64x64/squeak.cog.spur/plugins.ext M build.macos64x64/squeak.sista.spur/plugins.ext M build.macos64x64/squeak.stack.spur/plugins.ext Log Message: ----------- Remove MIDIPlugin from builds (but leave #80 open to track its rewrite)

1 0

Re: [Vm-dev] reattaching a detatched git head...
by Jakob Reschke 12 Oct '16

12 Oct '16

To determine the correct/best course of action, it might also help to see what happened or where your detached head actaully is (oh, the plethora of possible puns!). You can look at the history graph with `gitk --all` (it should come with git). You can also create, checkout and move branches around there or do things like cherry picking, maybe even merging, not sure atm. Am 12.10.2016 03:21 schrieb "John McIntosh" <johnmci(a)smalltalkconsulting.com >: >

2 2

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev October 2016