Vm-dev January 2012

vm-dev@lists.squeakfoundation.org

27 participants
75 discussions

Re: [Pharo-project] cogwin/Croquet (Win7) + Moose + very large models = crash (out of Memory)
by Eliot Miranda 27 Jan '12

27 Jan '12

Well, the define in sqWin32Alloc.h reads #ifndef MAX_VIRTUAL_MEMORY #define MAX_VIRTUAL_MEMORY 512*1024*1024 #endif (albeit guarded by #ifndef NO_VIRTUAL_MEMORY) so I tried to redefine it in the makefile: VM_DEF=-D'MAX_VIRTUAL_MEMORY=(2*1024*1024*1024)' ... DEFS:= $(COGDEFS) $(WINVER) $(VM_DEF) -DWIN32 -DWIN32_FILE_SUPPORT -DNO_ISNAN \ -DNO_SERVICE -DNO_STD_FILE_SUPPORT \ $(NDEBUG) -DLSB_FIRST -D'VM_NAME="$(VM_NAME)"' -DX86 $(XDEFS) $(CROQUET) But the resulting VM still wouldn't allocate more than 512M, so it is more complex than I hoped :) Andreas, if it is a simple job, do you know what's required to experiment with raising the limit on WIndows? On Thu, Jan 26, 2012 at 2:43 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: > On 25 January 2012 23:18, Mariano Martinez Peck <marianopeck(a)gmail.com> > wrote: > > I think Igor fixed that for the Windows VM, but such changes were not > > integerated in Eliot VMs, but rather in the branch of Git. > > But since the Jenkins is not building Windows VM, I have no idea where > you > > can get such a VM. > > > No, changes are there. But they are not "fixing" the hard limit which > is still 512M. > They only fixing a strange issue with growing image close to that > limit (so 400M (and even less size) images was crashing before even > reaching a limit). > This is because of miscalculation between requested space and > available space, after memory growth. > > > Cheers > > > > > > On Wed, Jan 25, 2012 at 11:12 PM, Hani Abdeen <hani.abdeen(a)gmail.com> > wrote: > >> > >> > >> > >> On 25 January 2012 23:05, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > >>> > >>> > >>> Hani Abdeen wrote > >>> > > >>> > Hello, > >>> > > >>> > I'm using cogwin/Croquet VM (last version > >>> > http://www.mirandabanda.org/files/Cog/VM/VM.r2522/) on windows7, > >>> > and today I had this probelm: when the size of the pharo image become > >>> > so > >>> > large the VM crashes with reason 'out of memory'. > >>> > The same problem with previous versions of cogwin. > >>> > Note that I use a PC with 8G of RAM, so it's really damage to have > such > >>> > a > >>> > problem. > >>> > > >>> > Any idea about another VM working well on Windows and does not have > >>> > such > >>> > an > >>> > issues? > >>> > Any urgent solution? > >>> > > >>> > Thanks, > >>> > Hani > >>> > > >>> > >>> From this thread: > >>> http://forum.world.st/experience-with-large-images-td4101765.html > >>> > >>> It seems that on windows the size of the image by default is limited to > >>> 500MB in RAM. I don't know if you can change it or not. Linux/Mac is > >>> limited to 2GB. Can you try your experiments on a Mac? > >> > >> > >> Unfortunately no, I've not Mac, and the company for which I'll use Moose > >> on their software, Tomorrow morning :(, do not use Mac. > >> > >> > >>> > >>> > >>> > >>> -- > >>> View this message in context: > >>> > http://forum.world.st/cogwin-Croquet-Win7-Moose-very-large-models-crash-out… > >>> Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > >>> > >> > > > > > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > > > -- > Best regards, > Igor Stasenko. > > -- best, Eliot

1 0

[Windows cog vm] [Keyboard events related] about keycode mapping
by Guillermo Polito 27 Jan '12

27 Jan '12

Hi! I was playing to add Function Ket support in the windows vm (yep, always the same :P), and looking at the code, I saw this in the recordKeyboardEvent: evt = (sqKeyboardEvent*) sqNextEventPut(); evt->type = EventTypeKeyboard; evt->timeStamp = msg->time; * evt->charCode = keymap[keyCode & 0xff];* * * the problem with that line is that KeyDown and KeyUp events send VirtualKeycodes as keycodes and the Char event sends a unicode char value. And, it makes collisions, since for example $p char value is 112 and F1 virtual code value is 112 too :P http://msdn.microsoft.com/en-us/library/windows/desktop/ms646276(v=vs.85).a… http://msdn.microsoft.com/en-us/library/windows/desktop/ms646281(v=vs.85).a… http://msdn.microsoft.com/en-us/library/windows/desktop/dd375731(v=vs.85).a… And so with other keys, having the same keycode in the image side with different keys... I'm trying a solution like this, providing in a Char event the keycode without mapping to the image: ... case WM_CHAR: case WM_SYSCHAR: /* Note: VK_RETURN is recorded as virtual key ONLY */ if(keyCode == 13) return 1; * charCode = keyCode;* pressCode = EventKeyChar; break ... evt->timeStamp = msg->time; * evt->charCode = charCode? charCode : keymap[keyCode & 0xff];* evt->pressCode = pressCode; ... changing only the bold lines, and It seems to work. What do you think? Guille

4 17

Not declared errors when compiling Windows vm
by Guillermo Polito 26 Jan '12

26 Jan '12

Hi! I'm trying to get Windows VM compiled with Msys, using the Cog source code in the git repository. I've almost surpassed everything, but I'm having some "not declared" errors like this: c:/MinGW/msys/1.0/home/Guille/cog/gpolito-cogvm/platforms/win32/vm/sqWin32Intel. c:1250:27: error: '_MCW_EM' no se declar¾ aquÝ (primer uso en esta funci¾n) related to these lines of the sqWin32Intel.c file: ... #define FPU_DEFAULT (_RC_NEAR + _PC_53 + _EM_INVALID + _EM_ZERODIVIDE + _EM_OVERFLOW + _EM_UNDERFLOW + _EM_INEXACT + _EM_DENORMAL) ... in squeakExceptionHandler and sqMain _control87(FPU_DEFAULT, _MCW_EM | _MCW_RC | _MCW_PC | _MCW_IC); ... However, if I comment those lines, I can compile and everything seem to work :/. I googled a little but I've not found anything that helps me... Has anyone has this problem? Is it a Msys configuration problem? Thanks! Guille

3 4

VM Maker: CMakeVMMaker-MarianoMartinezPeck.145.mcz
by commits＠source.squeak.org 26 Jan '12

26 Jan '12

Mariano Martinez Peck uploaded a new version of CMakeVMMaker to project VM Maker: http://source.squeak.org/VMMaker/CMakeVMMaker-MarianoMartinezPeck.145.mcz ==================== Summary ==================== Name: CMakeVMMaker-MarianoMartinezPeck.145 Author: MarianoMartinezPeck Time: 26 January 2012, 3:28:49 pm UUID: 01869235-4a4b-084d-97d3-09d50e63ae18 Ancestors: CMakeVMMaker-MarianoMartinezPeck.144 Once again fix outputDir for windows builds. DO NOT CHANGE THAT. =============== Diff against CMakeVMMaker-EstebanLorenzano.143 =============== Item was changed: ----- Method: CogFamilyWindowsConfig>>outputDir (in category 'directories') ----- outputDir + "the directory where built binaries will be stored. + DO NOT CHANGE THIS FOR WINDOWS. It is not clear why but if we put for windows the same target directory as the rest of the platforms (/results), there is a link problems. The only way it works is to put it in /build/results. Only change this if you are use it can build" - "the directory where built binaries will be stored" + ^ outputDir ifNil: [ outputDir := (self msysPathFor: (self buildDir fullName , '/', self outputDirName )) ] - ^ outputDir ifNil: [ outputDir := self msysPathFor: (self buildDir containingDirectory fullName , '/', self outputDirName) ] !

1 0

VM Maker: VMMaker-oscog-golubovsky.137.mcz
by commits＠source.squeak.org 26 Jan '12

26 Jan '12

Dmitry Golubovsky uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker-oscog-golubovsky.137.mcz ==================== Summary ==================== Name: VMMaker-oscog-golubovsky.137 Author: golubovsky Time: 25 January 2012, 9:45:52 pm UUID: fc3f3e0f-df8b-4181-846c-7b3f4784c57f Ancestors: VMMaker-oscog-golubovsky.136 Added primGetSDCardRoot primitive =============== Diff against VMMaker-oscog-golubovsky.136 =============== Item was added: + ----- Method: AndroidPlugin>>primGetSDCardRoot (in category 'system primitives') ----- + primGetSDCardRoot + | vmcls vmobj bmmeth jmsg res size oop ptr | + <var: 'res' type: 'char *'> + <var: 'vmcls' type: 'jclass'> + <var: 'vmobj' type: 'jobject'> + <var: 'bmmeth' type: 'jmethodID'> + <export: true> + vmcls := self getVMClass. + vmcls ifNil: [^ interpreterProxy primitiveFail]. + vmobj := self getVMObject. + vmobj ifNil: [^ interpreterProxy primitiveFail]. + bmmeth := self getMethod: 'getSDCardRoot' withSig: '()Ljava/lang/String;' inClass: vmcls. + bmmeth ifNil: [^ interpreterProxy primitiveFail]. + res := self callStringMethod: bmmeth On: vmobj with: 0. + size := self strlen: res. + (size == 0) ifTrue: [^ interpreterProxy primitiveFail]. + oop := interpreterProxy instantiateClass: interpreterProxy classString indexableSize: size. + ptr := interpreterProxy firstIndexableField: oop. + self memc: ptr p: res y: size. + self free: res. + interpreterProxy pop: 1. + interpreterProxy push: oop. + !

1 0

VM Maker: Android-Base-golubovsky.23.mcz
by commits＠source.squeak.org 26 Jan '12

26 Jan '12

Dmitry Golubovsky uploaded a new version of Android-Base to project VM Maker: http://source.squeak.org/VMMaker/Android-Base-golubovsky.23.mcz ==================== Summary ==================== Name: Android-Base-golubovsky.23 Author: golubovsky Time: 25 January 2012, 9:42:59 pm UUID: 72784f2f-c4a5-4a53-bbf0-9fd62dc37109 Ancestors: Android-Base-golubovsky.22 Added getSDCardRoot primitive =============== Diff against Android-Base-golubovsky.22 =============== Item was added: + ----- Method: Android class>>getSDCardRoot (in category 'system primitives') ----- + getSDCardRoot + "get a string from Android clipboard" + <primitive: 'primGetSDCardRoot' module: 'AndroidPlugin'> + self primitiveFailed.!

1 0

Primitive failed when compiling Vm on Windows
by Guillermo Polito 26 Jan '12

26 Jan '12

Hi! I've downloaded version 3.8 of ConfigurationOfCog on Pharo 1.4, and when sending #topDir: to a CogWindowsConfig instance, I get a primitive failed error: PrimitiveFailed: primitive #primCreateDirectory: in DosFileDirectory failed 25 January 2012 7:24:30 pm VM: Win32 - IX86 - 5.1 - CoInterpreter VMMaker.oscog-eem.140 uuid: 2487009c-2c13-4609-b89e-77f0e195f433 Dec 12 2011, StackToRegisterMappingCogit VMMaker.oscog-eem.139 uuid: c2849383-9768-4948-b9b2-a5c22d482b07 Dec 12 2011, r2522 http://www.squeakvm.org/svn/squeak/branches/Cog Image: Pharo1.4a [Latest update: #14296] DosFileDirectory(Object)>>primitiveFailed: Receiver: DosFileDirectory on '' Arguments and temporary variables: selector: #primCreateDirectory: Receiver's instance variables: pathName: FilePath('') DosFileDirectory(Object)>>primitiveFailed Receiver: DosFileDirectory on '' Arguments and temporary variables: Receiver's instance variables: pathName: FilePath('') DosFileDirectory(FileDirectory)>>primCreateDirectory: Receiver: DosFileDirectory on '' Arguments and temporary variables: fullPath: '\\MinGW' Receiver's instance variables: pathName: FilePath('') DosFileDirectory(FileDirectory)>>createDirectory: Receiver: DosFileDirectory on '' Arguments and temporary variables: localFileName: '\\MinGW' Receiver's instance variables: pathName: FilePath('') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '' Arguments and temporary variables: lPath: '\\MinGW' localPath: '\\MinGW' Receiver's instance variables: pathName: FilePath('') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW' Arguments and temporary variables: lPath: 'msys' localPath: 'msys' Receiver's instance variables: pathName: FilePath('\\MinGW') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW\msys' Arguments and temporary variables: lPath: '1.0' localPath: '1.0' Receiver's instance variables: pathName: FilePath('\\MinGW\msys') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW\msys\1.0' Arguments and temporary variables: lPath: 'home' localPath: 'home' Receiver's instance variables: pathName: FilePath('\\MinGW\msys\1.0') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW\msys\1.0\home' Arguments and temporary variables: lPath: 'Guille' localPath: 'Guille' Receiver's instance variables: pathName: FilePath('\\MinGW\msys\1.0\home') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW\msys\1.0\home\Guille' Arguments and temporary variables: lPath: 'cog' localPath: 'cog' Receiver's instance variables: pathName: FilePath('\\MinGW\msys\1.0\home\Guille') DosFileDirectory(FileDirectory)>>assureExistenceOfPath: Receiver: DosFileDirectory on '\\MinGW\msys\1.0\home\Guille\cog' I followed the error up to: DosFileDirectory class>>privateFullPathForURI: aURI | path | path := aURI path unescapePercents. "Check for drive notation (a: etc)" path size > 1 ifTrue: [ ((path at: 3) = $:) ifTrue: [path := path copyFrom: 2 to: path size] ifFalse: [ "All other cases should be network path names (\\xxx\sdsd etc)" path := '/' , path]]. ^path copyReplaceAll: '/' with: self slash Which seems not being resolving well a full path like 'c:\something\another\directory' and is answering something like '\\MinGW\msys\1.0\home\Guille\cog\gpolito-cogvm' which then is treated as a relative path... I've done a temporary fix like this in my image so I can continue, but maybe someone has a little more knowledge on this class: DosFileDirectory class>>privateFullPathForURI: aURI | path | path := aURI asString unescapePercents. "Check for drive notation (a: etc)" path size > 1 ifTrue: [ ((path at: 2) = $:) ifTrue: [path := path copyFrom: 1 to: path size] ifFalse: [ "All other cases should be network path names (\\xxx\sdsd etc)" path := '/' , path]]. ^path copyReplaceAll: '/' with: self slash Guille

1 0

[Unix][X11] some xkeysyms -> unicode mappings, not found in keysymdef.h
by Guillermo Polito 25 Jan '12

25 Jan '12

In sqUnixX11.c, xkeysym2ucs4 function, there are some explicit mappings that are not correlated to any keysym in keysymdef.h :/ I've compared to keysymdef.h in here<http://cgit.freedesktop.org/xorg/proto/x11proto/plain/keysymdef.h>and in /usr/include/X11. They are this ones: - 0x12a1 to 0x12fe - 0x14a1 to 0x14ff - 0x15d0 to 0x15f6 - 0x16a0 to 0x16f6 /* Non existing range in keysymdef.h */ static unsigned short ucs4_12a1_12fe[] = { 0x1e02, 0x1e03, 0x0000, 0x0000, 0x0000, 0x1e0a, 0x0000, /* 0x12a0-0x12a7 */ 0x1e80, 0x0000, 0x1e82, 0x1e0b, 0x1ef2, 0x0000, 0x0000, 0x0000, /* 0x12a8-0x12af */ 0x1e1e, 0x1e1f, 0x0000, 0x0000, 0x1e40, 0x1e41, 0x0000, 0x1e56, /* 0x12b0-0x12b7 */ 0x1e81, 0x1e57, 0x1e83, 0x1e60, 0x1ef3, 0x1e84, 0x1e85, 0x1e61, /* 0x12b8-0x12bf */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x12c0-0x12c7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x12c8-0x12cf */ 0x0174, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x1e6a, /* 0x12d0-0x12d7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0176, 0x0000, /* 0x12d8-0x12df */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x12e0-0x12e7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x12e8-0x12ef */ 0x0175, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x1e6b, /* 0x12f0-0x12f7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0177 /* 0x12f0-0x12ff */ }; /* Non existing range in keysymdef.h */ static unsigned short ucs4_14a1_14ff[] = { 0x2741, 0x00a7, 0x0589, 0x0029, 0x0028, 0x00bb, 0x00ab, /* 0x14a0-0x14a7 */ 0x2014, 0x002e, 0x055d, 0x002c, 0x2013, 0x058a, 0x2026, 0x055c, /* 0x14a8-0x14af */ 0x055b, 0x055e, 0x0531, 0x0561, 0x0532, 0x0562, 0x0533, 0x0563, /* 0x14b0-0x14b7 */ 0x0534, 0x0564, 0x0535, 0x0565, 0x0536, 0x0566, 0x0537, 0x0567, /* 0x14b8-0x14bf */ 0x0538, 0x0568, 0x0539, 0x0569, 0x053a, 0x056a, 0x053b, 0x056b, /* 0x14c0-0x14c7 */ 0x053c, 0x056c, 0x053d, 0x056d, 0x053e, 0x056e, 0x053f, 0x056f, /* 0x14c8-0x14cf */ 0x0540, 0x0570, 0x0541, 0x0571, 0x0542, 0x0572, 0x0543, 0x0573, /* 0x14d0-0x14d7 */ 0x0544, 0x0574, 0x0545, 0x0575, 0x0546, 0x0576, 0x0547, 0x0577, /* 0x14d8-0x14df */ 0x0548, 0x0578, 0x0549, 0x0579, 0x054a, 0x057a, 0x054b, 0x057b, /* 0x14e0-0x14e7 */ 0x054c, 0x057c, 0x054d, 0x057d, 0x054e, 0x057e, 0x054f, 0x057f, /* 0x14e8-0x14ef */ 0x0550, 0x0580, 0x0551, 0x0581, 0x0552, 0x0582, 0x0553, 0x0583, /* 0x14f0-0x14f7 */ 0x0554, 0x0584, 0x0555, 0x0585, 0x0556, 0x0586, 0x2019, 0x0027, /* 0x14f8-0x14ff */ }; /* Non existing range in keysymdef.h */ static unsigned short ucs4_15d0_15f6[] = { 0x10d0, 0x10d1, 0x10d2, 0x10d3, 0x10d4, 0x10d5, 0x10d6, 0x10d7, /* 0x15d0-0x15d7 */ 0x10d8, 0x10d9, 0x10da, 0x10db, 0x10dc, 0x10dd, 0x10de, 0x10df, /* 0x15d8-0x15df */ 0x10e0, 0x10e1, 0x10e2, 0x10e3, 0x10e4, 0x10e5, 0x10e6, 0x10e7, /* 0x15e0-0x15e7 */ 0x10e8, 0x10e9, 0x10ea, 0x10eb, 0x10ec, 0x10ed, 0x10ee, 0x10ef, /* 0x15e8-0x15ef */ 0x10f0, 0x10f1, 0x10f2, 0x10f3, 0x10f4, 0x10f5, 0x10f6 /* 0x15f0-0x15f7 */ }; /* Non existing range in keysymdef.h */ static unsigned short ucs4_16a0_16f6[] = { 0x0000, 0x0000, 0xf0a2, 0x1e8a, 0x0000, 0xf0a5, 0x012c, 0xf0a7, /* 0x16a0-0x16a7 */ 0xf0a8, 0x01b5, 0x01e6, 0x0000, 0x0000, 0x0000, 0x0000, 0x019f, /* 0x16a8-0x16af */ 0x0000, 0x017e, 0xf0b2, 0x1e8b, 0x01d1, 0xf0b5, 0x012d, 0xf0b7, /* 0x16b0-0x16b7 */ 0xf0b8, 0x01b6, 0x01e7, 0x01d2, 0x0000, 0x0000, 0x0000, 0x0275, /* 0x16b8-0x16bf */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x018f, 0x0000, /* 0x16c0-0x16c7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x16c8-0x16cf */ 0x0000, 0x1e36, 0xf0d2, 0xf0d3, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x16d0-0x16d7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x16d8-0x16df */ 0x0000, 0x1e37, 0xf0e2, 0xf0e3, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x16e0-0x16e7 */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, /* 0x16e8-0x16ef */ 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0259 /* 0x16f0-0x16f6 */ }; Does anyone know if those mappings are useful? or if they deprecated? Thanks, Guille

1 0

Split sound package -> Cog not loading in last 1.4
by Mariano Martinez Peck 25 Jan '12

25 Jan '12

Hi guys. Cog is not loading anymore in 1.4 because of some classes depending on Project from the 'Sound' package found in PharoSound repo in SS. At the beginning I thought to create a separate package "SoundVMSupport" and put there the needed classes, but I discover that there are a lot which are needed. And moreover, all of those needed classes are in the category Sound-Synthesis. The classes problematic (regarding Project and morphs) are in the other package Sound-Scores. I have just tried and split the Sound package in two: SoundScores and SoundSynthesis. Then I changed ConfigurationOfCog to load SoundSynthesis rather than Sound. That works and I can now build the VM without problems. I think that the split makes sense even without of the need of Cog. Do you agree? If true, I can commit everything. One of the things I am not sure is how to make sure Sound package is not used anymore. All I can do is: a) Put a comment in squeaksource page saying that the packages are now SoundScores and SoundSynthesis. b) Create a new baseline and version of ConfigurationOfPharoSound which reflecs this change c) Commit a version of everything empty (no single class) to the package Sound. Which ones of these should I do ? Thanks -- Mariano http://marianopeck.wordpress.com

3 3

VM Maker: VMMaker.oscog-eem.141.mcz
by commits＠source.squeak.org 24 Jan '12

24 Jan '12

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.141.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.141 Author: eem Time: 24 January 2012, 2:49:19.653 pm UUID: 8dc3fa63-a227-4a8b-9f98-ba759064d001 Ancestors: VMMaker.oscog-eem.140 Add some coverage analysis to check for unimplemented opcodes in the Cogit. Implement AndCwR & OrCwR in CogIA32Compiler. =============== Diff against VMMaker.oscog-eem.140 =============== Item was added: + ----- Method: CogAbstractInstruction class>>specificOpcodes (in category 'verification') ----- + specificOpcodes + ^self subclassResponsibility! Item was added: + ----- Method: CogAbstractInstruction class>>unimplementedOpcodes (in category 'verification') ----- + unimplementedOpcodes + "Check computeMaximumSize and dispatchConcretize for unimplemented opcodes." + "self subclasses collect: [:compiler| {compiler. compiler unimplementedOpcodes}]" + | opcodes cmsLiterals dcLiterals | + opcodes := CogRTLOpcodes opcodes, self specificOpcodes. + cmsLiterals := (self >> #computeMaximumSize) literals + select: [:l| l isVariableBinding] + thenCollect: [:l| l key]. + dcLiterals := (self >> #dispatchConcretize) literals + select: [:l| l isVariableBinding] + thenCollect: [:l| l key]. + ^Dictionary new + at: #computeMaximumSize put: (opcodes reject: [:opcode| cmsLiterals includes: opcode]); + at: #dispatchConcretize put: (opcodes reject: [:opcode| dcLiterals includes: opcode]); + yourself! Item was added: + ----- Method: CogAbstractInstruction class>>usedUnimplementedOpcodes (in category 'verification') ----- + usedUnimplementedOpcodes + "Check for uses of unimplemented opcodes" + "self subclasses collect: [:compiler| {compiler. compiler usedUnimplementedOpcodes}]" + | genericUnimplementedOpcodeBindings specificUnimplementedOpcodeBindings | + genericUnimplementedOpcodeBindings := Set new. + specificUnimplementedOpcodeBindings := Set new. + self unimplementedOpcodes do: + [:arrayOfOpcodes| + arrayOfOpcodes do: + [:opcode| + (self bindingOf: opcode) + ifNotNil: [:b| specificUnimplementedOpcodeBindings add: b] + ifNil: [genericUnimplementedOpcodeBindings add: (CogRTLOpcodes bindingOf: opcode)]]]. + ^ { (SystemNavigation new allCallsOn: genericUnimplementedOpcodeBindings localToPackage: #VMMaker) + inject: Set new + into: [:them :methodRef| "These should be in Cogit's abstract instructions category" + them + addAll: (SystemNavigation new allCallsOn: methodRef method selector localToPackage: #VMMaker); + yourself]. + SystemNavigation new allCallsOn: specificUnimplementedOpcodeBindings localToPackage: #VMMaker }! Item was added: + ----- Method: CogIA32Compiler class>>specificOpcodes (in category 'verification') ----- + specificOpcodes + "Answer the processor-specific opcodes for this class. + They're all in an Array literal in the initialize method." + ^(self class >> #initialize) literals detect: [:l| l isArray and: [l includes: #LOCK]]! Item was changed: ----- Method: CogIA32Compiler>>computeMaximumSize (in category 'generate machine code') ----- computeMaximumSize "Compute the maximum size for each opcode. This allows jump offsets to be determined, provided that all backward branches are long branches." "N.B. The ^maxSize := N forms are to get around the compiler's long branch limits which are exceeded when each case jumps around the otherwise." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^maxSize := 0]. [AlignmentNops] -> [^maxSize := (operands at: 0) - 1]. [Fill16] -> [^maxSize := 2]. [Fill32] -> [^maxSize := 4]. [FillFromWord] -> [^maxSize := 4]. [Nop] -> [^maxSize := 1]. "Specific Control/Data Movement" [CDQ] -> [^maxSize := 1]. [IDIVR] -> [^maxSize := 2]. [IMULRR] -> [^maxSize := 3]. [CPUID] -> [^maxSize := 2]. [CMPXCHGAwR] -> [^maxSize := 7]. [CMPXCHGMwrR] -> [^maxSize := 8]. [LFENCE] -> [^maxSize := 3]. [MFENCE] -> [^maxSize := 3]. [SFENCE] -> [^maxSize := 3]. [LOCK] -> [^maxSize := 1]. [XCHGAwR] -> [^maxSize := 6]. [XCHGMwrR] -> [^maxSize := 7]. [XCHGRR] -> [^maxSize := 2]. "Control" [Call] -> [^maxSize := 5]. [JumpR] -> [^maxSize := 2]. [Jump] -> [self resolveJumpTarget. ^maxSize := 5]. [JumpLong] -> [self resolveJumpTarget. ^maxSize := 5]. [JumpZero] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpNonZero] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpNegative] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpNonNegative] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpOverflow] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpNoOverflow] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpCarry] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpNoCarry] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpLess] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpGreaterOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpGreater] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpLessOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpBelow] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpAboveOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpAbove] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpBelowOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpLongZero] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpLongNonZero] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPNotEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPLess] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPGreaterOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPGreater] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPLessOrEqual] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPOrdered] -> [self resolveJumpTarget. ^maxSize := 6]. [JumpFPUnordered] -> [self resolveJumpTarget. ^maxSize := 6]. [RetN] -> [^maxSize := (operands at: 0) = 0 ifTrue: [1] ifFalse: [3]]. "Arithmetic" [AddCqR] -> [^maxSize := (self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [(self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]]. [AndCqR] -> [^maxSize := (self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [(self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]]. [CmpCqR] -> [^maxSize := (self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [(self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]]. [OrCqR] -> [^maxSize := (self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [(self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]]. [SubCqR] -> [^maxSize := (self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [(self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]]. [AddCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]. + [AndCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX + ifTrue: [5] + ifFalse: [6]]. [CmpCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]. + [OrCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX + ifTrue: [5] + ifFalse: [6]]. [SubCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]. [XorCwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]. [AddRR] -> [^maxSize := 2]. [AndRR] -> [^maxSize := 2]. [CmpRR] -> [^maxSize := 2]. [OrRR] -> [^maxSize := 2]. [XorRR] -> [^maxSize := 2]. [SubRR] -> [^maxSize := 2]. [NegateR] -> [^maxSize := 2]. [LoadEffectiveAddressMwrR] -> [^maxSize := ((self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [6]) + ((self concreteRegister: (operands at: 1)) = ESP ifTrue: [1] ifFalse: [0])]. [LogicalShiftLeftCqR] -> [^maxSize := (operands at: 0) = 1 ifTrue: [2] ifFalse: [3]]. [LogicalShiftRightCqR] -> [^maxSize := (operands at: 0) = 1 ifTrue: [2] ifFalse: [3]]. [ArithmeticShiftRightCqR] -> [^maxSize := (operands at: 0) = 1 ifTrue: [2] ifFalse: [3]]. [LogicalShiftLeftRR] -> [self computeShiftRRSize]. [LogicalShiftRightRR] -> [self computeShiftRRSize]. [ArithmeticShiftRightRR] -> [self computeShiftRRSize]. [AddRdRd] -> [^maxSize := 4]. [CmpRdRd] -> [^maxSize := 4]. [SubRdRd] -> [^maxSize := 4]. [MulRdRd] -> [^maxSize := 4]. [DivRdRd] -> [^maxSize := 4]. [SqrtRd] -> [^maxSize := 4]. "Data Movement" [MoveCqR] -> [^maxSize := (operands at: 0) = 0 ifTrue: [2] ifFalse: [5]]. [MoveCwR] -> [^maxSize := 5]. [MoveRR] -> [^maxSize := 2]. + [MoveRdRd] -> [^maxSize := 4]. [MoveAwR] -> [^maxSize := (self concreteRegister: (operands at: 1)) = EAX ifTrue: [5] ifFalse: [6]]. [MoveRAw] -> [^maxSize := (self concreteRegister: (operands at: 0)) = EAX ifTrue: [5] ifFalse: [6]]. [MoveRMwr] -> [^maxSize := ((self isQuick: (operands at: 1)) ifTrue: [3] ifFalse: [6]) + ((self concreteRegister: (operands at: 2)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveRdM64r] -> [^maxSize := ((self isQuick: (operands at: 1)) ifTrue: [5] ifFalse: [8]) + ((self concreteRegister: (operands at: 2)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveMbrR] -> [^maxSize := ((self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [6]) + ((self concreteRegister: (operands at: 1)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveRMbr] -> [^maxSize := ((self isQuick: (operands at: 1)) ifTrue: [3] ifFalse: [6]) + ((self concreteRegister: (operands at: 2)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveM16rR] -> [^maxSize := ((self isQuick: (operands at: 0)) ifTrue: [4] ifFalse: [7]) + ((self concreteRegister: (operands at: 1)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveM64rRd] -> [^maxSize := ((self isQuick: (operands at: 0)) ifTrue: [5] ifFalse: [8]) + ((self concreteRegister: (operands at: 1)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveMwrR] -> [^maxSize := ((self isQuick: (operands at: 0)) ifTrue: [3] ifFalse: [6]) + ((self concreteRegister: (operands at: 1)) = ESP ifTrue: [1] ifFalse: [0])]. [MoveXbrRR] -> [self assert: (self concreteRegister: (operands at: 0)) ~= ESP. ^maxSize := (self concreteRegister: (operands at: 1)) = EBP ifTrue: [5] ifFalse: [4]]. [MoveXwrRR] -> [self assert: (self concreteRegister: (operands at: 0)) ~= ESP. ^maxSize := (self concreteRegister: (operands at: 1)) = EBP ifTrue: [4] ifFalse: [3]]. [MoveRXwrR] -> [self assert: (self concreteRegister: (operands at: 1)) ~= ESP. ^maxSize := (self concreteRegister: (operands at: 2)) = EBP ifTrue: [4] ifFalse: [3]]. [PopR] -> [^maxSize := 1]. [PushR] -> [^maxSize := 1]. [PushCw] -> [^maxSize := 5]. [PrefetchAw] -> [^maxSize := self hasSSEInstructions ifTrue: [7] ifFalse: [0]]. "Conversion" [ConvertRRd] -> [^maxSize := 4] }. ^0 "to keep C compiler quiet"! Item was added: + ----- Method: CogIA32Compiler>>concretizeAndCwR (in category 'generate machine code') ----- + concretizeAndCwR + "Will get inlined into concretizeAt: switch." + <inline: true> + | value reg | + value := operands at: 0. + reg := self concreteRegister: (operands at: 1). + reg = EAX ifTrue: + [machineCode + at: 0 put: 16r25; + at: 1 put: (value bitAnd: 16rFF); + at: 2 put: (value >> 8 bitAnd: 16rFF); + at: 3 put: (value >> 16 bitAnd: 16rFF); + at: 4 put: (value >> 24 bitAnd: 16rFF). + ^machineCodeSize := 5]. + machineCode + at: 0 put: 16r83; + at: 1 put: (self mod: ModReg RM: reg RO: 4); + at: 2 put: (value bitAnd: 16rFF); + at: 3 put: (value >> 8 bitAnd: 16rFF); + at: 4 put: (value >> 16 bitAnd: 16rFF); + at: 5 put: (value >> 24 bitAnd: 16rFF). + ^machineCodeSize := 6! Item was added: + ----- Method: CogIA32Compiler>>concretizeOrCwR (in category 'generate machine code') ----- + concretizeOrCwR + "Will get inlined into concretizeAt: switch." + <inline: true> + | value reg | + value := operands at: 0. + reg := self concreteRegister: (operands at: 1). + reg = EAX ifTrue: + [machineCode + at: 0 put: 16r0D; + at: 1 put: (value bitAnd: 16rFF); + at: 2 put: (value >> 8 bitAnd: 16rFF); + at: 3 put: (value >> 16 bitAnd: 16rFF); + at: 4 put: (value >> 24 bitAnd: 16rFF). + ^machineCodeSize := 5]. + machineCode + at: 0 put: 16r83; + at: 1 put: (self mod: ModReg RM: reg RO: 1); + at: 2 put: (value bitAnd: 16rFF); + at: 3 put: (value >> 8 bitAnd: 16rFF); + at: 4 put: (value >> 16 bitAnd: 16rFF); + at: 5 put: (value >> 24 bitAnd: 16rFF). + ^machineCodeSize := 6! Item was changed: ----- Method: CogIA32Compiler>>dispatchConcretize (in category 'generate machine code') ----- dispatchConcretize "Attempt to generate concrete machine code for the instruction at address. This is the inner dispatch of concretizeAt: actualAddress which exists only to get around the branch size limits in the SqueakV3 (blue book derived) bytecode set." opcode caseOf: { "Noops & Pseudo Ops" [Label] -> [^self concretizeLabel]. [AlignmentNops] -> [^self concretizeAlignmentNops]. [Fill16] -> [^self concretizeFill16]. [Fill32] -> [^self concretizeFill32]. [FillFromWord] -> [^self concretizeFillFromWord]. [Nop] -> [^self concretizeNop]. "Specific Control/Data Movement" [CDQ] -> [^self concretizeCDQ]. [IDIVR] -> [^self concretizeIDIVR]. [IMULRR] -> [^self concretizeMulRR]. [CPUID] -> [^self concretizeCPUID]. [CMPXCHGAwR] -> [^self concretizeCMPXCHGAwR]. [CMPXCHGMwrR] -> [^self concretizeCMPXCHGMwrR]. [LFENCE] -> [^self concretizeFENCE: 5]. [MFENCE] -> [^self concretizeFENCE: 6]. [SFENCE] -> [^self concretizeFENCE: 7]. [LOCK] -> [^self concretizeLOCK]. [XCHGAwR] -> [^self concretizeXCHGAwR]. [XCHGMwrR] -> [^self concretizeXCHGMwrR]. [XCHGRR] -> [^self concretizeXCHGRR]. "Control" [Call] -> [^self concretizeCall]. [JumpR] -> [^self concretizeJumpR]. [JumpLong] -> [^self concretizeJumpLong]. [JumpLongZero] -> [^self concretizeConditionalJumpLong: 16r4]. [JumpLongNonZero] -> [^self concretizeConditionalJumpLong: 16r5]. [Jump] -> [^self concretizeJump]. "Table B-1 Intel® 64 and IA-32 Architectures Software Developer's Manual Volume 1: Basic Architecture" [JumpZero] -> [^self concretizeConditionalJump: 16r4]. [JumpNonZero] -> [^self concretizeConditionalJump: 16r5]. [JumpNegative] -> [^self concretizeConditionalJump: 16r8]. [JumpNonNegative] -> [^self concretizeConditionalJump: 16r9]. [JumpOverflow] -> [^self concretizeConditionalJump: 16r0]. [JumpNoOverflow] -> [^self concretizeConditionalJump: 16r1]. [JumpCarry] -> [^self concretizeConditionalJump: 16r2]. [JumpNoCarry] -> [^self concretizeConditionalJump: 16r3]. [JumpLess] -> [^self concretizeConditionalJump: 16rC]. [JumpGreaterOrEqual] -> [^self concretizeConditionalJump: 16rD]. [JumpGreater] -> [^self concretizeConditionalJump: 16rF]. [JumpLessOrEqual] -> [^self concretizeConditionalJump: 16rE]. [JumpBelow] -> [^self concretizeConditionalJump: 16r2]. [JumpAboveOrEqual] -> [^self concretizeConditionalJump: 16r3]. [JumpAbove] -> [^self concretizeConditionalJump: 16r7]. [JumpBelowOrEqual] -> [^self concretizeConditionalJump: 16r6]. [JumpFPEqual] -> [^self concretizeConditionalJump: 16r4]. [JumpFPNotEqual] -> [^self concretizeConditionalJump: 16r5]. [JumpFPLess] -> [^self concretizeConditionalJump: 16r2]. [JumpFPGreaterOrEqual] -> [^self concretizeConditionalJump: 16r3]. [JumpFPGreater] -> [^self concretizeConditionalJump: 16r7]. [JumpFPLessOrEqual] -> [^self concretizeConditionalJump: 16r6]. [JumpFPOrdered] -> [^self concretizeConditionalJump: 16rB]. [JumpFPUnordered] -> [^self concretizeConditionalJump: 16rA]. [RetN] -> [^self concretizeRetN]. "Arithmetic" [AddCqR] -> [^self concretizeAddCqR]. [AddCwR] -> [^self concretizeAddCwR]. [AddRR] -> [^self concretizeAddRR]. [AddRdRd] -> [^self concretizeSEE2OpRdRd: 16r58]. [AndCqR] -> [^self concretizeAndCqR]. + [AndCwR] -> [^self concretizeAndCwR]. [AndRR] -> [^self concretizeAndRR]. [CmpCqR] -> [^self concretizeCmpCqR]. [CmpCwR] -> [^self concretizeCmpCwR]. [CmpRR] -> [^self concretizeCmpRR]. [CmpRdRd] -> [^self concretizeCmpRdRd]. [DivRdRd] -> [^self concretizeSEE2OpRdRd: 16r5E]. [MulRdRd] -> [^self concretizeSEE2OpRdRd: 16r59]. [OrCqR] -> [^self concretizeOrCqR]. + [OrCwR] -> [^self concretizeOrCwR]. [OrRR] -> [^self concretizeOrRR]. [SubCqR] -> [^self concretizeSubCqR]. [SubCwR] -> [^self concretizeSubCwR]. [SubRR] -> [^self concretizeSubRR]. [SubRdRd] -> [^self concretizeSEE2OpRdRd: 16r5C]. [SqrtRd] -> [^self concretizeSqrtRd]. [XorCwR] -> [^self concretizeXorCwR]. [XorRR] -> [^self concretizeXorRR]. [NegateR] -> [^self concretizeNegateR]. [LoadEffectiveAddressMwrR] -> [^self concretizeLoadEffectiveAddressMwrR]. [ArithmeticShiftRightCqR] -> [^self concretizeArithmeticShiftRightCqR]. [LogicalShiftRightCqR] -> [^self concretizeLogicalShiftRightCqR]. [LogicalShiftLeftCqR] -> [^self concretizeLogicalShiftLeftCqR]. [ArithmeticShiftRightRR] -> [^self concretizeArithmeticShiftRightRR]. [LogicalShiftLeftRR] -> [^self concretizeLogicalShiftLeftRR]. "Data Movement" [MoveCqR] -> [^self concretizeMoveCqR]. [MoveCwR] -> [^self concretizeMoveCwR]. [MoveRR] -> [^self concretizeMoveRR]. [MoveAwR] -> [^self concretizeMoveAwR]. [MoveRAw] -> [^self concretizeMoveRAw]. [MoveMbrR] -> [^self concretizeMoveMbrR]. [MoveRMbr] -> [^self concretizeMoveRMbr]. [MoveM16rR] -> [^self concretizeMoveM16rR]. [MoveM64rRd] -> [^self concretizeMoveM64rRd]. [MoveMwrR] -> [^self concretizeMoveMwrR]. [MoveXbrRR] -> [^self concretizeMoveXbrRR]. [MoveXwrRR] -> [^self concretizeMoveXwrRR]. [MoveRXwrR] -> [^self concretizeMoveRXwrR]. [MoveRMwr] -> [^self concretizeMoveRMwr]. [MoveRdM64r] -> [^self concretizeMoveRdM64r]. [PopR] -> [^self concretizePopR]. [PushR] -> [^self concretizePushR]. [PushCw] -> [^self concretizePushCw]. [PrefetchAw] -> [^self concretizePrefetchAw]. "Conversion" [ConvertRRd] -> [^self concretizeConvertRRd] }! Item was added: + ----- Method: CogRTLOpcodes class>>opcodes (in category 'accessing') ----- + opcodes + "CogRTLOpcodes opcodes" + "CogRTLOpcodes opcodes select: + [:opcode| + (Cogit organization listAtCategoryNamed: #'abstract instructions') noneSatisfy: + [:s| + (Cogit compiledMethodAt: s) literals anySatisfy: + [:l| + l isVariableBinding and: [l key = opcode]]]]" + ^(classPool keys reject: + [:k| + (#('First' 'Last' 'DPFP') anySatisfy: [:prefix| k beginsWith: prefix]) + or: [#('Reg' 'Min' 'Max') anySatisfy: [:postfix| k endsWith: postfix]]]) asArray sort!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2012