Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

When did it become a good idea for selected text to be enclosed by () instead of replaced by 9 ?
by tim Rowledge 06 Nov '19

06 Nov '19

In trying to see if anything had changed re WaveEditor etc I updated an image to update 16963. When I went to save this image a Squeak5.1-16963… I selected the last thre digits of the prior name (Squeak5.1-16549…) intending to type 963. Imagine my surprise - nay, alarm! - when I got ‘Squeak5.1-16(963) instead. Oh my, I said to myself, what has Pooh done now. As best I can work out this is a result of the change in TextEditor>enclose: that added ‘9’ some time ago (and which did not affect me since I normally turn off the annoying enclose stuff in preferences) combined with a more recent change to TextEditor>dispatchOnKeyboardEvent: wherein a use of TextEditor>enclose: was added near the end. I see two obviously related Preferences for enclosing text. I see this as a dangerous thing, because multiple preferences interacting on the same issue can cause chaos, not to say confusion. And every time a preference is added it is yet another sheaf of potential problems to test. So, yes, I can turn it off easily enough. But how could it ever be unsurprising to a user to get a(bc)d instead of the expected a9d ? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Fell out of the family tree.

6 6

Context>>#tempNames can raise Syntax Error
by Fabio Niephaus 04 Nov '19

04 Nov '19

Hi all, While debugging a failing Seaside test on Squeak trunk (see [1]), I learned that Context>>#tempNames can raise a syntax error. Here's a repro doIt: `Context allInstances collect: [:e | e tempNames]` Anyone willing to look into this? When I try to debug the "calling process", my image freezes... Cheers, Fabio [1] https://travis-ci.org/SeasideSt/Seaside/jobs/578335182#L2733

2 1

The Trunk: System-mt.1093.mcz
by commits＠source.squeak.org 30 Oct '19

30 Oct '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1093.mcz ==================== Summary ==================== Name: System-mt.1093 Author: mt Time: 17 September 2019, 12:10:14.798406 pm UUID: 5eb2c78e-ce42-654d-b764-57fc1e4d0521 Ancestors: System-mt.1092 Refactors process debugging in general, which makes MVC debugging work again: - adds MorphicDebugger and MVCDebugger as subclasses of Debugger to untangle debugging for those different GUI frameworks - removes the intermediate role of UIManager for debugging purposes -- focus on Project, (Standard)ToolSet, and Process - treat unhandled warnings the same as unhandled errors, which is through the current ToolSet - let SyntaxError tool use tool builder - clarify #handle* and #debug* methods in ToolSet's 'debugging' category - adds comments to ToolSet and StandardToolSet =============== Diff against System-mt.1092 =============== Item was changed: + ----- Method: Project>>addDeferredUIMessage: (in category 'scheduling & debugging') ----- - ----- Method: Project>>addDeferredUIMessage: (in category 'scheduling') ----- addDeferredUIMessage: valuableObject "Arrange for valuableObject to be evaluated at a time when the user interface is in a coherent state." self subclassResponsibility! Item was removed: - ----- Method: Project>>debugMethod:forReceiver:inContext: (in category 'debugging') ----- - debugMethod: aCompiledMethod forReceiver: anObject inContext: aContextOrNil - "Just execute the method and return the result. We cannot know how interactive debugging works for arbitrary projects." - - ^ aCompiledMethod - valueWithReceiver: anObject - arguments: (aContextOrNil - ifNil: [#()] - ifNotNil: [{aContextOrNil}])! Item was added: + ----- Method: Project>>debuggerClass (in category 'scheduling & debugging') ----- + debuggerClass + + ^ self subclassResponsibility! Item was changed: + ----- Method: Project>>interruptName: (in category 'scheduling & debugging') ----- - ----- Method: Project>>interruptName: (in category 'debugging') ----- interruptName: labelString "Create a Notifier on the active scheduling process with the given label." ^ self subclassResponsibility ! Item was changed: + ----- Method: Project>>interruptName:preemptedProcess: (in category 'scheduling & debugging') ----- - ----- Method: Project>>interruptName:preemptedProcess: (in category 'debugging') ----- interruptName: labelString preemptedProcess: theInterruptedProcess "Create a Notifier on the active scheduling process with the given label." ^ self subclassResponsibility ! Item was added: + ----- Method: Project>>syntaxError: (in category 'scheduling & debugging') ----- + syntaxError: aSyntaxErrorNotification + + ^ ToolSet debugSyntaxError: aSyntaxErrorNotification! Item was changed: ----- Method: SmalltalkImage>>handleUserInterrupt (in category 'miscellaneous') ----- handleUserInterrupt Preferences cmdDotEnabled ifTrue: + [[ToolSet handleUserInterruptRequest: 'User Interrupt'] fork] - [[Project current interruptName: 'User Interrupt'] fork] ! Item was changed: ----- Method: SyntaxErrorNotification>>defaultAction (in category '*System-exceptionDescription') ----- defaultAction + ^ToolSet handleSyntaxError: self! - ^ToolSet debugSyntaxError: self! Item was removed: - ----- Method: ToolSet class>>debug:context:label:contents:fullView: (in category 'debugging') ----- - debug: aProcess context: aContext label: aString contents: contents fullView: aBool - "Open a debugger on the given process and context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[Processor terminateActive]. - ^self]. - ^self default debug: aProcess context: aContext label: aString contents: contents fullView: aBool! Item was added: + ----- Method: ToolSet class>>debugActiveProcessContext:label:contents: (in category 'debugging - convenience') ----- + debugActiveProcessContext: aContext label: aString contents: contents + + ^ self + debugProcess: Processor activeProcess + context: aContext + label: aString + contents: contents + fullView: false! Item was removed: - ----- Method: ToolSet class>>debugContext:label:contents: (in category 'debugging') ----- - debugContext: aContext label: aString contents: contents - "Open a debugger on the given context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[Processor terminateActive]. - ^self]. - ^self default debugContext: aContext label: aString contents: contents! Item was removed: - ----- Method: ToolSet class>>debugError: (in category 'debugging') ----- - debugError: anError - "Handle an otherwise unhandled error" - self default ifNil:[ | ctx | - Smalltalk - logSqueakError: anError description - inContext: (ctx := anError signalerContext) . - self inform: (anError description, String cr, ctx shortStack). - ^anError return]. - ^self default debugError: anError! Item was added: + ----- Method: ToolSet class>>debugInterruptedProcess:label: (in category 'debugging') ----- + debugInterruptedProcess: aSuspendedProcess label: aString + "Open a debugger on the given process, which is already suspended." + + ^ self default + ifNil: [(self confirm: 'Debugger request -- proceed?') ifFalse:[aSuspendedProcess terminate]] + ifNotNil: [:ts | ts debugInterruptedProcess: aSuspendedProcess label: aString]! Item was changed: ----- Method: ToolSet class>>debugMethod:forReceiver:inContext: (in category 'debugging') ----- debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext + ^ self default + ifNil: [ + self inform: 'Cannot debug method. It will just be executed.'. + aCompiledMethod + valueWithReceiver: anObject + arguments: (aContext ifNil: [#()] ifNotNil: [{aContext}])] + ifNotNil: [:ts | ts debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext]! - self default ifNil:[^ self inform: 'Cannot debug method.']. - ^self default debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext - ! Item was added: + ----- Method: ToolSet class>>debugProcess:context:label:contents:fullView: (in category 'debugging') ----- + debugProcess: aProcess context: aContext label: aString contents: contents fullView: aBool + "Open a debugger on the given process, which might be active, suspended, or terminated." + + ^ self default + ifNil: [(self confirm: 'Debugger request -- proceed?') ifFalse: [Processor terminateActive]] + ifNotNil: [:ts | ts debugProcess: aProcess context: aContext label: aString contents: contents fullView: aBool]! Item was changed: ----- Method: ToolSet class>>debugSyntaxError: (in category 'debugging') ----- + debugSyntaxError: aSyntaxErrorNotification + "Opens a tool to let the user correct the syntax error, which then resumes the compiler process." + + ^ self default + ifNil: [Project uiManager edit: aSyntaxErrorNotification errorCode label: 'Syntax Error (read only)'] + ifNotNil: [:ts | ts debugSyntaxError: aSyntaxErrorNotification]! - debugSyntaxError: anError - "Handle a syntax error" - self default ifNil:[^self debugError: anError]. "handle as usual error" - ^self default debugSyntaxError: anError! Item was added: + ----- Method: ToolSet class>>handleError: (in category 'debugging - handlers') ----- + handleError: anError + "No exception handler caught the given error. Let the user handle that error through an interactive tool such as a debugger. + + THE ACTIVE PROCESS *IS* WHERE THE ERROR HAPPENED." + + ^ self default + ifNil: [ | ctx | + Smalltalk + logSqueakError: anError description + inContext: (ctx := anError signalerContext) . + self inform: (anError description, String cr, ctx shortStack). + anError return] + ifNotNil: [:ts | ts handleError: anError]! Item was added: + ----- Method: ToolSet class>>handleSyntaxError: (in category 'debugging - handlers') ----- + handleSyntaxError: anError + "A syntax error (notification) occurred while parsing and compiling source code. Usually, the compiling process suspends until the syntax error gets corrected. + + THE ACTIVE PROCESS *IS* THAT COMPILER PROCESS." + + ^ self default + ifNil: [self handleError: anError] + ifNotNil: [:ts | ts handleSyntaxError: anError]! Item was added: + ----- Method: ToolSet class>>handleUserInterruptRequest: (in category 'debugging - handlers') ----- + handleUserInterruptRequest: aString + "The user wants to interrupt a process, which might be unresponsive, to debug it. + + THE ACTIVE PROCESS *IS* A HELPER PROCESS with a priority higher than the preempted one. See EventSensor >> #userInterruptWatcher." + + ^ self default + ifNil: [self inform: 'No handler for user interrupts found.'] + ifNotNil: [:ts | ts handleUserInterruptRequest: aString]! Item was added: + ----- Method: ToolSet class>>handleWarning: (in category 'debugging - handlers') ----- + handleWarning: aWarning + "No exception handler caught the given warning. Let the user handle that warning through an interactive tool such as a debugger. + + THE ACTIVE PROCESS *IS* WHERE THE WARNING HAPPENED." + + ^ self default + ifNil: [ + self inform: (aWarning messageText, String cr, aWarning signalerContext shortStack). + aWarning resume] + ifNotNil: [:ts | ts handleWarning: aWarning]! Item was removed: - ----- Method: ToolSet class>>interrupt:label: (in category 'debugging') ----- - interrupt: aProcess label: aString - "Open a debugger on the given process and context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[aProcess terminate]. - ^self]. - ^self default interrupt: aProcess label: aString! Item was changed: ----- Method: UnhandledError>>defaultAction (in category '*System-priv handling') ----- defaultAction "The current computation is terminated. The cause of the error should be logged or reported to the user. If the program is operating in an interactive debugging environment the computation should be suspended and the debugger activated." + ^ToolSet handleError: self exception! - ^ToolSet debugError: self exception! Item was changed: ----- Method: UnhandledWarning>>defaultAction (in category '*System-priv handling') ----- defaultAction + ^ ToolSet handleWarning: self exception! - ^ ToolSet - debugContext: self exception signalerContext - label: 'Warning' - contents: self exception messageText , '\\Select Proceed to continue, or close this window to cancel the operation.' withCRs! Item was changed: ----- Method: WrappedBreakpoint>>run:with:in: (in category 'evaluation') ----- run: aSelector with: anArray in: aReceiver | process | process := Process forContext: (Context sender: thisContext sender receiver: aReceiver method: method arguments: anArray) priority: Processor activeProcess priority. ToolSet + debugProcess: process - debug: process context: process suspendedContext label: 'Breakpoint in ' , method methodClass name , '>>#' , method selector contents: nil fullView: true. Project current spawnNewProcessIfThisIsUI: Processor activeProcess. thisContext swapSender: nil. Processor activeProcess terminate!

6 26

The Trunk: Morphic-mt.1514.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1514.mcz ==================== Summary ==================== Name: Morphic-mt.1514 Author: mt Time: 5 September 2019, 2:36:47.777837 pm UUID: 49f63b40-72ce-c447-9fb0-9400ea43fab2 Ancestors: Morphic-mt.1513, Morphic-ct.1501 Merges Morphic-ct.1500. and 1501. Can't we just filter for #isAlphaNumeric? Do we need parentheses etc.? Would be more readable than ">= 32". I also do not think that #caseOf: helps much in terms of readability. ;-) =============== Diff against Morphic-mt.1513 =============== Item was changed: ----- Method: MenuMorph>>handleFiltering: (in category 'keystroke helpers') ----- handleFiltering: evt | matchString | matchString := self valueOfProperty: #matchString ifAbsentPut: [ String new ]. + matchString := true + caseOf: { + [ evt keyCharacter = Character backspace ] -> + [ matchString isEmpty + ifTrue: [ matchString ] + ifFalse: [ matchString allButLast ] ]. + [ evt keyValue >= 32 ] -> + [ matchString , evt keyCharacter ] } + otherwise: [ matchString ]. - matchString := evt keyValue = 8 " Character backspace asciiValue " - ifTrue: [ - matchString isEmpty - ifTrue: [ matchString ] - ifFalse: [ matchString allButLast ] ] - ifFalse: [ - matchString copyWith: evt keyCharacter ]. self setProperty: #matchString toValue: matchString. self displayFiltered: evt!

6 7

Etoys infested by deprecation warnings
by Nicola Mingotti 25 Oct '19

25 Oct '19

Hi, This evening I learnt the basic of Etoys doing the "Falling ellipse" example from the book "Squeak - Object-Oriented Design with Multimedia Applications" (Guzdial pg.164-172). Problem. There are so many deprecation warnings going through this simple exercise (in Squeak-5.2 #update 18232) that only a highly motivated person would be patient enough to kill/ignore all of them. For the moment I am not able to fix it myself, better I can do is to signal you the issue;) bye Nicola

6 12

Give debuggers more space ... :-)
by Marcel Taeumel 23 Oct '19

23 Oct '19

Hi, all! May I add more spaces to Context >> #printOn:? ... and a "#" in front of the selector ... Best, Marcel

12 26

The Inbox: Compiler-mt.410.mcz
by commits＠source.squeak.org 11 Oct '19

11 Oct '19

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-mt.410.mcz ==================== Summary ==================== Name: Compiler-mt.410 Author: mt Time: 4 September 2019, 5:03:52.834738 pm UUID: 7ff9d1f8-5f7a-4077-b11b-ede80ada7d13 Ancestors: Compiler-TraitTest.409 Fixes ifNil:ifNotNil: decompilation. Please review. - Only decompile ifNil:ifNotNil: if temps are not closured across nested blocks. This is the same behavior as #to:(by:)do:, which does not restore #to:(by:)do: if the 'var' or 'limit' are in an outer (outer?) scope. Only relevant if programmers type the optimized source code themselves. - Note that I created a new method in DecompilerConstructor to pass 'tempReadCounts'. #to:(by:)do: is reconstructed in Decompiler, which already has access to 'tempReadCounts'. See Decompiler >> #jump:if: and #convertToDoLoop:. =============== Diff against Compiler-TraitTest.409 =============== Item was added: + ----- Method: AssignmentNode>>ifNilTemporary (in category 'private') ----- + ifNilTemporary + "(temp := object) == nil ifTrue: [...] ifFalse: [...]" + + ^ self variable! Item was added: + ----- Method: AssignmentNode>>ifNilValue (in category 'private') ----- + ifNilValue + "(temp := object) == nil ifTrue: [...] ifFalse: [...]" + + ^ self value! Item was changed: ----- Method: BlockNode>>printTemporaries:on:doPrior: (in category 'printing') ----- printTemporaries: tempSequence on: aStream doPrior: aBlock "Print any in-scope temporaries. If there are any evaluate aBlock prior to printing. Answer whether any temporaries were printed." | tempStream seen | tempSequence ifNil: [^false]. tempStream := (String new: 16) writeStream. "This is for the decompiler which canmot work out which optimized block a particular temp is local to and hence may produce diplicates as in expr ifTrue: [| aTemp | ...] ifFalse: [| aTemp | ...]" seen := Set new. tempSequence do: [:tempNode | tempNode isIndirectTempVector ifTrue: [tempNode remoteTemps do: [:tempVariableNode| (tempVariableNode scope >= 0 + and: [ + "This is for the deocmpiler which may create a block arg when converting + a ifTrue:ifFalse: into a ifNil:ifNotNil: but won't remove it from temporaries" + tempVariableNode isBlockArg not + and: [(seen includes: tempNode key) not]]) ifTrue: - and: [(seen includes: tempNode key) not]) ifTrue: [tempStream space; nextPutAll: (seen add: tempVariableNode key)]]] ifFalse: [(tempNode scope >= -1 and: ["This is for the decompiler which may create a block arg when converting + a while into a to:do: but won't remove it from temporaries" - a while into a to:do: but won't remove it form temporaries" tempNode isBlockArg not and: [(seen includes: tempNode key) not]]) ifTrue: [tempStream space; nextPutAll: (seen add: tempNode key)]]]. tempStream position = 0 ifTrue: [^false]. aBlock value. aStream nextPut: $|; nextPutAll: tempStream contents; space; nextPut: $|. ^true! Item was changed: ----- Method: Decompiler>>jump:if: (in category 'instruction decoding') ----- jump: dist if: condition | savePc sign elsePc elseStart end cond ifExpr thenBlock elseBlock thenJump elseJump condHasValue isIfNil saveStack | lastJumpIfPcStack addLast: lastPc. stack last == CascadeFlag ifTrue: [^ [self case: dist] ensure: [lastJumpIfPcStack removeLast]]. elsePc := lastPc. elseStart := pc + dist. end := limit. "Check for bfp-jmp to invert condition. Don't be fooled by a loop with a null body." sign := condition. savePc := pc. self interpretJump ifNotNil: [:elseDist| (elseDist >= 0 and: [elseStart = pc]) ifTrue: [sign := sign not. elseStart := pc + elseDist]]. pc := savePc. ifExpr := stack removeLast. (isIfNil := stack size > 0 and: [stack last == IfNilFlag]) ifTrue: [stack removeLast]. saveStack := stack. stack := OrderedCollection new. thenBlock := self blockTo: elseStart. condHasValue := hasValue or: [isIfNil]. "ensure jump is within block (in case thenExpr returns)" thenJump := exit <= end ifTrue: [exit] ifFalse: [elseStart]. "if jump goes back, then it's a loop" thenJump < elseStart ifTrue: [| blockBody blockArgs savedReadCounts blockBodyReadCounts selector | "Must be a while loop... thenJump will jump to the beginning of the while expr. In the case of while's with a block in the condition, the while expr should include more than just the last expression: find all the statements needed by searching for the node with the relevant pc." stack := saveStack. savedReadCounts := tempReadCounts copy. pc := thenJump. blockBody := self statementsTo: elsePc. blockBodyReadCounts := tempReadCounts. savedReadCounts keysAndValuesDo: [:temp :count| blockBodyReadCounts at: temp put: (blockBodyReadCounts at: temp) - count]. tempReadCounts := savedReadCounts. "discard unwanted statements from block" blockBody size - 1 timesRepeat: [statements removeLast]. blockArgs := thenBlock statements = constructor codeEmptyBlock statements ifTrue: [#()] ifFalse: [{ thenBlock }]. selector := blockArgs isEmpty ifTrue: [sign ifTrue: [#whileFalse] ifFalse: [#whileTrue]] ifFalse: [sign ifTrue: [#whileFalse:] ifFalse: [#whileTrue:]]. statements addLast: (constructor codeMessage: (constructor codeBlock: blockBody returns: false) selector: (constructor codeSelector: selector code: #macro) arguments: blockArgs). pc := elseStart. selector == #whileTrue: ifTrue: [self convertToDoLoop: blockBodyReadCounts]] ifFalse: ["Must be a conditional..." elseBlock := self blockTo: thenJump. elseJump := exit. "if elseJump is backwards, it is not part of the elseExpr" elseJump < elsePc ifTrue: [pc := lastPc]. cond := isIfNil ifTrue: [constructor codeMessage: ifExpr ifNilReceiver selector: (constructor codeSelector: (sign ifTrue: [#ifNotNil:] ifFalse: [#ifNil:]) code: #macro) arguments: (Array with: thenBlock)] ifFalse: + [(sign ifTrue: [{elseBlock. thenBlock}] ifFalse: [{thenBlock. elseBlock}]) in: [:args | + (constructor + decodeIfNilWithReceiver: ifExpr + selector: #ifTrue:ifFalse: + arguments: args + tempReadCounts: tempReadCounts) ifNil: [ + constructor + codeMessage: ifExpr + selector: (constructor codeSelector: #ifTrue:ifFalse: code: #macro) + arguments: args]]]. - [constructor - codeMessage: ifExpr - selector: (constructor codeSelector: #ifTrue:ifFalse: code: #macro) - arguments: (sign - ifTrue: [{elseBlock. thenBlock}] - ifFalse: [{thenBlock. elseBlock}])]. stack := saveStack. condHasValue ifTrue: [stack addLast: cond] ifFalse: [statements addLast: cond]]. lastJumpIfPcStack removeLast.! Item was changed: ----- Method: DecompilerConstructor>>codeMessage:selector:arguments: (in category 'constructor') ----- codeMessage: receiver selector: selector arguments: arguments | symbol | symbol := selector key. (self decodeLiteralVariableValueDereferenceWithReceiver: receiver selector: symbol arguments: arguments) ifNotNil: [:node| ^node]. + - (self decodeIfNilWithReceiver: receiver - selector: symbol - arguments: arguments) ifNotNil: [:node| ^node]. ^MessageNode new receiver: receiver selector: selector arguments: arguments precedence: symbol precedence! Item was removed: - ----- Method: DecompilerConstructor>>decodeIfNilWithReceiver:selector:arguments: (in category 'constructor') ----- - decodeIfNilWithReceiver: receiver selector: selector arguments: arguments - receiver ifNil: [ ^nil ]. "For instance, when cascading" - selector == #ifTrue:ifFalse: - ifFalse: [^ nil]. - (receiver isMessage: #== - receiver: nil - arguments: [:argNode | argNode == NodeNil]) - ifFalse: [^ nil]. - ^ (MessageNode new - receiver: receiver - selector: (SelectorNode new key: #ifTrue:ifFalse: code: #macro) - arguments: arguments - precedence: 3) - noteSpecialSelector: #ifNil:ifNotNil:! Item was added: + ----- Method: DecompilerConstructor>>decodeIfNilWithReceiver:selector:arguments:tempReadCounts: (in category 'constructor') ----- + decodeIfNilWithReceiver: receiver selector: selector arguments: arguments tempReadCounts: tempReadCounts + + | node temp | + receiver ifNil: [ ^nil ]. "For instance, when cascading" + selector == #ifTrue:ifFalse: + ifFalse: [^ nil]. + + (receiver isMessage: #== + receiver: nil + arguments: [:argNode | argNode == NodeNil]) + ifFalse: [^ nil]. + + "Like #to:(by:)do:, support only local temps." + (((temp := receiver ifNilTemporary) isNil or: [tempReadCounts includesKey: temp]) or: [ + "What about 'object ifNotNil: [:o | ]', which as not read the blockArg? Just check that there is no remote vector pointing to it." + tempReadCounts keys noneSatisfy: [:otherTemp | + otherTemp isIndirectTempVector + ifTrue: [otherTemp remoteTemps anySatisfy: [:remoteTemp | remoteTemp name = temp name]] + ifFalse: [otherTemp name = temp name]] + ]) + ifFalse: [^ nil]. + + node := (MessageNode new + receiver: receiver + selector: (SelectorNode new key: #ifTrue:ifFalse: code: #macro) + arguments: arguments + precedence: 3). + + "Reconfigure the message node to #ifNil:ifNotNil:. Note that original* instance variables keep their optimized format. See MessageNode >> #printIfNilNotNil:indent:." + node + noteSpecialSelector: #ifNil:ifNotNil:; + selector: (SelectorNode new key: #ifNil:ifNotNil:). + + temp ifNil: [^ node]. + temp isTemp ifFalse: [^ node]. + + (arguments second isJust: NodeNil) not ifTrue: [ + temp beBlockArg. + node arguments: { + arguments first. + arguments second copy arguments: { temp }; yourself } ]. + + ^ node! Item was added: + ----- Method: MessageNode>>ifNilTemporary (in category 'private') ----- + ifNilTemporary + + ^ self ifNilReceiver ifNilTemporary! Item was changed: ----- Method: MessageNode>>printIfNilNotNil:indent: (in category 'printing') ----- printIfNilNotNil: aStream indent: level + (arguments first isJust: NodeNil) ifTrue: [ + self printReceiver: receiver ifNilReceiver ifNilValue on: aStream indent: level. + ^ self printKeywords: #ifNotNil: - self printReceiver: receiver ifNilReceiver on: aStream indent: level. - - (arguments first isJust: NodeNil) ifTrue: - [^ self printKeywords: #ifNotNil: arguments: { arguments second } on: aStream indent: level]. + + (arguments second isJust: NodeNil) ifTrue: [ + self printReceiver: receiver ifNilReceiver on: aStream indent: level. + ^ self printKeywords: #ifNil: - (arguments second isJust: NodeNil) ifTrue: - [^ self printKeywords: #ifNil: arguments: { arguments first } on: aStream indent: level]. + + self printReceiver: receiver ifNilReceiver ifNilValue on: aStream indent: level. ^ self printKeywords: #ifNil:ifNotNil: arguments: arguments on: aStream indent: level! Item was changed: ----- Method: MessageNode>>printWithClosureAnalysisIfNilNotNil:indent: (in category 'printing') ----- printWithClosureAnalysisIfNilNotNil: aStream indent: level + (arguments first isJust: NodeNil) ifTrue: [ + self printWithClosureAnalysisReceiver: receiver ifNilReceiver ifNilValue on: aStream indent: level. + ^ self printWithClosureAnalysisKeywords: #ifNotNil: - self printWithClosureAnalysisReceiver: receiver ifNilReceiver on: aStream indent: level. - - (arguments first isJust: NodeNil) ifTrue: - [^self printWithClosureAnalysisKeywords: #ifNotNil: arguments: { arguments second } on: aStream indent: level]. + + (arguments second isJust: NodeNil) ifTrue: [ + self printWithClosureAnalysisReceiver: receiver ifNilReceiver on: aStream indent: level. + ^ self printWithClosureAnalysisKeywords: #ifNil: - (arguments second isJust: NodeNil) ifTrue: - [^self printWithClosureAnalysisKeywords: #ifNil: arguments: { arguments first } on: aStream indent: level]. + + self printWithClosureAnalysisReceiver: receiver ifNilReceiver ifNilValue on: aStream indent: level. + ^ self printWithClosureAnalysisKeywords: #ifNil:ifNotNil: - ^self printWithClosureAnalysisKeywords: #ifNil:ifNotNil: arguments: arguments on: aStream indent: level! Item was added: + ----- Method: ParseNode>>ifNilTemporary (in category 'private') ----- + ifNilTemporary + + ^ nil! Item was added: + ----- Method: ParseNode>>ifNilValue (in category 'private') ----- + ifNilValue + + ^self! Item was changed: ----- Method: Parser>>parseCue:noPattern:ifFail: (in category 'public access') ----- parseCue: aCue noPattern: noPattern ifFail: aBlock "Answer a MethodNode for the argument, sourceStream, that is the root of a parse tree. Parsing is done with respect to the CompilationCue to resolve variables. Errors in parsing are reported to the cue's requestor; otherwise aBlock is evaluated. The argument noPattern is a Boolean that is true if the the sourceStream does not contain a method header (i.e., for DoIts)." | methNode repeatNeeded myStream s p subSelection | myStream := aCue sourceStream. [repeatNeeded := false. p := myStream position. s := myStream upToEnd. myStream position: p. + + doitFlag := noPattern. + failBlock:= aBlock. self encoder init: aCue notifying: self. self init: myStream cue: aCue failBlock: [^ aBlock value]. subSelection := self interactive and: [cue requestor selectionInterval = (p + 1 to: p + s size)]. - doitFlag := noPattern. - failBlock:= aBlock. [methNode := self method: noPattern context: cue context] on: ReparseAfterSourceEditing do: [ :ex | repeatNeeded := true. properties := nil. "Avoid accumulating pragmas and primitives Number" myStream := ex newSource ifNil: [subSelection ifTrue: [ReadStream on: cue requestor text string from: cue requestor selectionInterval first to: cue requestor selectionInterval last] ifFalse: [ReadStream on: cue requestor text string]] ifNotNil: [:src | myStream := src readStream]]. repeatNeeded] whileTrue: [encoder := self encoder class new]. methNode sourceText: s. ^methNode !

5 10

The Trunk: Tools-mt.895.mcz
by commits＠source.squeak.org 03 Oct '19

03 Oct '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.895.mcz ==================== Summary ==================== Name: Tools-mt.895 Author: mt Time: 26 September 2019, 5:31:06.240419 pm UUID: 8a9fb174-09f8-894c-8c5f-35a10699d7ec Ancestors: Tools-mt.894 In debuggers, use same kind of "add protocol" as in code browsers. =============== Diff against Tools-mt.894 =============== Item was changed: ----- Method: Debugger>>askForCategoryIn:default: (in category 'notifier support') ----- askForCategoryIn: aClass default: aString + + ^ (Project uiManager + chooseFromOrAddTo: (aClass allMethodCategoriesIntegratedThrough: Object) + lines: #() + title: 'Please provide a good category for the new method' translated) + ifNil: [aString] + ifNotNil: [:newCategory | newCategory ifEmpty: [aString]]! - | categories index category | - categories := OrderedCollection with: 'new ...'. - categories addAll: (aClass allMethodCategoriesIntegratedThrough: Object). - index := UIManager default - chooseFrom: categories - title: 'Please provide a good category for the new method!!' translated. - index = 0 ifTrue: [^ aString]. - category := index = 1 ifTrue: [UIManager default request: 'Enter category name:'] - ifFalse: [categories at: index]. - ^ category isEmpty ifTrue: [^ aString] ifFalse: [category]!

3 2

The Trunk: Morphic-mt.1547.mcz
by commits＠source.squeak.org 02 Oct '19

02 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1547.mcz ==================== Summary ==================== Name: Morphic-mt.1547 Author: mt Time: 29 September 2019, 7:05:40.322524 pm UUID: d35fe693-b8fc-574c-a20b-0b5ce37208ad Ancestors: Morphic-mt.1546, Morphic-ct.1505, Morphic-ct.1506, Morphic-ct.1507, Morphic-ct.1514, Morphic-ct.1527, Morphic-ct.1530, Morphic-ct.1533, Morphic-ct.1535, Morphic-ct.1536 Merge, merge, merge. :-) Morphic-ct.1505 - halo scale up in demo mode Morphic-ct.1506 - window icons scale up in demo mode Morphic-ct.1507 - bugfix open tool attached to mouse Morphic-ct.1514 - dialog code clean-up Morphic-ct.1527 - CollapsedMorph Morphic-ct.1530 - comments Morphic-ct.1533 - fix in MorphicProject (fillStyle) Morphic-ct.1535 - fix in MorphicProject (background) Morphic-ct.1536 - TextMorph constructors =============== Diff against Morphic-mt.1546 =============== Item was added: + ----- Method: CollapsedMorph class>>createReplacementFor:in: (in category 'instance creation') ----- + createReplacementFor: aMorph in: anOwner + + ^ self new + beReplacementFor: aMorph in: anOwner; + yourself! Item was changed: ----- Method: CollapsedMorph>>beReplacementFor: (in category 'collapse/expand') ----- beReplacementFor: aMorph + "Encapsulate aMorph with the CollapsedMorph and display the latter" + | itsWorld | - | itsWorld priorPosition | (itsWorld := aMorph world) ifNil: [^self]. + self beReplacementFor: aMorph in: itsWorld.! - uncollapsedMorph := aMorph. - - self setLabel: aMorph externalName. - aMorph delete. - itsWorld addMorphFront: self. - self collapseOrExpand. - (priorPosition := aMorph valueOfProperty: #collapsedPosition ifAbsent: [nil]) - ifNotNil: - [self position: priorPosition]. - ! Item was added: + ----- Method: CollapsedMorph>>beReplacementFor:in: (in category 'collapse/expand') ----- + beReplacementFor: aMorph in: anOwner + "Encapsulate aMorph with the CollapsedMorph and display the latter in anOwner" + + | priorPosition | + uncollapsedMorph := aMorph. + + self setLabel: aMorph externalName. + aMorph delete. + self privateOwner: anOwner. "lest RealEstateAgent fail at positioning me" + self collapseOrExpand. + anOwner addMorphFront: self. + (priorPosition := aMorph valueOfProperty: #collapsedPosition ifAbsent: [nil]) + ifNotNil: [self position: priorPosition].! Item was added: + ----- Method: CollapsedMorph>>centerWithWrappees: (in category 'adjusting') ----- + centerWithWrappees: aPoint + + self center: aPoint. + uncollapsedMorph center: aPoint.! Item was added: + ----- Method: CollapsedMorph>>uncollapsedMorph (in category 'accessing') ----- + uncollapsedMorph + + ^ uncollapsedMorph! Item was changed: ----- Method: DialogWindow>>exploreInvocation (in category 'running') ----- exploreInvocation + self exclusive: false. + (self findInvocationContext stack collect: #method) + explore! - | result context | - self exclusive: false. "We want to explore." - - result := OrderedCollection new. - context := self findInvocationContext. - - [context sender] whileNotNil: [ - result add: context method. - context := context sender]. - result add: context method. - - result explore.! Item was changed: ----- Method: HaloMorph>>addHandlesForWorldHalos (in category 'private') ----- addHandlesForWorldHalos "Add handles for world halos, like the man said" | box w | w := self world ifNil:[target world]. self removeAllMorphs. "remove old handles, if any" self bounds: target bounds. box := w bounds insetBy: self handleSize // 2. target addWorldHandlesTo: self box: box. Preferences uniqueNamesInHalos ifTrue: [innerTarget assureExternalName]. + self + addNameBeneath: ((box insetBy: (0@0 corner: 0@10)) + scaleBy: RealEstateAgent scaleFactor) + string: innerTarget externalName. - self addNameBeneath: (box insetBy: (0@0 corner: 0@10)) string: innerTarget externalName. growingOrRotating := false. self layoutChanged. self changed. ! Item was changed: ----- Method: HaloMorph>>basicBox (in category 'private') ----- basicBox + | minSide outset anExtent aBox w | - | aBox minSide anExtent w | minSide := 4 * self handleSize. + outset := 8 * RealEstateAgent scaleFactor. + anExtent := (self extent + self handleSize + outset) max: minSide asPoint. - anExtent := ((self width + self handleSize + 8) max: minSide) @ - ((self height + self handleSize + 8) max: minSide). aBox := Rectangle center: self center extent: anExtent. w := self world ifNil:[target outermostWorldMorph]. ^ w ifNil: [aBox] ifNotNil: [aBox intersect: (w viewBox insetBy: self handleSize // 2)] ! Item was changed: ----- Method: HaloMorph>>createHandleAt:color:iconName: (in category 'private') ----- createHandleAt: aPoint color: aColor iconName: iconName | bou handle | bou := Rectangle center: aPoint extent: self handleSize asPoint. Preferences alternateHandlesLook ifTrue: [handle := RectangleMorph newBounds: bou color: aColor. handle useRoundedCorners. self setColor: aColor toHandle: handle] ifFalse: [handle := EllipseMorph newBounds: bou color: aColor]. handle borderWidth: 0; wantsYellowButtonMenu: false. "" iconName isNil ifFalse: [| form | form := ScriptingSystem formAtKey: iconName. form isNil ifFalse: [| image | image := ImageMorph new. + image image: form scaleIconToDisplay. - image image: form. image color: aColor makeForegroundColor. image lock. handle addMorphCentered: image]]. "" ^ handle! Item was changed: ----- Method: HaloMorph>>handleSize (in category 'private') ----- handleSize + ^ (Preferences biggerHandles - ^ Preferences biggerHandles ifTrue: [30] + ifFalse: [16]) * RealEstateAgent scaleFactor! - ifFalse: [16]! Item was changed: ----- Method: Morph>>hResizing (in category 'layout-properties') ----- hResizing "Layout specific. This property describes how the receiver should be resized with respect to its owner and its children. Possible values are: #rigid - do not resize the receiver #spaceFill - resize to fill owner's available space + #shrinkWrap - resize to fit children - #shrinkWrap - resize to fit children " | props | props := self layoutProperties. ^props ifNil:[#rigid] ifNotNil:[props hResizing].! Item was changed: ----- Method: MorphicProject>>setAsBackground: (in category 'utilities') ----- setAsBackground: aFormOrColorOrFillStyle "Set aForm as a background image." | thisWorld newFill oldFill | + thisWorld := self world. - thisWorld := self currentWorld. oldFill := thisWorld fillStyle. thisWorld fillStyle: aFormOrColorOrFillStyle. newFill := thisWorld fillStyle. newFill rememberCommand: (Command new cmdWording: 'set background to a picture' translated; undoTarget: thisWorld selector: #fillStyle: argument: oldFill; redoTarget: thisWorld selector: #fillStyle: argument: newFill). + thisWorld setProperty: #hasCustomBackground toValue: true.! - thisWorld setProperty: #hasCustomBackground toValue: true. - ! Item was changed: ----- Method: MorphicProject>>setWorldBackground: (in category 'initialize') ----- setWorldBackground: force ((world hasProperty: #hasCustomBackground) and: [force not]) ifTrue: [^ self]. "If the user has a custom background, propagate it into the new project." ((Project current ~~ self and: [Project current isMorphic]) and: [Project current world hasProperty: #hasCustomBackground]) ifTrue: [ + world fillStyle: Project current world fillStyle copy. - world fillStyle: Project current world fillStyle. world setProperty: #hasCustomBackground toValue: true] ifFalse: [ world removeProperty: #hasCustomBackground. world fillStyle: (self userInterfaceTheme background ifNil: [self class defaultFill])].! Item was changed: ----- Method: PasteUpMorph>>setAsBackground: (in category 'visual properties') ----- setAsBackground: aFormOrColorOrFillStyle + | project | + (self outermostWorldMorph == self and: [(project := self project) isMorphic]) + ifTrue: [project setAsBackground: aFormOrColorOrFillStyle] - (self outermostWorldMorph == self and: [Project current isMorphic]) - ifTrue: [Project current setAsBackground: aFormOrColorOrFillStyle] ifFalse: [self fillStyle: aFormOrColorOrFillStyle].! Item was changed: ----- Method: SystemWindow>>createBox: (in category 'initialization') ----- createBox: aForm "create a button with a form to be used in the label area" | box | box := SystemWindowButton new. box color: Color transparent; target: self; useSquareCorners; borderWidth: 0; + labelGraphic: aForm scaleIconToDisplay; - labelGraphic: aForm; extent: self boxExtent. ^ box! Item was changed: ----- Method: SystemWindow>>justDroppedInto:event: (in category 'geometry') ----- justDroppedInto: aMorph event: anEvent isCollapsed ifTrue: [self position: ((self position max: 0@0) grid: 8@8). collapsedFrame := self bounds] ifFalse: [fullFrame := self bounds]. self beKeyWindow. self hasDropShadow: Preferences menuAppearance3d. "See #startDragFromLabel:." aMorph == self world ifTrue: [self assureLabelAreaVisible]. (Project uiManager openToolsAttachedToMouseCursor and: (self hasProperty: #initialDrop)) ifTrue: [ self removeProperty: #initialDrop. (self submorphs detect: [:m | m isKindOf: BottomRightGripMorph] ifNone: []) ifNotNil: [:grip | grip referencePoint: anEvent position; setProperty: #targetHadDropShadow toValue: true "See MorphicToolBuilder >> #open:". + self + hasDropShadow: false; + lookFocused. + anEvent hand newMouseFocus: grip.]]. - self hasDropShadow: false. - anEvent hand newMouseFocus: grip]]. ^super justDroppedInto: aMorph event: anEvent! Item was added: + ----- Method: TextMorph class>>string:fontName: (in category 'instance creation') ----- + string: aString fontName: aName + + ^ self + string: aString + fontName: aName + size: TextStyle defaultFont pixelSize! Item was added: + ----- Method: TextMorph class>>string:fontName:size: (in category 'instance creation') ----- + string: aString fontName: aName size: aSize + + ^ self + string: aString + fontName: aName + size: aSize + wrap: false "...because we don't know the initial width to wrap..." + ! Item was added: + ----- Method: TextMorph class>>string:fontName:size:wrap: (in category 'instance creation') ----- + string: aString fontName: aName size: aSize wrap: shouldWrap + + ^ self new + string: aString fontName: aName size: aSize wrap: shouldWrap; + yourself! Item was added: + ----- Method: TextMorph class>>string:size: (in category 'instance creation') ----- + string: aString size: pixelSize + + ^ self + string: aString + fontName: TextStyle defaultFont familyName + size: pixelSize! Item was changed: + ----- Method: TextMorph>>fontName:pointSize: (in category 'initialization') ----- - ----- Method: TextMorph>>fontName:pointSize: (in category 'accessing') ----- fontName: fontName pointSize: fontSize | newTextStyle | newTextStyle := ((TextStyle named: fontName asSymbol) ifNil: [ TextStyle default ]) copy. newTextStyle ifNil: [self error: 'font ', fontName, ' not found.']. textStyle := newTextStyle. text addAttribute: (TextFontChange fontNumber: (newTextStyle fontIndexOfPointSize: fontSize)). + self releaseParagraph.! - paragraph ifNotNil: [paragraph textStyle: newTextStyle]! Item was changed: + ----- Method: TextMorph>>fontName:size: (in category 'initialization') ----- - ----- Method: TextMorph>>fontName:size: (in category 'accessing') ----- fontName: fontName size: fontSize | newTextStyle | newTextStyle := ((TextStyle named: fontName asSymbol) ifNil: [ TextStyle default ]) copy. textStyle := newTextStyle. text addAttribute: (TextFontChange fontNumber: (newTextStyle fontIndexOfSize: fontSize)). + self releaseParagraph.! - paragraph ifNotNil: [paragraph textStyle: newTextStyle]! Item was changed: ----- Method: TextMorph>>string:fontName:size:wrap: (in category 'initialization') ----- string: aString fontName: aName size: aSize wrap: shouldWrap shouldWrap ifTrue: [self contentsWrapped: aString] + ifFalse: [self contentsAsIs: aString]. + - ifFalse: [self contents: aString]. self fontName: aName size: aSize!

5 5

The Trunk: Monticello-ul.702.mcz
by commits＠source.squeak.org 02 Oct '19

02 Oct '19

Levente Uzonyi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ul.702.mcz ==================== Summary ==================== Name: Monticello-ul.702 Author: ul Time: 23 September 2019, 5:42:41.889162 pm UUID: a4a352f6-efcd-41ce-b716-f490b49229bb Ancestors: Monticello-ul.701 - disable #useSharedWebClientInstance on Windows by default until the issue is resolved =============== Diff against Monticello-ul.701 =============== Item was changed: ----- Method: MCHttpRepository class>>useSharedWebClientInstance (in category 'preferences') ----- useSharedWebClientInstance <preference: 'Use shared WebClient instance' category: 'Monticello' description: 'When true, use a shared WebClient instance to speed up downloads from MCHttpRepositories. Requires WebClient to be present.' type: #Boolean> + ^UseSharedWebClientInstance ifNil: [ + "The is some issue on Windows, so don't use it there by default. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2019-September/threa… for details." + Smalltalk os platformName ~= 'Win32' ]! - ^UseSharedWebClientInstance ifNil: [ true ]!

4 3

← Newer
1
2
3
4
5
6
7
...
36
Older →

Jump to page: