Squeak-dev September 2019

squeak-dev@lists.squeakfoundation.org

38 participants
356 discussions

#syntaxHighlightingAsYouType
by Thiede, Christoph 02 Oct '19

02 Oct '19

Hi, I just found out that #syntaxHighlightingAsYouType has no senders. In my images, the preference is even turned off, but Shout remains active. Is this preference deprecated or would we want to honor it in PluggableTextMorphPlus >> #updateStyleNow? In case of the latter, how about #updateStyle (and other senders of #style: and #styleInBackgroundProcess:)? And another note: I am currently working with some really long methods which store hard-coded Forms etc., and each time I open one of them, my Browser hangs heavily for about a few minutes. (If I watch the source code in an unstyled Workspace, everything is fast as usual.) Thence I would still find it relevant to have an option to turn off Shout completely. And why can't we always style long texts in background, not only when loading? Could it be useful to introduce a certain treshold which if exceeded disables styling for a text in general? Best regards, Christoph

3 3

The Inbox: ShoutCore-ct.73.mcz
by commits＠source.squeak.org 02 Oct '19

02 Oct '19

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.73.mcz ==================== Summary ==================== Name: ShoutCore-ct.73 Author: ct Time: 28 September 2019, 11:31:09.24777 pm UUID: 27e05259-bafa-0749-827d-b54de84bb8d2 Ancestors: ShoutCore-ct.72 Fixes a bug in context-dependent styling, as described in [1]. Until proved otherwise, we cannot distinguish between args and tempvars via DebuggerMap, so shout-reparse the original context source up to the place where the provided context starts and access the active variables from the nested shout parser. (Minimal example to reproduce the old bug: Do it: [:x| [:z | (x*z) halt] value: 7] value: 6 And style [z] in the context of #halt - it was wrongly styled as a tempvar before.) [1] http://forum.world.st/Distinguishing-temp-vars-and-arguments-via-DebuggerMa… =============== Diff against ShoutCore-ct.72 =============== Item was added: + ----- Method: SHParserST80>>activeArguments (in category 'accessing') ----- + activeArguments + "Parsed arguments that are in the active scope" + ^ arguments! Item was added: + ----- Method: SHParserST80>>activeTemporaries (in category 'accessing') ----- + activeTemporaries + "Parsed temporaries that are in the active scope" + ^ temporaries! Item was changed: ----- Method: SHParserST80>>initializeInstanceVariables (in category 'parse support') ----- initializeInstanceVariables instanceVariables := classOrMetaClass ifNil: [ #() ] ifNotNil: [ classOrMetaClass allInstVarNames asArray ]. allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. sourcePosition := 1. arguments ifNil: [ arguments := OrderedCollection with: nil ] ifNotNil: [ arguments reset; addLast: nil ]. temporaries ifNil: [ temporaries := OrderedCollection with: nil ] ifNotNil: [ temporaries reset; addLast: nil ]. + context ifNotNil: [ self initializeVariablesFromContext ]. - context ifNotNil: [ - | contextArgumentCount contextVariableNames | - contextArgumentCount := context numArgs. - contextVariableNames := context tempNames asOrderedCollection. - contextArgumentCount > 0 ifTrue: [ - arguments at: 1 put: (contextVariableNames first: contextArgumentCount) ]. - contextArgumentCount < contextVariableNames size ifTrue: [ - temporaries at: 1 put: (contextVariableNames allButFirst: contextArgumentCount) ] ]. bracketDepth := 0. ranges ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] ifNotNil: [ ranges reset ]! Item was added: + ----- Method: SHParserST80>>initializeVariablesFromContext (in category 'parse support') ----- + initializeVariablesFromContext + + | contextSourcePcIndex contextSourceParser | + contextSourcePcIndex := (context debuggerMap + rangeForPC: context pc + in: context method + contextIsActiveContext: true "little white lie to work in every situation") + start. + contextSourceParser := self class new + classOrMetaClass: context method methodClass; + environment: self environment; + source: (context method getSource first: contextSourcePcIndex); + yourself. + contextSourceParser parse. + arguments at: 1 put: ((contextSourceParser activeArguments + reject: #isNil) gather: #yourself) asOrderedCollection. + temporaries at: 1 put: ((contextSourceParser activeTemporaries + reject: #isNil) gather: #yourself) asOrderedCollection.!

3 3

The Trunk: Morphic-mt.1549.mcz
by commits＠source.squeak.org 01 Oct '19

01 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1549.mcz ==================== Summary ==================== Name: Morphic-mt.1549 Author: mt Time: 30 September 2019, 11:19:38.88371 am UUID: 6bbc0287-72da-fe4c-889d-591c9bec9657 Ancestors: Morphic-mt.1548 Caches "fullList" in pluggable lists to speed up list filtering. Note that we have now two kinds of caches in PluggableListMorph: (1) inst-var access to "list" with invalidation/update via #getList and (2) the accessor #fullList. In the future, we should harmonize that design ... Since the addition of list filters, we forgot to treat inst-var access to "list" as a cache. There are way too many sends of #getFullList at the moment. So that new cache makes sense. =============== Diff against Morphic-mt.1548 =============== Item was changed: ScrollPane subclass: #PluggableListMorph + instanceVariableNames: 'list fullList getListSelector getListSizeSelector getListElementSelector getIndexSelector setIndexSelector keystrokeActionSelector autoDeselect lastKeystrokeTime lastKeystrokes lastClickTime doubleClickSelector handlesBasicKeys potentialDropRow hoverRow listMorph hScrollRangeCache keystrokePreviewSelector priorSelection getIconSelector getHelpSelector' - instanceVariableNames: 'list getListSelector getListSizeSelector getListElementSelector getIndexSelector setIndexSelector keystrokeActionSelector autoDeselect lastKeystrokeTime lastKeystrokes lastClickTime doubleClickSelector handlesBasicKeys potentialDropRow hoverRow listMorph hScrollRangeCache keystrokePreviewSelector priorSelection getIconSelector getHelpSelector' classVariableNames: 'ClearFilterAutomatically FilterableLists HighlightHoveredRow MenuRequestUpdatesSelection' poolDictionaries: '' category: 'Morphic-Pluggable Widgets'! !PluggableListMorph commentStamp: 'cmm 8/21/2011 23:37' prior: 0! When a PluggableListMorph is in focus, type in a letter (or several letters quickly) to go to the next item that begins with that letter (if FilterableLists is false). Special keys (up, down, home, etc.) are also supported.! Item was changed: ----- Method: PluggableListMorph>>getFullList (in category 'model access') ----- getFullList "The full, unfiltered list." + ^ fullList ifNil: [fullList := model perform: getListSelector]! - ^ model perform: getListSelector! Item was changed: ----- Method: PluggableListMorph>>updateList (in category 'updating') ----- updateList + | index | + fullList := nil. - "the list has changed -- update from the model" self listMorph listChanged. - self setScrollDeltas. index := self getCurrentSelectionIndex. self resetPotentialDropRow. self selectionIndex: (self uiIndexFor: index). !

3 2

The Trunk: Morphic-mt.1540.mcz
by commits＠source.squeak.org 01 Oct '19

01 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1540.mcz ==================== Summary ==================== Name: Morphic-mt.1540 Author: mt Time: 24 September 2019, 5:18:23.87286 pm UUID: a049a4c1-b81f-3b4e-8aa3-cb0ecad08561 Ancestors: Morphic-mt.1539 Complements Tools-mt.893: - more comments - some additional warnings for usability =============== Diff against Morphic-mt.1539 =============== Item was changed: ----- Method: MorphicDebugger class>>openDrawingErrors: (in category 'opening') ----- openDrawingErrors: errors + "Open debuggers for all different errors found. DO NOT suspend the active process because drawing errors got caught gracefully already to keep the system running. The debuggers are only for exploration." - "Open debuggers for all different errors found." self setErrorRecursion. errors do: [:processToLabel | + (self new process: processToLabel key context: processToLabel key suspendedContext) + errorWasInUIProcess: Processor activeProcess = Project current uiProcess; + openNotifierNoSuspendContents: nil label: processToLabel value]. - (MorphicDebugger new process: processToLabel key context: processToLabel key suspendedContext) - errorWasInUIProcess: Processor activeProcess = Project current uiProcess; - openNotifierContents: nil label: processToLabel value]. "Try to draw the debuggers or else there will be no chance to escape from this catch-drawing-error loop." Project current world displayWorld. self clearErrorRecursion.! Item was changed: ----- Method: MorphicDebugger class>>openInterrupt:onProcess: (in category 'opening') ----- openInterrupt: aString onProcess: interruptedProcess "Open a notifier in response to an interrupt. An interrupt occurs when the user types the interrupt key (cmd-. on Macs, ctrl-c or alt-. on other systems) or when the low-space watcher detects that memory is low." + | errorWasInUIProcess debugger message | - | errorWasInUIProcess debugger | <primitive: 19> "Simulation guard" + Processor activeProcess == Project current uiProcess + ifTrue: [^ self notify: 'You cannot interrupt from within the UI process. Use a helper process instead.\\This interrupt request will be aborted.' withCRs translated]. + errorWasInUIProcess := Project current spawnNewProcessIfThisIsUI: interruptedProcess. + debugger := self new. debugger process: interruptedProcess context: interruptedProcess suspendedContext. debugger externalInterrupt: true; errorWasInUIProcess: errorWasInUIProcess. + ((aString includesSubstring: 'Space') and: [aString includesSubstring: 'low']) + ifTrue: [ + "Space is low!! See SmalltalkImage >> #lowSpaceWatcher." + message := self lowSpaceChoices. + Preferences logDebuggerStackToFile ifTrue: [ + Smalltalk logError: aString inContext: debugger interruptedContext to: 'LowSpaceDebug.log']] + ifFalse: [ + Preferences logDebuggerStackToFile ifTrue: [ + Smalltalk logSqueakError: aString inContext: debugger interruptedContext]]. - Preferences logDebuggerStackToFile ifTrue: - [(aString includesSubstring: 'Space') & (aString includesSubstring: 'low') - ifTrue: [Smalltalk logError: aString inContext: debugger interruptedContext to: 'LowSpaceDebug.log'] - "logging disabled for 4.3 release, see - http://lists.squeak.org/pipermail/squeak-dev/2011-December/162503.html" - "ifFalse: [Smalltalk logSqueakError: aString inContext: debugger interruptedContext]"]. + ^ debugger + openNotifierNoSuspendContents: message label: aString; - Preferences eToyFriendly ifTrue: [Project current world stopRunningAll]. - ^debugger - openNotifierContents: nil label: aString; yourself ! Item was changed: ----- Method: MorphicDebugger class>>openOn:context:label:contents:fullView: (in category 'opening') ----- openOn: process context: context label: title contents: contentsStringOrNil fullView: full "Open a notifier in response to an error, halt, or notify. A notifier view just shows a short view of the sender stack and provides a menu that lets the user open a full debugger." ErrorRecursionGuard critical: [ | errorWasInUIProcess debugger | ErrorRecursion ifTrue: [ "self assert: process == Project current uiProcess -- DOCUMENTATION ONLY" self clearErrorRecursion. ^ Project current handleFatalDrawingError: title]. [ErrorRecursion not & Preferences logDebuggerStackToFile ifTrue: [Smalltalk logSqueakError: title inContext: context]] on: Error do: [:ex | ex return: nil]. errorWasInUIProcess := Project current spawnNewProcessIfThisIsUI: process. "Schedule debugging in deferred UI message because 1) If process is the current UI process, it is already broken. 2) If process is some other process, it must not execute UI code" Project current addDeferredUIMessage: [ + ErrorRecursionGuard critical: [ + self setErrorRecursion. + + self informExistingDebugger: context label: title. + + debugger := self new process: process context: context. + full + ifTrue: [debugger openFullNoSuspendLabel: title] + ifFalse: [debugger openNotifierNoSuspendContents: contentsStringOrNil label: title]. + debugger errorWasInUIProcess: errorWasInUIProcess. - self setErrorRecursion. + "Try drawing the debugger tool at least once to avoid freeze." + Project current world displayWorldSafely. + + self clearErrorRecursion] ]]. - self informExistingDebugger: context label: title. - - debugger := self new process: process context: context. - full - ifTrue: [debugger openFullNoSuspendLabel: title] - ifFalse: [debugger openNotifierContents: contentsStringOrNil label: title]. - debugger errorWasInUIProcess: errorWasInUIProcess. - - "Try drawing the debugger tool at least once to avoid freeze." - Project current world displayWorldSafely. - - self clearErrorRecursion]]. process suspend.! Item was changed: ----- Method: MorphicDebugger class>>openOnMethod:forReceiver:inContext: (in category 'opening') ----- openOnMethod: aCompiledMethod forReceiver: anObject inContext: aContextOrNil + | guineaPig debugger context | - | guineaPig debugger debuggerWindow context | guineaPig := [aCompiledMethod valueWithReceiver: anObject arguments: (aContextOrNil ifNil: [ #() ] ifNotNil: [ { aContextOrNil } ]). guineaPig := nil "spot the return from aCompiledMethod"] newProcess. context := guineaPig suspendedContext. + debugger := self new process: guineaPig context: context. + debugger initializeFull. + - debuggerWindow := debugger openFullNoSuspendLabel: 'Debug it'. "Now step into the expression. But if it is quick (is implemented as a primtiive, e.g. `0') it will return immediately back to the block that is sent newProcess above. Guard against that with the check for home being thisContext." [debugger interruptedContext method == aCompiledMethod] + whileFalse: [ + (guineaPig isNil and: [debugger interruptedContext home == thisContext]) + ifTrue: [^ Project uiManager inform: 'Nothing to debug; expression is optimized']. + debugger send]. + + debugger openFullNoSuspendLabel: 'Debug it'.! - whileFalse: - [(guineaPig isNil - and: [debugger interruptedContext home == thisContext]) ifTrue: - [debuggerWindow delete. - UIManager default inform: 'Nothing to debug; expression is optimized'. - ^self]. - debugger send]! Item was added: + ----- Method: MorphicDebugger>>abandon: (in category 'initialize') ----- + abandon: myWindow + + myWindow delete.! Item was added: + ----- Method: MorphicDebugger>>openFullFromNotifier: (in category 'initialize') ----- + openFullFromNotifier: notifierWindow + "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." + + super openFullFromNotifier: notifierWindow. + + notifierWindow delete. + + ^ ToolBuilder default + open: self + label: notifierWindow label! Item was added: + ----- Method: MorphicDebugger>>openFullNoSuspendLabel: (in category 'initialize') ----- + openFullNoSuspendLabel: aString + "Create, schedule and answer a full debugger with the given label. Do not terminate the current active process." + + super openFullNoSuspendLabel: aString. + + ^ ToolBuilder default + open: self + label: aString! Item was added: + ----- Method: MorphicDebugger>>openNotifierNoSuspendContents:label: (in category 'initialize') ----- + openNotifierNoSuspendContents: msgString label: label + + | builder spec | + super openNotifierNoSuspendContents: msgString label: label. + + builder := ToolBuilder default. + spec := self buildNotifierWith: builder label: label message: msgString. + + ^ ToolBuilder default open: spec! Item was added: + ----- Method: MorphicProject>>interruptCleanUpFor: (in category 'scheduling & debugging') ----- + interruptCleanUpFor: interruptedProcess + "Clean up things in case of a process interrupt." + + super interruptCleanUpFor: interruptedProcess. + + (Preferences eToyFriendly and: [interruptedProcess == self uiProcess]) + ifTrue: [Project current world stopRunningAll].! Item was changed: ----- Method: MorphicProject>>interruptName:preemptedProcess: (in category 'scheduling & debugging') ----- interruptName: labelString preemptedProcess: theInterruptedProcess "Create a Notifier on the active scheduling process with the given label." | preemptedProcess projectProcess | + self uiProcess == Processor activeProcess ifTrue: [ + ^ self inform: 'You cannot interrupt from within the UI process.\Use a helper process instead.' withCRs translated]. + ActiveHand ifNotNil:[ActiveHand interrupted]. ActiveWorld := world. "reinstall active globals" ActiveHand := world primaryHand. ActiveHand interrupted. "make sure this one's interrupted too" ActiveEvent := nil. projectProcess := self uiProcess. "we still need the accessor for a while" preemptedProcess := theInterruptedProcess ifNil: [Processor preemptedProcess]. "Only debug preempted process if its priority is >= projectProcess' priority" preemptedProcess priority < projectProcess priority ifTrue:[preemptedProcess := projectProcess]. + preemptedProcess suspend. + self interruptCleanUpFor: preemptedProcess. ToolSet debugInterruptedProcess: preemptedProcess label: labelString.! Item was added: + ----- Method: MorphicProject>>startUpActions (in category 'enter') ----- + startUpActions + + super startUpActions. + + self world install. + self world firstHand position: 100@100.!

3 3

Bug in DateAndTime fromUnixTime: ???
by John-Reed Maffeo 01 Oct '19

01 Oct '19

When I execute : DateAndTime fromUnixTime: 1569648600 The value I get is : 2019-09-28T05:30:00-07:00 This looks wrong to me because UNIX time is supposed to be in UTC and the value shows an offset of -07:00 hours which I assume is the offset for Mountain Standard Time in the US. My understanding is that the UTC value should be 2019-09-28T05:30:00-00:00 and I would have to convert it to 2019-09-27T10:30:00-07:00 to get the local time. If the method #fromUnixTime is expected to return a value with the local timezone offset, then the time value should be adjusted to local time to match the offset. However, I don't think that a UNIX time value should be represented in anything but UTC and the application should decide when and how to modify it. - jrm

3 2

The Trunk: SUnitGUI-mt.73.mcz
by commits＠source.squeak.org 30 Sep '19

30 Sep '19

Marcel Taeumel uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-mt.73.mcz ==================== Summary ==================== Name: SUnitGUI-mt.73 Author: mt Time: 4 September 2019, 5:28:26.809072 pm UUID: 56e5b083-0108-450e-92d4-9bea9160a539 Ancestors: SUnitGUI-mt.72 Show durations in test runner. =============== Diff against SUnitGUI-mt.72 =============== Item was changed: ----- Method: TestRunner>>classList (in category 'accessing-classes') ----- classList | helper | classes isEmpty ifTrue: [ ^ classes ]. helper := Browser new. ^ helper flattenHierarchyTree: (helper createHierarchyTreeOf: classes) on: OrderedCollection new indent: '' by: ' ' format: [:class | class isAbstract ifTrue: [class name asText addAttribute: TextEmphasis italic; yourself] + ifFalse: [ + (class history notNil and: [class history includesKey: #duration]) + ifFalse: ['{1} ({2} tests)' format: {class name. class allTestSelectors size}] + ifTrue: [ + | duration | + duration := (class history at: #duration). + '{1} ({2} tests, {3})' format: { + class name. + class allTestSelectors size. + duration = 0 ifTrue: ['< 1 ms'] ifFalse: [ + duration < 1000 ifTrue: [duration asString, ' ms'] ifFalse: [ + (duration / 1000) rounded asString, ' secs']]}]]] ! - ifFalse: ['{1} ({2})' format: {class name. class allTestSelectors size}]]! Item was changed: ----- Method: TestRunner>>saveResultInHistory (in category 'history saving') ----- saveResultInHistory + result dispatchResultsIntoHistory. + self changed: #classList.! - result dispatchResultsIntoHistory! Item was changed: ----- Method: TestRunner>>updateResults (in category 'updating') ----- updateResults "<lint: #expect rule: #guardingClause>" "<lint: #expect rule: #longMethods>" self updateStatus: false. failedList size = result failures size ifFalse: [ failedList := result failures asArray sort: [ :a :b | a printString <= b printString ]. failedSelected := nil. self changed: #failedList; changed: #failedSelected; changed: #hasFailures; changed: #hasProgress ]. errorList size = result errors size ifFalse: [ errorList := result errors asArray sort: [ :a :b | a printString <= b printString ]. errorSelected := nil. self changed: #errorList; changed: #errorSelected; changed: #hasErrors; + changed: #hasProgress; + changed: #classList ].! - changed: #hasProgress ].!

3 4

The Trunk: ToolBuilder-Morphic-mt.244.mcz
by commits＠source.squeak.org 30 Sep '19

30 Sep '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.244.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.244 Author: mt Time: 30 September 2019, 3:58:55.27471 pm UUID: b25e56d0-917d-e547-bfd6-2ae0d355a03c Ancestors: ToolBuilder-Morphic-mt.243 Complements Morphic-mt.1551. =============== Diff against ToolBuilder-Morphic-mt.243 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableText: (in category 'widgets required') ----- buildPluggableText: aSpec | widget | widget := self textPaneClass new. aSpec stylerClass ifNotNil: [:c | widget styler: (c new view: widget)]. widget on: aSpec model text: aSpec getText accept: aSpec setText readSelection: aSpec selection menu: aSpec menu. aSpec font ifNotNil: [:f | widget font: f]. widget readOnly: aSpec readOnly. widget editTextSelector: aSpec editText. widget wantsFrameAdornments: aSpec indicateUnacceptedChanges. widget askBeforeDiscardingEdits: aSpec askBeforeDiscardingEdits. widget setProperty: #alwaysAccept toValue: aSpec askBeforeDiscardingEdits not. + widget wrapFlag: (aSpec softLineWrap ifNil: [true]). - aSpec softLineWrap ifNotNil: [:b | widget wrapFlag: b]. widget isAutoFit ifTrue: [widget hideHScrollBarIndefinitely] ifFalse: [widget showHScrollBarOnlyWhenNeeded]. self register: widget id: aSpec name. widget getColorSelector: aSpec color. widget getTextColorSelector: aSpec textColor. self buildHelpFor: widget spec: aSpec. self setFrame: aSpec frame in: widget. self setLayoutHintsFor: widget spec: aSpec. parent ifNotNil:[self add: widget to: parent]. ^widget!

1 0

The Trunk: Morphic-mt.1551.mcz
by commits＠source.squeak.org 30 Sep '19

30 Sep '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1551.mcz ==================== Summary ==================== Name: Morphic-mt.1551 Author: mt Time: 30 September 2019, 3:57:16.04771 pm UUID: a496bd6a-f249-1d41-8989-e6383d6a0826 Ancestors: Morphic-mt.1550 Like Morphic-mt.1550, complement the change in Morphic-mt.1520. Before 1520, using #contents: did set wrapFlag to "false", which effectively initializes every TextMorph with that value because "TextMorph new contents: 'foobar'" is kind of common. After 1520, that's not the case anymore. So, this commit really sets wrapFlag to "false" and finally adds autoFit to #initialize as well. As long as the client configures text morphs with their #contents, wrapping makes no sense. Only if that configuration considers both #contents and #width, wrapping matters. Since that is the case for tool building, I will change the default treatment of PluggableTextSpec >> #softLineWrap directly after this commit. =============== Diff against Morphic-mt.1550 =============== Item was changed: ----- Method: MenuMorph>>displayFiltered: (in category 'keyboard control') ----- displayFiltered: evt | matchStr allItems matches feedbackMorph | matchStr := self valueOfProperty: #matchString. allItems := self submorphs select: [:m | m isKindOf: MenuItemMorph]. matches := allItems select: [:m | | isMatch | isMatch := matchStr isEmpty or: [ m contents includesSubstring: matchStr caseSensitive: false]. m isEnabled: isMatch. isMatch]. feedbackMorph := self valueOfProperty: #feedbackMorph. feedbackMorph ifNil: [ + feedbackMorph := TextMorph new + color: Color darkGray; + yourself. - feedbackMorph := - TextMorph new - autoFit: true; - wrapFlag: false; - color: Color darkGray. self addLine; addMorphBack: feedbackMorph lock. self setProperty: #feedbackMorph toValue: feedbackMorph. self fullBounds. "Lay out for submorph adjacency"]. feedbackMorph contents: '<', matchStr, '>'. matchStr isEmpty ifTrue: [ feedbackMorph delete. self submorphs last delete. self removeProperty: #feedbackMorph]. " This method is invoked with evt = nil from MenuMorph >> removeMatchString. The current implementation can't select an item without an event. " (evt notNil and: [ matches size >= 1 ]) ifTrue: [ self selectItem: matches first event: evt]! Item was changed: ----- Method: TextMorph>>initialize (in category 'initialization') ----- initialize super initialize. textStyle := TextStyle default copy. + + wrapFlag := false. + autoFit := true.! - wrapFlag := true. - ! Item was changed: ----- Method: TextMorph>>isAutoFit (in category 'accessing') ----- isAutoFit + "For migrating old instances only. See #initialize." + - ^ autoFit ifNil: [autoFit := true]!

1 0

Caffeine news
by Craig Latta 30 Sep '19

30 Sep '19

Hi folks-- There have been some fun developments in Caffeine-space recently... [1] running Pharo 7 [2] controlling the Netflix player from Squeak in a Chrome DevTools panel [3] livecoding the Smalltalk devtools with VueJS You can read more about these on my blog, thiscontext.com. thanks, -C *** [1] https://tinyurl.com/yxg9kz7v (this.context.com) [2] https://tinyurl.com/y584ljyb [3] https://tinyurl.com/y5dm6yh5 -- Craig Latta Black Page Digital Amsterdam :: San Francisco craig(a)blackpagedigital.com +31 6 2757 7177 + 1 415 287 3547

2 1

TextMorph >> #fit broken?
by Thiede, Christoph 30 Sep '19

30 Sep '19

Hi all, can you reproduce the following? [cid:be268ece-e371-4907-8aa2-1da37a95ee37] I assume it this bug was revealed (not caused) by Morphic-mt.1520, so by default, each TextMorph now has the wrapFlag true. Is this really what we want? Minimal example to reproduce: m := Morph new. m openInHand. m extent: 300 @ 200. m cellPositioning: #center. m changeTableLayout. t := TextMorph new contents: 'Hello world'; yourself. t autoFit: true. t container Works before, does not work after the recent commit. Should we maybe initialize wrapFlag with false, in order to revert the behavior from before Morphic-mt.1520? I know also other implementations, aside from Trunk, which are failing after the update. Best, Christoph

2 3

← Newer
1
2
3
4
5
6
7
8
...
36
Older →

Jump to page: