Squeak-dev November 2019

squeak-dev@lists.squeakfoundation.org

23 participants
232 discussions

The Trunk: Tools-mt.920.mcz
by commits＠source.squeak.org 29 Nov '19

29 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.920.mcz ==================== Summary ==================== Name: Tools-mt.920 Author: mt Time: 29 November 2019, 11:40:09.779061 am UUID: 2a38fb46-276b-3949-a8d1-f1ac037e257a Ancestors: Tools-tpr.919 In inspector classes, make use of #setContents: (Kernel-mt.1284). Add a way to get/set the user-typed contents in the value pane, which is not the expression pane. =============== Diff against Tools-tpr.919 =============== Item was changed: ----- Method: DictionaryInspector>>removeSelection (in category 'menu') ----- removeSelection selectionIndex = 0 ifTrue: [^ self changed: #flash]. object removeKey: (keyArray at: selectionIndex - self numberOfFixedFields). selectionIndex := 0. + self setContents: ''. - contents := ''. self calculateKeyArray. self changed: #inspectObject. self changed: #selectionIndex. self changed: #fieldList. self changed: #selection.! Item was changed: StringHolder subclass: #Inspector + instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression shouldStyleValuePane contentsTyped' - instanceVariableNames: 'object selectionIndex timeOfLastListUpdate selectionUpdateTime context expression shouldStyleValuePane' classVariableNames: '' poolDictionaries: '' category: 'Tools-Inspector'! !Inspector commentStamp: '<historical>' prior: 0! I represent a query path into the internal representation of an object. As a StringHolder, the string I represent is the value of the currently selected variable of the observed object.! Item was added: + ----- Method: Inspector>>contentsTyped (in category 'accessing') ----- + contentsTyped + + ^ contentsTyped! Item was added: + ----- Method: Inspector>>contentsTyped: (in category 'accessing') ----- + contentsTyped: aStringOrText + + contentsTyped := aStringOrText.! Item was changed: ----- Method: Inspector>>modelWakeUpIn: (in category 'accessing') ----- modelWakeUpIn: aWindow | newText | self updateListsAndCodeIn: aWindow. newText := self contentsIsString ifTrue: [newText := self selection] ifFalse: ["keep it short to reduce time to compute it" self selectionPrintString ]. + self setContents: newText.! - newText = contents ifFalse: - [contents := newText. - self changed: #contents]! Item was changed: ----- Method: Inspector>>printStringErrorText (in category 'private') ----- printStringErrorText | nm | nm := self selectionIndex < 3 ifTrue: ['self'] + ifFalse: [self selectedFieldName]. - ifFalse: [self selectedSlotName]. ^ (nm ifNil: ['no selection'] ifNotNil: [nm first isDigit ifTrue: ['<error in printString: evaluate "(self at: ' , nm , ') printString" to debug>'] ifFalse: ['<error in printString: evaluate "' , nm , ' printString" to debug>'] ]) asText! Item was added: + ----- Method: Inspector>>selectFieldNamed: (in category 'selecting') ----- + selectFieldNamed: aString + + self selectedFieldName = aString ifTrue: [^ self]. + self toggleIndex: (self fieldList indexOf: aString).! Item was added: + ----- Method: Inspector>>selectedFieldName (in category 'selecting') ----- + selectedFieldName + + ^ self fieldList at: self selectionIndex ifAbsent: []! Item was removed: - ----- Method: Inspector>>selectedSlotName (in category 'selecting') ----- - selectedSlotName - - ^ self fieldList at: self selectionIndex ifAbsent: []! Item was added: + ----- Method: Inspector>>setContents: (in category 'initialize-release') ----- + setContents: aStringOrText + + super setContents: aStringOrText. + self contentsTyped: nil.! Item was added: + ----- Method: Inspector>>setContentsTyped: (in category 'initialize-release') ----- + setContentsTyped: aStringOrText + "Simulate typing." + + self contentsTyped: aStringOrText. + self changed: #editString with: aStringOrText.! Item was changed: ----- Method: Inspector>>stepAt:in: (in category 'stepping') ----- stepAt: millisecondClockValue in: aWindow | newText | (Preferences smartUpdating and: [(millisecondClockValue - self timeOfLastListUpdate) > 8000]) "Not more often than once every 8 seconds" ifTrue: [self updateListsAndCodeIn: aWindow. timeOfLastListUpdate := millisecondClockValue]. newText := self contentsIsString ifTrue: [self selection] ifFalse: ["keep it short to reduce time to compute it" self selectionPrintString ]. + self setContents: newText.! - newText = contents ifFalse: - [contents := newText. - self changed: #contents]! Item was changed: ----- Method: Inspector>>toggleIndex: (in category 'selecting') ----- toggleIndex: anInteger "The receiver has a list of variables of its inspected object. One of these is selected. If anInteger is the index of this variable, then deselect it. Otherwise, make the variable whose index is anInteger be the selected item." + | newText | selectionUpdateTime := 0. selectionIndex = anInteger ifTrue: ["same index, turn off selection" selectionIndex := 0. + newText := ''] - contents := ''] ifFalse: ["different index, new selection" shouldStyleValuePane := false. selectionIndex := anInteger. self contentsIsString + ifTrue: [newText := self selection] + ifFalse: [newText := self selectionPrintString]]. + self setContents: newText. - ifTrue: [contents := self selection] - ifFalse: [contents := self selectionPrintString]]. self changed: #selection. - self changed: #contents. self changed: #selectionIndex.! Item was changed: ----- Method: Inspector>>typeValue: (in category 'selecting') ----- typeValue: aTextOrString shouldStyleValuePane := true. + contentsTyped := aTextOrString. + self changed: #style.! - self changed: #style! Item was changed: ----- Method: Inspector>>update (in category 'accessing') ----- update "Reshow contents, assuming selected value may have changed." + | newText | selectionIndex = 0 ifFalse: [self contentsIsString + ifTrue: [newText := self selection] + ifFalse: [newText := self selectionPrintString]. + self setContents: newText. - ifTrue: [contents := self selection] - ifFalse: [contents := self selectionPrintString]. - self changed: #contents. self changed: #selection. self changed: #selectionIndex]! Item was changed: ----- Method: SetInspector>>removeSelection (in category 'menu') ----- removeSelection (selectionIndex <= object class instSize) ifTrue: [^ self changed: #flash]. object remove: self selection. selectionIndex := 0. + self setContents: ''. - contents := ''. self changed: #inspectObject. self changed: #fieldList. self changed: #selection. self changed: #selectionIndex.!

1 0

The Trunk: Kernel-mt.1284.mcz
by commits＠source.squeak.org 29 Nov '19

29 Nov '19

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1284.mcz ==================== Summary ==================== Name: Kernel-mt.1284 Author: mt Time: 29 November 2019, 11:37:15.422061 am UUID: 8058d02f-d2cd-b942-aa93-095fa963a523 Ancestors: Kernel-mt.1283 Adds a message to set new contents and notify all dependents. To be used by subclasses to remove extra #changed: calles and to provide a better hook to do something else when updating the contents. =============== Diff against Kernel-mt.1283 =============== Item was added: + ----- Method: StringHolder>>setContents: (in category 'initialize-release') ----- + setContents: aString + + self contents = aString ifTrue: [^ self]. + self contents: aString. + self changed: #contents.!

1 0

NetNameResolver gives spurious answers for images running 5.2 on x86 mac & 86 linux
by tim Rowledge 29 Nov '19

29 Nov '19

If I run NetNameResolver localHostAddress in a 5.2 image on my iMac it returns #[0 0 0 0]. On a Pi it returns the more appropriate #[192 168 1 42] sort of answer. On an 86 linux it also gives the wrong answer; so it doesn't seem like a purely Mac vm bug. The image says useOldNetwork is true (which seems like something we've been fudging for a long while now) in all cases. If I set the preference to use the ipv6/new network stuff I get a less bad answer on the Mac of 192.168.1.65(192.168.1.65),0(0) - but I don't think it is quite what the rest of the system wants since trying (from PersonalSqueakSource) (NetNameResolver nameForAddress: (NetNameResolver localHostAddress) timeout: 5) ifNil: [NetNameResolver localAddressString] results in a prim failure in NetNameResolver class>>#nameForAddress:timeout: Sigh. Anybody got any brilliant ideas on what is going wrong here? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim A sad tale that brings a lump to the eye and a tear to the throat.

3 4

The Inbox: Morphic-eem.1591.mcz
by commits＠source.squeak.org 28 Nov '19

28 Nov '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-eem.1591.mcz ==================== Summary ==================== Name: Morphic-eem.1591 Author: eem Time: 27 November 2019, 3:33:58.403643 pm UUID: 500d5e62-baba-4898-834f-a144b8a7d3fe Ancestors: Morphic-mt.1590 Support for Tools-eem.915 =============== Diff against Morphic-mt.1590 =============== Item was added: + ----- Method: Morph>>hasTextMorph (in category 'testing') ----- + hasTextMorph + "Answer if the receiver will answer with a TextMorph if sent the textMorph message." + ^false! Item was added: + ----- Method: NewBalloonMorph>>hasTextMorph (in category 'testing') ----- + hasTextMorph + "Answer if the receiver will answer with a TextMorph if sent the textMorph message." + ^true! Item was added: + ----- Method: PluggableTextMorph>>hasTextMorph (in category 'testing') ----- + hasTextMorph + "Answer if the receiver will answer with a TextMorph if sent the textMorph message." + ^true!

1 0

The Trunk: Collections-kfr.812.mcz
by commits＠source.squeak.org 27 Nov '19

27 Nov '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-kfr.812.mcz ==================== Summary ==================== Name: Collections-kfr.812 Author: kfr Time: 4 November 2018, 4:41:29.534614 pm UUID: 93f849c9-8b62-e04c-b8e0-ab2a7c2d728c Ancestors: Collections-eem.811 Print the matrix so one can see the rows and columns =============== Diff against Collections-eem.811 =============== Item was added: + ----- Method: Matrix>>printMatrix (in category 'printing') ----- + printMatrix + "Answer a String whose characters are a description of the receiver layed out in rows and columns" + + ^ String streamContents: [:aStream | + 1 + to: nrows + do: [:iRow | + 1 + to: ncols + do: [:iCols | + aStream + print: (self at: iRow at: iCols). + aStream tab: 2]. + aStream cr]]!

1 0

The Trunk: Collections-mt.864.mcz
by commits＠source.squeak.org 27 Nov '19

27 Nov '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.864.mcz ==================== Summary ==================== Name: Collections-mt.864 Author: mt Time: 27 November 2019, 10:46:36.719363 am UUID: 5e0200f3-d834-4849-93ad-393e5b2b1af2 Ancestors: Collections-mt.863, Collections-kfr.812 Merges Collections-kfr.812 but renames #printMatrix to the existing #stringForReadout. We might want to use that one for ObjectExplorer ... See Object >> #asExplorerString. =============== Diff against Collections-mt.863 =============== Item was added: + ----- Method: Matrix>>stringForReadout (in category 'printing') ----- + stringForReadout + "Answer a String whose characters are a description of the receiver layed out in rows and columns" + + ^ String streamContents: [:aStream | + 1 + to: self rowCount + do: [:iRow | + 1 + to: self columnCount + do: [:iCols | + aStream + print: (self at: iRow at: iCols). + aStream tab: 2]. + aStream cr]]!

1 0

The Trunk: MorphicExtrasTests-mt.6.mcz
by commits＠source.squeak.org 27 Nov '19

27 Nov '19

Marcel Taeumel uploaded a new version of MorphicExtrasTests to project The Trunk: http://source.squeak.org/trunk/MorphicExtrasTests-mt.6.mcz ==================== Summary ==================== Name: MorphicExtrasTests-mt.6 Author: mt Time: 27 November 2019, 10:24:35.984363 am UUID: 3d508d97-0a4c-8546-9d8f-9ce4823c6400 Ancestors: MorphicExtrasTests-pre.5 Tests for simple setter/getter moved to and extended in StringSystemSupportTest in the package Tests-System-Support. =============== Diff against MorphicExtrasTests-pre.5 =============== Item was removed: - TestCase subclass: #MorphicExtrasSymbolExtensionsTest - instanceVariableNames: '' - classVariableNames: '' - poolDictionaries: '' - category: 'MorphicExtrasTests-Flaps'! Item was removed: - ----- Method: MorphicExtrasSymbolExtensionsTest>>testAsSimpleSetterReturnsSetterSelector (in category 'as yet unclassified') ----- - testAsSimpleSetterReturnsSetterSelector - self assert: #foo: equals: #foo asSimpleSetter. - - "And it really is 'simple':" - self assert: #foo:: equals: #foo: asSimpleSetter.!

1 0

The Trunk: System-tpr.1125.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

tim Rowledge uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tpr.1125.mcz ==================== Summary ==================== Name: System-tpr.1125 Author: tpr Time: 26 November 2019, 12:41:51.836859 pm UUID: dd0aed77-eb3e-4d57-b1c9-3f6fbb5d9674 Ancestors: System-mt.1124 Improve MessageBrowser labelling a bit; see changes in Tools-tpr.919 =============== Diff against System-mt.1124 =============== Item was changed: ----- Method: SystemNavigation>>headingAndAutoselectForLiteral:do: (in category 'private') ----- headingAndAutoselectForLiteral: aLiteral do: binaryBlock "Evaluate binaryBlock with either Users of ... or Senders of ... plus the auto-select string for the given literal. aLiteral can be a Symbol, a VariableBinding or an arbitrary object." | autoSelect | ^ aLiteral isSymbol ifTrue: [ binaryBlock value: 'Senders of ' , aLiteral + value: aLiteral ] - value: (aLiteral keywords ifEmpty: [aLiteral] ifNotEmpty: [:keys | keys first]) ] ifFalse: [ autoSelect := aLiteral isVariableBinding ifTrue: [ aLiteral key ] ifFalse: [ aLiteral printString ]. binaryBlock value: 'Users of ' , autoSelect value: autoSelect ]!

1 0

The Trunk: Tools-tpr.919.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.919.mcz ==================== Summary ==================== Name: Tools-tpr.919 Author: tpr Time: 26 November 2019, 12:40:22.939049 pm UUID: 28b573d5-943f-4dbe-b825-60a57625a114 Ancestors: Tools-mt.918 Improve MessageBrowser labelling a bit; it will actually show the full message name being browsed instead of truncating it to the first part of any keyword. =============== Diff against Tools-mt.918 =============== Item was changed: ----- Method: MessageSet>>autoSelectString (in category 'private') ----- autoSelectString + "Return the string to be highlighted when making new selections. For actual keyword selectors, only select the first keyword." + + ^ autoSelectString ifNotNil: [:stringOrSelector | + (Symbol lookup: stringOrSelector) + ifNil: [stringOrSelector "no change"] + ifNotNil: [:selector | selector precedence = 3 + "only the first part of the keyword message" + ifTrue: [selector copyFrom: 1 to: (selector indexOf: $:)] + "no change" + ifFalse: [stringOrSelector]]] + ! - "Return the string to be highlighted when making new selections" - ^ autoSelectString! Item was changed: ----- Method: MessageTrace>>addChildMessages:autoSelectString: (in category 'building') ----- addChildMessages: methodReferences autoSelectString: aString | currentIndentionLevel addables selectables selectableString newAnchor | selectableString := aString keywords ifEmpty: [ String empty ] + ifNotEmptyDo: [ : keywords | + "we can probably do something more precise here; perhaps recombining the extracted keywords into a single selector? Then again all usages of this method seem to already enforce use of a selector" + aString ]. - ifNotEmptyDo: [ : keywords | keywords first ]. [ (messageListIndex between: 1 and: autoSelectStrings size) ] whileFalse: [ autoSelectStrings add: selectableString ]. currentIndentionLevel := self currentIndentionLevel. "Don't add mulitple copies of the same method, if a method is already in the list we will merely select it." addables := methodReferences reject: [ : each | messageList includes: each ]. addables do: [ : each | each stringVersion: (self indentionPrefixOfSize: currentIndentionLevel + 1) , each asStringOrText. messageList add: each afterIndex: self messageListIndex. autoSelectStrings add: nil afterIndex: self messageListIndex. messageSelections add: false afterIndex: self messageListIndex ]. selectables := addables copy addAll: (methodReferences select: [ : each | messageList includes: each ]) ; yourself. self deselectAll. anchorIndex := nil. selectables do: [ : each | self messageAt: (newAnchor := messageList indexOf: each) beSelected: true. anchorIndex ifNil: [ anchorIndex := newAnchor ] ]. self changed: #messageList. "Select the first child method." self messageListIndex: (selectables size > 0 ifTrue: [ messageList indexOf: selectables last ] ifFalse: [ messageList ifEmpty: [ 0 ] ifNotEmpty: [ 1 ] ])! Item was changed: ----- Method: MessageTrace>>addParentMessages:autoSelectString: (in category 'building') ----- addParentMessages: methodReferences autoSelectString: aString | currentIndentionLevel addables selectables | addables := methodReferences reject: [ : each | messageList includes: each ]. + "we may need to process aString here in a similar manner to that in #addChildMessages:autoSelectString:" selectables := addables copy addAll: (methodReferences select: [ : each | messageList includes: each ]) ; yourself. currentIndentionLevel := self currentIndentionLevel. (currentIndentionLevel = 0 and: [ addables notEmpty ]) ifTrue: [ self indentEverything. currentIndentionLevel := 1 ]. addables do: [ : each | each stringVersion: (self indentionPrefixOfSize: currentIndentionLevel - 1) , each asStringOrText. messageList add: each afterIndex: self messageListIndex - 1. autoSelectStrings add: aString afterIndex: self messageListIndex - 1. messageSelections add: false afterIndex: self messageListIndex - 1 ]. self deselectAll. selectables do: [ : each | | messageIndex | messageIndex := messageList indexOf: each. self messageAt: messageIndex beSelected: true. autoSelectStrings at: messageIndex put: aString ]. self changed: #messageList. anchorIndex := messageListIndex. selectables size > 0 ifTrue: [ self messageListIndex: (messageList indexOf: selectables first) ]! Item was changed: ----- Method: MessageTrace>>messageListIndex: (in category 'actions') ----- messageListIndex: anInteger + autoSelectStrings ifNotEmpty: - autoSelectStrings notEmpty ifTrue: [ autoSelectString := anInteger = 0 ifTrue: [ defaultSelectString ifNotNil: [:default| self containingWindow setLabel: default]. + "clear the autoSelectString" '' ] ifFalse: + [ messageListIndex := anInteger. + "setting the window label, below, can't wait for this.." - [ messageListIndex := anInteger. "setting the window label, below, can't wait for this.." self containingWindow setLabel: (self windowLabelAt: anInteger). + "work out the string to ask the text view to pre-select. We should do better than this; after all the debugger does" + (autoSelectStrings at: anInteger)] ]. - (autoSelectStrings at: anInteger) ifNotNil: [ : fullSelector | fullSelector keywords first ] ] ]. anInteger > 0 ifTrue: [ self messageAt: anInteger beSelected: true ]. super messageListIndex: anInteger !

1 0

Drag and drop to reorder items in a single list
by Jakob Reschke 26 Nov '19

26 Nov '19

Hello everyone, tl;dr: the current PluggableTextMorph/Plus does not support the reordering of items in a single list via drag and drop. Attached you find a change set that fixes this, but it might also break in other places. Thus, I kindly ask for a review. Today I found myself implementing a ToolBuilder-built list in which the items should be reorderable via drag and drop. Unfortunately, the current implementation of PluggableTextMorph/Plus does not allow this: you first have to drag the item out of the list before you can drop it in again. Seems like the list morph needs the mouse focus to be able to accept the drop. However, the current implementation explicitly releases the focus from the list upon grabbing the item. Then I changed the PluggableTextMorphPlus to not drop the focus, but keep it, when starting to drag an item. Now the focus would not even be released anymore when the item was indeed dragged out of a list if that list itself does not accept any drops (such as the method list in the system browser: it does not accept drops, but the methods can be dragged from it to the message categories list). So I have changed further methods to make the list morphs always handle dragging events, even if they are not interested in drops. But I do not know what else that might have broken. So, please have a look at the attached change sets. The one without "all" in the file name contains only the actual changes. The one with "all" also contains other relevant (unchanged) methods that I touched during my investigation. Eventually, I would like to put this or a revised edition of it in the inbox because list reordering via drag and drop should not be impossible. The third file contains a simple Model subclass with a list whose items should be reorderable via drag and drop, so you do not have to write it yourself. Grab a sample instance and open it with the ToolBuilder: ToolBuilder open: DragDropInSingleList new. In case I simply got it wrong and there is no need to change Morphic lists to achieve what I want, please tell me how to do it right. ;-) Best regards, Jakob

3 3

← Newer
1
2
3
4
5
6
7
8
9
...
24
Older →

Jump to page: