Squeak-dev November 2019

squeak-dev@lists.squeakfoundation.org

23 participants
232 discussions

UndeclaredVariable correction raises Error in Parser
by Thiede, Christoph 17 Sep '20

17 Sep '20

Hi all, maybe someone has time and knowledge to fix the following bug? Scenario: Try to compile the following method: foo ba := nil. 42 ifNotNil: [:ba | ba]. Then accept it and answer the UndeclaredVariable dialog with 'declare temp variable'. Expected behavior: The method should be corrected to: foo | ba | ba := nil. 42 ifNotNil: [: "Name already used in this method ->"ba | ba]. Actual behavior: UndeclaredVariableNode>>#sizeCodeForStorePop: is called and raises a #shouldNotImplement. Interpretation: I guess the problem is in #undeclaredTemps, where the encoder does not declare ba which was shadowed by the declaration in the block. How could that be solved? My first approach would be to store all UndeclaredTempVars in #bindUndeclaredTemp: separately, but I'm quite sure this is not efficient ... How would you solve this problem the best way? However, I attached a change set for my attempt, all tests are green. I'm excited to hear your answers! :) Best, Christoph

2 2

The Inbox: EToys-ct.367.mcz
by commits＠source.squeak.org 29 Mar '20

29 Mar '20

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-ct.367.mcz ==================== Summary ==================== Name: EToys-ct.367 Author: ct Time: 15 October 2019, 2:46:24.862129 pm UUID: 1394344f-b1e3-5640-a13a-70c5dffd51f4 Ancestors: EToys-mt.361 Allow for embedding SyntaxMorphs into test tiles. =============== Diff against EToys-mt.361 =============== Item was added: + ----- Method: SyntaxMorph>>parseNodeWith:asStatement: (in category '*Etoys-Squeakland-code generation') ----- + parseNodeWith: encoder asStatement: aBoolean + + ^ self parseNode!

4 11

The Inbox: HelpSystem-Core-ct.123.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

A new version of HelpSystem-Core was added to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.123.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.123 Author: ct Time: 13 October 2019, 9:04:08.373932 pm UUID: dec7ceca-320f-d945-8d2a-c2f6a5e49a52 Ancestors: HelpSystem-Core-ct.120 Refactors HelpBrowser menu: Move menu stuff from HelpBrowser into HelpTopic hierarchy in favor of a better object design Thanks again, Marcel :-) =============== Diff against HelpSystem-Core-ct.120 =============== Item was added: + ----- Method: AbstractHelpTopic>>browseTopicFromParent: (in category 'tools') ----- + browseTopicFromParent: parentTopic + + self canBrowseTopic + ifTrue: [^ self browseTopic]. + parentTopic canBrowseSubtopic + ifTrue: [^ parentTopic browseSubtopic: self]. + ! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopicFromParent: (in category 'testing') ----- + canBrowseTopicFromParent: parentTopic + + ^ self canBrowseTopic or: [ + parentTopic ifNotNil: #canBrowseSubtopic ifNil: [false]]! Item was added: + ----- Method: AbstractHelpTopic>>topicMenu:parentTopic: (in category 'menus') ----- + topicMenu: aMenu parentTopic: parentTopic + + aMenu + add: 'Inspect (i)' translated target: self action: #inspect; + add: 'Explore (I)' translated target: self action: #explore. + (self canBrowseTopicFromParent: parentTopic) + ifTrue: [ + aMenu add: 'Browse (b)' translated + target: self + selector: #browseTopicFromParent: + argumentList: {parentTopic} ]. + + ^ aMenu! Item was added: + ----- Method: AbstractHelpTopic>>topicMenuKey:fromParent: (in category 'menus') ----- + topicMenuKey: aChar fromParent: parentTopic + + aChar + caseOf: { + [$b] -> [(self canBrowseTopicFromParent: parentTopic) + ifTrue: [ self browseTopicFromParent: parentTopic ]]. + [$i] -> [self inspect]. + [$I] -> [self explore] } + otherwise: [^ false]. + ^ true! Item was added: + ----- Method: ClassAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: DirectoryBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: FileBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was removed: - ----- Method: HelpBrowser>>browseTopic (in category 'actions') ----- - browseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - ifTrue: [self currentTopic browseTopic] - ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]! Item was removed: - ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') ----- - canBrowseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - or: [self currentParentTopic respondsTo: #browseSubtopic:]! Item was removed: - ----- Method: HelpBrowser>>exploreTopic (in category 'actions') ----- - exploreTopic - - ^ self currentTopic explore! Item was removed: - ----- Method: HelpBrowser>>inspectTopic (in category 'actions') ----- - inspectTopic - - ^ self currentTopic inspect! Item was changed: ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') ----- treeKey: aChar from: aView event: anEvent anEvent anyModifierKeyPressed ifFalse: [^ false]. + ^ (self currentTopic topicMenuKey: aChar fromParent: self currentParentTopic)! - aChar - caseOf: { - [$b] -> [self browseTopic]. - [$i] -> [self inspectTopic]. - [$I] -> [self exploreTopic]. } - otherwise: [^ false]. - ^ true! Item was changed: ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') ----- treeListMenu: aMenu <treeListMenu> + ^ self currentTopic + ifNil: [aMenu] + ifNotNil: [:topic | topic + topicMenu: aMenu + parentTopic: self currentParentTopic]! - self currentTopic ifNil: [^ aMenu]. - - aMenu - add: 'Inspect (i)' action: #inspectTopic; - add: 'Explore (I)' action: #exploreTopic. - - self canBrowseTopic ifTrue: [ - aMenu - addLine; - add: 'Browse (b)' action: #browseTopic]. - - ^ aMenu! Item was added: + ----- Method: MethodListHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: PackageAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true!

9 22

28 Feb '20

Hi, -] I suppose the username/password for Squeakmap and Mantis are the same, is it so ? -] I would like to make a Squeakmap package for STON but I have issues logging into Squeakmap. I made a user, username "NMI", but I never received the confirmation email. All attempts I made to re-login or rewrite the password failed. I guess something is wrong. bye Nicola

4 6

The Inbox: Morphic-ct.1585.mcz
by commits＠source.squeak.org 16 Feb '20

16 Feb '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1585.mcz ==================== Summary ==================== Name: Morphic-ct.1585 Author: ct Time: 10 November 2019, 4:01:42.092559 pm UUID: 9564d2b2-4af1-044b-96fd-532e60252fd7 Ancestors: Morphic-mt.1584 TextEditor: Don't change the cursor position after a text action has been performed. This keeps a possible selection stable after you, for example, followed a link. =============== Diff against Morphic-mt.1584 =============== Item was changed: ----- Method: TextEditor>>mouseDown: (in category 'events') ----- mouseDown: evt "Either 1) handle text actions in the paragraph, 2) begin a text drag operation, or 3) modify the caret/selection." | clickPoint b | oldInterval := self selectionInterval. clickPoint := evt cursorPoint. b := paragraph characterBlockAtPoint: clickPoint. (paragraph clickAt: clickPoint for: model controller: self) ifTrue: [ - markBlock := b. - pointBlock := b. evt hand releaseKeyboardFocus: morph. evt hand releaseMouseFocus: morph. ^ self ]. (morph dragEnabled and: [self isEventInSelection: evt]) ifTrue: [ evt hand waitForClicksOrDrag: morph event: evt selectors: {#click:. nil. nil. #startDrag:} threshold: HandMorph dragThreshold. morph setProperty: #waitingForTextDrag toValue: true. ^ self]. evt shiftPressed ifFalse: [ self closeTypeIn. markBlock := b. pointBlock := b ] ifTrue: [ self closeTypeIn. self mouseMove: evt ]. self storeSelectionInParagraph!

3 2

The Trunk: Tools-ct.887.mcz
by commits＠source.squeak.org 29 Jan '20

29 Jan '20

Levente Uzonyi uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.887.mcz ==================== Summary ==================== Name: Tools-ct.887 Author: ct Time: 6 September 2019, 5:14:55.984698 pm UUID: 3f24f39e-68d7-0b45-bbb6-81299d9e9268 Ancestors: Tools-mt.886 Workspace: After expression evaluation, update style. If you "doit-ed" an assignment, Shout colors were not updated automatically ('x := 6*7'). =============== Diff against Tools-mt.886 =============== Item was added: + ----- Method: Workspace>>expressionEvaluated:result: (in category 'menu commands') ----- + expressionEvaluated: anExpression result: anObject + + self changed: #style!

2 1

Faster fibonacci
by tim Rowledge 28 Jan '20

28 Jan '20

I've been involved in a long and sometimes weird discussion on the RaspberryPi forums about fibonacci implementations in different languages and using assorted algorithms. I'd never really thought about alternatives to recursive approaches before but it turns out there is massively faster way. Clearly, this is not to replace the benchFib code since that has a specific use, but if anyone with an interest in numerics wants a faster way to generate fib(8577) for example, this is how - Integer >> fastDoublingFib "derived from https://www.nayuki.io/page/fast-fibonacci-algorithms" "(1 to: 20) collect:[:i| i fastDoublingFib]" "testing a quite large one - " "8577 fastDoublingFib= 13724780954457889052017147206983806244049002655849289934662148526555403650297300643609932653364630032094175733360509578504423049114004867523161091564824674600978308740378989479162611031273424686573759784740689516901416473328655422390895971263265867635819510949686102571388751758998017349379498918930220900180038324615253426530740473855269056304380498630108126734047701362218655030270360608989081398866489746698916626888016696892691933237089180504631788915650757757515944644732966345269202761471025651071790297611079540881155092137592980230998234868586211881093892491570520577408961869977892273540956424095750855208529072246641778982103984467921868950012668004047986803017482248992968482737462668300684879633714025755790485860328854796518843956263863014632532331145699658530054942590047273403691531821918862996422405159427262092477196755988981309029424760342802374213122162727840557722145891090413688461745240415668189577836068480363407847582529735341950500636735281963089675493707159434777756081146452522323681782226760627277553296721358921412115264845467834979154061137421532609247762981818564578019888974692581079593575783553856910367568474613323528337733872069223030834774749130478360574004172522316484339530942110067893000847800932306298725285623628731149337468217751734165148732164148285915275115006479682658150442259002271790547596033006363411193653337536041106069912826015502035140618407668385378737477702597473151509972754111640855347958033314453349633268543893894677097708945041254623018915871109789412793709229204261914803477697183287924195770678873001065036313926288444791424871512110658175954743584548831946767673488152740675550518235698898217693311515366329280005757014637854214769152690638778904780724293185353992279724740604674926819294787586671833537117545443846365508358918882" | a b c | a := 0. b := 1. self highBit to: 1 by: -1 do:[:i||d e| d := (b bitShift: 1) - a * a. e := a squared + b squared. a := d. b := e. (self bitAt: i) = 1 ifTrue:[ c := a + b. a := b. b := c] ]. ^a I bet it could be sped up more, but a simply spyOn run just allocated all the primitive time to delay waiting. Didn't we improve that some time ago? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: BYEBYE: Store in Write-Only Storage

9 35

ServerDirectory example login is dead
by tim Rowledge 20 Jan '20

20 Jan '20

If one tries to add a remote directory to a FileList the example server details lists the no longer extant st.cs.uiuc.edu, which is a little disappointing. Do we have a good replacement? Preferably a good place on our own server(s)? I did actually try files.squeak.org but that a) failed b) exposed me to the great joy of a loop of unhandled error handling handling errors in erroneous handling. I *can* get to my own server, so the basics still function - but I’m not providing access to that for the world in general. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Hypnotized as a child and couldn't be woken.

6 16

The Trunk: Morphic-cmm.1484.mcz
by commits＠source.squeak.org 13 Jan '20

13 Jan '20

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.1484.mcz ==================== Summary ==================== Name: Morphic-cmm.1484 Author: cmm Time: 4 April 2019, 5:46:17.398582 pm UUID: 5a57ba6f-fa15-44a3-9581-c919060f0378 Ancestors: Morphic-cmm.1483 Metacello and GitInfrastructure tools are currently the best way to load projects hosted by github.com. Promote installation of the these tools to the Tools menu. =============== Diff against Morphic-cmm.1483 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') ----- + gitInfrastructureMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Git Infrastructure' translated ; + help: 'Load tools for accessing github repositories.' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #installGitInfrastructure ]! Item was added: + ----- Method: TheWorldMainDockingBar>>metacelloMenuItemOn: (in category 'submenu - tools') ----- + metacelloMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Metacello' translated ; + help: 'Install Metacello' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #ensureRecentMetacello ]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; methodFinderMenuItemOn: menu; messageNamesMenuItemOn: menu. menu addLine. self - monticelloBrowserMenuItemOn: menu; - monticelloConfigurationsMenuItemOn: menu; simpleChangeSorterMenuItemOn: menu; + dualChangeSorterMenuItemOn: menu; + monticelloBrowserMenuItemOn: menu; + monticelloConfigurationsMenuItemOn: menu ; + metacelloMenuItemOn: menu ; + gitInfrastructureMenuItemOn: menu. - dualChangeSorterMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]! Item was changed: + (PackageInfo named: 'Morphic') postscript: '"updated Tools menu" + TheWorldMainDockingBar updateInstances'! - (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances'!

10 21

inescapable modal dialog in trunk
by Chris Muller 10 Jan '20

10 Jan '20

1. Make a method in a browser dirty. 2. Click on another method. Squeak displays, "Changes have not been saved, is it okay to cancel those changes?" 3. Click "No". 4. Now try click anywhere else or do anything else in other windows or the desktop. Every click anywhere causes the dialog to reappear until you say "Yes" or cancel the method changes.

7 20

Jump to page: