Squeak-dev November 2019

squeak-dev@lists.squeakfoundation.org

23 participants
232 discussions

The Trunk: ToolBuilder-Morphic-mt.251.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.251.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.251 Author: mt Time: 26 November 2019, 5:31:52.470764 pm UUID: 668e9ecf-898c-a64f-b8a3-da854a20b0c1 Ancestors: ToolBuilder-Morphic-mt.250 Complements Morphic-mt.1595. =============== Diff against ToolBuilder-Morphic-mt.250 =============== Item was changed: ----- Method: PluggableListMorphPlus>>startDrag: (in category 'drag and drop') ----- startDrag: evt | item itemMorph modelIndex | dragItemSelector ifNil:[^self]. evt hand hasSubmorphs ifTrue: [^ self]. self model okToChange ifFalse: [^ self]. "Ensure selection to save additional click." (self modelIndexFor: (self rowAtLocation: evt position)) in: [:evtIndex | self selectionIndex = evtIndex ifFalse: [self changeModelSelection: evtIndex]]. item := self selection ifNil: [^ self]. itemMorph := StringMorph contents: item asStringOrText. modelIndex := self modelIndexFor: self selectionIndex. [ "Initiate drag." (self model perform: dragItemSelector with: modelIndex) ifNotNil: [:passenger | | ddm | ddm := (self valueOfProperty: #dragTransferClass ifAbsent: [TransferMorph]) withPassenger: passenger from: self. ddm dragTransferType: (self dragTypeSelector ifNotNil: [:s | self model perform: s with: modelIndex]). ddm updateFromUserInputEvent: evt. self dragStartedSelector ifNotNil: [:s | self model perform: s with: itemMorph with: ddm]. + evt hand grabMorph: ddm. + self mouseEnterDragging: evt "Enable internal move"]. + ] ensure: [Cursor normal show]! - evt hand grabMorph: ddm]. - ] ensure: [ - Cursor normal show. - evt hand releaseMouseFocus: self]!

1 0

The Trunk: Morphic-mt.1595.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1595.mcz ==================== Summary ==================== Name: Morphic-mt.1595 Author: mt Time: 26 November 2019, 5:30:59.627764 pm UUID: b706474f-6b3b-b949-a8c4-dab4da0cc2f3 Ancestors: Morphic-mt.1594 Fixes internal drag-drop-move in pluggable lists. Thanks to Jakob (jr)! =============== Diff against Morphic-mt.1594 =============== Item was changed: + ----- Method: PluggableListMorph>>mouseLeaveDragging: (in category 'events') ----- - ----- Method: PluggableListMorph>>mouseLeaveDragging: (in category 'event handling') ----- mouseLeaveDragging: anEvent self hoverRow: nil. + anEvent hand releaseMouseFocus: self. (self dropEnabled and:[anEvent hand hasSubmorphs]) ifFalse: ["no d&d" ^ super mouseLeaveDragging: anEvent]. self resetPotentialDropRow. - anEvent hand releaseMouseFocus: self. "above is ugly but necessary for now" ! Item was changed: ----- Method: PluggableListMorph>>startDrag: (in category 'drag and drop') ----- startDrag: evt | item itemMorph | evt hand hasSubmorphs ifTrue: [^ self]. self model okToChange ifFalse: [^ self]. "Ensure selection to save additional click." (self rowAtLocation: evt position) in: [:clickedRow | self selectionIndex = clickedRow ifFalse: [self changeModelSelection: (self modelIndexFor: clickedRow)]]. item := self selection ifNil: [^ self]. itemMorph := StringMorph contents: item asStringOrText. [ "Initiate drag." (self model dragPassengerFor: itemMorph inMorph: self) ifNotNil: [:passenger | | ddm | ddm := (self valueOfProperty: #dragTransferClass ifAbsent: [TransferMorph]) withPassenger: passenger from: self. ddm dragTransferType: (self model dragTransferTypeForMorph: self). ddm updateFromUserInputEvent: evt. self model dragStartedFor: itemMorph transferMorph: ddm. + evt hand grabMorph: ddm. + self mouseEnterDragging: evt "Enable internal move"] + ] ensure: [Cursor normal show].! - evt hand grabMorph: ddm] - ] ensure: [ - Cursor normal show. - evt hand releaseMouseFocus: self].!

1 0

[BUG] 5.3 Alpha: No Text formatting in tree morphs
by Jakob Reschke 26 Nov '19

26 Nov '19

Hi all, It used to be that you can return a formatted Text from the method designated via the label selector of a pluggable tree. This screenshot is from Squeak 5.2: [image: image.png] In Trunk, this is broken. With the same code, the node labels are always unformatted, (except for the highlight color, which is used in ObjectExplorer, for example): [image: image.png] In case it was never supposed to work like that, how can I have Text-formatted labels in a pluggable tree in a supported way? Kind regards, Jakob Code excerpts for reference: chooserWidgetSpecs: builder ^ {builder pluggableTreeSpec new "..." label: #nodeLabelOf:; "..." nodeLabelOf: aSquotDiffNode | title | title := aSquotDiffNode title. ^ aSquotDiffNode anyChildNeedsChoice ifTrue: [(Text fromString: title) allBold; yourself] ifFalse: [title]

2 6

The Trunk: Morphic-mt.1594.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1594.mcz ==================== Summary ==================== Name: Morphic-mt.1594 Author: mt Time: 26 November 2019, 4:39:59.476764 pm UUID: 93c42f58-dfe3-bb42-85a6-0ba82ea72017 Ancestors: Morphic-jr.1593 Fixes that regression with custom text attributes in tree widgets. =============== Diff against Morphic-jr.1593 =============== Item was changed: ----- Method: IndentingListItemMorph>>getLabelFor: (in category 'model access') ----- getLabelFor: model + "Note that the given model is usually aListItemWrapper." + + ^ model asStringOrText! - - ^ model asString! Item was added: + ----- Method: IndentingListItemMorph>>initWithColor:andFont: (in category 'initialization') ----- + initWithColor: aColor andFont: aFont + + (self hasProperty: #hasColorFromText) + ifFalse: [self color: aColor]. + + (self hasProperty: #hasEmphasisFromText) + ifTrue: [ + (self hasProperty: #hasFontFromText) + ifFalse: [self font: aFont "Keeps emphasis from text."]] + ifFalse: [ + (self hasProperty: #hasFontFromText) + ifTrue: [self emphasis: aFont emphasis "Keeps font from text."] + ifFalse: [self font: aFont emphasis: aFont emphasis]] + ! Item was added: + ----- Method: IndentingListItemMorph>>initializeFromText: (in category 'initialization') ----- + initializeFromText: aText + "Overridden to keep track of text-based attributes." + + | priorFont priorEmphasis priorColor | + priorFont := self font. + priorEmphasis := self emphasis. + priorColor := self color. + + super initializeFromText: aText. + + priorFont == self font + ifFalse: [self setProperty: #hasFontFromText toValue: true]. + priorFont == self emphasis + ifFalse: [self setProperty: #hasEmphasisFromText toValue: true]. + priorColor == self color + ifFalse: [self setProperty: #hasColorFromText toValue: true].! Item was added: + ----- Method: ListItemWrapper>>asStringOrText (in category 'converting') ----- + asStringOrText + "Documentation only. You can create a custom wrapper that returns text with formatting. The tree widget will then use the text attributes of the first characters and applies them to the entire label. LazyListMorph works the same way." + + ^ self asString! Item was changed: ----- Method: SimpleHierarchicalListMorph>>addMorphsTo:from:allowSorting:withExpandedItems:atLevel: (in category 'private') ----- addMorphsTo: morphList from: aCollection allowSorting: sortBoolean withExpandedItems: expandedItems atLevel: newIndent | priorMorph newCollection firstAddition | priorMorph := nil. newCollection := (sortBoolean and: [sortingSelector notNil]) ifTrue: [ aCollection sorted: [ :a :b | (a perform: sortingSelector) <= (b perform: sortingSelector)] ] ifFalse: [ aCollection ]. firstAddition := nil. newCollection do: [:item | priorMorph := self indentingItemClass basicNew initWithContents: item prior: priorMorph forList: self indentLevel: newIndent. priorMorph + initWithColor: self textColor + andFont: self font. + priorMorph - color: self textColor; - font: self font; selectionColor: self selectionColor; selectionTextColor: self selectionTextColor; hoverColor: self hoverColor; highlightTextColor: self highlightTextColor; filterColor: self filterColor; filterTextColor: self filterTextColor. firstAddition ifNil: [firstAddition := priorMorph]. morphList add: priorMorph. ((item hasEquivalentIn: expandedItems) or: [priorMorph isExpanded]) ifTrue: [ self flag: #bug. "mt: Endless recursion can happen for similar items in the tree." priorMorph isExpanded: true. priorMorph addChildrenForList: self addingTo: morphList withExpandedItems: expandedItems. ]. ]. ^firstAddition ! Item was changed: ----- Method: StringMorph>>font: (in category 'accessing') ----- font: aFont "Set the font my text will use. The emphasis remains unchanged." - aFont = font ifTrue: [^ self]. - self setFont: (aFont emphasized: self emphasis) emphasis: self emphasis.! Item was changed: ----- Method: StringMorph>>initWithContents:font:emphasis: (in category 'initialization') ----- + initWithContents: aStringOrText font: aFont emphasis: emphasisCode - initWithContents: aString font: aFont emphasis: emphasisCode self initialize. + aStringOrText isText + ifTrue: [self initializeFromText: aStringOrText] + ifFalse: [ + self initializeFromString: aStringOrText. + self font: aFont emphasis: emphasisCode].! - contents := aString. - - self font: aFont emphasis: emphasisCode.! Item was added: + ----- Method: StringMorph>>initializeFromString: (in category 'initialization') ----- + initializeFromString: aString + + contents := aString.!

2 1

MessageBrowser labelling improved
by tim Rowledge 26 Nov '19

26 Nov '19

Something that has irritated me for ages has finally driven me to bang on it and make things a smidge less annoying. When you open a message browser (with an 'implementors of' for example) it normally starts up with a perfectly reasonable looking label; like 'Senders of add:rn:imm:ror: (4)' in my image today. Click on one of the listed methods and the label gets changed to the less helpful 'senders of add:'. Sigh. What happens is that the message name passed to the tool building gets 'processed' and a multi-argument keyword gets truncated to the first part of the message - hence #add:rn:imm:ror: -> #add:. This seems to have been done to allow the auto-select to try to find the first instance of the relevant message in the code. However, several layers of changes over the years appear to have combined to make things a bit more complex than necessary and a couple of simple changes can make the window label more consistent. Instead of keeping an array of pre-processed message names we can keep the entire thing. When the method is selected and the text view updated it can be passed a processed message name. That way the window label that is derived from the message can stay 'correct'. There is still one weirdness that I can't be fussed with today, where the window label when nothing is selected become e.g. 'Senders of add:rn:imm:ror: (4)'. I can see that having the number of instances attached might be interesting but it becomes a bit pointless as soon as you use the message tracing to add in some senders or implementors - now there are more than the original number! We could - should - improve the way the message is found and selected in the text view. Right now it is a trivial string search for the first case of the shortened selector. We do better than this in the debugger, so maybe someone might like to try using the same tricks to highlight the first case of the full message, which would have the nice extra bonus of not 'finding' in the comments. The attached changeset seems to do the job but I've been wrong before and might have missed something. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: DNPG: Do Not Pass Go

3 3

The Trunk: Tools-jr.894.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-jr.894.mcz ==================== Summary ==================== Name: Tools-jr.894 Author: jr Time: 21 September 2019, 11:33:52.065709 am UUID: 7230df17-e4e8-a945-b028-d534271ded3b Ancestors: Tools-jr.893 Fix error in help balloons for class comments in MessageSet Also add code to support the other special items: class definition, hierarchy. The text extraction expressions come from MessageSet>>selectedMessage. Add fallback nil check in messageHelpForMethod:. =============== Diff against Tools-jr.893 =============== Item was changed: ----- Method: CodeHolder>>messageHelpForMethod: (in category 'message list') ----- messageHelpForMethod: aMethod "Answer the formatted help text for a method." "Show the first n lines of the source code of the method." + | source formatted | + aMethod ifNil: [^ nil]. - | source formatted lineCount | source := aMethod getSource. formatted := (Smalltalk classNamed: #SHTextStylerST80) ifNil: [ source asText ] ifNotNil: [ :textStylerClass | textStylerClass new classOrMetaClass: aMethod methodClass; styledTextFor: source asText ]. + ^ self messageHelpTruncated: formatted! - - lineCount := 0. - source doWithIndex: [:char :index | - char = Character cr ifTrue: [lineCount := lineCount + 1]. - lineCount > 10 ifTrue: [ - formatted := formatted copyFrom: 1 to: index-1. - formatted append: ' [...]'. - ^ formatted]]. - - ^ formatted! Item was added: + ----- Method: CodeHolder>>messageHelpTruncated: (in category 'message list') ----- + messageHelpTruncated: aText + "Show only the first n lines of the text." + | formatted lineCount | + formatted := aText. + lineCount := 0. + aText doWithIndex: [:char :index | + char = Character cr ifTrue: [lineCount := lineCount + 1]. + lineCount > 10 ifTrue: [ + formatted := formatted copyFrom: 1 to: index-1. + formatted append: ' [...]'. + ^ formatted]]. + ^ formatted! Item was added: + ----- Method: MessageSet>>isClassDefinition: (in category 'message list') ----- + isClassDefinition: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class definition." + ^ messageListItemOrSymbol selector = #Definition! Item was added: + ----- Method: MessageSet>>isComment: (in category 'message list') ----- + isComment: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class comment." + ^ messageListItemOrSymbol selector = #Comment! Item was added: + ----- Method: MessageSet>>isHierarchy: (in category 'message list') ----- + isHierarchy: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class hierarchy." + ^ messageListItemOrSymbol selector = #Hierarchy! Item was changed: ----- Method: MessageSet>>messageHelpAt: (in category 'message list') ----- messageHelpAt: anIndex "Show the first n lines of the sources code of the selected message." | reference | Preferences balloonHelpInMessageLists ifFalse: [^ nil]. self messageList size < anIndex ifTrue: [^ nil]. reference := self messageList at: anIndex. reference isValid ifFalse: [^ nil]. + (self isComment: reference) ifTrue: [^ self messageHelpForComment: reference]. + (self isClassDefinition: reference) ifTrue: [^ self messageHelpForClassDefinition: reference]. + (self isHierarchy: reference) ifTrue: [^ self messageHelpForClassHierarchy: reference]. ^ self messageHelpForMethod: reference compiledMethod! Item was added: + ----- Method: MessageSet>>messageHelpForClassDefinition: (in category 'message list') ----- + messageHelpForClassDefinition: aMethodReference + "Answer the formatted help text for a class definition." + ^ aMethodReference setClassAndSelectorIn: [:class :sel | class definition]! Item was added: + ----- Method: MessageSet>>messageHelpForClassHierarchy: (in category 'message list') ----- + messageHelpForClassHierarchy: aMethodReference + "Answer the formatted help text for a class hierarchy." + "Show the first n lines of the class hierarchy." + | source | + source := aMethodReference setClassAndSelectorIn: [:class :sel | class printHierarchy]. + ^ self messageHelpTruncated: source asText! Item was added: + ----- Method: MessageSet>>messageHelpForComment: (in category 'message list') ----- + messageHelpForComment: aMethodReference + "Answer the formatted help text for a class comment." + "Show the first n lines of the class comment." + | source | + source := aMethodReference setClassAndSelectorIn: [:class :sel | class comment]. + ^ self messageHelpTruncated: source asText!

1 0

The Trunk: Tools-jr.893.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-jr.893.mcz ==================== Summary ==================== Name: Tools-jr.893 Author: jr Time: 20 September 2019, 9:37:14.292454 pm UUID: ff30360f-3e9b-d449-a2ee-a7644407fe27 Ancestors: Tools-mt.892 Allow to remove all selected methods from current ChangeSet in MessageTrace. Previously, only the viewed message was removed. =============== Diff against Tools-mt.892 =============== Item was added: + ----- Method: MessageTrace>>removeFromCurrentChanges (in category '*Tools') ----- + removeFromCurrentChanges + "Tell the changes mgr to forget that the selected messages were changed." + + self selectedMessages do: [:each | + each setClassAndSelectorIn: [:class :selector | + ChangeSet current removeSelectorChanges: selector class: class]]. + self changed: #annotation!

1 0

The Trunk: Tools-mt.918.mcz
by commits＠source.squeak.org 26 Nov '19

26 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.918.mcz ==================== Summary ==================== Name: Tools-mt.918 Author: mt Time: 26 November 2019, 9:01:06.905455 am UUID: 21303972-3181-0c44-a186-154a350444b3 Ancestors: Tools-mt.917, Tools-jr.894 Merges Tools-jr.894 and Tools-jr.893, which offers some fixes for MessageSet tools. Also, users can remove all selected methods in MessageTrace now. I chose to move the fixes for invalid method references down to RecentMessageSet. We should not spoil the base code with undocumented "ifNil" checks. :-) =============== Diff against Tools-mt.917 =============== Item was changed: ----- Method: CodeHolder>>messageHelpForMethod: (in category 'message list') ----- messageHelpForMethod: aMethod "Answer the formatted help text for a method." "Show the first n lines of the source code of the method." + | source formatted | - | source formatted lineCount | source := aMethod getSource. formatted := (Smalltalk classNamed: #SHTextStylerST80) ifNil: [ source asText ] ifNotNil: [ :textStylerClass | textStylerClass new classOrMetaClass: aMethod methodClass; styledTextFor: source asText ]. + ^ self messageHelpTruncated: formatted! - - lineCount := 0. - source doWithIndex: [:char :index | - char = Character cr ifTrue: [lineCount := lineCount + 1]. - lineCount > 10 ifTrue: [ - formatted := formatted copyFrom: 1 to: index-1. - formatted append: ' [...]'. - ^ formatted]]. - - ^ formatted! Item was added: + ----- Method: CodeHolder>>messageHelpTruncated: (in category 'message list') ----- + messageHelpTruncated: aText + "Show only the first n lines of the text." + | formatted lineCount | + formatted := aText. + lineCount := 0. + aText doWithIndex: [:char :index | + char = Character cr ifTrue: [lineCount := lineCount + 1]. + lineCount > 10 ifTrue: [ + formatted := formatted copyFrom: 1 to: index-1. + formatted append: ' [...]'. + ^ formatted]]. + ^ formatted! Item was added: + ----- Method: MessageSet>>isClassDefinition: (in category 'message list') ----- + isClassDefinition: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class definition." + ^ messageListItemOrSymbol selector = #Definition! Item was added: + ----- Method: MessageSet>>isComment: (in category 'message list') ----- + isComment: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class comment." + ^ messageListItemOrSymbol selector = #Comment! Item was added: + ----- Method: MessageSet>>isHierarchy: (in category 'message list') ----- + isHierarchy: messageListItemOrSymbol + "Answer whether this item from the message list (or its extracted selector) indicates a + class hierarchy." + ^ messageListItemOrSymbol selector = #Hierarchy! Item was changed: ----- Method: MessageSet>>messageHelpAt: (in category 'message list') ----- messageHelpAt: anIndex "Show the first n lines of the sources code of the selected message." | reference | Preferences balloonHelpInMessageLists ifFalse: [^ nil]. self messageList size < anIndex ifTrue: [^ nil]. reference := self messageList at: anIndex. reference isValid ifFalse: [^ nil]. + (self isComment: reference) ifTrue: [^ self messageHelpForComment: reference]. + (self isClassDefinition: reference) ifTrue: [^ self messageHelpForClassDefinition: reference]. + (self isHierarchy: reference) ifTrue: [^ self messageHelpForClassHierarchy: reference]. ^ self messageHelpForMethod: reference compiledMethod! Item was added: + ----- Method: MessageSet>>messageHelpForClassDefinition: (in category 'message list') ----- + messageHelpForClassDefinition: aMethodReference + "Answer the formatted help text for a class definition." + ^ aMethodReference setClassAndSelectorIn: [:class :sel | class definition]! Item was added: + ----- Method: MessageSet>>messageHelpForClassHierarchy: (in category 'message list') ----- + messageHelpForClassHierarchy: aMethodReference + "Answer the formatted help text for a class hierarchy." + "Show the first n lines of the class hierarchy." + | source | + source := aMethodReference setClassAndSelectorIn: [:class :sel | class printHierarchy]. + ^ self messageHelpTruncated: source asText! Item was added: + ----- Method: MessageSet>>messageHelpForComment: (in category 'message list') ----- + messageHelpForComment: aMethodReference + "Answer the formatted help text for a class comment." + "Show the first n lines of the class comment." + | source | + source := aMethodReference setClassAndSelectorIn: [:class :sel | class comment]. + ^ self messageHelpTruncated: source asText! Item was changed: + ----- Method: MessageTrace>>copySelector (in category 'menus') ----- - ----- Method: MessageTrace>>copySelector (in category '*Tools') ----- copySelector Clipboard clipboardText: (String streamContents: [ : stream | self selectedMessages do: [ : each | stream nextPutAll: each selector asString ] separatedBy: [ stream space ] ])! Item was added: + ----- Method: MessageTrace>>removeFromCurrentChanges (in category 'message list') ----- + removeFromCurrentChanges + "Tell the changes mgr to forget that the selected messages were changed." + + self selectedMessages do: [:each | + each setClassAndSelectorIn: [:class :selector | + ChangeSet current removeSelectorChanges: selector class: class]]. + self changed: #annotation! Item was added: + ----- Method: RecentMessageSet>>formattedLabel:forSelector:inClass: (in category 'message list') ----- + formattedLabel: aString forSelector: aSymbol inClass: aClass + "Overridden to account for outdated MethodReference after class renames." + + self flag: #fix. "mt: We might want to fix RecentMessages to instead. Other tools (or features) might depend on it, too." + ^ aClass + ifNil: [aString asText] + ifNotNil: [super formattedLabel: aString forSelector: aSymbol inClass: aClass] + ! Item was added: + ----- Method: RecentMessageSet>>messageHelpForMethod: (in category 'message list') ----- + messageHelpForMethod: aMethod + "Overridden to account for outdated MethodReference after class renames." + + self flag: #fix. "mt: We might want to fix RecentMessages to instead. Other tools (or features) might depend on it, too." + ^ aMethod ifNotNil: [super messageHelpForMethod: aMethod]!

1 0

The Trunk: Morphic-jr.1593.mcz
by commits＠source.squeak.org 25 Nov '19

25 Nov '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-jr.1593.mcz ==================== Summary ==================== Name: Morphic-jr.1593 Author: jr Time: 24 November 2019, 4:09:46.350968 pm UUID: a31f6451-b4c4-8549-b955-db51806e2477 Ancestors: Morphic-mt.1592 Backported From: Morphic-jr.1593 Make class list in "explain" output easier to consume. "... in these classes: an OrderedCollection(...)" is not really human-friendly. Now it prints Squeak array syntax {A . B . C}, which is still technical, but handy to copy&paste to methods or workspaces if needed. =============== Diff against Morphic-mt.1592 =============== Item was changed: ----- Method: TextEditor>>explainAnySel: (in category 'explain') ----- explainAnySel: symbol "Is this any message selector?" | list reply | list := self systemNavigation allClassesImplementing: symbol. list size = 0 ifTrue: [^nil]. list size < 12 + ifTrue: [reply := ' is a message selector which is defined in these classes: ' , list asArray printString] - ifTrue: [reply := ' is a message selector which is defined in these classes ' , list printString] ifFalse: [reply := ' is a message selector which is defined in many classes']. ^'"' , symbol , reply , '."' , '\' withCRs, 'SystemNavigation new browseAllImplementorsOf: #' , symbol!

1 0

The Trunk: ST80-jr.245.mcz
by commits＠source.squeak.org 25 Nov '19

25 Nov '19

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-jr.245.mcz ==================== Summary ==================== Name: ST80-jr.245 Author: jr Time: 24 November 2019, 4:13:20.610968 pm UUID: c21afa71-82ce-c94a-a0fd-dfcd010d49c9 Ancestors: ST80-mt.244 Make class list in "explain" output easier to consume. "... in these classes: an OrderedCollection(...)" is not really human-friendly. Now it prints Squeak array syntax {A . B . C}, which is still technical, but handy to copy&paste to methods or workspaces if needed. =============== Diff against ST80-mt.244 =============== Item was changed: ----- Method: ParagraphEditor>>explainAnySel: (in category 'explain') ----- explainAnySel: symbol "Is this any message selector?" | list reply | list := self systemNavigation allClassesImplementing: symbol. list size = 0 ifTrue: [^nil]. list size < 12 + ifTrue: [reply := ' is a message selector which is defined in these classes: ' , list asArray printString] - ifTrue: [reply := ' is a message selector which is defined in these classes ' , list printString] ifFalse: [reply := ' is a message selector which is defined in many classes']. ^'"' , symbol , reply , '."' , '\' withCRs, 'SystemNavigation new browseAllImplementorsOf: #' , symbol!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
24
Older →

Jump to page: