Squeak-dev November 2019

squeak-dev@lists.squeakfoundation.org

23 participants
232 discussions

Problems with "Hiding the Debugger invocation logic from user"
by Thiede, Christoph 22 Nov '19

22 Nov '19

Hi all, the thing I am trying to describe by the subject is the "feature" that when you do something like "self halt" anywhere, the Debugger will not show its "private" invocation stack (this includes the whole Halt and UnhandledError signaling up to the opening of the debugger). This seems to be implemented in StandardToolSet >> #handleError: where "anError signalerContext" is passed to the Process. However, there are two limitations of this effects currently: First, when you do "self halt" and expand the debugger, the "Where" button does not work until you press "Over" twice. (Found by Marcel) Second, I just discovered the following issue: 1. Do "self halt" 2. Expand the debugger 3. Press over, over, restart, into, over. Instead of "UndefinedObject>>DoIt", the control is given to a handler block in Context>>#runUntilErrorOrReturnFrom: now! Imho this is a clear bug, because the "Squeak end-user" should not be revealed this confusing implementation detail of the Debugger. I did not yet investigate the whole store of these issues, but one option might be this: After the debugger has been opened, it could directly do something like process completeTo: context (from the Debugger process, of course). But that does not solve the whole problem, so I would appreciate your help on how to fix these problems. :-) Best, Christoph

1 0

The Trunk: Tests-ct.412.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-ct.412.mcz ==================== Summary ==================== Name: Tests-ct.412 Author: ct Time: 30 June 2019, 2:11:26.54843 pm UUID: 24e0c844-757d-1246-a348-a0372f66d993 Ancestors: Tests-pre.411 Add tests for SyntaxErrorNotification>>#resume: =============== Diff against Tests-pre.411 =============== Item was added: + ----- Method: CompilerSyntaxErrorNotifyingTest>>testResumeEarlySyntaxError (in category 'tests') ----- + testResumeEarlySyntaxError + + | result | + result := [Compiler evaluate: ''''''''] + on: SyntaxErrorNotification + do: [:ex | ex resume: '''''''''']. + self assert: '''' equals: result! Item was added: + ----- Method: CompilerSyntaxErrorNotifyingTest>>testResumeLateSyntaxError (in category 'tests') ----- + testResumeLateSyntaxError + + | result | + result := [Compiler evaluate: '6*:7'] + on: SyntaxErrorNotification + do: [:ex | ex resume: '6*7']. + self assert: 42 equals: result!

1 0

The Trunk: Tests-mt.424.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.424.mcz ==================== Summary ==================== Name: Tests-mt.424 Author: mt Time: 22 November 2019, 3:12:53.436669 pm UUID: a10469ef-ba65-b546-8dc4-771983a23a95 Ancestors: Tests-mt.423, Tests-ct.412 Merges tests for syntax-error handling. =============== Diff against Tests-mt.423 =============== Item was added: + ----- Method: CompilerSyntaxErrorNotifyingTest>>testResumeEarlySyntaxError (in category 'tests') ----- + testResumeEarlySyntaxError + + | result | + result := [Compiler evaluate: ''''''''] + on: SyntaxErrorNotification + do: [:ex | ex resume: '''''''''']. + self assert: '''' equals: result! Item was added: + ----- Method: CompilerSyntaxErrorNotifyingTest>>testResumeLateSyntaxError (in category 'tests') ----- + testResumeLateSyntaxError + + | result | + result := [Compiler evaluate: '6*:7'] + on: SyntaxErrorNotification + do: [:ex | ex resume: '6*7']. + self assert: 42 equals: result!

1 0

The Trunk: Tools-ct.902.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.902.mcz ==================== Summary ==================== Name: Tools-ct.902 Author: ct Time: 2 October 2019, 11:24:54.197682 pm UUID: 4661db82-a61f-5b4c-8747-e0888c4e7590 Ancestors: Tools-ul.899 Shortens Inspector constructors and deprecates #withEvalPane argument that is no longer in use If approbated, I can move the deprecated methods into *60Deprecated package, of course ... =============== Diff against Tools-ul.899 =============== Item was changed: ----- Method: Inspector class>>openOn: (in category 'instance creation') ----- openOn: anObject "Create and schedule an instance of me on the model, anInspector. " + ^ self openOn: anObject withLabel: anObject defaultLabelForInspector! - ^ self openOn: anObject withEvalPane: true! Item was changed: ----- Method: Inspector class>>openOn:withEvalPane: (in category 'instance creation') ----- openOn: anObject withEvalPane: withEval "Create and schedule an instance of me on the model, anInspector. " + self deprecated. - ^ self openOn: anObject withEvalPane: withEval withLabel: anObject defaultLabelForInspector! Item was changed: ----- Method: Inspector class>>openOn:withEvalPane:withLabel: (in category 'instance creation') ----- openOn: anObject withEvalPane: withEval withLabel: label + self deprecated. ^ToolBuilder open: (self inspect: anObject) label: label! Item was added: + ----- Method: Inspector class>>openOn:withLabel: (in category 'instance creation') ----- + openOn: anObject withLabel: label + + ^ ToolBuilder open: (self inspect: anObject) label: label! Item was changed: ----- Method: ProcessBrowser>>inspectPointers (in category 'process actions') ----- inspectPointers | tc pointers | selectedProcess ifNil: [^self]. tc := thisContext. pointers := PointerFinder pointersTo: selectedProcess except: { self processList. tc. self}. pointers isEmpty ifTrue: [^self]. OrderedCollectionInspector openOn: pointers - withEvalPane: false withLabel: 'Objects pointing to ' , selectedProcess browserPrintString!

1 0

The Trunk: Tools-ct.904.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.904.mcz ==================== Summary ==================== Name: Tools-ct.904 Author: ct Time: 3 October 2019, 12:50:44.829083 am UUID: de2580f2-be4a-2546-b695-7c658ff3e1fe Ancestors: Tools-ul.899 Adds link to turn off warnings in ToolSet>>#handleWarning: =============== Diff against Tools-ul.899 =============== Item was changed: ----- Method: StandardToolSet class>>handleWarning: (in category 'debugging - handlers') ----- handleWarning: aWarning "Double dispatch. Let the active process take care of that warning, which usually calls back here to #debugProcess:..." + | message | + message := TextStream with: aWarning messageText asText. + message cr; cr; nextPutAll: 'Select Proceed to continue, or close this window to cancel the operation.' translated. + (aWarning class respondsTo: #turnOffWarnings) ifTrue: [ + message cr; cr; + withAttribute: (PluggableTextAttribute evalBlock: [ + aWarning class turnOffWarnings. + self inform: 'Preferences were updated.' translated]) + do: [message nextPutAll: 'Turn off these warnings' translated]]. ^ Processor activeProcess debug: aWarning signalerContext title: 'Warning' translated full: false + contents: message contents! - contents: aWarning messageText , '\\Select Proceed to continue, or close this window to cancel the operation.' withCRs translated!

1 0

The Trunk: ST80-mt.244.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.244.mcz ==================== Summary ==================== Name: ST80-mt.244 Author: mt Time: 22 November 2019, 2:13:01.763303 pm UUID: 0da72d4e-ba58-4a43-90ab-138d7cce93dd Ancestors: ST80-mt.243 Complements Tools-mt.917. =============== Diff against ST80-mt.243 =============== Item was changed: ----- Method: FormInspectView class>>openOn:withLabel: (in category 'instance creation') ----- openOn: aFormDictionary withLabel: aLabel "open a graphical dictionary in a window having the label aLabel. aFormDictionary should be a dictionary containing as value a form." ^ DictionaryInspector openOn: aFormDictionary - withEvalPane: true withLabel: aLabel !

1 0

The Trunk: EToys-mt.370.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.370.mcz ==================== Summary ==================== Name: EToys-mt.370 Author: mt Time: 22 November 2019, 2:12:24.581303 pm UUID: e6bf7952-2ec5-4041-9fa0-a2c5455f3202 Ancestors: EToys-nice.369 Complements Tools-mt.917. =============== Diff against EToys-nice.369 =============== Item was changed: ----- Method: HtmlEntity>>inspect (in category 'user interface') ----- inspect "Open an HtmlEntityInspector on the receiver. Use basicInspect to get a normal type of inspector." + HtmlEntityInspector openOn: self! - HtmlEntityInspector openOn: self withEvalPane: true! Item was changed: ----- Method: HtmlEntity>>inspectWithLabel: (in category 'user interface') ----- inspectWithLabel: aLabel "Open a HtmlEntityInspector on the receiver. Use basicInspect to get a normal (less useful) type of inspector." + HtmlEntityInspector openOn: self withLabel: aLabel! - HtmlEntityInspector openOn: self withEvalPane: true withLabel: aLabel!

1 0

The Trunk: 60Deprecated-mt.64.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of 60Deprecated to project The Trunk: http://source.squeak.org/trunk/60Deprecated-mt.64.mcz ==================== Summary ==================== Name: 60Deprecated-mt.64 Author: mt Time: 22 November 2019, 2:11:49.344303 pm UUID: 71813448-eb53-7944-9848-8308052da3eb Ancestors: 60Deprecated-mt.63 Complements Tools-mt.917. =============== Diff against 60Deprecated-mt.63 =============== Item was added: + ----- Method: Inspector class>>openOn:withEvalPane: (in category '*60Deprecated-instance creation') ----- + openOn: anObject withEvalPane: withEval + "Create and schedule an instance of me on the model, anInspector. " + self deprecated. + ^ ToolBuilder open: (self inspect: anObject) label: anObject defaultLabelForInspector! Item was added: + ----- Method: Inspector class>>openOn:withEvalPane:withLabel: (in category '*60Deprecated-instance creation') ----- + openOn: anObject withEvalPane: withEval withLabel: label + self deprecated. + ^ToolBuilder open: (self inspect: anObject) label: label!

1 0

The Trunk: Tools-ct.916.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.916.mcz ==================== Summary ==================== Name: Tools-ct.916 Author: ct Time: 15 November 2019, 7:00:12.771005 pm UUID: 05c08fc9-78c5-ea45-842e-dfc847d32551 Ancestors: Tools-mt.914 VersionsBrowser>>#selectMethod:: Compare not only timeStamp, but also source, as timeStamp is only minute-precise. =============== Diff against Tools-mt.914 =============== Item was changed: ----- Method: VersionsBrowser>>selectMethod: (in category 'menu') ----- selectMethod: aCompiledMethod self toggleListIndex: (self changeList indexOf: ( + self changeList detect: [:change | + change stamp = aCompiledMethod timeStamp and: [ + change string = aCompiledMethod getSource asString]]))! - self changeList detect: [:change | change stamp = aCompiledMethod timeStamp]))!

1 0

The Trunk: Tools-ct.915.mcz
by commits＠source.squeak.org 22 Nov '19

22 Nov '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.915.mcz ==================== Summary ==================== Name: Tools-ct.915 Author: ct Time: 15 November 2019, 5:30:02.890005 pm UUID: 326d55bd-8463-7e43-a517-e934932fb3a9 Ancestors: Tools-mt.914 Refactor ProcessBrowser nil checks again and move them into #stackListKey:from:. Also, use #browseMethod: in #browseContext to ensure the right version is browsed Thanks to Marcel for the review! =============== Diff against Tools-mt.914 =============== Item was changed: ----- Method: ProcessBrowser>>browseContext (in category 'stack list') ----- browseContext + ToolSet browseMethod: selectedContext method! - selectedContext - ifNil: [^ self]. - ToolSet browse: self selectedClass selector: self selectedSelector! Item was changed: ----- Method: ProcessBrowser>>changePriority (in category 'process actions') ----- changePriority | str newPriority nameAndRules | - selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules third ifFalse: [self inform: 'Nope, won''t change priority of ' , nameAndRules first. ^ self]. str := UIManager default request: 'New priority' initialAnswer: selectedProcess priority asString. newPriority := str asNumber asInteger. newPriority ifNil: [^ self]. (newPriority < 1 or: [newPriority > Processor highestPriority]) ifTrue: [self inform: 'Bad priority'. ^ self]. self class setProcess: selectedProcess toPriority: newPriority. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>chasePointers (in category 'process actions') ----- chasePointers | saved | - selectedProcess ifNil: [^ self]. saved := selectedProcess. [selectedProcess := nil. (Smalltalk includesKey: #PointerFinder) ifTrue: [PointerFinder on: saved] ifFalse: [self inspectPointers]] ensure: [selectedProcess := saved]! Item was changed: ----- Method: ProcessBrowser>>debugProcess (in category 'process actions') ----- debugProcess | nameAndRules | - selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules third ifFalse: [self inform: 'Nope, won''t debug ' , nameAndRules first. ^ self]. self class debugProcess: selectedProcess.! Item was changed: ----- Method: ProcessBrowser>>exploreContext (in category 'stack list') ----- exploreContext + selectedContext explore! - selectedContext ifNotNil: #explore! Item was changed: ----- Method: ProcessBrowser>>exploreProcess (in category 'process list') ----- exploreProcess + selectedProcess explore! - selectedProcess ifNotNil: #explore! Item was changed: ----- Method: ProcessBrowser>>exploreReceiver (in category 'stack list') ----- exploreReceiver + selectedContext receiver explore! - selectedContext ifNotNil: [ - selectedContext receiver explore]! Item was changed: ----- Method: ProcessBrowser>>inspectContext (in category 'stack list') ----- inspectContext + selectedContext inspect! - selectedContext ifNotNil: #inspect! Item was changed: ----- Method: ProcessBrowser>>inspectPointers (in category 'process actions') ----- inspectPointers | tc pointers | - selectedProcess ifNil: [^ self]. tc := thisContext. pointers := PointerFinder pointersTo: selectedProcess except: { self processList. tc. self}. pointers isEmpty ifTrue: [^ self]. OrderedCollectionInspector openOn: pointers withEvalPane: false withLabel: 'Objects pointing to ' , selectedProcess browserPrintString! Item was changed: ----- Method: ProcessBrowser>>inspectProcess (in category 'process list') ----- inspectProcess + selectedProcess inspect! - selectedProcess ifNotNil: #inspect! Item was changed: ----- Method: ProcessBrowser>>inspectReceiver (in category 'stack list') ----- inspectReceiver + selectedContext receiver inspect! - selectedContext ifNotNil: [ - selectedContext receiver inspect]! Item was changed: ----- Method: ProcessBrowser>>messageTally (in category 'stack list') ----- messageTally | secString secs | - selectedProcess ifNil: [^ self]. secString := UIManager default request: 'Profile for how many seconds?' initialAnswer: '4'. secString isEmptyOrNil ifTrue: [^ self]. secs := secString asNumber asInteger. (secs isNil or: [secs isZero]) ifTrue: [^ self]. [ TimeProfileBrowser spyOnProcess: selectedProcess forMilliseconds: secs * 1000 ] forkAt: selectedProcess priority + 1.! Item was changed: ----- Method: ProcessBrowser>>processListKey:from: (in category 'process list') ----- + processListKey: aKey from: aView + + aKey + caseOf: { + [$f] -> [^ self findContext]. + [$g] -> [^ self nextContext]. + [$a] -> [^ self toggleAutoUpdate]. + [$u] -> [^ self updateProcessList] } + otherwise: []. + selectedProcess ifNil: [^ self changed: #flash]. + ^ aKey + caseOf: { + [$i] -> [self inspectProcess]. + [$I] -> [self exploreProcess]. + [$c] -> [self chasePointers]. + [$P] -> [self inspectPointers]. + [$t] -> [self terminateProcess]. + [$r] -> [self resumeProcess]. + [$s] -> [self suspendProcess]. + [$d] -> [self debugProcess]. + [$p] -> [self changePriority]. + [$m] -> [self messageTally]. + [$S] -> [self signalSemaphore]. + [$k] -> [self moreStack]} + otherwise: [self arrowKey: aKey from: aView]! - processListKey: aKey from: aView - ^ aKey caseOf: { - [$i] -> [self inspectProcess]. - [$I] -> [self exploreProcess]. - [$c] -> [self chasePointers]. - [$P] -> [self inspectPointers]. - [$t] -> [self terminateProcess]. - [$r] -> [self resumeProcess]. - [$s] -> [self suspendProcess]. - [$d] -> [self debugProcess]. - [$p] -> [self changePriority]. - [$m] -> [self messageTally]. - [$f] -> [self findContext]. - [$g] -> [self nextContext]. - [$a] -> [self toggleAutoUpdate]. - [$u] -> [self updateProcessList]. - [$S] -> [self signalSemaphore]. - [$k] -> [self moreStack]} - otherwise: [self arrowKey: aKey from: aView]! Item was changed: ----- Method: ProcessBrowser>>resumeProcess (in category 'process actions') ----- resumeProcess - selectedProcess ifNil: [^ self]. self class resumeProcess: selectedProcess. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>signalSemaphore (in category 'process actions') ----- signalSemaphore - selectedProcess ifNil: [^ self]. (selectedProcess suspendingList isKindOf: Semaphore) ifFalse: [^ self]. [selectedProcess suspendingList signal] fork. (Delay forMilliseconds: 300) wait. "Hate to make the UI wait, but it's convenient..." self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>stackListKey:from: (in category 'views') ----- + stackListKey: aKey from: aView + + selectedContext ifNil: [^ self changed: #flash]. + ^ aKey + caseOf: { + [$c] -> [self inspectContext]. + [$C] -> [self exploreContext]. + [$i] -> [self inspectReceiver]. + [$I] -> [self exploreReceiver]. + [$b] -> [self browseContext]} + otherwise: [self arrowKey: aKey from: aView]! - stackListKey: aKey from: aView - ^ aKey caseOf: { - [$c] -> [self inspectContext]. - [$C] -> [self exploreContext]. - [$i] -> [self inspectReceiver]. - [$I] -> [self exploreReceiver]. - [$b] -> [self browseContext]} - otherwise: [self arrowKey: aKey from: aView]! Item was changed: ----- Method: ProcessBrowser>>suspendProcess (in category 'process actions') ----- suspendProcess | nameAndRules | - selectedProcess ifNil: [^ self]. selectedProcess isSuspended ifTrue: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules second ifFalse: [self inform: 'Nope, won''t suspend ' , nameAndRules first. ^ self]. self class suspendProcess: selectedProcess. self updateProcessList! Item was changed: ----- Method: ProcessBrowser>>terminateProcess (in category 'process actions') ----- terminateProcess | nameAndRules | - selectedProcess ifNil: [^ self]. nameAndRules := self nameAndRulesForSelectedProcess. nameAndRules second ifFalse: [self inform: 'Nope, won''t kill ' , nameAndRules first. ^ self]. self class terminateProcess: selectedProcess. self updateProcessList!

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
24
Older →

Jump to page: