Squeak-dev October 2019

squeak-dev@lists.squeakfoundation.org

41 participants
284 discussions

The Inbox: System-ct.1118.mcz
by commits＠source.squeak.org 26 Oct '19

26 Oct '19

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1118.mcz ==================== Summary ==================== Name: System-ct.1118 Author: ct Time: 26 October 2019, 9:53:56.908469 pm UUID: 813aa07b-dde6-7f46-af06-552f9f2f1b37 Ancestors: System-mt.1116 Adds execute-around utility to change an AppRegistry default temporarily "Usage:" SoundService setDefault: DummySoundSystem new during: [SoundService beep] =============== Diff against System-mt.1116 =============== Item was added: + ----- Method: AppRegistry class>>setDefault:during: (in category 'defaults') ----- + setDefault: aClassOrNil during: aBlock + + | previousDefault | + previousDefault := self default. + self default: aClassOrNil. + ^ aBlock ensure: [ + self default: previousDefault]!

1 0

Don Goodman-Wilson’s moral critique of Open Source
by Eliot Miranda 25 Oct '19

25 Oct '19

Don Goodman-Wilson’s moral critique of Open Source; essential reading. “What if we look at Open Source values through the lens of moral philosophy, by applying Scanlon’s contractualist theory of morality? When we do that, I think it becomes pretty clear that we ought to discard openness as an axiom, and start thinking about other ways to build software collaboratively that do not make us accessory to horrors. We can create open communities, better communities, more inclusive communities, without Open Source. The Open Source movement has always been focused on code. The result is a system that sadly neglects people." ... “Here are some candidate principles to guide an ethical conception of collaborative development.” https://don.goodman-wilson.com/posts/open-source-is-broken/ _,,,^..^,,,_ (phone)

6 7

The Trunk: Morphic-mt.1514.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1514.mcz ==================== Summary ==================== Name: Morphic-mt.1514 Author: mt Time: 5 September 2019, 2:36:47.777837 pm UUID: 49f63b40-72ce-c447-9fb0-9400ea43fab2 Ancestors: Morphic-mt.1513, Morphic-ct.1501 Merges Morphic-ct.1500. and 1501. Can't we just filter for #isAlphaNumeric? Do we need parentheses etc.? Would be more readable than ">= 32". I also do not think that #caseOf: helps much in terms of readability. ;-) =============== Diff against Morphic-mt.1513 =============== Item was changed: ----- Method: MenuMorph>>handleFiltering: (in category 'keystroke helpers') ----- handleFiltering: evt | matchString | matchString := self valueOfProperty: #matchString ifAbsentPut: [ String new ]. + matchString := true + caseOf: { + [ evt keyCharacter = Character backspace ] -> + [ matchString isEmpty + ifTrue: [ matchString ] + ifFalse: [ matchString allButLast ] ]. + [ evt keyValue >= 32 ] -> + [ matchString , evt keyCharacter ] } + otherwise: [ matchString ]. - matchString := evt keyValue = 8 " Character backspace asciiValue " - ifTrue: [ - matchString isEmpty - ifTrue: [ matchString ] - ifFalse: [ matchString allButLast ] ] - ifFalse: [ - matchString copyWith: evt keyCharacter ]. self setProperty: #matchString toValue: matchString. self displayFiltered: evt!

6 7

Fractional bounds and flickering (contains images that may be disturbing to some readers)
by Thiede, Christoph 25 Oct '19

25 Oct '19

Hi all, In the latest days, I encountered flickering problems caused by non-integer bounds of system windows again. For me, the following fails reproducibly in different images: SystemWindow new openInWorld extent: (24214/31)@(11565/31). If I hover and unhover the window a few times, its contents are drawn badly and incompletely like this: [cid:c4d513fa-a423-45b7-9cda-1182a88d7d4a] * As you can see, the issue also affects other morphs in the same region (in the screenshot I am hovering the implementors button of the background browser). * The issue only occurs with very complex fractions, so the extent 500 @ 300 / 2 would not be a problem (at least in my image). I could not reproduce it using floats. * The situation can be also reproduced by composing a few morphs manually, but the more submorphs there, the higher the flickering rate appears to be. * [World imageForm] does not contain any abnormalities, maybe the problem is related to the damage recording? I would like to solve this bug, but I'm not sure where the problem actually arises. In general, should morphs be allowed to have non-integer bounds? This could be useful e. g. for exact animations, but we already have some rounding that (unfortunately) rule out this use case: * #position: appears to round the delta value for movement * #extent: and #bounds: do no rounding at all. Should we maybe apply some rounding or at least truncating there? Or just convert the arguments using #asFloat before? Or do you have any idea how one could debug the problem? (For relevancy: I often call Preferences >> #changeFontSize:, and each time all windows are drawn badly until I round their bounds. This can indeed be quite annoying: [cid:e830eb65-4369-445c-acec-b060b136e348]) Looking forward to your help! Best, Christoph

4 6

The Inbox: HelpSystem-Core-ct.125.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

A new version of HelpSystem-Core was added to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.125.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.125 Author: ct Time: 14 October 2019, 12:33:57.997932 am UUID: bdc17b48-7f21-844e-ad05-f3ba9876fd3f Ancestors: HelpSystem-Core-mt.116 Adds CustomHelp>>#defaultPageKey to show the contents of a specified subtopic if a ClassBasedHelpTopic is selected =============== Diff against HelpSystem-Core-mt.116 =============== Item was changed: ----- Method: ClassBasedHelpTopic>>contents (in category 'accessing') ----- contents "A book has no contents. Only its pages do." + ^ self defaultSubtopic ifNil: [''] ifNotNil: #contents! - ^ ''! Item was added: + ----- Method: ClassBasedHelpTopic>>defaultSubtopic (in category 'accessing') ----- + defaultSubtopic + + ^ self helpClass defaultPageKey + ifNotNil: [:key | + self subtopics + detect: [:topic | topic key = key] + ifNone: [nil]] + ifNil: [nil]! Item was added: + ----- Method: ClassBasedHelpTopic>>key (in category 'accessing') ----- + key + + ^ self helpClass! Item was added: + ----- Method: CustomHelp class>>defaultPageKey (in category 'accessing') ----- + defaultPageKey + "Key of the page to show if no subtopic is selected, or nil" + ^ nil!

4 4

The Inbox: System-ct.1112.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1112.mcz ==================== Summary ==================== Name: System-ct.1112 Author: ct Time: 3 October 2019, 1:00:59.749083 am UUID: 46296c5c-1bbf-8849-96ad-70af15677f55 Ancestors: System-pre.1111 Recategorizes Smalltalk startup + shutdown list methods =============== Diff against System-pre.1111 =============== Item was changed: + ----- Method: SmalltalkImage>>add:toList:after: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>add:toList:after: (in category 'startup list') ----- add: aClass toList: startUpOrShutDownList after: predecessor "Add the name of aClass to the startUp or shutDown list. Add it after the name of predecessor" (Smalltalk globals includes: aClass) ifFalse: [self error: aClass name , ' cannot be found in Smalltalk dictionary.']. "Add after predecessor, moving it if already there." (Smalltalk globals includes: predecessor) ifFalse: [self error: predecessor name , ' cannot be found in Smalltalk dictionary.']. (startUpOrShutDownList includes: predecessor name) ifFalse: [self error: predecessor name , ' cannot be found in the list.']. startUpOrShutDownList remove: aClass name ifAbsent:[]. startUpOrShutDownList add: aClass name after: predecessor name! Item was changed: + ----- Method: SmalltalkImage>>add:toList:before: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>add:toList:before: (in category 'startup list') ----- add: aClass toList: startUpOrShutDownList before: successor "Add the name of aClass to the startUp or shutDown list. Add it before the name of successor" (Smalltalk globals includes: aClass) ifFalse: [self error: aClass name , ' cannot be found in Smalltalk dictionary.']. "Add before successor, moving it if already there." (Smalltalk globals includes: successor) ifFalse: [self error: successor name , ' cannot be found in Smalltalk dictionary.']. (startUpOrShutDownList includes: successor name) ifFalse: [self error: successor name , ' cannot be found in the list.']. startUpOrShutDownList remove: aClass name ifAbsent: []. startUpOrShutDownList add: aClass name before: successor name.! Item was changed: + ----- Method: SmalltalkImage>>addToShutDownList: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>addToShutDownList: (in category 'startup list') ----- addToShutDownList: aClass "This will add a ref to this class at the BEGINNING of the shutDown list." "No-op if already in the list." (ShutDownList includes: aClass name) ifFalse: [ShutDownList addFirst: aClass name]! Item was changed: + ----- Method: SmalltalkImage>>addToShutDownList:before: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>addToShutDownList:before: (in category 'startup list') ----- addToShutDownList: aClass before: predecessor self add: aClass toList: ShutDownList before: predecessor! Item was changed: + ----- Method: SmalltalkImage>>addToStartUpList: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>addToStartUpList: (in category 'startup list') ----- addToStartUpList: aClass "This will add a ref to this class at the END of the startUp list." "No-op if already in the list." (StartUpList includes: aClass name) ifFalse: [StartUpList addLast: aClass name]! Item was changed: + ----- Method: SmalltalkImage>>addToStartUpList:before: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>addToStartUpList:before: (in category 'startup list') ----- addToStartUpList: aClass before: predecessor self add: aClass toList: StartUpList before: predecessor! Item was changed: + ----- Method: SmalltalkImage>>removeFromShutDownList: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>removeFromShutDownList: (in category 'snapshot and quit') ----- removeFromShutDownList: aClass ShutDownList remove: aClass name ifAbsent: []! Item was changed: + ----- Method: SmalltalkImage>>removeFromStartUpList: (in category 'startup + shutdown list') ----- - ----- Method: SmalltalkImage>>removeFromStartUpList: (in category 'snapshot and quit') ----- removeFromStartUpList: aClass StartUpList remove: aClass name ifAbsent: []!

3 2

The Inbox: System-ct.1117.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1117.mcz ==================== Summary ==================== Name: System-ct.1117 Author: ct Time: 25 October 2019, 6:50:10.960469 pm UUID: 432c3317-b7e9-784f-9534-f86d8d09ff88 Ancestors: System-mt.1116 Refactor Utilities' CommonRequestStrings: Instead of an obsolescent string, store the code itself. This allows to benefit from senders and other refactoring tools. Also, it's impossible to compile invalid code. As you can see, I commented one line out as it contains a selector that is no longer present in modern Squeak. This change should not affect overall performance, as #commonRequestStrings keeps caching the result. Please note that when merging this commit into Trunk, a conflict with System-ct.1103 will be to solved manually. =============== Diff against System-mt.1116 =============== Item was added: + ----- Method: Utilities class>>commonRequestBlocks (in category 'common requests') ----- + commonRequestBlocks + + ^ { + [Utilities emergencyCollapse. + Utilities closeAllDebuggers. + RecentMessages default revertMostRecent]. + + [MCFileBasedRepository flushAllCaches]. + + [Sensor keyboard. + ParagraphEditor abandonChangeText. + Cursor normal show]. + + [CommandHistory resetAllHistory. + Project allInstancesDo: [:p | p displayDepth: 16]. + ScriptingSystem inspectFormDictionary. + Form fromUser bitEdit. + Display border: (0@0 extent: 640@480) width: 2]. + + [Undeclared inspect. + Undeclared removeUnreferencedKeys; inspect. + Transcript clear. + Utilities grabScreenAndSaveOnDisk. + FrameRateMorph new openInHand]. + + ["Utilities reconstructTextWindowsFromFileNamed: 'TW'." + Utilities storeTextWindowContentsToFileNamed: 'TW'. + ChangeSorter removeEmptyUnnamedChangeSets. + ChangeSorter reorderChangeSets]. + + [ActiveWorld installVectorVocabulary. + ActiveWorld abandonVocabularyPreference] + }! Item was changed: ----- Method: Utilities class>>initializeCommonRequestStrings (in category 'common requests') ----- initializeCommonRequestStrings "Initialize the common request strings, a directly-editable list of expressions that can be evaluated from the 'do...' menu." + CommonRequestStrings := StringHolder new contents: ( + String streamContents: [:stream | + self commonRequestBlocks + do: [:block | + block decompile statements + do: [:statement | + statement veryShortPrintOn: stream. + stream nextPut: $.] + separatedBy: [stream cr]] + separatedBy: [stream cr; nextPut: $-; cr]]) - CommonRequestStrings := StringHolder new contents: - 'Utilities emergencyCollapse. - Utilities closeAllDebuggers. - RecentMessages default revertMostRecent. - - - MCFileBasedRepository flushAllCaches - - - Sensor keyboard. - ParagraphEditor abandonChangeText. - Cursor normal show. - - - CommandHistory resetAllHistory. - Project allInstancesDo: [:p | p displayDepth: 16]. - ScriptingSystem inspectFormDictionary. - Form fromUser bitEdit. - Display border: (0@0 extent: 640@480) width: 2. - - - Undeclared inspect. - Undeclared removeUnreferencedKeys; inspect. - Transcript clear. - Utilities grabScreenAndSaveOnDisk. - FrameRateMorph new openInHand. - - - Utilities reconstructTextWindowsFromFileNamed: ''TW''. - Utilities storeTextWindowContentsToFileNamed: ''TW''. - ChangeSet removeEmptyUnnamedChangeSets. - ChangesOrganizer reorderChangeSets. - - - ActiveWorld installVectorVocabulary. - ActiveWorld abandonVocabularyPreference.' "Utilities initializeCommonRequestStrings"!

1 0

Etoys infested by deprecation warnings
by Nicola Mingotti 25 Oct '19

25 Oct '19

Hi, This evening I learnt the basic of Etoys doing the "Falling ellipse" example from the book "Squeak - Object-Oriented Design with Multimedia Applications" (Guzdial pg.164-172). Problem. There are so many deprecation warnings going through this simple exercise (in Squeak-5.2 #update 18232) that only a highly motivated person would be patient enough to kill/ignore all of them. For the moment I am not able to fix it myself, better I can do is to signal you the issue;) bye Nicola

6 12

The Inbox: Graphics-ct.424.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

A new version of Graphics was added to project The Inbox: http://source.squeak.org/inbox/Graphics-ct.424.mcz ==================== Summary ==================== Name: Graphics-ct.424 Author: ct Time: 25 October 2019, 5:53:01.196469 pm UUID: 1b6bc1e0-0b8f-3544-93c4-257657b42c1b Ancestors: Graphics-mt.422 Proposal: Support for a permanent, image-defined host window title Do "DisplayScreen defaultHostWindowTitle: 'Image sweet Image'", save your image and reopen it =============== Diff against Graphics-mt.422 =============== Item was changed: Form subclass: #DisplayScreen instanceVariableNames: 'clippingBox extraRegions' + classVariableNames: 'DefaultHostWindowTitle DeferringUpdates DisplayChangeSignature DisplayIsFullScreen ScreenSave' - classVariableNames: 'DeferringUpdates DisplayChangeSignature DisplayIsFullScreen ScreenSave' poolDictionaries: '' category: 'Graphics-Display Objects'! !DisplayScreen commentStamp: '<historical>' prior: 0! There is only one instance of me, Display. It is a global and is used to handle general user requests to deal with the whole display screen. Although I offer no protocol, my name provides a way to distinguish this special instance from all other Forms. This is useful, for example, in dealing with saving and restoring the system. To change the depth of your Display... Display newDepth: 16. Display newDepth: 8. Display newDepth: 1. Valid display depths are 1, 2, 4, 8, 16 and 32. It is suggested that you run with your monitors setting the same, for better speed and color fidelity. Note that this can add up to 4Mb for the Display form. Finally, note that newDepth: ends by executing a 'ControlManager restore' which currently terminates the active process, so nothing that follows in the doit will get executed. Depths 1, 2, 4 and 8 bits go through a color map to put color on the screen, but 16 and 32-bit color use the pixel values directly for RGB color (5 and 8 bits per, respectivlely). The color choice an be observed by executing Color fromUser in whatever depth you are using. ! Item was added: + ----- Method: DisplayScreen class>>defaultHostWindowTitle (in category 'host window access') ----- + defaultHostWindowTitle + + ^ DefaultHostWindowTitle! Item was added: + ----- Method: DisplayScreen class>>defaultHostWindowTitle: (in category 'host window access') ----- + defaultHostWindowTitle: aString + + DefaultHostWindowTitle := aString! Item was changed: ----- Method: DisplayScreen class>>startUp (in category 'snapshots') ----- startUp "DisplayScreen startUp" Display setExtent: self actualScreenSize depth: Display nativeDepth. + DefaultHostWindowTitle ifNotNil: [:title | + self hostWindowTitle: title]. Display beDisplay!

1 0

The Inbox: Tools-ct.910.mcz
by commits＠source.squeak.org 25 Oct '19

25 Oct '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.910.mcz ==================== Summary ==================== Name: Tools-ct.910 Author: ct Time: 25 October 2019, 1:00:13.846396 pm UUID: b10a85ef-63c1-524d-8943-93a23acac838 Ancestors: Tools-mt.909 Removes Blocks check from MethodFinder Due to several implementators of #value(:)?(value:)* and #cull(:)?(cull:)* we have got nowadays, this is an unnecessary restriction. Furthermore, it impedes maintenance. For more information, read http://forum.world.st/MethodFinder-Blocks-td5105421.html =============== Diff against Tools-mt.909 =============== Item was changed: Object subclass: #MethodFinder instanceVariableNames: 'data answers selector argMap thisData mapStage mapList expressions cachedClass cachedArgNum cachedSelectorLists' + classVariableNames: 'AddAndRemove Approved Dangerous' - classVariableNames: 'AddAndRemove Approved Blocks Dangerous' poolDictionaries: '' category: 'Tools-MethodFinder'! !MethodFinder commentStamp: '<historical>' prior: 0! Find a method in the system from a set of examples. Done by brute force, trying every possible selector. Errors are skipped over using ( [3 + 'xyz'] ifError: [^ false] ). Submit an array of the form ((data1 data2) answer (data1 data2) answer). MethodFinder methodFor: #( (4 3) 7 (0 5) 5 (5 5) 10). answer: 'data1 + data2' More generally, use the brace notation to construct live examples. The program tries data1 as the receiver, and tries all other permutations of the data for the receiver and args, and tries leaving out one argument, and uses all selectors data understands, and uses all selectors in all od data's superclasses. Floating point values must be precise to 0.01 percent, or (X * 0.0001). If you get an error, you have probably discovered a selector that needs to be removed from the Approved list. See MethodFinder.initialize. Please email the Squeak Team. Only considers 0, 1, 2, and 3 argument messages. The argument data may have 1 to 5 entries, but only a max of 4 used at a time. For now, we only test messages that use given number of args or one fewer. For example, this data (100 true 0.6) would test the receiver plus two args, and the receiver plus one arg, but not any other patterns. Three sets of selectors: Approved, AddAndRemove, and Blocks selectors. When testing a selector in AddAndRemove, deepCopy the receiver. We do not handle selectors that modify an argument (printOn: etc.). Blocks is a set of (selector argNumber) where that argument must be a block. For perform, the selector is tested. It must be in the Approved list. do: is not on the Approved list. It does not produce a result that can be tested. Type 'do' into the upper pane of the Selector Finder to find messages list that. [Later, allow the user to supply a block that tests the answer, not just the literal answer.] MethodFinder methodFor: { { true. [3]. [4]}. 3}. Later allow this to work without the blocks around 3 and 4.! Item was changed: ----- Method: MethodFinder class>>cleanUp: (in category 'class initialization') ----- cleanUp: aggressive Approved := nil. + AddAndRemove := nil.! - AddAndRemove := nil. - Blocks := nil.! Item was changed: ----- Method: MethodFinder>>initialize (in category 'initialize') ----- (excessive size, no diff calculated) Item was changed: ----- Method: MethodFinder>>initialize2 (in category 'initialize') ----- (excessive size, no diff calculated) Item was changed: ----- Method: MethodFinder>>testPerfect: (in category 'search') ----- testPerfect: aSelector "Try this selector!! Return true if it answers every example perfectly. Take the args in the order they are. Do not permute them. Survive errors. later cache arg lists." | sz argList val rec activeSel perform | "Transcript cr; show: aSelector. debug" perform := aSelector beginsWith: 'perform:'. sz := argMap size. 1 to: thisData size do: [:ii | "each example set of args" argList := (thisData at: ii) copyFrom: 2 to: sz. perform ifFalse: [activeSel := aSelector] ifTrue: [activeSel := argList first. "what will be performed" ((Approved includes: activeSel) or: [AddAndRemove includes: activeSel]) ifFalse: [^ false]. "not approved" aSelector == #perform:withArguments: ifTrue: [activeSel numArgs = (argList at: 2) basicSize "avoid error" ifFalse: [^ false]] ifFalse: [activeSel numArgs = (aSelector numArgs - 1) ifFalse: [^ false]]]. - 1 to: sz do: [:num | - (Blocks includes: (Array with: activeSel with: num)) ifTrue: [ - (argList at: num) isBlock ifFalse: [^ false]]]. rec := (AddAndRemove includes: activeSel) ifTrue: [(thisData at: ii) first isSymbol ifTrue: [^ false]. "vulnerable to modification" (thisData at: ii) first copyTwoLevel] "protect from damage" ifFalse: [(thisData at: ii) first]. val := [[rec perform: aSelector withArguments: argList] on: Deprecation do: [ :ex | ex resume ]] ifError: [:aString :aReceiver | "self test3." "self test2: (thisData at: ii)." ^ false]. "self test3." "self test2: (thisData at: ii)." ((answers at: ii) closeTo: val) ifFalse: [^ false]. ]. ^ true!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
29
Older →

Jump to page: