Squeak-dev October 2019

squeak-dev@lists.squeakfoundation.org

41 participants
284 discussions

When did it become a good idea for selected text to be enclosed by () instead of replaced by 9 ?
by tim Rowledge 06 Nov '19

06 Nov '19

In trying to see if anything had changed re WaveEditor etc I updated an image to update 16963. When I went to save this image a Squeak5.1-16963… I selected the last thre digits of the prior name (Squeak5.1-16549…) intending to type 963. Imagine my surprise - nay, alarm! - when I got ‘Squeak5.1-16(963) instead. Oh my, I said to myself, what has Pooh done now. As best I can work out this is a result of the change in TextEditor>enclose: that added ‘9’ some time ago (and which did not affect me since I normally turn off the annoying enclose stuff in preferences) combined with a more recent change to TextEditor>dispatchOnKeyboardEvent: wherein a use of TextEditor>enclose: was added near the end. I see two obviously related Preferences for enclosing text. I see this as a dangerous thing, because multiple preferences interacting on the same issue can cause chaos, not to say confusion. And every time a preference is added it is yet another sheaf of potential problems to test. So, yes, I can turn it off easily enough. But how could it ever be unsurprising to a user to get a(bc)d instead of the expected a9d ? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Fell out of the family tree.

6 6

[Discussion] Warning vs. Halt (or: "Why is a warning a notification?")
by Marcel Taeumel 04 Nov '19

04 Nov '19

Hi, there. At the moment, we have this hierarchy in Squeak's exception mechanism: Exception < Error Exception < Notification < Warning Exception < Halt Exception < UnhandledError < UnhandledWarning I think that something is conceptually wrong here. Notifications are supposed to be resumable and do nothing by default. Warnings, on the other hand, are resumable but interrupt the process by default. Like Halt does. Not now, but in the future, I would like to change it to something like this: Exception < Error Exception < Notification Exception < ResumableInterrupt < Warning Exception < ResumableInterrupt < Halt Exception < UnhandledError < UnhandledWarning Thoughts? Well, there are other notifications that interrupt the current process in a way: EnvironmentRequest, MCMergeResolutionRequest, ... Maybe my definition of "Notification" is wrong? Best, Marcel P.S.: Why is CurrentReadOnlySourceFiles an Exception but CurrentEnvironment is a Notification? Sigh....

4 5

Context>>#tempNames can raise Syntax Error
by Fabio Niephaus 04 Nov '19

04 Nov '19

Hi all, While debugging a failing Seaside test on Squeak trunk (see [1]), I learned that Context>>#tempNames can raise a syntax error. Here's a repro doIt: `Context allInstances collect: [:e | e tempNames]` Anyone willing to look into this? When I try to debug the "calling process", my image freezes... Cheers, Fabio [1] https://travis-ci.org/SeasideSt/Seaside/jobs/578335182#L2733

2 1

The Inbox: Chronology-Core-mt.50.mcz
by commits＠source.squeak.org 04 Nov '19

04 Nov '19

A new version of Chronology-Core was added to project The Inbox: http://source.squeak.org/inbox/Chronology-Core-mt.50.mcz ==================== Summary ==================== Name: Chronology-Core-mt.50 Author: mt Time: 30 October 2019, 10:25:14.294226 am UUID: f064aadc-0e62-174e-b97c-f70cc22a23f6 Ancestors: Chronology-Core-mt.49 Proposal to add GC pressure to #bench method. =============== Diff against Chronology-Core-mt.49 =============== Item was changed: ----- Method: BlockClosure>>benchFor: (in category '*chronology-core') ----- benchFor: aDuration "See how many times I can value within the given duration. I'll answer a meaningful description." + | startTime shouldRun count elapsedTime roundTo3Digits delay gcStart gcTime | - | startTime shouldRun count elapsedTime roundTo3Digits delay | roundTo3Digits := [:num | | rounded lowDigit | rounded := (num * 1000) rounded. "round to 1/1000" lowDigit := (rounded numberOfDigitsInBase: 10) - 3. "keep only first 3 digits" rounded := rounded roundTo:(10 raisedTo: lowDigit). (lowDigit >= 3 or: [rounded \\ 1000 = 0]) "display fractional part only when needed" ifTrue: [(rounded // 1000) asStringWithCommas] ifFalse: [(rounded / 1000.0) printString]]. delay := aDuration asDelay. count := 0. shouldRun := true. + Smalltalk garbageCollect. [ delay wait. shouldRun := false ] forkAt: Processor timingPriority - 1. startTime := Time millisecondClockValue. + gcStart := (Smalltalk vmParameterAt: 8) + (Smalltalk vmParameterAt: 10). [ shouldRun ] whileTrue: [ self value. count := count + 1 ]. elapsedTime := Time millisecondsSince: startTime. + gcTime := (Smalltalk vmParameterAt: 8) + (Smalltalk vmParameterAt: 10) - gcStart. ^(roundTo3Digits value: count * 1000 / elapsedTime) , ' per second.', (( #( (1e-3 'seconds') (1 'milliseconds') (1e3 'microseconds') (1e6 'nanoseconds') ) detect: [ :pair | elapsedTime * pair first >= count ] ifNone: [ #(1e9 'picoseconds') ]) in: [ :pair | ' {1} {2} per run.' format: { (roundTo3Digits value: elapsedTime * pair first / count). + pair second } ]), (' {1} % GC time.' format: {gcTime / elapsedTime * 100 roundTo: 0.0001})! - pair second } ])!

4 6

The Inbox: System-ct.1119.mcz
by commits＠source.squeak.org 02 Nov '19

02 Nov '19

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1119.mcz ==================== Summary ==================== Name: System-ct.1119 Author: ct Time: 26 October 2019, 10:00:59.779469 pm UUID: dc499ab1-dfe1-064c-a997-271a591d4b18 Ancestors: System-mt.1116 Adds convenience methods to change multiple preferences Usage example: Preferences setPreferences: { #(UIManager >> #openToolsAttachedToMouseCursor) join asSymbol -> false. #(Model >> #useColorfulWindows) join asSymbol -> false } during: [self notify: 'Carpe Squeak!'] =============== Diff against System-mt.1116 =============== Item was added: + ----- Method: Preferences class>>setPreferences: (in category 'get/set') ----- + setPreferences: associations + + associations associationsDo: [:association | + self setPreference: association key toValue: association value].! Item was added: + ----- Method: Preferences class>>setPreferences:during: (in category 'get/set') ----- + setPreferences: associations during: aBlock + "Changes the given values for the duration of aBlock" + + | values previousValues | + values := associations as: Dictionary. + previousValues := values associations collect: [:association | + association key -> (self valueOfFlag: association key)]. + self setPreferences: values. + ^ aBlock ensure: [ + self setPreferences: previousValues]!

3 5

The Trunk: System-mt.1093.mcz
by commits＠source.squeak.org 30 Oct '19

30 Oct '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1093.mcz ==================== Summary ==================== Name: System-mt.1093 Author: mt Time: 17 September 2019, 12:10:14.798406 pm UUID: 5eb2c78e-ce42-654d-b764-57fc1e4d0521 Ancestors: System-mt.1092 Refactors process debugging in general, which makes MVC debugging work again: - adds MorphicDebugger and MVCDebugger as subclasses of Debugger to untangle debugging for those different GUI frameworks - removes the intermediate role of UIManager for debugging purposes -- focus on Project, (Standard)ToolSet, and Process - treat unhandled warnings the same as unhandled errors, which is through the current ToolSet - let SyntaxError tool use tool builder - clarify #handle* and #debug* methods in ToolSet's 'debugging' category - adds comments to ToolSet and StandardToolSet =============== Diff against System-mt.1092 =============== Item was changed: + ----- Method: Project>>addDeferredUIMessage: (in category 'scheduling & debugging') ----- - ----- Method: Project>>addDeferredUIMessage: (in category 'scheduling') ----- addDeferredUIMessage: valuableObject "Arrange for valuableObject to be evaluated at a time when the user interface is in a coherent state." self subclassResponsibility! Item was removed: - ----- Method: Project>>debugMethod:forReceiver:inContext: (in category 'debugging') ----- - debugMethod: aCompiledMethod forReceiver: anObject inContext: aContextOrNil - "Just execute the method and return the result. We cannot know how interactive debugging works for arbitrary projects." - - ^ aCompiledMethod - valueWithReceiver: anObject - arguments: (aContextOrNil - ifNil: [#()] - ifNotNil: [{aContextOrNil}])! Item was added: + ----- Method: Project>>debuggerClass (in category 'scheduling & debugging') ----- + debuggerClass + + ^ self subclassResponsibility! Item was changed: + ----- Method: Project>>interruptName: (in category 'scheduling & debugging') ----- - ----- Method: Project>>interruptName: (in category 'debugging') ----- interruptName: labelString "Create a Notifier on the active scheduling process with the given label." ^ self subclassResponsibility ! Item was changed: + ----- Method: Project>>interruptName:preemptedProcess: (in category 'scheduling & debugging') ----- - ----- Method: Project>>interruptName:preemptedProcess: (in category 'debugging') ----- interruptName: labelString preemptedProcess: theInterruptedProcess "Create a Notifier on the active scheduling process with the given label." ^ self subclassResponsibility ! Item was added: + ----- Method: Project>>syntaxError: (in category 'scheduling & debugging') ----- + syntaxError: aSyntaxErrorNotification + + ^ ToolSet debugSyntaxError: aSyntaxErrorNotification! Item was changed: ----- Method: SmalltalkImage>>handleUserInterrupt (in category 'miscellaneous') ----- handleUserInterrupt Preferences cmdDotEnabled ifTrue: + [[ToolSet handleUserInterruptRequest: 'User Interrupt'] fork] - [[Project current interruptName: 'User Interrupt'] fork] ! Item was changed: ----- Method: SyntaxErrorNotification>>defaultAction (in category '*System-exceptionDescription') ----- defaultAction + ^ToolSet handleSyntaxError: self! - ^ToolSet debugSyntaxError: self! Item was removed: - ----- Method: ToolSet class>>debug:context:label:contents:fullView: (in category 'debugging') ----- - debug: aProcess context: aContext label: aString contents: contents fullView: aBool - "Open a debugger on the given process and context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[Processor terminateActive]. - ^self]. - ^self default debug: aProcess context: aContext label: aString contents: contents fullView: aBool! Item was added: + ----- Method: ToolSet class>>debugActiveProcessContext:label:contents: (in category 'debugging - convenience') ----- + debugActiveProcessContext: aContext label: aString contents: contents + + ^ self + debugProcess: Processor activeProcess + context: aContext + label: aString + contents: contents + fullView: false! Item was removed: - ----- Method: ToolSet class>>debugContext:label:contents: (in category 'debugging') ----- - debugContext: aContext label: aString contents: contents - "Open a debugger on the given context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[Processor terminateActive]. - ^self]. - ^self default debugContext: aContext label: aString contents: contents! Item was removed: - ----- Method: ToolSet class>>debugError: (in category 'debugging') ----- - debugError: anError - "Handle an otherwise unhandled error" - self default ifNil:[ | ctx | - Smalltalk - logSqueakError: anError description - inContext: (ctx := anError signalerContext) . - self inform: (anError description, String cr, ctx shortStack). - ^anError return]. - ^self default debugError: anError! Item was added: + ----- Method: ToolSet class>>debugInterruptedProcess:label: (in category 'debugging') ----- + debugInterruptedProcess: aSuspendedProcess label: aString + "Open a debugger on the given process, which is already suspended." + + ^ self default + ifNil: [(self confirm: 'Debugger request -- proceed?') ifFalse:[aSuspendedProcess terminate]] + ifNotNil: [:ts | ts debugInterruptedProcess: aSuspendedProcess label: aString]! Item was changed: ----- Method: ToolSet class>>debugMethod:forReceiver:inContext: (in category 'debugging') ----- debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext + ^ self default + ifNil: [ + self inform: 'Cannot debug method. It will just be executed.'. + aCompiledMethod + valueWithReceiver: anObject + arguments: (aContext ifNil: [#()] ifNotNil: [{aContext}])] + ifNotNil: [:ts | ts debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext]! - self default ifNil:[^ self inform: 'Cannot debug method.']. - ^self default debugMethod: aCompiledMethod forReceiver: anObject inContext: aContext - ! Item was added: + ----- Method: ToolSet class>>debugProcess:context:label:contents:fullView: (in category 'debugging') ----- + debugProcess: aProcess context: aContext label: aString contents: contents fullView: aBool + "Open a debugger on the given process, which might be active, suspended, or terminated." + + ^ self default + ifNil: [(self confirm: 'Debugger request -- proceed?') ifFalse: [Processor terminateActive]] + ifNotNil: [:ts | ts debugProcess: aProcess context: aContext label: aString contents: contents fullView: aBool]! Item was changed: ----- Method: ToolSet class>>debugSyntaxError: (in category 'debugging') ----- + debugSyntaxError: aSyntaxErrorNotification + "Opens a tool to let the user correct the syntax error, which then resumes the compiler process." + + ^ self default + ifNil: [Project uiManager edit: aSyntaxErrorNotification errorCode label: 'Syntax Error (read only)'] + ifNotNil: [:ts | ts debugSyntaxError: aSyntaxErrorNotification]! - debugSyntaxError: anError - "Handle a syntax error" - self default ifNil:[^self debugError: anError]. "handle as usual error" - ^self default debugSyntaxError: anError! Item was added: + ----- Method: ToolSet class>>handleError: (in category 'debugging - handlers') ----- + handleError: anError + "No exception handler caught the given error. Let the user handle that error through an interactive tool such as a debugger. + + THE ACTIVE PROCESS *IS* WHERE THE ERROR HAPPENED." + + ^ self default + ifNil: [ | ctx | + Smalltalk + logSqueakError: anError description + inContext: (ctx := anError signalerContext) . + self inform: (anError description, String cr, ctx shortStack). + anError return] + ifNotNil: [:ts | ts handleError: anError]! Item was added: + ----- Method: ToolSet class>>handleSyntaxError: (in category 'debugging - handlers') ----- + handleSyntaxError: anError + "A syntax error (notification) occurred while parsing and compiling source code. Usually, the compiling process suspends until the syntax error gets corrected. + + THE ACTIVE PROCESS *IS* THAT COMPILER PROCESS." + + ^ self default + ifNil: [self handleError: anError] + ifNotNil: [:ts | ts handleSyntaxError: anError]! Item was added: + ----- Method: ToolSet class>>handleUserInterruptRequest: (in category 'debugging - handlers') ----- + handleUserInterruptRequest: aString + "The user wants to interrupt a process, which might be unresponsive, to debug it. + + THE ACTIVE PROCESS *IS* A HELPER PROCESS with a priority higher than the preempted one. See EventSensor >> #userInterruptWatcher." + + ^ self default + ifNil: [self inform: 'No handler for user interrupts found.'] + ifNotNil: [:ts | ts handleUserInterruptRequest: aString]! Item was added: + ----- Method: ToolSet class>>handleWarning: (in category 'debugging - handlers') ----- + handleWarning: aWarning + "No exception handler caught the given warning. Let the user handle that warning through an interactive tool such as a debugger. + + THE ACTIVE PROCESS *IS* WHERE THE WARNING HAPPENED." + + ^ self default + ifNil: [ + self inform: (aWarning messageText, String cr, aWarning signalerContext shortStack). + aWarning resume] + ifNotNil: [:ts | ts handleWarning: aWarning]! Item was removed: - ----- Method: ToolSet class>>interrupt:label: (in category 'debugging') ----- - interrupt: aProcess label: aString - "Open a debugger on the given process and context." - self default ifNil:[ - (self confirm: 'Debugger request -- proceed?') - ifFalse:[aProcess terminate]. - ^self]. - ^self default interrupt: aProcess label: aString! Item was changed: ----- Method: UnhandledError>>defaultAction (in category '*System-priv handling') ----- defaultAction "The current computation is terminated. The cause of the error should be logged or reported to the user. If the program is operating in an interactive debugging environment the computation should be suspended and the debugger activated." + ^ToolSet handleError: self exception! - ^ToolSet debugError: self exception! Item was changed: ----- Method: UnhandledWarning>>defaultAction (in category '*System-priv handling') ----- defaultAction + ^ ToolSet handleWarning: self exception! - ^ ToolSet - debugContext: self exception signalerContext - label: 'Warning' - contents: self exception messageText , '\\Select Proceed to continue, or close this window to cancel the operation.' withCRs! Item was changed: ----- Method: WrappedBreakpoint>>run:with:in: (in category 'evaluation') ----- run: aSelector with: anArray in: aReceiver | process | process := Process forContext: (Context sender: thisContext sender receiver: aReceiver method: method arguments: anArray) priority: Processor activeProcess priority. ToolSet + debugProcess: process - debug: process context: process suspendedContext label: 'Breakpoint in ' , method methodClass name , '>>#' , method selector contents: nil fullView: true. Project current spawnNewProcessIfThisIsUI: Processor activeProcess. thisContext swapSender: nil. Processor activeProcess terminate!

6 26

The Trunk: Tools-mt.910.mcz
by commits＠source.squeak.org 30 Oct '19

30 Oct '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.910.mcz ==================== Summary ==================== Name: Tools-mt.910 Author: mt Time: 29 October 2019, 12:39:01.998604 pm UUID: 981eb775-0636-d744-b7bf-8f13d72351b1 Ancestors: Tools-mt.909 Fixes (a regression in) list selection in change-list tool. It is not the job of the model to implement toggle in a multi-selection setting. The model only has to react to index selector and selection-list selectors. =============== Diff against Tools-mt.909 =============== Item was changed: ----- Method: ChangeList>>listSelectionAt:put: (in category 'viewing access') ----- listSelectionAt: index put: value + listSelections at: index put: value. + self changed: #listIndex.! - ^ listSelections at: index put: value! Item was changed: ----- Method: ChangeList>>toggleListIndex: (in category 'viewing access') ----- toggleListIndex: newListIndex + listIndex = newListIndex ifTrue: [^ self]. - listIndex ~= 0 ifTrue: [listSelections at: listIndex put: false]. - newListIndex ~= 0 ifTrue: [listSelections at: newListIndex put: true]. listIndex := newListIndex. + self changed: #listIndex. self contentsChanged!

3 2

The Trunk: Tools-mt.911.mcz
by commits＠source.squeak.org 30 Oct '19

30 Oct '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.911.mcz ==================== Summary ==================== Name: Tools-mt.911 Author: mt Time: 30 October 2019, 9:16:36.005226 am UUID: 14795473-427f-2c4d-81b1-79db8f78296f Ancestors: Tools-mt.910 *at:put: should always return the stored value. =============== Diff against Tools-mt.910 =============== Item was changed: ----- Method: ChangeList>>listSelectionAt:put: (in category 'viewing access') ----- listSelectionAt: index put: value listSelections at: index put: value. + self changed: #listIndex. + ^ value! - self changed: #listIndex.!

1 0

The Trunk: Morphic-mt.1583.mcz
by commits＠source.squeak.org 29 Oct '19

29 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1583.mcz ==================== Summary ==================== Name: Morphic-mt.1583 Author: mt Time: 29 October 2019, 3:09:10.326172 pm UUID: 2724b1c3-9a13-1c4f-811f-a5bbc8ed76e1 Ancestors: Morphic-mt.1582 Make it possible to recover from (deprecation) warnings in important drawing methods. See http://forum.world.st/The-Trunk-System-mt-1093-mcz-tp5103937p5106420.html =============== Diff against Morphic-mt.1582 =============== Item was changed: ----- Method: WorldState>>displayWorldSafely: (in category 'update cycle') ----- displayWorldSafely: aWorld "Update this world's display and keep track of errors during draw methods." | finished classesWithErrors | finished := false. [finished] whileFalse: [ + [aWorld displayWorld. finished := true] on: Error, Halt, Warning do: [:ex | - [aWorld displayWorld. finished := true] on: Error, Halt do: [:ex | "Handle a drawing error" | err rcvr errCtx errMorph | err := ex description. rcvr := ex receiver. errCtx := thisContext. [ errCtx := errCtx sender. "Search the sender chain to find the morph causing the problem" [errCtx notNil and:[(errCtx receiver isMorph) not]] whileTrue:[errCtx := errCtx sender]. "If we're at the root of the context chain then we have a fatal drawing problem" errCtx ifNil:[^Project current fatalDrawingError: err]. errMorph := errCtx receiver. "If the morph causing the problem has already the #drawError flag set, then search for the next morph above in the caller chain." errMorph hasProperty: #errorOnDraw ] whileTrue. errMorph setProperty: #errorOnDraw toValue: true. "Catch all errors, one for each receiver class." classesWithErrors ifNil: [classesWithErrors := IdentitySet new]. (classesWithErrors includes: rcvr class) ifFalse: [ classesWithErrors add: rcvr class. ToolSet debugException: ex]. "Repaint all to catch all errors now and not if the debugger will appear." aWorld fullRepaintNeeded. ]].!

1 0

The Inbox: Files-dtl.184.mcz
by commits＠source.squeak.org 28 Oct '19

28 Oct '19

David T. Lewis uploaded a new version of Files to project The Inbox: http://source.squeak.org/inbox/Files-dtl.184.mcz ==================== Summary ==================== Name: Files-dtl.184 Author: dtl Time: 24 October 2019, 10:15:34.856587 pm UUID: cfa02841-644b-49cb-b3f2-a0eb1b36707b Ancestors: Files-pre.183 Provide error handling for #adoptInstance in StandardFileStream>>binary to provide pre-Spur behavior when running on a V3 image. Prior to Spur, class ByteArray cannot adopt an instance of ByteString, so use #asByteArray instead. Resolves the only remaining difference for package Files when running on either Spur or V3 images. The packages with significant Spur/V3 differences (excluding unit tests) are now Collections, Compiler, Kernel, and System. See www.squeaksource.com/TrunkUpdateStreamV3 for verification. =============== Diff against Files-pre.183 =============== Item was changed: ----- Method: StandardFileStream>>binary (in category 'properties-setting') ----- binary "Read and/or write in binary mode." buffer1 ifNil: [ buffer1 := ByteArray new: 1 ] + ifNotNil: [ [ ByteArray adoptInstance: buffer1 ] + on: Error "V3 image" + do: [ buffer1 := ByteArray new: 1 ] ]. + collection ifNotNil: [ [ ByteArray adoptInstance: collection ] + on: Error + do: [ collection := collection asByteArray ] ]. - ifNotNil: [ ByteArray adoptInstance: buffer1 ]. - collection ifNotNil: [ ByteArray adoptInstance: collection ]. lastWritten ifNotNil: [ lastWritten isCharacter ifTrue: [ lastWritten := lastWritten asInteger ] ]!

3 4

← Newer
1
2
3
4
5
6
7
8
...
29
Older →

Jump to page: