[OpenSmalltalk/opensmalltalk-vm] Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575 (#576)
Fix for bug:
Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575
Tested on arm32 Raspberry Pi 3 with Raspberry Pi OS (no X11) and on arm64 Le Potato (AML-S905S-XX) with Armbian OS.
Nota Bene: The include file ordering fix for arm64 does not seem to have been applied yet to the 32 bit platform.
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/576
-- Commit Summary --
* Works on RasPi 3 with RasPi Linux * for RasPi3
-- File Changes --
M build.linux32ARMv6/squeak.cog.spur/build/mvm (3) M platforms/unix/vm-display-fbdev/sqUnixEvdevKeyMouse.c (7) M platforms/unix/vm-display-fbdev/sqUnixFBDev.c (2)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/576.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/576.diff
@KenDickey pushed 1 commit.
5ef63ba3550921f8891ad4c9f4947807dbc1bd1f Help text now matches current
@KenDickey pushed 2 commits.
fe56d0620a1f12019206681ab2f7ffca3bf5edc5 -kbmap help b5011d4ea834cdd86584a610b7824933109806e2 DEBUG_EVENTS
Notes: [A] Given the superannuated nature of the code, it would be good to eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV guard was inverted so as to make this code path the default code. Then this flag would no longer be required by the normal build. IMHO, this would be less confusing.
[B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards.
On Tue, Jul 27, 2021 at 12:32 PM Ken Dickey ***@***.***> wrote:
Notes: [A] Given the superannuated nature of the code, it would be good to eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV guard was inverted so as to make this code path the default code. Then this flag would no longer be required by the normal build. IMHO, this would be less confusing.
If it works for you, go for it. You're the one driving fb-dev support these days. Make it the way you want it.
[B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/576#issuecomment-887778145, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY5VUELDOJTHIPCDSCWNSTTZ4CUHANCNFSM5A6442CQ .
@KenDickey pushed 1 commit.
969f58704954dd914fa7d10a387feac8cfb65353 elide -DUSEEVDEV for (unused) -DNOEVDEV
@KenDickey pushed 1 commit.
abb5353795cdfb091b65e20b07698506ee2ff2c5 linux32ARMv6
Elided USEEVDEV flag & fixes a few nits. Tested mvm's & working on: Aarch64/arm64 [LePotato/Armbian] squeak.cog.spur/build squeak.cog.spur/build.debug Arm32 [RPi3/Raspberry Pi OS] squeak.cog.spur/build squeak.cog.spur/build.debug
Looks ready to integrate..
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Ken Dickey