We used to use MAXHOSTNAMELEN, but that is 64 on most Linuxen and might be differen w/ or w/o POSIX compliance. We now use the definitions from and implications by DNS itself.
Now, we can
``` WebClient httpGet: 'http://theofficialabsolutelongestdomainnameregisteredontheworldwideweb.inter...; ```
Fixes #619 You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/635
-- Commit Summary --
* [Unix/Sockets] Fix Resolution of FQDNs >64 chars
-- File Changes --
M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c (45)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/635.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/635.diff
Merged #635 into Cog.
The only change I would make would be to add a comment at the end of #define FQDN_LEN 253 to have it read #define FQDN_LEN 253 // FullyQualifiedDomainName or put it in the comment. I had to think for a few seconds before I worked out what FQDN stood for. Take away that pain :-)
Sorry :D I figure(d) that fqdn is a very well known concept around DNS. Maybe it is sufficient to expand FQDn in the comment above it?
On May 26, 2022, at 1:09 PM, Tobias Pape ***@***.***> wrote:
Sorry :D I figure(d) that fqdn is a very well known concept around DNS. Maybe it is sufficient to expand FQDn in the comment above it?
Yes, that will work :-)
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.
vm-dev@lists.squeakfoundation.org