Previously validMask = -1 was considered an error. Now validMask < 0 is considered an error and the value is returned to the image with primitiveFailForOSError().
This is more robust against word length in the VM and provides a general mechanism for the plugin to provide error information back to the image. You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/278
-- Commit Summary --
* 274: Update primitiveFileStdioHandles error handling.
-- File Changes --
M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c (3) M platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c (3) M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c (3) M src/plugins/FilePlugin/FilePlugin.c (22)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/278.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/278.diff
Merged #278 into Cog.
vm-dev@lists.squeakfoundation.org