[OpenSmalltalk/opensmalltalk-vm] vm-display-X11: Fix scale factor detection in headless and no-display mode (PR #626)
Closes #625. You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/626
-- Commit Summary --
* vm-display-X11: Fix scale factor detection in headless and no-display mode
-- File Changes --
M platforms/unix/vm-display-X11/sqUnixX11Scale.c (7)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/626.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/626.diff
Hmm... I don't like this approach. There are currently only 4 uses of the expression`!stDisplay` in "platforms/unix" and they all just verify initialization, not that headless mode. So, this is the wrong "concept" to use here.
Instead, I will go with the already used (but partially missing) `headless || !isConnectedToXServer` checks as suggested in #625.
Superseded by https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2d7105db755928fd908...
Closed #626.
vm-dev@lists.squeakfoundation.org
-
Christoph Thiede -
Marcel Taeumel