[OpenSmalltalk/opensmalltalk-vm] remove emulation of single button mouse on Windows and Linux (#362)
fixes #361 You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/362
-- Commit Summary --
* remove emulation of single button mouse on Windows and Linux
-- File Changes --
M platforms/unix/vm/sqUnixEvent.c (11) M platforms/win32/vm/sqWin32Window.c (8)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/362.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/362.diff
Merged #362 into Cog.
On 29.01.2019, at 11:02, Esteban Lorenzano notifications@github.com wrote:
Merged #362 into Cog.
Wait what? I don't remember a discussion about this quite far-reaching change…
Does that mean the platforms drift even further apart for event handling? -t
On Tue, 29 Jan 2019 at 18:20, Tobias Pape Das.Linux@gmx.de wrote:
On 29.01.2019, at 11:02, Esteban Lorenzano notifications@github.com
wrote:
Merged #362 into Cog.
Wait what? I don't remember a discussion about this quite far-reaching change…
My impression is that the PR was there for 2 days and the subject seems fairly clear... "[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] remove emulation of single button mouse on Windows and Linux (#362)"
so it was open for discussion, but no one cared to comment. Or are you not receiving PR emails and something needs to be looked at there?
Does that mean the platforms drift even further apart for event handling?
So lets discuss. What are the pros/cons? For me, its purpose to fix Issue #361 seems reasonable...
The Windows and Linux VM are still trying to emulate the right mouse
button with Ctrl+LMB for
compatibility with the old Mac emulation of RMB on single-button mouse.
This completely
prevents any reasonable standard usage of Ctlr button on such platforms
(like selecting multiple items lists etc.)
But I'm not clear on the behaviour. Is the CTRL key currently being swallowed so that a single button mouse can emulate a three button mouse? Where are single button mice being used today?
cheers -ben
Hi
On 29.01.2019, at 14:31, Ben Coman btc@openInWorld.com wrote:
On Tue, 29 Jan 2019 at 18:20, Tobias Pape Das.Linux@gmx.de wrote:
On 29.01.2019, at 11:02, Esteban Lorenzano notifications@github.com wrote:
Merged #362 into Cog.
Wait what? I don't remember a discussion about this quite far-reaching change…
Sorry for the delay
My impression is that the PR was there for 2 days and the subject seems fairly clear... "[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] remove emulation of single button mouse on Windows and Linux (#362)"
so it was open for discussion, but no one cared to comment. Or are you not receiving PR emails and something needs to be looked at there?
The point is that this is a behavior that has been like that for quite a long time. Just killing it within 3 days is a bit quick.
I see that no-one yet responded, so apparently, yet the interest is quite low
Does that mean the platforms drift even further apart for event handling?
So lets discuss. What are the pros/cons? For me, its purpose to fix Issue #361 seems reasonable...
For me, too.
The Windows and Linux VM are still trying to emulate the right mouse button with Ctrl+LMB for compatibility with the old Mac emulation of RMB on single-button mouse. This completely prevents any reasonable standard usage of Ctlr button on such platforms (like selecting multiple items lists etc.)
But I'm not clear on the behaviour. Is the CTRL key currently being swallowed so that a single button mouse can emulate a three button mouse? Where are single button mice being used today?
My laptop's touchpad only can deliver two mousebuttons reliably… and I've seen other touchpad with only one button tho.
Best regards -Tobias
vm-dev@lists.squeakfoundation.org
-
Ben Coman -
Esteban Lorenzano -
Pavel Krivanek
-
Tobias Pape