You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/255
-- Commit Summary --
* another try to properly build libgit2 * temporal line to verify the result of libgit2 build * now is ssh2 what's not there * trying adding dependencies * maybe not all those ;) * another try? * you like more this one? * the problems of copy&pasting * restore dependencies but it *shouldn't* be necessary :( * maybe setting LD_FLAGS explicit? * more to force libssh2 directory * Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into Cog * still working on compile lingit2 with libssh2
-- File Changes --
M .travis_install.sh (3) M build.linux32x86/third-party/Makefile.libgit2 (11)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/255.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/255.diff
@estebanlm pushed 1 commit.
cd2359e remove invisible chars
this PR should be ready to integrate, but it is failing on sista builds (no related with my changes). Con someone take a look? Should I integrate anyway?
akgrant43 commented on this pull request.
@@ -43,7 +43,8 @@ elif [[ "${ARCH}" = "linux32x86" ]]; then
libaudio-dev:i386 \ gcc-multilib \ uuid-dev:i386 \ - libcurl3-dev:i386 + libcurl4-openssl-dev:i386 \ + libssh2-1-dev:i386
Are installing:
- libssh2-1-dev:i386 - libcurl4-openssl-dev:i386
an artefact of trying to figure out this issue, or really required? If they are required, should the 64 bit libraries be added as well (and why isn't the 64 bit version of libcurl3 loaded? :-))
estebanlm commented on this pull request.
@@ -43,7 +43,8 @@ elif [[ "${ARCH}" = "linux32x86" ]]; then
libaudio-dev:i386 \ gcc-multilib \ uuid-dev:i386 \ - libcurl3-dev:i386 + libcurl4-openssl-dev:i386 \ + libssh2-1-dev:i386
uhm, yes... those are remainders of me trying to solve the problem. probably not needed :)
estebanlm commented on this pull request.
@@ -56,6 +56,7 @@ install: $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
cp -d $$each $(THIRDPARTYINSTALLDIR); \ fi \ done + ldd $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
technically, this is not needed anymore either (I put it to see the bindings of libgit2 to ensure it was linking libssh2). Anyway since this can break again I would keep it.
akgrant43 commented on this pull request.
@@ -56,6 +56,7 @@ install: $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
cp -d $$each $(THIRDPARTYINSTALLDIR); \ fi \ done + ldd $(THIRDPARTYLIBDIR)/$(LIBGIT2LIBNAME)
Exactly why I didn't comment here. :-)
meh, I'm going to accept it anyway, since sista builds are also failing in Cog branch
Merged #255.
vm-dev@lists.squeakfoundation.org
-
akgrant43 -
Esteban Lorenzano